In `EventListeners.css` I added `width: 100%` to the `.event-listener-label` to increase the width of the clickable area.
Differential Revision: https://phabricator.services.mozilla.com/D39500
--HG--
extra : moz-landing-system : lando
The reference isn't used within the component itself,
and is available in the webConsoleUI.
Callsites are updated.
Differential Revision: https://phabricator.services.mozilla.com/D39505
--HG--
extra : moz-landing-system : lando
There's no reason it should be JsTerm's responsability
to clear the output node.
Differential Revision: https://phabricator.services.mozilla.com/D39508
--HG--
extra : moz-landing-system : lando
In the last patch of this series, I forgot to sync `remoteWebNavigationImpl`
state in the progress listener. This patch corrects that.
Differential Revision: https://phabricator.services.mozilla.com/D39395
--HG--
extra : moz-landing-system : lando
Some failures crept in and out after my last sets of annotations landed. This
patch updates most of the annotations to deal with them.
MANUAL PUSH: Lando won't let me land.
Differential Revision: https://phabricator.services.mozilla.com/D39462
--HG--
extra : rebase_source : 4cfccf95c5bb2521533a9f5c4c25d67f414fb6f5
extra : histedit_source : c19187a3b3002e0eebdd809738b57641e1e432cd
The test is supposed that the document is not scalable at all when
"minimum-scale=maximum-scale" is set in the viewport meta content, but it's
actually invalid. A correct content is assumed "minimum-scale=1,maximum-scale=1"
so that the document is not scaled at all.
The reason why this check has passed is that "user-scalable=no" which is set
right before this check remains in cache so that the content of the meta
viewport becomes "user-scalable=no,minimum-scale=maximum-scale" which means the
document is not scalable. But we are going to fix this weird behavior in this
commit series so that we are no longer able to rely on the cached
"user-scalable=no" value.
Differential Revision: https://phabricator.services.mozilla.com/D38919
--HG--
extra : moz-landing-system : lando
The fronts are destroyed when the toolbox closes and when a front is destroyed,
all its listeners are removed. So there is no real value in trying to unregister
them. On top of that, this destroy method is called by Inspector.destroy
and doesn't wait for its completion.
Differential Revision: https://phabricator.services.mozilla.com/D39302
--HG--
extra : moz-landing-system : lando
This code in ToolSidebar.destroy looks dead as there shouldn't be any sidebar
loaded in distinct iframes anymore. So we are not trying to call sidebars destroy
from here anymore. Instead, it is being done from Inspector.destroy, via the _panels
Map.
Differential Revision: https://phabricator.services.mozilla.com/D39301
--HG--
extra : moz-landing-system : lando
Depends on D39335
Looking in details at get(), the implementation can also be simplified
Differential Revision: https://phabricator.services.mozilla.com/D39338
--HG--
rename : devtools/shared/webconsole/parser.js => devtools/shared/webconsole/parser-helper.js
extra : moz-landing-system : lando
We were displaying result.value.throw if result.value.return
was falsy. But it can happen that a getter does return a
falsy value, and we want to display it.
So now we turn the expression the other way around, we first
check result.value.throw, and then default to result.value.return.
A mochitest is added to ensure we hav expected value for different
getters returning falsy values.
Differential Revision: https://phabricator.services.mozilla.com/D39136
--HG--
extra : moz-landing-system : lando
The diagram we had was outdated. We delete
the image, and add 2 ascii diagrams that
reflect the current architecture:
- one for the react part
- one for the non-react part
The style of the page is modified so diagrams can take
the whole horizontal space if needed.
Differential Revision: https://phabricator.services.mozilla.com/D39157
--HG--
extra : moz-landing-system : lando
This avoids intermittent leaks in aboutdebugging tests relying on about:devtools-toolbox
Differential Revision: https://phabricator.services.mozilla.com/D39174
--HG--
extra : moz-landing-system : lando
As part of bug 1510569, the majority of the `nsIWebProgress` event listeners
have moved from the `WebProgressChild`/`RemoteWebProgress` to the
`BrowserChild`/`BrowserParent`. In responsive design mode, the
`RemoteWebProgress` previously would update the state of the `<iframe
mozbrowser>` with document URI and title which would be mirrored back to the
`<xul:browser>` when leaving RDM. However, the event handlers in the
`BrowserParent` call directly into the `<xul:browser>`, skipping the `<iframe
mozbrowser>` entirely. Therefore, when RDM is shut down, old state will be
mirroed to the `<xul:browser>`, leaving it in an inconsistent state. We now
mirror the state from the `<xul:browser>` to the `<iframe mozbrowser>` with an
`nsIWebProgressListener` so that the `<iframe mozbrowser>` will not clobber the
`<xul:browser>`'s state when leaving RDM.
Differential Revision: https://phabricator.services.mozilla.com/D38918
--HG--
extra : moz-landing-system : lando
test_bug819670_getter_throws.html:
Previously, the document context inspected in the console was the test
harness XULDocument, but now it will be an HTMLDocument. Update the
checks to make sure the inspected object has the same own properties as
the test documents own properties.
other tests:
Simply replace the expected document type.
Differential Revision: https://phabricator.services.mozilla.com/D38695
--HG--
extra : moz-landing-system : lando
Depends on D38620
json5 is a much bigger library than JSOL but it doesn't rely on any eval-like code.
It should provide similar features, and testing locally it seems to work as expected.
Differential Revision: https://phabricator.services.mozilla.com/D38515
--HG--
extra : moz-landing-system : lando
Depends on D38619
The new version of JSZip doesn't rely on any eval like code.
Differential Revision: https://phabricator.services.mozilla.com/D38517
--HG--
extra : moz-landing-system : lando
Depends on D38618
The template() helper seems not used in devtools so I removed it here.
If we could generate a bundle of lodash without this method from the start that would be great.
Differential Revision: https://phabricator.services.mozilla.com/D38516
--HG--
extra : moz-landing-system : lando
Depends on D38617
We should no longer use eval-like code in privileged modules
Differential Revision: https://phabricator.services.mozilla.com/D38513
--HG--
extra : moz-landing-system : lando
The template is used in one of the page, but the
plugin wasn't installed, so Gitbook would fail
generating the doc.
Differential Revision: https://phabricator.services.mozilla.com/D39156
--HG--
extra : moz-landing-system : lando
The current auto height and auto width tests were not asserting the proper element.
Differential Revision: https://phabricator.services.mozilla.com/D39102
--HG--
extra : moz-landing-system : lando
Support for coping link location from within the Console panel (through the context menu) can be extended and cover learn more links too.
Differential Revision: https://phabricator.services.mozilla.com/D38546
--HG--
extra : moz-landing-system : lando
**NOTE: This depends on D35513, so if it has not landed yet, please `arc patch D35513` before patching this one on top.**
- `.devtools-button` styles in `common.css` are kinda broken , so I decided to roll out our own button component (`UIButton`) after consulting with Victoria colors, sizes, etc. The other downside to selectors in `common.css` is that they can have a high specificity :(
- Victoria said to use the "micro" style from Photon as the default style for buttons in the panels. So I created an even smaller "micro" styles (very similar to `.devtools-togglebutton`) for when we need smaller buttons.
- I created some light/dark variables in our stylesheets instead of on `variables.css` because `--theme-button-background` was already taken (only used in a single panel, but still…). Maybe after the buttons are fixed globally in the common folder, we could use the variables there. In the meantime, to avoid losing more time, I rolled out our own vars here.
Differential Revision: https://phabricator.services.mozilla.com/D37883
--HG--
extra : moz-landing-system : lando
The patch for Bug 724505 changed the return of `prettifyCSS()` from a string to an object and the reference in the StyleRuleActor.getRuleText() was not updated. This patch fixes this and introduces a test.
Differential Revision: https://phabricator.services.mozilla.com/D38673
--HG--
extra : moz-landing-system : lando
**NOTE: This depends on D35513, so if it has not landed yet, please `arc patch D35513` before patching this one on top.**
- `.devtools-button` styles in `common.css` are kinda broken , so I decided to roll out our own button component (`UIButton`) after consulting with Victoria colors, sizes, etc. The other downside to selectors in `common.css` is that they can have a high specificity :(
- Victoria said to use the "micro" style from Photon as the default style for buttons in the panels. So I created an even smaller "micro" styles (very similar to `.devtools-togglebutton`) for when we need smaller buttons.
- I created some light/dark variables in our stylesheets instead of on `variables.css` because `--theme-button-background` was already taken (only used in a single panel, but still…). Maybe after the buttons are fixed globally in the common folder, we could use the variables there. In the meantime, to avoid losing more time, I rolled out our own vars here.
Differential Revision: https://phabricator.services.mozilla.com/D37883
--HG--
extra : moz-landing-system : lando
When a test crashes, the harness skips all of the remaining tests in the
directory. That means that with crashes skipped, we now try to run a whole lot
more tests than we did before, and a lot of them fail under Fission.
This patch adds annotations to the new failures that show up after part 1.
Differential Revision: https://phabricator.services.mozilla.com/D38726
--HG--
extra : rebase_source : 292157039c88fc615f5de41679e96e72766ac4db
I added `-moz-user-select: none;` to the `.badge` class in devtools/client/accessibility/accessibility.css .
Differential Revision: https://phabricator.services.mozilla.com/D37730
--HG--
extra : moz-landing-system : lando
In `Breakpoint.js` I added an if else statement to the function `addBreakpoint()` to add/remove class "breakpoint-disabled" depending on the value of `breakpoint.disabled`. I then added a selector in `Editor.css` to set `color: blue`.
Differential Revision: https://phabricator.services.mozilla.com/D38017
--HG--
extra : moz-landing-system : lando
There is no guarantee that any RDP request will be completed when the toolbox
closes, so that we should do the cleanup from the actor side if anything
needs to be stopped or removed.
Differential Revision: https://phabricator.services.mozilla.com/D38371
--HG--
extra : moz-landing-system : lando
This was kept to support old xul addons. All mozilla-central usages
have been removed and now uses Loader.jsm to get access to this module.
Differential Revision: https://phabricator.services.mozilla.com/D38321
--HG--
extra : moz-landing-system : lando
We used to have another provider which would load module via file:// URI,
directly from the disk. But the progress on artifact builds and ./mach build faster
made this obsolete and has been removed a long time ago.
We still have a lot of abstraction to support this non-existent feature.
Differential Revision: https://phabricator.services.mozilla.com/D38284
--HG--
extra : moz-landing-system : lando
The rest was legacy code to support old xul add-ons.
All mozilla-central code used to be refactored, but a few places
were still using the old codepaths.
Differential Revision: https://phabricator.services.mozilla.com/D38283
--HG--
extra : moz-landing-system : lando
A test is added to ensure this is fixed properly.
We also fix the Array previewer to properly return
undefined for unknown array properties, rather than null.
Differential Revision: https://phabricator.services.mozilla.com/D38467
--HG--
extra : moz-landing-system : lando
The file was included in the index.html and was used
to create the WebConsoleWrapper.
We can directly create it from webconsole-ui.js and
not have this unusual mechanism.
Differential Revision: https://phabricator.services.mozilla.com/D38456
--HG--
extra : moz-landing-system : lando
If user clicks gutter to add a breakpoint in tab of a blackboxed file, the file should be un-blackboxed.
Differential Revision: https://phabricator.services.mozilla.com/D38198
--HG--
extra : moz-landing-system : lando
This shouldn't be JSTerm's responsability to call
this function. Furthermore, the function clear
some references in the WebConsoleFront, which are
going to be destroyed anyway.
Differential Revision: https://phabricator.services.mozilla.com/D38614
--HG--
extra : moz-landing-system : lando
The function is only called from the context-menu,
where we already have all the references we need.
So we can move the function code directly in the
menu item callback.
Differential Revision: https://phabricator.services.mozilla.com/D38613
--HG--
extra : moz-landing-system : lando
Moved network monitor actor files:
network-monitor.js
network-event.js
into devtools/server/actors/network-monitor directory.
And updated moz.build files presented in related directories.
Differential Revision: https://phabricator.services.mozilla.com/D38219
--HG--
rename : devtools/server/actors/network-event.js => devtools/server/actors/network-monitor/network-event.js
rename : devtools/server/actors/network-monitor.js => devtools/server/actors/network-monitor/network-monitor.js
extra : moz-landing-system : lando
We add a GridElementWidthResizer to handle the editor width.
The width is then persisted in a pref.
A test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D37687
--HG--
extra : moz-landing-system : lando
We need this in the console to put the borders on the
right position, depending on the NotificationBox place.
Differential Revision: https://phabricator.services.mozilla.com/D38039
--HG--
extra : moz-landing-system : lando
Since we now have a GridElementWidthResizer element, we can
get rid of the SplitBox wrapping the SideBar, and have all
major elements as child of the App element, controlled by
a CSS Grid.
This makes it easy to change the console layout when toggling
the editor mode (re-ordering element in JS, changing the CSS
grid templates, and placing the element in different areas).
This also means we can take advantage of subgrid to align
the sidebar toolbar with the filter bar for example.
As the part of the stylesheet dedicated to layout grew, it
made sense to have it all in a separate stylesheet, App.css,
that lives next to the App component.
Differential Revision: https://phabricator.services.mozilla.com/D38038
--HG--
rename : devtools/client/themes/webconsole.css => devtools/client/webconsole/components/App.css
extra : moz-landing-system : lando
Adding a new opcional property to Frame.js, messageSource, which will allows us to know the source of the Message. We will be using this property to display the correct tooltip message.
Differential Revision: https://phabricator.services.mozilla.com/D38139
--HG--
extra : moz-landing-system : lando
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.
There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.
Differential Revision: https://phabricator.services.mozilla.com/D38247
--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
We can speed up the getType function by changing the dataType into an object from an array.
That way we avoid looping looking for the matching tagName and namespaceURI and access the typeData directly by their tagName.
Differential Revision: https://phabricator.services.mozilla.com/D38196
The button display the same icon that will be used
in the console input when in inline-mode to toggle
the editor mode, active.
A test is added to ensure the button works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D38622
--HG--
rename : browser/themes/shared/icons/sidebars.svg => devtools/client/themes/images/webconsole/editor.svg
extra : moz-landing-system : lando
When clicking and selecting source text on a collapsible message, the message expansion is toggled after releasing the mouse
Differential Revision: https://phabricator.services.mozilla.com/D37607
--HG--
extra : moz-landing-system : lando
MANUAL PUSH: Lando gives me strange errors and no one is around in #lando to help diagnose the problem.
--HG--
extra : rebase_source : 3701625298b2647d8cef671d75fdda4340fb43b1
extra : histedit_source : c2ea99a43942a6dcf7bd5b527b87387b03d38151
Moved network monitor actor files:
network-monitor.js
network-event.js
into devtools/server/actors/network-monitor directory.
And updated moz.build files presented in related directories.
Differential Revision: https://phabricator.services.mozilla.com/D38219
--HG--
rename : devtools/server/actors/network-event.js => devtools/server/actors/network-monitor/network-event.js
rename : devtools/server/actors/network-monitor.js => devtools/server/actors/network-monitor/network-monitor.js
extra : moz-landing-system : lando
- Remove WebSocket Type column
- Move the frame type information to the Data column as an arrow icon
- Add L10N strings for frame types and time format
- Reorder columns
- Set percentage widths for columns to give more room to data and time
Differential Revision: https://phabricator.services.mozilla.com/D37064
--HG--
extra : moz-landing-system : lando
As originally implemented, nsISiteSecurityService.removeState allowed direct
access to remove HSTS state. It also provided the implementation for when the
browser encountered an HSTS header with "max-age=0". In bug 775370, it was
updated to store an entry that would override preloaded information when
processing such headers. However, this meant that the semantics of the direct
access API had changed. Preloaded information could be overridden if a user
invoked the "forget about this site" feature. This change fixes the public API
(and renames it to "resetState") so it actually behaves as its consumers expect.
Reviewers: jcj!, KevinJacobs!
Tags: #secure-revision
Bug #: 1564481
Differential Revision: https://phabricator.services.mozilla.com/D38108
--HG--
extra : rebase_source : 8dd5460d3fd3c0ce92746cc83fae220d6e2a83cf
extra : amend_source : 171ebb015e9f9ae775f0caa22e161d41970f3d51
Bogdan Tara
Krishnal Ciccolella
Nicolas Chevobbe
Armando Ferreira
Barret Rennie
Kris Maglione
Yura Zenevich
Noemi Erli
Hiroyuki Ikezoe
Gabriel Luong
Bryan Kok
Florens Verschelde
Jason Laster
Alexandre Poirot
Julian Descottes
Andreea Pavel
Brendan Dahl
Micah Tigley
Jonathan Kingston
Ola Gasidlo
Boris Zbarsky
Narcis Beleuzu
Belén Albeza
Cosmin Sabou
Daisuke Akatsuka
Mihai Alexandru Michis
Oana Pop Rus
Tom Schuster
yulia
Razvan Maries
David Walsh
Coroiu Cristina
Brian Hackett
Vikas Mahato
Razvan Caliman
Nicholas Nethercote
Sebastian Streich
Daniel Varga
Csoregi Natalia
longsonr
Charlie Marlow
Anshul
Brindusan Cristian
Eden Chuang
ui.manish
Hubert B Manilla
Luca Greco
Alex Rosenfeld
tanhengyeow
Michael Ratcliffe
Ciure Andrei
Jeremy
Benjamin
Gurzau Raul
Thomas Nguyen
Dana Keeler
Oriol Brufau
Maliha Islam
Jan Odvarko