Граф коммитов

16945 Коммитов

Автор SHA1 Сообщение Дата
Jason Laster 69066c0a69 Bug 1354679 - re-apply pause overlay. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D38572

--HG--
extra : moz-landing-system : lando
2019-07-18 22:14:49 +00:00
Eden Chuang 2e2e393e21 Bug 1561930 - Correct the wrong attribute isFromChromeContext value for chrome context messages from Cu.reportError r=baku
Differential Revision: https://phabricator.services.mozilla.com/D38464

--HG--
extra : moz-landing-system : lando
2019-07-18 21:49:30 +00:00
Oana Pop Rus f64dbd1034 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-07-19 01:03:15 +03:00
Oana Pop Rus 8526799100 Merge inbound to mozilla-central. a=merge 2019-07-19 00:52:35 +03:00
ui.manish df8521eddf Bug 1505295 - Remove unused BarGraphWidget. r=gl 2019-07-18 14:24:57 -04:00
Brian Hackett ea4bf4d365 Bug 1565343 - Ignore alternate stacks for unknown kinds of channels, r=ochameau.
--HG--
extra : rebase_source : 915d492fc407c433fa33d4adf8fe914fd969267a
2019-07-17 17:49:01 -10:00
Alexandre Poirot ddcf8d83eb Bug 1566435 - Stop emitting requests when the netmonitor closes. r=Honza
There is no guarantee that any RDP request will be completed when the toolbox
closes, so that we should do the cleanup from the actor side if anything
needs to be stopped or removed.

Differential Revision: https://phabricator.services.mozilla.com/D38371

--HG--
extra : moz-landing-system : lando
2019-07-18 08:53:02 +00:00
Julian Descottes 05ed6b64d3 Bug 1486717 - Do not emit contextmenu from parentprocess if target is the RDM iframe r=mconley,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D37691

--HG--
extra : moz-landing-system : lando
2019-07-18 16:46:59 +00:00
Hubert B Manilla ef73fd6410 Bug 1561148 - Improve detection of react libraries r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D38236

--HG--
extra : moz-landing-system : lando
2019-07-18 02:24:43 +00:00
Luca Greco b96c8e6c30 Bug 1566520 - Ensure DevToolsShim.getToolboxes returns an empty array if devtools are not yet initialized. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D38472

--HG--
extra : moz-landing-system : lando
2019-07-18 12:03:23 +00:00
Alexandre Poirot 040c1a34cc Bug 1566457 - Removed deprecated gDevTools JSM. r=jdescottes
This was kept to support old xul addons. All mozilla-central usages
have been removed and now uses Loader.jsm to get access to this module.

Differential Revision: https://phabricator.services.mozilla.com/D38321

--HG--
extra : moz-landing-system : lando
2019-07-18 12:25:13 +00:00
Alexandre Poirot 438498ee47 Bug 1566457 - Remove unused provider logic from Loader.jsm. r=jdescottes
We used to have another provider which would load module via file:// URI,
directly from the disk. But the progress on artifact builds and ./mach build faster
made this obsolete and has been removed a long time ago.
We still have a lot of abstraction to support this non-existent feature.

Differential Revision: https://phabricator.services.mozilla.com/D38284

--HG--
extra : moz-landing-system : lando
2019-07-18 12:25:05 +00:00
Alexandre Poirot c9648fef81 Bug 1566457 - Only export require, loader and DevToolsLoader from Loader.jsm r=jdescottes
The rest was legacy code to support old xul add-ons.
All mozilla-central code used to be refactored, but a few places
were still using the old codepaths.

Differential Revision: https://phabricator.services.mozilla.com/D38283

--HG--
extra : moz-landing-system : lando
2019-07-18 12:25:03 +00:00
Alexandre Poirot 47fff7b393 Bug 1566457 - Remove unused devtools-cleanup observer message. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D38282

--HG--
extra : moz-landing-system : lando
2019-07-18 12:25:01 +00:00
Alexandre Poirot 8164b4a595 Bug 1566457 - Remove unused codepath in the base loader for non-shared globals. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D38281

--HG--
extra : moz-landing-system : lando
2019-07-18 12:24:54 +00:00
Alexandre Poirot 7d4d01eb1d Bug 1566435 - Make netmonitor destroy codepath synchronous. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D38370

--HG--
extra : moz-landing-system : lando
2019-07-17 16:57:53 +00:00
Nicolas Chevobbe bffc60754d Bug 1565781 - Fix ConsoleTable with nested holey array. r=Honza.
A test is added to ensure this is fixed properly.
We also fix the Array previewer to properly return
undefined for unknown array properties, rather than null.

Differential Revision: https://phabricator.services.mozilla.com/D38467

--HG--
extra : moz-landing-system : lando
2019-07-18 12:04:42 +00:00
Nicolas Chevobbe f2fd01c611 Bug 1567082 - Fix console table overflow. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D38466

--HG--
extra : moz-landing-system : lando
2019-07-18 11:58:16 +00:00
Nicolas Chevobbe d232eb14b1 Bug 1567071 - Remove main.js file. r=jdescottes.
The file was included in the index.html and was used
to create the WebConsoleWrapper.
We can directly create it from webconsole-ui.js and
not have this unusual mechanism.

Differential Revision: https://phabricator.services.mozilla.com/D38456

--HG--
extra : moz-landing-system : lando
2019-07-18 11:40:38 +00:00
Alex Rosenfeld eed79feede Bug 1565011 - Un-blackbox a file by adding a gutter breakpoint. r=davidwalsh
If user clicks gutter to add a breakpoint in tab of a blackboxed file, the file should be un-blackboxed.

Differential Revision: https://phabricator.services.mozilla.com/D38198

--HG--
extra : moz-landing-system : lando
2019-07-17 16:38:24 +00:00
David Walsh 75c80a355d Bug 1555354 - Prevent debug line from displaying in conditional panel r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D36413

--HG--
extra : moz-landing-system : lando
2019-07-16 21:59:03 +00:00
Noemi Erli 0497bd7b16 Backed out changeset a98b795c2b3c (bug 1100630) for Linting failure CLOSED TREE 2019-07-18 19:19:48 +03:00
Sebastian Streich fa947e166a Bug 1100630 - Print Related JS-Line on CSP Violation (if any) r=ckerschb,dveditz
Differential Revision: https://phabricator.services.mozilla.com/D31420

--HG--
extra : moz-landing-system : lando
2019-07-18 15:14:41 +00:00
Julian Descottes 760bc3dbdf Bug 1567147 - Simplify debugger mochitest browser.ini r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D38475

--HG--
extra : moz-landing-system : lando
2019-07-18 15:00:34 +00:00
tanhengyeow 60458cbfd4 Bug 1564105 - Enable WS Monitor in Nightly. r=Honza,jdescottes
Enable WS Monitor in Nightly

Differential Revision: https://phabricator.services.mozilla.com/D38230

--HG--
extra : moz-landing-system : lando
2019-07-18 13:49:59 +00:00
Julian Descottes 9349ded3c6 Bug 1566763 - Call telemetry.toolOpened/Closed from new aboutdebugging r=remote-debugging-reviewers,Ola
Differential Revision: https://phabricator.services.mozilla.com/D38471

--HG--
extra : moz-landing-system : lando
2019-07-18 13:34:22 +00:00
Michael Ratcliffe 10ece9e5b4 Bug 1563776 - Fix debugger tests when fx source folder is called firefox r=jlast
### Changes

- Tests under `<rootDir>/src/client/firefox/` were previously blocked. Maybe we should just remove them as they don't match the debugger's API any longer.

### Test Results

    Test Suites: 205 passed, 205 total
    Tests:       8 skipped, 1736 passed, 1744 total
    Snapshots:   440 passed, 440 total
    Time:        33.115s
    Ran all test suites in 5 projects.

### Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03aa91011325b983bd8aae54bd19c3b6f573c513&group_state=expanded

Differential Revision: https://phabricator.services.mozilla.com/D37086

--HG--
extra : moz-landing-system : lando
2019-07-16 19:47:17 +00:00
Michael Ratcliffe b934009a64 Bug 1560006 - Upgrade React to v16.8.6 r=nchevobbe
### Try

All green... at least when it comes to these changes.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d44faac0cd9cad95e0a22e4e465c130240d04f0
https://treeherder.mozilla.org/#/jobs?repo=try&revision=82aa7753e83faf3be594dd746ccba4414951def7

Just resurrected this in the hope it will help Gabe with the markup view changes.

Differential Revision: https://phabricator.services.mozilla.com/D35265

--HG--
extra : moz-landing-system : lando
2019-07-19 09:08:36 +00:00
Nicolas Chevobbe 6f973acea4 Bug 1567167 - Remove webConsoleClient getter from JSTerm. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D38615

--HG--
extra : moz-landing-system : lando
2019-07-19 08:29:54 +00:00
Nicolas Chevobbe f65992235e Bug 1567167 - Remove clearNetworkRequests from JsTerm destroy function. r=jdescottes.
This shouldn't be JSTerm's responsability to call
this function. Furthermore, the function clear
some references in the WebConsoleFront, which are
going to be destroyed anyway.

Differential Revision: https://phabricator.services.mozilla.com/D38614

--HG--
extra : moz-landing-system : lando
2019-07-19 08:28:48 +00:00
Nicolas Chevobbe d551082a54 Bug 1567167 - Remove copyObject function from JSTerm. r=jdescottes.
The function is only called from the context-menu,
where we already have all the references we need.
So we can move the function code directly in the
menu item callback.

Differential Revision: https://phabricator.services.mozilla.com/D38613

--HG--
extra : moz-landing-system : lando
2019-07-19 08:28:24 +00:00
Nicolas Chevobbe 96b0efb5e0 Bug 1567167 - Remove unused gSequenceId function in JSTerm . r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D38612

--HG--
extra : moz-landing-system : lando
2019-07-19 08:27:59 +00:00
Ciure Andrei b6b6dbdb5d Bug 1560261 - disable browser_webconsole_warning_groups_filtering.js on windows 7 opt for frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38091

--HG--
extra : moz-landing-system : lando
2019-07-17 17:55:59 +00:00
Jeremy afb1a94481 Bug 1563680 - Move network monitor actor files into the network-monitor directory r=Honza
Moved network monitor actor files:

network-monitor.js
network-event.js

into devtools/server/actors/network-monitor directory.

And updated moz.build files presented in related directories.

Differential Revision: https://phabricator.services.mozilla.com/D38219

--HG--
rename : devtools/server/actors/network-event.js => devtools/server/actors/network-monitor/network-event.js
rename : devtools/server/actors/network-monitor.js => devtools/server/actors/network-monitor/network-monitor.js
extra : moz-landing-system : lando
2019-07-19 06:40:38 +00:00
Julian Descottes 41a180b220 Bug 1567084 - Move netmonitor package.json to test/node folder r=Honza
Depends on D38462
Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=11540772729bce1614b75e7cf6b71931eed1582e

Differential Revision: https://phabricator.services.mozilla.com/D38463

--HG--
rename : devtools/client/netmonitor/package.json => devtools/client/netmonitor/test/node/package.json
rename : devtools/client/netmonitor/test/reducers/sort.spec.js => devtools/client/netmonitor/test/node/reducers/sort.spec.js
rename : devtools/client/netmonitor/yarn.lock => devtools/client/netmonitor/test/node/yarn.lock
extra : moz-landing-system : lando
2019-07-18 10:38:07 +00:00
Julian Descottes ef8a12bdbd Bug 1567084 - Remove files related to running netmonitor with launchpad/chrome r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D38462

--HG--
extra : moz-landing-system : lando
2019-07-18 10:33:57 +00:00
Razvan Caliman 1258790cbb Bug 1566398 - Remove expired scalar telemetry probes for Changes panel. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D38363

--HG--
extra : moz-landing-system : lando
2019-07-17 18:29:36 +00:00
Nicolas Chevobbe 73adf5f4f8 Bug 1554877 - Make JsTerm editor resizable. r=Honza.
We add a GridElementWidthResizer to handle the editor width.
The width is then persisted in a pref.
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D37687

--HG--
extra : moz-landing-system : lando
2019-07-18 05:51:44 +00:00
Nicolas Chevobbe 5642141d9f Bug 1565963 - Add props to NotificationBox to render top and bottom borders. r=Honza.
We need this in the console to put the borders on the
right position, depending on the NotificationBox place.

Differential Revision: https://phabricator.services.mozilla.com/D38039

--HG--
extra : moz-landing-system : lando
2019-07-18 05:51:24 +00:00
Nicolas Chevobbe a22dc0fd39 Bug 1565962 - Refactor webconsole layout. r=Honza.
Since we now have a GridElementWidthResizer element, we can
get rid of the SplitBox wrapping the SideBar, and have all
major elements as child of the App element, controlled by
a CSS Grid.

This makes it easy to change the console layout when toggling
the editor mode (re-ordering element in JS, changing the CSS
grid templates, and placing the element in different areas).
This also means we can take advantage of subgrid to align
the sidebar toolbar with the filter bar for example.

As the part of the stylesheet dedicated to layout grew, it
made sense to have it all in a separate stylesheet, App.css,
that lives next to the App component.

Differential Revision: https://phabricator.services.mozilla.com/D38038

--HG--
rename : devtools/client/themes/webconsole.css => devtools/client/webconsole/components/App.css
extra : moz-landing-system : lando
2019-07-18 09:02:46 +00:00
Nicolas Chevobbe 656b548c72 Bug 1567067 - Fix PropTypes error in Message.js .r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D38454

--HG--
extra : moz-landing-system : lando
2019-07-18 08:55:36 +00:00
Nicolas Chevobbe b0909bc6fd Bug 1565662 - Fix test_HSplitBox_01.html intermittent. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D38161

--HG--
extra : moz-landing-system : lando
2019-07-18 08:53:24 +00:00
Armando Ferreira ac079371c1 Bug 1546347 - Message location on CSS Warnings has an erroneous title attribute. r=nchevobbe
Adding a new opcional property to Frame.js, messageSource, which will allows us to know the source of the Message. We will be using this property to display the correct tooltip message.

Differential Revision: https://phabricator.services.mozilla.com/D38139

--HG--
extra : moz-landing-system : lando
2019-07-18 06:17:16 +00:00
Ciure Andrei d835b44a76 Merge inbound to mozilla-central. a=merge 2019-07-18 06:46:41 +03:00
Kris Maglione 0962c2b731 Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.

There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.

Differential Revision: https://phabricator.services.mozilla.com/D38247

--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Gabriel Luong 6e997644fa Bug 1566467 - Speed up shared/node-attribute-parser getType function. r=nchevobbe
We can speed up the getType function by changing the dataType into an object from an array.
That way we avoid looping looking for the matching tagName and namespaceURI and access the typeData directly by their tagName.

Differential Revision: https://phabricator.services.mozilla.com/D38196
2019-07-16 11:19:59 -04:00
Benjamin 7cd76c27d8 Bug 1566149: Added test to ensure CSP 'navigate-to' does not parse r=ckerschb
The test sets a navigate-to policy which results in a parse error.

Differential Revision: https://phabricator.services.mozilla.com/D38221

--HG--
extra : moz-landing-system : lando
2019-07-17 18:16:47 +00:00
Ciure Andrei b90bfe8d02 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-07-18 00:52:45 +03:00
Nicolas Chevobbe 41b44a849a Bug 1567370 - Add a close button to the Editor Toolbar. r=Honza.
The button display the same icon that will be used
in the console input when in inline-mode to toggle
the editor mode, active.
A test is added to ensure the button works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D38622

--HG--
rename : browser/themes/shared/icons/sidebars.svg => devtools/client/themes/images/webconsole/editor.svg
extra : moz-landing-system : lando
2019-07-19 14:10:06 +00:00
tanhengyeow 8f2fe89432 Bug 1555631 - WebSocket frame payload preview. r=Honza,nchevobbe
Support WebSocket frame payload preview.

Differential Revision: https://phabricator.services.mozilla.com/D38271

--HG--
extra : moz-landing-system : lando
2019-07-19 13:25:30 +00:00
Gurzau Raul 8a87842307 Bug 1559591 - disabled a few browser_application_panel tests to avoid leaks r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38654

--HG--
extra : moz-landing-system : lando
2019-07-19 13:28:49 +00:00
David Walsh 687a84bb9b Bug 1507936 - Provide information when node compilation fails r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D38344

--HG--
extra : moz-landing-system : lando
2019-07-17 15:51:06 +00:00
Armando Ferreira 4172b0bfee Bug 1524115 - When clicking and selecting source text on a collapsible message, the message expansion is toggled after releasing the mouse. r=nchevobbe
When clicking and selecting source text on a collapsible message, the message expansion is toggled after releasing the mouse

Differential Revision: https://phabricator.services.mozilla.com/D37607

--HG--
extra : moz-landing-system : lando
2019-07-17 15:48:56 +00:00
Coroiu Cristina a456952e71 Backed out changeset 8b0c5e44d937 (bug 1100630) for wpt failures at securitypolicyviolation/securitypolicyviolation-block-cross-origin-image-from-script.sub.html on a CLOSED TREE 2019-07-17 17:10:03 +03:00
Nicolas Chevobbe fe2f310301 Bug 1564138 - Fix DevTools PropTypes errors when updating eslint. r=Ola.
Differential Revision: https://phabricator.services.mozilla.com/D38093

--HG--
extra : moz-landing-system : lando
2019-07-17 10:35:44 +00:00
Sebastian Streich 975121a09a Bug 1100630 - Print Related JS-Line on CSP Violation (if any) r=ckerschb,dveditz
Differential Revision: https://phabricator.services.mozilla.com/D31420

--HG--
extra : moz-landing-system : lando
2019-07-17 10:54:07 +00:00
Brian Hackett 8e2cb113e0 Bug 1556813 Part 10 - Add test for breakpoint hits with complex control flow, r=loganfsmyth.
MANUAL PUSH: Lando gives me strange errors and no one is around in #lando to help diagnose the problem.

--HG--
extra : rebase_source : 3701625298b2647d8cef671d75fdda4340fb43b1
extra : histedit_source : c2ea99a43942a6dcf7bd5b527b87387b03d38151
2019-06-12 07:46:57 -10:00
Brian Hackett af8698c62b Bug 1556813 Part 9 - Show unscanned regions and uncached points on timeline, r=loganfsmyth.
--HG--
extra : rebase_source : 0015ede8437c6e0cccc9d8a349d744358575e320
extra : histedit_source : 364647d06744a93f98082a656dd6782d341d611a
2019-06-12 07:46:14 -10:00
Brian Hackett d62dcc9f5f Bug 1556813 Part 7 - Instrumentation based control logic, r=loganfsmyth.
--HG--
extra : rebase_source : 8d2dbd2017551651f88994de2937e0eb8832ae55
extra : histedit_source : df5a94b656f2a866315135914058ad3540c3d5be
2019-06-12 07:45:04 -10:00
Brian Hackett d4d55cdb95 Bug 1556813 Part 6 - Watch for provisional logpoint messages in webconsole, r=nchevobbe.
--HG--
extra : rebase_source : 7ba0c4a127644d3523fd84f6f6eea5f5d70eab27
extra : histedit_source : f1eb8349ba3f2a72134e8502509102fc5c5a619d
2019-06-12 07:43:35 -10:00
Brian Hackett 35c0ee1da7 Bug 1556813 Part 5 - Server changes for instrumentation based control logic, r=loganfsmyth.
--HG--
extra : rebase_source : b678f9170a1d2250c5916d9a9dcbfe7ed82c0a0b
extra : histedit_source : 548ebf0a3570200dcf856cff249a518a568e9d5a
2019-06-12 07:42:49 -10:00
Mihai Alexandru Michis 2958b91ee4 Backed out changeset 209c91065bfb (bug 1563680) for causing mochitest failures CLOSED TREE
--HG--
rename : devtools/server/actors/network-monitor/network-event.js => devtools/server/actors/network-event.js
rename : devtools/server/actors/network-monitor/network-monitor.js => devtools/server/actors/network-monitor.js
2019-07-17 11:42:59 +03:00
Julian Descottes d58dbb582c Bug 1519018 - Remove expired scalars and histograms related to about:devtools page r=ochameau,janerik
Depends on D38168

Differential Revision: https://phabricator.services.mozilla.com/D38169

--HG--
extra : moz-landing-system : lando
2019-07-17 08:12:54 +00:00
Julian Descottes 69ac3ca688 Bug 1519018 - Remove expired scalar devtools.onboarding.is_devtools_user r=ochameau,janerik
Depends on D38167

Differential Revision: https://phabricator.services.mozilla.com/D38168

--HG--
extra : moz-landing-system : lando
2019-07-17 08:12:37 +00:00
Julian Descottes ea69f317d4 Bug 1519018 - Remove startup code dedicated for DevTools onboarding experiment r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D38167

--HG--
extra : moz-landing-system : lando
2019-07-17 08:12:19 +00:00
Jeremy c897fe1404 Bug 1563680 - Move network monitor actor files into the network-monitor directory r=Honza
Moved network monitor actor files:

network-monitor.js
network-event.js

into devtools/server/actors/network-monitor directory.

And updated moz.build files presented in related directories.

Differential Revision: https://phabricator.services.mozilla.com/D38219

--HG--
rename : devtools/server/actors/network-event.js => devtools/server/actors/network-monitor/network-event.js
rename : devtools/server/actors/network-monitor.js => devtools/server/actors/network-monitor/network-monitor.js
extra : moz-landing-system : lando
2019-07-17 07:48:34 +00:00
Coroiu Cristina 0fddb5f0fd Backed out changeset ffc9fe173b43 (bug 1566149) for ESlint failure on a CLOSED TREE 2019-07-17 10:18:26 +03:00
Benjamin 8e6a440fe8 Bug 1566149: Added test to ensure CSP 'navigate-to' does not parse r=ckerschb
The test sets a navigate-to policy which results in a parse error.

Differential Revision: https://phabricator.services.mozilla.com/D38221

--HG--
extra : moz-landing-system : lando
2019-07-16 19:12:17 +00:00
Gurzau Raul a40be3ff67 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-07-17 06:53:00 +03:00
Gurzau Raul 21df1f7413 Merge inbound to mozilla-central. a=merge 2019-07-17 06:48:50 +03:00
Csoregi Natalia baf6ea8af4 Backed out changeset b1a964205023 (bug 1564105) for devtools failures on /browser_toolbox_tool_remote_reopen.js. CLOSED TREE 2019-07-17 04:40:53 +03:00
Florens Verschelde 127473ad9b Bug 1561549 - Move WebSocket type to an icon in Data column and reorder columns; r=Honza
- Remove WebSocket Type column
- Move the frame type information to the Data column as an arrow icon
- Add L10N strings for frame types and time format
- Reorder columns
- Set percentage widths for columns to give more room to data and time

Differential Revision: https://phabricator.services.mozilla.com/D37064

--HG--
extra : moz-landing-system : lando
2019-07-16 14:32:53 +00:00
Jason Laster ff7e5c4529 Bug 1561092 - browser_dbg-wasm-sourcemaps.js. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D38243

--HG--
extra : moz-landing-system : lando
2019-07-16 22:51:51 +00:00
tanhengyeow 02e5c9683c Bug 1564105 - Enable WS Monitor in Nightly. r=Honza
Enable WS Monitor in Nightly

Differential Revision: https://phabricator.services.mozilla.com/D38230

--HG--
extra : moz-landing-system : lando
2019-07-16 19:48:56 +00:00
tanhengyeow dce9db2dee Bug 1555634 - Summary stats at the bottom of Messages panel. r=Honza,nchevobbe,flod
Add summary stats at bottom of Messages panel.

Differential Revision: https://phabricator.services.mozilla.com/D38051

--HG--
extra : moz-landing-system : lando
2019-07-16 18:05:35 +00:00
Thomas Nguyen b0fa7cedfe Bug 1554947 - Update saveURL to use referrerInfo class instead of referrer and referrerr policy r=Gijs,snorp
Differential Revision: https://phabricator.services.mozilla.com/D33939

--HG--
extra : moz-landing-system : lando
2019-07-16 17:59:28 +00:00
Dana Keeler 18e9f3ba80 bug 1564481 - reset HSTS/HPKP state to factory settings rather than storing knockout entries for preloaded sites r=jcj r=KevinJacobs
As originally implemented, nsISiteSecurityService.removeState allowed direct
access to remove HSTS state. It also provided the implementation for when the
browser encountered an HSTS header with "max-age=0". In bug 775370, it was
updated to store an entry that would override preloaded information when
processing such headers. However, this meant that the semantics of the direct
access API had changed. Preloaded information could be overridden if a user
invoked the "forget about this site" feature. This change fixes the public API
(and renames it to "resetState") so it actually behaves as its consumers expect.

Reviewers: jcj!, KevinJacobs!

Tags: #secure-revision

Bug #: 1564481

Differential Revision: https://phabricator.services.mozilla.com/D38108

--HG--
extra : rebase_source : 8dd5460d3fd3c0ce92746cc83fae220d6e2a83cf
extra : amend_source : 171ebb015e9f9ae775f0caa22e161d41970f3d51
2019-07-11 13:48:28 -07:00
Jason Laster 6d4b358fc8 Bug 1564168 - [jsdbg2] Debugger.prototype.enabled should be removed (part 1). r=jimb
Differential Revision: https://phabricator.services.mozilla.com/D37929

--HG--
extra : moz-landing-system : lando
2019-07-16 00:56:19 +00:00
Yura Zenevich e51df71677 Bug 1565414 - update audit functionality to include warnings and best practices results. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D37817

--HG--
extra : moz-landing-system : lando
2019-07-15 23:01:07 +00:00
Noemi Erli 2f99f5d875 Merge mozilla-central to autoland. a=merge CLOSED TREE 2019-07-16 00:48:17 +03:00
Noemi Erli af897e281a Merge inbound to mozilla-central. a=merge 2019-07-16 00:42:51 +03:00
Oriol Brufau a8e153d3c1 Bug 1544329 - Don't load browser console in an invisibleToDebugger compartment. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D37926

--HG--
extra : moz-landing-system : lando
2019-07-15 19:48:43 +00:00
Gurzau Raul b44982b9f4 Bug 1544828 - disabled browser_aboutdebugging_devtoolstoolbox_reload.js on Linux debug and browser_aboutdebugging_devtoolstoolbox_shortcuts.js on Linux 64 debug for frequent failures. r=jmaher,aryx
Differential Revision: https://phabricator.services.mozilla.com/D38014

--HG--
extra : moz-landing-system : lando
2019-07-15 16:40:01 +00:00
Maliha Islam 672aefd444 Bug 1478156 - Make color picker tooltip screen reader accessible, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D35980

--HG--
extra : moz-landing-system : lando
2019-07-15 11:01:04 +00:00
Maliha Islam 7bd7b72040 Bug 1478156 - Make color picker tooltip keyboard accessible, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D33331

--HG--
rename : devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click.js => devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js
extra : moz-landing-system : lando
2019-07-15 11:01:04 +00:00
Maliha Islam 8cfcbe667f Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D33885

--HG--
extra : moz-landing-system : lando
2019-07-15 11:01:04 +00:00
Maliha Islam e9c7f9af44 Bug 1478156 - Add contrast ratio annotation title and info link to color picker, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D32842

--HG--
extra : moz-landing-system : lando
2019-07-15 11:01:03 +00:00
Maliha Islam d53f90a1d7 Bug 1478156 - Add color contrast span to color picker, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D32491

--HG--
extra : moz-landing-system : lando
2019-07-15 17:25:23 +00:00
Maliha Islam a94e63b533 Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D32490

--HG--
extra : moz-landing-system : lando
2019-07-15 11:01:03 +00:00
Jan Odvarko 4133d764ee Bug 1566019 - Fix URL column sorting + test r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D38065

--HG--
extra : moz-landing-system : lando
2019-07-15 15:22:56 +00:00
Razvan Maries dc7ff541ae Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-07-15 18:26:45 +03:00
Alexandre Poirot 2a463d6bff Bug 1388054 - Stop using Promise.jsm from devtools/shared/defer. r=jryans 2019-07-14 19:46:32 -07:00
Coroiu Cristina 8b6a45f83b Backed out changeset 6363111ee8ce (bug 1354679) for causing bug 1565833 2019-07-14 21:15:31 +03:00
Narcis Beleuzu cb456cb27d Backed out 6 changesets (bug 1478156) for dt failures on browser_html_tooltip_xul-wrapper.js . CLOSED TREE
Backed out changeset 5ca694230ffa (bug 1478156)
Backed out changeset fcc9123589fd (bug 1478156)
Backed out changeset 83a10c635fe9 (bug 1478156)
Backed out changeset a363971fffb0 (bug 1478156)
Backed out changeset 314855eab887 (bug 1478156)
Backed out changeset 041f51c9d4d1 (bug 1478156)

--HG--
rename : devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js => devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click.js
2019-07-14 05:32:45 +03:00
Maliha Islam 8029f7b024 Bug 1478156 - Make color picker tooltip screen reader accessible, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D35980

--HG--
extra : moz-landing-system : lando
2019-07-13 18:37:48 +00:00
Maliha Islam 2d795ad89c Bug 1478156 - Make color picker tooltip keyboard accessible, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D33331

--HG--
rename : devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click.js => devtools/client/inspector/rules/test/browser_rules_colorpicker-appears-on-swatch-click-or-keyboard-activation.js
extra : moz-landing-system : lando
2019-07-13 18:37:35 +00:00
Maliha Islam ff03e00a30 Bug 1478156 - Move shareable focus methods to be used for color picker accessibility, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D33885

--HG--
extra : moz-landing-system : lando
2019-07-13 18:37:18 +00:00
Maliha Islam 7739643423 Bug 1478156 - Add contrast ratio annotation title and info link to color picker, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D32842

--HG--
extra : moz-landing-system : lando
2019-07-13 18:37:06 +00:00
Maliha Islam fcc482964d Bug 1478156 - Add color contrast span to color picker, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D32491

--HG--
extra : moz-landing-system : lando
2019-07-13 18:36:54 +00:00
Maliha Islam 0e48d4c3b4 Bug 1478156 - Move shared code to be used by color contrast feature, r=yzen,gl
Differential Revision: https://phabricator.services.mozilla.com/D32490

--HG--
extra : moz-landing-system : lando
2019-07-13 18:36:41 +00:00
Edwin Gao 12e285eb71 Bug 1514751 - disable browser_aboutdebugging_addons_manifest_url.js for macosx1014 debug r=jmaher
Changes:
- temporarily disable the test on macosx1014 as per comments in the bug

Differential Revision: https://phabricator.services.mozilla.com/D37987

--HG--
extra : moz-landing-system : lando
2019-07-13 22:46:28 +00:00
Brindusan Cristian a558be5c35 Merge inbound to mozilla-central. a=merge 2019-07-14 00:54:25 +03:00
longsonr 7cf71757bf Bug 1353164 Part 1 - Remove dominant-baseline values that no longer exist r=heycam 2019-07-13 15:35:08 +01:00
Cosmin Sabou d4dd365f35 Bug 1432176 - Disable tests on ccov for frequent failures. a=testonly
--HG--
extra : amend_source : 4afdbe178ab5d01930885248bc31a7d4eac8f259
2019-07-13 16:14:55 +03:00
yulia 2d93b0778f Bug 1565194 - fix missing client; r=bhackett
the front renaming missed once case of client

Differential Revision: https://phabricator.services.mozilla.com/D37838

--HG--
extra : moz-landing-system : lando
2019-07-12 16:24:36 +00:00
Christoph Kerschbaumer 5a187ae11e Bug 1497197: Apply Meta CSP to about:debugging. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D37369

--HG--
extra : moz-landing-system : lando
2019-07-15 08:01:27 +00:00
Florens Verschelde a24be842cb Bug 1565917 - Tweak visual alignment of clear icon in Console and Network; r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D38016

--HG--
extra : moz-landing-system : lando
2019-07-15 07:38:22 +00:00
Ciure Andrei 3d0c68f966 Backed out changeset a9ea4223df5a (bug 1544828) the cause for the disable was backed out bug 1354679 CLOSED TREE
--HG--
extra : rebase_source : f3b8fae6526e237d3e5fdcac730cabc81428bb81
2019-07-12 23:57:12 +03:00
Ciure Andrei 6481c7cc39 Backed out changeset fa44f47160b2 (bug 1354679)for causing high frequency browser_aboutdebugging_devtoolstoolbox_shortcuts.js and browser_aboutdebugging_devtoolstoolbox_reload.js failures CLOSED TREE 2019-07-12 23:42:16 +03:00
Andreea Pavel 59262a5149 Bug 1432176 - disabled test on win ccov r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D37530

--HG--
extra : moz-landing-system : lando
2019-07-10 09:22:30 +00:00
Dorel Luca 28d6d22bfe Bug 1544828 - Disabled browser_aboutdebugging_devtoolstoolbox_reload.js on Linux64 and OSX Debug r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D37868

--HG--
extra : moz-landing-system : lando
2019-07-12 14:34:49 +00:00
Nicolas Chevobbe 9eee9f68e1 Bug 1521452 - Create a GridElementWidthResizer component. r=Honza.
This component is placed by the consumer on a grid, and act on
one of the grid element size.
The component can be placed at the inline start or the inline end
of the area it is in.
This component relies on the existing Draggable component.
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D37686

--HG--
extra : moz-landing-system : lando
2019-07-12 16:48:27 +00:00
Gijs Kruitbosch f862faa152 Bug 1560178 - fix devtools tests that load untrusted URIs in the parent, r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D36311

--HG--
extra : moz-landing-system : lando
2019-07-12 16:28:56 +00:00
Razvan Caliman 5c78bb5b6b Bug 1554701 - Replace CssProperties.isValidOnClient() with CSS.supports() r=gl
Given that `CssProperties.isValidOnClient()` does only a client-side check for support of a CSS declaration, we can leverage the built-in `CSS.supports()` method and remove some of the inter-dependencies between the `CssProperties` object from the `CssPropertiesFront` and its consumers, `OutputParser` and `FilterWidget`.

Differential Revision: https://phabricator.services.mozilla.com/D37751

--HG--
extra : moz-landing-system : lando
2019-07-12 15:28:29 +00:00
Panos Astithas 4993f3303e Bug 1406915 - Convert uses of defer to DOM promises in devtools/shared/client/. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D37747

--HG--
extra : moz-landing-system : lando
2019-07-12 14:37:29 +00:00
Dorel Luca 77d61d6a6f Backed out 5 changesets (bug 1560178) for Browser-chrome failures in builds/worker/workspace/build/src/dom/base/Document.cpp. CLOSED TREE
Backed out changeset 1ff8a41dd3c1 (bug 1560178)
Backed out changeset 4aaeda889656 (bug 1560178)
Backed out changeset b1dfc0b5a14c (bug 1560178)
Backed out changeset 45fca0f1b675 (bug 1560178)
Backed out changeset fc2be64e4ece (bug 1560178)
2019-07-12 18:38:34 +03:00
Jan de Mooij 5ea23033d2 Bug 1565175 - Fix HeapSnapshotHandler to not add nodes to |visited| until they're written to the core dump. r=fitzgen
Because ShouldIncludeEdge considers the |origin| node as well, it was possible for
the old code to 'miss' nodes and never write them to the core dump even though we
also wrote some edges with the node as referent.

Differential Revision: https://phabricator.services.mozilla.com/D37701

--HG--
extra : moz-landing-system : lando
2019-07-11 18:41:43 +00:00
Gijs Kruitbosch 125429e38a Bug 1560178 - fix devtools tests that load untrusted URIs in the parent, r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D36311

--HG--
extra : moz-landing-system : lando
2019-07-12 12:36:19 +00:00
Daniel Varga cf2048abd6 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-07-12 13:03:23 +03:00
Daniel Varga 883bfd385e Merge mozilla-inbound to mozilla-central. a=merge 2019-07-12 12:58:03 +03:00
Dorel Luca 7624ccd338 Backed out changeset 26592a2a32aa (bug 1561092) reverting disabling because of bug 1559760 and bug 1559761 2019-07-12 12:16:06 +03:00
Ola Gasidlo 05e788acf7 Bug 1557699 - Improve CSS base, r=ladybenko
Added variables in base.css, reduced specificity

Differential Revision: https://phabricator.services.mozilla.com/D35513

--HG--
extra : moz-landing-system : lando
2019-07-12 08:24:55 +00:00
Coroiu Cristina c440961ac6 Backed out changeset ad78f4b2fcee (bug 1521452) for chrome failures at devtools/client/shared/components/test/mochitest/test_HSplitBox_01.html
--HG--
extra : rebase_source : 3ec3d16bfb96fe6341186f0a4689b235a52cfa8e
2019-07-12 10:54:47 +03:00
Brian Hackett 53443837f2 Bug 1529163 - Wait for all threads in debugger client, r=jlast.
--HG--
extra : rebase_source : 6ba3159c47a69befbcf98950240ed072b25a8c5d
2019-07-11 17:47:22 +00:00
tanhengyeow b04946d40e Bug 1555628 - Toolbar for Messages side panel. r=Honza,nchevobbe
Implement Toolbar for WebSocketsPanel.

Differential Revision: https://phabricator.services.mozilla.com/D36455

--HG--
extra : moz-landing-system : lando
2019-07-12 07:37:23 +00:00
Armando Ferreira 7c12423a03 Bug 1528774 - Remove unnecessary code in GridItem's onGridCheckboxClick. r=nchevobbe
Removed unnecessary code in GridItem.js file's onGridCheckboxClick function and updated the render function so that the onInspectIconClick call triggers the stopPropagation function.

Differential Revision: https://phabricator.services.mozilla.com/D37612

--HG--
extra : moz-landing-system : lando
2019-07-12 07:11:26 +00:00
Nicolas Chevobbe de09ed81e9 Bug 1521452 - Create a GridElementWidthResizer component. r=Honza.
This component is placed by the consumer on a grid, and act on
one of the grid element size.
The component can be placed at the inline start or the inline end
of the area it is in.
This component relies on the existing Draggable component.
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D37686

--HG--
extra : moz-landing-system : lando
2019-07-11 14:37:11 +00:00
Jason Laster 6b6ac62e01 Bug 1354679 - tweak pause overlay. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D37496

--HG--
extra : moz-landing-system : lando
2019-07-11 16:29:10 +00:00
Alexandre Poirot c57a4aea23 Bug 1543023 - Use ChromeUtils.import only with one argument in all /devtools/ r=jdescottes
ChromeUtils.import still support a second argument as it used to do
when it was Components.utils.import. But this is deprecated and we should
instead always use the returned value.

Differential Revision: https://phabricator.services.mozilla.com/D37708

--HG--
extra : moz-landing-system : lando
2019-07-11 17:08:20 +00:00
Ehsan Akhgari e45ddde0ac Bug 1555861 - Make devtools storage.js module use storage principal; r=miker
Storage principal is the principal used for the storage area of a document,
as well as when trying to communicate to other same-origin document instances.
Right now the default is for the storage principal to be equal to the node
principal for all documents, but in the dynamic FPI feature (bug 1549587)
the storage principal for third-party documents will have a member of its
origin attributes set to the eTLD+1 of the domain of the top-level document
in order to 'partition' third-party data across top-level documents from
different sites.

This patch moves the devtools storage actor to use the storage principal
so that when dynamic FPI is enabled, devtools uses the correct principal.

Differential Revision: https://phabricator.services.mozilla.com/D37664

--HG--
extra : moz-landing-system : lando
2019-07-11 17:50:32 +00:00
Vikas Prasad Mahato b6dbc3f296 Bug 1541278 - Markup View's background flash effect: use yellow from Box Model shift-hover highlight. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D32864

--HG--
extra : moz-landing-system : lando
2019-07-11 18:00:06 +00:00
Bogdan Tara 0298725326 Backed out changeset f5d458cf80ae (bug 1555628) for ES lint failure on WebSocketsPanel.js CLOSED TREE 2019-07-11 21:05:06 +03:00
tanhengyeow be59cf7d7d Bug 1555628 - Toolbar for Messages side panel. r=Honza,nchevobbe
Implement Toolbar for WebSocketsPanel.

Differential Revision: https://phabricator.services.mozilla.com/D36455

--HG--
extra : moz-landing-system : lando
2019-07-11 14:49:48 +00:00
Jason Laster 6c4ef459cd Bug 1560942 - Fix perf regression from Event listener breakpoints. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D36826

--HG--
extra : moz-landing-system : lando
2019-07-10 00:17:20 +00:00
Brian Hackett 8fbd4d6692 Bug 1448166 Part 3 - Merge function body and function lexical scopes in scopes pane, r=jlast.
--HG--
extra : rebase_source : 7aafa54b0ace045b3422ef52694583dd3bdb6aeb
2019-07-09 21:19:49 +00:00
yulia 4e6d03ada7 Bug 1559819 - rename context to thread; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D32849

--HG--
extra : moz-landing-system : lando
2019-07-11 09:45:02 +00:00
yulia cc00bf541b Bug 1559819 - rename threadClient to threadFront; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D32848

--HG--
rename : devtools/client/debugger/src/actions/tests/helpers/threadClient.js => devtools/client/debugger/src/actions/tests/helpers/threadFront.js
rename : devtools/shared/client/thread-client.js => devtools/shared/fronts/thread.js
extra : moz-landing-system : lando
2019-07-11 09:45:32 +00:00
Nicolas Chevobbe 0905947b3b Bug 1564480 - Enhance performance on parseAttribute function. r=gl.
`hasAttribute` and `getAttribute` were using for..of loop to
get what they wanted, which wasn't ideal.
Moreover, most of those operations were happening because we
didn't pass the attribute value to the parseAttribute function,
only an array of all the attributes. This is a bit unfortunate
there's only one place where we call the parseAttribute function,
and there, we have easy access to the attribute value.

This patch removes direct calls to hasAttribute and getAttribute.
hasAttribute is removed, but we need to keep getAttribute for the
isValid function in parsers.
We add an `attributeValue` parameter to the parseAttribute function.
The unit test for this function is also modified to pass the attribute
value.

perfherder reports a ~2.5% improvement on custom open and ~3% on
custom reload.

Differential Revision: https://phabricator.services.mozilla.com/D37551

--HG--
extra : moz-landing-system : lando
2019-07-11 08:53:53 +00:00
Razvan Caliman e97022e21e Bug 1525326 - Remove backwards compatibility for custom unique ids for rules and stylesheets. r=gl
Since Firefox 67 tracked changes have unique identifiers as follows:
- ruleId => StyleRuleActor.actorID
- sourceId => StylesheetActor.actorID

Given that we're at Firefox 70 and beyond the window where we support connecting to servers older than 3 versions, this patch removes the backwards compatibility provided by methods to generate unique ids  based on attributes of the rule and stylesheet for the tracked change.

Differential Revision: https://phabricator.services.mozilla.com/D37591

--HG--
extra : moz-landing-system : lando
2019-07-10 19:51:57 +00:00
Jason Laster c0146c7fdf Bug 1565485 - Bug 1544329 - Fix debugger schema validation. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D37923

--HG--
extra : moz-landing-system : lando
2019-07-15 15:59:07 +00:00
Brian Hackett 9f9d6421f4 Bug 1349956 - Watch for dead objects when processing a thread's sources, r=loganfsmyth.
--HG--
extra : rebase_source : 7729b2ba3f3cb5f179ce93ecb169ced2d6ab0128
2019-07-09 21:35:00 +00:00
David Walsh dc35ef134c Bug 1552278 - Improve search bar performance in debugger r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D36801

--HG--
extra : moz-landing-system : lando
2019-07-03 17:19:13 +00:00
Florens Verschelde 36a057ae93 Bug 1560227 - Fix clipped bottom padding in aboutdebugging; r=ladybenko
Differential Revision: https://phabricator.services.mozilla.com/D35393

--HG--
extra : moz-landing-system : lando
2019-07-15 14:17:04 +00:00
Narcis Beleuzu dd7cd21402 Bug 1479782 - Disable browser_net_frame.js on Win7-32 and Linux64 r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38000

--HG--
extra : moz-landing-system : lando
2019-07-15 13:25:03 +00:00
Sebastian Hengst 6ec318ecd0 Bug 1556687 - Disable devtools/client/performance/test/browser_perf-recording-notices-03.js on Windows ccov because it always fails. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38061

--HG--
extra : moz-landing-system : lando
2019-07-15 12:38:30 +00:00
Sebastian Hengst a5ed3c8951 Bug 1516686 - Disable browser_rules_media-queries_reload.js for frequently failing on Windows ccov. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38062

--HG--
extra : moz-landing-system : lando
2019-07-15 12:51:51 +00:00
Ciure Andrei 8d5a2a730c Backed out changeset 286763a6d791 (bug 1544828) for perma failing browser_aboutdebugging_devtoolstoolbox_shortcuts.js CLOSED TREE 2019-07-15 16:03:52 +03:00
Gurzau Raul 9015aafda8 Bug 1544828 - disabled browser_aboutdebugging_devtoolstoolbox_reload.js on Linux debug for frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38014

--HG--
extra : moz-landing-system : lando
2019-07-15 10:48:58 +00:00
Andreea Pavel 4179d5fd2b Bug 1561092 - disabled browser_dbg-wasm-sourcemaps.js on win and linux debug r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D37523

--HG--
extra : moz-landing-system : lando
2019-07-10 09:36:57 +00:00
Nicolas Chevobbe 997f0e4621 Bug 1563761 - Handle comments in analyzeInput. r=ochameau.
We weren't handling comments at all, which means that having
any in the console would probably make the autocomplete not
working.
This patch handles both inline and multiline javascript comments,
and adds test cases to ensure we don't regress.

Depends on D36573

Differential Revision: https://phabricator.services.mozilla.com/D37196

--HG--
extra : moz-landing-system : lando
2019-07-10 08:00:32 +00:00
Julian Descottes 9ecd76c56b Bug 1539461 - Remove the old aboutdebugging codebase r=remote-debugging-reviewers,daisuke
Depends on D37863

Differential Revision: https://phabricator.services.mozilla.com/D37864

--HG--
extra : moz-landing-system : lando
2019-07-16 16:24:57 +00:00
Julian Descottes f1fcf6094f Bug 1539461 - Remove the aboutdebugging.new-enabled preference r=remote-debugging-reviewers,daisuke
Depends on D37860

Differential Revision: https://phabricator.services.mozilla.com/D37863

--HG--
extra : moz-landing-system : lando
2019-07-16 16:24:14 +00:00
Julian Descottes eb34d94bb2 Bug 1539451 - Disable WebIDE and ConnectPage by default r=remote-debugging-reviewers,daisuke
Depends on D37859

Differential Revision: https://phabricator.services.mozilla.com/D37860

--HG--
extra : moz-landing-system : lando
2019-07-16 16:23:46 +00:00
Julian Descottes e7303a1e95 Bug 1539451 - Remove the unused "disabled" field in devtools/client/menus r=remote-debugging-reviewers,daisuke
Differential Revision: https://phabricator.services.mozilla.com/D37859

--HG--
extra : moz-landing-system : lando
2019-07-16 16:22:34 +00:00
David Walsh 6e8b9aea44 Bug 1564243 - Don't show map scopes for pretty sources r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D38113

--HG--
extra : moz-landing-system : lando
2019-07-16 13:22:32 +00:00
Jason Laster 5970b1a8fe Bug 1354679 - Automatically display the PausedDebuggerOverlay when the debugger is paused. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D35162

--HG--
extra : moz-landing-system : lando
2019-07-09 22:01:34 +00:00
Junior Hsu 11fb864ed7 Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza
We'd like to enable the Origin header for all eligible reqeusts, which include POST.
The test should be adjusted.

Differential Revision: https://phabricator.services.mozilla.com/D33382
2019-07-09 23:20:01 +02:00
Oana Pop Rus b0ba88239d Backed out 4 changesets (bug 1424076) for mochitests failures in test_iframe_sandbox_navigation.html on a CLOSED TREE
Backed out changeset 67239c7df87c (bug 1424076)
Backed out changeset 2b4487c6403d (bug 1424076)
Backed out changeset c002ddb976e9 (bug 1424076)
Backed out changeset 50fbc0cec01a (bug 1424076)
2019-07-09 23:48:37 +03:00
Dorel Luca 441c28479d Backed out changeset e97f23bfa99c (bug 1497197) for devtools failures in devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_profiler_dialog.js
--HG--
extra : rebase_source : 7dee1e5b361f92470a55c3e0b6119a89c6aec2e4
2019-07-09 21:52:51 +03:00
Junior Hsu a9df20be3c Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza
We'd like to enable the Origin header for all eligible reqeusts, which include POST.
The test should be adjusted.

Differential Revision: https://phabricator.services.mozilla.com/D33382

--HG--
extra : moz-landing-system : lando
2019-07-09 18:26:59 +00:00
Dorel Luca 06b684f035 Backed out 4 changesets (bug 1424076) for ESlint failure
Backed out changeset c6299be2356c (bug 1424076)
Backed out changeset f567bf2904c9 (bug 1424076)
Backed out changeset 6127a13715c9 (bug 1424076)
Backed out changeset 743605a9b0ac (bug 1424076)

--HG--
extra : rebase_source : a20ab3fc782b376dd091e18b647a2ef12d7e4aca
2019-07-09 21:17:22 +03:00
jaril c44213fae7 Bug 1564134 - Convert ContentProcessTargetActor to protocol.js. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D37188

--HG--
extra : moz-landing-system : lando
2019-07-10 08:21:50 +00:00
Florens Verschelde 75cbed9086 Bug 1566135 - Remove devtools-separator margin variables; r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D38105

--HG--
extra : moz-landing-system : lando
2019-07-16 06:22:12 +00:00
Panos Astithas b290fc08af Bug 1233891 - Use DOM promises instead of deprecated sync promises in devtools/. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D37138

--HG--
extra : moz-landing-system : lando
2019-07-09 17:26:32 +00:00
Junior Hsu 6aa8489ec9 Bug 1424076 - P2 adjust Origin header comparison for POST request r=Honza
We'd like to enable the Origin header for all eligible reqeusts, which include POST.
The test should be adjusted.

Differential Revision: https://phabricator.services.mozilla.com/D33382

--HG--
extra : moz-landing-system : lando
2019-07-09 17:15:21 +00:00
Christoph Kerschbaumer b4c50e5e07 Bug 1497197: Apply Meta CSP to about:debugging. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D37369

--HG--
extra : moz-landing-system : lando
2019-07-09 17:10:31 +00:00
Belén Albeza 9b6880a907 Bug 1558757 - Add unit tests for reducers. r=Ola
Differential Revision: https://phabricator.services.mozilla.com/D36741

--HG--
extra : moz-landing-system : lando
2019-07-09 13:40:55 +00:00
Nicolas Chevobbe c263325eba Bug 1564363 - Close the network detail on Escape. r=Honza.
We use the openNetworkDetails prop which is already in use
in the netmonitor to collapse the message if the parameter
passed to the function is falsy (i.e. the panel is already
displayed)

Depends on D37388

Differential Revision: https://phabricator.services.mozilla.com/D37389

--HG--
extra : moz-landing-system : lando
2019-07-09 10:50:50 +00:00
Nicolas Chevobbe b6f86a6665 Bug 1564363 - Set toggleNetworkDetails prop as non required. r=Honza.
This prop is only used when hideToggleButton isn't truthy.
In the case of the console, it won't ever be called, so
it's not mandatory.

Differential Revision: https://phabricator.services.mozilla.com/D37388

--HG--
extra : moz-landing-system : lando
2019-07-09 10:50:48 +00:00
Nicolas Chevobbe 064fd41499 Bug 1534706 - Don't focus ConfirmDialog when displaying it. r=Honza
Some people found that the ConfirmDialog was getting into their
way when typing into the console, as it was stealing the focus.
This patch fixes this by not focusing the ConfirmDialog when
we show it, so the user can still type.
This means that we now handle the dialog confirm and dismiss from
JSTerm, when the former is displayed.

Since it wasn't clear how you could close the popup, we add a close
button that makes it very obvious.

This means we can drop the key handler in the dialog as the jsterm
is always focused.
We also simply remove the feature to open the MDN link on `?` key
stroke as it's not discoverable and was the only part of the
panel where you could do such thing.

Existing tests are adapted and extended to cover the new behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D36174

--HG--
extra : moz-landing-system : lando
2019-07-09 12:28:38 +00:00
Nicolas Chevobbe a0d642a0a5 Bug 1563914 - Fix ConsoleTable with invalid headers. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D37164

--HG--
extra : moz-landing-system : lando
2019-07-09 08:47:58 +00:00
Florens Verschelde e1899f230d Bug 1564267 - Fix console line-height for large text; r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D37367

--HG--
extra : moz-landing-system : lando
2019-07-09 11:16:34 +00:00
Jonathan Kew 7ae68c458b Bug 1421938 - Add an 'auto' value for the CSS 'quotes' property, and make it use language-dependent quote marks. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D36429

--HG--
extra : moz-landing-system : lando
2019-07-09 08:59:27 +00:00
Florens Verschelde 8700d1754a Bug 1564191 - Remove unused tool-canvas.svg and tool-webaudio.svg; r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D37299

--HG--
extra : moz-landing-system : lando
2019-07-09 08:17:26 +00:00
Javier Olaechea ad8d779e56 Bug 1558355 - Remove devtools.netmonitor.features.resizeColumns pref, r=Honza
Remove devtools.netmonitor.features.resizeColumns pref and any reference to it.

Differential Revision: https://phabricator.services.mozilla.com/D37159

--HG--
extra : moz-landing-system : lando
2019-07-09 08:33:12 +00:00
Christoph Kerschbaumer fa67de326f Bug 1497199: Apply Meta CSP to about:devtools.
Differential Revision: https://phabricator.services.mozilla.com/D37370

--HG--
extra : moz-landing-system : lando
2019-07-09 06:56:56 +00:00
Daisuke Akatsuka a894b5e7b1 Bug 1521085: Add a test which add a property which is an invalid identifier. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D37220

--HG--
extra : moz-landing-system : lando
2019-07-09 03:54:57 +00:00
Daisuke Akatsuka 5382e84637 Bug 1521085: Return false if the property name is an invalid identifier. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D37219

--HG--
extra : moz-landing-system : lando
2019-07-09 04:43:23 +00:00
shindli f5dea34efe Backed out 5 changesets (bug 1421938) for bustages in /builds/worker/workspace/build/src/layout/base/nsQuoteList.cpp CLOSED TREE
Backed out changeset 4e25a6db1f5b (bug 1421938)
Backed out changeset 11a8f9bc0418 (bug 1421938)
Backed out changeset f27980997dc5 (bug 1421938)
Backed out changeset adb2e2714c14 (bug 1421938)
Backed out changeset 33e38a62b400 (bug 1421938)
2019-07-09 02:52:38 +03:00
Jonathan Kew 6bea7b3966 Bug 1421938 - Add an 'auto' value for the CSS 'quotes' property, and make it use language-dependent quote marks. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D36429

--HG--
extra : moz-landing-system : lando
2019-07-08 20:16:19 +00:00
shindli 2c12986a7f Backed out 5 changesets (bug 1421938) for causing a bustage in /builds/worker/workspace/build/src/intl/locale/cldr-quotes.inc:21:448 CLOSED TREE
Backed out changeset 3958f2af0e34 (bug 1421938)
Backed out changeset 89a0866d1aa0 (bug 1421938)
Backed out changeset f150702af11f (bug 1421938)
Backed out changeset b8ebd4d241e0 (bug 1421938)
Backed out changeset 1d38eb5eff6e (bug 1421938)
2019-07-08 23:09:34 +03:00
Jonathan Kew e5f479f588 Bug 1421938 - Add an 'auto' value for the CSS 'quotes' property, and make it use language-dependent quote marks. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D36429

--HG--
extra : moz-landing-system : lando
2019-07-08 12:13:28 +00:00
Jason Laster 0cffef92ff Bug 1561092 - Fix intermittent browser_dbg-wasm-sourcemaps test.
Differential Revision: https://phabricator.services.mozilla.com/D37294

--HG--
extra : moz-landing-system : lando
2019-07-08 17:55:35 +00:00
Tom Schuster d427e8bfe9 Bug 1558914 - Remove non-standard Array.sort from devtools test. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D36438

--HG--
extra : moz-landing-system : lando
2019-07-08 17:45:09 +00:00
Jonathan Kingston 31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Noemi Erli ba301c3e5e Bug 1563684 - ES lint fix CLOSED TREE 2019-07-08 16:12:34 +03:00
Nicolas Chevobbe 875a819a93 Bug 1563684 - Fix blank console on GMail. r=yulia.
The console fails to connect to the server because
the getCachedMessages function throws on GMail.
This is because we try to access a property on a
cross-origin object, window.windowUtils, in
getInnerWindowId.
Wrapping the access to the property fixes the issue.
A test is added to make sure we don't regress.

// TODO: The test isn't failing without the fix,
so it should be re-written.

Differential Revision: https://phabricator.services.mozilla.com/D37069

--HG--
extra : moz-landing-system : lando
2019-07-08 12:34:20 +00:00
Nicolas Chevobbe c0c38fd4a3 Bug 1557305 - Speed up JsPropertyProvider analyzeInput function. r=ochameau.
We were using Array.from to get an array of all the characters, and
be able to slice parts of the strings to run some checks.
This had the disadvantage of being quite slow on very large strings,
at a point where we introduced a bail out mechanism into the function
to not block the content page.
This patch switches to `String.prototype[Symbol.iterator]` to loop
over all the character, and removes lots of array and string manipulations.
On the same, super-large, string, the function cost went from 6700ms to
less than 200ms.

Differential Revision: https://phabricator.services.mozilla.com/D36572

--HG--
extra : moz-landing-system : lando
2019-07-08 06:24:38 +00:00
Sebastian Hengst 11acdc3897 Bug 1554707 - Refactor test folder structure: adjust code for js Prettier. a=eslint-fix CLOSED TREE
--HG--
extra : amend_source : 534bfbe20df1ba8875778afc8bd4aa99f9f51fa5
2019-07-08 12:06:32 +02:00
Ola Gasidlo 247d4a898e Bug 1554707 - Refactor test folder structure, r=jdescottes,ladybenko
Refactor test folder structure to align with remote debugging

Differential Revision: https://phabricator.services.mozilla.com/D35002

--HG--
rename : devtools/client/application/test/browser.ini => devtools/client/application/test/browser/browser.ini
rename : devtools/client/application/test/browser_application_panel_debug-service-worker.js => devtools/client/application/test/browser/browser_application_panel_debug-service-worker.js
rename : devtools/client/application/test/browser_application_panel_list-domain-workers.js => devtools/client/application/test/browser/browser_application_panel_list-domain-workers.js
rename : devtools/client/application/test/browser_application_panel_list-several-workers.js => devtools/client/application/test/browser/browser_application_panel_list-several-workers.js
rename : devtools/client/application/test/browser_application_panel_list-single-worker.js => devtools/client/application/test/browser/browser_application_panel_list-single-worker.js
rename : devtools/client/application/test/browser_application_panel_list-unicode.js => devtools/client/application/test/browser/browser_application_panel_list-unicode.js
rename : devtools/client/application/test/browser_application_panel_list-workers-empty.js => devtools/client/application/test/browser/browser_application_panel_list-workers-empty.js
rename : devtools/client/application/test/browser_application_panel_open-links.js => devtools/client/application/test/browser/browser_application_panel_open-links.js
rename : devtools/client/application/test/browser_application_panel_start-service-worker.js => devtools/client/application/test/browser/browser_application_panel_start-service-worker.js
rename : devtools/client/application/test/browser_application_panel_unregister-worker.js => devtools/client/application/test/browser/browser_application_panel_unregister-worker.js
rename : devtools/client/application/test/head.js => devtools/client/application/test/browser/head.js
rename : devtools/client/application/test/service-workers/debug-sw.js => devtools/client/application/test/browser/resources/service-workers/debug-sw.js
rename : devtools/client/application/test/service-workers/debug.html => devtools/client/application/test/browser/resources/service-workers/debug.html
rename : devtools/client/application/test/service-workers/dynamic-registration.html => devtools/client/application/test/browser/resources/service-workers/dynamic-registration.html
rename : devtools/client/application/test/service-workers/empty-sw.js => devtools/client/application/test/browser/resources/service-workers/empty-sw.js
rename : devtools/client/application/test/service-workers/empty.html => devtools/client/application/test/browser/resources/service-workers/empty.html
rename : devtools/client/application/test/service-workers/scope-page.html => devtools/client/application/test/browser/resources/service-workers/scope-page.html
rename : devtools/client/application/test/service-workers/simple-unicode.html => devtools/client/application/test/browser/resources/service-workers/simple-unicode.html
rename : devtools/client/application/test/service-workers/simple.html => devtools/client/application/test/browser/resources/service-workers/simple.html
rename : devtools/client/application/test/.eslintrc.js => devtools/client/application/test/components/.eslintrc.js
rename : devtools/client/application/test/babel.config.js => devtools/client/application/test/components/babel.config.js
rename : devtools/client/application/test/fixtures/Chrome.js => devtools/client/application/test/components/fixtures/Chrome.js
rename : devtools/client/application/test/fixtures/PluralForm.js => devtools/client/application/test/components/fixtures/PluralForm.js
rename : devtools/client/application/test/fixtures/Services.js => devtools/client/application/test/components/fixtures/Services.js
rename : devtools/client/application/test/fixtures/l10n.js => devtools/client/application/test/components/fixtures/l10n.js
rename : devtools/client/application/test/fixtures/stub.js => devtools/client/application/test/components/fixtures/stub.js
rename : devtools/client/application/test/jest.config.js => devtools/client/application/test/components/jest.config.js
rename : devtools/client/application/test/package.json => devtools/client/application/test/components/package.json
rename : devtools/client/application/test/setup.js => devtools/client/application/test/components/setup.js
rename : devtools/client/application/test/yarn.lock => devtools/client/application/test/components/yarn.lock
extra : moz-landing-system : lando
2019-07-08 09:20:28 +00:00
Cosmin Sabou 38de4a72d6 Backed out 1 changesets (bug 1561092) for debugger failures on flow and jest tests. CLOSED TREE
Backed out changeset 109fab16fdda (bug 1561092)
2019-07-08 08:53:09 +03:00
Jason Laster d5e49f826f Bug 1561092 - Fix intermittent browser_dbg-wasm-sourcemaps test. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D36837

--HG--
extra : moz-landing-system : lando
2019-07-07 21:20:49 +00:00
Julian Descottes 5a3789f753 Bug 1563686 - Introduce menu.popupAtTarget to fix zoom issues in netmonitor menus r=nchevobbe
Already tested via toolbox menus in devtools/client/framework/test/browser_toolbox_zoom_popup.js
Could open a follow up to allow for other anchor points than bottom-left.

Differential Revision: https://phabricator.services.mozilla.com/D37044

--HG--
extra : moz-landing-system : lando
2019-07-07 14:15:51 +00:00
Nicolas Chevobbe 81e865fd97 Bug 1558248 - Don't clear the completion text when it starts with the typed letters. r=fvsch.
We were clearing the completion text all the time to prevent
a visual glitch while typing (See Bug 1491776). But since we
are now waiting for 75ms before calling the autocomplete
function (which triggers the autocompletion text update), we
have a flash of the completion text, which isn't ideal.
In this patch, we check if the typed letters match the begining
of the completion text, and if they do, we don't clear the
completion text.
In the same time, we set the completion text in absolute position
so it doesn't jump when the new letter is added in the CodeMirror
document.
Finally, we change how the Editor pipe events from CodeMirror to
include parameters, so we can use them in JsTerm.

Differential Revision: https://phabricator.services.mozilla.com/D36163

--HG--
extra : moz-landing-system : lando
2019-07-07 10:38:08 +00:00
Yash Johar 26f5af1d30 Bug 1535254 - Update RDM rotate and touch icons to a Photon style. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D32790

--HG--
extra : moz-landing-system : lando
2019-07-06 14:37:17 +00:00
Cosmin Sabou 037c8526b6 Backed out changeset f93a2cb9622e (bug 1563776) for debugger failures on jest-test.config.js. CLOSED TREE 2019-07-06 01:08:37 +03:00
Michael Ratcliffe 5d02b348c1 Bug 1563776 - Fix debugger tests when fx source folder is called firefox r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D37086

--HG--
extra : moz-landing-system : lando
2019-07-05 17:24:22 +00:00
Julian Descottes 15564ff126 Bug 1561304 - Add border to HTML tooltip when not using XUL wrapper r=fvsch
Also changed the border radius to be consistent between doorhanger and arrow style tooltips.
There are still subtle differences between the XUL+arrow/HTML+arrow/XUL+doorhanger, but for now I would just like to fix this before we merge to 70.
Strictly using the photon shadow for doorhangers is too subtle and too inconsistent with our other tooltips, so I used shadow-20.

Differential Revision: https://phabricator.services.mozilla.com/D36767

--HG--
extra : moz-landing-system : lando
2019-07-05 07:08:17 +00:00
Victor Porof b8157dfaaf Bug 1561435 - Format remaining devtools/, a=automatic-formatting, CLOSED TREE
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35894

--HG--
extra : source : 4722b924e08478f5337ab509718bd66906bf472f
extra : amend_source : a5baa1aab21639fdba44537e3a10b179b0073cb4
2019-07-05 11:29:32 +02:00
Victor Porof 66e8f7440d Bug 1561435 - Fix test failures for devtools/server/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35893

--HG--
extra : source : 9238d499b425da9f71e9afa887b200841b73ca1a
extra : intermediate-source : aa4fc8c9ee0d199e5b78bc6827f677605f71e70f
2019-06-19 13:43:15 -07:00
Victor Porof d8903e9911 Bug 1561435 - Fix linting errors for devtools/server/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35892

--HG--
extra : source : 5bdd50ed27f18c787fc43b5ffbe3bf778969d759
extra : intermediate-source : cffe7cded9d562e2700c576bce3e2088f4e7882d
2019-06-20 06:26:50 -07:00
Victor Porof 24d2c75470 Bug 1561435 - Format devtools/server/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35891

--HG--
extra : source : d2dc183b9bf9086d4b862e0e9a0cfa0bf773193f
2019-07-05 11:26:00 +02:00
Victor Porof 60b8254b35 Bug 1561435 - Update `pageError stubs file` after formatting devtools/client/ by running `browser_webconsole_update_stubs_page_error.js`, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35890

--HG--
extra : source : e550cb2590583e0978a183813069197d65bb4b9e
extra : intermediate-source : 39a13b35139e3d3f7be072a51674e125ff798c66
2019-06-28 23:03:19 +02:00
Victor Porof e22aa772cc Bug 1561435 - Fix test failures for devtools/client/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35889

--HG--
extra : source : b0c4a5ceaa806c7eb0b80373bad03952a8e8e615
extra : intermediate-source : bc3217f46831d07aba771b9f19373190d2122894
2019-06-19 13:31:45 -07:00
Victor Porof 56ef3d5679 Bug 1561435 - Fix linting errors for devtools/client/, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35885

--HG--
extra : source : 64dd06feccb80551c56339bdf16ee480b94b2d84
extra : intermediate-source : 59239f9cb724bfb9ac79c5e06ac42393e74af328
2019-06-20 06:22:00 -07:00
Victor Porof f6db0ee557 Bug 1561435 - Format devtools/client/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35884

--HG--
extra : source : 60e4496cf9699dc59f2f4738cb60f87cbdb01e67
2019-07-05 11:24:38 +02:00
Victor Porof 57a6febcec Bug 1561435 - Update `pageError stubs file` after formatting testing/ by running `browser_webconsole_update_stubs_page_error.js`, r=standard8
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36412

--HG--
extra : source : ef0ac7e1af4307bd0e8fbefbce2f05a647cde9be
extra : intermediate-source : d05c283a1ffde68231f668ef0c1359c422c5bdbc
2019-06-28 22:48:16 +02:00
Victor Porof 34da32ec3c Bug 1558517 - Pre 3.1: Change conflicting "camelcase" rule which would fail after running Prettier, r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D34695

--HG--
extra : source : 078747ad644246551a165a176a691e0440553c85
extra : intermediate-source : 3b39b237ae3c49eb6c9d56a2ef8bfb5134b878da
2019-06-12 11:43:25 +02:00
Victor Porof b5a4cb3848 Bug 1558517 - Pre 3.0: Remove conflicting eslint rules, and turn on "curly: all" everywhere, r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D34535

--HG--
extra : source : 74ed7ee773393d305c4e948a57a1b1e32b1f12e8
extra : intermediate-source : 403d0757d61683e0a85d0bb07768eb39fbd0af72
2019-06-28 17:14:01 +02:00
Razvan Maries 960e4c47d4 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-07-05 00:43:53 +03:00
Razvan Maries daed363fd7 Merge mozilla-inbound to mozilla-central a=merge 2019-07-05 00:40:17 +03:00
Razvan Caliman 0bde9bbef6 Bug 724505 - Map minified CSS to prettyfied CSS. r=gl
Ensure source links for selectors in the Rules view and warning links in Web Console for minified CSS go to the right location in the Style Editor after applying automatic prettification.

This only works for linked stylesheets. [Bug 1169770](https://bugzilla.mozilla.org/show_bug.cgi?id=1169770) needs to be fixed first before this can work correctly on inline minified stylesheets.

This patch augments the `prettifyCSS()` method to generate the mappings necessary to generate a sourcemap from the original to the prettified source. It uses these mappings to translate the cursor position when invoking the Style Editor to be opened at a specific location.

The mappings from the minified to the prettified source are used only until the stylesheet is changed in the Style Editor. Upon editing the source in the Style Editor, the associated mappings are cleared because it's likely they have been rendered invalid.

The updated stylesheet will already be prettified so it bypasses the `prettifyCSS()` method, thus avoiding the need to re-generate mappings. New CSS warnings will be listed in the Web Console which point to the right location in the edited stylesheet (the old warnings no longer point to the right place, but that's an acceptable side-effect). The Rules view in the Inspector also lists selectors with the new positions within the edited stylesheet.

Differential Revision: https://phabricator.services.mozilla.com/D36585

--HG--
extra : moz-landing-system : lando
2019-07-04 17:30:00 +00:00
Csoregi Natalia 0c754625a9 Merge mozilla-central to mozilla-inbound. CLOSED TREE 2019-07-04 12:54:22 +03:00
Oana Pop Rus 2ad74ef9f7 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-07-04 06:38:21 +03:00
Nicolas Chevobbe a48d2333b8 Bug 1560426 - Fix dead link in getting started page. r=sole.
Differential Revision: https://phabricator.services.mozilla.com/D35486

--HG--
extra : moz-landing-system : lando
2019-07-04 17:06:35 +00:00
J 8d50baa36e Bug 1561755 - Replace flex display badge tooltip with the correct inlineFlex tooltip string id in element-editor.js. r=gl 2019-07-03 14:49:46 -04:00
Yura Zenevich da1fd387a0 Bug 1562194 - update links to MDN since the wording and thus MDN doc headings are updated as well. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D36763

--HG--
extra : moz-landing-system : lando
2019-07-04 14:21:41 +00:00
Yura Zenevich 548f92d410 Bug 1562194 - update heading with no content text label audit rule from failure to warning. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D36762

--HG--
extra : moz-landing-system : lando
2019-07-04 10:39:55 +00:00
Yura Zenevich 724ec6a79b Bug 1562194 - update <fieldset> no name from legend text label audit rule from failure to warning. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D36761

--HG--
extra : moz-landing-system : lando
2019-07-04 10:38:46 +00:00
Yura Zenevich 459cd85753 Bug 1562194 - update <optgroup> text label audit rules and only keep the text label for optgroup from label rule. r=nchevobbe,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D36760

--HG--
extra : moz-landing-system : lando
2019-07-04 15:16:57 +00:00
Yura Zenevich 1012544d50 Bug 1518808 - add accessibility highlighter infobar for text label audit. When accessible object does not pass text label accessibility audit, the infobar will display a short message describing the particular labeling issue. r=nchevobbe,flod
Differential Revision: https://phabricator.services.mozilla.com/D35961

--HG--
extra : moz-landing-system : lando
2019-07-04 15:16:57 +00:00
Yura Zenevich a2bb375be2 Bug 1552067 - add checks section for text label audit. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D35497

--HG--
extra : moz-landing-system : lando
2019-07-04 03:36:35 +00:00
Yura Zenevich 76b7fe4f3e Bug 1552067 - move common error/warning/error icons to devtools/client/themes/images/. r=nchevobbe,fvsch
Differential Revision: https://phabricator.services.mozilla.com/D35496

--HG--
rename : devtools/client/themes/images/alert.svg => devtools/client/themes/images/alert-small.svg
rename : devtools/client/themes/images/webconsole/error.svg => devtools/client/themes/images/error-small.svg
rename : devtools/client/themes/images/webconsole/info.svg => devtools/client/themes/images/info-small.svg
extra : moz-landing-system : lando
2019-07-04 03:36:27 +00:00
Julian Descottes 043855ab8e Bug 1562583 - Add license headers in devtools/shared/protocol files r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D36480

--HG--
extra : moz-landing-system : lando
2019-07-03 18:00:30 +00:00
Yura Zenevich d1477ea4b5 Bug 1518808 - add accessibility highlighter infobar for text label audit. When accessible object does not pass text label accessibility audit, the infobar will display a short message describing the particular labeling issue. r=nchevobbe,flod
Differential Revision: https://phabricator.services.mozilla.com/D35961

--HG--
extra : moz-landing-system : lando
2019-07-03 17:25:13 +00:00
Yura Zenevich 04eaa20e54 Bug 1552067 - add checks section for text label audit. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D35497

--HG--
extra : moz-landing-system : lando
2019-07-03 17:25:06 +00:00
Yura Zenevich 654c4e2673 Bug 1552067 - move common error/warning/error icons to devtools/client/themes/images/. r=nchevobbe,fvsch
Differential Revision: https://phabricator.services.mozilla.com/D35496

--HG--
rename : devtools/client/themes/images/alert.svg => devtools/client/themes/images/alert-small.svg
rename : devtools/client/themes/images/webconsole/error.svg => devtools/client/themes/images/error-small.svg
rename : devtools/client/themes/images/webconsole/info.svg => devtools/client/themes/images/info-small.svg
extra : moz-landing-system : lando
2019-07-03 17:26:43 +00:00
arthur.iakab 7bc47eec9b Backed out 2 changesets (bug 1552168) for causing mochitest crashes on test_menubar.xul CLOSED TREE
Backed out changeset 83590619ce06 (bug 1552168)
Backed out changeset 7ff83cc5d33a (bug 1552168)
2019-07-03 16:08:23 +03:00
Nicolas Chevobbe 8921a25384 Bug 1562914 - Fix PropTypes error in FilterBar in split console. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D36618

--HG--
extra : moz-landing-system : lando
2019-07-03 11:15:28 +00:00
Nicolas Chevobbe ea96bb70c8 Bug 1562839 - Put editor mode behind a pref. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D36582

--HG--
extra : moz-landing-system : lando
2019-07-03 11:14:22 +00:00
Sebastian Streich ce99ef5438 Bug 1552168 - Fix Tests that rely on data_uri.unique_opaque_origin r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D35006

--HG--
extra : moz-landing-system : lando
2019-07-03 10:23:46 +00:00
Narcis Beleuzu 60d6348455 Backed out 3 changesets (bug 1552067, bug 1518808) as per yzen`s req . CLOSED TREE
Backed out changeset e677852d2ea5 (bug 1518808)
Backed out changeset d60bcc3b1c72 (bug 1552067)
Backed out changeset 2cee1703625e (bug 1552067)

--HG--
rename : devtools/client/themes/images/error-small.svg => devtools/client/themes/images/webconsole/error.svg
rename : devtools/client/themes/images/info-small.svg => devtools/client/themes/images/webconsole/info.svg
2019-07-04 02:21:44 +03:00
Kris Maglione b459f53a11 Bug 1561061: Move SpecialPowers pref env code to parent and make sane-ish. r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D35706

--HG--
extra : rebase_source : ec33af8c17048c3828d4ca4643e2e17bd2a854c0
extra : source : c2d0956f41d82e76c682f829807e818863cd802a
2019-06-24 13:47:53 -07:00
Maliha Islam 20343ec334 Bug 1558544 - Fix CSS styling for overlapping sliders on color preview, r=gl
Differential Revision: https://phabricator.services.mozilla.com/D34924

--HG--
extra : moz-landing-system : lando
2019-06-13 21:34:10 +00:00
Ciure Andrei f0ee56947e Merge mozilla-central to autoland. a=merge CLOSED TREE
--HG--
extra : rebase_source : dc375a75c39378fa7cb5db8220af0ee49528a568
2019-07-03 00:51:32 +03:00
Ciure Andrei d2edc7f197 Merge inbound to mozilla-central. a=merge 2019-07-03 00:47:39 +03:00
Maliha Islam 2d69e323f1 Bug 1559975 - Make directories python3 compatible r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D35257

--HG--
extra : moz-landing-system : lando
2019-07-02 15:47:34 +00:00
Razvan Maries fd165b8d1b Backed out changeset e43b59849492 (bug 1552278) for debugger failure. CLOSED TREE 2019-07-02 20:44:02 +03:00
David Walsh f17e16215c Bug 1552278 - Improve Quick Open animation r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D36507

--HG--
extra : moz-landing-system : lando
2019-07-02 16:14:45 +00:00
Alex Rosenfeld 2e33d7a927 Bug 1561577 - prevent default when esc is pressed on shortcutsModal r=jlast
Prevent toggling open Split Console with escape is pressed to toggle shortcutsModal closed.

Differential Revision: https://phabricator.services.mozilla.com/D36448

--HG--
extra : moz-landing-system : lando
2019-07-02 16:23:17 +00:00
David Walsh a5e1307a53 Bug 1557895 - Provide a tooltip for directories in the sources tree r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D34264

--HG--
extra : moz-landing-system : lando
2019-06-26 18:19:24 +00:00
Jason Laster e508e7c9eb Bug 1553291 - CodeMirror chokes on large minified files. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D36237

--HG--
extra : moz-landing-system : lando
2019-06-28 17:22:35 +00:00
Connor Brewster 6180037e31 Bug 1561060 - Enable filter tooltip for backdrop-filter in devtools r=gl
Differential Revision: https://phabricator.services.mozilla.com/D36292

--HG--
extra : moz-landing-system : lando
2019-07-02 00:13:17 +00:00
Greg Tatum 56a3070459 Bug 1545582 - Hook JS allocations into the profiler popup; r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D34545

--HG--
extra : moz-landing-system : lando
2019-07-01 21:53:40 +00:00
Logan Smyth e572b4c130 Bug 1561707 - Support excluding listeners from the event collector list. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D36076

--HG--
extra : moz-landing-system : lando
2019-06-27 06:23:54 +00:00
Gabriel Luong 91807979e8 Bug 1558783 - Fixes the subgrid and parent grid highlighter states when both are highlighted. r=mtigley
This fixes 2 issues that we had when the subgrid and parent grid highlighter are shown:

1) When the subgrid and its parent grid container are both highlighted and the parent grid container
is unhighlighted, we need to still show a translucent parent grid container highlight.

2) Avoid showing a translucent parent grid container highlight for a subgrid, when the
parent grid container is already highlighted.

Differential Revision: https://phabricator.services.mozilla.com/D35725
2019-06-24 17:46:04 -04:00
David Walsh 2eae45b214 Bug 1562249 - Improve perceived performance of column breakpoints by rendering offscreen breakpoints r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D36343

--HG--
extra : moz-landing-system : lando
2019-06-28 21:41:43 +00:00
shindli d8e8b80c16 Backed out 2 changesets (bug 1558914) for SM bustages on Array.slice . CLOSED TREE
Backed out changeset ac7ca81ef7c6 (bug 1558914)
Backed out changeset e7fbcb7b6694 (bug 1558914)
2019-07-01 19:02:49 +03:00
Kris Maglione fd61f8b9d4 Bug 1541557: Part 7 - Convert SpecialPowers to use JSWindowActors rather than framescripts. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D35057

--HG--
rename : testing/specialpowers/content/SpecialPowersObserverAPI.jsm => testing/specialpowers/content/SpecialPowersAPIParent.jsm
rename : testing/specialpowers/content/SpecialPowers.jsm => testing/specialpowers/content/SpecialPowersChild.jsm
rename : testing/specialpowers/content/SpecialPowersObserver.jsm => testing/specialpowers/content/SpecialPowersParent.jsm
extra : rebase_source : f3edaf8edc918bb4291b66cb50f4de117f57b2bd
extra : source : 46ff845a7b0cdabf640bb2e3c783735ab68b7cd1
2019-06-12 10:48:29 -07:00
Tom Schuster d572d1339c Bug 1558914 - Remove non-standard Array.sort from devtools test. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D36438

--HG--
extra : moz-landing-system : lando
2019-07-01 12:52:59 +00:00
Nicolas Chevobbe d430ca54b8 Bug 1546917 - Create this.printSimulation in rule.js in the constructor. r=gl.
This fixes an issue in the destroy function without having to guard for the
property existence.

Differential Revision: https://phabricator.services.mozilla.com/D36164

--HG--
extra : moz-landing-system : lando
2019-07-01 13:56:55 +00:00
Jatin a9bd762a6a Bug 1554209 - Added spacing to Accessibility icon in RTL Firefox builds. r=yzen,gl
Before this change, the accessibility icon was too close to the text beside it
on the RTL versions of Firefox.
Now a margin has been added to create sufficient space between the icon and
the text.

Differential Revision: https://phabricator.services.mozilla.com/D36014

--HG--
extra : moz-landing-system : lando
2019-06-30 19:01:21 +00:00
Csoregi Natalia 29f8e6aebd Merge inbound to mozilla-central. a=merge 2019-06-29 12:59:53 +03:00
Kagami Sascha Rosylight 29904ec6bf Bug 1454622: Remove DOMQuad bounds attribute r=bzbarsky
The bounds attribute has been deprecated and shown zero use, and thus this change removes it.

Differential Revision: https://phabricator.services.mozilla.com/D36005

--HG--
extra : moz-landing-system : lando
2019-06-29 02:27:47 +00:00
jaril 6e05066510 Bug 1548369 - Render an SVG in the gap between the token and the preview where it shouldn't unrender the preview right away (WIP)
Still WIP

Differential Revision: https://phabricator.services.mozilla.com/D34910

--HG--
extra : moz-landing-system : lando
2019-06-28 21:17:51 +00:00
shindli 67c134b492 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-06-29 02:23:28 +03:00
Gabriel Luong 1aa241f2d1 Bug 1550030 - Part 1: Implement the DOM mutation breakpoint context menu items in the markup view. r=loganfsmyth,jdescottes
This implements the context menu items for the DOM mutation breakpoint.
In addition, there were some server changes to:
- Update the mutationBreakpoints form for the NodeActor
- Expose the mutationBreakpoints form
- Moved the setMutationBreakpoints method from the Node spec to Walker spec
since the Node spec only consisted of getter methods. It made more sense
that the setter went into the Walker spec to be more consistent with how
the Walker and Node spec have been arranged.

Unit tests will be followed up in Part 2 immediately.

Differential Revision: https://phabricator.services.mozilla.com/D36074
2019-06-26 15:16:22 -04:00
Cosmin Sabou 798a05e2dc Merge mozilla-central to mozilla-inbound. 2019-06-28 19:16:36 +03:00
Bryan Kok b425bf8630 Bug 1519315 - Display CodeMirror's gutter in console input when devtools.webconsole.input.editor is true. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D33995

--HG--
extra : moz-landing-system : lando
2019-06-28 16:27:55 +00:00
Julien Wajsberg a0fc08dc4a Bug 1561886 - Color the profiler icon in blue if the profiler is running at startup r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D36198

--HG--
extra : moz-landing-system : lando
2019-06-28 14:12:00 +00:00
Julian Descottes 91b274be5b Bug 1561565 - Add linting rule and update documentation for setupInParent r=ochameau,yulia,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D36003

--HG--
extra : moz-landing-system : lando
2019-06-28 12:09:25 +00:00
Julien Wajsberg 050b115653 Bug 1561875 - Increase the profiler's popup's width to fix layout issues on Linux r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D36181

--HG--
extra : moz-landing-system : lando
2019-06-27 23:01:47 +00:00
Razvan Caliman 8eb3b5c195 Bug 1561871 - Restore default numeric value for letter-spacing to 0 in the Font Editor. r=gl
Fix for accidental regression in D35394 form careless copy / paste.

Differential Revision: https://phabricator.services.mozilla.com/D36180

--HG--
extra : moz-landing-system : lando
2019-06-27 17:07:43 +00:00
Nicolas Chevobbe 4257b47fac Bug 1519105 - Add a keyboard shortcut to switch between inline and editor mode. r=Honza.
We use Cmd/Ctrl + B to switch between inline and editor mode. This
should be familiar for VSCode users as it toggles the file sidebar.
When changing the layout, we persist the choice into the editor pref
so the user keeps the same layout the next time they open the console.

Differential Revision: https://phabricator.services.mozilla.com/D34718

--HG--
extra : moz-landing-system : lando
2019-06-28 09:25:59 +00:00
Nicolas Chevobbe 66150262ef Bug 1519312 - Render the console input to the left of the panel when editor preference is true; r=Honza.
When the editor preference is true, a CSS class is added to
the panel that allow us to shift the layout to a CSS Grid, where
the input panel is on the left and the output on the right.

A toolbar is added to be able to execute an expression when in
editor mode.

Differential Revision: https://phabricator.services.mozilla.com/D17096

--HG--
extra : moz-landing-system : lando
2019-06-27 13:13:32 +00:00
Nicolas Chevobbe 43fd57f33f Bug 1560804 - Fix double scrollbar in network message detail. r=Honza.
We take this as an opportunity to fix the alignment between the XHR
badge and the URL.

Differential Revision: https://phabricator.services.mozilla.com/D36297

--HG--
extra : moz-landing-system : lando
2019-06-28 08:50:43 +00:00
Jefry Lagrange bd7874038e Bug 1517728 - Export Console content to file. .
Add a context menu entry to export the console output to a file.
We group the 2 export entries into a submenu.

Differential Revision: https://phabricator.services.mozilla.com/D22158

--HG--
extra : moz-landing-system : lando
2019-06-28 08:28:53 +00:00
tanhengyeow 44c6145f6e Bug 1559398 - Implement table and preview sections in WebSocket side panel. r=Honza
Implement table and preview sections in WebSocket side panel.

Differential Revision: https://phabricator.services.mozilla.com/D35983

--HG--
extra : moz-landing-system : lando
2019-06-28 07:24:59 +00:00
lloan fb05c2c381 Bug 1556350 - Each child in an array or iterator should have a unique key prop. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D36038

--HG--
extra : moz-landing-system : lando
2019-06-28 07:17:05 +00:00
Gerald Squelart b13eeec2e9 Bug 1552063 - Use PowerOfTwo and PowerOfTwoMask in profilers - r=gregtatum
PowerOfTwo makes for a cleaner and more expressive interface, showing that the
profiler will use a power-of-2 storage size.

Using PowerOfTwoMask in ProfilerBuffer also makes it more obvious that we want
cheap modulo operations.
And we don't need to keep the original capacity, as it's only used once and can
easily be recomputed from the mask.

Differential Revision: https://phabricator.services.mozilla.com/D36027

--HG--
extra : moz-landing-system : lando
2019-06-28 07:12:57 +00:00
Charlie Marlow 8d6b1bcaa4 Bug 1561131: Adding parsing support for text-decoration-skip-ink r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D35831

--HG--
extra : moz-landing-system : lando
2019-06-27 21:34:33 +00:00
Andreea Pavel ea400c1438 Backed out changeset 21d365e43fec (bug 1561131) for failing test_bug1112014.html on a CLOSED TREE 2019-06-28 00:12:41 +03:00
Andreea Pavel c41e3df739 Bug 1559547 - disabled browser_dbg-worker-scopes.js on linux asan r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D36232

--HG--
extra : moz-landing-system : lando
2019-06-27 19:03:46 +00:00
Charlie Marlow 3f0f7ff856 Bug 1561131: Adding parsing support for text-decoration-skip-ink r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D35831

--HG--
extra : moz-landing-system : lando
2019-06-27 18:09:10 +00:00
Razvan Caliman ad206d66fc Bug 1561639 - Simplify handling for font variation instances in Font Editor. r=gl
The Redux action/reducer setup for handling selecting and applying font variation instances is needlessly complex. The indirection is not necessary.

The flow is as follows:
- When a font variation instance (provided by some variable font files) is selected from the _Instances_ select menu, update all variation axes with the values associated with that instance.

- When the user makes any manual change to any of the axis values, save all axis values associated with a "Custom" variation instance. This enables the user to revert to them.

This patch removes the needless indirection about saving the axis values and applying the "Custom" variation instance. The logic is now moved to the UPDATE_AXIS_VALUE reducer.

Differential Revision: https://phabricator.services.mozilla.com/D36051

--HG--
extra : moz-landing-system : lando
2019-06-27 13:20:01 +00:00
Herpiko Dwi Aguno 6edc04621b Bug 1548076. Let the devtools gain focus even if the click hits an empty area on UI. r=jdescottes,yzen
Differential Revision: https://phabricator.services.mozilla.com/D35686

--HG--
extra : moz-landing-system : lando
2019-06-27 13:01:28 +00:00
Nicolas Chevobbe 68245b3595 Bug 1548866 - Fix intermittent failure on browser_webconsole_keyboard_accessibility.js. r=jdescottes.
The failure was happening on window7, which I guess is
pretty slow. Looking at the failure screenshot I was able
to see that the console output was empty.
The test is initially waiting for a 100 messages to be displayed
in the console output.
We are using the waitFor helper function for that. waitFor by default
call the function argument 500 times, at a 10ms interval, and then
fail.
Here, we bump the interval to 100ms, and set the max number of
tries to 500, in order to give extra time for the 100 messages
to be rendered in the output.

Pushed a TV job a re-ran it a few times without seeing the failure,
so the fix should be good.

Differential Revision: https://phabricator.services.mozilla.com/D36039

--HG--
extra : moz-landing-system : lando
2019-06-27 12:45:56 +00:00
tanhengyeow c5423a8f4a Bug 1561676 - WebSocket panel crashes in WebConsole. r=nchevobbe,Honza
Hide WebSocketsPanel in console.

Differential Revision: https://phabricator.services.mozilla.com/D36158

--HG--
extra : moz-landing-system : lando
2019-06-27 11:54:37 +00:00
Nicolas Chevobbe c1f5c82eda Bug 1560320 - Dismiss autocomplete on Ctrl+A on OSX. r=Honza.
Ctrl + A moves the cursor to the beginning of the line,
so we need to dismiss autocomplete.
A test case is added to make sure this behaves as
expected.

Differential Revision: https://phabricator.services.mozilla.com/D35573

--HG--
extra : moz-landing-system : lando
2019-06-27 11:48:34 +00:00
Nicolas Chevobbe 06b2ed9350 Bug 1559329 - Set "group similar messages" to true by default. r=Honza.
This was making browser_webconsole_scroll.js fail.
After some investigation, I found that the `isInWarningGroup`
prop, a function defined in `mapStateToProp` was causing a
re-rendering (because we were creating a new function each
time), impacting the shouldScrollToBottom behaviour.

To fix this, we no longer create a `isInWarningGroup` prop,
but directly use the `isMessageInWarningGroup` selector, which
was modified to take an array of visible messages instead of
the whole state.

Differential Revision: https://phabricator.services.mozilla.com/D35016

--HG--
extra : moz-landing-system : lando
2019-06-27 11:42:15 +00:00
Nicolas Chevobbe 81c6695582 Bug 1559335 - Fix messages ordering when 2 messages have the same timestamp. r=Honza.
If 2 messages are emitted during the same microsecond,
their timestamps are similar, and the sorting we do when
filtering for warning groups might be erroneous.
In such case, we now check the message id, to see which
one we handled first, which should be enough.

A test is added to ensure this works as expected. Basically,
we now render 2 logs one after the another, to increase the
chance they'll get the same timestamp.
The updated test was failing without the fix, and seems to
pass with it.

Differential Revision: https://phabricator.services.mozilla.com/D35015

--HG--
extra : moz-landing-system : lando
2019-06-27 11:41:56 +00:00
Dorel Luca 357997da30 Backed out changeset 5f0520d9b5de (bug 1561639) for ESlint failure 2019-06-27 14:06:28 +03:00
Razvan Caliman 5a3ef1cbf6 Bug 1561639 - Simplify handling for font variation instances in Font Editor. r=gl
The Redux action/reducer setup for handling selecting and applying font variation instances is needlessly complex. The indirection is not necessary.

The flow is as follows:
- When a font variation instance (provided by some variable font files) is selected from the _Instances_ select menu, update all variation axes with the values associated with that instance.

- When the user makes any manual change to any of the axis values, save all axis values associated with a "Custom" variation instance. This enables the user to revert to them.

This patch removes the needless indirection about saving the axis values and applying the "Custom" variation instance. The logic is now moved to the UPDATE_AXIS_VALUE reducer.

Differential Revision: https://phabricator.services.mozilla.com/D36051

--HG--
extra : moz-landing-system : lando
2019-06-27 10:35:31 +00:00
Coroiu Cristina f91bd38732 Merge inbound to mozilla-central a=merge 2019-06-27 12:36:00 +03:00
Nicholas Nethercote ca8e78069d Bug 1561491 - Make gfx.* static prefs follow the naming convention. r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D35975

--HG--
extra : rebase_source : 9090ac828f1da9582510975047d5ad59a228dda5
2019-06-26 10:38:09 +10:00
Gurzau Raul f5eb98192b Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-06-27 01:04:55 +03:00
Jason Laster 890892c4e2 Bug 1560445 - Extract classes from protocol.js. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D35502

--HG--
rename : devtools/shared/protocol.js => devtools/shared/protocol/Actor.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/Actor/generateActorSpec.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/Front.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/Front/FrontClassWithSpec.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/Pool.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/Request.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/Response.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/types.js
rename : devtools/shared/protocol.js => devtools/shared/protocol/utils.js
extra : moz-landing-system : lando
2019-06-26 15:53:20 +00:00
Logan Smyth 76d6b8f5c2 Bug 1550835 - DOM mutation breakpoint server API. r=jlast,gl
Differential Revision: https://phabricator.services.mozilla.com/D33528

--HG--
extra : moz-landing-system : lando
2019-06-26 06:23:03 +00:00
Florens Verschelde 2eb0a8831a Bug 1558630 - Move Netmonitor tab to 4th place to reflect popularity; r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D35397

--HG--
extra : moz-landing-system : lando
2019-06-26 14:10:38 +00:00
Nicolas Chevobbe 04e73a0fed Bug 1526886 - Convert evaluateJsAsync from Promise to an async function. r=yulia.
We take this as an opportunity to clean-up the function that
waits for the evaluation result.
This change was causing an issue in main.js `_queueResponse`.
Previously, since `evaluateJsAsync` wasn't returning anything,
`_queueResponse` wouldn't be called (See https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/devtools/server/main.js#1305-1308).
But now `ret` isn't falsy (the async function always return a
Promise), which means we ended up trying to send a response.
To fix this, we simply check if the response isn't falsy, or we
bail out.

Differential Revision: https://phabricator.services.mozilla.com/D35985

--HG--
extra : moz-landing-system : lando
2019-06-26 15:28:04 +00:00
Nicolas Chevobbe 082c14256e Bug 1526886 - Fix nits in main.js error messages. r=yulia.
Differential Revision: https://phabricator.services.mozilla.com/D35984

--HG--
extra : moz-landing-system : lando
2019-06-26 15:27:16 +00:00
jaril 627c8a353c Bug 1560831 - Add getting started docs for setting up mozilla-central. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D35631

--HG--
extra : moz-landing-system : lando
2019-06-25 15:43:36 +00:00
Armando Ferreira a7e460857f Bug 1522104 - Re-organise devtools/client/webconsole/components/ folder. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D35932

--HG--
rename : devtools/client/webconsole/components/FilterBar.js => devtools/client/webconsole/components/FilterBar/FilterBar.js
rename : devtools/client/webconsole/components/FilterButton.js => devtools/client/webconsole/components/FilterBar/FilterButton.js
rename : devtools/client/webconsole/components/FilterCheckbox.js => devtools/client/webconsole/components/FilterBar/FilterCheckbox.js
rename : devtools/client/webconsole/components/ConfirmDialog.js => devtools/client/webconsole/components/Input/ConfirmDialog.js
rename : devtools/client/webconsole/components/JSTerm.js => devtools/client/webconsole/components/Input/JSTerm.js
rename : devtools/client/webconsole/components/ReverseSearchInput.css => devtools/client/webconsole/components/Input/ReverseSearchInput.css
rename : devtools/client/webconsole/components/ReverseSearchInput.js => devtools/client/webconsole/components/Input/ReverseSearchInput.js
rename : devtools/client/webconsole/components/CollapseButton.js => devtools/client/webconsole/components/Output/CollapseButton.js
rename : devtools/client/webconsole/components/ConsoleOutput.js => devtools/client/webconsole/components/Output/ConsoleOutput.js
rename : devtools/client/webconsole/components/ConsoleTable.js => devtools/client/webconsole/components/Output/ConsoleTable.js
rename : devtools/client/webconsole/components/GripMessageBody.js => devtools/client/webconsole/components/Output/GripMessageBody.js
rename : devtools/client/webconsole/components/Message.js => devtools/client/webconsole/components/Output/Message.js
rename : devtools/client/webconsole/components/MessageContainer.js => devtools/client/webconsole/components/Output/MessageContainer.js
rename : devtools/client/webconsole/components/MessageIcon.js => devtools/client/webconsole/components/Output/MessageIcon.js
rename : devtools/client/webconsole/components/MessageIndent.js => devtools/client/webconsole/components/Output/MessageIndent.js
rename : devtools/client/webconsole/components/MessageRepeat.js => devtools/client/webconsole/components/Output/MessageRepeat.js
rename : devtools/client/webconsole/components/message-types/CSSWarning.js => devtools/client/webconsole/components/Output/message-types/CSSWarning.js
rename : devtools/client/webconsole/components/message-types/ConsoleApiCall.js => devtools/client/webconsole/components/Output/message-types/ConsoleApiCall.js
rename : devtools/client/webconsole/components/message-types/ConsoleCommand.js => devtools/client/webconsole/components/Output/message-types/ConsoleCommand.js
rename : devtools/client/webconsole/components/message-types/DefaultRenderer.js => devtools/client/webconsole/components/Output/message-types/DefaultRenderer.js
rename : devtools/client/webconsole/components/message-types/EvaluationResult.js => devtools/client/webconsole/components/Output/message-types/EvaluationResult.js
rename : devtools/client/webconsole/components/message-types/NetworkEventMessage.js => devtools/client/webconsole/components/Output/message-types/NetworkEventMessage.js
rename : devtools/client/webconsole/components/message-types/PageError.js => devtools/client/webconsole/components/Output/message-types/PageError.js
rename : devtools/client/webconsole/components/message-types/WarningGroup.js => devtools/client/webconsole/components/Output/message-types/WarningGroup.js
rename : devtools/client/webconsole/components/message-types/moz.build => devtools/client/webconsole/components/Output/message-types/moz.build
extra : moz-landing-system : lando
2019-06-26 09:19:54 +00:00
Cosmin Sabou 2fa3b2ee5b Merge mozilla-inbound to mozilla-central. a=merge 2019-06-26 06:58:03 +03:00
arthur.iakab 785bee02e8 Merge mozilla-central to mozilla-inbound 2019-06-26 01:09:31 +03:00
janelledement bec014efe2 Bug 1548933 Preview should ignore search results. r=davidwalsh
This patch addresses bug 1548933.  It adds/removes the preview highlight to related tokens (if necessary) as well as the target token. This happens when one token is broken into pieces due to a search query that only covers part of the token.

Differential Revision: https://phabricator.services.mozilla.com/D34749

--HG--
extra : moz-landing-system : lando
2019-06-25 16:46:14 +00:00
Julian Descottes 9d682b17d1 Bug 1553042 - Enable new about:debugging on all channels r=daisuke
Differential Revision: https://phabricator.services.mozilla.com/D35792

--HG--
extra : moz-landing-system : lando
2019-06-25 18:36:02 +00:00
Jim Porter 32b61264e9 Bug 1551992 - Compress profile data before sending to perf-html; r=mstange,julienw
Differential Revision: https://phabricator.services.mozilla.com/D33399

--HG--
extra : moz-landing-system : lando
2019-06-25 09:54:49 +00:00
David Walsh e65a1b74dd Bug 1486416 - Show extension name in the debugger r=jlast,rpl,jdescottes
Showing moz-extension URLs in the debugger is not helpful -- we should display the name of the extension instead.

Differential Revision: https://phabricator.services.mozilla.com/D34427

--HG--
extra : moz-landing-system : lando
2019-06-25 17:17:39 +00:00
David Walsh 8292ca922e Bug 1560642 - Provide URLs as tooltips for hidden tabs r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D35578

--HG--
extra : moz-landing-system : lando
2019-06-24 19:02:03 +00:00