We'd like to enable the Origin header for all eligible reqeusts, which include POST.
The test should be adjusted.
Differential Revision: https://phabricator.services.mozilla.com/D33382
--HG--
extra : moz-landing-system : lando
We'd like to enable the Origin header for all eligible reqeusts, which include POST.
The test should be adjusted.
Differential Revision: https://phabricator.services.mozilla.com/D33382
--HG--
extra : moz-landing-system : lando
We use the openNetworkDetails prop which is already in use
in the netmonitor to collapse the message if the parameter
passed to the function is falsy (i.e. the panel is already
displayed)
Depends on D37388
Differential Revision: https://phabricator.services.mozilla.com/D37389
--HG--
extra : moz-landing-system : lando
This prop is only used when hideToggleButton isn't truthy.
In the case of the console, it won't ever be called, so
it's not mandatory.
Differential Revision: https://phabricator.services.mozilla.com/D37388
--HG--
extra : moz-landing-system : lando
Some people found that the ConfirmDialog was getting into their
way when typing into the console, as it was stealing the focus.
This patch fixes this by not focusing the ConfirmDialog when
we show it, so the user can still type.
This means that we now handle the dialog confirm and dismiss from
JSTerm, when the former is displayed.
Since it wasn't clear how you could close the popup, we add a close
button that makes it very obvious.
This means we can drop the key handler in the dialog as the jsterm
is always focused.
We also simply remove the feature to open the MDN link on `?` key
stroke as it's not discoverable and was the only part of the
panel where you could do such thing.
Existing tests are adapted and extended to cover the new behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D36174
--HG--
extra : moz-landing-system : lando
Remove devtools.netmonitor.features.resizeColumns pref and any reference to it.
Differential Revision: https://phabricator.services.mozilla.com/D37159
--HG--
extra : moz-landing-system : lando
The console fails to connect to the server because
the getCachedMessages function throws on GMail.
This is because we try to access a property on a
cross-origin object, window.windowUtils, in
getInnerWindowId.
Wrapping the access to the property fixes the issue.
A test is added to make sure we don't regress.
// TODO: The test isn't failing without the fix,
so it should be re-written.
Differential Revision: https://phabricator.services.mozilla.com/D37069
--HG--
extra : moz-landing-system : lando
We were using Array.from to get an array of all the characters, and
be able to slice parts of the strings to run some checks.
This had the disadvantage of being quite slow on very large strings,
at a point where we introduced a bail out mechanism into the function
to not block the content page.
This patch switches to `String.prototype[Symbol.iterator]` to loop
over all the character, and removes lots of array and string manipulations.
On the same, super-large, string, the function cost went from 6700ms to
less than 200ms.
Differential Revision: https://phabricator.services.mozilla.com/D36572
--HG--
extra : moz-landing-system : lando
Already tested via toolbox menus in devtools/client/framework/test/browser_toolbox_zoom_popup.js
Could open a follow up to allow for other anchor points than bottom-left.
Differential Revision: https://phabricator.services.mozilla.com/D37044
--HG--
extra : moz-landing-system : lando
We were clearing the completion text all the time to prevent
a visual glitch while typing (See Bug 1491776). But since we
are now waiting for 75ms before calling the autocomplete
function (which triggers the autocompletion text update), we
have a flash of the completion text, which isn't ideal.
In this patch, we check if the typed letters match the begining
of the completion text, and if they do, we don't clear the
completion text.
In the same time, we set the completion text in absolute position
so it doesn't jump when the new letter is added in the CodeMirror
document.
Finally, we change how the Editor pipe events from CodeMirror to
include parameters, so we can use them in JsTerm.
Differential Revision: https://phabricator.services.mozilla.com/D36163
--HG--
extra : moz-landing-system : lando
Also changed the border radius to be consistent between doorhanger and arrow style tooltips.
There are still subtle differences between the XUL+arrow/HTML+arrow/XUL+doorhanger, but for now I would just like to fix this before we merge to 70.
Strictly using the photon shadow for doorhangers is too subtle and too inconsistent with our other tooltips, so I used shadow-20.
Differential Revision: https://phabricator.services.mozilla.com/D36767
--HG--
extra : moz-landing-system : lando
Ensure source links for selectors in the Rules view and warning links in Web Console for minified CSS go to the right location in the Style Editor after applying automatic prettification.
This only works for linked stylesheets. [Bug 1169770](https://bugzilla.mozilla.org/show_bug.cgi?id=1169770) needs to be fixed first before this can work correctly on inline minified stylesheets.
This patch augments the `prettifyCSS()` method to generate the mappings necessary to generate a sourcemap from the original to the prettified source. It uses these mappings to translate the cursor position when invoking the Style Editor to be opened at a specific location.
The mappings from the minified to the prettified source are used only until the stylesheet is changed in the Style Editor. Upon editing the source in the Style Editor, the associated mappings are cleared because it's likely they have been rendered invalid.
The updated stylesheet will already be prettified so it bypasses the `prettifyCSS()` method, thus avoiding the need to re-generate mappings. New CSS warnings will be listed in the Web Console which point to the right location in the edited stylesheet (the old warnings no longer point to the right place, but that's an acceptable side-effect). The Rules view in the Inspector also lists selectors with the new positions within the edited stylesheet.
Differential Revision: https://phabricator.services.mozilla.com/D36585
--HG--
extra : moz-landing-system : lando
Prevent toggling open Split Console with escape is pressed to toggle shortcutsModal closed.
Differential Revision: https://phabricator.services.mozilla.com/D36448
--HG--
extra : moz-landing-system : lando
This fixes 2 issues that we had when the subgrid and parent grid highlighter are shown:
1) When the subgrid and its parent grid container are both highlighted and the parent grid container
is unhighlighted, we need to still show a translucent parent grid container highlight.
2) Avoid showing a translucent parent grid container highlight for a subgrid, when the
parent grid container is already highlighted.
Differential Revision: https://phabricator.services.mozilla.com/D35725
This fixes an issue in the destroy function without having to guard for the
property existence.
Differential Revision: https://phabricator.services.mozilla.com/D36164
--HG--
extra : moz-landing-system : lando
Before this change, the accessibility icon was too close to the text beside it
on the RTL versions of Firefox.
Now a margin has been added to create sufficient space between the icon and
the text.
Differential Revision: https://phabricator.services.mozilla.com/D36014
--HG--
extra : moz-landing-system : lando
The bounds attribute has been deprecated and shown zero use, and thus this change removes it.
Differential Revision: https://phabricator.services.mozilla.com/D36005
--HG--
extra : moz-landing-system : lando
This implements the context menu items for the DOM mutation breakpoint.
In addition, there were some server changes to:
- Update the mutationBreakpoints form for the NodeActor
- Expose the mutationBreakpoints form
- Moved the setMutationBreakpoints method from the Node spec to Walker spec
since the Node spec only consisted of getter methods. It made more sense
that the setter went into the Walker spec to be more consistent with how
the Walker and Node spec have been arranged.
Unit tests will be followed up in Part 2 immediately.
Differential Revision: https://phabricator.services.mozilla.com/D36074
We use Cmd/Ctrl + B to switch between inline and editor mode. This
should be familiar for VSCode users as it toggles the file sidebar.
When changing the layout, we persist the choice into the editor pref
so the user keeps the same layout the next time they open the console.
Differential Revision: https://phabricator.services.mozilla.com/D34718
--HG--
extra : moz-landing-system : lando
When the editor preference is true, a CSS class is added to
the panel that allow us to shift the layout to a CSS Grid, where
the input panel is on the left and the output on the right.
A toolbar is added to be able to execute an expression when in
editor mode.
Differential Revision: https://phabricator.services.mozilla.com/D17096
--HG--
extra : moz-landing-system : lando
We take this as an opportunity to fix the alignment between the XHR
badge and the URL.
Differential Revision: https://phabricator.services.mozilla.com/D36297
--HG--
extra : moz-landing-system : lando
Add a context menu entry to export the console output to a file.
We group the 2 export entries into a submenu.
Differential Revision: https://phabricator.services.mozilla.com/D22158
--HG--
extra : moz-landing-system : lando
PowerOfTwo makes for a cleaner and more expressive interface, showing that the
profiler will use a power-of-2 storage size.
Using PowerOfTwoMask in ProfilerBuffer also makes it more obvious that we want
cheap modulo operations.
And we don't need to keep the original capacity, as it's only used once and can
easily be recomputed from the mask.
Differential Revision: https://phabricator.services.mozilla.com/D36027
--HG--
extra : moz-landing-system : lando
The Redux action/reducer setup for handling selecting and applying font variation instances is needlessly complex. The indirection is not necessary.
The flow is as follows:
- When a font variation instance (provided by some variable font files) is selected from the _Instances_ select menu, update all variation axes with the values associated with that instance.
- When the user makes any manual change to any of the axis values, save all axis values associated with a "Custom" variation instance. This enables the user to revert to them.
This patch removes the needless indirection about saving the axis values and applying the "Custom" variation instance. The logic is now moved to the UPDATE_AXIS_VALUE reducer.
Differential Revision: https://phabricator.services.mozilla.com/D36051
--HG--
extra : moz-landing-system : lando
The failure was happening on window7, which I guess is
pretty slow. Looking at the failure screenshot I was able
to see that the console output was empty.
The test is initially waiting for a 100 messages to be displayed
in the console output.
We are using the waitFor helper function for that. waitFor by default
call the function argument 500 times, at a 10ms interval, and then
fail.
Here, we bump the interval to 100ms, and set the max number of
tries to 500, in order to give extra time for the 100 messages
to be rendered in the output.
Pushed a TV job a re-ran it a few times without seeing the failure,
so the fix should be good.
Differential Revision: https://phabricator.services.mozilla.com/D36039
--HG--
extra : moz-landing-system : lando
Ctrl + A moves the cursor to the beginning of the line,
so we need to dismiss autocomplete.
A test case is added to make sure this behaves as
expected.
Differential Revision: https://phabricator.services.mozilla.com/D35573
--HG--
extra : moz-landing-system : lando
This was making browser_webconsole_scroll.js fail.
After some investigation, I found that the `isInWarningGroup`
prop, a function defined in `mapStateToProp` was causing a
re-rendering (because we were creating a new function each
time), impacting the shouldScrollToBottom behaviour.
To fix this, we no longer create a `isInWarningGroup` prop,
but directly use the `isMessageInWarningGroup` selector, which
was modified to take an array of visible messages instead of
the whole state.
Differential Revision: https://phabricator.services.mozilla.com/D35016
--HG--
extra : moz-landing-system : lando
If 2 messages are emitted during the same microsecond,
their timestamps are similar, and the sorting we do when
filtering for warning groups might be erroneous.
In such case, we now check the message id, to see which
one we handled first, which should be enough.
A test is added to ensure this works as expected. Basically,
we now render 2 logs one after the another, to increase the
chance they'll get the same timestamp.
The updated test was failing without the fix, and seems to
pass with it.
Differential Revision: https://phabricator.services.mozilla.com/D35015
--HG--
extra : moz-landing-system : lando
The Redux action/reducer setup for handling selecting and applying font variation instances is needlessly complex. The indirection is not necessary.
The flow is as follows:
- When a font variation instance (provided by some variable font files) is selected from the _Instances_ select menu, update all variation axes with the values associated with that instance.
- When the user makes any manual change to any of the axis values, save all axis values associated with a "Custom" variation instance. This enables the user to revert to them.
This patch removes the needless indirection about saving the axis values and applying the "Custom" variation instance. The logic is now moved to the UPDATE_AXIS_VALUE reducer.
Differential Revision: https://phabricator.services.mozilla.com/D36051
--HG--
extra : moz-landing-system : lando
We take this as an opportunity to clean-up the function that
waits for the evaluation result.
This change was causing an issue in main.js `_queueResponse`.
Previously, since `evaluateJsAsync` wasn't returning anything,
`_queueResponse` wouldn't be called (See https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/devtools/server/main.js#1305-1308).
But now `ret` isn't falsy (the async function always return a
Promise), which means we ended up trying to send a response.
To fix this, we simply check if the response isn't falsy, or we
bail out.
Differential Revision: https://phabricator.services.mozilla.com/D35985
--HG--
extra : moz-landing-system : lando
This patch addresses bug 1548933. It adds/removes the preview highlight to related tokens (if necessary) as well as the target token. This happens when one token is broken into pieces due to a search query that only covers part of the token.
Differential Revision: https://phabricator.services.mozilla.com/D34749
--HG--
extra : moz-landing-system : lando
Showing moz-extension URLs in the debugger is not helpful -- we should display the name of the extension instead.
Differential Revision: https://phabricator.services.mozilla.com/D34427
--HG--
extra : moz-landing-system : lando
* Use XScopes data to display original varaibles (prototype)
* Move DWARF debugger logic to the separate package.
Differential Revision: https://phabricator.services.mozilla.com/D35367
--HG--
rename : devtools/client/debugger/packages/devtools-source-map/src/utils/convertToJSON.js => devtools/client/debugger/packages/devtools-wasm-dwarf/src/convertToJSON.js
rename : devtools/client/debugger/packages/devtools-source-map/wasm/dwarf_to_json.wasm => devtools/client/debugger/packages/devtools-wasm-dwarf/wasm/dwarf_to_json.wasm
extra : moz-landing-system : lando
due to leaks related to this test on other linux platforms, we might want to disable this
test on linux in general
Differential Revision: https://phabricator.services.mozilla.com/D35199
--HG--
extra : moz-landing-system : lando
Due to how highlighters work, it requires the inspector to be initialized.
It can happen than the user will mouseenter/mouseout on an element that
calls highlight/unhighlight very quickly.
Since the hightlight can take some time, it might happen that the unhighlight
call is handled first, before the highlight call, meaning that we now have an
highlighter displayed, even though the user isn't hovering anything that
should cause this anymore.
This patch introduces a new toolbox function called `getHighlighter` that
returns an object with a `highlight and a `unhighlight` function.
We keep a reference to any possible pending `highlight` call so we can wait
for it to be done in `unhighlight`, before destroying it.
The console makes use of the new helper function, and a test is added to ensure
we don't have zombie highlighters anymore.
Differential Revision: https://phabricator.services.mozilla.com/D34562
--HG--
extra : moz-landing-system : lando
- Uses theme-twisty for the triangle icon.
- Icon now has the correct orientation in RTL (handled by theme-twisty styles in common.css).
- Header rows are now always 24px tall excluding the border (before they were all 25px tall, including the first one.
- Accessible text color for event headers (dark theme, was 4.12).
- Make the event name 12px (our usual "biggish font" size, used in accordion headers and tab labels).
Differential Revision: https://phabricator.services.mozilla.com/D34385
--HG--
extra : moz-landing-system : lando
Remove conversion for computed `line-height` value to unitless value to prevent Font Editor from crashing when the patch from [Bug 1536871](https://bugzilla.mozilla.org/show_bug.cgi?id=1536871) is applied (the default computed value for `line-height` is no longer numeric).
Add support for `normal` keyword value for `line-height` as the default returned by `getComputedStyle()`, similar to existing behavior for `letter-spacing`.
Fix misnomer of the class in `LetterSpacing.js` component.
Differential Revision: https://phabricator.services.mozilla.com/D35394
--HG--
extra : moz-landing-system : lando
A test case is added to make sure this is fixed.
We also add the ability to not run a given test case in the color test.
Differential Revision: https://phabricator.services.mozilla.com/D35493
--HG--
extra : moz-landing-system : lando
One of the css rules appied to this element defines flex: 1 1 auto; but since this element
is not inside a flex container, this declaration is inactive and was removed.
The failures indicated that some warning messages
were placed before the navigation marker, when they
should be placed after.
We now listen to the `load` event instead of `DOMContentLoaded`
to ensure the page is fully loaded and the warning gets
reported into the right page session.
Differential Revision: https://phabricator.services.mozilla.com/D35014
--HG--
extra : moz-landing-system : lando
For content HTML/XHTML copy/paste should always be enabled, but for chrome
docs we can support enabling/disabling copy/paste.
Also, restores tests to how they were before copy/paste was always enabled.
Differential Revision: https://phabricator.services.mozilla.com/D34805
--HG--
extra : moz-landing-system : lando
The top-level App component forcefully resets focus to the console input when something in the output gains focus, e.g disclosure toggles, and the clear output button.While this is useful for mouse users when typing, it breaks reading flow for screen reader users when reviewing output, being sent back to input when interacting with disclosures.
This commit prevents the unwanted focus behaviour when clicking by suppressing it in an onMouseDown, and prevents the click event from bubbling to the App component so focus doesn't get reset.
Differential Revision: https://phabricator.services.mozilla.com/D28178
--HG--
extra : moz-landing-system : lando
Some colors weren't matching the UI spec document,
and the padding was a bit off.
Differential Revision: https://phabricator.services.mozilla.com/D34701
--HG--
extra : moz-landing-system : lando
This patch removes the preference we were using to
display the checkbox in the Browser Console; it's now
always displayed there.
We flip the pref to show content messages ini tests that need them.
Differential Revision: https://phabricator.services.mozilla.com/D34996
--HG--
extra : moz-landing-system : lando
For content HTML/XHTML copy/paste should always be enabled, but for chrome
docs we can support enabling/disabling copy/paste.
Also, restores tests to how they were before copy/paste was always enabled.
Differential Revision: https://phabricator.services.mozilla.com/D34805
--HG--
extra : moz-landing-system : lando
This was a difficult situation. We are not waiting for a server response when setting or
removing breakpoints. The result is that the server has not completed those actions by the time the
test closed, leaving setBreakpoint or removeBreakpoint requests hanging, causing a number of tests
to fail. In order to get around this, I made the panel action "SET_BREAKPOINT" and
"REMOVE_BREAKPOINT" aware of the server response. This involved rewriting the helper methods
`clientSetBreakpoint` and `clientRemoveBreakpoint` so that they no longer relied on the dispatch.
It was not possible to use the dispatches to wait, as they had no event exposed to the tests,
especially in cases when we triggered these requests via button presses.
Differential Revision: https://phabricator.services.mozilla.com/D32710
--HG--
extra : moz-landing-system : lando
this is the weird one. we have a Debugger.executeSoon call for the destruction of the host.
However, before this happened immediately after the test closed. Now, it happens a little later, and
this messes up the data set up. The comment says that we cannot remove this.
Differential Revision: https://phabricator.services.mozilla.com/D32722
--HG--
extra : moz-landing-system : lando
The webConsoleFront and the threadClient front both used to depend on the debugger-client
to destroy them via registered clients. This is no longer the case, and this code can be deleted
Differential Revision: https://phabricator.services.mozilla.com/D32699
--HG--
extra : moz-landing-system : lando
In order for a front to be available to getFront on a given target, it must be first --
registered on the target scope, and second -- set on the target's targetForm. This makes that update
for both browsing context and worker targets. This works as part of a work around until we can get
the server into better shape.
Differential Revision: https://phabricator.services.mozilla.com/D32698
--HG--
extra : moz-landing-system : lando
The resume case is much more complex than the other events, because we do an
unsafeSynchronize to send an unsolicited pause. In the old system, the resume response would have
been ignored, but that is no longer the case. With the new system, we do not want to send a response
to a resume action if it did not come from the UI. This also update the debugger panel code to
accept a resume.
Differential Revision: https://phabricator.services.mozilla.com/D32697
--HG--
extra : moz-landing-system : lando
This is part one of removing threadClient specifics out of the debuggerClient. We were
managing messages from the thread client in a special way -- this was the "Unsolicited Pauses"
object that we had before. This patch updates the threadClient to use Front style events. This
required updating the spec for the threadClient, and several of the methods. What has not been fully
migrated here is the "resumed" event, as this is much more complex. This is taken care of in the
next patch.
Differential Revision: https://phabricator.services.mozilla.com/D32695
--HG--
extra : moz-landing-system : lando
This is the first part of the threadClient refactor. It only moves the methods to the new
front. and does some basic fixes.
Differential Revision: https://phabricator.services.mozilla.com/D32692
--HG--
extra : moz-landing-system : lando
make sure we have a copy of thread client for old servers
Differential Revision: https://phabricator.services.mozilla.com/D34179
--HG--
rename : devtools/shared/client/thread-client.js => devtools/shared/client/deprecated-thread-client.js
extra : moz-landing-system : lando
This patch removes the preference we were using to
display the checkbox in the Browser Console; it's now
always displayed there.
Differential Revision: https://phabricator.services.mozilla.com/D34996
--HG--
extra : moz-landing-system : lando
In an attempt to reduce intermittent failures, the pref apz.keyboard.enabled is set to false. However, this preference is only ever read once, on startup before any JS test has a chance to run and modify the pref..
It doesn't do what it was thought to do.
Differential Revision: https://phabricator.services.mozilla.com/D34860
--HG--
extra : moz-landing-system : lando
We take this as an opportunity to add tests for `align-self` as well.
This requires the test to change a bit so we can create more than one
element in order to test the inactive property helper on grid/flex item
(i.e. with a parent flex/grid container).
This is done by providing a `createTestElement` function in the test case,
that creates whatever nodes it need and append it in the rootNode parameter.
The function then returns the element that needs to be tested with isPropertyUsed.
Differential Revision: https://phabricator.services.mozilla.com/D34714
--HG--
extra : moz-landing-system : lando
This was a difficult situation. We are not waiting for a server response when setting or
removing breakpoints. The result is that the server has not completed those actions by the time the
test closed, leaving setBreakpoint or removeBreakpoint requests hanging, causing a number of tests
to fail. In order to get around this, I made the panel action "SET_BREAKPOINT" and
"REMOVE_BREAKPOINT" aware of the server response. This involved rewriting the helper methods
`clientSetBreakpoint` and `clientRemoveBreakpoint` so that they no longer relied on the dispatch.
It was not possible to use the dispatches to wait, as they had no event exposed to the tests,
especially in cases when we triggered these requests via button presses.
Differential Revision: https://phabricator.services.mozilla.com/D32710
--HG--
extra : moz-landing-system : lando
this is the weird one. we have a Debugger.executeSoon call for the destruction of the host.
However, before this happened immediately after the test closed. Now, it happens a little later, and
this messes up the data set up. The comment says that we cannot remove this.
Differential Revision: https://phabricator.services.mozilla.com/D32722
--HG--
extra : moz-landing-system : lando
The webConsoleFront and the threadClient front both used to depend on the debugger-client
to destroy them via registered clients. This is no longer the case, and this code can be deleted
Differential Revision: https://phabricator.services.mozilla.com/D32699
--HG--
extra : moz-landing-system : lando
In order for a front to be available to getFront on a given target, it must be first --
registered on the target scope, and second -- set on the target's targetForm. This makes that update
for both browsing context and worker targets. This works as part of a work around until we can get
the server into better shape.
Differential Revision: https://phabricator.services.mozilla.com/D32698
--HG--
extra : moz-landing-system : lando
The resume case is much more complex than the other events, because we do an
unsafeSynchronize to send an unsolicited pause. In the old system, the resume response would have
been ignored, but that is no longer the case. With the new system, we do not want to send a response
to a resume action if it did not come from the UI. This also update the debugger panel code to
accept a resume.
Differential Revision: https://phabricator.services.mozilla.com/D32697
--HG--
extra : moz-landing-system : lando
This is part one of removing threadClient specifics out of the debuggerClient. We were
managing messages from the thread client in a special way -- this was the "Unsolicited Pauses"
object that we had before. This patch updates the threadClient to use Front style events. This
required updating the spec for the threadClient, and several of the methods. What has not been fully
migrated here is the "resumed" event, as this is much more complex. This is taken care of in the
next patch.
Differential Revision: https://phabricator.services.mozilla.com/D32695
--HG--
extra : moz-landing-system : lando
This is the first part of the threadClient refactor. It only moves the methods to the new
front. and does some basic fixes.
Differential Revision: https://phabricator.services.mozilla.com/D32692
--HG--
extra : moz-landing-system : lando
make sure we have a copy of thread client for old servers
Differential Revision: https://phabricator.services.mozilla.com/D34179
--HG--
rename : devtools/shared/client/thread-client.js => devtools/shared/client/deprecated-thread-client.js
extra : moz-landing-system : lando
For content HTML/XHTML copy/paste should always be enabled, but for chrome
docs we can support enabling/disabling copy/paste.
Also, restores tests to how they were before copy/paste was always enabled.
Differential Revision: https://phabricator.services.mozilla.com/D34805
--HG--
extra : moz-landing-system : lando
The `WebProgress#sendLoadCallResult` method only existed to send a empty async
message and was only called from the `WebNavigationChild`. Since
`WebNavigationChild` is in the process of being removed, it makes sense to
inline the replaced method into its call site.
Differential Revision: https://phabricator.services.mozilla.com/D34566
--HG--
extra : moz-landing-system : lando
- Fixes expandFrames() to ensure the thread property is set
- Refactors getSourceLocationFromMouseEvent to use fromEditorLine
- Replaces dwarf_to_json (for proper DWARF conversion)
Differential Revision: https://phabricator.services.mozilla.com/D33092
--HG--
extra : moz-landing-system : lando
The `WebProgress#sendLoadCallResult` method only existed to send a empty async
message and was only called from the `WebNavigationChild`. Since
`WebNavigationChild` is in the process of being removed, it makes sense to
inline the replaced method into its call site.
Differential Revision: https://phabricator.services.mozilla.com/D34566
--HG--
extra : moz-landing-system : lando
This implements Victoria's suggestion for improving highlight line visibility.
Differential Revision: https://phabricator.services.mozilla.com/D34372
--HG--
extra : moz-landing-system : lando
In the regular webconsole input, on Enter, we check that the
input is a compilable unit, so the user don't accidentally
execute an incomplete snippet.
In the editor mode, the user will have to use Ctrl/Cmd + Enter to
execute, so we don't have to worry about Enter (it will simply
append a new line).
And since the user might deal with a large number of characters,
we don't want to prevent them to execute. If it's malformed, they
will get an error in the output and can fix their input easily, since
it wasn't cleared.
The patch adds a test to ensure this work as expected.
Differential Revision: https://phabricator.services.mozilla.com/D34522
--HG--
extra : moz-landing-system : lando
We put some objects on the InactivePropertyHelper (node, rule),
but never reset those properties, which was causing leaks in some
inspector tests.
This patch adds a unselect function that clears all the references
added in the select function.
Differential Revision: https://phabricator.services.mozilla.com/D34844
--HG--
extra : moz-landing-system : lando
The inactive CSS feature is only enabled in Nightly at
the moment, which is what's causing the test to fail
on beta simulation.
Forcing the pref to true in the test should fix the issue.
Differential Revision: https://phabricator.services.mozilla.com/D34847
--HG--
extra : moz-landing-system : lando
This test was failing due to the tab closing before a response from the tab was recieved.
It is due to the threadClient closing more quickly. This waits for the last message before closing
Differential Revision: https://phabricator.services.mozilla.com/D32718
--HG--
extra : moz-landing-system : lando
this test was failing because the threadClient was posting messages due to being unable to
find the source map. After investigating, I found that the sourcemap was formatted incorrectly. I do
not know if this was intentional. If it wasn't this fix works. If it was, then we need to find a way
to wait on source map failures, and the test name might need to be updated
Differential Revision: https://phabricator.services.mozilla.com/D32715
--HG--
extra : moz-landing-system : lando
There was an issue where this test was timing out, and due to the way it was written it was
very hard to identify where -- there were many nested promises. I rewrote the test in order to
identify the time out.
Differential Revision: https://phabricator.services.mozilla.com/D32714
--HG--
extra : moz-landing-system : lando
the test `browser_net_params_sorted` may not have been functioning for some time. While
investigating this, I discovered that we were getting an empty array for `actualKeys`. Iterating
over this array returned immediately. As a result the test always passed, even though the shape of
the data changed. I updated this code so that it waits for the dom to be populated with the number
of keys expected. I also updated the test to reflect the data the front end has today.
Differential Revision: https://phabricator.services.mozilla.com/D32713
--HG--
extra : moz-landing-system : lando
There were a few miscellaneous situations in which the test would fail due to a hanging
request. These tests passed in the past because the old way of using the threadActor did not
identify which requests had been responded to.
Differential Revision: https://phabricator.services.mozilla.com/D32711
--HG--
extra : moz-landing-system : lando
In the layout panel of the inspector, in the flex part, change color of min and max properties.
Change the min/max labels, and lock icon color of the flex outline box to the same color too.
Differential Revision: https://phabricator.services.mozilla.com/D33835
--HG--
extra : moz-landing-system : lando
If logpoint throws, set `level` to "error".
Add tests to ensure the correct level is set.
Demo function: https://luxuriant-system.glitch.me/
Add some logpoints. The first two statements are invalid. The third one is valid.
{F1311386}
In console:
{F1311387}
Differential Revision: https://phabricator.services.mozilla.com/D31157
--HG--
extra : moz-landing-system : lando
This should make the test more managable as we add properties
validators in InactivePropertyHelper.
eslint doesn't support dynamic import yet, so we have to ignore
the test file.
Differential Revision: https://phabricator.services.mozilla.com/D34677
--HG--
rename : devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html => devtools/server/tests/mochitest/inactive-property-helper/gap.js
rename : devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html => devtools/server/tests/mochitest/inactive-property-helper/max-min-width-height.js
rename : devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html => devtools/server/tests/mochitest/inactive-property-helper/vertical-align.js
extra : moz-landing-system : lando
Added proper plural form to editor.searchResults and sourceSearch.resultsSummary1. Updated the comments and IDs for the new strings as well. Replaced all instances of old string references with new string references.
Differential Revision: https://phabricator.services.mozilla.com/D32881
--HG--
extra : moz-landing-system : lando
This allows to have more meaningful warning group messages, i.e.
"Content Blocking" is turned into something like "The resource at
'<URL>' was blocked because content blocking is enabled".
This is done by parsing the message of the first warning to put
in the group, and replacing the URL with a generic placeholder.
We take this as an opportunity to decouple content blocked messages
and storage access blocked ones, as they have slightly different
meanings and consequences.
Tests are updated to match the new labels, and a new test is
added to make sure that we can have multiple warning group in a
single "page navigation" session.
Differential Revision: https://phabricator.services.mozilla.com/D34339
--HG--
extra : moz-landing-system : lando
Hitting Ctrl+ArrowRight didn't have any effect on windows/linux.
The patch fixes this and add a test to make sure a user can
navigate from word to word using Ctrl (or Alt on OSX) and
Arrow Left/Right keys.
Differential Revision: https://phabricator.services.mozilla.com/D34312
--HG--
extra : moz-landing-system : lando
Element.nodeName is usually all-caps, and we were testing lower cased version,
which brought erroneous results.
The test wasn't picking those errors because we were creating the element from
a XHTML document, where Element.nodeName keep the casing used for their creation.
The test is modified to deal with an HTML document instead.
After the test was modified, I could see it was failing, and was then able to
do the actual feature fix.
Differential Revision: https://phabricator.services.mozilla.com/D34149
--HG--
rename : devtools/server/tests/browser/browser_inspector-inactive-property-helper.js => devtools/server/tests/mochitest/test_inspector-inactive-property-helper.html
extra : moz-landing-system : lando
Indicate in the infobar highlighter if the element is of kind grid or flex, and if it is a container or an item.
Differential Revision: https://phabricator.services.mozilla.com/D29964
--HG--
extra : moz-landing-system : lando
This patch adds a componentDidCatch handler to the Message component
so we don't crash the whole console when a message can't be rendered.
When a message causes a crash, we display an error message instead,
asking the user to file a bug. A button allow to copy the message data
so it can be attached in the bug report.
Differential Revision: https://phabricator.services.mozilla.com/D31195
--HG--
extra : moz-landing-system : lando
This makes the console code more consistent, and adds the
nice benefit of being able to check if the layout should
be modified when performing non-window-resize events that
might still impact the layout (sidebar toggle, sidebar
resizing, ...).
Differential Revision: https://phabricator.services.mozilla.com/D27668
--HG--
extra : moz-landing-system : lando
Set a minimum width on the filter bar of the Devtools Console window. When there is enough empty space
to the right of the filterbar, allow the filter buttons to be desplaying inline, rather than on their own
separate row.
Differential Revision: https://phabricator.services.mozilla.com/D20188
--HG--
extra : moz-landing-system : lando
This patch adds a componentDidCatch handler to the Message component
so we don't crash the whole console when a message can't be rendered.
When a message causes a crash, we display an error message instead,
asking the user to file a bug. A button allow to copy the message data
so it can be attached in the bug report.
Differential Revision: https://phabricator.services.mozilla.com/D31195
--HG--
extra : moz-landing-system : lando
Follow-up to [Bug 1093953](https://bugzilla.mozilla.org/show_bug.cgi?id=1093953) which introduced a generalized `payload` object for messages to be populated asynchronously with additional data associated with the message after it is initially received.
The reasoning is: messages can have arbitrary data payload associated with them. The rendering component for the message type will consume and validate that payload data.
Here, we replace the specialized messageTableDataByID with the generalized messagePayloadByID, update corresponding Redux actions, reducers, selectors and tests.
The only place where `tableData` is used is in the `ConsoleApiCall` message type, in the `ConsoleTable` component. We replace it with `payload` which is sent down to all message types anyway.
Differential Revision: https://phabricator.services.mozilla.com/D33975
--HG--
extra : moz-landing-system : lando
This is done so the user has a choice what kind of audit to run or what kind of audit type to filter the accessibility tree by
Differential Revision: https://phabricator.services.mozilla.com/D33183
--HG--
extra : moz-landing-system : lando
### Changes
#### Set 1 - Match cookie creation strings, remove "on" and capitalize.
- Expires on {icon long-arrow-right} Expires
- Last accessed on {icon long-arrow-right} Last accessed
- Created on {icon long-arrow-right} Created
- sameSite {icon long-arrow-right} SameSite
#### Set 2 - Re-add missing strings
- table.headers.cookies.isHttpOnly=HttpOnly
- table.headers.cookies.isSecure=Secure
- table.headers.cookies.hostOnly=HostOnly
Differential Revision: https://phabricator.services.mozilla.com/D33041
--HG--
extra : moz-landing-system : lando
Currently, if the autocomplete preference is set to false, and the user
displays the autocomplete popup with Ctrl + Space, typing other letters
won't filter the popup, which feels very weird.
This patch fixes this behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D28597
--HG--
extra : moz-landing-system : lando
This patch addresses bug 888161 by adding a ‘Download File’ option to the context menu of individual source tree item files.
Differential Revision: https://phabricator.services.mozilla.com/D32828
--HG--
extra : moz-landing-system : lando
It can happen that the string we receive is quite large
and as a result takes a long time to analyze, freezing
the process.
This patch simply tracks for how long the for loop is running,
and bail out if it's greater than a given time (set to 2500 ms
for now).
This is mostly a safeguard, a future patch should try to improve
the performance of the function itself.
Differential Revision: https://phabricator.services.mozilla.com/D33791
--HG--
extra : moz-landing-system : lando
The current “go to line” keyboard shortcut `CmdOrCtrl+;` conflicts with the “step in” shortcut. The "go to line" shortcut is replaced with the shortcut for Chrome debugger and Sublime Text: `Ctrl+G`. Upper or lower cases don’t matter.
1. Current behavior:
1a) With no file open in editor; or with a file open in editor, but not pausing at a breakpoint:
`Cmd+;` or `Cmd+Shift+;` opens the “go to line” box.
1b) Pause at a breakpoint:
`Cmd+;` runs `step in`, and also opens the “go to line” box;
`Cmd+Shift+;` runs `step over`, and also opens the “go to line” box.
2) Code changes:
2a) Create gotoLineModal.key3.
2b) Update localization note.
2b) Update snapshot test.
3) After the code changes, on macOS:
3a) With no file open in editor:
`Ctrl+G` opens the “go to line” box.
3b) With a file open, but not pausing at breakpoints:
`Ctrl+G`opens the “go to line” box; hitting `Ctrl+G` again or `escape` closes the box.
3c) Pause at a breakpoint:
`Cmd+;` or `Cmd+Shift+;` doesn’t open the “go to line” box.
`Ctrl+G` opens the “go to line” box.
Differential Revision: https://phabricator.services.mozilla.com/D26256
--HG--
extra : moz-landing-system : lando
This introduce a new form of invalid messages. Until now, all the
messages were like "X has no effect on this since it's not Y".
But in this case, the width/height properties applies to all but
a few cases, which means we can't really keep the same shape of
message (or it would be "since it's not A, B, C, D, ...).
So we're switching to a message that prints the display property
of the element ("X has no effect on this element since it has a
display of Y").
In order to do that, we need to pipe the element computed display
into the inactive tooltip.
Differential Revision: https://phabricator.services.mozilla.com/D32805
--HG--
extra : moz-landing-system : lando
support for from-font listed in the CSS spec will be implemented in a later bug
Differential Revision: https://phabricator.services.mozilla.com/D33233
--HG--
extra : moz-landing-system : lando
Depends on D32867
Reference the shared list of pseudo-elements throughout the codebase:
- markup view context menu + test
- Rule editor
- box model highlighter
- node actor
- new Rules view
Differential Revision: https://phabricator.services.mozilla.com/D32868
--HG--
extra : moz-landing-system : lando
- Removes the hardcoded references from `index.xhtml` and `rules.js` and uses a centralized list of pseudo-classes to generate the checkboxes for the supported pseudo-class locks at runtime.
- Streamlines the handling for pseudo-class locks state. Fixes Bug 1536676 as a side-effect.
- Updates tests.
Differential Revision: https://phabricator.services.mozilla.com/D32867
--HG--
extra : moz-landing-system : lando
support for from-font listed in the CSS spec will be implemented in a later bug
Differential Revision: https://phabricator.services.mozilla.com/D33233
--HG--
extra : moz-landing-system : lando
They're not used internally either, so remove all ability to address them.
I haven't removed the implementation yet, as some of them are quite complex, and
I don't have a mac / windows build. We should do that when this hits release
though.
Differential Revision: https://phabricator.services.mozilla.com/D32488
--HG--
extra : moz-landing-system : lando
We also listen for the warningGroup preference change to
toggle warningGroups in the console output.
If warningGroups were disabled, we need to loop through
the state messages to create warningGroups when needed.
A test is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D32716
--HG--
extra : moz-landing-system : lando
We move the observer declaration closest to where the store is created
so we can dispatched action more easily.
We put all the observers in a Map so we can remove them easily when
destroying the console panel.
Differential Revision: https://phabricator.services.mozilla.com/D31591
--HG--
extra : moz-landing-system : lando
Since isPropertyUsed takes an HTMLElement and its computed style, we
need to have access to the DOM, and can't use an xpcshell test.
Differential Revision: https://phabricator.services.mozilla.com/D33454
--HG--
extra : moz-landing-system : lando
When hovering from the preview of tokenA back to tokenA, the preview shouldn't unrender and the rerender.
Before:
{F1318568}
After:
{F1318569}
Differential Revision: https://phabricator.services.mozilla.com/D31899
--HG--
extra : moz-landing-system : lando
new exceptions in sorting the sourcesTree
Refactored treeOrder code to remove duplicate code and make it simple to add
new exceptions in sorting the sourcesTree
Differential Revision: https://phabricator.services.mozilla.com/D31684
--HG--
extra : moz-landing-system : lando
This commit takes the popup, and wires it up the button using the
CustomizableUI interface. It is integrated with the DevTools initialization
code.
Differential Revision: https://phabricator.services.mozilla.com/D31629
--HG--
extra : moz-landing-system : lando
The performance profiler pop-up menu wants to be near DevTools, but work
without the complete DevTools initialization. This patch ensure that
any calls to lazyRequireGetter properly initialize the provider.
Differential Revision: https://phabricator.services.mozilla.com/D31628
--HG--
extra : moz-landing-system : lando
This commit represents the changes needed to convert the existing
Gecko Profiler Add-on code to work outside of the WebExtensions
environment. A following commit will actually wire it into the
rest of the browser.
Differential Revision: https://phabricator.services.mozilla.com/D31627
--HG--
extra : moz-landing-system : lando
- Fixes expandFrames() to ensure the thread property is set
- Refactors getSourceLocationFromMouseEvent to use fromEditorLine
- Replaces dwarf_to_json (for proper DWARF conversion)
Differential Revision: https://phabricator.services.mozilla.com/D33092
--HG--
extra : moz-landing-system : lando
I think this is a good change regardless of other discussion in bug 1552587. If
we decide to move `mColor` to the top-level of the struct that can be done
separately.
Differential Revision: https://phabricator.services.mozilla.com/D32726
--HG--
extra : moz-landing-system : lando
The component is no longer needed since we enabled the new aboutdebugging by default on Nightly
Differential Revision: https://phabricator.services.mozilla.com/D32756
--HG--
extra : moz-landing-system : lando
Token highlights should disappear when no longer hovered on a token. Sometimes it stays on after scrolling in the editor. This seemed to have been caused by the way we select which token was hovered on when removing the highlight, which is based off of the cursor position. That method is not as reliable when scrolling, which was causing the bug.
Instead, we can just use the `target` property of the preview at the time the popup is mounted/unmounted to reliably add and remove the token highlight class.
Differential Revision: https://phabricator.services.mozilla.com/D33719
--HG--
extra : moz-landing-system : lando
Ensures scroll position stays the same between tab switches while paused and not paused.
Differential Revision: https://phabricator.services.mozilla.com/D33312
--HG--
extra : moz-landing-system : lando
These are generally:
- Code comments to browser.xhtml
- Testcases, assertions that were mostly using browser.xul as a generic chrome URL
- References to the browser.xul path in tree
Differential Revision: https://phabricator.services.mozilla.com/D33208
r=jdescottes
turns out we were incorrectly passing the threadClient to the environmentClient while
instantiating in one of the tests. It worked before because the threadClient exposed the API surface
of the debugger-client.
Differential Revision: https://phabricator.services.mozilla.com/D32685
--HG--
extra : moz-landing-system : lando
Julian Descottes
David Walsh
Jason Laster
Junior Hsu
Oana Pop Rus
Dorel Luca
jaril
Florens Verschelde
Panos Astithas
Christoph Kerschbaumer
Belén Albeza
Nicolas Chevobbe
Jonathan Kew
Javier Olaechea
Daisuke Akatsuka
shindli
Tom Schuster
Jonathan Kingston
Noemi Erli
Sebastian Hengst
Ola Gasidlo
Cosmin Sabou
Yash Johar
Michael Ratcliffe
Victor Porof
Razvan Maries
Razvan Caliman
Csoregi Natalia
J
Yura Zenevich
arthur.iakab
Sebastian Streich
Narcis Beleuzu
Kris Maglione
Maliha Islam
Ciure Andrei
Alex Rosenfeld
Connor Brewster
Greg Tatum
Logan Smyth
Gabriel Luong
Jatin
Kagami Sascha Rosylight
Bryan Kok
Julien Wajsberg
Jefry Lagrange
tanhengyeow
lloan
Gerald Squelart
Charlie Marlow
Andreea Pavel
Herpiko Dwi Aguno
Coroiu Cristina
Nicholas Nethercote
Gurzau Raul
Armando Ferreira
janelledement
Jim Porter
chujun
Brian Hackett
Yury Delendik
yulia
Emilio Cobos Álvarez
Vikas Prasad Mahato
Brian Grinstead
Patrick Brosset
Daniel Varga
Brendan Dahl
Dickson Tan
violet
Mihai Alexandru Michis
Gregor Weber
Jean-Yves Avenard
Barret Rennie
Brindusan Cristian
Boris Zbarsky
Miriam
Ehsan Akhgari
Edwin Gao
Thomas
Bogdan Tara
phoenixabhishek
Micah Tigley
Tim Nguyen
Neil Deakin
Kelly
Nicolas B. Pierron
Dhruvi Butti
Ryan Duffy
Nicolas B. Pierron
Francis Houle
Andrea Marchesini
Brad Werth
Tushar
Ashley Hauck
ravefalcon92
Daniel Holbert