Rename this attribute to better significate that the target is
changing over time when the debugged target navigates to another process.
Differential Revision: https://phabricator.services.mozilla.com/D44632
--HG--
extra : moz-landing-system : lando
We want the Browser Console and WebConsole to have
distinct preferences, so you might have one in
editor mode, and the other one in inline mode if
you want.
This is as simple as adding the preference, and
stripping the devtools.webconsole. prefix in
the constant we use for retrieving the preference
value.
Differential Revision: https://phabricator.services.mozilla.com/D44631
--HG--
extra : moz-landing-system : lando
This is broken out into a separate commit since it is a layout change
for the DevTools as well. Note, that this area is still not localized.
Differential Revision: https://phabricator.services.mozilla.com/D43120
--HG--
extra : moz-landing-system : lando
This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.
Differential Revision: https://phabricator.services.mozilla.com/D43119
--HG--
rename : devtools/client/performance-new/popup/popup.html => devtools/client/performance-new/popup/popup.xhtml
extra : moz-landing-system : lando
This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.
Differential Revision: https://phabricator.services.mozilla.com/D43118
--HG--
extra : moz-landing-system : lando
We're re-using the test we already have for invoking getters
in the webconsole as it is checking a lot of different cases.
Differential Revision: https://phabricator.services.mozilla.com/D44628
--HG--
rename : devtools/client/webconsole/test/browser/browser_webconsole_object_inspector_getters.js => devtools/client/webconsole/test/browser/browser_console_content_getters.js
extra : moz-landing-system : lando
When we wanted to insert a string in the webconsole input,
we were setting the input value, and setting the cursor
manually. But since the editor setCursor function is calling
alignLine, there could be cases where the editor scroll position
would jump, feeling awkward for the user.
It turns out we can simplify this code a lot since codeMirror
provides a replaceRange function, which is a perfect replacement
for what we were using, without having to manage the cursor position.
The only downside to that is that inserting characters this
way *does* fire a `changes` event, that we are listening to
in the JsTerm to request autocompletion (which we don't need
as we only insert characters when accepting a completion or
adding a tab).
To mitigate that, we pass a specific jsterm origin string to
replaceRange, which let's us discriminate in the changes event
listener if those changes originate from jsterm only actions.
A test is added to ensure this works as expected (the test was
failing without the fix).
Differential Revision: https://phabricator.services.mozilla.com/D44466
--HG--
extra : moz-landing-system : lando
We could be more explicit and also handle svg on the height / width stuff
(width and height don't apply to all SVG elements).
But this avoids the false positive for now.
Differential Revision: https://phabricator.services.mozilla.com/D44621
--HG--
extra : moz-landing-system : lando
By tweaking the while loop in addHighlightToTargetSiblings, the preview highlight will not continue beyond a non-text node. (Example in the case of a semi colon or a period.
Differential Revision: https://phabricator.services.mozilla.com/D44275
--HG--
extra : moz-landing-system : lando
Add menu items to both secondary panel and editor
Add a mochitest
{F1539841}
Differential Revision: https://phabricator.services.mozilla.com/D44115
--HG--
extra : moz-landing-system : lando
This is broken out into a separate commit since it is a layout change
for the DevTools as well. Note, that this area is still not localized.
Differential Revision: https://phabricator.services.mozilla.com/D43120
--HG--
extra : moz-landing-system : lando
This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.
Differential Revision: https://phabricator.services.mozilla.com/D43119
--HG--
rename : devtools/client/performance-new/popup/popup.html => devtools/client/performance-new/popup/popup.xhtml
extra : moz-landing-system : lando
This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.
Differential Revision: https://phabricator.services.mozilla.com/D43118
--HG--
extra : moz-landing-system : lando
Fix 2 proptype errors: one in App.js, and the
other one in the renderStacktrace function,
that is called by Error rep.
Differential Revision: https://phabricator.services.mozilla.com/D44467
--HG--
extra : moz-landing-system : lando
The failures were about pending requests to highlighters,
because we were logging node elements. Since we don't
really need to do that, we simply change the command
to not lod elements.
Differential Revision: https://phabricator.services.mozilla.com/D44367
--HG--
extra : moz-landing-system : lando
Chris Muldoon
Alexandre Poirot
Nicolas Chevobbe
tanhengyeow
Greg Tatum
David Walsh
Brindusan Cristian
Cosmin Sabou
Noemi Erli
Jason Laster
Julian Descottes
lloan
Emilio Cobos Álvarez
janelledement
chujun
Megan Bailey
Maliha Islam
arthur.iakab
Razvan Maries
Markus Stange
Emma Malysz