This uses a bitfield for flags in FindBoundary, the idea is that it
will give some regression coverage if/when we move the native API
to do the same.
Differential Revision: https://phabricator.services.mozilla.com/D169246
I can see that after navigation, allowJavascript is correctly set for the browsing context, but it seems we need to call
RecomputeCanExecuteScripts() to force it to be applied to the new page. Not sure if doing this here makes sense or if it should be done earlier.
Also there are still other issues with this feature:
- closing the toolbox does not reload the page: meaning JavaScript remains disabled on the page
- similarly all pages which have been put in bfcache will retain the javascript disabled/enabled setting
For the first issue, I wonder if we should force a reload when closing the toolbox (iff javascript disabled was toggled).
And for the second issue, could we invalidate contexts put in bfcache for a given browsing context when we toggle allowJavaScript?
Olli: Does this change make sense at least to fix the basic issue?
Differential Revision: https://phabricator.services.mozilla.com/D169182
I verified with an assumeUnreachable that iterator-indices-7.js now reaches the dense element fastpath.
I've given `numShapes` a more meaningful name in the places where that makes sense.
Differential Revision: https://phabricator.services.mozilla.com/D169541
gn -> f4783696a51991a33f0476ad7120e49537d76093
hu -> e2c47c445ed5b92b3266876f8e9ed8ce579628e7
is -> ad67bd04d06a9a114f30b2098ad3077230419dd3
lo -> 48763f2e40f537803c087a29070dd36acb1394d7
skr -> 4decd1206aadc37ccbb6575cf0ba6f0fa9178b05
tg -> 1fa06ff864f248e78b03245f747fc67821a450e6
uk -> 74762c7fdc0b16bcc3b9dfa08ad75706659c1b62
If the glslopt pass fails to optimize a shader, we helpfully print the
shader source so that it is easy to find what the problem is. However,
we print this from within the build_parallel call, meaning if multiple
shaders fail to optimize we print all of their sources and they get
interleaved with each other, making it very difficult to find the
problematic line.
This patch makes us delay printing the source until the same place
where we print the error log, after we have stopped processing in
parallel. This means we will only print the source of a single
shader (the first one which fails to optimize), along with the error
log for that shader, which is much easier to debug.
This also includes a small tidy-up to handle both vertex and fragment
shaders in a loop to remove code duplication, and runs rustfmt.
Differential Revision: https://phabricator.services.mozilla.com/D169618
Much like dedicated workers: In this patch we copy over affected CSP tests to the mozilla tests
directory before modifying them so that they rely on the workers headers rather than the page.
Differential Revision: https://phabricator.services.mozilla.com/D167665
This initially updates WPT tests that are immediately turned green by enabling modules on workers.
It does not include the copies of tests related to CSP that are currently failing. This will be done
in the next two patches.
***
new changes for wpt
Differential Revision: https://phabricator.services.mozilla.com/D164573
This patch introduces modules workers to shared workers. This includes the necessary chagnes to pass
the "type: module" to the shared worker. Beyond that, this patch relies on the work landed in
dedicated workers.
Depends on D162743
Differential Revision: https://phabricator.services.mozilla.com/D156103
Instead of rendering the cropped URL, we split the URL in 3 parts, so the full
URL text will be in the DOM, but we visually hide the middle part and replace
it with an ellipsis.
This way copying the message will still put the full URL in the clipboard.
A test case is added to ensure this works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D165805