ESLint 2 now flags anonymous generator functions according to
generator-star-spacing. Most of the changes here are correcting that.
MozReview-Commit-ID: 9xg2Gmlaz94
--HG--
extra : rebase_source : e6db0fd0ef477cd4fd2196b1036783f0974c586b
extra : histedit_source : 03eea033884969cc2a340316377318b0487ebdf2
ESLint 2 now flags anonymous generator functions that don't match the
generator-star-spacing rule so this mostly is fixing that.
MozReview-Commit-ID: 5sLaF26sd0E
--HG--
extra : rebase_source : 6008f48c94e4a8e5bd2ed2f8a95e764e4aa39cdb
extra : histedit_source : 6f0151c184ee2e4288f3ec9c5a85a65e975d46e1
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: KHYdAkRvhVr
--HG--
extra : rebase_source : 720cc9d864175248508146a7f4704b4bf3f02439
extra : histedit_source : 6cc0ecbf21a571e1a41d517b67512a3452fac19a
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: DEskVIjiKDM
--HG--
extra : rebase_source : 07ba1d14655f5d761624b105ef025ec88323d4d5
extra : histedit_source : 9e5ab54ce1b1a5ee1f0fb143f8d1450522455e3b
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: CRpZy873GP6
--HG--
extra : rebase_source : d355e5f0f13211cbd81e2a91cfe6191f5e84adb2
extra : histedit_source : eb85af7438b493a22fd9a4c32ab254e6a01b7cb3
Rename the rules that ESLint 2 no longer supports to the new names. Ignore the
microformat test suite as it is external code.
MozReview-Commit-ID: BgIxFERjHp1
--HG--
extra : rebase_source : 9f02a87f9a843b427b021caa72db9eb766287151
extra : histedit_source : 954abc7e447ac6cdd36290ade7adec626f4fe4fb
Add coverage for:
* The |openOptionsPage| method when |options_ui| is missing from the manifest.
MozReview-Commit-ID: BwVMzDOECl3
--HG--
extra : transplant_source : %ED%E7%04N%DC%9D%FC%FD%BF%A2%02%D7SQ%3D%8A%EBa%98%A7
In promise chains, we don't have to use t.step_func. However, when there
are callbacks in promise chains, assertions in the callbacks need wrapped
in either t.step or t.step_func.
If we use t.step_func, a variable scope might be divided. This can be a
problem when an assertion uses local-scope variable (e.g. the callback
in MutationObserver uses an assertion which take `changedAnimation`).
Therefore, t.step is helpful in this case.
(There no t.step_func we should remove in web-platform tests.)
MozReview-Commit-ID: IiSizgCQjpG
--HG--
extra : rebase_source : bfe314c20763d0ea26127dd561c64388d6431bf3
Also converts the longer |UniquePtr<char, void(&)(void*)> foo(..., PORT_Free)|
to the shorter and equivalent |UniquePORTString foo(...)|.
MozReview-Commit-ID: LlrTNUYBP4V
--HG--
extra : transplant_source : afU%FB%0EC%3E%E0pm%A3-%0E%C8%83%CF%0A%B1%9E%ED
Jared Wein
Ryan VanderMeulen
ffxbld
Wes Kocher
Carsten "Tomcat" Book
Phil Ringnalda
Nick Alexander
Nick Fitzgerald
Dave Townsend
bsilverberg
Jason Laster
Greg Tatum
Ryo Kato
Cykesiopka
Tobias Schneider
Andrea Marchesini
Tooru Fujisawa
Andrew McCreight
Masatoshi Kimura
Lee Salzman
Ben Kelly