Mike Hommey
6110e21789
Bug 1744890 - Remove build_type field from clang configs. r=firefox-build-system-reviewers,andi
...
`Release` is the default already.
Differential Revision: https://phabricator.services.mozilla.com/D133177
2021-12-08 06:29:14 +00:00
Mike Hommey
5acfe5550f
Bug 1744890 - Remove assertions field from clang configs. r=firefox-build-system-reviewers,andi
...
`false` is the default already.
Differential Revision: https://phabricator.services.mozilla.com/D133176
2021-12-08 06:29:14 +00:00
Mike Hommey
7cdb0e3c39
Bug 1744890 - Remove build_libcxx from individual configs. r=firefox-build-system-reviewers,andi
...
And make build-clang use a sensible default corresponding to what
the configs were doing.
Differential Revision: https://phabricator.services.mozilla.com/D133175
2021-12-08 06:29:14 +00:00
Mike Hommey
3631977b63
Bug 1730078 - Build clang-tidy with clang. r=firefox-build-system-reviewers,andi
...
There are complications with building a 1-stage clang with gcc, so just
use clang. Eventually, the clang-tidy toolchains will be removed in
favor of providing clang-tidy from the clang toolchain itself anyways.
Differential Revision: https://phabricator.services.mozilla.com/D125158
2021-09-15 02:39:52 +00:00
Mike Hommey
6a42db4b68
Bug 1720820 - Remove python executable configuration from clang build script. r=firefox-build-system-reviewers,andi
...
Clang >= 11 ignores PYTHON_EXECUTABLE entirely (and uses python3, which
is not even what we pass, but that's actually fine), and all the build
tasks we have on older versions find the python executable they need on
their own.
Differential Revision: https://phabricator.services.mozilla.com/D120049
2021-07-17 04:29:10 +00:00
Mike Hommey
1c3750fe19
Bug 1704766 - Remove libstdc++ from clang toolchains. r=firefox-build-system-reviewers,andi
...
Differential Revision: https://phabricator.services.mozilla.com/D119140
2021-07-16 04:09:54 +00:00
Noemi Erli
e276a4bf18
Backed out changeset a275000100a4 (bug 1704766) for causing build bustages CLOSED TREE
2021-07-15 02:14:21 +03:00
Mike Hommey
5b7fee4aea
Bug 1704766 - Remove libstdc++ from clang toolchains. r=firefox-build-system-reviewers,andi
...
Differential Revision: https://phabricator.services.mozilla.com/D119140
2021-07-14 20:54:27 +00:00
Andi-Bogdan Postelnicu
b3ae95374e
Bug 1696491 - when clang errors are present, mark static analysis jobs as failed. r=firefox-build-system-reviewers,mhentges
...
Our bot was expecting to have tasks that were succeeding, right now we no longer need that
and in a case of a build failure, or in a case of the presence of a checker that asserts itself
as error and not warning we should mark the task red by failing the job.
Differential Revision: https://phabricator.services.mozilla.com/D107656
2021-03-10 05:20:46 +00:00
David Major
180d35da9f
Bug 1685335 - Update to clang 11.0.1 r=firefox-build-system-reviewers,static-analysis-reviewers,andi,mhentges,sylvestre
...
In addition to the usual dot-release type of fixes, this also lets us drop a good amount of code that we had patched into our clang 11.
Differential Revision: https://phabricator.services.mozilla.com/D100959
2021-01-07 13:53:53 +00:00
Andi-Bogdan Postelnicu
e9fbba867c
Bug 1666550 - Update `clang-tools` to `clang-11`. r=dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D97137
2020-11-17 15:04:14 +00:00
Andi-Bogdan Postelnicu
c9368b86d1
Bug 1650057 - Avoid using external clang-tidy patches when dealing with paths that need to be escaped. r=marco
...
Differential Revision: https://phabricator.services.mozilla.com/D82002
2020-07-02 14:11:19 +00:00
Andi-Bogdan Postelnicu
779d955fee
Bug 1645948 - for `clang-tidy` static-analysis escape some paths that have special chars. r=sylvestre
...
The patch that has been applied to our `clang-tidy` artifact has also been pushed upstead https://reviews.llvm.org/D81917
Differential Revision: https://phabricator.services.mozilla.com/D79799
2020-06-27 14:10:20 +00:00
Andi-Bogdan Postelnicu
b9d855801b
Bug 1633694 - For `clang-tools` apply fixes from `clang-tools-extra` master branch to our own `clang-10` based build. r=sylvestre
...
In `Bug 1629853` we had to revert D69573 <https://reviews.llvm.org/D69573 > from `clang-tools-extra` repo because it created regressions.
These regressions have been fixed in `clang master` with D78879 <https://reviews.llvm.org/D78879 > and D76850 <https://reviews.llvm.org/D76850 >.
This patch adds the two fixes mentioned above and remove the patch that reverted D69573.
Differential Revision: https://phabricator.services.mozilla.com/D72815
2020-04-28 11:49:50 +00:00
Andi-Bogdan Postelnicu
fa006f3af3
Bug 1629853 - revert D69573 from clang-format. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D71918
2020-04-22 11:03:05 +00:00
Andi-Bogdan Postelnicu
56a9802f89
Bug 1625884 - move `clang-tidy` and `clang-format` to `clang-10`. r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D70065
--HG--
extra : moz-landing-system : lando
2020-04-09 14:16:44 +00:00
Cosmin Sabou
60934f9072
Backed out 3 changesets (bug 1625884) as requested by ANdi for causing build bustages. a=backout
...
Backed out changeset a35cfda6e271 (bug 1625884)
Backed out changeset 412c8c401196 (bug 1625884)
Backed out changeset 927ff250bc4b (bug 1625884)
2020-04-09 16:14:06 +03:00
Andi-Bogdan Postelnicu
ffe0a6a754
Bug 1625884 - move `clang-tidy` and `clang-format` to `clang-10`. r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D70065
--HG--
extra : moz-landing-system : lando
2020-04-09 05:28:34 +00:00
Andi-Bogdan Postelnicu
c09d1d5ae3
Bug 1606630 - For clang-tidy fix checkers `readability-misleading-indentation` and `readability-braces-around-statements`. r=sylvestre
...
The purpose of this patch is to add support for `if constexpr` statements for the above checkers.
`readability-braces-around-statements` fix has been back-ported from <https://reviews.llvm.org/D71980 >
and the fix for `readability-misleading-indentation` uses the same logic as a principle.
Differential Revision: https://phabricator.services.mozilla.com/D58825
--HG--
extra : moz-landing-system : lando
2020-01-06 21:42:58 +00:00
Sylvestre Ledru
33853fcce7
Bug 1605181 - 'if constexpr' wasn't supported in clang-tidy r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D57835
--HG--
extra : moz-landing-system : lando
2019-12-19 18:32:40 +00:00
Andi-Bogdan Postelnicu
7843370cdf
Bug 1600033 - for clang-tidy force the output diagnostic as warnings from errors.r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D55135
--HG--
extra : moz-landing-system : lando
2019-11-28 21:15:01 +00:00
Andi-Bogdan Postelnicu
5392090016
Bug 1589096 - add registerPPCallbacks to our version of clang-tidy due to a limitation in mozilla-must-override. r=sylvestre
...
In the future we should re-write this checker but for now this solution is acceptable.
Differential Revision: https://phabricator.services.mozilla.com/D51242
--HG--
extra : moz-landing-system : lando
2019-10-31 12:16:35 +00:00
David Major
103a1cbba6
Bug 1573211 - Update to clang 9.0.0 r=glandium
...
Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds
which suffer from bug 1548624 and will be handled separately later.
Differential Revision: https://phabricator.services.mozilla.com/D44160
MANUAL PUSH: Rebuild clang toolchains without stalling autoland
--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-android.json
rename : build/build-clang/clang-8-linux64-aarch64-cross.json => build/build-clang/clang-linux64-aarch64-cross.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-macosx64.json
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh
2019-09-21 16:26:53 +02:00
Brindusan Cristian
e2348a18ee
Backed out 2 changesets (bug 1573211) as requested by dmajor on irc. CLOSED TREE
...
Backed out changeset 587463567434 (bug 1573211)
Backed out changeset de0fe40466cb (bug 1573211)
--HG--
rename : build/build-clang/clang-android.json => build/build-clang/clang-8-android.json
rename : build/build-clang/clang-linux64-aarch64-cross.json => build/build-clang/clang-8-linux64-aarch64-cross.json
rename : build/build-clang/clang-linux64.json => build/build-clang/clang-8-linux64.json
rename : build/build-clang/clang-macosx64.json => build/build-clang/clang-8-macosx64.json
rename : taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh
extra : histedit_source : 3f9570ab67fd42186265b1dbb6e93c8342bc60e2
2019-09-26 20:12:51 +03:00
David Major
9d69f6a5ba
Bug 1573211 - Update to clang 9.0.0 r=glandium
...
Updates all clang 8.0.1 to version 9.0.0, except for the mingw builds
which suffer from bug 1548624 and will be handled separately later.
Differential Revision: https://phabricator.services.mozilla.com/D44160
MANUAL PUSH: Rebuild clang toolchains without stalling autoland
--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-android.json
rename : build/build-clang/clang-8-linux64-aarch64-cross.json => build/build-clang/clang-linux64-aarch64-cross.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-macosx64.json
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-linux-macosx-cross.sh
extra : amend_source : 2dc7e91897e869ead501f19fbd7960d59c4b79bd
2019-09-21 16:26:53 +02:00
Mike Hommey
639908c191
Bug 1573378 - Make build-clang independent of what MOZ_FETCHES_DIR resolves to. r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D41711
2019-08-15 11:21:42 +09:00
Mike Hommey
0d49eb3466
Bug 1571562 - Make tooltool-download.sh download and extract to MOZ_FETCHES_DIR. r=nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D40712
2019-08-07 13:54:18 +09:00
Mike Hommey
034e9b6b7b
Bug 1570541 - Use git fetch tasks for clang. r=froydnj
...
What this means is that the sources for clang/llvm are downloaded
separately from the toolchain build (which also means we finally only
download a given version of clang once for all platforms).
In turn, this means the build-clang.py script needs to start with an
existing llvm-project tree, and we choose to make build-clang.py expect
that it's run from the llvm-project root directory.
This also means we don't need to download git for the windows toolchain
task.
Differential Revision: https://phabricator.services.mozilla.com/D40402
2019-08-07 13:54:15 +09:00
Sylvestre Ledru
2505df426c
Bug 1566336 - Build clang from git rather than subversion. r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D38361
MANUAL PUSH: avoid closing autoland while clang rebuilds.
2019-08-01 07:26:55 +09:00
Bogdan Tara
4f87c3bc2b
Backed out changeset 4ba7a3e079e3 (bug 1566336) for static analysis bustage CLOSED TREE
2019-08-01 00:38:59 +03:00
Sylvestre Ledru
86692bad14
Bug 1566336 - Build clang from git rather than subversion. r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D38361
MANUAL PUSH: avoid closing autoland while clang rebuilds.
2019-08-01 05:56:39 +09:00
Andi-Bogdan Postelnicu
c303df04c3
Bug 1539779 - clang-tidy 8 mixes stderr and stdout causing parsing issues. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D25255
--HG--
extra : moz-landing-system : lando
2019-04-01 12:18:44 +00:00
Sylvestre Ledru
bf99cf9d2e
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D24175
--HG--
extra : moz-landing-system : lando
2019-04-01 12:24:35 +00:00
Ciure Andrei
8a67ec169a
Backed out 3 changesets (bug 1538060, bug 1539779, bug 1536790) for causing clang-tidy bustages CLOSED TREE
...
Backed out changeset 7d058f3174e5 (bug 1538060)
Backed out changeset 8839622122ed (bug 1539779)
Backed out changeset 9eb7867c1dd4 (bug 1536790)
--HG--
rename : build/build-clang/clang-8-android.json => build/build-clang/clang-7-android.json
rename : build/build-clang/clang-8-linux64.json => build/build-clang/clang-7-linux64.json
rename : build/build-clang/clang-8-macosx64.json => build/build-clang/clang-7-macosx64.json
rename : build/build-clang/clang-8-mingw.json => build/build-clang/clang-trunk-mingw.json
rename : taskcluster/scripts/misc/build-clang-8-android.sh => taskcluster/scripts/misc/build-clang-7-android.sh
rename : taskcluster/scripts/misc/build-clang-8-linux-macosx-cross.sh => taskcluster/scripts/misc/build-clang-7-linux-macosx-cross.sh
rename : taskcluster/scripts/misc/build-clang-8-linux.sh => taskcluster/scripts/misc/build-clang-7-linux.sh
rename : taskcluster/scripts/misc/build-clang-8-mingw.sh => taskcluster/scripts/misc/build-clang-trunk-mingw.sh
2019-03-30 01:52:37 +02:00
Andi-Bogdan Postelnicu
5583c1c99a
Bug 1539779 - clang-tidy 8 mixes stderr and stdout causing parsing issues. r=sylvestre
...
Reviewers: sylvestre
Reviewed By: sylvestre
Bug #: 1539779
Differential Revision: https://phabricator.services.mozilla.com/D25255
--HG--
extra : rebase_source : 83da546c3121350a7560a6890ad2c5920c1df613
extra : histedit_source : 6f1f945e7cfda0cb87f26c679fa2cfe78bde1e5e
2019-03-30 01:24:05 +02:00
Sylvestre Ledru
878a6926e9
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
...
Reviewers: andi
Reviewed By: andi
Bug #: 1536790
Differential Revision: https://phabricator.services.mozilla.com/D24175
--HG--
extra : rebase_source : 4916f93d375ba7415a000fd1a4c48f214b300f47
extra : histedit_source : d21ca90bd40c0fe2db99ea69b7d3c98eaf872f49
2019-03-30 01:23:21 +02:00
Daniel Varga
0bc3e10232
Backed out 2 changesets (bug 1539779, bug 1536790) for toolchain failure. On a CLOSED TREE
...
Backed out changeset 5ecdbfab88b4 (bug 1539779)
Backed out changeset 20d5cdaa08e3 (bug 1536790)
2019-03-29 10:34:45 +02:00
Andi-Bogdan Postelnicu
2473b505db
Bug 1539779 - clang-tidy 8 mixes stderr and stdout causing parsing issues. r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D25255
--HG--
extra : moz-landing-system : lando
2019-03-29 08:08:31 +00:00
Andi-Bogdan Postelnicu
437397c847
Bug 1536790 - Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1) r=andi
...
Patch wrote by Sylvestre Ledru (sylvestre@mozilla.com )
Differential Revision: https://phabricator.services.mozilla.com/D24175
--HG--
extra : moz-landing-system : lando
2019-03-28 17:49:41 +00:00
Mike Hommey
3dc15d5c35
Bug 1516374 - Upgrade clang to 7.0.1. r=dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D15346
--HG--
extra : moz-landing-system : lando
2019-01-09 23:01:46 +00:00
Cosmin Sabou
d6a8d4942e
Backed out changeset 4728285e13e4 (bug 1516374) for causing coverage build bustages. a=backout
2019-01-09 18:34:05 +02:00
Mike Hommey
d1371b35a2
Bug 1516374 - Upgrade clang to 7.0.1. r=dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D15346
--HG--
extra : moz-landing-system : lando
2019-01-09 09:20:15 +00:00
Ciure Andrei
c1b788ba04
Backed out 1 changesets (bug 1516374) for causing Linux asan browser chrome exceptions CLOSED TREE
...
Backed out changeset 4474a7665e47 (bug 1516374)
2018-12-27 08:17:10 +02:00
Mike Hommey
242f814d8a
Bug 1516374 - Upgrade clang to 7.0.1. r=dmajor
...
Differential Revision: https://phabricator.services.mozilla.com/D15346
--HG--
extra : moz-landing-system : lando
2018-12-27 00:49:54 +00:00
Sylvestre Ledru
2ad3aee57b
Bug 1491788 - Use clang 7final to build firefox & clang-tidy r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D6018
2018-09-20 10:10:29 +09:00
Andi-Bogdan Postelnicu
34a6c4ff8f
Bug 1466427 - Migrate clang-tidy package from 5.0.1 to 7.0.0-rc2. r=glandium,janx
...
Differential Revision: https://phabricator.services.mozilla.com/D3980
--HG--
rename : tools/clang-tidy/test/misc-bool-pointer-implicit-conversion.cpp => tools/clang-tidy/test/bugprone-bool-pointer-implicit-conversion.cpp
rename : tools/clang-tidy/test/misc-forward-declaration-namespace.cpp => tools/clang-tidy/test/bugprone-forward-declaration-namespace.cpp
rename : tools/clang-tidy/test/misc-macro-repeated-side-effects.cpp => tools/clang-tidy/test/bugprone-macro-repeated-side-effects.cpp
rename : tools/clang-tidy/test/misc-string-constructor.cpp => tools/clang-tidy/test/bugprone-string-constructor.cpp
rename : tools/clang-tidy/test/misc-string-integer-assignment.cpp => tools/clang-tidy/test/bugprone-string-integer-assignment.cpp
rename : tools/clang-tidy/test/misc-suspicious-missing-comma.cpp => tools/clang-tidy/test/bugprone-suspicious-missing-comma.cpp
rename : tools/clang-tidy/test/misc-swapped-arguments.cpp => tools/clang-tidy/test/bugprone-swapped-arguments.cpp
rename : tools/clang-tidy/test/misc-unused-raii.cpp => tools/clang-tidy/test/bugprone-unused-raii.cpp
extra : moz-landing-system : lando
2018-08-24 12:39:58 +00:00
Bogdan Tara
af579cb55e
Backed out changeset bc15796e6fa7 (bug 1478644) static analysis failures on win2012
2018-08-13 17:57:18 +03:00
Andi-Bogdan Postelnicu
915b4ea25e
Bug 1478644 - [Clang-Tidy] Synchronize run-clang-tidy output with the actual files that are being checked. r=sylvestre
...
MozReview-Commit-ID: LyfcV4oQwyw
--HG--
extra : rebase_source : c992dc421980eb819f6272bb68058ff9e607dfaa
2018-07-26 15:29:19 +02:00
Andi-Bogdan Postelnicu
b030e9525d
Bug 1447904 - for clang-tidy toolchains set default cxx dialect cxx14. r=froydnj
...
MozReview-Commit-ID: LrGETsz0W6q
--HG--
extra : rebase_source : 02a9e9bb50ef91fe5aa23fbfce9fe00e6042c005
2018-03-28 18:48:57 +03:00
Narcis Beleuzu
f7d1771078
Backed out changeset 0c253578b791 (bug 1447904) for TL failures /toolchain-win32-clang-tidy TW32. CLOSED TREE
2018-03-28 18:43:54 +03:00