Граф коммитов

609 Коммитов

Автор SHA1 Сообщение Дата
Ricky Stewart 02a7b4ebdf Bug 1654103: Standardize on Black for Python code in `mozilla-central`.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara da1098d4aa Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart c0cea3b0fa Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca 1ff59cb7a3 Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart 50762dacab Bug 1654103: Standardize on Black for Python code in `mozilla-central`. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Geoff Brown 7d74529955 Bug 1638974 - Run 'mach mochitest' with Python 3; r=bc
Minor fix to remoteautomation.py: Increment stdoutlen before any type conversions,
to ensure that it accurately reflects the byte offset in the file.

With this last change, 'mach mochitest' appears to run correctly on Android with Python 3:
switch it over to Python 3.

Differential Revision: https://phabricator.services.mozilla.com/D91586
2020-09-28 16:30:33 +00:00
Bob Clary 73ba237058 Bug 1658679 - Fix Python 3 compatibility in RemoteAutomation.read_stdout(). r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D86958
2020-08-13 14:02:37 +00:00
Bob Clary f39d6f85a0 Bug 1486004 - Part 2 - Update remoteautomation.py to support unrooted android devices using mozdevice 4.0.0, r=gbrown
Depends on D82744

Differential Revision: https://phabricator.services.mozilla.com/D82745
2020-07-17 20:48:44 +00:00
Narcis Beleuzu b1faa2872a Backed out 17 changesets (bug 1486004) for wrench bustage on android.py . CLOSED TREE
Backed out changeset cae730f105d7 (bug 1486004)
Backed out changeset e0094d50a315 (bug 1486004)
Backed out changeset 424425ed98c6 (bug 1486004)
Backed out changeset 551232749abe (bug 1486004)
Backed out changeset 505747095def (bug 1486004)
Backed out changeset 5b1c62c4a4d5 (bug 1486004)
Backed out changeset 0a1c8d50ee69 (bug 1486004)
Backed out changeset 6ef81c676859 (bug 1486004)
Backed out changeset 234e55153fb6 (bug 1486004)
Backed out changeset 2f33b309d746 (bug 1486004)
Backed out changeset 48947692c176 (bug 1486004)
Backed out changeset 473bac8eedd9 (bug 1486004)
Backed out changeset af6afed0a04a (bug 1486004)
Backed out changeset a0e2f91eb4d4 (bug 1486004)
Backed out changeset 138c987440c7 (bug 1486004)
Backed out changeset 6d2e305f4722 (bug 1486004)
Backed out changeset 1181ff03bb05 (bug 1486004)
2020-07-17 23:43:57 +03:00
Bob Clary f473f07a48 Bug 1486004 - Part 2 - Update remoteautomation.py to support unrooted android devices using mozdevice 4.0.0, r=gbrown
Depends on D82744

Differential Revision: https://phabricator.services.mozilla.com/D82745
2020-07-16 21:32:52 +00:00
Narcis Beleuzu 1eb115035d Backed out 20 changesets (bug 1486004, bug 1653094) for wrench bustages. CLOSED TREE
Backed out changeset 120c64ebdea3 (bug 1486004)
Backed out changeset b10f105b1c36 (bug 1486004)
Backed out changeset 7f186e6bcccc (bug 1486004)
Backed out changeset cdda7b349cd8 (bug 1486004)
Backed out changeset 650c47e81402 (bug 1486004)
Backed out changeset 2bcca7cf3f1b (bug 1486004)
Backed out changeset e1df276f8a8d (bug 1486004)
Backed out changeset f6f5e7f2bd0a (bug 1486004)
Backed out changeset 1c56cb03ce53 (bug 1486004)
Backed out changeset 582cd190f174 (bug 1486004)
Backed out changeset 7c162e1b3a79 (bug 1486004)
Backed out changeset d1088e178216 (bug 1486004)
Backed out changeset 40763f4afd26 (bug 1486004)
Backed out changeset f20eb5b5a670 (bug 1486004)
Backed out changeset 6349ee0bd63f (bug 1486004)
Backed out changeset 7c23729053f6 (bug 1486004)
Backed out changeset 49586014bd29 (bug 1486004)
Backed out changeset 07971e82ae85 (bug 1653094)
Backed out changeset 47e7295e9c19 (bug 1653094)
Backed out changeset 57a25bbeec37 (bug 1653094)
2020-07-16 17:58:09 +03:00
Bob Clary fc493ba092 Bug 1486004 - Part 2 - Update remoteautomation.py to support unrooted android devices using mozdevice 4.0.0, r=gbrown
Depends on D82744

Differential Revision: https://phabricator.services.mozilla.com/D82745
2020-07-15 20:57:24 +00:00
Mihai Alexandru Michis a1d49fb98d Backed out 17 changesets (bug 1486004) for causing bustages in AccessCheck.h
CLOSED TREE

Backed out changeset 86a0855e1e45 (bug 1486004)
Backed out changeset 4fc98067edc5 (bug 1486004)
Backed out changeset 8ab3f1597fde (bug 1486004)
Backed out changeset b487e98320fb (bug 1486004)
Backed out changeset 4cba8e6bc515 (bug 1486004)
Backed out changeset d0db5eef2343 (bug 1486004)
Backed out changeset 50285a87de6b (bug 1486004)
Backed out changeset 9730c0303810 (bug 1486004)
Backed out changeset 140a9d2362f3 (bug 1486004)
Backed out changeset 9d1ce06f6039 (bug 1486004)
Backed out changeset 88a5a4ab39fa (bug 1486004)
Backed out changeset eb186c92232d (bug 1486004)
Backed out changeset 677f2129750e (bug 1486004)
Backed out changeset 81427a5f2103 (bug 1486004)
Backed out changeset 38d7def3d425 (bug 1486004)
Backed out changeset a9e73221c471 (bug 1486004)
Backed out changeset ebe8c2d5432e (bug 1486004)
2020-07-16 15:29:29 +03:00
Bob Clary d8a7ba43c7 Bug 1486004 - Part 2 - Update remoteautomation.py to support unrooted android devices using mozdevice 4.0.0, r=gbrown
Depends on D82744

Differential Revision: https://phabricator.services.mozilla.com/D82745
2020-07-15 20:57:24 +00:00
Geoff Brown 874c22d7df Bug 1565286 - Ensure Android lastTestSeen displays whether the test was in-progress or finished; r=jmaher
Extends the desktop changes made in bug 1475141 to Android, to avoid confusion when the
browser hangs between tests, or during shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D74284
2020-05-07 20:01:56 +00:00
Bob Clary a7055089af Bug 1611473 - fix mach reftest and mach jstestbrowser, r=gbrown.
* update paths to test manifest and user.js after Bug 1596567.
* make sure to use root=True when checking for existence of reftest.log.
* work around permissions errors when pushing to /data/local/tests.
* Properly handle symbolic links to the JavaScript tests for desktop
  and remote Android tests.

Differential Revision: https://phabricator.services.mozilla.com/D69313
2020-04-28 17:08:36 +00:00
Geoff Brown 534483c227 Bug 1177545 - Remove automation.py.in entirely; r=egao,bc
Remove the remainder of automation.py.in and the build support for generating
automation.py.
Some of this functionality was in use, especially for android tests.
Some code was moved or re-implemented in remoteautomation.py or in the affected
harness(es). Some features were removed: There are some minor changes in behavior.
For instance, instead of using a different server startup timeout for debug builds,
one value is used for all builds (due to performance improvements over time,
the longer timeout is no longer needed).

Differential Revision: https://phabricator.services.mozilla.com/D66839

--HG--
extra : moz-landing-system : lando
2020-03-17 19:06:34 +00:00
Geoff Brown 313e12e535 Bug 1177545 - Cleanup automation.py.in; r=egao
Remove unused code from automation.py.in, move some android-specific code from
automation.py.in to remoteautomation.py, and eliminate some other easily-replaced
code. In the long term we want to eliminate automation.py.in completely; I may
attempt that once these changes have landed.

Differential Revision: https://phabricator.services.mozilla.com/D66306

--HG--
extra : moz-landing-system : lando
2020-03-10 21:42:26 +00:00
Geoff Brown 3161788df7 Bug 1603499 - Report java exceptions from minidump .extra files; r=bc
Stop using mozcrash.check_for_java_exception(), which scans logcat for uncaught
exceptions. Instead, check for java_stack in the extra dump information during
normal crash reporting; if java_stack is present, display the java exception and
stack instead of dumping a full native crash report.

Differential Revision: https://phabricator.services.mozilla.com/D61836

--HG--
extra : moz-landing-system : lando
2020-02-07 16:05:52 +00:00
Geoff Brown 253aaf1570 Bug 1599587 - Adjust android mochitest/reftest logging; r=jmaher
Guard against flaky results from the remote is_file and reduce adb traffic
by waiting once for the log file to be created rather than checking for it
throughout the test run.
(Minor ride-along change to reftest.jsm resolves javascript error introduced
by bug 1575266.)

Differential Revision: https://phabricator.services.mozilla.com/D55026

--HG--
extra : moz-landing-system : lando
2019-11-27 21:33:38 +00:00
Geoff Brown 4286faeb7b Bug 1590354 - Remove checks for remote minidumps directory; r=jmaher
Whereas:
 - desktop tests don't make this check;
 - the check for directory existence has been troublesome and almost never useful;
 - bug classification of this condition has been troublesome;
 - if a startup crash actually did occur before crashreporter init, there would still be an indication in logcat and possibly a tombstone, and the "No test summary found" check would definitely be triggered;
Let's stop checking for minidumps directory creation.

Differential Revision: https://phabricator.services.mozilla.com/D54755

--HG--
extra : moz-landing-system : lando
2019-11-26 16:38:44 +00:00
Marian Raiciof b2b633e095 Bug 1526752 - [mozdevice] Update adb.py and other necessary files to support python3 r=ahal,davehunt
Improve support for Python 3 by running modernize over adb.py and a few other related changes.

Differential Revision: https://phabricator.services.mozilla.com/D19306

--HG--
extra : moz-landing-system : lando
2019-06-07 08:44:15 +00:00
Bob Clary 2a1c46386f Bug 1559103 - RemoteAutomation should call parent class init first, r=gbrown.
Differential Revision: https://phabricator.services.mozilla.com/D34856

--HG--
extra : moz-landing-system : lando
2019-06-13 13:54:18 +00:00
Geoff Brown fe297ae528 Bug 1539603 - Remove obsolete references to MediaPipelineFactory logging; r=jmaher
Other than the MediaPipelineFactory references, nothing else is obsolete, so this is a
very minor cleanup, just to improve readability a bit.

Differential Revision: https://phabricator.services.mozilla.com/D25124

--HG--
extra : moz-landing-system : lando
2019-03-28 00:13:48 +00:00
Geoff Brown a908bb5504 Bug 1531611 - Check for ANR and tombstone files in all android tests; r=bc
The existing ANR and tombstone checks in remoteautomation are used
by mochitests and reftests but are awkward for other harnesses like cppunit
that do not use remoteautomation...and easily missed. This patch moves that
code to the mozharness AndroidMixin, treating ANRs and tombstones like the
logcat: Make sure any old logs are deleted when the mozharness script starts,
then move any logs found at the end of the run to the upload directory.
https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=f3de1e9836da2b0c9232f5d92c751b979459e19b
demonstrates tombstone artifacts for the Android 7.0 cppunit tests.

Differential Revision: https://phabricator.services.mozilla.com/D21774

--HG--
extra : moz-landing-system : lando
2019-03-05 14:22:45 +00:00
Geoff Brown 308d1fcb22 Bug 1517169 - Ensure Android remote test log is deleted before launching test app; r=bc 2019-01-02 09:50:36 -07:00
Geoff Brown 27c0a1415f Bug 1507207 - Improve support for e10s mode testing on Android; r=bc 2018-11-27 09:41:13 -07:00
Geoff Brown fa50b896b4 Bug 1509534 - Simplify Android runApp; r=bc 2018-11-27 09:41:12 -07:00
Geoff Brown a6aa854ab5 Bug 1503587 - Check for and kill errant crashreporter after Android browser tests; r=bc 2018-10-31 17:23:47 -06:00
Bob Clary 129bad1f48 Bug 1482887 - Remote automation should kill already running instances rather than dying, r=gbrown. 2018-08-18 10:47:12 -07:00
Bob Clary fbd6d3dfca Bug 1482878 - Use screencap to capture on physical android device screenshots, r=gbrown. 2018-08-18 10:47:12 -07:00
Bob Clary be2ccf78f3 Bug 1482874 - Handle Android 8.1 change for anr stack directory to contain individual files for traces, r=gbrown. 2018-08-18 10:47:12 -07:00
Geoff Brown 8b4653a7b7 Bug 1480546 - Enhance logging for Android automation app wait; r=bc 2018-08-07 10:05:37 -06:00
Bob Clary 745c5ff6c2 Bug 1477807 - Distinguish ADBTimeoutErrors from other exceptions in Android remote tests, r=gbrown. 2018-07-27 08:27:16 -07:00
Geoff Brown bea4bee944 Bug 1472032 - Increase Android browser time-out to 110 minutes; r=me,a=test-only
This time-out has traditionally been 90 minutes. It mustn't exceed the 120 minute
task time-out for android browser tests. Let's try 110 minutes.
2018-06-29 16:05:58 -06:00
Geoff Brown 4d05f461aa Bug 1464866 - Fix a typo in Android time-out message; r=me,a=test-only 2018-05-28 11:29:34 -06:00
Sylvestre Ledru dcfef841a7 bug 1463425 - Fix flake8/pep8 issue by hand in build/ r=gps
MozReview-Commit-ID: AZdcEWyVV6e

--HG--
extra : rebase_source : b1c45028c8d46be5ba590a27a2f9f20e248a26b1
2018-05-21 23:58:19 +02:00
Sylvestre Ledru 8cd16bb55b bug 1463425 - autopep8 on build/ r=gps
MozReview-Commit-ID: ETzx4HsjbEF

--HG--
extra : rebase_source : 7e27a4cfe2bb358d513a18a33c245bcc6d559c46
2018-05-21 23:56:34 +02:00
Geoff Brown 3680684f70 Bug 1452694 - Use TestRunnerActivity for geckoview mochitest/reftest; r=bc
This makes the changes necessary to use TestRunnerActivity when geckoview
is installed and requested, but we do not yet attempt to run any such
test tasks in automation.
2018-04-10 13:26:11 -06:00
Geoff Brown b4dddb3c35 Bug 1440719 - Set MOZ_CRASHREPORTER_SHUTDOWN during tests, other than browser-chrome and non-e10s; r=ted 2018-03-28 12:43:52 -06:00
Geoff Brown cf1401dff9 Bug 1448697 - Try to use force-stop instead of kill to end remote applications; r=bc
This is important for running browser tests on some non-privileged devices, where
kill may not be permitted.
2018-03-26 12:21:46 -06:00
Geoff Brown 6083932cff Bug 1440714 - Convert Android browser test harnesses to adb.py; r=bc
This affects Android robocop, mochitest (all flavors) and reftests (all flavors).
2018-03-23 18:06:27 -06:00
Geoff Brown 385ab244a3 Bug 1440674 - Simplify some code in remoteautomation.py; r=jmaher
remove RemoteAutomation._product and product options;
remove some unused code paths;
remove "blobber" references;
remove incorrect and/or unhelpful comments;
s/_devicemanager/_dm/ (shorter, improve readability)
2018-02-23 09:47:57 -07:00
Geoff Brown 0531bf800b Bug 1436262 - Improve efficiency of detection of end of test Android test runs; r=jmaher
Once a test summary is seen, check for application completion more often,
so that we can complete the test run sooner.
2018-02-07 13:33:44 -07:00
Geoff Brown 8b8a2994e8 Bug 1435433 - Print master test summary after android mochitests when runByManifest; r=jmaher 2018-02-07 13:33:43 -07:00
Mike Hommey 2b2a874b47 Bug 1420355 - Statically link DMD. r=njn
--HG--
extra : rebase_source : 8e7cf975d096116b666532f3fe8aa5a7f61b5725
2017-11-28 08:10:48 +09:00
Csoregi Natalia 4ce8d0124c Backed out 7 changesets (bug 1420355) for mass failures on OS X and Android. r=backout on a CLOSED TREE
Backed out changeset a7ed89e13a4c (bug 1420355)
Backed out changeset fd6702e6e0a0 (bug 1420355)
Backed out changeset 0479dda078a2 (bug 1420355)
Backed out changeset e69357ccca9e (bug 1420355)
Backed out changeset 3742a4b69ba2 (bug 1420355)
Backed out changeset 451cd087922f (bug 1420355)
Backed out changeset d80b5c4e1dd0 (bug 1420355)
2017-11-29 03:08:46 +02:00
Mike Hommey 7c62087a43 Bug 1420355 - Statically link DMD. r=njn
--HG--
extra : rebase_source : 46800c9c0c5006a5a32f11abc209da27e65ae0f5
2017-11-28 08:10:48 +09:00
John Lin 93c62b59f7 Bug 1417006 - remove tombstone files but keep the directory. r=dminor
MozReview-Commit-ID: Ds87KZ47vf1

--HG--
extra : rebase_source : 0578a58107b39abb546758cd8aa21c89e7b4b81f
2017-11-13 16:10:35 +08:00
Geoff Brown b6387e7f30 Bug 1412297 - Retry devicemanager getTopActivity once; r=jmaher
getTopActivity calls 'adb shell dumpsys window windows' which intermittently
times out. Instead of ending the test run when that happens, let's try
again, in hopes of recovering. If recovery fails and the browser is
subsequently found running, log an explanation before killing it.
2017-10-31 15:58:31 -06:00