When a top site was deleted, the snackbar that contains the undo button was overlapping the search toolbar.
The issue was that the anchor was not set.
Besides fixing the issue, the duplicated call of FenixSnackbar from TopSiteItemViewHolder.kt was removed.
Differential Revision: https://phabricator.services.mozilla.com/D206992
Automatic update from web-platform-tests
Fix error reporting in tools/serve/serve.py
In #45686 I reported the following log output:
```
❯ ./wpt serve
<irrelevant parts removed>
[2024-04-12 17:08:01,479 wss on port 33453] CRITICAL - Please ensure all the necessary WPT subdomains are mapped to a loopback device in /etc/hosts.
See https://web-platform-tests.org/running-tests/from-local-system.html#system-setup for instructions.
```
The underlying problem was actually https://github.com/GoogleChromeLabs/pywebsocket3/issues/38 and had nothing to do with the content of `/etc/hosts` (which had already been set up).
The problem is that `tools/serve/serve.py` contains numerous points like the following:
```python
try:
# <do something>
except Exception:
startup_failed(logger)
```
This swallows the actual exception, while `startup_failed` logs the message above. Since the actual problem is not as described, the logs are extremely misleading.
This change adds a log of the original exception to each location where the exception was swallowed. The log message includes enough context to help diagnose the problem.
With this change, the log output is as follows:
```
➜ ./wpt serve
<irrelevant parts removed>
[2024-04-29 18:01:15,751 wss on port 33175] CRITICAL - start_wss_server: Caught exception from WebSocketDomain: module 'ssl' has no attribute 'wrap_socket'
[2024-04-29 18:01:15,751 wss on port 33175] CRITICAL - Please ensure all the necessary WPT subdomains are mapped to a loopback device in /etc/hosts.
See https://web-platform-tests.org/running-tests/from-local-system.html#system-setup for instructions.
```
--
wpt-commits: 6ad503f0f467176f468e89f2e278de87116e4473
wpt-pr: 45956
Automatic update from web-platform-tests
Set the default device_serial argument (#45819)
It appears that WPT does not run on the Chrome Android browser
of the simulator unless the '--device-serial' argument is
explicitly added, after the PR[1] that introduced support for
multiple emulators. The CL only sets the default value(emulator-5554)
to Firefox Android. So this CL sets the default value to Chrome
Android browsers as well.
[1] Support multiple emulators for Android browsers (#31634)
(https://github.com/web-platform-tests/wpt/pull/31634)
--
wpt-commits: 99f5bfcd8599009aaedb3ddb341ea1be833b0db6
wpt-pr: 45819
Automatic update from web-platform-tests
webnn: Enforce input data type constraints for gemm and matmul
As specified in https://github.com/webmachinelearning/webnn/pull/646
Bug: 328567884
Change-Id: Ia55a214e7ad281ec3c8911e9116f388fac209d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5495161
Auto-Submit: Shiyi Zou <shiyi.zou@intel.com>
Commit-Queue: Shiyi Zou <shiyi.zou@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1294123}
--
wpt-commits: 0664d8153b085b9b3a94ecc52bc5b04d37e7d6fa
wpt-pr: 45945
Automatic update from web-platform-tests
Sync and regenerate the canvas tests after fd6e3178 (#45965)
Only the manifest for the element canvas tests was updated
in fd6e3178. This updates the offscreen manifest and generates
the actual tests for both.
--
wpt-commits: 679d8854550a361c073eca4b6a0813dd00dba830
wpt-pr: 45965
Automatic update from web-platform-tests
Support :user-valid/:user-invalid on multifield inputs
This patch makes :user-valid and :user-invalid start working on inputs
with type date, datetime-local, and time.
I matched the webkit behavior for when to start matching in response to
keyboard input, and added a separate tentative test for that behavior.
Fixed: 328674226
Change-Id: If3c394e43043a0b3d27eac22d0671c6b45b82bc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5463293
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294002}
--
wpt-commits: 6a7c427b1e2f8c5542e4515ae7d73afaa6e0f236
wpt-pr: 45792
Automatic update from web-platform-tests
[layout] Fix synthesis of inline baselines.
Previously for <button>, <input type=button> (and friends), and
<input type=range> we'd explicitly produce a baseline at appropriate
"end" edge.
This wasn't strictly correct instead we should be synthesizing them
within LogicalBoxFragment::BaselineMetrics.
There are three different ways to synthesize these baseline, off the
margin-box (the default), content-box (buttons), and border-box (range
and checkbox/radio with effective appearance).
Instead of checking all these conditions, this patch introduces an
additional field to the computed style to tell BaselineMetrics which
edge the synthesize off.
This patch changes two WPT tests which I believe were incorrect, see:
https://github.com/web-platform-tests/wpt/issues/45889
The TL;DR is that:
<button></button> <button style="contain:layout"></button>
Currently have different baselines when they shouldn't.
The image rebaselines are ensuring that we synthesize the baseline
for range controls consistently. Previously we'd synthesize them off
the border-box if they were in the same writing-mode, and off the
margin-box if in a different writing-mode.
Bug: 40937312
Change-Id: I28eedfbce58ead9d5e3119ae3b164c559fb9267c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5479489
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293898}
--
wpt-commits: b312464e2203190809de7c34055a51b7643ba6c2
wpt-pr: 45936
Automatic update from web-platform-tests
Remove legacy window-placement code.
1) Removes legacy window-placement permission and permission policy
code.
2) Updates tests from testing both variants to only test
window-management.
3) Updates comments that were referencing the old github URL.
4) Removes the experimental flag: WindowPlacementPermissionAlias
5) Removes kWindowPlacementPermissionAlias base feature. (Note that
it was previously enabled by default but the corresponding blink
feature was "experimental" which was enough to disable the feature).
5) Removes related deprecation warning tests.
Bug: 40842072
Change-Id: I58da5f7409d93c48cc7c65f09caa22577e8c975d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5441562
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mike Wasserman <msw@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Brad Triebwasser <btriebw@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293891}
--
wpt-commits: 0ad7b70827017751e454fb9fe5cda1a64e99a51c
wpt-pr: 45636
Automatic update from web-platform-tests
Keep element as fullscreen during atomic move
- We keep the kContainsFullScreenElement flag on the element, and
don't remove the element from top-layer
- We still clear the kContainsFullScreenElement flag from the old
node's ancestor chain
- When re-inserting, we set the kContainsFullScreenElement on the
new ancestor chain
Bug: 40150299
Change-Id: I0ffd6cb6ed12009646169419e96e06e69c9ab389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5466094
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Noam Rosenthal <nrosenthal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293887}
--
wpt-commits: f2874a51b30e774588a7dcdbdf82f6198c32d8d3
wpt-pr: 45800
Automatic update from web-platform-tests
Use simple rrect instead of Path for ClipPathClip if possible
This can enable fast rounded corners and avoid mask layers in more
cases.
Bug: 40241108
Change-Id: Ie80a511446e8905ff5f6793213e9f244fa1bb09f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5464825
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293880}
--
wpt-commits: fd379c4717c024424f2be6b3e23938dd8ef5c326
wpt-pr: 45894
Automatic update from web-platform-tests
Disallow atomic moves when moving across shadow/document
Using the node's TreeScope as a way to ensure this is valid.
Added new tests that rely on the CSS transition behavior of moveBefore.
This narrows down the impact surface of moveBefore, preventing potential
unknown edge cases. We can revise this and enable same-document
cross-shadow atomic moves in the future if the use case arises and the
implications are clear.
Bug: 40150299
Change-Id: Ie91afb678ee1b97d68d76337c0bbc5e04b6accdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5465565
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293836}
--
wpt-commits: 6fd74049d87db2bcbcdb483c450ad2b2a241e73b
wpt-pr: 45782
Automatic update from web-platform-tests
Early-exit from fetch metadata tests that cannot succeed.
`new Worker()` can only make same-origin requests: we're currently
testing a number of cross-origin cases that consistently fail across
browsers.
Bug: 40475877
Change-Id: I52ba08fa0e748ef6c79aaa891ef0d380310c98c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5497155
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1293796}
--
wpt-commits: c49bdcd7c8f6c99078d31d47eeccf194cda58a6c
wpt-pr: 45952
Automatic update from web-platform-tests
[css-viewport] Remove assert for offsetTop after modifying zoom property (#45927)
There's no spec about what we should do with the scrollTop value
after applying zoom. Which makes Firefox fail the test:
css/css-viewport/zoom/scroll-top-test-with-zoom.html
Anyway checking that intermediate value is not relevant for this test,
that is checking that the scrollTop value doesn't change
when coming back to the initial zoom level.
So this patch removes the assert checking that value.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1891910
for more details.
--
wpt-commits: 7047dc1ca2964fde10d4ff477f56c3309a0c2fdf
wpt-pr: 45927
Automatic update from web-platform-tests
[css-color] Tests assume old hsl()/hsla() clipping behavior or depend on unclear gamut mapping to sRGB (#45941)
https://github.com/web-platform-tests/wpt/issues/45814
Removes tests that were assuming the CSS Color 3 rules for hsl()/hsla()
where lightness and saturation values outside of 0-100 were clamped to
that range. CSS Color 4 states that only saturation below 0 is clamped.
To make it clear that only the saturation clamping is being tested, the
tests where that is still tested have been renamed to be more clear.
--
wpt-commits: fd6e317871ed6baeedfe25b03b79b73eb898d15c
wpt-pr: 45941
Automatic update from web-platform-tests
Export made from a WebKit repository (#45950)
Co-authored-by: Ziran Sun <zsun@igalia.com>
--
wpt-commits: 07358b5e59c46e0c60b6629c23d811f88738b993
wpt-pr: 45950
Automatic update from web-platform-tests
webnn: Migrate Pad validation tests to WPTs
This CL adds WPT tests for pad and removes the unit tests
`MLGraphBuilderTest.PadTest`, `MLGraphTestMojo.PadTest` and
`MLGraphTest.PadTest`.
Bug: 327337526, 328026885
Change-Id: Ic24215dea7c4b995719df168000e107064bef3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5476427
Reviewed-by: Austin Sullivan <asully@chromium.org>
Commit-Queue: Shanxing Mei <shanxing.mei@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Cr-Commit-Position: refs/heads/main@{#1293535}
--
wpt-commits: 722942181d5c231bda75561c05c44564800a1e42
wpt-pr: 45845
In bug 1769913, we remove the WorkerThreadRunnable's raw pointer to the corresponding WorkerPrivate and expect the corresponding WorkerPrivate to be obtained by GetCurrentThreadWorkerPrivate() when WorkerThreadRunnable::Run executing.
In general, the assumption is correct. However, it could be violated in the following two situations.
1. WorkerJSContext initialization fails.
2. WorkerThreadRunnable dispatching after CycleCollector shutdown.
In both cases, there is no corresponding WorkerJSContext to get its mWorkerPrivate by GetCurrentThreadWorkerPrivate(), which causes WorkerThreadRunnable to have no WorkerPrivate for executing.
For case 1, the WorkerThreadRunnables are all from WorkerPrivate::mPreStartRunnables. These runnables need a WorkerPrivate to execute WorkerRun(). To cleanup the resources through WorkerRun() if Worker initialization fails or shutdown before DoRunLoop() starts, WorkerThreadRunnable saves a CheckedUnsafePtr<WorkerPrivate> when the runnable is dispacthed to WorkerPrivate::mPreStartRunnables.
For case 2, the solution could be much easier since the WorkerThreadRunnable is not really a WorkerThreadRunnable. Because the Worker is in the "Dead" state, the WorkerThreadRunnable could not be dispatched normally, which means by WorkerThreadRunnable::Dispatch(WorkerPrivate). So it must be from NS_DispatchToCurrentThread(), WorkerThread::Dispatch(), or other ways which treat WorkerThread as nsIThread/nsISerialEventTarget, where the runnable is wrapped as a WorkerThreadRunnable and call nsThread::Dispatch() directly. In this case, the runnable does not need to be WorkerThreadRunnable, so we should be able to call the runnable's Run() directly.
Differential Revision: https://phabricator.services.mozilla.com/D208259
RebecaTudor
Julian Descottes
moz-wptsync-bot
dependabot[bot]
Tim Nguyen
Bradford Hovinen
Philip Jägenstedt
Gyuyoung Kim
Shiyi Zou
mei1127
Antoine Quint
Sam Weinig
L. David Baron
Joey Arhar
Ian Kilpatrick
Brad Triebwasser
Noam Rosenthal
Xianzhu Wang
Mike West
Dominic Farolino
Manuel Rego Casasnovas
Maksim Sadym
ziransun
Eitan Isaacson
Mark Banner
Mozilla Releng Treescript
Vinny Diehl
Eden Chuang
Emilio Cobos Álvarez
mcarare
Nicolas Chevobbe