Граф коммитов

12867 Коммитов

Автор SHA1 Сообщение Дата
Emilio Cobos Álvarez 3a5abc5912 Bug 1588737 - Simplify media query code now that lifetimes are non-lexical. r=xidorn
We can deindent and simplify a bunch of this code now.

Differential Revision: https://phabricator.services.mozilla.com/D49509

--HG--
extra : moz-landing-system : lando
2019-10-20 13:44:07 +00:00
Emilio Cobos Álvarez 3a1f428214 Bug 1588737 - Remove useless conditional compilation. r=xidorn
Servo doesn't use this flag or -webkit- prefixed media queries, so no point in
doing this conditionally.

Differential Revision: https://phabricator.services.mozilla.com/D49508

--HG--
extra : moz-landing-system : lando
2019-10-20 13:44:09 +00:00
Emilio Cobos Álvarez 26b98d2285 Bug 1588737 - Remove layout.css.prefixes.device-pixel-ratio-webkit. r=dholbert
There's no effort to disable it any time soon, so I don't think it's useful to
keep the pref around.

Differential Revision: https://phabricator.services.mozilla.com/D49507

--HG--
extra : moz-landing-system : lando
2019-10-20 13:43:57 +00:00
Emilio Cobos Álvarez 986d8c0d8e Bug 1588737 - Hide -moz-touch-enabled media query in Nightly and Early Beta. r=xidorn
This is effectively superseded by the hover / any-hover media queries, which
actually are standard, and is also causing trouble in the wild.

Not even the browser fronted uses it, so we should be able to just remove it
everywhere at once.

Differential Revision: https://phabricator.services.mozilla.com/D49506

--HG--
extra : moz-landing-system : lando
2019-10-20 13:44:16 +00:00
Emilio Cobos Álvarez 6752dad196 Bug 1548718 - Support multiple parts in ::part() selectors. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D48753

--HG--
extra : moz-landing-system : lando
2019-10-17 00:51:54 +00:00
Emilio Cobos Álvarez 1aaa268725 Bug 1588743 - Remove old scroll-snap implementation, and scroll snapping prefs. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D49267

--HG--
extra : moz-landing-system : lando
2019-10-15 12:40:14 +00:00
Coroiu Cristina 291d475197 Backed out changeset 1a951477dca5 (bug 1588743) for xpcshell failures at devtools/shared/tests/unit/test_css-properties-db.js on a CLOSED TREE 2019-10-15 15:35:50 +03:00
Emilio Cobos Álvarez 8325c4b9a3 Bug 1588743 - Remove old scroll-snap implementation, and scroll snapping prefs. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D49267

--HG--
extra : moz-landing-system : lando
2019-10-15 11:39:30 +00:00
Cameron McCormack cd4be0a31d Bug 1587235 - Report missing include filename in ServoBindings.toml. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D48625

--HG--
extra : moz-landing-system : lando
2019-10-09 10:44:29 +00:00
Emilio Cobos Álvarez 24a26b3b97 Bug 1587368 - Revert ccov bustage workaround now that builds have been updated.
Differential Revision: https://phabricator.services.mozilla.com/D48814

--HG--
extra : moz-landing-system : lando
2019-10-10 09:44:19 +00:00
Emilio Cobos Álvarez 86119bc696 Bug 1587468 - Update num_derive to 0.3. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D48731

--HG--
extra : moz-landing-system : lando
2019-10-09 20:22:05 +00:00
Emilio Cobos Álvarez f543161777 Bug 1587368 - follow-up: Unbust some ccov builds that are still using old Rust. a=shlindi
MANUAL PUSH: bustage
2019-10-09 18:42:09 +02:00
Emilio Cobos Álvarez ab7a52626a Bug 1587368 - Stop using -oldsyn bindgen version now that we pull newer syn and proc_macro versions anyway.
MANUAL PUSH: Cherry-picking upstream stuff, with reviewers that are not on phabricator.
2019-10-09 13:42:36 +02:00
Emilio Cobos Álvarez 95b0369470 Bug 1587368 - Fix servo build. 2019-10-09 13:35:51 +02:00
Emilio Cobos Álvarez b5fdaa85be Bug 1587368 - Rustfmt recent changes. 2019-10-09 13:35:50 +02:00
Emilio Cobos Álvarez 5a6d7ed393 Bug 1587368 - Cherry-pick updates towards syn 1.
From: https://github.com/servo/servo/pull/24308
2019-10-09 13:35:48 +02:00
Emilio Cobos Álvarez 2c773522c0 Bug 1587368 - Use consistent naming and shared code for out-of-flow stuff. r=nox
Use the functions introduced in ee17eedf3a857f27ce2b6b775574a3a455df8aa3.
2019-10-09 13:35:48 +02:00
Anthony Ramine c4a439d228 Bug 1587368 - servo: Update html5ever to 0.24. r=emilio 2019-10-09 13:35:46 +02:00
Simon Sapin c1af5161a0 Bug 1587368 - servo: WebIDL codegen: Replace cmake with a single Python script. r=emilio
When playing around with Cargo’s new timing visualization:
https://internals.rust-lang.org/t/exploring-crate-graph-build-times-with-cargo-build-ztimings/10975/21

… I was surprised to see the `script` crate’s build script take 76 seconds.
I did not expect WebIDL bindings generation to be *that* computationally
intensive.

It turns out almost all of this time is overhead. The build script uses CMake
to generate bindings for each WebIDL file in parallel, but that causes a lot
of work to be repeated 366 times:

* Starting up a Python VM
* Importing (parts of) the Python standard library
* Importing ~16k lines of our Python code
* Recompiling the latter to bytecode, since we used `python -B` to disable
  writing `.pyc` file
* Deserializing with `cPickle` and recreating in memory the results
  of parsing all WebIDL files

----

This commit remove the use of CMake and cPickle for the `script` crate.
Instead, all WebIDL bindings generation is done sequentially
in a single Python process. This takes 2 to 3 seconds.
2019-10-09 13:35:45 +02:00
Simon Sapin c00df807f7 Bug 1587368 - servo: Fix error message for invalid combination of style crate feature flags. r=emilio
Instead of ``cannot find value `engine` in this scope``
https://github.com/servo/servo/issues/24284
2019-10-09 13:35:44 +02:00
Anthony Ramine 42cb31df76 Bug 1587368 - servo: Uncomment more stuff related to box construction. r=emilio 2019-10-09 13:35:43 +02:00
Brendan Dahl ac5283b5c0 Bug 1510785 - Add way to disable XBL in servo. r=emilio
Adds a feature "moz_xbl" that when disabled causes the XBL code in servo to
be stubbed out.

Depends on D45613

Differential Revision: https://phabricator.services.mozilla.com/D45614

--HG--
extra : moz-landing-system : lando
2019-10-08 23:52:26 +00:00
Brian Birtles 8b913dca40 Bug 1586643 - Don't make visibility additive; r=boris
As per discussion here: https://github.com/web-platform-tests/wpt/pull/19160

This property type does not have a procedure for addition defined so it should
not be additive.

Differential Revision: https://phabricator.services.mozilla.com/D48454

--HG--
extra : moz-landing-system : lando
2019-10-08 01:27:29 +00:00
Emilio Cobos Álvarez 6d02538204 Bug 1585882 - Fix the case where where a node with an up-to-date style loses its frame due to a DOM mutation of siblings. r=heycam
This fixes another edge-case that I thought of while debugging this, I think
this makes our behavior correct now. The comment and test-case should be
self-descriptive.

Differential Revision: https://phabricator.services.mozilla.com/D48135

--HG--
extra : moz-landing-system : lando
2019-10-06 23:30:23 +00:00
Savo be6805c792 Bug 1586068 - Replace #define NS_STYLE_FLEX_WRAP with enum class. r=emilio
MANUAL PUSH: Rebasing contributor patch.

Differential Revision: https://phabricator.services.mozilla.com/D48166
2019-10-07 00:42:12 +02:00
Emilio Cobos Álvarez daab72e229 Bug 1585882 - Fix needs_frame() check to account for the case where an ancestor of us has been reconstructed regularly, not via lazy frame construction. r=heycam
This is a pre-existing bug, and this would be enough to fix the website, but
this is still not 100% correct. More on that in a second.

Differential Revision: https://phabricator.services.mozilla.com/D48134

--HG--
extra : moz-landing-system : lando
2019-10-05 09:25:21 +00:00
Morgan Reschenberg 05ad28e67c Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D42979

--HG--
extra : moz-landing-system : lando
2019-10-04 16:44:49 +00:00
Emilio Cobos Álvarez ea3d3a0084 Bug 1583736 - Don't allow negative radii in radial gradients. r=boris
Mostly renaming for clarity, as the gradient parsing code is a bit hairy.

This also changes -webkit- gradients, which is, I think, the right thing to do
(otherwise I need to give up on the type system and sprinkle parse_non_negatives
around, which would be unfortunate).

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=1008112 on
Chromium still accepting negative radii for those, so will wait to submit the
patch for review until they reply there with their intentions.

Differential Revision: https://phabricator.services.mozilla.com/D47141

--HG--
extra : moz-landing-system : lando
2019-10-01 21:44:41 +00:00
Boris Chiou 01cd967fa8 Bug 1510486 - Set WillChangeBits::TRANSFORM for individual transform. r=hiro
We always check StyleWillChangeBits_TRANSFORM bit together with a
transform-like property set, so using WillChangeBits::TRANSFORM bit to
represent all transform-like properties is ok.

However, it seems the new test case works well even if we don't have this
patch. I still add it for individual transform properties to make sure
the test coverage is enough anyway.

Differential Revision: https://phabricator.services.mozilla.com/D47509

--HG--
extra : moz-landing-system : lando
2019-09-30 21:52:30 +00:00
Mats Palmgren b15d020bef Bug 1581106 part 3 - [css-grid-2] Implement 'repeat(auto-fill, <line-names>)' in subgridded axis. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D46895

--HG--
extra : moz-landing-system : lando
2019-09-30 17:32:52 +00:00
Emilio Cobos Álvarez 41ff579eac Bug 1583471 - Don't pull new syn / quote / etc. dependencies just yet. r=bbouvier
Transition to syn 1.0 is ongoing, but these take a long time to build.

Hopefully we already patch coreaudio-sys manually so all the crates dependent on
bindgen are effectively in-tree.

I published v0.51.1-oldsyn to avoid pulling all these dependencies for now.

Differential Revision: https://phabricator.services.mozilla.com/D46966

--HG--
rename : third_party/rust/quote-0.6.11/tests/conditional/integer128.rs => third_party/rust/quote/tests/conditional/integer128.rs
rename : third_party/rust/unicode-xid-0.1.0/scripts/unicode.py => third_party/rust/unicode-xid/scripts/unicode.py
extra : moz-landing-system : lando
2019-09-25 09:50:10 +00:00
Benjamin Bouvier e207459263 Bug 1583471: Update bindgen to 0.51.1 througout the tree; r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D46962

--HG--
rename : third_party/rust/quote/tests/conditional/integer128.rs => third_party/rust/quote-0.6.11/tests/conditional/integer128.rs
rename : third_party/rust/unicode-xid/scripts/unicode.py => third_party/rust/unicode-xid-0.1.0/scripts/unicode.py
extra : moz-landing-system : lando
2019-09-25 09:50:10 +00:00
Boris Chiou 470629b5d3 Bug 1567330 - Add offset shorthand. r=emilio,birtles
Also, update the serialization by the shorter perference because this is
a new feature and using older syntax doesn't make sense.

Besides, use `cssOffset` for web animation IDL attribute name.

Differential Revision: https://phabricator.services.mozilla.com/D45607

--HG--
extra : moz-landing-system : lando
2019-09-23 19:56:33 +00:00
Emilio Cobos Álvarez e8cd2193b5 Bug 1579585 - Use fallible allocation for stylesheet invalidation. r=jwatt
If the sets get too big we cannot allocate anything else, we'll just empty them
and invalidate the whole document.

Differential Revision: https://phabricator.services.mozilla.com/D46828

--HG--
extra : moz-landing-system : lando
2019-09-23 19:08:22 +00:00
Brian Birtles 6bd2528448 Bug 1576866 - Make various border-image-* properties interpolable; r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D46724

--HG--
extra : moz-landing-system : lando
2019-09-23 02:07:56 +00:00
Brian Birtles 9108e5f393 Bug 1576866 - Parse '0' as a number for border-image-width; r=emilio
As per CSS Values & Units:

"However, if a 0 could be parsed as either a <number> or a <length> in a
property (such as line-height), it must parse as a <number>."

(https://drafts.csswg.org/css-values-4/#lengths)

Differential Revision: https://phabricator.services.mozilla.com/D46723

--HG--
extra : moz-landing-system : lando
2019-09-23 02:07:16 +00:00
Emilio Cobos Álvarez 49baadd637 Bug 1582814 - Let the CSS use counter prefs be independent. r=boris
* Let layout.css.use-counters.enabled be independent from the unimplemented
   property counters.

 * Always count in the style system (that is, always create
   Document::mStyleUseCounters), so that the warning from bug 1582374 works
   irrespective of these prefs.

 * Add a pref check to the SVGElement code path so that the prefs properly
   reflect whether the histograms end up being recorded or not.

 * Make the pref checks consistent (check both when reporting telemetry, not
   earlier).

Differential Revision: https://phabricator.services.mozilla.com/D46633

--HG--
extra : moz-landing-system : lando
2019-09-21 12:18:39 +00:00
Emilio Cobos Álvarez 732d7a819b Bug 1582627 - Always serialize aspect-ratio and font shorthand with spaces around the slash. r=heycam
Differential Revision: https://phabricator.services.mozilla.com/D46568

--HG--
extra : moz-landing-system : lando
2019-09-20 05:02:57 +00:00
Bogdan Tara 4ba431cc02 Backed out changeset 928b755ef57b (bug 1539212) for backplate-bg-image-006.html failures 2019-09-20 03:59:03 +03:00
Morgan Reschenberg b20a6706d3 Bug 1539212: Add readability backplate for all elements containing text when HCM or a11y theme is active. r=dholbert,mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D42979

--HG--
extra : moz-landing-system : lando
2019-09-19 21:25:12 +00:00
Daniel Holbert 99952c0744 Bug 1580012: In css 'display' blockification codepath, leave -moz-box alone and promote -moz-inline-box to -moz-box (if a new pref is set). r=emilio
This is in the interests of allowing the frontend team to experiment with
switching from XUL grid to CSS grid, without inadvertently changing the
display values for the grid items via css-grid-item blockification.

This patch's new pref is not expected to remain in the codebase for long.
We're just adding it so that the behavior remains the same by default, because
we do currently have some XUL code that inadvertently depends on -moz-box
display values being blockified to 'block'.  The plan is for folks to remove
that dependency e.g. by adding explicit 'display:block' styling to frontend
code as-needed. After we've done that, we can tentatively flip the pref to true
by default, and then remove the pref entirely.

Differential Revision: https://phabricator.services.mozilla.com/D45258

--HG--
extra : moz-landing-system : lando
2019-09-19 03:58:53 +00:00
Ting-Yu Lin 977a6275d1 Bug 1582224 - Split SIDEWAYS bit in WritingMode. r=jfkthame,emilio
Currently, there's no way to tell whether the SIDEWAYS bit is set from
`writing-mode:sideways-*` or `writing-mode:vertical-*; text-orientation:sideways;`.
To be able to tell them apart, split SIDEWAYS bits into VERTICAL_SIDEWAYS
and TEXT_SIDEWAYS. This is needed by my proposed solution in bug 1102175.

Also, provide convenience methods related to sideways writing-mode, and replace
obscure checks in the codebase.

Note that we don't have the use cases to distinguish vertical-rl from
sideways-rl in layout, but for the completeness, IsSidewaysLR() is still
defined.

Differential Revision: https://phabricator.services.mozilla.com/D46321

--HG--
extra : moz-landing-system : lando
2019-09-19 02:37:14 +00:00
Emilio Cobos Álvarez 95582debce Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-19 00:20:04 +00:00
Emilio Cobos Álvarez 2b159772ee Bug 1578661 - Merge the stylesheet use counters, report them, and add tests. r=boris
C'est fini. Now to do the same with the unimplemented ones remains, but it
should be straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D44698

--HG--
extra : moz-landing-system : lando
2019-09-19 00:19:59 +00:00
Cosmin Sabou 2978a72248 Backed out 10 changesets (bug 1578661) for linting failures on layout/style/ServoCSSPropList.py. CLOSED TREE
Backed out changeset b1b5393b1099 (bug 1578661)
Backed out changeset b87eebb0cf6e (bug 1578661)
Backed out changeset 6ba2ee45f26e (bug 1578661)
Backed out changeset 4a1d45160d60 (bug 1578661)
Backed out changeset 7a5687bebc02 (bug 1578661)
Backed out changeset 33c306c9020a (bug 1578661)
Backed out changeset 89d7e6fb24b0 (bug 1578661)
Backed out changeset 42c4943e569b (bug 1578661)
Backed out changeset 88d988a80de1 (bug 1578661)
Backed out changeset 78c90f9e9eee (bug 1578661)
2019-09-19 01:50:03 +03:00
Emilio Cobos Álvarez 4ce6b69adf Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:15 +00:00
Emilio Cobos Álvarez 65b3948518 Bug 1578661 - Merge the stylesheet use counters, report them, and add tests. r=boris
C'est fini. Now to do the same with the unimplemented ones remains, but it
should be straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D44698

--HG--
extra : moz-landing-system : lando
2019-09-18 15:15:24 +00:00
Andreea Pavel 7494b360c0 Backed out 10 changesets (bug 1578661) for lints failure at ServoCSSPropList.cpp on a CLOSED TREE
Backed out changeset ed3c619100e7 (bug 1578661)
Backed out changeset 027514a2eaf6 (bug 1578661)
Backed out changeset f2e228282b20 (bug 1578661)
Backed out changeset 67c36136dce7 (bug 1578661)
Backed out changeset 2280b27cc130 (bug 1578661)
Backed out changeset 445d13a2c452 (bug 1578661)
Backed out changeset 89caaa850049 (bug 1578661)
Backed out changeset 2f8be5db1786 (bug 1578661)
Backed out changeset 51a015a9a0f8 (bug 1578661)
Backed out changeset ad8e1f27a600 (bug 1578661)
2019-09-18 18:09:30 +03:00
Emilio Cobos Álvarez 30e754a811 Bug 1578661 - Report counted unknown properties as well. r=boris
Differential Revision: https://phabricator.services.mozilla.com/D44717

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:48 +00:00
Emilio Cobos Álvarez 6021f6b576 Bug 1578661 - Merge the stylesheet use counters, report them, and add tests. r=boris
C'est fini. Now to do the same with the unimplemented ones remains, but it
should be straight-forward.

Differential Revision: https://phabricator.services.mozilla.com/D44698

--HG--
extra : moz-landing-system : lando
2019-09-18 12:04:44 +00:00