Nicholas Nethercote
1a6f1a62fa
Bug 1387381 - Remove nsXPIDLString local variables. r=erahm.
...
nsXPIDLStrings are marked as VOIDED upon initialization. Most of these local
nsXPIDLString variables are immediately set via getter_Copies(), which will
either assign a string value (using Adopt()) or do SetIsVoid(). These can be
trivially converted to nsString, which will get the same treatment.
The patch suitably converts the remaining nsXPIDLString local variable as well.
--HG--
extra : rebase_source : 5fff9f2c6844559198f601853f8db08564add7d5
2017-08-08 16:07:55 +10:00
Julian Seward
408d24da56
Bug 1382563 - Remove ns*String::AssignWithConversion. r=erahm.
...
This patch replaces four functions of the name AssignWithConversion which
are essentially wrappers around CopyASCIItoUTF16 and LossyCopyUTF16toASCII
with direct calls to the latter two functions. The replaced functions are:
void nsCString::AssignWithConversion( const nsAString& aData )
void nsString::AssignWithConversion( const nsACString& aData )
void nsTString_CharT::AssignWithConversion(
const incompatible_char_type* aData,
int32_t aLength = -1);
The last of the three exists inside the double-included nsTString* world and
so describes two functions, giving four in total.
This has two advantages:
* it removes code
* at the call points, it makes clear (from the replacement name) which
conversion is being carried out. The generic name "AssignWithConversion"
doesn't make that obvious -- one had to infer it from the types.
The patch also removes two commented out lines from
editor/composer/nsComposerCommands.cpp, that appear to be related. They are
at top level, where they would never have compiled. They look like
leftovers from some previous change.
--HG--
extra : rebase_source : fb47bf450771c3c9ee3341dd14520f5da69ec4f5
2017-07-24 19:23:52 +02:00
Xidorn Quan
1358c75c5d
Bug 1384162 part 1 - DeCOMtaminate nsContentDLF::CreateBlankDocument. r=bz
...
MozReview-Commit-ID: 1KNNSIqrmZh
--HG--
extra : rebase_source : 8429bdd18f2c55acde245c4b4381735aff635042
2017-07-26 19:32:45 +10:00
Carsten "Tomcat" Book
1c55d9468a
Backed out changeset 7c3ddf34fc42 (bug 1377158) for stylo failures
2017-07-25 14:34:14 +02:00
KuoE0
8caf7792c4
Bug 1377158 - (Part 1) Make nsIDocumentLoaderFactory::createInstance() accept style backend type. r=heycam
...
MozReview-Commit-ID: L4kixMsCd8S
--HG--
extra : rebase_source : 09befb7bf27c146bc0df2b6be75439f5e51cfb99
2017-07-12 16:30:32 +08:00
Sylvestre Ledru
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Mats Palmgren
9542d00e58
Bug 1376498 part 2 - Use plain Remove(key) in some places instead of Lookup(key).Remove() for simplicity. r=froydnj
...
MozReview-Commit-ID: 7GlCL1jyGAz
2017-07-05 02:01:44 +02:00
Mats Palmgren
b9f0924f9a
Bug 1376491 - Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups. r=froydnj
...
MozReview-Commit-ID: 99pNpzMRvJF
2017-06-28 01:03:17 +02:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
ea1b86680c
Backed out changeset 9846de3bd954 (bug 1372405
)
...
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey
4592152411
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Henri Sivonen
2f2bb984f8
Bug 1372994 - Clear up leftover ISO-8859-1 encoding names. r=emk
...
MozReview-Commit-ID: IBuUPa9H9Q2
--HG--
extra : rebase_source : fb8db0c70caeec179d50b9ecaeb811d1e87eb0dd
2017-06-15 10:35:22 +03:00
Joel Maher
2a4e02f6d6
Bug 1341808 - annotate xpfe/* with BUG_COMPONENTS. r=enndeakin
...
MozReview-Commit-ID: 8vJu7e6DAHs
2017-04-06 07:29:57 -04:00
Florian Quèze
b11907c7aa
Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws.
2017-01-27 10:51:03 +01:00
Eric Rahm
d986dfc66d
Bug 1309409 - Part 1: Remove nsISupportsArray usage from nsIRDFDataSource. r=Pike
...
This converts the usage of nsISupportsArray in nsIRDFDataSource to just
nsISupports. Internally none of the params are used, all external usages in
the addons repo appear to just be passthroughs.
Regardless, any external implementors wanting to pass in an nsISupportsArray
can still do so as it is derived from nsISupports.
Additionally the |IsCommandEnabled| and |DoCommand| stubs are updated to just
return NS_ERROR_NOT_IMPLEMENTED as this functionallity is currently not
supported.
MozReview-Commit-ID: JJSHAQKiLSZ
2016-11-04 11:03:26 -07:00
Eric Rahm
125365b7da
Bug 1312144 - Part 1: Stop using nsISupportsArray in nsDirectoryViewer. r=froydnj
...
This swaps out nsIMutableArray for nsISupportsArray.
MozReview-Commit-ID: 9iZynpMcq6A
2016-10-24 11:31:15 -07:00
Eric Rahm
3bb810e812
Bug 1312144 - Part 0: Cleanup formatting. r=froydnj
...
This just cleans up some indentation and if statements.
MozReview-Commit-ID: JT585Zg4iJY
2016-10-24 11:31:14 -07:00
Nicholas Nethercote
2b67a0c986
Bug 1297300 - Add missing checks to GetSpec() calls in rdf/, startupcache/ and xpfe/. r=froydnj.
...
--HG--
extra : rebase_source : ea94044a5f674f80cdac2b382f3d58d71ba19088
2016-08-31 09:08:42 +10:00
Tom Tromey
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson
b175c9fdd5
Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo
2016-07-20 22:03:25 -07:00
Chris Peterson
8a9e2d2bd4
Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium
2016-05-14 00:54:55 -07:00
Chris Peterson
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
Andrea Marchesini
8c313db5c7
Bug 1252839 - Remove some if stmt after allocation with 'new' - patch 2, r=bz
2016-03-02 18:51:33 +01:00
Kyle Huey
91efc5a86c
Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug
2016-01-30 09:05:36 -08:00
Nicholas Nethercote
4669b76df0
Bug 1186790 - Replace nsBaseHashtable::EnumerateRead() calls in xpfe/ with iterators. r=neil.
...
--HG--
extra : rebase_source : 5d966b0ac332ebe9666b8c8ebc1a2de1cb1f6a86
2015-11-01 19:50:57 -08:00
Christoph Kerschbaumer
a84cc7dc39
Bug 1192943 - Use channel->asycnOpen2 in xpfe/components/directory/nsDirectoryViewer.cpp (r=sicking)
2015-11-02 09:55:06 -08:00
Nicholas Nethercote
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Chris Peterson
1416e566de
Bug 1198124 - Enable -Wshadow in directories that have no -Wshadow warnings. r=glandium
2015-08-25 09:14:38 -07:00
Birunthan Mohanathas
7315345693
Bug 1191100
- Remove XPIDL signature comments in .cpp files. r=ehsan
...
Comment-only so DONTBUILD.
2015-08-04 16:17:36 -07:00
Dragana Damjanovic
7987d2203e
Bug 905127 - Part 2 - remove unnecessary nsNetUtil.h includes r=jduell
2015-07-06 07:55:00 +02:00
Emanuel Hoogeveen
7d1e52f2ff
Bug 905127 - Part 1 - Make some functions from nsNetUtil not inline. r=jduell
2015-07-07 04:17:00 +02:00
Andrew McCreight
53e8d2ac49
Bug 958641 - De-holder nsIXPConnect::WrapNative. r=gabor
2015-07-01 11:17:17 -07:00
Jan de Mooij
303b210317
Bug 1177892 part 3 - Remove OBJECT_TO_JSVAL. r=evilpie
2015-06-30 21:09:46 -07:00
Neil Rashbrook
cf42e317ab
Bug 1155963 Only allow NS_LITERAL_CSTRING to be used on compile-time literals r=froydnj,ehsan
2015-05-16 09:07:10 +01:00
Wes Kocher
3c714c42eb
Backed out changeset 17cfad44e12b (bug 1155963) for breaking b2g builds
2015-05-14 16:35:18 -07:00
Neil Rashbrook
ae441fafa2
Bug 1155963 Only allow NS_LITERAL_CSTRING to be used on compile-time literals r=froydnj,ehsan
2015-05-15 00:00:33 +01:00
Philip Chee
b23f6e2222
Bug 1160770 - Unnecessary return in tabScrolling property in XPFE autocomplete.xml NPOTB r=Neil DONTBUILD
2015-05-03 00:15:40 +08:00
Jim Blandy
ebd83c9a61
Bug 1152577: Add 'aReason' argument to AutoEntryScript constructor, and provide plausible names for its instantiations. r=bholley
...
--HG--
extra : rebase_source : 8ab7a3628a5b4d94b957f24e23e4c5c7871db97c
2015-04-08 21:23:48 -04:00
Nathan Froyd
4c7234747e
Bug 1143651 - don't use CallQueryInterface when the compiler can do the cast for us; r=ehsan
2015-03-12 13:20:29 -04:00
Andrea Marchesini
e6f385fb3d
Bug 1148527 - Indentation fix after bug 1145631, r=ehsan
2015-03-27 18:52:19 +00:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Boris Zbarsky
a7d78c82c0
Bug 1136388. Change nsIDocumentLoaderFactory and nsIURIContentListener to take MIME types as an XPCOM string, not a char*. r=smaug
2015-02-25 10:26:51 -05:00
Chris Peterson
249ac81315
Bug 1110031 - Part 1: Mark more directories as FAIL_ON_WARNINGS. r=gps
2014-12-10 22:56:31 -08:00
Trevor Saunders
1a013270b5
bug 1105074 - make more stuff final r=froydnj
2014-11-25 13:56:07 -05:00
Neil Rashbrook
bfd24f75ba
Bug 1070768 Fix up more references to XPFE's autocomplete.css r=Ratty
...
DONTBUILD because NPOTB
2014-11-07 19:37:44 +00:00
Neil Rashbrook
26c7fc43eb
Bug 1070768 Move XPFE's autocomplete.css to communicator so it doesn't conflict with toolkit's new global autocomplete.css r=Ratty
2014-10-23 08:34:12 +01:00
Christoph Kerschbaumer
29facae35b
Bug 1041180: Remove deprecated nsIChannelPolicy (r=sstamm,jduell,jst)
2014-10-15 19:11:45 -07:00
Jon Morton
1700296f02
Bug 979835: Port BoxObject and its subclasses to WebIDL. r=khuey sr=bz
...
--HG--
rename : layout/xul/nsIPopupBoxObject.idl => dom/webidl/PopupBoxObject.webidl
rename : layout/xul/tree/nsITreeBoxObject.idl => dom/webidl/TreeBoxObject.webidl
rename : layout/xul/nsBoxObject.cpp => layout/xul/BoxObject.cpp
rename : layout/xul/nsBoxObject.h => layout/xul/BoxObject.h
rename : layout/xul/nsListBoxObject.cpp => layout/xul/ListBoxObject.cpp
rename : layout/xul/nsMenuBoxObject.cpp => layout/xul/MenuBoxObject.cpp
rename : layout/xul/nsPopupBoxObject.cpp => layout/xul/PopupBoxObject.cpp
2014-10-14 13:15:21 -07:00