Kannan Vijayan
3fb6190ec6
Bug 1559414 - Rename unaudited pre-fission methods with SameProcess for future audit burndown. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D39378
--HG--
extra : moz-landing-system : lando
2019-07-26 16:48:31 +00:00
Andrew Swan
188dd811fb
Bug 1543090
Clean up unused bits of XPIState r=zombie
...
XPIState.getModTime() was setting a .changed property that nothing ever
looks at. It also sets lastModifiedTime which is used from about:addons
but built-in addons aren't visible there so there's no point setting it
for them.
Differential Revision: https://phabricator.services.mozilla.com/D39061
--HG--
extra : moz-landing-system : lando
2019-07-26 02:45:52 +00:00
Boris Zbarsky
c411601264
Bug 1568884. Remove unnecessary QIs to nsIObjectLoadingContent. r=mossop
...
They're no-ops with Web IDL bindings.
Differential Revision: https://phabricator.services.mozilla.com/D39356
--HG--
extra : moz-landing-system : lando
2019-07-25 15:27:39 +00:00
Mark Striemer
f12772ecc5
Bug 1547017 - Hide the more options button when there are no items r=mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D38926
--HG--
extra : moz-landing-system : lando
2019-07-24 14:17:16 +00:00
Boris Zbarsky
a818800ec5
Bug 1568278. Remove various unnecessary QIs to nsIDOMWindow. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D39065
--HG--
extra : moz-landing-system : lando
2019-07-24 01:26:07 +00:00
Edwin Gao
7fd5fb983a
Bug 1555454 - disable permafailing tests on macosx1014, migrate mochitest-browser-chrome to macosx1014 r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D38783
--HG--
extra : moz-landing-system : lando
2019-07-23 18:30:26 +00:00
Mark Striemer
e8fcd3492e
Bug 1564522 - Grey out disabled add-ons in about:addons r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D38384
--HG--
extra : moz-landing-system : lando
2019-07-22 19:22:37 +00:00
Bogdan Tara
0cd03d6d7f
Backed out changeset ad5e0980c273 (bug 1555454) for central permafails on browser_devices_get_user_media.js a=backout
2019-07-22 07:45:40 +03:00
Edwin Gao
6383bcad31
Bug 1555454 - disable permafailing tests on macosx1014, migrate mochitest-browser-chrome to macosx1014 r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D38783
--HG--
extra : moz-landing-system : lando
2019-07-21 09:27:47 +00:00
Tim Nguyen
828a74cb4f
Bug 1554238 - Remove 'richlistitem' and 'category' bindings. r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D38261
--HG--
extra : moz-landing-system : lando
2019-07-19 20:04:19 +00:00
Coroiu Cristina
31758c22aa
Backed out changeset 00ab4104c304 (bug 1557175) for browser-chrome failures at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_optionsPage_popups.js on a CLOSED TREE
2019-07-19 22:17:24 +03:00
Mark Striemer
38c8adc28a
Bug 1557175 - Hide inline options when add-on is disabled r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D35068
--HG--
extra : moz-landing-system : lando
2019-07-19 16:09:16 +00:00
Luca Greco
bb5a69c3a8
Bug 1472740 - Remove usage of deprecated lwt aliased from browser_webapi_theme.js. r=ntim,robwu
...
Depends on D37889
Differential Revision: https://phabricator.services.mozilla.com/D37890
--HG--
extra : moz-landing-system : lando
2019-07-17 16:14:55 +00:00
Kris Maglione
0962c2b731
Bug 1566182: Annotate mochitests that fail with Fission enabled. r=mccr8
...
My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.
There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.
Differential Revision: https://phabricator.services.mozilla.com/D38247
--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
2019-07-15 16:19:32 -07:00
Julian Descottes
f771440e34
Bug 1539461 - Update extensions tests after removing aboutdebugging.new-enabled pref r=remote-debugging-reviewers,daisuke,rpl
...
Depends on D37864
Differential Revision: https://phabricator.services.mozilla.com/D37865
--HG--
extra : moz-landing-system : lando
2019-07-16 16:25:34 +00:00
Mark Striemer
e8a129da1b
Bug 1564515 - Update alignment and spacing in about:addons list r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D37732
--HG--
extra : moz-landing-system : lando
2019-07-16 11:43:04 +00:00
Gijs Kruitbosch
a44b86f060
Bug 1560178
- fix/remove about:addons tests that load discovery pane in the parent, r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D36308
--HG--
extra : moz-landing-system : lando
2019-07-12 16:27:27 +00:00
Dorel Luca
77d61d6a6f
Backed out 5 changesets (bug 1560178
) for Browser-chrome failures in builds/worker/workspace/build/src/dom/base/Document.cpp. CLOSED TREE
...
Backed out changeset 1ff8a41dd3c1 (bug 1560178
)
Backed out changeset 4aaeda889656 (bug 1560178
)
Backed out changeset b1dfc0b5a14c (bug 1560178
)
Backed out changeset 45fca0f1b675 (bug 1560178
)
Backed out changeset fc2be64e4ece (bug 1560178
)
2019-07-12 18:38:34 +03:00
Gijs Kruitbosch
0bd423ac63
Bug 1560178
- fix/remove about:addons tests that load discovery pane in the parent, r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D36308
--HG--
extra : moz-landing-system : lando
2019-07-12 12:35:20 +00:00
Tom Schuster
5b7ad5ebb7
Bug 1564967 - Rename More Options menu entry in about:addons to Details. r=mstriemer,fluent-reviewers,rpl,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D37707
--HG--
extra : moz-landing-system : lando
2019-07-12 00:05:52 +00:00
Luca Greco
d2092df77a
Bug 1561411 - Fix abuse report message bar string shown on report on addon uninstall. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D35993
--HG--
extra : moz-landing-system : lando
2019-07-10 19:29:39 +00:00
Luca Greco
b56ff15392
Bug 1556757 - Abuse Report panel should not show the 'broken reason' suggestion when addon support url is missing. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D35674
--HG--
extra : moz-landing-system : lando
2019-07-10 19:12:19 +00:00
Luca Greco
217df84885
Bug 1556403 - Hide abuse report author container element when addon author metadata is not available. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D35669
--HG--
extra : moz-landing-system : lando
2019-07-10 19:10:08 +00:00
Luca Greco
94105ea0a0
Bug 1562792 - Prevent extension file locking issues due to browser_html_abuse_report.js test cases. r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D37249
--HG--
extra : moz-landing-system : lando
2019-07-11 17:32:16 +00:00
Mark Striemer
912ad7a045
Bug 1561407 - Match message-bar font with other page styles r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D35848
--HG--
extra : moz-landing-system : lando
2019-07-11 14:41:19 +00:00
Cosmin Sabou
bb9fec28eb
Merge mozilla-inbound to mozilla-central. a=merge
2019-07-11 07:04:54 +03:00
Oriol Brufau
a526f3ed1f
Bug 1558823 - Show generic icon for extensions without icon. r=mstriemer,mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D36730
--HG--
extra : moz-landing-system : lando
2019-07-10 19:48:31 +00:00
arthur.iakab
fcec9d5243
Merge mozilla-central to mozilla-inbound
...
--HG--
extra : rebase_source : a169b55c78d3644d678e2f1ce7df2b2576d42e7f
2019-07-11 00:57:20 +03:00
Andrew Swan
b96422fc89
Bug 1563062 Part 2: Remove unused bits of old about:addons r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D36694
--HG--
extra : rebase_source : be7d1bc6d72c32c8099380dbd0fa2df560a5b979
2019-07-02 17:18:51 -07:00
Andrew Swan
5f2d70b85c
Bug 1563062 Part 1: Remove tests of old about:addons r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D36693
--HG--
extra : rebase_source : 4f06fcd08315f674f63a76592ad2fe78e5c91ba1
2019-07-08 11:04:06 -07:00
Dorel Luca
3708e4be2c
Backed out 2 changesets (bug 1563062) for Browser-chrome failure in toolkit/mozapps/extensions/test/browser/browser_gmpProvider.js. CLOSED TREE
...
Backed out changeset 59255dd51e9a (bug 1563062)
Backed out changeset 46ad01c26df8 (bug 1563062)
--HG--
extra : amend_source : a238d650d4e899382a7785070b9eb0b06a48f752
2019-07-10 01:29:53 +03:00
Andrew Swan
29e884ab88
Bug 1563062 Part 2: Remove unused bits of old about:addons r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D36694
--HG--
extra : moz-landing-system : lando
2019-07-09 19:50:07 +00:00
Andrew Swan
3bf625aa4d
Bug 1563062 Part 1: Remove tests of old about:addons r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D36693
--HG--
extra : moz-landing-system : lando
2019-07-09 19:33:33 +00:00
Sylvestre Ledru
90fac8fa22
Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D37217
--HG--
extra : moz-landing-system : lando
2019-07-10 12:03:37 +00:00
Andreea Pavel
b698eeec56
Backed out changeset 3d59cb02b6ff (bug 1562642) for eslint failure on a CLOSED TREE
2019-07-10 14:44:29 +03:00
Sylvestre Ledru
fd95abf361
Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D37217
--HG--
extra : moz-landing-system : lando
2019-07-10 11:15:25 +00:00
Jonathan Kingston
31441f82ea
Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D35504
--HG--
extra : moz-landing-system : lando
2019-07-08 16:37:45 +00:00
Victor Porof
815b9d372b
Bug 1561435 - Fix linting errors for toolkit/, r=standard8
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D35955
--HG--
extra : source : e6571d8ed75be94bdcdef8fbd0d977bfa92f3a34
extra : intermediate-source : 1351521a4bb3f78be45cf6bf6df90b4c75a959c4
2019-06-25 23:43:58 +02:00
Victor Porof
584e273f90
Bug 1561435 - Format toolkit/mozapps/, a=automatic-formatting
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D36057
--HG--
extra : source : fc2db4029f7eeae4942b42ca0b23873f150012b2
2019-07-05 11:17:14 +02:00
Rob Wu
ecba58f27a
Bug 1563581 - Remove redundant log warning when add-on is loaded r=mixedpuppy,kmag
...
Temporary add-ons were already ignored by the `isRecommended` getter of
`AddonWrapper, but they were still read and parsed, and consequently
resulted in unnecessary warning messages in the console.
This patch stops with warning about IO errors (because those are
expected for the majority of cases), and only logs a warning if there is
an actual parser error.
Differential Revision: https://phabricator.services.mozilla.com/D36987
--HG--
extra : moz-landing-system : lando
2019-07-04 22:32:39 +00:00
Kris Maglione
1952055c0c
Bug 1561122: Disable browser_html_abuse_report on Windows. r=me,test-only
...
--HG--
extra : rebase_source : 865786a0963419b84818f6d3afd745494217baa9
extra : source : d916d89a5c90af020cd5bc06f744f1ac8814ef1c
2019-07-01 19:18:32 -07:00
Emilio Cobos Álvarez
d998039c21
Bug 1562427 - Back out bug 1540984, since bug 1554405 fixes it in a way that doesn't need -moz-element(). r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D36679
--HG--
extra : moz-landing-system : lando
2019-07-02 22:20:43 +00:00
Rob Wu
2b97594781
Bug 1561827 - Move pluginPrefs initialization to pluginPrefs.js r=Gijs
...
The plugin preference rendering logic was in PluginProvider.jsm and
was tightly coupled to the markup of the XUL about:addons page,
and therefore does not work with the HTML about:addons page.
Fix this by moving the rendering logic to pluginPrefs.js (which is
loaded by pluginPrefs.xul), and updating the browser_pluginprefs.js unit
test to ensure that the rendering works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D36185
--HG--
extra : moz-landing-system : lando
2019-06-28 23:48:06 +00:00
Rob Wu
4180632b7d
Bug 1560746 - Fall back to default locale if localized name is missing r=kmag
...
Legacy add-ons can have null values instead of localized strings.
This breaks code that expects names to always be a string.
Fix this by falling back to the default locale.
This code is not needed for WebExtensions, because the name for those is
always a string, even if the translation is missing.
Differential Revision: https://phabricator.services.mozilla.com/D36266
--HG--
extra : moz-landing-system : lando
2019-06-27 23:01:28 +00:00
Luca Greco
d8896fa841
Bug 1551515
- Fix Library button focused/unfocused when clicking on a abuse report panel's radio button. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D31600
--HG--
extra : moz-landing-system : lando
2019-06-24 17:18:23 +00:00
He Yifei
ed9d09a791
Bug 1557524 - Add top margin for about:addons inline settings page. r=mstriemer,rpl
...
Added a top margin for about:addons inline settings page such that
the paddings would be consistent.
Differential Revision: https://phabricator.services.mozilla.com/D34817
--HG--
extra : moz-landing-system : lando
2019-06-21 23:22:16 +00:00
Kestrel
a8ee64bd36
Bug 1555371 - Apply context fill to update icon for dark mode and do the same for all panel-items r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D35168
--HG--
extra : moz-landing-system : lando
2019-06-19 08:55:34 +00:00
Kestrel
1535c1dd10
Bug 1553534 - Apply in-content colors to about:addons tab deck for dark mode compatibility r=jaws
...
Tabs use --in-content-box colors as seen in common.css, about:preferences Certificate viewer and about:logins.
Differential Revision: https://phabricator.services.mozilla.com/D35313
--HG--
extra : moz-landing-system : lando
2019-06-19 17:56:26 +00:00
Gijs Kruitbosch
1f87792af0
Bug 1559353 - ensure XML and remote settings lists are updated immediately when switching between them, r=leplatrem
...
Differential Revision: https://phabricator.services.mozilla.com/D35032
--HG--
extra : moz-landing-system : lando
2019-06-19 17:35:17 +00:00
Gijs Kruitbosch
fee2848e73
Bug 1559353 - fix test_blocklist_clients.js to actually work, r=leplatrem
...
It's unclear to me how this is passing on infra. After bug 1548542, as far as I can tell the only
time this test passes is when it somehow finishes before it does any of the filter testing.
The filter functions as-is (which predates that bug) does not allow these items to be in the
blocklist without something to identify what they're blocking (a guid/name for addons, a
matchXXXXX prop for plugins). Also, we no longer have a separate bucket pref for the extension
blocklist.
Before this patch, when this (rarely) passes for me on the local machine, it does so because
we bail out immediately after the initial run_test, as if the add_task functions have somehow
not registered. I do not understand why this would happen. In any case, after these changes,
we definitely run the rest of the test and it passes for me locally.
Differential Revision: https://phabricator.services.mozilla.com/D35030
--HG--
extra : moz-landing-system : lando
2019-06-19 14:20:38 +00:00