3505188f5e
Bug 1552787 - Log a more verbose error message in the console when a abuse report fails for a client or server submission error. r=mixedpuppy
...
This patch includes the response status and response text for the abuse report submission failures in the AbuseReportError message, to make it easier to investigate report submission errors.
Differential Revision: https://phabricator.services.mozilla.com/D32812
--HG--
extra : moz-landing-system : lando
2019-06-07 09:13:19 +00:00
4da63aeb53
Backed out 6 changesets (bug 1505909) for bc failures complaining about WebNavigationChild and browser_e10s_about_page_triggeringprincipal.js CLOSED TREE
...
Backed out changeset 56449fd37aee (bug 1505909)
Backed out changeset 3ff09b79821c (bug 1505909)
Backed out changeset a1a2a9efe22f (bug 1505909)
Backed out changeset 8aeb77291207 (bug 1505909)
Backed out changeset 4aa17e28ee54 (bug 1505909)
Backed out changeset dbe6803d979e (bug 1505909)
2019-06-07 06:15:16 +03:00
9a9c8d0dd9
Bug 1505909 - Don't forward non-existant contextmenu messages to the main window from about:addons. r=mixedpuppy,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D33166
--HG--
extra : moz-landing-system : lando
2019-06-06 20:33:29 +00:00
b43139b7b6
Bug 1557369 - Disable extension recommendations in discopane tests r=mstriemer,zombie,mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D33979
--HG--
extra : moz-landing-system : lando
2019-06-06 16:45:16 +00:00
a49f5263f1
Bug 1552714 - Fix tests to compare the result of getAttributes against L10nKeys. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D33740
--HG--
extra : moz-landing-system : lando
2019-06-06 16:33:09 +00:00
4076ada524
Bug 1555632: Add separate AddonManager.beforeShutdown barrier and use where appropriate. r=aswan
...
The AddonManager.shutdown barrier blocks the final phase of AddonManager
shutdown, which means that things which use it to mean "I need to do this
before the add-on manager shuts down" are generally broken.
This patch adds a separate beforeShutdown barrier which blocks the start of
provider shutdown, and changes existing broken consumers to use it. It also
renames the existing barrier to `AddonManagerPrivate.finalShutdown` to make it
clearer a) what it does, and b) that only internal AddonManager code should
use it.
Differential Revision: https://phabricator.services.mozilla.com/D33195
--HG--
extra : rebase_source : de20ecdc145a3b0c2565da910be6c99698b0b7df
extra : source : 678144498f35fd4ffafe8f0ddf5f64143d380dcb
2019-05-30 12:33:20 -07:00
37aa0653c9
Bug 1553650 - AddonList onUninstalling handler should check the addon type and pending operations. r=mstriemer,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D32369
--HG--
extra : moz-landing-system : lando
2019-06-05 11:56:26 +00:00
89f6a1aa42
Bug 1550911 - Show recommendations on extension and theme lists r=robwu,flod,jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D30745
--HG--
extra : moz-landing-system : lando
2019-06-04 01:50:33 +00:00
f35d98dcc4
Merge mozilla-central to mozilla-inbound
2019-06-01 12:45:58 +03:00
9b169ea3a5
Bug 1551213 - Update commands on show in HTML about:addons r=mixedpuppy,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D33304
--HG--
extra : moz-landing-system : lando
2019-05-31 22:19:50 +00:00
ce0c11236e
Bug 1532724 - Part 1: Inline options browser for HTML about:addons details r=rpl,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D29787
--HG--
extra : moz-landing-system : lando
2019-05-31 14:05:53 +00:00
0dc14776cd
Merge mozilla-inbound to mozilla-central. a=merge
2019-05-31 19:05:23 +02:00
b1b122fb20
Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D33031
--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
222a24635e
Bug 1553416 - Show system add-ons with shortcuts r=mixedpuppy,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D32118
--HG--
extra : moz-landing-system : lando
2019-05-30 22:44:41 +00:00
6fbf0558e0
Bug 1551563 - Hide hidden/builtin extensions in shortcuts view r=mstriemer,mixedpuppy,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D31795
--HG--
extra : moz-landing-system : lando
2019-05-30 22:44:48 +00:00
4d66e6276b
Bug 1551563 - Move shortcut test to own file r=mstriemer,mixedpuppy
...
In bug 1522757, a new test was added to verify that extensions without
shortcuts were hidden in the shortcut view, and shown in a list of
extensions without shortcuts.
The test was inserted in an existing test that did not have anything to
do with the change. In the next patch, I am going to add similar tests,
so the test logic was moved to a separate file.
Differential Revision: https://phabricator.services.mozilla.com/D31794
--HG--
extra : moz-landing-system : lando
2019-05-30 22:32:52 +00:00
402bc3a970
Bug 1553188 - Part 4 - Update remaining references to browser.xul;r=bdahl
...
These are generally:
- Code comments to browser.xhtml
- Testcases, assertions that were mostly using browser.xul as a generic chrome URL
- References to the browser.xul path in tree
Differential Revision: https://phabricator.services.mozilla.com/D33208
2019-05-28 16:40:42 -07:00
4693e3507d
Bug 1555389: Expect default theme to be inactive on dev edition. r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D33056
--HG--
extra : rebase_source : e5f751b6da23843a0ca5545590a2cab6dd24d050
2019-05-29 11:03:33 -07:00
e10165f100
No bug Fix blocklist component annotations r=me CLOSED TREE
...
--HG--
extra : rebase_source : 13e25892591f8da918274c75a1167b4af22b2567
extra : amend_source : ad4d3a0b83b9cdd23cc9c719aff41a5a002586ab
2019-05-30 11:00:33 -07:00
dcfb49e98b
No bug Add bugzilla component annotations for blocklist r=kmag DONTBUILD
...
--HG--
extra : rebase_source : 7a3d7c1e67cdca4134cd70ea41a7b6ee08365069
2019-05-30 09:31:53 -07:00
4c6ace6ac6
Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D31214
--HG--
extra : moz-landing-system : lando
2019-05-29 15:55:03 +00:00
944263f18a
Backed out 5 changesets (bug 1551798) for multiple build bustages on StaticPrefList.h CLOSED TREE
...
Backed out changeset c89daff34d97 (bug 1551798)
Backed out changeset bbc3f88b8c03 (bug 1551798)
Backed out changeset b87996b8a411 (bug 1551798)
Backed out changeset d88b0002d736 (bug 1551798)
Backed out changeset 0fe740c90e2b (bug 1551798)
2019-05-29 18:07:26 +03:00
e9bbb85ed1
Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D31214
--HG--
extra : moz-landing-system : lando
2019-05-24 15:18:49 +00:00
43b7abedc8
Bug 1539595 - Check the remoteType when we receive a privileged AMO message r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D30278
--HG--
extra : moz-landing-system : lando
2019-05-29 11:32:39 +00:00
ac6f9d6c71
Merge mozilla-central to autoland. a=merge CLOSED TREE
2019-05-29 01:09:35 +03:00
deb6cb04a5
Bug 1553448 - Improve appearance of card menu at about:addons r=mstriemer,jaws
...
- Render "hidden" appearance via opacity. This fixes the reported
regression, and also results in a desired fading of the icon (if any).
- Set cursor to "default" avoid "pointer" cursor in menu items.
- Let the "checked" icon adapt the color of the style sheet (e.g. to
account for dark themes) instead of using the default black color.
- Prevent clicks on non-button elements in the menu from expanding the
card, e.g. when the user clicks on the triangle or separator.
- Render menu item icon at the right in RTL locales.
Differential Revision: https://phabricator.services.mozilla.com/D32145
--HG--
extra : moz-landing-system : lando
2019-05-28 18:16:47 +00:00
c93b5324d2
Bug 1551541 - HTML about:addons should show permissions prompt when enabling sideloaded extensions. r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D31068
--HG--
extra : moz-landing-system : lando
2019-05-28 14:07:57 +00:00
25770a5232
Backed out changeset 1853d9e96a09 (bug 1550090) for test failures. Backout requested by ntim. CLOSED TREE
2019-05-28 21:09:53 +03:00
c3351b1306
Bug 1550090 - Fix theme active check. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D30396
--HG--
extra : moz-landing-system : lando
2019-05-28 15:34:25 +00:00
fba75a919c
Backed out 4 changesets (bug 1539595) for build bustage in nsAboutRedirector.cpp. CLOSED TREE
...
Backed out changeset 2b0bb889b087 (bug 1539595)
Backed out changeset 95f0b82ec253 (bug 1539595)
Backed out changeset 6310e6dabceb (bug 1539595)
Backed out changeset ba3e353c6957 (bug 1539595)
--HG--
rename : browser/base/content/test/tabs/browser_e10s_about_page_triggeringprincipal.js => browser/base/content/test/general/browser_e10s_about_page_triggeringprincipal.js
rename : browser/base/content/test/tabs/browser_e10s_about_process.js => browser/base/content/test/general/browser_e10s_about_process.js
rename : browser/base/content/test/tabs/browser_e10s_chrome_process.js => browser/base/content/test/general/browser_e10s_chrome_process.js
rename : browser/base/content/test/tabs/browser_e10s_javascript.js => browser/base/content/test/general/browser_e10s_javascript.js
rename : browser/base/content/test/tabs/browser_e10s_switchbrowser.js => browser/base/content/test/general/browser_e10s_switchbrowser.js
rename : browser/base/content/test/tabs/file_about_child.html => browser/base/content/test/general/file_about_child.html
rename : browser/base/content/test/tabs/file_about_parent.html => browser/base/content/test/general/file_about_parent.html
rename : browser/base/content/test/tabs/test_process_flags_chrome.html => browser/base/content/test/general/test_process_flags_chrome.html
rename : browser/base/content/test/tabs/browser_new_tab_in_privilegedabout_process_pref.js => browser/base/content/test/tabs/browser_new_tab_in_privileged_process_pref.js
2019-05-28 19:49:17 +02:00
d83f300d8d
Bug 1539595 - Check the remoteType when we receive a privileged AMO message r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D30278
--HG--
extra : moz-landing-system : lando
2019-05-28 14:09:09 +00:00
f8bc88a3eb
Bug 1551183: Part 3 - Add a test to sanity check the default theme on all platforms. r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D32225
--HG--
extra : rebase_source : 7577e30e91c478ae60fa82ad4f8459527bd83024
2019-05-22 14:34:44 -07:00
d3aac04243
Bug 1551183: Part 2 - Support enumerating directories in extensions in nested JARs. r=aswan
...
On Android, omni.ja is bundled inside an API, and therefore loaded as a nested
JAR. That means that its resource URIs resolve to something resembling
"jar🫙 ...!/omni.ja!/...". Our current enumeration code assumes no nesting
of jar: URIs, and therefore can't handle this.
This patch changes our enumeration helpers to accept URIs rather than nsIFile
instances, and to correctly handle resolving the ZipReaders for those nested
JARs. It also moves the path filter generation into the native helper to make
things easier for other callers which may need this behavior.
Differential Revision: https://phabricator.services.mozilla.com/D32224
--HG--
extra : rebase_source : 2a4f236f6066ddf65cf7ee78af87496dd3b4f882
2019-05-22 14:34:07 -07:00
760dbbdc88
Bug 1552184 - Go to discover if detail view add-on can't be found r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D31457
--HG--
extra : moz-landing-system : lando
2019-05-27 15:39:47 +00:00
993c03acb1
Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan
...
Differential Revision: https://phabricator.services.mozilla.com/D31769
--HG--
extra : moz-landing-system : lando
2019-05-22 22:37:14 +00:00
89ee522abc
Bug 1552537 - Include preferences option for plugins r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D31707
--HG--
extra : moz-landing-system : lando
2019-05-22 20:01:52 +00:00
b49196046b
Bug 1549548 - update browser tests for plugin blocking, r=mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D31346
--HG--
rename : browser/base/content/test/plugins/browser.ini => browser/base/content/test/plugins/browser-rs-blocklist.ini
extra : moz-landing-system : lando
2019-05-22 14:48:04 +00:00
75cc987da6
Bug 1456140 - Remove unnecessary size args for getChildList. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D31631
--HG--
extra : moz-landing-system : lando
2019-05-21 06:20:40 +00:00
ecf5714fea
Bug 1548542 - Remove notions of Kinto in blocklists unit tests r=keeler,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D31221
--HG--
extra : moz-landing-system : lando
2019-05-22 11:25:04 +00:00
8eb7224e54
Bug 1526018 - Initialize PSM clients in their own service r=Gijs,jcj
...
Differential Revision: https://phabricator.services.mozilla.com/D31603
--HG--
extra : moz-landing-system : lando
2019-05-21 21:14:11 +00:00
b633427366
Bug 965637: Move CSP from Principal into Client, part 1: backend changes. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D27654
--HG--
extra : moz-landing-system : lando
2019-05-21 23:14:27 +00:00
cc418f44e8
Bug 1551320 - Replace one more createElement with createElementNS. r=bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D31918
--HG--
extra : moz-landing-system : lando
2019-05-21 18:12:31 +00:00
543c10a1d2
Bug 1551320 - Replace all CreateElement calls in XUL documents with CreateXULElement. r=mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D31295
--HG--
extra : moz-landing-system : lando
2019-05-20 16:50:28 +00:00
677d6530b9
Bug 1551202 - Support dark theme for radio input at abuse reports r=jaws
...
- Put every color in a variable name.
- Add `label:hover` so that the radio input provides visual feedback upon hover.
- Implement "pressed" (`[type="radio"]:active`) and `:focus{border:0}`
to match Photon's design guidelines at
https://design.firefox.com/photon/components/radio-buttons.html
- Implement dark theme for radio inputs (using creative freedom as there
is no Photon guideline for this).
Differential Revision: https://phabricator.services.mozilla.com/D31510
--HG--
extra : moz-landing-system : lando
2019-05-18 05:47:16 +00:00
069ae86050
Bug 1551202 - Update <message-bar> to fully match Photon's style r=jaws
...
- Update info.svg to adjust color based on the fill color.
- Use button colors as defined by Photon (without this, the background
of the non-generic buttons are almost indistinguishable when dark
themes are enabled).
- Small refactor of message-bar.css to put all type-specific
declarations in one location.
Differential Revision: https://phabricator.services.mozilla.com/D31509
--HG--
extra : moz-landing-system : lando
2019-05-18 12:28:55 +00:00
af19ba5704
Bug 1551202 - Support dark theme at HTML about:addons r=jaws
...
Most colors have been replaced with a variable that has the same color
value.
The exception is the border color at the add-on details.
`--grey-90-a20` was replaced with `--in-content-box-border-color`,
whose value is `--grey-90-a30`. This is close enough.
Differential Revision: https://phabricator.services.mozilla.com/D31508
--HG--
extra : moz-landing-system : lando
2019-05-18 05:47:15 +00:00
0319a9ce33
Backed out 3 changesets (bug 1551202) for Causing Bug 1550093 to break on browser_parsable_css.js
...
Backed out changeset 70b0d5a417b8 (bug 1551202)
Backed out changeset 145429781395 (bug 1551202)
Backed out changeset 5f5daca84fbe (bug 1551202)
2019-05-18 08:28:33 +03:00
aa95e5912c
Bug 1544824 - Redirect to list view when an extension is removed r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D30738
--HG--
extra : moz-landing-system : lando
2019-05-17 20:21:25 +00:00
1477380289
Bug 1551202 - Support dark theme for radio input at abuse reports r=jaws
...
- Put every color in a variable name.
- Add `label:hover` so that the radio input provides visual feedback upon hover.
- Implement "pressed" (`[type="radio"]:active`) and `:focus{border:0}`
to match Photon's design guidelines at
https://design.firefox.com/photon/components/radio-buttons.html
- Implement dark theme for radio inputs (using creative freedom as there
is no Photon guideline for this).
Differential Revision: https://phabricator.services.mozilla.com/D31510
--HG--
extra : moz-landing-system : lando
2019-05-17 18:48:03 +00:00
70b1d66e05
Bug 1551202 - Update <message-bar> to fully match Photon's style r=jaws
...
- Update info.svg to adjust color based on the fill color.
- Use button colors as defined by Photon (without this, the background
of the non-generic buttons are almost indistinguishable when dark
themes are enabled).
- Small refactor of message-bar.css to put all type-specific
declarations in one location.
Differential Revision: https://phabricator.services.mozilla.com/D31509
--HG--
extra : moz-landing-system : lando
2019-05-17 16:57:13 +00:00
0845a53646
Bug 1551202 - Support dark theme at HTML about:addons r=jaws
...
Most colors have been replaced with a variable that has the same color
value.
The exception is the border color at the add-on details.
`--grey-90-a20` was replaced with `--in-content-box-border-color`,
whose value is `--grey-90-a30`. This is close enough.
Differential Revision: https://phabricator.services.mozilla.com/D31508
--HG--
extra : moz-landing-system : lando
2019-05-17 16:58:02 +00:00
1b9b276554
Bug 1550143 - Open links included in the abuse report panel using a null triggeringPrincipal. r=mstriemer,jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D30400
--HG--
extra : moz-landing-system : lando
2019-05-17 10:41:11 +00:00
1caa86aa66
Bug 1551455 - Reinstall distribution language packs. r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D31456
--HG--
extra : moz-landing-system : lando
2019-05-16 18:19:14 +00:00
225d93a362
Bug 1372033 - Added option to permanently disallow addon installation for a website. r=johannh,aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D28867
--HG--
extra : moz-landing-system : lando
2019-05-16 10:20:07 +00:00
40e016aded
Bug 1531964 - Permissions tab on add-on details page r=rpl,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D30429
--HG--
extra : moz-landing-system : lando
2019-05-16 14:14:29 +00:00
2748936152
Bug 1547835 - Show release notes on HTML about:addons details r=aswan,flod,rpl,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D30428
--HG--
extra : moz-landing-system : lando
2019-05-15 19:27:37 +00:00
b73495ced7
Bug 1550526 - Create deck with tabs for HTML about:addons details r=robwu,jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D29895
--HG--
extra : moz-landing-system : lando
2019-05-15 19:20:04 +00:00
2282e96a6d
Bug 1471522 - Move blocklist target app filter to Blocklist module r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D31222
--HG--
extra : moz-landing-system : lando
2019-05-15 22:22:50 +00:00
a98b93897c
Bug 1522823 - Policy for whitelist/blacklist addons by ID. r=aswan,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D27902
--HG--
extra : moz-landing-system : lando
2019-05-15 01:22:39 +00:00
50fb137a2c
Bug 1550521 - Remove private browsing help message with settings hidden r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D30747
--HG--
extra : moz-landing-system : lando
2019-05-14 17:36:10 +00:00
b511ab41ce
Bug 1550928 part 2. Stop using [array] in nsIPluginHost. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D30767
--HG--
extra : moz-landing-system : lando
2019-05-14 09:11:45 +00:00
8dea79d6de
Bug 1550928 part 1. Stop using [array] in nsIPluginTag. r=peterv
...
Differential Revision: https://phabricator.services.mozilla.com/D30766
--HG--
extra : moz-landing-system : lando
2019-05-14 09:11:37 +00:00
e9c7644627
Bug 1550647 - Updated test to check for addon-install-blocked events, improved AddonManger fullscreen block. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D30955
--HG--
extra : moz-landing-system : lando
2019-05-14 07:53:05 +00:00
4bf5812d4c
Merge mozilla-inbound to mozilla-central. a=merge
2019-05-14 07:10:36 +03:00
c1f5b7a338
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D23045
--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/search-textbox.js
extra : moz-landing-system : lando
2019-05-13 18:12:37 +00:00
0bc0968a7a
Backed out 2 changesets (bug 1547835, bug 1550526) for causing EventStateManager.cpp asertion failures CLOSED TREE
...
Backed out changeset 0bc1bd7285c1 (bug 1547835)
Backed out changeset 9053b1f316ff (bug 1550526)
2019-05-13 23:50:59 +03:00
43e302f3d3
Bug 1550529 - Load tabprompts.css as document stylesheet in the XUL about:addons page. r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D30655
--HG--
extra : moz-landing-system : lando
2019-05-13 20:29:48 +00:00
2a4fc64e5e
Bug 1550563 - Use new about:debugging URL in about:addons r=rpl,jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D30275
--HG--
extra : moz-landing-system : lando
2019-05-10 20:46:55 +00:00
98291bed43
Bug 1547835 - Show release notes on HTML about:addons details r=aswan,flod,rpl,kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D30428
--HG--
extra : moz-landing-system : lando
2019-05-13 19:04:11 +00:00
4bd67d819d
Bug 1550526 - Create deck with tabs for HTML about:addons details r=robwu,jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D29895
--HG--
extra : moz-landing-system : lando
2019-05-13 19:05:26 +00:00
f71d78cf3c
Bug 1532726 - Open add-on prefs in tab about:addons HTML r=flod,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D29786
--HG--
extra : moz-landing-system : lando
2019-05-13 19:04:06 +00:00
d47e202b04
Bug 1549192 Send ADDON_ENABLE startupReason for addons enabled early during browser startup r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D30603
--HG--
extra : rebase_source : e786630611f47291004bb9a1e681be8dade851a6
2019-05-09 15:54:06 -07:00
fb9c2d9660
Bug 1546248 - Add telemetry to discopane r=rpl,chutten
...
This adds telemetry with new actions and link values to uniquely
identify interactions with the discovery pane and recommended add-on
cards.
The card may appear in other views (bug 1523406), so the event names
must carefully be chosen to avoid confusion with other events. The
new "installFromRecommendation" and most link values are unique for
this reason.
The "manage" event can safely be reused, because it is only shown in the
discopane (in other views, the recommended add-on card would be replaced
with an actual add-on card).
Unrelated to this change, the documentation of "homepage" at Events.yaml
has been updated to clarify that it can also be a URL outside of AMO,
because that is the reality.
Differential Revision: https://phabricator.services.mozilla.com/D30533
--HG--
extra : moz-landing-system : lando
2019-05-13 15:03:22 +00:00
761b7556ea
Bug 1546997 - Expand add-on card with single click r=jaws
...
These originally changed to double click with the HTML version but it was decided
to stick with the single click and hover styles from the XUL version.
Differential Revision: https://phabricator.services.mozilla.com/D30740
--HG--
extra : moz-landing-system : lando
2019-05-11 03:12:18 +00:00
cc280c4be9
Backed out changeset c5798de806e2 (bug 1521280) for crashing when searching about:config for upcoming beta (bug 1551013)
...
--HG--
extra : rebase_source : 8f936159c23d09bf227ce4f5eb6f2d96d33bbff1
2019-05-13 08:50:28 +03:00
c5c77834f5
Bug 1548383 - Support extensions.getAddons.showPane in HTML discopane r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D30727
--HG--
extra : moz-landing-system : lando
2019-05-11 17:14:26 +00:00
4afbff4959
Backed out changeset 58acbc167331 (bug 1550090) for causing various bc perma failures CLOSED TREE
2019-05-11 14:16:06 +03:00
ad75d6928d
Bug 1550090 - Fix theme active check. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D30396
--HG--
extra : moz-landing-system : lando
2019-05-11 09:32:49 +00:00
ff3c537781
Bug 1550863 - Fix disabled menu item styles in HTML about:addons r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D30718
--HG--
extra : moz-landing-system : lando
2019-05-10 21:04:01 +00:00
1a57aab68e
Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
...
Differential Revision: https://phabricator.services.mozilla.com/D23045
--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/search-textbox.js
extra : moz-landing-system : lando
2019-05-10 11:46:49 +00:00
6ff10519fa
Bug 1549261 - Improved reliability of full-screen addon install block test. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D30471
--HG--
extra : moz-landing-system : lando
2019-05-09 19:59:03 +00:00
ef01932b50
Bug 1546248 - Loosen Client-ID check in unit test r=rpl
...
The client_id part of browser_html_discover_view_clientid.js was failing
on TV because of a pre-existing, test-specific issue in Telemetry.
Fixing this is not trivial, so just check that the ID was set instead of
checking its exact value.
See the comment for more details; the fix will be part of bug 1537933
Differential Revision: https://phabricator.services.mozilla.com/D30001
--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:18 +00:00
3964ab68f9
Bug 1546123 - Correct size calculation of theme previews r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D29482
--HG--
extra : moz-landing-system : lando
2019-05-08 23:36:31 +00:00
9675eda2fa
Bug 1546980 - Add ratings and user counts to discopane r=mstriemer,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D29481
--HG--
extra : moz-landing-system : lando
2019-05-08 23:36:32 +00:00
bb1e8193ce
Bug 1542262 - Match AMO's rating logic in about:addons r=mstriemer,Pike
...
- Fill stars based on whether the rating is within the 0.5 range of a
0.5-multiple, rather than checking whether the rating is at least as
large as the 0.5-multiple. This follows the boundaries at:
bb9277eeff/src/ui/components/Rating/index.js (L139-L140)bb9277eeff/src/ui/components/IconStar/index.js (L19)https://phabricator.services.mozilla.com/D29480
--HG--
extra : moz-landing-system : lando
2019-05-08 18:30:04 +00:00
163dcef402
Bug 1546248 - Add attribution parameters to AMO links r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D29479
--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:17 +00:00
07b06b75fa
Bug 1546248 - Put HTML discopane behind separate pref r=mstriemer
...
Require `extensions.htmlaboutaddons.discover.enabled` to be enabled
before the HTML-based discopane is shown. This allows the feature
to be turned on and/or off independent of the other HTML views.
Differential Revision: https://phabricator.services.mozilla.com/D29478
--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:17 +00:00
006cf25259
Bug 1546248 - Add notice to discopane when TAAR is enabled r=mstriemer,flod
...
The `<message-bar>` custom element used in this patch will be
introduced by https://phabricator.services.mozilla.com/D27547
The notice text and SUMO link target were taken from
6d2de7e52a/src/disco/pages/DiscoPane/index.js (L211-L213)https://phabricator.services.mozilla.com/D29477
--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:16 +00:00
a4d633137e
Bug 1546248 - Change "Get Add-ons" to "Recommendations" r=mstriemer,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D28936
--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:16 +00:00
dd8df1ac64
Bug 1546248 - Add discopane to about:addons HTML view r=mstriemer,flod,aswan
...
The api_response.json test file is the response from
https://addons-dev.allizom.org/api/v4/discovery/?lang=en-US
It has not been modified, except for being prettified using `json_pp`.
Differential Revision: https://phabricator.services.mozilla.com/D28436
--HG--
extra : moz-landing-system : lando
2019-05-09 14:22:16 +00:00
97a6924489
Bug 1549991 - No remove action on report submitted for add-ons without PERM_CAN_UNINSTALL. r=flod,mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D30366
--HG--
extra : moz-landing-system : lando
2019-05-09 06:41:13 +00:00
f513023141
Bug 1549706 - Use per addonType Fluent id for abuse-report remove and keep actions. r=flod,mstriemer
...
Depends on D30186
Differential Revision: https://phabricator.services.mozilla.com/D30187
--HG--
extra : moz-landing-system : lando
2019-05-08 16:24:56 +00:00
ca0496fc85
Bug 1549858 - move blocklist json into tests, r=kmag
...
Differential Revision: https://phabricator.services.mozilla.com/D30394
--HG--
extra : moz-landing-system : lando
2019-05-08 19:04:51 +00:00
3f60f66f05
Bug 1547994 - Remove preference that can disable Remote Settings signature verification r=glasserc
...
Differential Revision: https://phabricator.services.mozilla.com/D29656
--HG--
extra : moz-landing-system : lando
2019-05-07 14:16:22 +00:00
509b7f217a
Bug 1257565 - move addon blocklist tests from services/common to the blocklist dir, r=leplatrem
...
Differential Revision: https://phabricator.services.mozilla.com/D29835
--HG--
rename : services/common/tests/unit/test_blocklist_clients.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_clients.js
rename : services/common/tests/unit/test_blocklist_targetapp_filter.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_targetapp_filter.js
extra : moz-landing-system : lando
2019-05-07 00:56:01 +00:00
d773fd23da
Bug 1257565 - add remote settings support for plugin and addon blocklist, r=aswan
...
MozReview-Commit-ID: AiGycyhGUta
Differential Revision: https://phabricator.services.mozilla.com/D29834
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_appversion.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_appversion.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_metadata_filters.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_metadata_filters.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_osabi.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_osabi.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_flashonly.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_flashonly.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_outdated.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_outdated.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_regexp.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_regexp.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_severities.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_plugin_severities.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_prefs.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_prefs.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_severities.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_severities.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklistchange.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklistchange.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_pluginBlocklistCtp.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_pluginBlocklistCtp.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_pluginInfoURL.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_pluginInfoURL.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_softblocked.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_softblocked.js
extra : moz-landing-system : lando
2019-05-07 00:55:53 +00:00
d8a027e065
Bug 1257565 - switch gfx blocklist over to kinto-based storage, r=leplatrem,aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D29833
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist.json
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist2.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist2.json
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_AllOS.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_AllOS.json
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_OSVersion.xml => toolkit/mozapps/extensions/test/xpcshell/data/test_gfxBlacklist_OSVersion.json
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/head.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/head.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_gfx.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_gfx.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Device.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Device.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_DriverNew.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_DriverNew.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_DriverNew.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Equal_DriverNew.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_DriverOld.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Equal_DriverOld.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_OK.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Equal_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_GTE_DriverOld.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_GTE_DriverOld.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_GTE_OK.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_GTE_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_No_Comparison.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_No_Comparison.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OK.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OS.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OS.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_match.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OSVersion_match.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_mismatch_DriverVersion.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OSVersion_mismatch_DriverVersion.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_mismatch_OSVersion.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_OSVersion_mismatch_OSVersion.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Vendor.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Vendor.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Version.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_Version.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_prefs.js => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_gfxBlacklist_prefs.js
rename : toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/xpcshell.ini => toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/xpcshell.ini
extra : moz-landing-system : lando
2019-05-07 00:55:32 +00:00
34ee6c8005
Bug 1257565 - create a pref to phase out use of the XML blocklist, r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D29832
--HG--
extra : moz-landing-system : lando
2019-05-07 00:55:15 +00:00
53400f74d1
Bug 1257565 - move blocklist tests to their own dir so we can easily keep them working and separate from tests for the new implementation, r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D29831
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_appversion.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_appversion.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_gfx.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_gfx.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_metadata_filters.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_metadata_filters.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_osabi.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_osabi.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_plugin_flashonly.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_flashonly.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_plugin_outdated.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_outdated.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_plugin_regexp.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_regexp.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_plugin_severities.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_plugin_severities.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_prefs.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_prefs.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_severities.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_severities.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_url_parameters.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_url_parameters.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklist_url_ping_count.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklist_url_ping_count.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_blocklistchange.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_blocklistchange.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Device.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Device.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_DriverNew.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_DriverNew.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_DriverNew.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_DriverNew.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_DriverOld.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_DriverOld.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Equal_OK.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Equal_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_GTE_DriverOld.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_GTE_DriverOld.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_GTE_OK.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_GTE_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_No_Comparison.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_No_Comparison.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OK.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OK.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OS.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OS.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OSVersion_match.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_match.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OSVersion_mismatch_DriverVersion.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_mismatch_DriverVersion.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_OSVersion_mismatch_OSVersion.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_OSVersion_mismatch_OSVersion.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Vendor.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Vendor.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Version.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_Version.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_prefs.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_gfxBlacklist_prefs.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_overrideblocklist.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_overrideblocklist.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_pluginBlocklistCtp.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_pluginBlocklistCtp.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_pluginInfoURL.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_pluginInfoURL.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_softblocked.js => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/test_softblocked.js
rename : toolkit/mozapps/extensions/test/xpcshell/xpcshell.ini => toolkit/mozapps/extensions/test/xpcshell/xml-blocklist/xpcshell.ini
extra : moz-landing-system : lando
2019-05-07 00:55:02 +00:00
251b4874dc
Merge mozilla-central to autoland. a=merge CLOSED TREE
2019-05-07 01:33:06 +03:00
1a0cadf59d
Merge autoland to mozilla-central. a=merge
2019-05-07 00:43:07 +03:00
0fe9cabf19
bug 1549249 - follow-up to bump add-on db schema so users pick up the changes faster r=kmag a=ryanvm
...
Reviewers: kmag
Tags: #secure-revision
Bug #: 1549249
Differential Revision: https://phabricator.services.mozilla.com/D30113
--HG--
extra : amend_source : f73586d97a2a4797ff7595cfa822168d70145331
2019-05-06 13:53:00 -07:00
c41a8afa77
bug 1549249 - hard-code new add-on signing intermediate so it's always available r=jcj,kmag a=ryanvm
...
Summary:
Our previous approach to making this intermediate available relied on being able
to add it to the user's NSS cert DB. This does work in the majority of cases,
but there are some situations where it doesn't work (e.g. if the user's DB is
set to read only, if they've configured Firefox to run in "nocertdb" mode, if
they have a master password but forgot it, and so on). This patch compiles the
intermediate in to Firefox in the same way we incorporate the root, so it should
always be available.
At the same time, this patch reverts the changes from
023dd959512e2cfa685187616560f91efa91183c and
1d35f8d88bdd007e01d42c4ff76c6d10d7c01a98 (the patches that implemented the
original approach) because they should no longer be necessary.
Reviewers: jcj!, kmag!
Tags: #secure-revision
Bug #: 1549249
Differential Revision: https://phabricator.services.mozilla.com/D30090
--HG--
extra : amend_source : dd475918be3f263a4a363c66a60edc708d3bdcca
extra : histedit_source : b6861a1d7c7ddbe07d5df73d76734d9a48ee3164%2C54cbc4b0446ff1ee3dc860bb2d3798ba8f662566
2019-05-06 10:42:52 -07:00
0cd87e2e3e
Bug 1544927 - Record telemetry on integrated about:addons abuse reporting. r=aswan,janerik
...
Differential Revision: https://phabricator.services.mozilla.com/D29184
--HG--
extra : moz-landing-system : lando
2019-05-06 18:38:28 +00:00
88f53ef2b9
Bug 1544928 - Fix pending uninstall extension not yet active when onOperationCancelled is fired. r=aswan
...
Depends on D29122
Differential Revision: https://phabricator.services.mozilla.com/D29123
--HG--
extra : moz-landing-system : lando
2019-05-06 18:38:26 +00:00
2448c9bc05
Bug 1544928 - Allow to optionally report an extension on addon uninstall. r=flod,jaws,mstriemer
...
Depends on D29121
Differential Revision: https://phabricator.services.mozilla.com/D29122
--HG--
extra : moz-landing-system : lando
2019-05-06 18:38:23 +00:00
edd852e8ff
Bug 1544928 - Support pending uninstall in html about:addons. r=mstriemer,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D29121
--HG--
extra : moz-landing-system : lando
2019-05-06 18:38:21 +00:00
21d52c5cb5
Bug 1543377 - Add report action to html about:addons addon card options panel. r=mstriemer,flod
...
Depends on D26906
Differential Revision: https://phabricator.services.mozilla.com/D27294
--HG--
extra : moz-landing-system : lando
2019-05-06 18:36:20 +00:00
8ea36b7e78
Bug 1543377 - Add the abuse reporting WebComponents. r=mstriemer,flod,mixedpuppy,robwu
...
Depends on D27938 and D27547
Differential Revision: https://phabricator.services.mozilla.com/D26906
--HG--
extra : moz-landing-system : lando
2019-05-06 18:45:01 +00:00
5ad9453a80
Bug 1543377 - Create message-bar and message-bar-stack WebComponents. r=mstriemer,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D27547
--HG--
extra : moz-landing-system : lando
2019-05-06 18:35:44 +00:00
c5e820dd3d
Bug 1543377 - Add abuse report submission helpers. r=janerik,aswan
...
This patch contains a new jsm file which provides some helpers to be used for the
abuse report submission in the UI components related to abuse reporting,
and a new xpcshell test that unit test these helpers.
Differential Revision: https://phabricator.services.mozilla.com/D27938
--HG--
extra : moz-landing-system : lando
2019-05-06 18:45:01 +00:00
e9c2024ba3
Backed out 9 changesets (bug 1546980, bug 1546123, bug 1546248, bug 1542262) backed out for not being reviewed by a proper peer on a CLOSED TREE
...
Backed out changeset b3f31aa87d0d (bug 1546248)
Backed out changeset c372247f4432 (bug 1546123)
Backed out changeset 56f4b0058107 (bug 15469801542262
2019-05-06 19:41:37 +03:00
12463768ef
Bug 1546248 - Loosen Client-ID check in unit test r=rpl
...
The client_id part of browser_html_discover_view_clientid.js was failing
on TV because of a pre-existing, test-specific issue in Telemetry.
Fixing this is not trivial, so just check that the ID was set instead of
checking its exact value.
See the comment for more details; the fix will be part of bug 1537933
Differential Revision: https://phabricator.services.mozilla.com/D30001
--HG--
extra : moz-landing-system : lando
2019-05-06 11:19:25 +00:00
0deb1a997a
Bug 1546123 - Correct size calculation of theme previews r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D29482
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:36 +00:00
e5a72c28c3
Bug 1546980 - Add ratings and user counts to discopane r=mstriemer,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D29481
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:34 +00:00
483804f946
Bug 1542262 - Match AMO's rating logic in about:addons r=mstriemer,Pike
...
- Fill stars based on whether the rating is within the 0.5 range of a
0.5-multiple, rather than checking whether the rating is at least as
large as the 0.5-multiple. This follows the boundaries at:
bb9277eeff/src/ui/components/Rating/index.js (L139-L140)bb9277eeff/src/ui/components/IconStar/index.js (L19)https://phabricator.services.mozilla.com/D29480
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:26 +00:00
589c513fee
Bug 1546248 - Add attribution parameters to AMO links r=mstriemer
...
Differential Revision: https://phabricator.services.mozilla.com/D29479
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:24 +00:00
cc4b53e47a
Bug 1546248 - Put HTML discopane behind separate pref r=mstriemer
...
Require `extensions.htmlaboutaddons.discover.enabled` to be enabled
before the HTML-based discopane is shown. This allows the feature
to be turned on and/or off independent of the other HTML views.
Differential Revision: https://phabricator.services.mozilla.com/D29478
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:22 +00:00
5dd83d8207
Bug 1546248 - Add notice to discopane when TAAR is enabled r=mstriemer,flod
...
The `<message-bar>` custom element used in this patch will be
introduced by https://phabricator.services.mozilla.com/D27547
The notice text and SUMO link target were taken from
6d2de7e52a/src/disco/pages/DiscoPane/index.js (L211-L213)https://phabricator.services.mozilla.com/D29477
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:20 +00:00
4b5b11167b
Bug 1546248 - Change "Get Add-ons" to "Recommendations" r=mstriemer,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D28936
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:12 +00:00
acb77d2f29
Bug 1546248 - Add discopane to about:addons HTML view r=mstriemer,flod
...
The api_response.json test file is the response from
https://addons-dev.allizom.org/api/v4/discovery/?lang=en-US
It has not been modified, except for being prettified using `json_pp`.
Differential Revision: https://phabricator.services.mozilla.com/D28436
--HG--
extra : moz-landing-system : lando
2019-05-06 10:41:10 +00:00
2555fb9646
Bug 1545420 - Allow extensions to set Proxy-Authorization and connection isolation key through proxy.onRequest, r=dragana,mixedpuppy+mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D29825
--HG--
extra : moz-landing-system : lando
2019-05-06 07:22:18 +00:00
15881e3dff
Bug 1412561 - Block addon installation prompts in fullscreen mode. r=johannh,aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D27734
--HG--
extra : moz-landing-system : lando
2019-05-03 21:44:24 +00:00
33d7656e97
Bug 1549133: Make intermediate add-on signing cert injection less insane. r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D29955
--HG--
extra : moz-landing-system : lando
2019-05-05 04:44:34 +00:00
7bb82fa0dc
Merge mozilla-central to autoland a=merge on a CLOSED TREE
2019-05-06 00:42:50 +03:00
6f634e87e9
Merge inbound to mozilla-central a=merge on a CLOSED TREE
2019-05-06 00:38:28 +03:00
220dcf8df1
Bug 1549075 Follow-up Fix loading built in manifests r=zombie a=pascalc CLOSED TREE
...
Differential Revision: https://phabricator.services.mozilla.com/D29963
--HG--
extra : amend_source : f6cd21d8189ad059bea00e4f4bd373a013d31401
2019-05-05 09:04:47 -07:00
7bb54ec5aa
Bug 1549075 Follow-up: Fix system addon test on CLOSED TREE r=kmag a=bustage
2019-05-04 22:12:55 -07:00
c5b95ad0ce
Bug 1549075: Follow-up: Fix ESLint bustage on a CLOSED TREE. a=bustage
...
--HG--
extra : amend_source : 52d76b0c7fe42a57b90b6effcddb888647107ee1
2019-05-04 21:03:43 -07:00
acd424e5d9
Bug 1549075 Don't blow up on builtin addons while rebuilding the extensions database r=kmag a=lizzard CLOSED TREE
...
Differential Revision: https://phabricator.services.mozilla.com/D29954
--HG--
extra : amend_source : 0589d26ab75f9036034fb2d9f1e4280acf670b89
extra : histedit_source : fbb56252f19a30dd5c436f9cfe81a2b52ee037dc
2019-05-04 19:23:37 -07:00
8aceea0bac
Bug 1549061 - Add intermediate certificate r=kmag a=lizzard CLOSED TREE
...
This patch relies on a schema bump in a previous commit to be effective
for users.
Differential Revision: https://phabricator.services.mozilla.com/D29940
--HG--
extra : histedit_source : fa86330bd31d9bbbff2fa97d40abdd4ffbfbddd9
2019-05-04 21:39:46 +00:00
f9908e82a7
Bug 1549010: Part 2 - Bump DB schema version to force certificate reverification. r=zombie a=lizzard CLOSED TREE
...
Users who are affected by the intermediate add-on signing certificate expiry
need their add-on signatures re-verified as soon as possible after updating to
a version containging the fix. A database rebuild includes signature
reverifications, so a schema version achieves this.
Differential Revision: https://phabricator.services.mozilla.com/D29930
--HG--
extra : rebase_source : 421fe35aaf00d24fa2d79ebcc7dd2c749e1c1280
2019-05-03 21:32:17 -07:00
e329bc4d67
Merge mozilla central to mozilla inbound on a CLOSED TREE
2019-05-04 01:00:29 +03:00
5bd59ad140
Bug 1548869: Fix blocklist startup category registration. r=aswan
...
We're supposed to register this category for everything other than desktop
Firefox. Instead, we currently register it only for desktop Firefox.
Differential Revision: https://phabricator.services.mozilla.com/D29858
--HG--
extra : rebase_source : aaafd1704d9518dd9595c9e7229fb1ae5956acf7
2019-05-03 10:14:40 -07:00
4ccbb9175b
Bug 1535430 - Updates views for HTML about:addons r=mixedpuppy,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D29267
--HG--
extra : moz-landing-system : lando
2019-05-03 14:14:11 +00:00
6eb2084136
Bug 1544811 - Use web processes on a per-site basis for fission-enabled windows, r=mconley
...
This patch introduces a new type of content process, which has a dynamic name.
This type of content process is labeled as `webIsolated=${SITE_ORIGIN}` and is
used within fission-enabled windows.
To enable this, additional information about the fission status of the target
window must be passed into E10SUtils. This was done by updating every call site
manually to pass an extra boolean. A better solution perhaps should be used in
the future.
With this patch enabled, we now perform process switches, but only when
navigating to HTTP URIs. If we navigate to a non-HTTP URI in an iframe with
fission enabled, it will not behave correctly. This must be done in a
follow-up.
Differential Revision: https://phabricator.services.mozilla.com/D29570
--HG--
extra : moz-landing-system : lando
2019-05-03 21:31:57 +00:00
154872a672
Bug 1540984: Pre-load theme header image and share across all windows. r=aswan
...
For large header images, built-in memory caching does not work correctly, and
we wind up seeing a flicker any time a new window is opened or becomes active.
This patch caches the header image in an Image element at startup, and uses
that element as the backing for the header image in all browser windows.
Differential Revision: https://phabricator.services.mozilla.com/D29554
--HG--
extra : source : 6159d01c9341088edcabb318259c8ce6201c61ac
extra : amend_source : c43c543fd142f11b8439a6011a6ffe0f610e1015
2019-05-01 12:43:25 -07:00
6feaabc3c9
Bug 1547050 support builtin extensions in safemode r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D29091
--HG--
extra : moz-landing-system : lando
2019-05-02 18:21:21 +00:00
787d9413a8
Bug 1500626 - Convert <menuitem> bindings to a Custom Element r=surkov
...
Differential Revision: https://phabricator.services.mozilla.com/D9322
--HG--
extra : moz-landing-system : lando
2019-05-02 19:28:18 +00:00
2a74af237a
Bug 1547495 - disable browser_html_plugins test if windows10-aarch64 is detected as no plugin support is present r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D29282
--HG--
extra : moz-landing-system : lando
2019-04-29 22:14:19 +00:00
cc261e9e4a
Bug 1525174 - Plugin active states for HTML about:addons r=kmag,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D27967
--HG--
extra : moz-landing-system : lando
2019-04-27 00:30:48 +00:00
c2c49c5b01
Bug 1535683 - Part 3: Consolidate addon-card listeners into a single class r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D28338
--HG--
extra : moz-landing-system : lando
2019-04-27 00:30:36 +00:00
164001d459
Bug 1535683 - Part 2: Private browsing in HTML about:addons r=mixedpuppy,flod,jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D27138
--HG--
extra : moz-landing-system : lando
2019-04-27 00:30:41 +00:00
2535017b15
Bug 1535683 - Part 1: Manage extension updates in list/detail views r=aswan,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D27137
--HG--
extra : moz-landing-system : lando
2019-04-27 00:30:33 +00:00
411fe8b712
Bug 1535683 - Part 0: Store upgrade install on AddonWrapper r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D27599
--HG--
extra : moz-landing-system : lando
2019-04-27 00:30:21 +00:00
650e9d63ed
Bug 1546833 - Remove testpilot from AddonManager._installHostSource Map. r=aswan
...
Differential Revision: https://phabricator.services.mozilla.com/D28968
--HG--
extra : moz-landing-system : lando
2019-04-26 15:58:54 +00:00
d21d519dd6
Bug 1544111 - Fix contrast of various elements in HTML about:addons in dark mode. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D28378
--HG--
extra : moz-landing-system : lando
2019-04-26 11:57:00 +00:00
5f945421d4
Bug 1493599 - Expose reason of security blocking on nsILoadInfo and add new http observer notification for failed asyncOpens, r=Honza,dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D23150
--HG--
extra : moz-landing-system : lando
2019-04-26 10:59:41 +00:00
99a71d624d
Backed out changeset 0c643e1215c7 (bug 1544111) for failing bc at browser_parsable_css.js on a CLOSED TREE
2019-04-26 14:47:12 +03:00
11e9f0fe22
Merge mozilla-central to autoland. a=merge on a CLOSED TREE
2019-04-26 12:54:36 +03:00
Luca Greco
Bogdan Tara
Mike Conley
Rob Wu
Zibi Braniecki
Kris Maglione
Mark Striemer
Daniel Varga
Sebastian Hengst
Andrea Marchesini
Brian Grinstead
Andrew Swan
arthur.iakab
Tom Ritter
Oana Pop Rus
Razvan Maries
Tim Nguyen
Sylvestre Ledru
Gijs Kruitbosch
Michael Kaply
Mathieu Leplatre
Christoph Kerschbaumer
Brendan Dahl
Brendan Dahl
Dorel Luca
Paul Zuehlcke
Boris Zbarsky
Andreea Pavel
Ciure Andrei
Coroiu Cristina
Dana Keeler
Honza Bambas
Mihai Alexandru Michis
Nika Layzell
Shane Caraveo
Edwin Gao