Граф коммитов

528 Коммитов

Автор SHA1 Сообщение Дата
Sylvestre Ledru 4e9cf83ee8 Bug 1378712 - Remove all trailing whitespaces r=Ehsan
MozReview-Commit-ID: Kdz2xtTF9EG

--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Aaron Klotz 6ac7e2f671 Bug 1378141: Make 32-bit a11y builds make more thorough checks to determine which manifest to load; r=eeejay
MozReview-Commit-ID: 6Hx7ggqt9Ck

--HG--
extra : histedit_source : 28db28e939c947361988cb8e3c8d7932787cf47e
2017-07-04 16:04:35 -07:00
Aaron Klotz 44e203215a Bug 1374792: Modify a11y handler to only invoke IGeckoBackChannel::put_HandlerControl once; r=eeejay
MozReview-Commit-ID: Bxo0IsAuhBh
2017-06-30 12:04:02 -07:00
Aaron Klotz a129f378f7 Bug 1377195: Remove redundant main thread activation context from a11y::PlatformChild; r=eeejay
--HG--
extra : rebase_source : f8ff2ab8ca7eaf7c0dea9b082af7180f1a6d9208
2017-06-29 10:47:15 -07:00
Aaron Klotz 091386062e Bug 1354077: Modify a11y platform initialization to select and enable appropriate IAccessible manifest; r=eeejay
MozReview-Commit-ID: 1ODOm4Vc4UH
2017-06-06 12:19:17 -06:00
Aaron Klotz 9db0de2b03 Bug 1354077: Add manifests for IAccessible variants: 32-bit and 64-bit; r=jimm
MozReview-Commit-ID: CoHASAsg5tf
2017-06-06 12:19:12 -06:00
Aaron Klotz d5cffb7895 Bug 1375590: Replace NS_ERROR + IPC_FAIL_NO_REASON with IPC_FAIL in DocAccessibleParent; r=eeejay
--HG--
extra : rebase_source : 3859abca294230d6bc7061ee8b807191790f822b
2017-06-27 11:52:55 -07:00
Bill McCloskey f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Eitan Isaacson 71c52fe020 Bug 1375348 - Include last role as a good role to recieve from child. r=davidb 2017-06-23 08:55:38 -07:00
Carsten "Tomcat" Book 8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey 6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Aaron Klotz a33d941b4e Bug 1374643: Use IID instead of REFIID for a11y::HandlerProvider::mTargetUnkIid; r=jimm
MozReview-Commit-ID: IMFMxhHsbp6

--HG--
extra : amend_source : 10f8b88b0ba538241b59e88ad145db7479d64c07
2017-06-20 12:32:21 -06:00
Carsten "Tomcat" Book ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey 4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Eitan Isaacson 109fff34b9 Bug 1366374 - Check if AccessibleHandler.dll is registered before using. r=aklotz 2017-06-15 15:55:06 -07:00
Wes Kocher 3ee39c3f47 Backed out 3 changesets (bug 1354077) for assertions in AccessibleWrap.cpp a=backout CLOSED TREE
Backed out changeset 1380fe0f701b (bug 1354077)
Backed out changeset 2b5602bd352a (bug 1354077)
Backed out changeset a0fc3a1a9122 (bug 1354077)

MozReview-Commit-ID: ABHV3evXKrG
2017-06-12 16:54:10 -07:00
Aaron Klotz da19e2296f Bug 1354077: Modify a11y platform initialization to select and enable appropriate IAccessible manifest; r=eeejay
MozReview-Commit-ID: 1ODOm4Vc4UH

--HG--
extra : rebase_source : 6bac99f6e5e6318cf856f860edb373930979c92a
2017-06-06 12:19:17 -06:00
Aaron Klotz 05e5a2e310 Bug 1354077: Add manifests for IAccessible variants: 32-bit and 64-bit; r=jimm
MozReview-Commit-ID: CoHASAsg5tf

--HG--
extra : rebase_source : 84e30f4601c5f628cc731e1796601381cc012b6c
2017-06-06 12:19:12 -06:00
Aaron Klotz 230ddb60a5 Bug 1368571: Modify handler and interceptor marshaling code so that it strips out any handlers from proxies that are destined for non-Gecko processes; r=jimm
MozReview-Commit-ID: A1lCqvbQYAF

There is no clean API-based solution to this, so instead I went grovelling
through the DCOM wire protocol and was able to write a function that converts
handler OBJREFs into standard OBJREFs.

See also:
https://msdn.microsoft.com/en-us/library/cc226801

--HG--
extra : rebase_source : a650055c4adda3a1d99262e47f2b463074c6b935
2017-06-06 17:35:51 -06:00
Jim Mathies 10b72ec89d Bug 1309271 - Fire accessibility focus events from focused content elements when focus changes from chrome to content. r=surkov
MozReview-Commit-ID: 5Iu2TQ58kGa
2017-06-06 06:09:01 -05:00
Aaron Klotz 570cbae5c4 Bug 1364544: Ensure that proxied CARET_MOVED and FOCUS events update the Win32 system caret before firing their WinEvents; r=eeejay
MozReview-Commit-ID: LVML7EZaSYD

In non-e10s AccessibleWrap::HandleAccEvent, we special case our handling of
CARET_MOVED and FOCUS events with a call to UpdateSystemCaretFor. In e10s mode
we were not doing the same thing for proxied events sent from content. This
threw JAWS for a loop and presumably messes up other ATs as well.

This patch modifies the IPDL messages for these two events so that we may
send the caret rect along with the event, thus allowing us to update the
system caret for proxied events as well.

--HG--
extra : rebase_source : e1502c12b038739520afd5c7078d011e25ea669e
2017-05-15 14:11:46 -06:00
David Parks cff8d258a2 Bug 1330484 - Part 2: Remove invalid assert that checked that removed a11y child documents have no children. r=jimm
Here is a scenario under which the assert is invalid:

RecvHideEvent is received on a DocAccessibleParent DAP1 that has a child document DAP2... that in turn has a child document DAP3.  DAP1::RecvHideEvent calls Shutdown on its root ProxyAccessible.  This recursively calls Shutdown on child ProxyAccessibles until it reaches the one that is the parent of the child document DAP2.  ProxyAccessibleBase::Shutdown then attempts to Unbind DAP2, which calls DAP1::RemoveChildDoc, which trips the assert because DAP2 has child document DAP3.
2017-05-22 02:39:11 -07:00
David Parks 1810e88c32 Bug 1359129 - Use the most recent RootDocAccessible when delaying DocAccessibleChild messages. r=aklotz
We sometimes briefly have more than one root DocAccessible associated with a TabChild, for example, while navigating links in a page.  This patch makes sure that we use the correct accessible when delaying messages that we forward to the parent process.
2017-05-01 14:04:55 -07:00
Aaron Klotz 369e5eb9f0 Bug 1357967: Include mozilla-config.h in HandlerData.idl so that we have access to configured preprocessor defines; r=jimm
MozReview-Commit-ID: LWaxhDzq2ge

--HG--
extra : rebase_source : de6e88530e8c4ff6a8b43120a0fa9a944c643d84
2017-04-19 19:06:53 -06:00
Aaron Klotz 92ce20591b Bug 1357194: Use MOZ_UPDATE_CHANNEL to distinguish between local/nightly and beta/release builds for AccessibleHandler CLSIDs; r=mhowell,mshal
MozReview-Commit-ID: Kp8x5o66nrY

I want AccessibleHandler.dll to use different UUIDs based on release channel.
The way I was doing it before wasn't working correctly because I also wanted
local builds to have their own set of UUIDs vs our regular Nightly/Beta/Release
builds.

I also want the beta channel to have its own set of UUIDs that are distinct
from release.

I'm using MOZ_UPDATE_CHANNEL to distinguish between the channels when
NIGHTLY_BUILD and BETA_OR_RELEASE are insufficient.

--HG--
extra : rebase_source : 8cb28a22a3cac16fb743a8fe81db5e120c1fdf6d
2017-04-17 14:47:41 -06:00
David Parks 6a3359a108 Bug 1326084 - Unbind accessible child doc before replacing with new one. r=trevor
We need to update mChildDocs on child document removal.  This also cleans up some code related to setting a new child doc when one is already set -- we now assert that this cannot happen.
2017-04-07 13:26:45 -07:00
Aaron Klotz 4978c3cc95 Bug 1322532: Platform a11y changes to enable handler-based live regions; r=tbsaunde
MozReview-Commit-ID: nNPvBy3ZGO

--HG--
extra : rebase_source : 8c9f9e7a07e1e2268d922574273a3d65919513a7
2017-04-13 20:35:32 -06:00
Aaron Klotz 6302f1af4a Bug 1322532: Add sync text event to PDocAccessible; r=tbsaunde, r=billm
MozReview-Commit-ID: AFZMYghoOHe

--HG--
extra : rebase_source : 2364cf4a5ecaaceda151e16df170aebb77ae55e9
2017-04-13 17:08:42 -06:00
Aaron Klotz c06b376e9a Bug 1322532: Move a11y retrieval of native window handle to DocAccessibleChild; r=yzen
MozReview-Commit-ID: DwLBfAQJkRJ

--HG--
extra : rebase_source : 8ca53e9c4882ce9053e9a36428fed503ebe8919c
2017-02-21 11:27:33 -07:00
Aaron Klotz ba24d548f9 Bug 1322532: Add support for live regions to the com handler dll; r=tbsaunde
MozReview-Commit-ID: 1JPaUw5PrxU

--HG--
extra : rebase_source : e74cf6b3a2e9d78a3e939231ea06e0e3088fd538
2017-04-13 16:57:33 -06:00
Wes Kocher 5c3c7eb8db Backed out 4 changesets (bug 1322532) for windows static build failures a=backout
Backed out changeset df4e3ee037d6 (bug 1322532)
Backed out changeset 0acfde7a7a45 (bug 1322532)
Backed out changeset 34bf061d8e29 (bug 1322532)
Backed out changeset 954ea82470ed (bug 1322532)
2017-04-14 00:02:40 -07:00
Aaron Klotz 0ee7073299 Bug 1322532: Platform a11y changes to enable handler-based live regions; r=tbsaunde
MozReview-Commit-ID: nNPvBy3ZGO

--HG--
extra : rebase_source : d8a797c9ddfb3d8ab4f13c9f2f261fba04320beb
extra : histedit_source : cc4f0bd8ba26cc88bcf9907f684e5d6c240d354f
2017-04-13 20:35:32 -06:00
Aaron Klotz 1de2299a3a Bug 1322532: Add sync text event to PDocAccessible; r=tbsaunde, r=billm
MozReview-Commit-ID: AFZMYghoOHe

--HG--
extra : rebase_source : 22939e1a1208501fa646c02ee8199b72a16e14b5
extra : histedit_source : fd408d3d96578bc23c8d6627248c0578563e9b7e
2017-04-13 17:08:42 -06:00
Aaron Klotz 68616ae61e Bug 1322532: Move a11y retrieval of native window handle to DocAccessibleChild; r=yzen
MozReview-Commit-ID: DwLBfAQJkRJ

--HG--
extra : rebase_source : b206229f4167979d79c71e7cad11d01d7d60f9ed
2017-02-21 11:27:33 -07:00
Aaron Klotz c9721c0a3b Bug 1322532: Add support for live regions to the com handler dll; r=tbsaunde
MozReview-Commit-ID: 1JPaUw5PrxU

--HG--
extra : rebase_source : eef53f27be2d431c8b86c90e0681af9fb29c7d90
2017-04-13 16:57:33 -06:00
Ryan VanderMeulen cae23d0f9a Bug 1354293 - Don't try to build a11y IPC code that depends on accessibility being enabled. r=aklotz 2017-04-06 18:51:02 -04:00
Aaron Klotz 0a1611cdcd Bug 1303060: Build system changes for implementation of the caching COM handler for a11y; r=mshal
MozReview-Commit-ID: KBe1bw6xnhD

--HG--
extra : rebase_source : ea5f60be13f5ff6c0d295b4704646ceb44eb5794
2017-03-27 19:13:40 -06:00
Aaron Klotz 54c8ab6c9e Bug 1303060: Implementation of the caching COM handler for a11y; r=tbsaunde
MozReview-Commit-ID: HkiIgDQURtK

The a11y COM handler consists of two classes. AccessibleHandler is the one that
is actually interposed by COM between the client and the proxy. It implements
IAccessible2_3, IServiceProvider, and IProvideClassInfo. It is derived from
mscom::Handler which takes care of most of the COM boilerplate for handler
instantiation. AccessibleHandler must override a few virtual functions from
mscom::Handler:

* QueryHandlerInterface - mscom::Handler must implement the "real" QI. This is
  the method that mscom::Handler uses to delegate to the implementer.
* ReadHandlerPayload - deserializing the payload. This uses
  mscom::StructFromStream and the IA2Data_Decode function that was generated by
  midl. It should essentially be the inverse of the serialization code in the
  IHandlerProvider implementation inside Gecko.
* MarshalAs - identical to IHandlerProvider::MarshalAs
* GetHandlerPayloadSize and WriteHandlerPayload - it sucks that we have to
  include these, but they are neccessary for the scenario when COM wants to
  make a proxy of a proxy. When that happens, we need to get COM to serialize
  the payload again; it isn't smart enough to recognize payloads in existing
  proxies and copy them itself.

In order to reduce round trips, AccessibleHandler implements the most
sophisticated IA2 interface. This way the client has access to any of those
interfaces from IDispatch all the way down to IAccessible2_3 without needing to
incur additional round-trips to obtain them.

We also implement IServiceProvider so that a client may QueryService for an IA2
interface without needing to incur more round trips. In addition, we maintain
a list of service IDs that we definitely do not support, and handle those
locally instead of incurring an IPC round-trip.

We also implement IProvideClassInfo because NVDA's python code (and presumably
other ATs that use interpreted languages) supports using that interface to
assist its FFI library with resolution of our COM objects.

COM wraps each instance of an IAccessible* proxy with an AccessibleHandler
object. Proxies whose interfaces are not part of the IDispatch ... IAccessible2_3
hierarchy are not wrapped with handlers (though this might change in the future
if we need to expand coverage). AccessibleHandler implements IAccessible2_3 such
that, if we have cached data available for a particular IA2 method, we provide
that cached data to the client. Otherwise we pass on the request to the COM
proxy for retrieval via IPC.

The other class in the handler dll is AccessibleHandlerControl. This class
implements the IHandlerControl interface that is provided to IGeckoBackChannel.
Gecko dispatches cache invalidation events using this interface. This class
is a singleton within the handler dll and manages shared, handler-wide resources.

--HG--
extra : rebase_source : 4fc3910f789b0ed92c90655344ffb89f576ca5bd
2017-03-27 19:13:34 -06:00
Aaron Klotz d8b6197f8b Bug 1303060: Build system changes for a11y to enable the serving of a COM handler; r=mshal
MozReview-Commit-ID: 51r9ezFwDGE

--HG--
extra : rebase_source : cdc96a1c5f2c021c407d7c634036dd8cae7c04c6
2017-03-27 19:13:07 -06:00
Aaron Klotz b836337e81 Bug 1303060: Changes to a11y to enable the serving of a COM handler; r=tbsaunde
MozReview-Commit-ID: GTQF3x1pBtX

A general outline of the COM handler (a.k.a. the "smart proxy"):

COM handlers are pieces of code that are loaded by the COM runtime along with
a proxy and are layered above that proxy. This enables the COM handler to
interpose itself between the caller and the proxy, thus providing the
opportunity for the handler to manipulate an interface's method calls before
those calls reach the proxy.

Handlers are regular COM components that live in DLLs and are declared in the
Windows registry. In order to allow for the specifying of a handler (and an
optional payload to be sent with the proxy), the mscom library allows its
clients to specify an implementation of the IHandlerProvider interface.

IHandlerProvider consists of 5 functions:

* GetHandler returns the CLSID of the component that should be loaded into
  the COM client's process. If GetHandler returns a failure code, then no
  handler is loaded.
* GetHandlerPayloadSize and WriteHandlerPayload are for obtaining the payload
  data. These calls are made on a background thread but need to do their work
  on the main thread. We declare the payload struct in IDL. MIDL generates two
  functions, IA2Payload_Encode and IA2Payload_Decode, which are used by
  mscom::StructToStream to read and write that struct to and from buffers.
* The a11y payload struct also includes an interface, IGeckoBackChannel, that
  allows the handler to communicate directly with Gecko. IGeckoBackChannel
  currently provides two methods: one to allow the handler to request fresh
  cache information, and the other to provide Gecko with its IHandlerControl
  interface.
* MarshalAs accepts an IID that specifies the interface that is about to be
  proxied. We may want to send a more sophisticated proxy than the one that
  is requested. The desired IID is returned by this function. In the case of
  a11y interfaces, we should always return IAccessible2_3 if we are asked for
  one of its parent interfaces. This allows us to eliminate round trips to
  resolve more sophisticated interfaces later on.
* NewInstance, which is needed to ensure that all descendent proxies are also
  imbued with the same handler code.

The main focus of this patch is as follows:

1. Provide an implementation of the IHandlerProvider interface;
2. Populate the handler payload (ie, the cache) with data;
3. Modify CreateHolderFromAccessible to specify the HandlerPayload object;
4. Receive the IHandlerControl interface from the handler DLL and move it
   into the chrome process.

Some more information about IHandlerControl:

There is one IHandlerControl per handler DLL instance. It is the interface that
we call in Gecko when we need to dispatch an event to the handler. In order to
ensure that events are dispatched in the correct order, we need to dispatch
those events from the chrome main thread so that they occur in sequential order
with calls to NotifyWinEvent.

--HG--
extra : rebase_source : acb44dead7cc5488424720e1bf58862b7b30374f
2017-04-04 15:23:55 -06:00
David Parks 55dc6b7f68 Bug 1332690 - Assign Managers to DocAccessibleChilds. r=tbsaunde
The Manager is set by IPDL for remotely constructed objects but our DocAccessibleChilds are created on the child process side, so we need to assign a manager in the constructor so that we can find it when needed.

--HG--
extra : rebase_source : 8bf76534860ed73fbdc71df494130f6028400fa3
2017-03-27 10:03:43 -07:00
Trevor Saunders 502b0f327c bug 1332690 - don't try and bind child docs to a shutdown DocAccessibleParent r=yzen
a BindChildDoc message can race with the parent process shutting down a tab.
The result of that is that RecvBindChildDoc() can be called on a
DocAccessibleParent that has already been shut down by the destruction of the
owning TabParent.
2017-03-05 23:12:13 -05:00
Trevor Saunders 26401c70e6 bug 1340579 - fixup werror bustage landing on a CLOSED TREE 2017-03-01 17:45:04 -05:00
Trevor Saunders e8562200c5 bug 1340579 - look up this DocAccessibleParent in live docs instead of using this in DocAccessibleParent::Destroy() r=davidb 2017-03-01 17:23:48 -05:00
Aaron Klotz 9e3522ce1d Bug 1310166: Register ISimpleDOMNode typelib in content process; r=tbsaunde
MozReview-Commit-ID: 2JcIHJbHDgT
2017-02-23 11:32:06 -07:00
Trevor Saunders b7a422448c Bug 1341731 - fixup werror bustage. r=bustage-fix on a CLOSED TREE 2017-02-24 17:02:12 +01:00
Trevor Saunders 7e05a50676 bug 1341731 - propagate failures before working around them r=yzen 2017-02-24 10:26:27 -05:00
Sebastian Hengst 7bb022c060 Backed out changeset c1544abd34c2 (bug 1340903) for frequent failure of docshell/test/unit/test_setUsePrivateBrowsing.js on Linux opt and pgo. r=backout 2017-02-22 09:59:29 +01:00
Trevor Saunders c886524f63 bug 1340579 - add another diagnostic assert r=davidb 2017-02-21 22:27:49 -05:00
Trevor Saunders b2600d1cbe bug 1340903 - work around binding child docs to non outer DocAccessibles r=eeejay 2017-02-21 22:27:49 -05:00
Trevor Saunders 98b6c0804b bug 1332690 - work around non existant proxies 2017-02-21 11:19:51 -05:00
Eitan Isaacson 7f072468f4 Bug 1340733 - Fix attributes getter in win/ProxyAccessible. r=yzen
MozReview-Commit-ID: 7s3UrJlcsEQ

--HG--
extra : rebase_source : 8e9505a5d789088ba121b67be00c7f2b0aa332a8
2017-02-16 15:32:19 -08:00
Trevor Saunders dd89edabac bug 1197184 - downgrade various MOZ_DIAGNOSTIC_ASSERTs 2017-02-17 10:15:26 -05:00
Trevor Saunders 8db37fbd19 bug 1338755 - split up SetCOMProxy() r=yzen 2017-02-17 09:06:26 -05:00
Trevor Saunders 053f200a0c bug 1338755 - split parts of SetCOMProxy() out to MaybeInitWindowEmulation() r=yzen 2017-02-17 09:06:26 -05:00
Trevor Saunders 43c3840ad1 bug 1197181 - downgrade diagnostic assert in RecvHideEvent() 2017-02-16 16:27:40 -05:00
Trevor Saunders d758a5e011 bug 1338755 - split ParentCOMProxy message up r=yzen
sending the emulated window information is basically unrelated to sending the
parent COM proxy to the child process, and in the future it will be useful to
send these at different times.
2017-02-16 15:17:53 -05:00
Trevor Saunders 1f0c97f262 bug 1339472 - refer to child DocAccessibleParents by id r=yzen 2017-02-14 18:10:04 -05:00
Trevor Saunders 66243ccb3f bug 1339472 - make DocAccessibleParents refer to there parent document by id r=yzen
This saves a little space on x86_64 builds.
2017-02-14 18:10:03 -05:00
Trevor Saunders 9f62f9a5c1 bug 1339472 - keep a map from DocAccessibleParents to the actors themselves r=yzen 2017-02-14 18:10:03 -05:00
Trevor Saunders 2f8dccb36c bug 1339156 - add an assert to RemoveChildDoc() r=yzen 2017-02-14 11:10:47 -05:00
Trevor Saunders 570037515c bug 1339128 - reference parent proxy by id r=eeejay 2017-02-13 14:52:07 -05:00
Eitan Isaacson 5f324eb9dd Bug 1336637 - Support relation methods in xpc on windows. r=tbsaunde
MozReview-Commit-ID: BcyE0Vy1Fu4
2017-02-10 17:27:33 -08:00
Trevor Saunders 0525b774a0 bug 1337983 - remove incorrect assert r=aklotz
the outer doc of a top level content document does not necessarily exist when
we recieve the PDocAccessibleConstructor message for it.  So we shouldn't asser
there is an outer doc here.
2017-02-10 16:06:54 -05:00
Yura Zenevich e04a84bbc8 Bug 1206711 - pass emulated window proxy to doc accessible child to be used as parent IAccessible for top level documents. r=tbsaunde
MozReview-Commit-ID: 4ejD6OmNgiR
2017-02-10 08:11:29 -05:00
Trevor Saunders 96fc2fb77a bug 1326084 - rework ProxyAccessible handling of outer docs 2017-02-10 00:41:29 -05:00
Wes Kocher afcf40f3ea Backed out changeset 15d237d39fb8 (bug 1332690) for asserts in DocAccessibleParent.cpp a=backout
MozReview-Commit-ID: BwRMVLvOSde
2017-02-08 16:19:20 -08:00
Trevor Saunders dbe8f2a177 bug 1332690 - remove diagnostic for nonexistant proxies 2017-02-08 14:22:14 -05:00
Trevor Saunders 83b95e091a bug 1336901 - remove incorrect assert r=yzen
There are cases where there is no good reason to shutdown the child document
actors before the parent.  For example when TabParent::DestroyInternal() is
about to send the Destroy message we might as well just shut down the top level
document and let that tear down the rest.
2017-02-06 13:21:30 -05:00
Trevor Saunders a7e68b58ed bug 1337028 - add another diagnostic assert to DocAccessibleParent::Destroy() r=yzen 2017-02-06 13:21:30 -05:00
Wes Kocher 10fb637abf Merge m-c to inbound a=release CLOSED TREE
MozReview-Commit-ID: AwyW5DU4EMh
2017-02-03 17:21:29 -08:00
Trevor Saunders 47cd47695a backout bug 1326084 2017-02-03 12:47:51 -05:00
Eitan Isaacson 78e90909da Bug 1335825 - Provide full state bitfield to xpcom accessibles in Windows. r=yzen
MozReview-Commit-ID: H7lFB5khEJm
2017-02-03 15:22:09 -08:00
Trevor Saunders 820cf8dcf5 bug 1334673 - ignore some invalid Show event messages r=davidb 2017-02-02 11:37:16 -05:00
Trevor Saunders 8765a50df4 bug 1326084 - fixup shutting down a ProxyAccessible with no child doc 2017-02-02 11:37:16 -05:00
Eitan Isaacson 2725184bbf Bug 1335220 - Add minimumIncrement to windows ProxyAccessible. r=yzen
MozReview-Commit-ID: DY89qIALmrq
2017-02-01 12:37:13 -08:00
Trevor Saunders 8d2ecdbd5d bug 1326084 - ClearChildDoc() should leave the proxy marked as being an outerdoc r=aklotz
Since it can be called in strange orderings wrt SetChildDoc() it seems
reasonable to believe we can get an ordering where the proxy has a document as
a child but is not marked as having document children.
2017-02-01 14:37:01 -05:00
Trevor Saunders 5e44465e8d bug 1333514 - fix race between PDocAccessibleConstructor messages and PBrowser::Destroy messages r=billm 2017-01-26 10:01:43 -05:00
Yura Zenevich 299ef55172 Bug 1329697 - registering typelib for IGeckoCustom interface. r=aklotz
MozReview-Commit-ID: CIvoSrPrRVM
2017-01-25 13:40:17 -05:00
Yura Zenevich 26f2c60483 Bug 1206711 - add support for HWND emulation for content top level docs on Windows. r=tbsaunde
MozReview-Commit-ID: GQ1LxCwtv3j
2017-01-24 09:45:25 -05:00
Trevor Saunders b09bcb000f bug 1324863 - paper over null parent proxy accessible r=davidb 2017-01-23 17:08:16 -05:00
Trevor Saunders 0d5925b408 bug 1332690 - return failure from DocAccessibleParent::RecvShow() when appropriate r=yzen 2017-01-23 11:09:39 -05:00
Trevor Saunders 71398a8500 bug 1331255 - annotate some IPC failure conditions r=eeejay 2017-01-18 16:09:45 -05:00
Trevor Saunders 3be357c7ba bug 1330730 - make sure mAccessibles and mChildDocs are cleared by DocAccessibleparent::Destroy() r=davidb
This shouldn't be necessary because shutting down all the proxies and child
  documents should already do it, but we might as well be sure.
2017-01-16 17:18:52 -05:00
Trevor Saunders 24d013e645 bug 1330730 - ignore events delivered to a destroyed DocAccessibleParent r=smaug
After bug 1329814 a DocAccessibleParent can be shutdown by the parent process
before a content process has started shutting down the document that
DocAccessibleParent represents.  That means the content processcan send an
event from a live document to a DocAccessibleParent that has already been
destroyed.
2017-01-16 17:18:52 -05:00
Trevor Saunders 235c3677ff bug 1329814 - fix race condition when shutting down a tab r=smaug
When TabChild recieves the Destroy message from its parent the doc accessibles
for that tab are shut down.  However if the Shutdown message sent by
DocAccessible::Shutdown() isn't recieved before the child process handles the
runnable that sends __delete__ to the tab parent actor the parent can send a
message to the already shut down doc accessible child actor.
2017-01-12 05:19:36 -05:00
Carsten "Tomcat" Book 58249e3bf0 Backed out changeset 18151dec259d (bug 1184217) for causing bug 1329644 2017-01-10 16:55:37 +01:00
Yura Zenevich 4a9e23d316 Bug 1269369 - add support for GetID XPCOM method on Windows with e10s. r=tbsaunde
MozReview-Commit-ID: KXhDeNW3Oaw
2017-01-09 14:52:51 -05:00
Trevor Saunders 971e419e21 bug 1184217 - make CheckDocTree check the entire document tree not just the subtree r=davidb 2017-01-08 17:30:54 -05:00
Trevor Saunders 2bc78b9768 bug 1301148 - implement anchor at for windows r=aklotz 2017-01-05 10:48:10 -05:00
Trevor Saunders 0ec84956f2 bug 1301148 - allow getting a proxy accessible from a com proxy r=aklotz 2017-01-05 10:48:10 -05:00
Trevor Saunders 70cc56383f bug 1301148 - implement anchor count for windows r=aklotz 2017-01-05 10:48:10 -05:00
Trevor Saunders 1cdf6bbf9b bug 1301148 - implement easy parts of nsIAccessibleHyperlink r=aklotz 2017-01-05 10:48:09 -05:00
Aaron Klotz 0f16e8d38d Bug 1323996: Make PDocAccessible.ipdl import IAccessibleHolder from IPCTypes.h to fix --disable-accessibility build failures; r=tbsaunde
MozReview-Commit-ID: JYD3lMmdlyc
2016-12-16 12:23:31 -07:00
Aaron Klotz fd166cbe7a Bug 1314707: Replace PDocAccessible::SendCOMProxy with new parameter to PDocAccessibleConstructor and async RecvParentCOMProxy call in child. Sending of a11y events from child to parent is now deferred until DocAccessibleChild::RecvParentCOMProxy is called; r=tbsaunde
MozReview-Commit-ID: DjxSfLJQtTu

--HG--
extra : rebase_source : d0f1ff1d22df003bc87968e1991eb08eeb977d85
2016-12-01 16:28:54 -07:00
Aaron Klotz 2c794979ff Bug 1321935: Make ProxyAccessibleBase::SetChildDoc tolerate replacing one document with another, and add a new ClearChildDoc for removing that document; r=tbsaunde
MozReview-Commit-ID: 2GgiUPf4gi0
2016-12-02 14:50:00 -07:00
Kan-Ru Chen c649cfaa98 Bug 1319271 - Use actor's manager in case actor is already deleted (r=billm)
MozReview-Commit-ID: 3Dr2POjqNft
2016-12-13 16:46:33 -08:00
Aaron Klotz d2484c8f56 Bug 1320192: Ensure that we return a null native accessible if GetWindow(GW_CHILD) on a windowed plugin fails; r=tbsaunde
MozReview-Commit-ID: 1Fe8xwS3dWc
2016-12-07 09:37:36 -10:00
Aaron Klotz 0307053bdb Bug 1321622: Make DocAccessibleParent::Unbind delegate to DocAccessibleParent::RemoveChildDoc; r=tbsaunde
MozReview-Commit-ID: 4O3xJnPDpRB
2016-12-06 10:28:48 -10:00
Aaron Klotz 3358d07564 Bug 1319640: Make obtaining of plugin IAccessible go through Chrome process on Sandboxed builds; r=tbsaunde
MozReview-Commit-ID: DQnOwJ1VpYS
2016-12-03 16:07:24 -07:00
Trevor Saunders ea6ea16d57 bug 1270916 - use accessible->IndexInParent() in DocAccessibleChildBase::ShowEvent() r=davidb
Since we will fire events in the correct order we can use the index of the
event target at the time the event is fired.  This protects from weird cases
where the target is inserted, and then children before the target are removed.
2016-11-16 23:47:01 -05:00
Wes Kocher d8a0141e5f Backed out 12 changesets (bug 1270916) for a11y crashes a=backout CLOSED TREE
Backed out changeset 916cbaf21a63 (bug 1270916)
Backed out changeset 8ee47068d1fb (bug 1270916)
Backed out changeset 60189bf08272 (bug 1270916)
Backed out changeset 5ca49b5d1c51 (bug 1270916)
Backed out changeset b8ead1b86059 (bug 1270916)
Backed out changeset 034efc9a4408 (bug 1270916)
Backed out changeset a9d6410f068e (bug 1270916)
Backed out changeset eefa622b467a (bug 1270916)
Backed out changeset 91a8f65a69fe (bug 1270916)
Backed out changeset cd68b5fd88a6 (bug 1270916)
Backed out changeset 4c58195d6bcf (bug 1270916)
Backed out changeset 8e5f19f19b7f (bug 1270916)
2016-11-16 16:16:13 -08:00
Trevor Saunders 4e7e9203c9 bug 1270916 - use accessible->IndexInParent() in DocAccessibleChildBase::ShowEvent() r=davidb
Since we will fire events in the correct order we can use the index of the
event target at the time the event is fired.  This protects from weird cases
where the target is inserted, and then children before the target are removed.
2016-11-16 18:15:23 -05:00
Kan-Ru Chen f8100451db Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Aaron Klotz 31db1f008a Bug 1315638: Modify MainThreadHandoff::FixArrayElements to be able to distinguish between outparams with different levels of indirection; r=jimm
MozReview-Commit-ID: HZgED9JT16m

--HG--
extra : rebase_source : 3b147251d55229aa5722d9f9ec6a9ad832a83c87
2016-11-07 16:04:06 -07:00
Chris Manchester 61aedfd2ef Bug 1303533 - Don't traverse accessible/ipc/win/typelib during Artifact builds. r=mshal
MozReview-Commit-ID: Clxfj8h8ZRT

--HG--
extra : rebase_source : 4d197e629b942d749e9d47fc0bf186d666140f9e
2016-11-01 22:45:35 -07:00
Michael Li fdb96b726d bug 1303447 - implement text interface methods for the windows ProxyAccessible r=aklotz 2016-10-27 18:11:55 -04:00
Michael Li 4560f258dd bug 1303133 - Implement ia2AccessibleValue methods in ProxyAccessible for Windows. r=aklotz 2016-10-27 18:11:54 -04:00
Aaron Klotz e6b863ac53 Bug 1309236: Move setting of MSAA ID to PDocAccessibleConstructor; r=tbsaunde
MozReview-Commit-ID: D5iFud9DiEh

--HG--
extra : rebase_source : d1a1ec17258e9be8023dd730593745d32a96cc0f
2016-10-27 13:16:24 -06:00
Trevor Saunders 3bee0c9b28 bug 1305402 - add new IPC messages needed for AtkTableCell interface r=davidb
To implement the interface with 1 IPC message per method we need these new
messages.
2016-10-18 13:37:25 -04:00
Aaron Klotz 22d38ae56d Bug 1308397: Fix stack overflow by ensuring that ProxyAccessible::GetCOMInterface uses its real MSAA ID to lazily resolve its COM proxy, instead of using CHILDID_SELF; r=tbsaunde
MozReview-Commit-ID: 20xdOlcCXed
2016-10-17 12:39:16 -06:00
Sebastian Hengst 4fb838d8c5 Backed out changeset 28272f824ad0 (bug 1305402) 2016-10-13 23:15:09 +02:00
Sebastian Hengst a6102946de Backed out changeset 27509f16a0f2 2016-10-13 23:15:03 +02:00
Trevor Saunders 7f873ac8c9 no bug - fixup unused value Werror bustage landed on a CLOSED TREEE 2016-10-13 17:00:15 -04:00
Trevor Saunders 743d490068 bug 1305402 - add new IPC messages needed for AtkTableCell interface r=davidb
To implement the interface with 1 IPC message per method we need these new
messages.
2016-10-13 16:18:27 -04:00
Aaron Klotz 6a79a0759a Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen
MozReview-Commit-ID: Hsmg056d6js

--HG--
extra : rebase_source : 9832e77938f112460cac075391f4f68b0adf18b8
2016-10-12 12:34:57 -06:00
Phil Ringnalda c26d9eb6e6 Backed out changeset 0257341f6b62 (bug 1301232) for WinXP permaorange in test_content_integration.html
MozReview-Commit-ID: Bz0VkhmpJL1
2016-10-11 18:42:46 -07:00
Aaron Klotz 08df7a0cf6 Bug 1301232: Re-enable jsat mochitests on Windows; r=yzen
MozReview-Commit-ID: CPIfvMDTLzv
2016-10-11 10:49:07 -06:00
Aaron Klotz a90989b900 Bug 1304449: Part 4 - Change Windows a11y MSAA id generation to partition based on content process id; r=tbsaunde
MozReview-Commit-ID: 1IBkP20uc1f

--HG--
extra : rebase_source : d0861da3419534f04f2e9de66157b8cde57c1ccd
2016-10-05 15:56:20 -06:00
Bill McCloskey f478d1188c Bug 1306708 - Rename prio to nested in IPDL (r=dvander) 2016-10-04 20:34:54 -07:00
Bill McCloskey b83db28a45 Revert "Bug 1306708 - Rename prio to nested in IPDL (r=dvander)" on a CLOSED TREE
This reverts commit b1460c626078afbb9290e7d9ecaf3af605d5e893.
2016-10-04 15:55:19 -07:00
Bill McCloskey eddd80027c Bug 1306708 - Rename prio to nested in IPDL (r=dvander) 2016-10-04 15:28:14 -07:00
Michael Li a29eef42cd Bug 1303040 - implement shared header for two ProxyAccessible classes. r=tbsaunde
MozReview-Commit-ID: 1cU71RljySc
2016-09-21 14:10:33 -04:00
Andrea Marchesini 9d38619302 Bug 1288997 - memory blob should not be shared across processes - part 3 - SendStream for memory blobs, r=bkelly 2016-09-21 12:27:26 +02:00
Aaron Klotz 6eb5eabb31 Bug 1297549: Part 1 - Use chrome-generated MSAA IDs in content; r=tbsaunde
MozReview-Commit-ID: 7YIx7f6KEOs
2016-09-19 13:58:15 -06:00
Phil Ringnalda b588bc52de Backed out changeset 5643f6aebe25 (bug 1297549) for talos bustage 2016-09-18 11:19:00 -07:00
Aaron Klotz ce64d6a91b Bug 1297549: Part 1 - Use chrome-generated MSAA IDs in content; r=tbsaunde
MozReview-Commit-ID: 7YIx7f6KEOs
2016-09-16 12:17:05 -06:00
Wes Kocher 8805e85679 Backed out 3 changesets (bug 1297549) for Windows VM Mn-e10s failures a=backout
Backed out changeset c3f82cedfb27 (bug 1297549)
Backed out changeset c643278d88c8 (bug 1297549)
Backed out changeset 3d515669d3e0 (bug 1297549)
2016-09-15 16:45:31 -07:00
Aaron Klotz 2f2f607a11 Bug 1297549: Part 1 - Use chrome-generated MSAA IDs in content; r=tbsaunde
MozReview-Commit-ID: 7YIx7f6KEOs

--HG--
extra : rebase_source : de5c26ee8857f00c45944163db5591ee24e24a2b
2016-09-15 13:25:04 -06:00
Aaron Klotz 63a3869bb8 Bug 1298412: Fix Interceptor construction to use Move semantics for STAUniquePtr instead of pass-by-reference; r=jimm
MozReview-Commit-ID: 8DzeT35Ao4O

--HG--
extra : rebase_source : 14a94903843e54c1c4a4b6c980805ed37d878911
2016-08-26 10:03:17 -06:00
Kan-Ru Chen b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Ryan VanderMeulen 30d948fc12 Bug 1297171 - Unconditionally export COMPtrTypes.h rather than depending on accessibility enabled/disabled status. r=aklotz
--HG--
extra : rebase_source : 7d55dba2cdf73defe9ed199f8734e227bac3a67c
2016-08-22 14:33:00 -04:00
Aaron Klotz a0da658cd9 Bug 1292452: Add missing ArrayData to Windows a11y e10s PlatformChild; r=tbsaunde
MozReview-Commit-ID: FgtpTFKb7JM

--HG--
extra : histedit_source : e5b7387992f5eb5500328346f9c922699569f3fd
2016-08-08 18:40:24 -06:00
Aaron Klotz 05bd3da901 Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
MozReview-Commit-ID: 4xe2T8pQ44f
2016-07-22 13:27:10 -06:00
Aaron Klotz 7debf7c239 Bug 1268544: Integrate remote COM objects into a11y code; r=tbsaunde
MozReview-Commit-ID: ctPgegQ83a
2016-08-18 09:49:13 -06:00
Aaron Klotz 6691c8cfa8 Bug 1268544: Refactor ProxyAccessible and dependencies; r=tbsaunde
MozReview-Commit-ID: EHV0JR6NmKf

--HG--
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/ProxyAccessibleBase.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/ProxyAccessibleBase.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/other/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/other/ProxyAccessible.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/win/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/win/ProxyAccessible.h
2016-08-19 13:16:42 -06:00
Aaron Klotz 1ee837c40c Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 17:14:53 -06:00
Sebastian Hengst 87b8b23d92 Backed out changeset a2b189275d7a (bug 1268544) for asserting in Windows M(oth) jobs. r=backout on a CLOSED TREE
--HG--
rename : accessible/ipc/other/DocAccessibleChild.cpp => accessible/ipc/DocAccessibleChild.cpp
rename : accessible/ipc/other/DocAccessibleChild.h => accessible/ipc/DocAccessibleChild.h
rename : accessible/ipc/win/PDocAccessible.ipdl => accessible/ipc/PDocAccessible.ipdl
2016-08-19 10:04:23 +02:00
Sebastian Hengst 8e027d975c Backed out changeset 2b4c3a792b14 (bug 1268544)
--HG--
rename : accessible/ipc/win/ProxyAccessible.cpp => accessible/ipc/ProxyAccessible.cpp
rename : accessible/ipc/win/ProxyAccessible.h => accessible/ipc/ProxyAccessible.h
2016-08-19 10:02:32 +02:00
Sebastian Hengst 5842832f4e Backed out changeset ff58e1a5f483 (bug 1268544) 2016-08-19 10:02:19 +02:00
Sebastian Hengst 2f058326f7 Backed out changeset ce6e2c41d939 (bug 1288841) 2016-08-19 10:02:15 +02:00
Sebastian Hengst 942cc5dc87 Backed out changeset 00bf09b9870a (bug 1292452) 2016-08-19 10:02:06 +02:00
Sebastian Hengst 5dc07a28e3 Backed out changeset cf746c67d0e9 (bug 1268544) 2016-08-19 10:01:47 +02:00
Aaron Klotz ce3943a9f7 Bug 1268544: Remove extra MOZ_COUNT_CTOR that should have been removed; r=bustage
MozReview-Commit-ID: 6oenmiLJE67
2016-08-18 16:13:00 -06:00
Aaron Klotz 3d79e98e6e Bug 1292452: Add missing ArrayData to Windows a11y e10s PlatformChild; r=tbsaunde
MozReview-Commit-ID: FgtpTFKb7JM
2016-08-08 18:40:24 -06:00
Aaron Klotz 8224d60f6f Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
MozReview-Commit-ID: 4xe2T8pQ44f
2016-07-22 13:27:10 -06:00
Aaron Klotz 92899f5101 Bug 1268544: Integrate remote COM objects into a11y code; r=tbsaunde
MozReview-Commit-ID: ctPgegQ83a
2016-08-18 09:49:13 -06:00
Aaron Klotz 1597663492 Bug 1268544: Refactor ProxyAccessible and dependencies; r=tbsaunde
MozReview-Commit-ID: EHV0JR6NmKf

--HG--
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/ProxyAccessibleBase.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/ProxyAccessibleBase.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/other/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/other/ProxyAccessible.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/win/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/win/ProxyAccessible.h
2016-08-18 10:45:55 -06:00
Aaron Klotz 1d9ba42f65 Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 17:14:53 -06:00
Phil Ringnalda 0d69896d44 Backed out 6 changesets (bug 1288841, bug 1268544) for causing Win7 e10s Marionette to fail in test_import_script.py TestImportScriptContent.test_imports_apply_globally
Backed out changeset c9f49a119255 (bug 1288841)
Backed out changeset a9d43e83e070 (bug 1268544)
Backed out changeset d898178a0809 (bug 1268544)
Backed out changeset 4887b4164dd9 (bug 1268544)
Backed out changeset 7c3a5a770cae (bug 1268544)
Backed out changeset 12aa15cf5879 (bug 1268544)

--HG--
rename : accessible/ipc/other/DocAccessibleChild.cpp => accessible/ipc/DocAccessibleChild.cpp
rename : accessible/ipc/other/DocAccessibleChild.h => accessible/ipc/DocAccessibleChild.h
rename : accessible/ipc/win/PDocAccessible.ipdl => accessible/ipc/PDocAccessible.ipdl
rename : accessible/ipc/win/ProxyAccessible.cpp => accessible/ipc/ProxyAccessible.cpp
rename : accessible/ipc/win/ProxyAccessible.h => accessible/ipc/ProxyAccessible.h
2016-08-18 00:30:21 -07:00
Aaron Klotz d53414c75a Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
MozReview-Commit-ID: 4xe2T8pQ44f
2016-07-22 13:27:10 -06:00
Aaron Klotz 01e4a55f10 Bug 1268544: Integrate remote COM objects into a11y code; r=tbsaunde
MozReview-Commit-ID: ctPgegQ83a
2016-08-15 14:24:12 -06:00
Aaron Klotz 494a0e9e53 Bug 1268544: Refactor ProxyAccessible and dependencies; r=tbsaunde
MozReview-Commit-ID: EHV0JR6NmKf

--HG--
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/ProxyAccessibleBase.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/ProxyAccessibleBase.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/other/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/other/ProxyAccessible.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/win/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/win/ProxyAccessible.h
2016-08-16 12:21:41 -06:00
Aaron Klotz c3a25c1ddc Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 17:14:53 -06:00
Wes Kocher 021a12c86f Backed out changesets e4a39e456f89 (bug 1268544) for mass build bustage a=backout CLOSED TREE
***
Backed out changeset 119a4b187938 (bug 1268544)
***
Backed out changeset d83cba382cfe (bug 1268544)
***
Backed out changeset a0085eb5ffe7 (bug 1268544)
***
Backed out changeset eefa457c3680 (bug 1288843)
***
Backed out changeset 17dc46beb1a5 (bug 1288841)
***
Backed out changeset e76f58f328d4 (bug 1268544)
***
Backed out changeset ffc8ee715fdb (bug 1268544)
***
Backed out changeset 99f0ea19b8f5 (bug 1268544)
***
Backed out changeset 2bdfb9514317 (bug 1268544)
***
Backed out changeset e4b3a5e1756d (bug 1268544)

--HG--
rename : accessible/ipc/other/DocAccessibleChild.cpp => accessible/ipc/DocAccessibleChild.cpp
rename : accessible/ipc/other/DocAccessibleChild.h => accessible/ipc/DocAccessibleChild.h
rename : accessible/ipc/win/PDocAccessible.ipdl => accessible/ipc/PDocAccessible.ipdl
rename : accessible/ipc/win/ProxyAccessible.cpp => accessible/ipc/ProxyAccessible.cpp
rename : accessible/ipc/win/ProxyAccessible.h => accessible/ipc/ProxyAccessible.h
extra : amend_source : dc73ec117c7279539cab36af821637bb1b0236bd
extra : histedit_source : 438ce81f07a53af61b1cabf7620f30b090e7d5e2%2Ccb6472913fe0d7d2ec66bf0cedc18f2e4d00678e
2016-08-15 15:58:45 -07:00
Aaron Klotz 61834c57ab Bug 1268544: Add missing FINAL_LIBRARY entry to accessible/ipc/other/moz.build; r=bustage a=kwierso CLOSED TREE
MozReview-Commit-ID: JKTfjrDE2GO

--HG--
extra : rebase_source : a3bd217a499ecc71cdc4161876c2bbaa744b8526
2016-08-15 16:06:57 -06:00
Aaron Klotz e1b248cac4 Bug 1268544: Followup: fix missing include in DocAccessibleChildBase; r=me
MozReview-Commit-ID: CzeTjJa9gg6

--HG--
extra : rebase_source : 93827e6cac5acf3df06147de28452293fc0befe6
2016-08-15 15:35:46 -06:00
Aaron Klotz 5dc67fdd18 Bug 1288841: Add a typelib containing info for IServiceProvider and IEnumVARIANT; r=tbsaunde, mshal
MozReview-Commit-ID: 4xe2T8pQ44f
2016-07-22 13:27:10 -06:00
Aaron Klotz 9c133fb86d Bug 1268544: Integrate remote COM objects into a11y code; r=tbsaunde
MozReview-Commit-ID: ctPgegQ83a
2016-08-15 14:24:12 -06:00
Aaron Klotz 53a0a1af6b Bug 1268544: Refactor ProxyAccessible and dependencies; r=tbsaunde
MozReview-Commit-ID: EHV0JR6NmKf

--HG--
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/ProxyAccessibleBase.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/ProxyAccessibleBase.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/other/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/other/ProxyAccessible.h
rename : accessible/ipc/ProxyAccessible.cpp => accessible/ipc/win/ProxyAccessible.cpp
rename : accessible/ipc/ProxyAccessible.h => accessible/ipc/win/ProxyAccessible.h
2016-08-04 18:28:08 -06:00
Aaron Klotz 55b28e20c7 Bug 1268544: Refactor PDocAccessible and its dependencies, and add code to integrate remote COM objects; r=tbsaunde
MozReview-Commit-ID: Fr4q3dq1ZQU

--HG--
rename : accessible/ipc/DocAccessibleChild.cpp => accessible/ipc/other/DocAccessibleChild.cpp
rename : accessible/ipc/DocAccessibleChild.h => accessible/ipc/other/DocAccessibleChild.h
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/other/PDocAccessible.ipdl
rename : accessible/ipc/moz.build => accessible/ipc/other/moz.build
rename : accessible/ipc/PDocAccessible.ipdl => accessible/ipc/win/PDocAccessible.ipdl
2016-08-15 14:24:04 -06:00
Tom Tromey 5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Michael Li 3b4d1337e7 Bug 1287145 - Support QueryInterfacing proxy accessibles to nsIAccessibleHyperText. r=tbsaunde 2016-07-18 08:23:00 +02:00
Michael Li c28fee3910 Bug 1284281 - Support QueryInterfacing proxy accessibles to nsIAccessibleHyperlink. r=tbsaunde 2016-07-07 08:13:00 +02:00
Trevor Saunders 0843a2a966 bug 1279984 - avoid invalid proxy OuterDocAccessibles r=davidb
Before binding a child document to an outer doc proxy we need to make sure its
Outer doc proxies are only allowed to have one child which is the document they
own.  So before we bind a proxied document to a proxied outer doc we need to
make sure the outer doc either doesn't have children or has a document we can
unbind.
2016-06-22 09:17:16 -04:00
Trevor Saunders ea8a901a13 bug 1272712 - send a RoleChanged message when an accessible document's role changes r=davidb 2016-06-14 12:46:21 -04:00
Jonathan Watt b15368cfcb Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Lorien Hu f5740ca0da Bug 1274195 - Invalidate children of remote mozAccessible's remote parents r=tbsaunde 2016-06-09 14:33:48 -07:00
Lorien Hu ce5ba79772 Bug 1199755 - Retrieve native proxy children when mozAccessible children is called on outerdocs in parent r=tbsaunde 2016-06-09 14:33:48 -07:00
Trevor Saunders 434092ec78 bug 1278004 - support QIing proxied accessibles to nsIAccessibleValue r=davidb 2016-06-07 14:18:08 -04:00
Trevor Saunders 0b06041a22 bug 1277959 - cleanup Interfaces enum r=davidb 2016-06-03 18:02:48 -04:00
Yura Zenevich 7d43849773 Bug 1272491 - fire xpcom show/hide events with e10s. r=tbsaunde
MozReview-Commit-ID: 9nwyHJMdlwO
2016-05-25 12:01:35 -04:00
Chris Peterson 353ee65255 Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium 2016-05-11 00:00:01 -07:00
Yura Zenevich 414632d8b4 Bug 1271776 - fire text inserted/removed instead of text change events with e10s. r=tbsaunde
MozReview-Commit-ID: hz61vYrmdK
2016-05-12 08:36:22 -04:00
Nicholas Nethercote 2511b2c327 Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.

MozReview-Commit-ID: 1VS4Dney4WX

--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
Trevor Saunders 06af77faee bug 1267376 - bail out of RecvShowEvent() early if we failed to add children r=davidb 2016-04-27 10:16:21 -04:00
Trevor Saunders 471e46a43a bug 1266518 - add a new event message for AccSelChangeEvents r=davidb
For these events atk needs to know about the widget not the event target, and
the easiest way to support that is by adding a new event message that sends the
widget id.
2016-04-25 13:38:06 -04:00
Trevor Saunders f2bc8b52ca bug 1262563 - fire show / hide events for proxied accessibles r=davidb 2016-04-21 13:41:09 -04:00
Trevor Saunders 907963ea24 bug 1262563 - add IsFromUserInput to show / hide event messages r=davidb 2016-04-21 13:41:09 -04:00
Trevor Saunders 696d088bee bug 1262233 - stop implementing ProxyAccessible::EmbeddedChildAt() with a sync message r=lsocks 2016-04-19 17:17:25 -04:00
Trevor Saunders fbb720e10a bug 1262233 - stop implementing ProxyAccessible::IndexOfEmbeddedChild() with a sync message r=lsocks 2016-04-19 17:17:25 -04:00
Trevor Saunders 426fa80158 bug 1262233 - stop using a sync message to implement ProxyAccessible::EmbeddedChildCount() r=lsocks 2016-04-19 17:17:25 -04:00
Trevor Saunders 5a44fb72ed bug 1262233 - add ProxyAccessible::IsEmbeddedObject() r=lsocks 2016-04-19 17:17:25 -04:00
Trevor Saunders d70fabf87e bug 1262980 - expose the table interface on proxies r=dbolter 2016-04-07 17:06:54 -04:00
Sebastian Hengst 589be256a0 Backed out changeset 0a9ecb630db6 (bug 1234121) for Marionette-e10s crashes on Linux in test_accessibility.py TestAccessibility.test_click_raises_no_exceptions. r=backout on a CLOSED TREE 2016-04-07 14:17:13 +02:00
Sebastian Hengst c77c3ae876 Backed out changeset 071d44d633ea (bug 1234121) 2016-04-07 14:15:41 +02:00
Lorien Hu edd5ded287 Bug 1234121 - FocusManager focused proxy cleared on hide event (Part 2) r=tbsaunde 2016-04-07 04:18:15 -07:00
Lorien Hu 4c94b38c77 Bug 1234121 - Remove sync calls for FocusedChild (Part 1) r=tbsaunde 2016-01-10 17:11:51 -08:00
Yura Zenevich 6b187e4707 Bug 1259023 - fixing invalid array index assertion when accessing next sibling. r=tbsaunde
MozReview-Commit-ID: L1zY8aEmrb
2016-04-04 16:38:15 -04:00
Trevor Saunders 37452b3a13 bug 1255009 - make AccShowEvent store the insertion index of the new child r=davidb 2016-03-28 09:09:22 -04:00
Mike Hommey 7f131dbc35 Bug 1256988 - Replace tests on MOZ_ENABLE_GTK with tests on MOZ_WIDGET_TOOLKIT containing gtk. r=chmanchester 2016-03-17 06:49:44 +09:00
Nicholas Nethercote 7cb4896c8f Bug 1255655 - Const-ify sWAIRoleMaps. r=tbsaunde.
--HG--
extra : rebase_source : 1274cdb26bbc41456e91b67849733bfb5bc89401
2016-03-11 13:13:01 +11:00
Trevor Saunders 6da1ca03eb bug 1253268 - allow getting ids of proxied accessibles r=yzen 2016-03-09 17:33:27 -05:00
Birunthan Mohanathas d7371d07d0 Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-02-02 17:36:30 +02:00
Phil Ringnalda d381b4bca6 Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
CLOSED TREE

Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas 373593275e Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj 2016-01-31 17:12:12 +02:00
Bill McCloskey c663839ade Bug 1240871 - Don't allow implicit "async" in IPDL (r=mccr8,billm) 2016-01-28 20:56:37 -08:00
Trevor Saunders d3f830df59 bug 1241453 - fire nsIAccessibleCaretMoveEvents for proxies r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders a26233525c bug 1241453 - fire nsIAccessibleEvents for proxied accessibles r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders ed69c87d2c bug 1241453 - fire nsIAccessibleTextChangeEvents for proxies r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders a512318f50 bug 1241453 - fire nsIAccessibleStateChangeEvents for proxied accessibles r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders 0be48532d2 bug 1241453 - add DocAccessibleParent::GetXPCAccessible() r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders 8f79d0d09c bug 1241453 - allow caching proxies in xpcAccessibleDocuments r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders 6b42e68369 bug 1241453 - allow caching xpc documents for remote documents r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders fe374b7271 bug 1218762 - proxy ia2Accessible::scrollTo{,Point}() r=davidb 2015-11-20 09:45:23 -05:00
Trevor Saunders 23e5f861c1 bug 1221551 - unbind child documents before rebinding them r=davidb
It seems possible that a child document could be bound to a parent document
without first being unbound.  Some evidence for this being possible is that
OuterDocAccessible::InsertChildAt() explicitly checks for this and does
something similar if it already has a child.
2015-11-06 17:29:17 -05:00
Birunthan Mohanathas 9985829ecc Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Trevor Saunders e9c2a868bb bug 1219528 - add ProxyAccessible::{Next,Prev}Sibling() and ProxyAccessible::{First,Last}Child() r=davidb 2015-10-30 19:27:42 -04:00
Trevor Saunders a6479f0c55 bug 1214864 - make SetCarretOffset() async r=davidb
It calls TakeFocus() which needs to be async to avoid deadlocks, so it needs to
be async as well.
2015-10-15 15:04:37 -04:00
Trevor Saunders 38c71db8ad bug 1213606 - assert that we don't destroy a document's proxy until we destroy all of its children r=davidb 2015-10-14 14:09:49 -04:00
Olli Pettay 42685fa873 Bug 1213382 - proxy more accessible selection methods, r=tbsaunde
--HG--
extra : rebase_source : 1d8d688d4b1ab671aed5ba28bdcc14b2c4b94f70
2015-10-13 22:08:00 +03:00
Trevor Saunders d12bfed3c9 bug 1210884 - expose the action interface on proxied accessibles r=davidb 2015-10-07 18:26:56 -04:00
Olli Pettay daf442d9cb Bug 1210407 - teach nsMaiInterfaceTable to use proxies, r=tbsaunde
--HG--
extra : rebase_source : bc80721e4fb1ff2362f556661def0ede45690220
2015-10-06 22:36:29 +03:00
Olli Pettay 010075bd3f Bug 1210408 - make nsMaiInterfaceAction work with proxies, r=tbsaunde
--HG--
extra : rebase_source : a24bf6bcded4eed0d7d7a5bf8e3a008cd299f6ae
2015-10-06 22:14:18 +03:00
Trevor Saunders c64438d7d8 bug 1210803 - expose the selection interface on proxied accessibles r=davidb 2015-10-02 06:38:21 -04:00
Trevor Saunders 533d8ecbae bug 1210447 - fix ProxyAccessible::EmbeddedChildAt() on proxies of outerDocs r=davidb 2015-10-02 06:38:21 -04:00
Frédéric Wang ecb7092186 Bug 1210441 - ProxyAccessible::IsTable* should take tabular MathML accessibles into account. r=tbsaunde 2015-10-01 11:06:00 +02:00
Trevor Saunders 5526821155 bug 1209147 - make proxying of Accessible::TakeFocus() async r=davidb
TakeFocus() ends up making sync calls to the parent process. That means if we
try to call it from a sync call to the child process we end up deadlocked.  The
easiest way to fix this is to make the message to the child process async.
2015-09-28 15:27:11 -04:00
Trevor Saunders 2672cf7d54 bug 1207862 - make it possible to traverse down the tree of proxied documents r=davidb 2015-09-24 19:23:19 -04:00
Olli Pettay 2380c07907 Bug 1207311 - No need for \!nsAccUtils::MustPrune(acc) in DocAccessibleChild::RecvExtents, r=tbsaunde
--HG--
extra : rebase_source : 89e844a308063a9e82467778a0286c0161a0ea1e
2015-09-23 01:45:27 +03:00
Trevor Saunders 258b34828c bug 1204070 - add a little more checking to proxy subtree removal r=davidb 2015-09-15 18:15:16 -04:00
Trevor Saunders cec058720c bug 1186536 - make SerializeTree() use IsOuterDoc() to check if an accessible is an outer doc r=davidb
In theory this should be the same, but slightly faster than checking there is
one child and it is a document.  However it appears ChildCount() sometimes
returns 1 when there is no child 0.
2015-09-03 18:41:19 -04:00
Olli Pettay e0121eceb5 Bug 1199785 - Make atk methods in nsMaiInterfaceComponent.cpp to work with ipc proxies, r=tbsaunde 2015-09-02 00:57:57 +03:00
Nicholas Nethercote f44287005f Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.

--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
Trevor Saunders dcf750da4b bug 1195471 - make getChildCountCB work with proxies r=davidb 2015-08-18 14:36:11 -04:00
Trevor Saunders c9ee76cab8 bug 1188415 - make CheckDocTree return if the document tree is in a sane state 2015-08-17 18:06:13 -04:00
Trevor Saunders 05e24ec361 bug 1194853 - pass the correct interfaces to Proxycreated when creating documents r=davidb 2015-08-17 13:49:28 -04:00
Lorien Hu e135c799c7 Bug 1187740 - Handle proxies in mozHTMLAccessible r=tbsaunde 2015-08-05 21:55:15 -04:00
Lorien Hu abb6b3c292 Bug 1187995 - Add proxy handling to mozTextAccessible r=tbsaunde 2015-08-05 21:55:13 -04:00
Trevor Saunders a400749fd7 bug 1191433 - use ProxyAccessible::AsDoc() in ProxyAccessible::Shutdown() r=lsocks 2015-08-05 16:14:49 -04:00
Trevor Saunders ca9181514b bug 1191433 - add ProxyAccessible::Document r=lsocks 2015-08-05 16:14:49 -04:00
Trevor Saunders 2e76a4af25 bug 1191433 - add methods to downcast ProxyAccessible to DocAccessibleParent r=lsocks 2015-08-05 16:14:49 -04:00
Trevor Saunders 0c848e2708 bug 1191326 - always initialize ProxyAccessible::mOuterDoc r=lsocks 2015-08-05 10:57:52 -04:00
Trevor Saunders b710a80b19 bug 1170049 - check if document tree is correct before cleaning it up r=lsocks 2015-08-05 10:57:28 -04:00
Lorien Hu 47968718fe Bug 1187739 - (Part 1) Handle proxies in mozActionElements r=tbsaunde 2015-08-04 14:56:18 -04:00
Lorien Hu a469201d46 Bug 1187742 - Handle proxies in mozAccessible {isEnabled,title,value,help,isExpired} r=tbsaunde 2015-08-04 14:56:17 -04:00
Lorien Hu b0fe23af9c Bug 1187609 - Check for proxies in mozAccessible role, subrole r=tbsaunde 2015-08-04 14:56:07 -04:00
Trevor Saunders 6dfa5d2acf bug 1188415 - add document tree consistancy checks to more message handlers r=davidb 2015-07-28 16:32:16 -04:00
Nicholas Nethercote b755ef234b Bug 1182969 - Use nsTHashTable::Iterator in accessible/. r=tbsaunde.
--HG--
extra : rebase_source : 548f1b49bcbfee3aca9642cdc2fa00e86dd3ee2e
2015-07-22 20:49:25 -07:00
Trevor Saunders 723cbf3c16 bug 1185157 make sure we don't send an event to a destroyed ipc document r=billm 2015-07-23 14:49:18 -04:00
Trevor Saunders 3cb7efe847 bug 1185726 - follow up to deal with -Wunused warning r=me landing on a CLOSED TREE 2015-07-21 13:39:40 -04:00
Trevor Saunders b2c4426264 bug 1185726 - avoid killing the child process when it sends the parent events with bad IDs r=lsocks 2015-07-21 12:52:18 -04:00
Trevor Saunders 730418c580 bug 1185550 - Make sure to correctly handle invalid RecvBindChildDoc and PDocAccessibleConstructor messages from the child process r=lsocks 2015-07-20 15:09:15 -04:00
Lorien Hu 99ce39504f Bug 1171995 - Part 5: Handle proxies in mozAccessible accessibilityAttributeValue r=tbsaunde 2015-07-16 17:34:52 -04:00
Lorien Hu 6f1e2f6c21 Bug 1171995 - Part 2: Add IsTable, IsTableRow, IsTableCell to proxied accessibles r=tbsaunde 2015-07-16 17:34:51 -04:00
Lorien Hu 5e32e582c2 Bug 1171995 - Part 1: Add FocusedChild to proxy accessibles r=tbsaunde 2015-07-16 17:34:51 -04:00
Trevor Saunders df6c6b58a4 bug 1184217 - check consistancy of the document tree before removing accessibles in a hide event r=davidb 2015-07-15 19:57:12 -04:00
Bill McCloskey b0e100d0db Bug 1100602 - Kill child if accessibility ID is re-used (r=trevor) 2015-07-15 14:39:26 -07:00
Trevor Saunders 59f17c9689 bug 1172523 - fire useful text change events for proxies r=lsocks 2015-07-14 11:02:03 -04:00
Lorien Hu 66a8fe1d95 Bug 1173418 - Check if a document is top level in DocAccessibleParent::Destroy so that RemoteDocShutdown isn't erroneously called r=tbsaunde 2015-06-10 14:11:34 -04:00