- Optimize integer ++ and -- to avoid double-to-int, which is quite costly for
some compilers (ftol on Windows with MSVC).
- Optimized arguments[i] and arguments.length references to use bytecodes that
avoid creating an arguments object for the current frame. This entailed
simplifying the compiler to avoid flagging functions and scripts that set
arguments, since we have code in jsfun.c to catch such sets at runtime.
- The code generator now eliminates useless expression statements, giving a
strict warning about them.
- Rationalized jsemit.c's LookupArgOrVar to have well-defined results in *pn.
- Code generation errors set report->filename and report->lineno, rather than
hacking "{0}, line {1}: " into the localized message.
- Bogus JSFRAME_VAROBJBUG removed, JSOPTION_VAROBJFIX is sufficient.
- Spruce up jsinterp.c macros to use JS_BEGIN/END_MACRO brackets if possible.
- Avoid calling JS_PropertyStub. The call is too costly compared to a branch
in the caller.
we are already done with the download. Break apart
SaveTodisk and LaunchWithTempFile into to separate
methods. never try to really open or save to disk
until we are sure we've brought up the progress window.
Bug #61947 --> pass in the initial time when we started the download via getDownloadInfo so
the progress dialog can use this information.
sr=sspitzer
within the last 18 hours: time only (12:24:34)
within the last 6 days: weekday and time (Fri 12:24)
within the last 100 days: month and day (01-19)
older than 100 days: previous behaviour (2001-01-19)
Subject:
minor Rhino bug
Date:
Tue, 23 Jan 2001 13:14:51 -0800
From:
dave russo <d-russo@ti.com>
To:
nboyd@atg.com
CC:
d-russo@ti.com
Norris,
While using the new Rhino debugger (from the latest tip) I started to get "No
Context associated with current Thread" exceptions when expanding host objects
in the "Context:" debugger window.
In looking at the code, I discovered that NativeObject.toString seems to assume
that Context.getContext() may return null. In fact, getContext() always returns
a non-null context or throws an exception.
I changed NativeObject.toString to never throw an exception (see below) and this
eliminated the problem I was seeing (of course).
It would be nice to incorporate this in a future Rhino tip or, if this change is
inappropriate, any guidance would be appreciated. Thanks in advance.
I changed NativeObject.toString to:
public String toString() {
try {
Context cx = Context.getContext();
return jsFunction_toString(cx, this, null, null);
}
catch (Exception e) {
return "[object " + getClassName() + "]";
}
}
from:
public String toString() {
Context cx = Context.getContext();
if (cx != null)
return jsFunction_toString(cx, this, null, null);
else
return "[object " + getClassName() + "]";
}
skip a lot of expensive code if we don't need to do the conversion.
this will help sorting, scrolling and message display.
there is more work to do on this code for non us-ascii users.
sr=bienvenu
brade%netscape.com
bienvenu%netscape.com
dbaron%fas.harvard.edu
sspitzer%netscape.com
brendan%mozilla.org
mscott%netscape.com
timeless%mac.com
blakeross%telocity.com
mkaply%us.ibm.com
dave%intrec.com
andreww%netscape.com
nelsonb%netscape.com
gagan%netscape.com
mcafee%netscape.com
wtc%netscape.com
beard%netscape.com
javi%netscape.com
dmose%mozilla.org
jj%netscape.com
ccarlen%netscape.com
nboyd%atg.com
Peter.VanderBeken%pandora.be
axel%pike.org
neeti%netscape.com