The button display the same icon that will be used
in the console input when in inline-mode to toggle
the editor mode, active.
A test is added to ensure the button works as expected.
Differential Revision: https://phabricator.services.mozilla.com/D38622
--HG--
rename : browser/themes/shared/icons/sidebars.svg => devtools/client/themes/images/webconsole/editor.svg
extra : moz-landing-system : lando
We have some tests which the top level document would
navigate to navigate_back.html, use history.back()
to navigate back to the top level document, and wait for
the iframes to fire a postMessage. This behavior requires
BFCache to be disabled to work correctly, otherwise BFCache
could block the code.
Differential Revision: https://phabricator.services.mozilla.com/D38520
--HG--
extra : moz-landing-system : lando
This tests triggers the problem that we ran into with bug 1565231. It
triggers the somewhat rare scenario where we update a blob and have a
new visible area.
Often changes in the visible area cause a bounds change which causes a
complete rebuild of the blob.
Differential Revision: https://phabricator.services.mozilla.com/D38550
--HG--
extra : moz-landing-system : lando
A possible explanation for the infrequent observation of an incomplete log is that
the log is still being written when the harness detects that the process has completed.
Waiting for one extra polling interval may avoid this.
Differential Revision: https://phabricator.services.mozilla.com/D38577
--HG--
extra : moz-landing-system : lando
Instead of first collecting all formatted-number field positions into
UFieldPositionIterator and then iterating over the position iterator, the new
UFormattedValue API allows direct iteration, resulting in a slight performance
improvement.
And using `ufmtval_getString` will additionally allow us to access the
underlying formatted string directly, which saves us a copy via
`unumf_resultToString`, leading to another minor performance improvement.
Differential Revision: https://phabricator.services.mozilla.com/D37698
--HG--
extra : moz-landing-system : lando
This is because of profiling and performance regressions, which we don't want
to live with while we investigate.
Differential Revision: https://phabricator.services.mozilla.com/D38645
--HG--
extra : moz-landing-system : lando
Removing the lwt aliases from the theme API schema is not going to be enough, because the images and colors properties are very permissive on the unknown properties (likely to prevent a property supported on chrome but not on firefox to prevent the theme from being installed), and so removing the lwt aliases from the schema would not raise any error (the theme API implementation would just be silently ignoring the deprecated lwt aliases).
For the above reason the following patch use the following approach:
- kept the deprecated lwt aliases in the schema, but changes the deprecation warning message to mention that the property is now completely ignored by Firefox, and which property should be used instead
- removed the deprecation warning from the toolbar_text theme colors property, as we decided that we are not going to deprecate it anymore
- changed the theme API implementation to ignore the deprecated lwt alias property
- repurposed browser_ext_themes_lwtsupport.js test file to verify that the lwt aliases are ignored as expected
A separate addons-linter pull request is going to be created, to ensure that the addons-linter will raise linting errors (instead of linting warning) when these deprecated lwt aliases are being used in a theme (to prevent that newly submitted theme versions including the aliases will go unnoticed).
Depends on D37890
Differential Revision: https://phabricator.services.mozilla.com/D37891
--HG--
extra : moz-landing-system : lando
This patch reverts the previous attempted fix for snapping issues
with picture caching, and implements a better solution.
This fixes the main visual issue by ensuring that any fractional
offset in the root transform is accounted for by:
* Offsetting the tile rects by this amount, so that the content
origin is a whole device pixel.
* Invalidating all tiles if the fractional part of the root
transform changes. This is required since it can affect the
snapping logic that WR applies. Fortunately, this occurs
very rarely - Gecko typically has a constant fractional part
for each page.
Differential Revision: https://phabricator.services.mozilla.com/D38267
--HG--
extra : moz-landing-system : lando
Not that it's causing any problem, but I noticed the build-base image
was being rebuilt when updating valgrind, and that seemed odd.
Differential Revision: https://phabricator.services.mozilla.com/D38297
--HG--
extra : moz-landing-system : lando
The preprocessed install manifest code uses a Makefile dependency file
to list inputs. If one of the inputs was missing (due to a file removal
or rename), an incremental build would fail until clobbered. We should
treat a missing input as simply being out-of-date and continue
processing.
Differential Revision: https://phabricator.services.mozilla.com/D38576
--HG--
extra : moz-landing-system : lando
David Walsh
Edwin Gao
Nicolas Chevobbe
tanhengyeow
Dão Gottwald
Paul Adenot
Sean Feng
Gurzau Raul
Erica Wright
harry
Boris Zbarsky
Jeff Muizelaar
alexandru.ionescu
Geoff Brown
André Bargull
Bob Owen
Luca Greco
sotaro
Csoregi Natalia
Narcis Beleuzu
Lee Salzman
Glenn Watson
Mike Hommey
Matthew Gregan
Oana Pop Rus
Brindusan Cristian
Emilio Cobos Álvarez
Olli Pettay
Ted Campbell
Mike Shal