Helps to determine which methods of `nsFrameSelection` are intended to
be called only for the `eNormal` Selection.
Driven by the idea that state of `nsFrameSelection` relevant only for
the `eNormal` Selection should later move to a `NormalSelection` class.
Differential Revision: https://phabricator.services.mozilla.com/D67445
--HG--
extra : moz-landing-system : lando
This is a mistake implementation of cutout support.
When OS/device doesn't support cutout (safe-area-insets-*), widget returns 0 for safe area insets values.
So if it is 0, we shouldn't set safe-area-insets.
Also, I will add test for this by bug 1622713. Actually, no Android emulator that supports notch.
Differential Revision: https://phabricator.services.mozilla.com/D67275
--HG--
extra : moz-landing-system : lando
Only 3 callers are using a non-UTF-8 charset as the first parameter.
* MediaDocument.cpp: This does not make sense because the "filename" part of
URLs will always be encoded with UTF-8.
* nsContextMenu.js: This is wrong because "mailto:" URLs don't care about the
document charset.
* Finder.jsm: This caused bug 1623222.
Differential Revision: https://phabricator.services.mozilla.com/D67386
--HG--
extra : moz-landing-system : lando
Alleviates the possibility to add calls which are unintentionally no-ops.
In practice, these errors should never be propagated to the web, and
signal to other callers (for copy&paste) that the calls are wrong.
Ideally, the other callers wouldn't see these methods, but that requires
a larger refactoring.
Differential Revision: https://phabricator.services.mozilla.com/D67327
--HG--
extra : moz-landing-system : lando
The actor indicated by 'parentFound' is no longer in use since parent intercept was enabled.
Differential Revision: https://phabricator.services.mozilla.com/D66546
--HG--
extra : moz-landing-system : lando
Add generated files to "Generated.txt" to exclude them from being linted to
avoid a "trailing whitespace" error in a comment copied over from the original
Unicode files.
Depends on D66557
Differential Revision: https://phabricator.services.mozilla.com/D66558
--HG--
extra : moz-landing-system : lando
Make the features parameter of window.open just a condition for whether to open
a popup or a new tab.
Also remove dom.disable_window_open_feature.* prefs.
Differential Revision: https://phabricator.services.mozilla.com/D65926
--HG--
extra : moz-landing-system : lando
When you type in a textarea, and zoom to position the caret, then click, we'll
scroll all the way to the top of the textarea, via:
IMEStateManager::OnClickInEditor -> SetIMEState -> SetInputContext -> mEditable->NotifyIME(EditableListener::NOTIFY_IME_OPEN_VKB);
Even if the keyboard was already displayed. In this case, we're not moving
focus, and panning to the start causes more issues than it fixes. Prevent
zooming to the start of the input in this case, but still do it if we get the
resize event (and thus toggle the keyboard).
Differential Revision: https://phabricator.services.mozilla.com/D67222
--HG--
extra : moz-landing-system : lando
When you're zoomed inside a large text-area in GeckoView, we are zooming out
right now which is very disruptive and clearly not what the code intended.
Differential Revision: https://phabricator.services.mozilla.com/D67221
--HG--
extra : moz-landing-system : lando
This refactoring:
* Removes the "avoid focusing a fixed subtree" condition, because it doesn't
make sense after bug 656036.
* Avoids keeping nsIFrame pointers across calls to ScrollContentIntoView(),
which can flush layout and thus is unsafe.
Differential Revision: https://phabricator.services.mozilla.com/D67220
--HG--
extra : moz-landing-system : lando
It was previously set on mac only due to driver mischiefs, however the cost of growing texture arrays becomes high with large layer counts, which capping the layer count to 32 everywhere helps mitigate at the expense of batch breaks.
Depends on D67368
Differential Revision: https://phabricator.services.mozilla.com/D67369
--HG--
extra : moz-landing-system : lando
Doesn't make for a stellar API but texture_cache.rs has a lot of code and I had a hard time wrapping my head around the scattered parts of picture-cache specific code.
In addition (and more importantly) texture arrays for each tile sizes can be allocated on demand and do not need to be created when initializing the texture cache. This avoids allocating and deallocating the mispredicted picture texture size when the initial window size is garbage.
Depends on D67367
Differential Revision: https://phabricator.services.mozilla.com/D67368
--HG--
extra : moz-landing-system : lando
Also make sure that the pressure factor never gets to zero.
These new constants aren't deinitive in any way though I think that they are a bit more reasonable.
Depends on D67366
Differential Revision: https://phabricator.services.mozilla.com/D67367
--HG--
extra : moz-landing-system : lando
As an initial step to reduce the reallocation churn a bit. This texture array grows up to 12 layers for any trivial page and goes up to 40+ on many sites (like the youtube front page) so it's far from enough but it's a start. Simple popups like Help > About Nightly don't need more than 4 layers, though.
Differential Revision: https://phabricator.services.mozilla.com/D67366
--HG--
extra : moz-landing-system : lando
The win64-aarch64 have a kind of a nasty trick that makes fetch-content
download artifacts of a dependent task directly as artifacts of the task
itself. For some reason, while this pattern works on native Windows
jobs, it doesn't on Linux. What happens is essentially that:
`pathlib.Path(path).joinpath('../foo').mkdir(parents=True, exist=ok=True)`
fails when path doesn't exist first. I guess the fetches directory
already exists on Windows worker or something.
Unfortunately, os.path.normpath doesn't take `pathlib.Path`s in
still-supported python 3.5, so we have to convert to str first.
Differential Revision: https://phabricator.services.mozilla.com/D66518
--HG--
extra : moz-landing-system : lando
Otherwise, the error is never visible to the build system, taskcluster,
treeherder, and, ultimately, this defeats the purpose of the check.
Differential Revision: https://phabricator.services.mozilla.com/D67414
--HG--
extra : moz-landing-system : lando
Arthur Iakab
Mirko Brodesser
meenohara
David Teller
Makoto Kato
Mihai Alexandru Michis
James Graham
Mariana Picolo
Andrei Oprea
Dave Townsend
Masatoshi Kimura
Simon Giesecke
Subhamoy Sengupta
André Bargull
Jan de Mooij
Tooru Fujisawa
Masayuki Nakano
Emilio Cobos Álvarez
Miko Mynttinen
Nicolas Silva
yulia
Mike Hommey
Martin Stransky