There's no reason for this class to be exposed to script; it'd be
awkward to use from script anyway, because the runnables script
dispatches would be running off the main thread. Thread pool listeners
likewise can't be exposed to script or implemented by script, because
they are also running off the main thread. The classinfo stuff just
seems like a relic from a bygone era.
Differential Revision: https://phabricator.services.mozilla.com/D57485
--HG--
extra : moz-landing-system : lando
In brief, this just includes two out-of-process iframes in the
tresize test page, so that when we are resizing the main window,
we will also be resizing in each of the other fission processes.
The current tresize test is registered at a chrome:// URL, so I
had to make it an http URL to have OOP http iframes, which meant
I had to adjust a bit of the framescriptery to account for this.
Differential Revision: https://phabricator.services.mozilla.com/D55572
--HG--
extra : moz-landing-system : lando
Add a document.addCertException function to about:certerror pages, and use it on the desktop certerror page.
Also, as the CallerIsTrusted* functions expect URLs like about:certerror, but GeckoView error pages are data URLs, and so need to be handled differently for these special error-page methods to be exposed on their documents.
Example usage of document.addCertException:
document.addCertException(
true|false /* true == temporary, false == permanent */
).then(
() => {
location.reload();
},
err => {
console.error(err);
}
);
Differential Revision: https://phabricator.services.mozilla.com/D56974
--HG--
extra : moz-landing-system : lando
The OS APIs used by the osclientcerts module aren't guaranteed to be
thread-safe. To deal with this, this patch introduces a dedicated thread to
perform these operations.
Differential Revision: https://phabricator.services.mozilla.com/D56465
--HG--
extra : moz-landing-system : lando
This adds a Scalar category "deletion.request" for the deletion request, it also adds a probe "impression_id" into this category.
Differential Revision: https://phabricator.services.mozilla.com/D57368
--HG--
extra : moz-landing-system : lando
`port.connectNative` is synchronous, so there is the slim possibility that a
message could be sent before the app has been notified that the port has been
created. Similarly, if the app has not attached a listener yet, the port
message gets lost.
In either case, we now store this message in a list that we check when a
delegate is attached to the port object.
Differential Revision: https://phabricator.services.mozilla.com/D57511
--HG--
extra : moz-landing-system : lando
The controller will be used in a later patch to listen to delegates updates.
Differential Revision: https://phabricator.services.mozilla.com/D57366
--HG--
extra : moz-landing-system : lando
Previously, GetCancelled() would have return true should the channel's status was an error.
Doing Cancel(NS_OK) for example, would have made a follow-up call to GetCancelled() return false. However, we can assert that such a call would have been a bug.
Following this change GetCancelled() will only return true if Cancel() was explicitly called.
Differential Revision: https://phabricator.services.mozilla.com/D55401
--HG--
extra : moz-landing-system : lando
There is no functional change with this commit. The default implementation for GetCanceled() is still to check if the status code is a failure.
However, it can be argued that as you had to call Cancel() on the nsIChannel, having to check the nsIHttpChannelInternal interface to determine if you had been canceled in the past was rather a non obvious path.
It makes more sense to check the nsIChannel interface to determine if it's been canceled already and this allows for finer granularity if needed in the future.
Differential Revision: https://phabricator.services.mozilla.com/D55268
--HG--
extra : moz-landing-system : lando
This also fixes a lifetime issue where we may have been leaking the
native instance of `WebResponse.Support`.
Differential Revision: https://phabricator.services.mozilla.com/D56994
--HG--
extra : moz-landing-system : lando
Along with this comes a new test server for use with GeckoView JUnit
tests based on AndroidAsync. This allows us to have more control
over responses and gets us off of the end-of-lifed Jetty we were using
before.
Differential Revision: https://phabricator.services.mozilla.com/D56993
--HG--
extra : moz-landing-system : lando
This removes another dead caller of nsContentUtils::SetScrollbarVisibility.
Plus, before these patches, nsContentUtils::SetScrollbarVisibility didn't
invalidate layout in any way, so it's not like it'd work, even if the chrome
code would set the preference (which it doesn't).
Differential Revision: https://phabricator.services.mozilla.com/D57185
--HG--
extra : moz-landing-system : lando
We notice we didn't write states info ControllerState correctly before because sometimes there is only one controller (right hand), it will try to access the slot 1 instead of the current available slot 0. That makes us can't see this controller is available.
Differential Revision: https://phabricator.services.mozilla.com/D56243
--HG--
extra : moz-landing-system : lando
This adds security.tls.version.enable-deprecated to DEFAULT_ENVIRONMENT_PREFS,
which should tell us how many users have re-enabled TLS 1.0/1.1 via the error
page UI.
Differential Revision: https://phabricator.services.mozilla.com/D57361
--HG--
extra : moz-landing-system : lando
There's only one test that can potentially rely on this, and still passes
with this patch:
toolkit/components/windowwatcher/test/browser_new_content_window_chromeflags.js
More to the point, this doesn't work with e10s whatsoever already, and seems
content cannot change the scrollbar visibility anymore, and chrome code doesn't
do it either.
Depends on D57182
Differential Revision: https://phabricator.services.mozilla.com/D57184
--HG--
extra : moz-landing-system : lando
Changes:
Some tests in `layout/reftests/svg/text/reftests.list` now pass unconditionally when run on ubuntu1804. Permit pixel differential value of 0 for these tests while ubuntu1604 and ubutnu1804 coexist, leave the bug open then once the migration is complete look to remove the redundant annotation.
Differential Revision: https://phabricator.services.mozilla.com/D57546
--HG--
extra : moz-landing-system : lando
Uploading texture data is showing up frequently in profiles on Adreno devices,
especially when zooming on a text-heavy page. Specifically, the time is spent in
glMapBufferRange and glBufferSubData, most likely when internally allocating the
buffer before transferring data in to it.
Currently, we are creating a new PBO, by calling glBufferData(), for each
individual upload region. This change makes it so that we calculate the required
size for all upload regions to a texture, then create single a PBO of the
required size. The entire buffer is then mapped only once, and each individual
upload chunk is written to it. This can require the driver to allocate a large
buffer, sometimes multiple megabytes in size. However, it handles this case much
better than allocating tens or even hundreds of smaller buffers.
An upload chunk may require more space in a PBO than the original CPU-side
buffer, so that the data is aligned correctly for performance or correctness
reasons. Therefore it is the caller of Device.upload_texture()'s responsibility
to call a new function, Device.required_upload_size(), to calculate the required
size beforehand.
On AMD Macs, there is a bug where PBO uploads from a non-zero offset can
fail. See bug 1603783. Therefore this patch preserves the current behaviour on
AMD Mac, reallocating a new PBO for each upload, therefore ensuring the offset
is always zero.
Differential Revision: https://phabricator.services.mozilla.com/D56382
--HG--
extra : moz-landing-system : lando
Changes:
Some tests now pass when run under `ubuntu1804` and `webrender`, so mark these as expected passes now.
Differential Revision: https://phabricator.services.mozilla.com/D57545
--HG--
extra : moz-landing-system : lando
This patch adds a new ContentSearchHandoffUI class to be used when search
handoff is enabled in the newtab page, avoiding the much more complex
ContentSearchUI. This also reduces the amount of unnecessary information being
sent across processes.
Differential Revision: https://phabricator.services.mozilla.com/D48776
--HG--
extra : moz-landing-system : lando
Changes:
Since the test in question has annotation marking it as expected failure if `webrender` and `linux` and `ubuntu1604` and the test indeed continues failing with `ubuntu1804`, mark it as an expected failure.
Differential Revision: https://phabricator.services.mozilla.com/D57513
--HG--
extra : moz-landing-system : lando
Nico Grunbaum
Andrew McCreight
Nathan Froyd
Mats Palmgren
Cosmin Sabou
Doug Thayer
Thomas Wisniewski
Dana Keeler
Nan Jiang
Noemi Erli
Agi Sferro
Jean-Yves Avenard
James Willcox
Emilio Cobos Álvarez
Daosheng Mu
Thinker Li
Glenn Watson
Tom Schuster
Gautham Velchuru
Byron Campen [:bwc]
Edwin Takahashi
Jamie Nicol
Mark Hammond
Rob Wood
Jim Porter