42e6712830
Bug 1388332 - Fix a shutdown crash when destroying image decoders before initializing its SurfacePipe. r=tnikkel
...
A default constructed SurfacePipe contains a NullSurfaceSink as its
filter in mHead. This filter does nothing and is merely a placeholder.
Since most SurfacePipe objects are constructed with the default
constructor, and NullSurfaceSink has no (modified) state, we use a
singleton to represent it. Normally the SurfacePipe owns its filter, so
it needs to do a special check for NullSurfaceSink to ensure it doesn't
free it explicitly.
A Decoder object contains a default constructed SurfacePipe until it
needs to create the first frame from an image. This is a very brief
window because it does not take very long or much data to get to this
stage of decoding.
The NullSurfaceSink singleton is freed upon shutdown, however some
ISurfaceProvider objects may be lingering after this. If their Decoder
has yet to create the first frame, that means the SurfacePipe actually
contains a dangling pointer to the already freed singleton. To make
things worse, it actually tried to free the filter because it didn't
match the singleton (it got freed!).
As such, this change removes NullSurfaceSink entirely. We never use the
SurfacePipe before initializing it with a proper filter, and it would be
considered a programming error to do so. Instead let SurfacePipe::mHead
be null, and assert that it is not null when any operations are
performed on the SurfacePipe.
2017-08-09 06:54:55 -04:00
cd8e5781d1
Back out bug 1357107 since it broke a feature that we have no automated tests for...
2017-05-05 22:41:36 -04:00
1bf467365d
Bug 1357107 - Part 1: Move the handling of the permissions.default.image pref to imgLoader.cpp; r=bzbarsky
2017-04-28 00:13:23 -04:00
4b42312a6f
Bug 1160200 - APNG can't be used with type switching. r=mcaceres, r=jrmuizel, r=johns
2016-08-09 22:15:00 +02:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
887122b9b7
Bug 1275229 - Stop using do_CreateInstance("@mozilla.org/image/loader;1") to create gecko internal imgLoader instances. r=tikkel
2016-05-19 13:31:15 +01:00
8a9e2d2bd4
Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium
2016-05-14 00:54:55 -07:00
c108701a85
Backed out changeset 68442febc36c (bug 1160200) for almost permafailing added test apng-mime/test.html Android 4.3 API15+ opt. r=backout
2016-04-23 22:33:26 +02:00
f44103a43f
Bug 1160200 - APNG can't be used with type switching. r=mcaceres,r=jrmuizel
2016-04-20 23:57:00 +02:00
b1ec50b23f
Bug 1246851 (Part 1) - Add a new SurfacePipe API for writing to image surfaces in a safe and composable manner. r=njn
2016-02-25 16:21:29 -08:00
804c890bc0
Backed out 1 changesets (bug 1160200) for causing R2 test failures
...
Backed out changeset b4f64c940524 (bug 1160200)
--HG--
extra : rebase_source : d037665348c358848b40f6b09194f58b66ce8be9
2015-09-29 11:48:53 +02:00
5c07d1ccdb
Bug 1160200 - APNG can't be used with type switching. r=mcaceres, sr=jrmuizel
...
--HG--
extra : rebase_source : ea7ff84295608a51d663fee48707bfec5a8c13e5
2015-09-25 11:36:00 +02:00
71920a9550
Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium
2015-09-22 21:39:03 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
db2ca75447
Bug 1038536 - Flatten image/src/ directory. r=seth
...
--HG--
rename : image/src/BMPFileHeaders.h => image/BMPFileHeaders.h
rename : image/src/ClippedImage.cpp => image/ClippedImage.cpp
rename : image/src/ClippedImage.h => image/ClippedImage.h
rename : image/src/DecodePool.cpp => image/DecodePool.cpp
rename : image/src/DecodePool.h => image/DecodePool.h
rename : image/src/Decoder.cpp => image/Decoder.cpp
rename : image/src/Decoder.h => image/Decoder.h
rename : image/src/Downscaler.cpp => image/Downscaler.cpp
rename : image/src/Downscaler.h => image/Downscaler.h
rename : image/src/DynamicImage.cpp => image/DynamicImage.cpp
rename : image/src/DynamicImage.h => image/DynamicImage.h
rename : image/src/FrameAnimator.cpp => image/FrameAnimator.cpp
rename : image/src/FrameAnimator.h => image/FrameAnimator.h
rename : image/src/FrozenImage.cpp => image/FrozenImage.cpp
rename : image/src/FrozenImage.h => image/FrozenImage.h
rename : image/src/ICOFileHeaders.h => image/ICOFileHeaders.h
rename : image/src/IProgressObserver.h => image/IProgressObserver.h
rename : image/src/Image.cpp => image/Image.cpp
rename : image/src/Image.h => image/Image.h
rename : image/src/ImageFactory.cpp => image/ImageFactory.cpp
rename : image/src/ImageFactory.h => image/ImageFactory.h
rename : image/src/ImageMetadata.cpp => image/ImageMetadata.cpp
rename : image/src/ImageMetadata.h => image/ImageMetadata.h
rename : image/src/ImageOps.cpp => image/ImageOps.cpp
rename : image/src/ImageOps.h => image/ImageOps.h
rename : image/src/ImageRegion.h => image/ImageRegion.h
rename : image/src/ImageURL.h => image/ImageURL.h
rename : image/src/ImageWrapper.cpp => image/ImageWrapper.cpp
rename : image/src/ImageWrapper.h => image/ImageWrapper.h
rename : image/src/MultipartImage.cpp => image/MultipartImage.cpp
rename : image/src/MultipartImage.h => image/MultipartImage.h
rename : image/src/Orientation.h => image/Orientation.h
rename : image/src/OrientedImage.cpp => image/OrientedImage.cpp
rename : image/src/OrientedImage.h => image/OrientedImage.h
rename : image/src/ProgressTracker.cpp => image/ProgressTracker.cpp
rename : image/src/ProgressTracker.h => image/ProgressTracker.h
rename : image/src/RasterImage.cpp => image/RasterImage.cpp
rename : image/src/RasterImage.h => image/RasterImage.h
rename : image/src/SVGDocumentWrapper.cpp => image/SVGDocumentWrapper.cpp
rename : image/src/SVGDocumentWrapper.h => image/SVGDocumentWrapper.h
rename : image/src/ScriptedNotificationObserver.cpp => image/ScriptedNotificationObserver.cpp
rename : image/src/ScriptedNotificationObserver.h => image/ScriptedNotificationObserver.h
rename : image/src/ShutdownTracker.cpp => image/ShutdownTracker.cpp
rename : image/src/ShutdownTracker.h => image/ShutdownTracker.h
rename : image/src/SourceBuffer.cpp => image/SourceBuffer.cpp
rename : image/src/SourceBuffer.h => image/SourceBuffer.h
rename : image/src/SurfaceCache.cpp => image/SurfaceCache.cpp
rename : image/src/SurfaceCache.h => image/SurfaceCache.h
rename : image/src/VectorImage.cpp => image/VectorImage.cpp
rename : image/src/VectorImage.h => image/VectorImage.h
rename : image/src/imgFrame.cpp => image/imgFrame.cpp
rename : image/src/imgFrame.h => image/imgFrame.h
rename : image/src/imgLoader.cpp => image/imgLoader.cpp
rename : image/src/imgLoader.h => image/imgLoader.h
rename : image/src/imgRequest.cpp => image/imgRequest.cpp
rename : image/src/imgRequest.h => image/imgRequest.h
rename : image/src/imgRequestProxy.cpp => image/imgRequestProxy.cpp
rename : image/src/imgRequestProxy.h => image/imgRequestProxy.h
rename : image/src/imgTools.cpp => image/imgTools.cpp
rename : image/src/imgTools.h => image/imgTools.h
2015-05-14 20:52:05 -07:00
e68838c027
Bug 1102048 (Part 25, header guards) - Make image/src files comply with the Mozilla Coding Style Guide. r=seth
2015-03-23 16:59:00 -07:00
bb5b07a9a3
Bug 1119158 - Retarget OnDataAvailable to a new I/O thread instead of the image decoding thread pool. r=sworkman
2015-01-18 01:27:16 -08:00
659ab90036
Bug 1104622 (Part 1) - Remove DiscardTracker. r=tn
2014-11-27 19:55:57 -08:00
3fe61f95a3
Bug 980036 - Move image prefs to gfxPrefs. r=seth
2014-09-22 17:30:20 -04:00
387301daa6
Bug 1070340 (Part 1) - Add ShutdownTracker to imagelib. r=tn
2014-09-23 15:32:16 -07:00
622bf09730
Bug 1041864 - Remove LIBRARY_NAMEs that aren't used. r=mshal
2014-07-23 08:39:56 +09:00
27df9c5c91
Bug 913138 - Shut down imagelib at the end of layout shutdown. r=bsmedberg
2014-04-08 15:51:34 -07:00
6020ff9031
Bug 937224 - Part d: Move LOCAL_INCLUDES to moz.build in image/; r=mshal
2013-11-28 15:17:27 +01:00
e06d795c71
Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps
2013-11-19 11:48:10 +09:00
e80e877ab7
Bug 939044 - Remove most definitions of MODULE. r=mshal
2013-11-19 11:47:39 +09:00
ffe0380912
Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps
2013-11-19 11:47:14 +09:00
b000a846c2
Bug 929905 - Consolidate sources in moz.build. r=gps
2013-10-25 08:23:05 +09:00
f3ffa0c710
Bug 764299 (Part 2) - Add a temporary surface cache to imagelib. r=dholbert
2013-10-22 13:37:59 +02:00
809746b013
Backout 5a0801040b54, 5bedd82346b4, 4d8068fd3271, and bc31e05eddb8 for b2g build breakage. CLOSED TREE.
2013-10-21 14:39:33 -04:00
4076d6db32
Bug 764299 (Part 2) - Add a temporary surface cache to imagelib. r=dholbert
2013-10-21 18:10:43 +02:00
f4153f40d4
Bug 900980 - Part a: Move unconditional assignments to EXPORT_LIBRARY to moz.build; rs=gps
2013-10-03 09:11:13 +02:00
e9a5dd723a
Bug 867755 - Support OnDataAvailable and OnStopRequest off main thread for image loading r=seth
2013-09-28 11:28:42 -07:00
f8bc7fa754
Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps
2013-09-05 09:01:46 +09:00
5bae25cea8
Bug 784739 - Switch from NULL to nullptr in image/. r=ehsan
2013-08-23 15:51:00 -04:00
1c4d224f0e
Bug 883284 - Part d: Move LIBXUL_LIBRARY into moz.build (f-j); r=bsmedberg
2013-08-22 08:56:00 +02:00
4807f1c86c
Bug 882859 - Part b: Move FAIL_ON_WARNINGS into moz.build; r=joey+gps
2013-08-22 08:55:59 +02:00
e62a12b52f
bug 886526 - remove IS_COMPONENT and MODULE_NAME makefile vars for things in libxul r=bsmedberg r=glandium
2013-08-08 20:12:37 -04:00
108b7dd046
backout bug 886526 because it probably made us use a lot more memory to link on windows
2013-07-29 11:03:21 -04:00
30db599e0c
Bug 882526 - Remove Gecko support for WBMP. r=joe, r=roc
2013-07-22 22:31:24 -04:00
4fda35a773
bug 886526 - disallow MODULE_NAME and IS_COMPONENT for makefiles in libxul r=bsmedberg
2013-06-25 11:15:21 -04:00
11bcc1cd9e
Bug 875934 - Move LIBRARY_NAME to moz.build (batch #1 ); r=mshal
...
--HG--
extra : rebase_source : 385d3fd65475ffc18ee44ae088753649470e214b
2013-06-17 15:21:01 -04:00
5169c0a913
Bug 864774 - Part 2: Move CPPSRCS to moz.build as CPP_SOURCES; r=joey CLOSED TREE
...
From 9e0ba7f425143f545eb6c4b26a9a96b5ade4d8e9 Mon Sep 17 00:00:00 2001
2013-04-23 17:54:15 -04:00
72a717a860
Bug 855465 - Add emacs python mode comments to moz.build files; r=gps
2013-04-01 11:36:59 -07:00
43628a7867
Backout for changeset 03452b187c14 (Bug 855465) due to bustage on a CLOSED TREE; r=qdot
2013-03-29 15:12:58 -07:00
334c0800cf
Bug 855465 - Add emacs python mode comments to moz.build files; r=gps
...
--HG--
extra : rebase_source : 004a756492323e1a049586e85b3be5037159df20
2013-03-29 13:56:18 -07:00
2f2a1387d7
Bug 582783 - Move windows.h include and undef LoadImage to gfxWindowsSurface.h. r=joe
2013-03-25 17:53:54 -04:00
5cc5056451
Bug 852053 - Support WBMP on FirefoxOS only. r=joe
2013-03-20 14:03:07 +08:00
e3efc3a646
Bug 852534 - Remove GRE_MODULE from Makefile.in; r=gps
2013-03-21 08:41:00 -07:00
7ecea60097
Bug 844654 - Part 2: Move MODULE to moz.build; rs=gps
2013-03-19 11:47:00 -07:00
e51f538dd6
Bug 847310 - WBMP decoder implementation. r=joe
2013-03-08 11:17:29 +08:00
Andrew Osmond
Ehsan Akhgari
Ehsan Akhgari
Marcos Caceres
Tom Tromey
Jonathan Watt
Chris Peterson
Sebastian Hengst
David Newton
Seth Fowler
Carsten "Tomcat" Book
Nicholas Nethercote
Birunthan Mohanathas
Glenn Randers-Pehrson
Seth Fowler
Milan Sreckovic
Mike Hommey
Bobby Holley
Ms2ger
Kannan Vijayan
Steve Workman
Trevor Saunders
Shih-Chiang Chien
Brian O'Keefe
Mike Shal
Kyle Machulis
Mina Almasry