The new API should be used everywhere:
* getSnapshotForScalars
* getSnapshotForKeyedScalars
* getSnapshotForHistograms
* getSnapshotForKeyedHistograms
Differential Revision: https://phabricator.services.mozilla.com/D12892
--HG--
extra : moz-landing-system : lando
c['desc'].splitlines()[0] raises an error because .splitlines() returns an empty list, rather than a one element list with an empty string when c['desc'] is ''. So test for c['desc'] first and then set it.
Differential Revision: https://phabricator.services.mozilla.com/D13252
--HG--
extra : moz-landing-system : lando
This fixes the assertion, though not the test-case, but now I can debug the
test-case and also land it as failing for now.
What was happening is that we had two ASRs (for the canvas and for the <body>),
and we were creating scroll data for the CompositorHitTestInfo of the <body>
(which obviously didn't have any ancestor transform) and for the
nsDisplayTransform in the backface for which HasPerspective returns true for,
but which already had an ancestor transform for the frame for which
ChildrenHavePerspective returns true.
It may be less risky to force it for both, but this doesn't make anything fail.
Differential Revision: https://phabricator.services.mozilla.com/D13242
--HG--
extra : moz-landing-system : lando
`mach artifact toolchain` gets task definitions from taskgraph, to get the
index path to find the artifacts at. Now that these index paths depend on the
digests of fetch tasks, those kinds need to be loaded as well. This adds a
supported API to get task definitions for a given kind, which loads all the
kind dependencies.
Differential Revision: https://phabricator.services.mozilla.com/D12161
--HG--
extra : moz-landing-system : lando
Depends on D13137. I could use help to write the test in a better.
I believe there is a cleaner way to create the front here?
I also had other suggestions for making the fronts more robust in the bug.
Let me know if you think I should try to investigate them more.
Differential Revision: https://phabricator.services.mozilla.com/D13138
--HG--
extra : moz-landing-system : lando
This changeset actually creates the new routes we want for decision tasks, and adds the supporting code for passing push info
in to the taskgraph.
This must land after scriptworker is updated and deployed. This has the affect of also un-hardcoding the .taskcluster.yml
fields applied in the first part of this bug.
This changeset in particular will ride trains and not be uplifted (outside of compelling reasons).
Differential Revision: https://phabricator.services.mozilla.com/D5195
--HG--
extra : moz-landing-system : lando
Previously, WebRender was getting a rectangle for reference frames
and stacking contexts, and it had to carefully treat the origin of this rectange:
- by offseting all the items in a stacking context
- by negatively compensating the sticky frame scroll port according to the
parent reference frame origin
With this change, we stop providing any non-zero origins. Instead we accomplish
the same behavior using existing API primitives, such as reference frames:
1. when a stacking context has an origin, we push another reference frame for it
2. when computing the sticky frame scroll port, we take this origin into account
This slightly simplifies Gecko-WR API, but more importantly it would allow WR to
get rid of this logic (of handling origins), which in turn would allow to switch
the reference frames from push()/pop() model to just define(), like we do for
scroll/sticky frames already.
Differential Revision: https://phabricator.services.mozilla.com/D13081
--HG--
extra : moz-landing-system : lando
All instances of nsIBrowserSearchService::currentEngine have been replaced by nsIBrowserSearchService::defaultEngine. Dropping this variable now.
Differential Revision: https://phabricator.services.mozilla.com/D12223
--HG--
extra : moz-landing-system : lando
Normally eslint handles its own file exclusions, but there are still some
globally excluded paths that |mach lint| passes in (e.g objdirs and things in
ThirdPartyPaths.txt).
This makes sure that if they show up in the 'config', we handle them.
Differential Revision: https://phabricator.services.mozilla.com/D12712
--HG--
extra : moz-landing-system : lando
Bug 1469148 added support for detecting which mouse button was used,
by synthetizing "command" events when a "click" event was captured.
The implementation did not account for unclickable menu items, such
as items that act as the parent of a submenu (see bug report),
separators and disabled menu items.
This patch adds the necessary checks and regression tests for these
scenarios to make sure that such clicks are ignored, as expected.
Differential Revision: https://phabricator.services.mozilla.com/D13084
--HG--
extra : moz-landing-system : lando
We're paying two function calls from Gecko_AddRefAtom /
Gecko_ReleaseAtom for no good reason, plus it's simple enough it's probably
worth to inline it anyway for C++ callers.
Differential Revision: https://phabricator.services.mozilla.com/D12860
--HG--
extra : moz-landing-system : lando
Add "Reason" checks in the testcase because it provides more
fine-grained check.
In this patch, I also refactor the testcase by move telemetry stuff
into head_download_manager.js so it could easily used by different testcases.
Differential Revision: https://phabricator.services.mozilla.com/D10953
--HG--
extra : moz-landing-system : lando
In this patch, we added a telemetry to record different reasons that
why download protection service decides to allow or block this download.
The |verdict| and |shouldBlock| parameters are moved inside
PendingLookup::OnComplete and now we used |Reason| in the query
reputation code path instead
Use enumerated Telemetry because it is easier to add more reasons in the
future.
Differential Revision: https://phabricator.services.mozilla.com/D10952
--HG--
extra : moz-landing-system : lando
This spewer design has two goals:
1. Provide a spew mechanism that has first-class support for slicing and
dicing output. This means that filtering by script and channel should be
the dominant output mechanism.
2. Provide a simple powerful mechanism for getting information out of the
compiler and into tools. I'm inspired by tools like CacheIR analyzer,
IR Hydra, and the upcoming tracelogger integration into perf.html.
Differential Revision: https://phabricator.services.mozilla.com/D11787
--HG--
extra : moz-landing-system : lando
Part 2 - Make old methods and fields for get/set<DataType> in `GeckoSessionSettings` private.
Migrate existing code to use these new methods instead of the exisiting get/set<DataType>(Key, Value) methods.
This commit does not tackle making the old functions inaccessible publicly as this requires a complete refactoring of the Setting @interface in `GeckoSessionTestRule.java`. There may be a follow up commit if this is something we want to do.
Make `GeckoSessionSettings` fields and get<Type> methods private.
Update `GeckoSessionTestRule` to access private fields and methods using reflection.
Differential Revision: https://phabricator.services.mozilla.com/D12435
--HG--
extra : moz-landing-system : lando
Kartikaya Gupta
Emilio Cobos Álvarez
Gabriele Svelto
Jan-Erik Rediger
Sylvestre Ledru
Brendan Dahl
Justin Wood
Tom Prince
Dão Gottwald
Shane Caraveo
Jason Laster
Narcis Beleuzu
Matthew Gaudet
John Lin
Julian Descottes
Henri Sivonen
Sebastian Hengst
Michael Ratcliffe
Florens Verschelde
Nicolas Silva
Brindusan Cristian
Dzmitry Malyshau
Siddhant085
Iain Ireland
Andrew Halberstadt
Rob Wu
dlee
WR Updater Bot
Emily Toop