8be4dec718
Removed some |scalar()|s where they were redundant, added some XXX comments, and fixed a couple of logic errors (>2 should have been >=2 and stuff like that -- this code really should use named constants)
2001-12-26 16:46:06 +00:00
a8a4ffb711
|not| implies a scalar context, so there's no need for an explicit |scalar()|
2001-12-26 16:10:17 +00:00
6a8b581138
Removed a redundant |scalar()| -- |if| implies a scalar context anyway.
2001-12-26 16:05:54 +00:00
77fac412e2
Clarified a comment.
2001-12-26 16:03:55 +00:00
5bb8ed02a5
A few minor fixes: checked for a reference being defined rather than being true (twice), replaced some double quotes with single quotes, and removed a trailing dot on a call to error().
2001-12-26 15:45:01 +00:00
a75437cefb
Removing a level 10 dump statement that was being hit a lot.
2001-12-26 15:42:21 +00:00
28afeb3cb3
Re-fixing bug 37339 - Checking an undefined variable for a specific value didn't work in Netscape 4 (and was probably a strict warning everywhere else).
...
Fix by Christian Reis <kiko@async.com.br>
r= afranke, jake
2001-12-24 22:24:35 +00:00
61a97fd94a
Bugzilla Bug 106386 rid source of these misspellings: persistant persistance priviledge protocal editting editted targetted targetting
...
r='s from many people. sr=jst
2001-12-23 23:23:41 +00:00
ef1f0d0f95
removing test-specific cgi's, we have generalized this.
2001-12-23 21:47:44 +00:00
38fe14bbd7
removing test-specific cgi, we have generalized this.
2001-12-23 21:44:37 +00:00
300f9bd37a
Nuking images that have disappeard.
2001-12-22 02:39:05 +00:00
923618312e
update
2001-12-22 02:27:53 +00:00
519403ffa5
removing a few bogus ones
2001-12-22 02:19:17 +00:00
a53ac9a976
updating from SeaMonkey tree
2001-12-22 02:14:32 +00:00
07608c5bfc
Nuking images that have disappeard. r=sleestasck
2001-12-22 01:34:46 +00:00
3151e0df6d
explain my usage of RPMS.
2001-12-21 20:10:05 +00:00
f921dbe2e9
review and clean up the instructions. Explain a bit about where to find extra
...
documentation. Explain about Makefile,Configure variables. Explain
clientbin directory, explain postfix configuration.
2001-12-21 19:45:31 +00:00
aaacb0a75e
add text browser support as a goal.
2001-12-21 19:42:02 +00:00
5b2fbb858e
erase work I have already completed.
2001-12-21 19:41:10 +00:00
258f60311e
change cgibin prefix to better default
2001-12-21 19:40:34 +00:00
4226f87493
add info about tree state and change the 'will soon' since the code works.
2001-12-21 19:39:50 +00:00
6ec7e43e84
explain all the client code. This readme had not been updated since
...
tinderbox1 days and was badly out of date.
2001-12-21 19:37:54 +00:00
0aa6b67ecf
Bug 98080 ask for an attachment number when no params are given
...
r=dkl r=justdave
2001-12-20 23:42:28 +00:00
6034436643
Bug 106470 Bonsai rview.cgi unclosed html comment tag
...
patch by pzb@datastacks.com r=justdave
2001-12-20 20:46:01 +00:00
f09cad0452
Bugzilla Bug 90598 spelling and minor syntactic correctness
...
r=zach
2001-12-20 18:31:56 +00:00
1dcd7423ca
put a <pre> arround the main build log section. This is needed for opera to render
...
the section correctly, otherwise opera shows no \n. IE and netscape render
the pages fine without it, but it is a mistake not to have it.
2001-12-20 17:19:03 +00:00
b51ee2d5ba
Adding two m.performance links
2001-12-18 07:52:18 +00:00
ae6b56d7c3
minor wording change
2001-12-17 09:35:28 +00:00
e4ba5888ef
Fix for bug 113646, midair when changing assignee gives error. Fix changes sub trim() in globals.pl not to use $_ so as not to conflict with $_ values allready
...
set.
Patch by myk@mozilla.org , r1=bbaetz, r2=dave.
2001-12-17 01:29:52 +00:00
a872073700
adding number count column
2001-12-16 20:38:57 +00:00
a8ab38a1d2
commenting main routine
2001-12-16 00:23:09 +00:00
e16af41548
Added graph size UI. Made lead UI smaller font=-1.
2001-12-16 00:06:51 +00:00
840d1c4527
Fix for bug 102487: If you had "comment on product change required" turned on in your installation, Bugzilla would warn you of
...
a forgotten comment AFTER allowing you to choose new components, versions, and milestones, forcing you to hit your back button
TWICE to correct your mistake. This checkin corrects that.
Patch by David Kilzer <ddkilzer@theracingworld.com>
r= caillon, gerv
2001-12-16 00:05:54 +00:00
04a8134ad3
Add support for size=X, X=.5, 1, etc. scales the graph size
2001-12-15 22:46:07 +00:00
98c22d2152
better html
2001-12-15 10:59:29 +00:00
aa9df2da92
adding rawdata link
2001-12-15 10:54:56 +00:00
efded144c1
better title
2001-12-15 10:52:12 +00:00
34b90fa385
cgi to print out the raw data we are plotting
2001-12-15 10:50:38 +00:00
8224222734
Add perl emacs header
2001-12-15 10:33:05 +00:00
db79537e16
whitespace nits
2001-12-15 04:13:24 +00:00
96935af74f
remove #_PH_ comments
2001-12-15 03:55:54 +00:00
b4aa7802d7
add Petr Cimprich to contributor list
2001-12-15 03:53:38 +00:00
50b81b33ca
patch from Petr Cimprich petr@gingerall.cz to allow the output to be nested in a frameset.
...
refer to parent.frames, instead of top.frames in navToGroup functions.
2001-12-15 03:09:00 +00:00
16408d486d
forgot to pass in points settings for a few urls
2001-12-15 00:55:20 +00:00
ecc086ff9b
blue points, comments
2001-12-15 00:41:01 +00:00
d7b508ac69
I can not keep up with portable /bin/echo syntax. Make /bin/echo
...
a variable and let the users figure out what they need.
2001-12-14 20:20:03 +00:00
72e72d1536
too many people ask me silly questions about the two different build states
...
both being colored yellow. Make one of them white to quiet the masses.
2001-12-14 20:19:10 +00:00
26a7e2a2bb
document new portable popup window code.
2001-12-14 20:18:13 +00:00
5174a2bb14
fixed typos in the Link() commands.
2001-12-14 20:17:34 +00:00
1bfd9cbc42
explain the mail time format.
2001-12-14 20:15:43 +00:00
ce0fdbc0bf
minor typos fixed.
2001-12-14 20:14:25 +00:00
6041493f23
typo in print statement.
2001-12-14 20:13:01 +00:00
a60ec46d66
get_all_treestates name has changed due to the conversion for text browsers.
2001-12-13 16:09:36 +00:00
dfb5cacdf3
days=n form submit was ignoring units, ltype, points.
2001-12-13 07:48:34 +00:00
a35fc54a19
splitting out separate points UI
2001-12-13 07:42:53 +00:00
1c67c0d9e0
Split points out as seperate arg
2001-12-13 07:32:40 +00:00
45cdcbdc99
Adding line style UI
2001-12-13 07:17:48 +00:00
671c7746c6
Adding ltype argument, lines, steps, or points.
2001-12-13 06:57:07 +00:00
be538729d5
pass in units too
2001-12-13 06:38:41 +00:00
4819a927a3
pass in autoscale, days for browsing urls
2001-12-13 06:32:17 +00:00
62eb0e4218
smaller font for browsing links
2001-12-13 05:37:23 +00:00
4918f5a44e
Adding machine/test browsing links
2001-12-13 05:35:12 +00:00
c409d84056
lowercase some html
2001-12-13 04:58:55 +00:00
b2eaf237ca
Adding form UI for days=n argument
2001-12-13 04:53:03 +00:00
7fe5b2878e
Adding yahoo-quote-style Y-axis control UI.
2001-12-13 02:10:16 +00:00
a51a9fbbb6
autoscale time axis. move timestamp down a little to allow for two-line time axis labels.
2001-12-13 01:56:52 +00:00
4dc9db546e
Bug 37339 and Bug 80183 - Adding a sidebar.cgi and index.cgi. The sidebar.cgi can currently be used in Mozilla/Netscape 6 and uses XUL that was originally written by Scott Collins <scc@mozilla.org>. The index.cgi displays both the proper header and footer in the appropriate places. It also changes the links accoding to if you are logged in or not.
...
r= ddk, kiko
2001-12-12 22:41:19 +00:00
d89032c7bf
Fix for bug 73502: midair collision wasn't catching other bugs changing dependencies
...
Patch by Dave Miller
r= bbaetz, jake
2001-12-11 02:38:18 +00:00
fab20109ca
Re-fix for bug 102141: The prior checkin on this bug caused an error if you could only see one product and you tried to
...
change a bug.
Fix by David Kilzer <ddk@theracingworld.com>
r= justdave, bbaetz
2001-12-09 20:21:31 +00:00
4ea66d33f2
SECURITY FIX bug 54901: If you were using LDAP authentication it would let you log in as anyone if you left the password
...
blank.
Patch by David Crowe <crow@waveset.com>
r= jmrobins, justdave
2001-12-09 15:56:23 +00:00
9f05d83eea
Adding alt text to img src tag.
2001-12-08 03:09:41 +00:00
470edd1d9e
treestate function changed names during last update to treestate class.
2001-12-07 19:30:34 +00:00
2eb27dceea
query browsing should point at query.cgi, not graph.cgi
2001-12-07 11:43:41 +00:00
b1dc9f1e4a
pass in units, we might want to hide this by default
2001-12-07 11:35:35 +00:00
261e2bd1f4
Adding title to query result
2001-12-07 11:31:10 +00:00
2ec5b81976
Solaris wants file modes for mkdir()
2001-12-07 10:20:06 +00:00
98e47592de
query wrapper for graph.cgi
2001-12-07 10:02:32 +00:00
1920fcaacd
First attempt at generalizing graph.cgi and collect.cgi
2001-12-07 09:43:54 +00:00
497e22a89b
a new portable library for popups. This library uses layers but is portable between netscape and IE (and hopefully other browsers as well).
2001-12-06 15:59:07 +00:00
988853e179
Removing a bunch of dump(10, ...) calls. It turns out that dump() is actually quite expensive, and calling it 1000+ times just to do nothing isn't that useful. In addition, most of these dump()s were used to debug the core PLIF code which now works pretty well, so they aren't that useful any more.
2001-12-04 18:06:06 +00:00
0ac4b20d8e
PLIF::Service::XML::Char() was the most expensive function in a typical profile. This takes it completely off the radar by not bothering to merge adjacent strings.
2001-12-04 17:51:23 +00:00
199ee1a91f
Changed the groupsById and groupsByName hashes of arrays into hashes of hashes to make them friendlier to handle. Also fixed some typos (groupByID instead of groupsByID, and one case of groupsByID where groupsByName was meant) and optimised away a call to dataSource.user's getGroupName method (since we already know the name).
2001-12-04 14:34:54 +00:00
a4d4cebebf
Fixing copy/paste error -- the user prefs object isn't the application object...
2001-12-04 13:40:04 +00:00
b382ef763c
Make '0' and '' be equivalent to 'default' for the 'order' attribute of the <set> element. This makes defaulting actually work (missing attributes seem to get set to ''?).
2001-12-04 13:08:39 +00:00
9868c69a29
Place a 5 second timeout on the SMTP object -- this makes running setup bearable without an SMTP server (the default timeout is 2 minutes).
2001-12-04 12:53:40 +00:00
1454dc7651
getFieldsHierarchically() will now return an even prettier result. Since it is mainly (currently only?) used for creating the data hash sent to the string expanders, this makes it a lot easier to author the templates. No silly numbers to remember. :-)
2001-12-04 12:51:48 +00:00
33e830aebd
Adjusting btek yrange hack value
2001-12-03 20:48:38 +00:00
ecb5b17c4a
empty cells need to have text brower string.
2001-12-03 20:02:39 +00:00
bc12f06bf0
minor changes in now addnote communicates with tinder.cgi. now the note
...
is rendered on an as needed basis inside tinder.cgi.
2001-12-03 19:57:35 +00:00
1f0967426d
text browser updates.
2001-12-03 19:55:56 +00:00
15567e3914
add features to allow text browsers to view status tables.
2001-12-03 19:55:12 +00:00
572164fdd0
update tests to accomidate new text browser features and conventions.
2001-12-03 19:53:31 +00:00
3c0f636f8f
add support for an ALL page.
...
fix a bunch of minor bugs and typos.
2001-12-03 19:52:38 +00:00
fe5b24cccf
add link back to the current status page from which ever status page
...
you are looking at.
2001-12-03 19:50:00 +00:00
e80777fb94
add support for text browser characters.
2001-12-03 19:48:47 +00:00
2c1da9b53c
generalize treestate so that we can provide data to text browsers.
2001-12-03 19:47:24 +00:00
1033dd75d6
add support for an ALL page.
2001-12-03 19:46:04 +00:00
28b599eab9
add support for text browsers: colorized characters which discribe the build
...
cell state. Also allow users to chose the brief/full log from the
status page.
2001-12-03 19:44:26 +00:00
22ecd64fd0
add support for text browsers including, special colorized characters
...
and click through text of notices.
2001-12-03 19:43:28 +00:00
32d632c2c6
add support for text browsers.
2001-12-03 19:42:45 +00:00
813da6c87b
removing jrgm's version of &days=, Date::Calc version is working.
2001-12-03 09:07:16 +00:00
c649101a71
Adding &days=n argument.
2001-12-03 08:56:28 +00:00
0963eca175
Adding &days=n argument. Left in jrgm's attempt as a comment for now.
2001-12-03 08:40:42 +00:00
6614130b91
Adding &days=n argument. Needs Bit::Vector and Date::Calc perl modules.
2001-12-03 08:11:15 +00:00
d6812466c3
Added &autoscale=1 option, default is still the btek hack [1300:1400]
2001-12-02 21:54:25 +00:00
44e080573b
First commit.
2001-12-02 21:50:59 +00:00
4c2f1c910d
Ignore db directory
2001-12-02 21:31:30 +00:00
6df2649904
Added &autoscale=1 option to autoscale y-axis.
2001-12-02 21:30:31 +00:00
09282c5818
Fixed a bug in the main run loop whereby the objects array wasn't freed until shutdown, which sometimes meant objects got destroyed after the application, which is bad when the objects use the application to find services, etc. (This doesn't happen with services since services are not allowed to store references to the application, either directly or indirectly through references to objects or service instances.) Fixed the logout code to wait until the user tries to do something that requires login before clearing the logging out flag. This fixes a bug with HTTP whereby if a user logged out then his UA wouldn't ever be sent a 401 so wouldn't ever lose the authentication info, because browsers send the authentication info regardless of whether a page needs it or not. Also took the opportunity to remove a potential bug in the input validator code: store the admin message instead of a reference to the user object which might end up with a lifetime longer than expected.
2001-12-01 04:37:26 +00:00
ac14fa1708
Removed an outdated comment. It is now safe to have a single module be a service, one or more service instances, and one or more objects all at the same time.
2001-12-01 04:29:20 +00:00
7ec6984494
Add support for keyed channels to mozbot. A lot of work, like it said in the INSTALL file. :-) b=112955 r=timeless
2001-11-30 23:38:21 +00:00
8429b5989b
Get the file list of files to scan for templates from Support::Files instead of glob('*')
2001-11-30 21:49:47 +00:00
79c1860606
Made all dependencies load their modules on demand rather than on startup (cuts down the page serving time by about 50%). Also removed some debugging statements in certain high profile areas.
2001-11-30 20:48:36 +00:00
050ad60758
Added support for easily getting the original key name of a munged key: added a virtual '.coses: original key' entry to all hashes in COSES (works similar to the virtual '.length' item that all arrays have). Edited the debug string to mention these virtual items.
2001-11-30 16:20:22 +00:00
389c6783a8
Fixing an inconsistency between getArgument() and peekArgument(). peekArgument() now returns an empty list in an array context if there is no such argument, instead of undef. This makes it act like getArgument(), which just returns the list of values in an array context. Similarly, made the default implementation of peekArgument() whine about not being implemented instead of returning undef, since by design peekArgument() should return the same as getArgument() if the argument is present.
2001-11-30 16:13:00 +00:00
d7607585fc
Adding error handling for the case where the user prefs editor is called with bogus user IDs.
2001-11-30 16:06:45 +00:00
004b78a163
Implemented logout and explicit new account creation in the login service. Had to add removeObject() to the Controller module (the opposite of the exisiting addObject()).
2001-11-30 13:31:29 +00:00
6da5b9485f
close the file to get it to write to disk
2001-11-30 08:41:27 +00:00
1305df405a
match changes from startup test.
2001-11-30 08:38:05 +00:00
93dce4750e
better error message when no data file is found.
2001-11-30 08:32:53 +00:00
37703a0ee2
try to fix error-on-first-report
2001-11-30 07:57:19 +00:00
2d4846374f
avg -> value
2001-11-30 05:53:01 +00:00
ba13aea768
switching avg to value
2001-11-30 05:49:19 +00:00
906e56e46d
Fixing Y axis label
2001-11-30 05:44:07 +00:00
d29e4da38d
First add. Clone of startup cgis. plans to make this a general graph cgi are in the wings, this is a temporary get-this-going hack
2001-11-30 04:51:04 +00:00
d0f1adf983
Minor fixes to make the previous checkin actually compile...
2001-11-29 20:23:48 +00:00
ae996eb3e1
* Corrected some inaccurate comments I came across.
...
* Added support for group membership levels (now you can be a normal member, as before, but also a group op or a group admin) -- this affected the user data source, the mysql data source, and the user service.
* Added a getFieldsHierarchically() method to the user data source.
* Added a getFieldsByCategory() method to the user data source.
* Fixed a typo in some of the SQL in the rights management part of the MySQL user data source.
* Added support in the arguments input module for treating the arguments as dot-delimited trees and returning a specific branch.
* Added support in the passwords service for encrypting a specific password.
* Added a getFieldByID() method to the user service.
* Made the groups in the user service be indexed by both ID and Name.
* Implemented the user preferences component.
2001-11-29 18:03:38 +00:00
c7e781a010
Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
...
r=louie, myk
2001-11-27 15:04:52 +00:00
bc46b41785
Solaris needs LD_LIBRARY_PATH help for /usr/local/lib
2001-11-27 05:01:47 +00:00
ce346ab569
Find gnuplot
2001-11-27 04:43:32 +00:00
fc6c963c9d
First add. code=jrgm, modified by mcafee
2001-11-27 02:26:48 +00:00
ce89f9a71b
minor html fix
2001-11-27 02:19:00 +00:00
1e969d3f91
Fix for bug 109802: Make it clear how to enter mysql passwords with special characters into localconfig.
...
Patch by Dave Miller <justdave@syndicomm.com>.
r=ddkilzer,louie.
2001-11-27 00:49:26 +00:00
7cf8c8c8a5
Fix for bug 101875: Put the product column before the component column rather than after.
...
Patch by Paul Baker <pbaker@where2getit.com>.
Low risk, r=myk, no second review needed.
2001-11-26 23:29:29 +00:00
a325f27a1b
Bug 109530 - xml.cgi was quoting stuff way too much. This is because it was incorrectly quoted in Bug.pm
...
r= justdave, louie
2001-11-26 14:16:10 +00:00
51a4520c4a
Bugzilla Bug 107823 change nsIFile
...
to use 'Modified' instead of 'Modification'
r=akkana sr=brendan
2001-11-26 08:05:05 +00:00
ae454984a5
mkdir requires the second argument in perl 5.005. b=111730, r=daniele
2001-11-25 14:17:19 +00:00
cbd99231b2
Mozbot shipped with a broken default bugsDWIMQueryDefault -- made the code more consistent. b=93203, r=timeless
2001-11-25 13:59:53 +00:00
ad706350b0
oops, stray dot meant the private karma scores were getting corrupted! r=kerz
2001-11-25 01:25:27 +00:00
9e4bc32d9a
Initial checkin of a karma module. r=kerz b=111757
2001-11-25 01:01:35 +00:00
c07181231b
Changing 'will soon be available as an open source resource' to 'is available as an open source resource'
2001-11-23 16:50:57 +00:00
002b60fd9c
work in progress: a component that provides a way for users and admins to edit user preferences, settings, contact details, password, etc.
2001-11-23 00:16:44 +00:00
d84431bbb0
changing the argument names from the cosesEditorXYZ form to the cosesEditor.x.y.z form. This will make them more consistent with how things work elsewhere in PLIF.
2001-11-22 20:15:45 +00:00
ee423a9430
* Created service- and serviceInstance- specific constructors so that a single module can have distinct constructors depending on how it is invoked. These constructors are called serviceInit() and serviceInstanceInit(), and both chain to the existing init() constructor (so no change are required by this).
...
* Changed FileStrings so that it doesn't have to be updated every time the file string format changes. The format is now one line per piece of metadata, then a blank line, then the string data. If additional metadata is added later then this will automatically support it.
* Renamed the dataSource.strings service to dataSource.strings.customised, and renamed its get() method to getCustomisedString().
* Changed the semantics of dataSource.strings.customised so that it no longer looks for a default string if it can't find a customised one (and thus removed getDefaultString).
* Abstracted the Generic output module even more. It now consists of output.generic (a service instance with its own constructor) and dataSource.strings (a pure service), the latter of which is a wrapper around dataSource.strings.customised and dataSource.strings.defaults.
* Updated Coses to work with the new dataSource.strings insterface.
* Removed the test app DataSource::ConsoleStrings and DataSource::HTTPStrings files, since they were redundant with the default output files.
* Removed all the default strings in the CosesEditor and Login components since they are pretty pointless.
* Factored out the call to dump() in the GenericOutputs module.
* Changed setString in the MySQL string data source so that it will now add a blank string (it used to delete the string if it was blank, but that meant that it was not possible to customise strings away).
* Added a piece of metadata to strings: their version number.
* Updated the customised string data source stubs to mention the version data now stored with all strings
* Added a getAllStringVersions method to the customised strings data source which returns all the string names and their version numbers.
* Made the customised strings data source check the version number of every string in its database during setupInstall to make sure that they are all up to date, version-wise. If any are out of date, the user is notified.
* Added support for the new version column to the MySQL version of the customised string data source.
* Updated the increasingly misnamed CosesEditor to support the versioned strings stuff.
* Factored out some code in the CosesEditor.
* Added version information to all default strings. All default strings are now at version 1.
* Fixed a typo in a FileStrings dump statement.
* Fixed the calls to setProgress in the MySQL user and strings data sources and in the user field factory to use the correct syntax (a parsable dotted string instead of unlocalisable plain English).
* Updated the Generic output module's documentation to match what now happens.
2001-11-22 15:46:42 +00:00
61d6d30534
Fix for bug 61634: explain what "Milestone URL" is on the editproducts page.
...
patch by Matthew Tuck <matty@chariot.net.au>
r= caillon, justdave
2001-11-22 15:46:27 +00:00
807c799353
Bug 104261 - incorrect template paths. r=myk, ddk.
2001-11-22 06:12:36 +00:00
cc5c2ee269
Fix for bug 99864: consistant use of "product" vs "program"
...
Patch by Josh Soref <timeless@mac.com>
r= dkl, justdave
2001-11-21 19:56:28 +00:00
57a399e8a8
Bugzilla Bug 93754�describe should be #directable
...
r=justdave,dkl
2001-11-21 16:44:38 +00:00
703571611f
Fix for bug 102141: SECURITY FIX - the Product popup menu on the show_bug form listed all products, even if the user didn't
...
have access to all of them. It now only shows products the user has access to (and the product the bug is in, if the user is
viewing it because of some other override)
Patch by George Hotelling <george.hotelling@iconideas.com> and Dave Miller <justdave@syndicomm.com>
r= bbaetz, caillon
2001-11-21 08:30:47 +00:00
ab62630688
Bug 110276:SQL error in globals.pl.
...
Patch by me, r=bbaetz,caillon.
2001-11-21 08:09:32 +00:00
ian%hixie.ch
jake%acutex.net
timeless%mac.com
mcafee%netscape.com
sfraser%netscape.com
kestes%walrus.com
zach%zachlipton.com
justdave%syndicomm.com
rginda%netscape.com
myk%mozilla.org
gerv%gerv.net
matty%chariot.net.au