813da6c87b
removing jrgm's version of &days=, Date::Calc version is working.
2001-12-03 09:07:16 +00:00
c649101a71
Adding &days=n argument.
2001-12-03 08:56:28 +00:00
0963eca175
Adding &days=n argument. Left in jrgm's attempt as a comment for now.
2001-12-03 08:40:42 +00:00
6614130b91
Adding &days=n argument. Needs Bit::Vector and Date::Calc perl modules.
2001-12-03 08:11:15 +00:00
d6812466c3
Added &autoscale=1 option, default is still the btek hack [1300:1400]
2001-12-02 21:54:25 +00:00
44e080573b
First commit.
2001-12-02 21:50:59 +00:00
4c2f1c910d
Ignore db directory
2001-12-02 21:31:30 +00:00
6df2649904
Added &autoscale=1 option to autoscale y-axis.
2001-12-02 21:30:31 +00:00
09282c5818
Fixed a bug in the main run loop whereby the objects array wasn't freed until shutdown, which sometimes meant objects got destroyed after the application, which is bad when the objects use the application to find services, etc. (This doesn't happen with services since services are not allowed to store references to the application, either directly or indirectly through references to objects or service instances.) Fixed the logout code to wait until the user tries to do something that requires login before clearing the logging out flag. This fixes a bug with HTTP whereby if a user logged out then his UA wouldn't ever be sent a 401 so wouldn't ever lose the authentication info, because browsers send the authentication info regardless of whether a page needs it or not. Also took the opportunity to remove a potential bug in the input validator code: store the admin message instead of a reference to the user object which might end up with a lifetime longer than expected.
2001-12-01 04:37:26 +00:00
ac14fa1708
Removed an outdated comment. It is now safe to have a single module be a service, one or more service instances, and one or more objects all at the same time.
2001-12-01 04:29:20 +00:00
7ec6984494
Add support for keyed channels to mozbot. A lot of work, like it said in the INSTALL file. :-) b=112955 r=timeless
2001-11-30 23:38:21 +00:00
8429b5989b
Get the file list of files to scan for templates from Support::Files instead of glob('*')
2001-11-30 21:49:47 +00:00
79c1860606
Made all dependencies load their modules on demand rather than on startup (cuts down the page serving time by about 50%). Also removed some debugging statements in certain high profile areas.
2001-11-30 20:48:36 +00:00
050ad60758
Added support for easily getting the original key name of a munged key: added a virtual '.coses: original key' entry to all hashes in COSES (works similar to the virtual '.length' item that all arrays have). Edited the debug string to mention these virtual items.
2001-11-30 16:20:22 +00:00
389c6783a8
Fixing an inconsistency between getArgument() and peekArgument(). peekArgument() now returns an empty list in an array context if there is no such argument, instead of undef. This makes it act like getArgument(), which just returns the list of values in an array context. Similarly, made the default implementation of peekArgument() whine about not being implemented instead of returning undef, since by design peekArgument() should return the same as getArgument() if the argument is present.
2001-11-30 16:13:00 +00:00
d7607585fc
Adding error handling for the case where the user prefs editor is called with bogus user IDs.
2001-11-30 16:06:45 +00:00
004b78a163
Implemented logout and explicit new account creation in the login service. Had to add removeObject() to the Controller module (the opposite of the exisiting addObject()).
2001-11-30 13:31:29 +00:00
6da5b9485f
close the file to get it to write to disk
2001-11-30 08:41:27 +00:00
1305df405a
match changes from startup test.
2001-11-30 08:38:05 +00:00
93dce4750e
better error message when no data file is found.
2001-11-30 08:32:53 +00:00
37703a0ee2
try to fix error-on-first-report
2001-11-30 07:57:19 +00:00
2d4846374f
avg -> value
2001-11-30 05:53:01 +00:00
ba13aea768
switching avg to value
2001-11-30 05:49:19 +00:00
906e56e46d
Fixing Y axis label
2001-11-30 05:44:07 +00:00
d29e4da38d
First add. Clone of startup cgis. plans to make this a general graph cgi are in the wings, this is a temporary get-this-going hack
2001-11-30 04:51:04 +00:00
d0f1adf983
Minor fixes to make the previous checkin actually compile...
2001-11-29 20:23:48 +00:00
ae996eb3e1
* Corrected some inaccurate comments I came across.
...
* Added support for group membership levels (now you can be a normal member, as before, but also a group op or a group admin) -- this affected the user data source, the mysql data source, and the user service.
* Added a getFieldsHierarchically() method to the user data source.
* Added a getFieldsByCategory() method to the user data source.
* Fixed a typo in some of the SQL in the rights management part of the MySQL user data source.
* Added support in the arguments input module for treating the arguments as dot-delimited trees and returning a specific branch.
* Added support in the passwords service for encrypting a specific password.
* Added a getFieldByID() method to the user service.
* Made the groups in the user service be indexed by both ID and Name.
* Implemented the user preferences component.
2001-11-29 18:03:38 +00:00
c7e781a010
Bug 108312 - The mid-air collision page was only showing the most recent changes if two people comitted changes to a bug while you were viewing it.
...
r=louie, myk
2001-11-27 15:04:52 +00:00
bc46b41785
Solaris needs LD_LIBRARY_PATH help for /usr/local/lib
2001-11-27 05:01:47 +00:00
ce346ab569
Find gnuplot
2001-11-27 04:43:32 +00:00
fc6c963c9d
First add. code=jrgm, modified by mcafee
2001-11-27 02:26:48 +00:00
ce89f9a71b
minor html fix
2001-11-27 02:19:00 +00:00
1e969d3f91
Fix for bug 109802: Make it clear how to enter mysql passwords with special characters into localconfig.
...
Patch by Dave Miller <justdave@syndicomm.com>.
r=ddkilzer,louie.
2001-11-27 00:49:26 +00:00
7cf8c8c8a5
Fix for bug 101875: Put the product column before the component column rather than after.
...
Patch by Paul Baker <pbaker@where2getit.com>.
Low risk, r=myk, no second review needed.
2001-11-26 23:29:29 +00:00
a325f27a1b
Bug 109530 - xml.cgi was quoting stuff way too much. This is because it was incorrectly quoted in Bug.pm
...
r= justdave, louie
2001-11-26 14:16:10 +00:00
51a4520c4a
Bugzilla Bug 107823 change nsIFile
...
to use 'Modified' instead of 'Modification'
r=akkana sr=brendan
2001-11-26 08:05:05 +00:00
ae454984a5
mkdir requires the second argument in perl 5.005. b=111730, r=daniele
2001-11-25 14:17:19 +00:00
cbd99231b2
Mozbot shipped with a broken default bugsDWIMQueryDefault -- made the code more consistent. b=93203, r=timeless
2001-11-25 13:59:53 +00:00
ad706350b0
oops, stray dot meant the private karma scores were getting corrupted! r=kerz
2001-11-25 01:25:27 +00:00
9e4bc32d9a
Initial checkin of a karma module. r=kerz b=111757
2001-11-25 01:01:35 +00:00
c07181231b
Changing 'will soon be available as an open source resource' to 'is available as an open source resource'
2001-11-23 16:50:57 +00:00
002b60fd9c
work in progress: a component that provides a way for users and admins to edit user preferences, settings, contact details, password, etc.
2001-11-23 00:16:44 +00:00
d84431bbb0
changing the argument names from the cosesEditorXYZ form to the cosesEditor.x.y.z form. This will make them more consistent with how things work elsewhere in PLIF.
2001-11-22 20:15:45 +00:00
ee423a9430
* Created service- and serviceInstance- specific constructors so that a single module can have distinct constructors depending on how it is invoked. These constructors are called serviceInit() and serviceInstanceInit(), and both chain to the existing init() constructor (so no change are required by this).
...
* Changed FileStrings so that it doesn't have to be updated every time the file string format changes. The format is now one line per piece of metadata, then a blank line, then the string data. If additional metadata is added later then this will automatically support it.
* Renamed the dataSource.strings service to dataSource.strings.customised, and renamed its get() method to getCustomisedString().
* Changed the semantics of dataSource.strings.customised so that it no longer looks for a default string if it can't find a customised one (and thus removed getDefaultString).
* Abstracted the Generic output module even more. It now consists of output.generic (a service instance with its own constructor) and dataSource.strings (a pure service), the latter of which is a wrapper around dataSource.strings.customised and dataSource.strings.defaults.
* Updated Coses to work with the new dataSource.strings insterface.
* Removed the test app DataSource::ConsoleStrings and DataSource::HTTPStrings files, since they were redundant with the default output files.
* Removed all the default strings in the CosesEditor and Login components since they are pretty pointless.
* Factored out the call to dump() in the GenericOutputs module.
* Changed setString in the MySQL string data source so that it will now add a blank string (it used to delete the string if it was blank, but that meant that it was not possible to customise strings away).
* Added a piece of metadata to strings: their version number.
* Updated the customised string data source stubs to mention the version data now stored with all strings
* Added a getAllStringVersions method to the customised strings data source which returns all the string names and their version numbers.
* Made the customised strings data source check the version number of every string in its database during setupInstall to make sure that they are all up to date, version-wise. If any are out of date, the user is notified.
* Added support for the new version column to the MySQL version of the customised string data source.
* Updated the increasingly misnamed CosesEditor to support the versioned strings stuff.
* Factored out some code in the CosesEditor.
* Added version information to all default strings. All default strings are now at version 1.
* Fixed a typo in a FileStrings dump statement.
* Fixed the calls to setProgress in the MySQL user and strings data sources and in the user field factory to use the correct syntax (a parsable dotted string instead of unlocalisable plain English).
* Updated the Generic output module's documentation to match what now happens.
2001-11-22 15:46:42 +00:00
61d6d30534
Fix for bug 61634: explain what "Milestone URL" is on the editproducts page.
...
patch by Matthew Tuck <matty@chariot.net.au>
r= caillon, justdave
2001-11-22 15:46:27 +00:00
807c799353
Bug 104261 - incorrect template paths. r=myk, ddk.
2001-11-22 06:12:36 +00:00
cc5c2ee269
Fix for bug 99864: consistant use of "product" vs "program"
...
Patch by Josh Soref <timeless@mac.com>
r= dkl, justdave
2001-11-21 19:56:28 +00:00
57a399e8a8
Bugzilla Bug 93754�describe should be #directable
...
r=justdave,dkl
2001-11-21 16:44:38 +00:00
703571611f
Fix for bug 102141: SECURITY FIX - the Product popup menu on the show_bug form listed all products, even if the user didn't
...
have access to all of them. It now only shows products the user has access to (and the product the bug is in, if the user is
viewing it because of some other override)
Patch by George Hotelling <george.hotelling@iconideas.com> and Dave Miller <justdave@syndicomm.com>
r= bbaetz, caillon
2001-11-21 08:30:47 +00:00
ab62630688
Bug 110276:SQL error in globals.pl.
...
Patch by me, r=bbaetz,caillon.
2001-11-21 08:09:32 +00:00
00b81c656f
Added blurb about unified diffs.
2001-11-20 20:16:24 +00:00
6230b92d8f
Taint mode note.
2001-11-20 20:11:41 +00:00
3aa7a50cfc
Added Javascript, Cookies, and Templatization requirements to Hacking
...
Bugzilla.
2001-11-20 20:09:06 +00:00
e999d8db14
Added tip about checking sanitycheck.cgi if you make schema changes,
...
per bug 98049.
2001-11-20 19:56:31 +00:00
4184f599d2
Removed references to bugzilla.mozilla.org so we can avoid
...
spurious bug postings. However, this file will need some significant
treatment for 2.16 release since the query.cgi interface has changed.
2001-11-20 18:22:30 +00:00
42c9eb0def
Backing out previous checkin, this file is distributed with Bugzilla, we don't need mozilla-specific information in it.
2001-11-20 18:11:05 +00:00
7c59b3446c
Added one liner mentioning that mozilla.org provides only one vote
...
per bug.
2001-11-20 17:46:14 +00:00
bdacf2d95f
Modified Win32 notes regarding system() calls per bug 99595.
2001-11-20 17:26:45 +00:00
13f86e9939
Fixed CPAN locations per bug 97582.
2001-11-20 17:18:03 +00:00
5e4bff4b25
Added bit about needing proper <Directory> permissions in order
...
for .htaccess to function. See bug 97668.
2001-11-20 17:09:38 +00:00
c5f0502819
Changed openjade compilation instructions to match new commands
...
required by XML conversion of the Guide.
2001-11-20 16:41:23 +00:00
7d4973fb0c
Initial conversion to XML format from SGML.
...
Note this is a work-in-progress. It compiles cleanly, but I am not yet
submitting compiled HTML and text.
There is one notable problem: nsgmls barfs on the <imagedata> tag in
database.sgml during validation. openjade handles it fine. Weird.
2001-11-20 16:36:28 +00:00
bab6081aff
Removing server-side pageloader data reporting, use client-side scrape mechanism
2001-11-20 06:30:18 +00:00
1e3f91e6a2
Remove server-side data reporting for pageloader test, use client-based scrape mechanism now.
2001-11-20 06:27:33 +00:00
10ba12205e
bloat.pl not needed, use scrape.pl
2001-11-20 05:42:46 +00:00
03914cf282
Removing old bloat data reporting stuff, use scrape reporting now.
2001-11-20 05:27:29 +00:00
3ede41a072
no more startup.dat
2001-11-20 03:50:25 +00:00
99a449b9be
startup.pl should use scrape.pl mechanism now.
2001-11-20 03:47:05 +00:00
3ab251b448
startup data goes to scrapt.dat now.
2001-11-20 03:43:27 +00:00
f7e7d5aeff
Fix for bug 109240: fixes the regression that changed the way comments regarding attachment creation are formatted.
...
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org , no second review needed.
2001-11-20 02:59:55 +00:00
e9d0d81126
Fix for bug 107120, templates/default/global/header has invalid HTML.
...
Patch removes a <meta> tag as per bug 38856.
Patch by David D. Kilzer <mailto:ddkilzer@theracingworld.com>.
r1=Christopher Aillon <mailto:caillon@returnzero.com>. No 2nd review
required as per caillon.
2001-11-20 01:59:57 +00:00
37c09d1017
Bug 98707. Query.cgi rewrite. Patch by me, layout by mpt and others, r=justdave, mattyt. Wahey!
2001-11-18 22:23:31 +00:00
86418ea974
Bug 98707. Query.cgi rewrite, reformatting and templatisation. Patch by me, layout by mpt and others, r=justdave,matty. Wahey!
2001-11-18 22:20:20 +00:00
677692909a
Moving a comment to the right place, in order to be able to make a comment about my previous check in that accidentally got checked in without a comment, and hence didn't show up on Tinderbox I think.
...
It was a change to CGI.pl, a fix for bug 105812: Rename "Components" link in sub GetCommandMenu() to "Products".
The patch was by James A Laska <jlaska@us.ibm.com>.
2001-11-18 03:54:54 +00:00
fb8ca6d4cd
*** empty log message ***
2001-11-18 03:22:50 +00:00
14122fd43e
Fix for bug 100788: enter_bug.cgi wasn't correctly interpretting whether or not a partial URL needed an http:// added to the
...
front of it, which had the side-effect of duplicating the http:// on the front when a URL was passed from Bugzilla Helper.
Patch by Josh Soref <timeless@mac.com>
r= justdave, caillon
2001-11-17 23:05:48 +00:00
bc2ba9abf9
Fix for bug 109354: After entering a new bug, the link offering to add an attachment to the bug you just created pointed at
...
the old attachment form instead of the new one.
Patch by Josh Soref <timeless@mac.com>
r= myk x2
2001-11-17 22:40:02 +00:00
7e069b138f
Fix for bug 107120: templates/default/global/header was generating HTML that wouldn't validate as HTML 4.01 Transitional
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake, bbaetz
2001-11-17 22:25:15 +00:00
a66257c75e
Fix for bug 92500: line-feeds were not being properly converted when submitting parameter changes with some Mac browsers.
...
Patch by Gervase Markham <gerv@mozilla.org>
r= ddk, justdave
2001-11-17 22:18:07 +00:00
5a3a1fe26f
Backing out previous checkin, it broke the tree. :(
2001-11-17 21:28:24 +00:00
5828cbd866
Fix for bug 102487: If admin has set preferences to require a comment on a product/component change, prompt the user that they
...
forgot to comment first, before prompting for component, milestone, and version for new product.
Patch by Garvase Markham <gerv@mozilla.org>
r= kiko, ddk
2001-11-17 21:12:53 +00:00
c510bfa682
Fix for bug 12284: allow user to specify which columns to display in a bug list
...
Patch by Andreas Franke <afranke@ags.uni-sb.de>
r= gerv, kiko
2001-11-17 21:04:37 +00:00
c1593016d6
Correct some XML errors in the default output strings.
2001-11-17 20:57:42 +00:00
68a56e9d2b
Fix the double testing of .pm files.
...
No review needed for tests at this time.
2001-11-17 17:29:06 +00:00
8cd4f2a450
Bug 104677 : Votes field (text style) on showvotes.cgi defaults to size 5, not natural size and doesn't include a maxlength attribute.
...
Patch by Christoper Aillon <caillon@returnzero.com>.
2001-11-17 10:29:55 +00:00
befb702df6
Bug 101560, pt 2. Perl 5.00503 gives a (bogus?) warning which 5.6 doesn't.
...
Quote manually rather than using qw to get arround this
2001-11-17 07:57:25 +00:00
a4ce4d1898
Bug 101560 - clear some more env vars so that system calls will run in
...
taint mode. The perforce integration stuff needs this.
r=gerv,mattyt
2001-11-17 07:19:46 +00:00
a04fba1c5d
removing server-side startup data reporting, use client-side TinderboxPrint: now.
2001-11-17 06:52:50 +00:00
81161fffbe
leave the update function early if we have not updated anything.
2001-11-16 20:45:24 +00:00
b4c7ff96c3
remove comment which was left over from the original code copy. It refered
...
to some other code.
2001-11-16 20:44:54 +00:00
6bc80bec3b
add support for the Req Ticketing system.
2001-11-16 20:43:30 +00:00
25f260c715
Bug 6419 - command-line query tools by Andreas Franke <afranke@ags.uni-sb.de>.
2001-11-15 17:04:58 +00:00
dfd9b8fa51
turn apostrophe into accute accent to work arround netscape bug.
2001-11-14 21:59:55 +00:00
ecdc8de5e6
document most important change.
2001-11-14 21:25:49 +00:00
d3e78a0f85
admin scripts I use.
2001-11-14 21:24:36 +00:00
618b9d7704
my echo statements had leading '$', how did they get there?
...
I added to the test command so that you can see exactly how it was called.
change the example to show how --tree now works.
2001-11-14 21:23:40 +00:00
1006ed316d
make the checkouts of -D be in sync with the tinderbox boxes by ensuring
...
-D is really the start time.
2001-11-14 21:22:13 +00:00
7a5db2003c
allow for alternating builds using a single build process.
2001-11-14 21:21:02 +00:00
91fafca168
Bug 107718 pt 2 - use subtraction instead of the ~ operator, which older
...
mysql versions don't support. Remove the checksetup.pl restriction, too.
r=jake x2
2001-11-14 15:12:23 +00:00
cca68c9a93
We don't really need to look for fragments that are pulled in by [% INCLUDE %] or [% PROCESS %]. While removing this code bit doesn't allow us to seperatly check that those fragments exist and compile, they'll be checked atomatically when the the template that wants them is run through the process() routine by the 004template.t test. This issue was raised because bug 98707 introduced a [% BLOCK %] element and the syntax for using that is the same as for including a template fragment.
2001-11-14 03:44:07 +00:00
da7e725db3
Fix license headers and make attachment changed page look like bug changed page. Bug 99518 and 98110. r-myk, no second review.
2001-11-13 17:24:24 +00:00
07e2f4e3ac
Fix for bug 86300 - If a bug didn't exist and GetBugLink() tried to create a tooltip for it, you'd get uninitialized variables warnings in your error log. This path also introduces a cache so if the same bug # is mentioned more than once during the same running of the script, it only has to query the database once.
...
r= mattyt, gerv
2001-11-12 13:43:59 +00:00
963817d4d2
Oops. Bug 109690 again, r=justdave, gerv
2001-11-12 05:47:24 +00:00
67fff67155
Bug 109690: Check $bug before using it.
...
r=justdave,gerv
2001-11-12 05:39:14 +00:00
305453a450
Some very primitive default HTML output files for login.accessDenied and login.detailsSent.
2001-11-11 15:37:48 +00:00
c1fbe83087
We should be able to access strings with uppercase letters -- oops. Changing regexp to include 'A-Z' as well as 'a-z'. Also adding a dump statement in the failure case to help when analysing the log looking for a bug.
2001-11-11 15:33:59 +00:00
a98c451be4
Missed a return statement in the setupInstall method. This was causing setup to fail every time, because the function returned a defined value. Also took the opportunity to add a call to setupProgress.
2001-11-11 11:54:06 +00:00
c2b7af4e48
Missed a return statement in the setupInstall method. This was causing setup to fail every time, because the function returned a defined value.
2001-11-11 11:48:14 +00:00
333b70e6e1
Should have been checking for a defined value, not a true value -- there is nothing to stop a failure from being '0', for instance. (The important thing is to be consistent with the SelectingServiceList code, really, and it uses defined().)
2001-11-11 11:47:02 +00:00
538669aedd
Implement a module to give the main application the ability to add rights and do other configuration related stuff.
2001-11-11 09:36:02 +00:00
c36586eccb
Switching to arg form of system call to avoid security hole (76109)
2001-11-11 09:08:56 +00:00
be9eedb5d2
typo! fixes bug
2001-11-11 08:30:21 +00:00
ebf177c5db
Mute the Net::AIM warnings and add some null-checking code to the close() method.
2001-11-11 08:08:26 +00:00
c9fdcfec0f
First stab at primitive AIM output support as an alternative to e-mail.
2001-11-11 04:18:09 +00:00
fb9e84ff2d
Fix typo (PLIFF->PLIF)
2001-11-11 00:58:48 +00:00
a538c2a0cd
Fix the DESTROY method to actually call the close() method like it was supposed to.
2001-11-11 00:14:07 +00:00
085c309f7d
Change the order of the settings so as to match the order in which they are requested. This causes the error message to mention the setting that the user aborted on, instead of some random later setting.
2001-11-10 22:06:54 +00:00
65d308d967
Change createArgument so that we drop the default on the floor -- the default should only be used when explicitly requested (e.g. by the user in interactive mode), not in all cases. CommandLine.pm was in fact already assume that this was the case.
2001-11-10 22:04:34 +00:00
4c322128a7
Switching to batch mode involves changing the 'batch' argument, not the one being requested... ahem.
2001-11-10 21:59:13 +00:00
7c4f16563f
Bracket shuffling to fix a warning in Perl 5.0.x.
2001-11-10 21:57:07 +00:00
2d3f1dc3de
Handle the case where the user hits Ctrl+D during input, and the case where the user piped a file into us and the file was too short.
2001-11-10 21:53:49 +00:00
2f00ddd8dc
Correct an error in the default handler of the namespaced XML walker: we have to shift out the first argument otherwise weird things will naturally happen.
2001-11-10 21:44:28 +00:00
b9400f341d
The User object was not saving anything if its userID started off as undef (i.e., new user) and the code never changed any properties (which is normal for a new user). Changed the code to automatically assume it is dirty if it starts with an undefined userID. Changed writeProperties to use the return value from the data source to save any changes to userID, so that when it is defined (by inserting a new record, probably) then we can remember it. Finally, changed propertySet so that when userID is changed from an undefined value to a defined value, the change is propagated to the fields and the groups are marked dirty, which will force them to be written out too.
2001-11-10 21:00:37 +00:00
5139796ce4
Fix the output template to support multiple authentication protocols now that the code is not lying about that.
2001-11-10 20:55:39 +00:00
503d696c7e
Changed a comment in UserField.pm to be more accurate: it is actually safe to change the userID on the fly from an undefined value to a defined value because the code only uses it at two points: creation, if it was defined (used by the caller) and destruction (at which point it is passed to the data source to save any changes).
2001-11-10 20:53:37 +00:00
ceb11d6d7f
s/smtp/email/go -- have to be consistent with the rest of the code\!
2001-11-10 20:46:29 +00:00
760684e638
Return the user ID even when the user exists, so that there is no need for callers to check the return value.
2001-11-10 20:43:44 +00:00
755f8317fa
Fixing ill-formedness error.
2001-11-10 20:34:00 +00:00
11792d7e2d
fixing perl error
2001-11-10 20:21:38 +00:00
c0f007744b
Switching to proper log-header variable
2001-11-10 19:26:42 +00:00
b5ef59ba98
implemented getFieldNamesByCategory() in the user data source, and used it to fill in the list of contact methods for the loginFailed output handler.
2001-11-10 10:55:33 +00:00
25760a3e0a
Made the phrase 'or to have your password sent to you,' appear regardless of the value of data.tried
2001-11-10 10:51:10 +00:00
168f7364e4
Fix a typo on the To: line which was resulting in a blank To: field, made the Subject: line be dynamically generated, and made the text actually be useful.
2001-11-10 06:26:28 +00:00
75d4cd33b4
proper checking for scrape_builds data
2001-11-10 06:01:35 +00:00
653db8eef9
Oops, syntax error.
2001-11-10 05:21:17 +00:00
73e0c55c22
Use the actual From: address (now that the outputter tells us what it is...).
2001-11-10 05:12:06 +00:00
4a03227913
Added another set of data to the data hash: the outputter hash. This will be useful for strings that have to embed things like the e-mail address of the application itself. Added hash methods to the Email and Stdout generic outputter modules to support this change. Renamed 'from' to 'address' in the Email outputter to make it easier to reuse the code (hehe). Also, in the same module, changed some of the comments, changed a double quote string literal to a single quote string literal, and added the word 'configure' where it was missing in one of the dump statements.
2001-11-10 05:00:14 +00:00
d433d136be
Implement some primitive error handling for sending mail.
2001-11-09 21:59:21 +00:00
8e94200878
Adding scrapebuilds.pl check
2001-11-09 21:37:02 +00:00
fbdc6f515c
Adding scrape_builds
2001-11-09 21:35:25 +00:00
a2023e4533
Adding scrapebuilds toggle ui
2001-11-09 21:32:41 +00:00
5f50ff180f
Adding scrapebuilds.pl
2001-11-09 21:31:19 +00:00
b6d1378fa1
Removing unnecessary spammy debug output (this code works now... honest\!)
2001-11-09 21:22:32 +00:00
91d903d8df
Decode %XX-encoded strings.
2001-11-09 21:19:59 +00:00
e9904215c0
Added some more comments that might help people get this working on Apache.
2001-11-09 20:23:42 +00:00
197ee7192a
Factored out the connect/disconnect code, added settings for the host and the from address and made them be handled by a setup.configure handler, wrapped the call to Net::SMTP->new() in a warning-free block.
2001-11-09 20:21:11 +00:00
4d542c9a80
Adding support for generic saving and retrieving of settings.
2001-11-09 20:13:21 +00:00
3ae1b10178
Adding a comment on the use of assert()
2001-11-09 20:09:22 +00:00
e2ceae0e2f
Refactored the Database::DBI code. Added support for default values in the setup code. Added support to create the database and the user (although some of this may need refactoring into separate MySQL submodules).
2001-11-09 17:23:41 +00:00
7d4ba9fdd4
Changing the order of loaded modules to make sure they are set up in the right order.
2001-11-09 17:16:50 +00:00
27c0a625e9
Added a missing 'return' statement so that the user.fields setup routine doesn't appear to have failed when it hasn't (without a return statement, the value of the last statement is the return value).
2001-11-09 17:15:13 +00:00
df6f9d0b23
Changed the DESTROY method to make sure it calls its parent.
2001-11-09 17:13:27 +00:00
d8ed08b9c5
Added support for printing the default value for requests.
2001-11-09 17:12:18 +00:00
2605f093c1
Added the ability to find the length of an array (array.length to go with array.0, array.1, etc). Added assertions to handle the case of invalid order or sort attributes on <set>. Added two new sort types ('default' and 'reverse default').
2001-11-09 17:10:22 +00:00
2dc794285b
Added two assertions to make sure the handle is defined before using it, and added a check that the handle is defined before releasing it. Also changed the DESTROY method to call its parent.
2001-11-09 17:07:18 +00:00
d11f28591a
Removing excess trailing spaces on one line, and moving a warn from level 5 ('important events') to level 8 ('frequent important events').
2001-11-09 17:03:40 +00:00
a5b875e7b1
Fixed DESTROY method to make sure it calls its parent.
2001-11-09 17:00:28 +00:00
2913cffeec
Removing the @arguments array from a dump statement, because if any of the elements in the array are undef then a runtime warning is printed (undef elements is not always a bug).
2001-11-09 16:58:38 +00:00
ac58840368
Added a level 5 dump indicating the completion of the PLIF program.
2001-11-09 16:56:49 +00:00
1f8a352b1d
Fixed DESTROY method to make sure it called it's parent.
2001-11-09 16:52:08 +00:00
fd84ee0b49
Change default DEBUG level from 9 to 4, which is what it should be in production releases. Added comments explaining debug levels 6 (reserved for personal use) and 8. Added level 10 debug info to the DESTROY method (makes it easier to track down bugs during shutdown).
2001-11-09 16:50:47 +00:00
90d2164530
Made it so the setupEnding event is sent out after the setup failure message is printed but before the setup success message is printed (reduces the number of error messages if you cancel during setup). Changed the semantics of the output.progress string's data.component data. It is now a dotted hierarchical string giving progressively more detail about what is being set up. e.g., 'database', 'database.default.settings', 'database.default.settings.connection.port'. If outputters are interpreting data.component then any trailing unknown levels of detail should be ignored. This allows the setup routines to potentially give much more useful output. Fixed the default stdout output string for setup (it has <text variable=""> instead of value="").
2001-11-09 16:39:29 +00:00
55777ba07e
Bugzilla Bug 109138 platform detection not working on macintosh
...
r=bbaetz,dkl
2001-11-09 05:32:43 +00:00
306a373344
Fix for bug 109048: fixes error when creating attachments without logging in.
...
Patch by Myk Melez <myk@mozilla.org>.
r=bbaetz,gerv
2001-11-09 01:11:09 +00:00
0530fac9f3
Also send default values to output.
2001-11-08 17:27:07 +00:00
003293a088
Implement default values for arguments. getArgument() and createArgument() now take two parameters like setArgument(). Changed the CommandLine module's createArgument() method so that if the user hits enter at the prompt, the default value is used. Added some comments to clarify what is going on with the 'batch' argument. Changed setArgument() and createArgument() in the Arguments module and createArgument() in the CommandLine module to be more efficient (less array copying).
2001-11-08 17:09:11 +00:00
a6fc410cbf
Adding comments to clearly indicate that no dump()s, warn()s or error()s should have a level lower than 5 unless they are not expected to occur during normal operation. Also changing the default level at which the user is notified of problems from 3 to 1.
2001-11-08 16:47:25 +00:00
ade117cf45
Added two new hooks into the setup code: a start notification and an end notification. Added the ability to disable the string datasource (causes it to only use the default strings and not the database). Made the string datasource automatically disable itself during configuration, using the two hooks added to the setup code. This removes the warning messages that are output during a clean setup ('could not get string from database', etc).
2001-11-08 16:42:42 +00:00
a15a7b4506
Improved error handling for the case where the database configuration doesn't exist and therefore every output attempt raises database errors. Fatal database errors are now fatal, missing database configurations is not. This would be a lot cleaner if Perl exceptions were objects... Also improved some of the error messages.
2001-11-08 16:10:21 +00:00
477622872e
Added a little more level 9 verbose debugging feedback to help track down where output is going wrong.
2001-11-08 05:07:42 +00:00
f9a76a2609
Stop complaining about the configuration file missing -- if it is not there then just assume there is nothing to worry about. This makes the output of the initial run with the 'setup' argument a lot quieter.
2001-11-08 05:06:27 +00:00
10dc2574fd
Make the STDOUT generic outputter flush everything it outputs -- this fixes a bug whereby sometimes prompts wouldn't appear until after the user had replied to them.
2001-11-08 05:03:57 +00:00
52073d81d4
Fix for bug 99519: timestamps were not being set correctly in the activity table in some situations, and the delta_ts on the
...
bug itself was not always being updated if dependencies or CCs changed.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-08 03:38:12 +00:00
5efe1d5efa
Fix for bug 104652: Duplicate bugs in the dependency tree now get marked with the message "This bug appears elsewhere in this tree." so users know why the bug does not appear to have dependencies.
...
Patch by Gerv <gerv@mozilla.org>.
r=jake@acutex.net ,myk@mozilla.org
2001-11-08 02:43:55 +00:00
1b68d1dda8
Fix for bug 108822: Prevent any user from changing their own groupset.
...
Patch by Jake <jake@acutex.net>.
r=bbaetz,myk
2001-11-08 00:54:15 +00:00
a216712f0a
Fix for bug 108821: Prevent users with any blessgroupset privileges from blessing any group set.
...
Patch by Jake <jake@acutex.net> and Bradley <bbaetz@cs.mcgill.ca>.
r=jake,myk for Bradley's portion, r=bbaetz,myk for Jake's portion.
2001-11-08 00:52:13 +00:00
fa9b2fac19
Fix for bug 108812: Prevent users from running queries containing arbitrary SQL.
...
Patch by Jake <jake@acutex.net>
r=bbaetz,myk
2001-11-08 00:49:18 +00:00
0f4ed0a3f3
Require (temporarily) mysql >= 3.23.5 for the ~ operator, needed for the
...
fix to bug 107718. This should be removed when the group stuff lands (bug
60822).
r=justdave x 2
2001-11-07 22:42:32 +00:00
5b62cb9f40
Bug 101166 - users seeing a bug via _accessible bits should see that its
...
the group
r=justdave,jake
2001-11-07 16:11:33 +00:00
b827269287
Bug 108547 - Make the JavaScript use proper DOM
...
Patch by Christopher Aillon <caillon@returnzero.com>
r= timeless@bemail.org , kiko@async.com.br
2001-11-07 14:58:56 +00:00
d1d1fa4ac2
Disambiguate the names of the two methods 'hash' and 'sort'. They are now called 'genericHash' and 'genericSort' so as not to clash with the perl builtins 'CORE::hash' and 'CORE::sort'.
2001-11-07 02:49:21 +00:00
96ab2ee6f2
Changing the shebang to point to a more likely location of the perl interpreter.
2001-11-07 02:46:38 +00:00
9fc12babee
Initial checkin of the first PLIF test application.
2001-11-07 01:42:05 +00:00
b393412647
Refixing bug 71840 - The name should be the 'name' should be the same as what the 'href' points it too...
...
r= justdave@syndicomm.com
2001-11-06 18:06:02 +00:00
99906b233b
SECURITY FIX see bug 108385: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to add a comment to a bug pretending to be someone else if you edited the HTML by hand before submitting. The bug form did not include the field in question, but due to legacy processing code, the field was still trusted if it was present.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake x2
2001-11-05 20:47:17 +00:00
5167730d7c
SECURITY FIX see bug 108516: Due to trusting of passed form fields that shouldn't have been trusted, it was possible to file a
...
bug pretending to be someone else if you edited the HTML by hand before submitting.
Patch by Dave Miller <justdave@syndicomm.com>
r= bbaetz, jake
2001-11-05 20:43:35 +00:00
59c51cc3f3
scrape comment
2001-11-05 08:50:55 +00:00
63dd8ca807
Bugzilla Bug 107672 Browser OS/Platform discrimination alg sucks
...
r=bbaetz, jake
Windows XP references are #'d because of bug 92763
2001-11-05 04:44:34 +00:00
8d60ac104d
Bug 107718 - mass changes give all changed bugs the groupset of the first
...
bug in the list.
Do bit fiddling instead of adding groupsets from the first bug.
r=justdave, jake
2001-11-03 05:49:23 +00:00
0d548cbdb5
remove unused remove_build sub.
2001-11-03 05:14:10 +00:00
2f96d2424d
Adding multi-line support.
2001-11-03 02:10:05 +00:00
830eb08e7c
Fix for bug 105773: Email addresses in the CC list are now sorted case-insensitively
...
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2
2001-11-03 02:05:43 +00:00
2b5d21db32
cut&paste bug
2001-11-03 01:18:39 +00:00
f169efa91a
Adding basic scrape functionality. Pick off TinderboxPrint: token and print the argument in the corresponding build box. Currently limited to one line, multi-line change coming next.
2001-11-03 00:50:13 +00:00
1960bf88c1
Adding scrape.dat
2001-11-02 22:55:09 +00:00
5491c18362
Switching to TinderboxPrint:aaa,bbb,ccc format. r=pchen
2001-11-02 22:41:40 +00:00
63778cf408
Fix for bug 95615: cosmetic change to clarify error message when trying to use too many votes
...
Patch by Adam Kennedy <bugzilla@ali.as>
r= justdave x2
2001-11-02 20:05:13 +00:00
445371fdc5
Adding scrape scan.
2001-11-02 09:43:12 +00:00
1485bee767
Tinderbox,aaa,bbb,ccc,ddd format.
2001-11-02 09:37:35 +00:00
caa12c0123
General purpose version of bloat.pl
2001-11-02 05:22:00 +00:00
4002af17b4
no warn.pl anymore
2001-11-02 05:20:25 +00:00
eb04d9ee9c
Checking in fix for bug #86920 , fix from jake@acutex.net
2001-10-31 04:30:33 +00:00
bfc39645e6
Checking in patch for bug #44641 , patch from Ian Wells
2001-10-31 04:20:28 +00:00
6bddfa73c0
Checking in patch for bug#36597, patch from miri@punknet.cz
2001-10-31 04:07:25 +00:00
c85a5d1839
Fixing tinderbox bustage (removing <Tab>s and adding a "use vars" line)
2001-10-31 03:31:00 +00:00
5669c51e6b
Have the tests test .pm files as well, yes this creates bustage, this is
...
intentional!
No review needed for tests at this time.
2001-10-31 01:06:31 +00:00
5c76deb7fa
Fix test bustage by removing tabs.
2001-10-31 00:21:28 +00:00
4ea5f75411
Fix for bug 98602: re-implementation of "create attachment" page.
...
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org ,jake@acutex.net
2001-10-30 23:42:22 +00:00
ce040d977a
Fix for bug 96675: checksetup should require admin e-mail address satisfy emailregexp. This fix has
...
checksetup.pl use the emailregexp set in params if the params file exists, or ensures that it matches the
default emailregexp from defparams.pl.
r1=justdave, r2=bbaetz.
2001-10-28 03:40:59 +00:00
c30466ca7c
A few enhancements to the template test:
...
* If there's a compilation error, report what it is
* Don't try to compile a template if it doesn't exist
- We already tested for that and issued an ERROR
* Define the 'url' FILTER
2001-10-27 15:27:31 +00:00
99fb9b92c7
Bug 105879 - Footer links have an extra | by Sanity Check
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com , jake@acutex.net
2001-10-26 18:49:33 +00:00
5c374686dd
Bug 81594 - SQL error after editing user entry when changing numerous things at once (including the login name).
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= dkl@redhat.com , jake@acutex.net
2001-10-26 18:35:04 +00:00
d6fb901800
Check templates for tabs, also.
2001-10-26 13:21:38 +00:00
b59ced36fe
Change %f to %d for page load times.
2001-10-26 06:37:31 +00:00
042a622edf
Use ms instead of s for pageloader time.
2001-10-26 06:32:58 +00:00
b227e18dfe
Fix for bug 98602: re-implementation of "create attachment" page.
...
Patch by Myk Melez <myk@mozilla.org>.
r=gerv@mozilla.org ,jake@acutex.net
2001-10-25 20:37:53 +00:00
57021053de
Bug 104065 - Stop uninitilized string warnings from getting into the error log when the login cookie doesn't exist.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= gerv@mozilla.org , jake@acutex.net
2001-10-25 14:46:58 +00:00
2117408847
Bug 104540 LXR updates for .idl collaboration diagrams
...
by mozilla@elemental.com (Brian Bramlett)
r=endico
2001-10-25 01:05:07 +00:00
ac3ee32727
Fixed "used only once" warning coming from my patch for bug 97469. The
...
warning was hidden from the tests by bug 106424.
r=Jake, no 2nd review needed.
2001-10-24 20:33:49 +00:00
6747fcb289
Don't rely on the TEST_VERBOSE environment variable (no longer exported from runtests.sh) and instead print to the TESTOUT file handle pulled in from Test::More. This will allow the testing backend to check for verbosity rather than having to handle it in the .t files.
2001-10-24 18:41:53 +00:00
670ce08714
Bug 106424 - We weren't going orange on warnings such as "used only once". This script now properly outputs the --WARNING and fails on such a condition.
2001-10-24 13:29:49 +00:00
131e04c22d
Fix for bug 106315: Link on bug list for emailing QA contacts.
...
Patch by Dave Miller <justdave@syndicomm.com>.
r=myk@mozilla.org , no second review needed.
2001-10-24 01:31:09 +00:00
543d7e522a
Bug 97469 - Assignee/QA/Reporter/CC don't get email on restricted bugs.
...
Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.
Also fxed bug 101560, by clearing BASH_ENV
r=myk,justdave
2001-10-23 15:44:53 +00:00
65fa8f8fc3
Bug 63249 - The Bug Counts report was running very slowly due to unneeded fields/joins in the SQL query.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org , jake@acutex.net
2001-10-23 14:45:45 +00:00
a6dd3ea4b9
Fix missing description problem for options that required multiple lines for the description.
2001-10-21 19:11:25 +00:00
816b5dd385
Bug 71840 - Make comments referenceable using a #c4 to get the fourth comment.
...
Patch by Gerv <gerv@mozilla.org> and Myself.
r= jake@acutex.net , gerv@mozilla.org , justdave@syndicomm.com
2001-10-20 13:03:14 +00:00
8a7f3a8457
Backing out previous change, the wrong patch got checked in.
2001-10-20 12:59:57 +00:00
46fd032ece
Bug 71840 - make comments referenceable. Patch by gerv/jake. r=justdave, jake/gerv.
2001-10-20 01:06:59 +00:00
675c319ea2
Bug 105480 - Use the friendly name from the fielddefs table when reporting strictvalue errors if it's available.
...
Patch by James A. Laska <jlaska@us.ibm.com>
r= justdave@syndicomm.com , jake@acutex.net
2001-10-20 00:50:27 +00:00
bcb8c54a83
Bug 104340 - Changing the UI of the toolbar for hiding bugs in the dependency tree.
...
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com , gerv@mozilla.org
2001-10-20 00:22:52 +00:00
b6e9432e59
Bug 73180 - We now put a notice at the top of the versioncache file saying that it should not be edited.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= gerv@mozilla.org , jake@acutex.net
2001-10-19 23:49:37 +00:00
e2b7472ba4
Bug 103664 - Tests should "use strict;" and not contain any tabs. We should also use the TEST_VERBOSE environment variable instead of VERBOSE.
...
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
Additional edits by myself to add the emacs mode line. Also, the change to runtests.sh was done by me.
2001-10-19 22:39:51 +00:00
7318c1f0c6
Fix for bug 105365 - Hacker's Guide should be in SGML. This will make it easier to do other additions to the hacker's guide.
2001-10-19 16:18:10 +00:00
57dc85bacc
yet another meaningless whitespace change to test tinderbox with
2001-10-19 13:03:52 +00:00
84b6128d34
another useless whitespace change to test tinderbox with
2001-10-19 06:19:52 +00:00
99976f18e1
Adding one more sig fig for startup time.
2001-10-19 06:15:24 +00:00
85fc977983
switching search token to __avg_startuptime, we are going to iterate the test now and report an average time.
2001-10-19 05:56:38 +00:00
95bb6c3a2f
whitespace change to test tinderbox again.
2001-10-19 05:33:23 +00:00
eba7113fc2
whitespace change to do a test checkin to see how tinderbox reacts
2001-10-19 04:36:19 +00:00
ee01d8559d
Bug 72177 - reword checkbox to make it consistent with the others on the page.
2001-10-18 21:41:25 +00:00
d881020ef7
Bug 60818 - make Bugzilla cope with MIME types with parameters. Patch by gerv, r=myk.
2001-10-18 21:28:06 +00:00
3fa8caccbc
Remove the /var/run/ stuff. I need to think this through more carefully.
...
This only needs to happen on the build script. This needs to happen as
the user root but currently I do not run the build script ever as root.
2001-10-18 16:19:59 +00:00
779e9d8b3c
bug fixes to get the /var/run stuff to work.
2001-10-18 16:17:24 +00:00
b409f8a706
separate the packge output into client and server packages.
2001-10-18 15:59:20 +00:00
892bf124a5
Add support for /var/run/ directory.
2001-10-18 15:05:57 +00:00
534fd0c9a6
Bug 98146 redux - changing URL to relative one. Oops. Patch by jake, r=gerv.
2001-10-16 18:42:05 +00:00
f71660f568
bug 27506, i messed up. making the changes per cbiesinger@web.de and justdave@syndicomm.com
2001-10-16 08:44:43 +00:00
b7929470ef
Bug 30480 - add 'show dependencies as buglist' links. Patch by gerv, r=myk, kiko.
2001-10-16 03:09:52 +00:00
7b534cab6c
Fix for bug 98146.
...
Patch by Gerv <gerv@mozilla.org>.
r=myk, no second review needed.
2001-10-15 23:02:48 +00:00
b3109d83ec
Recompiling docs to pick up last two changes
2001-10-15 19:18:04 +00:00
mcafee%netscape.com
ian%hixie.ch
jake%acutex.net
myk%mozilla.org
timeless%mac.com
justdave%syndicomm.com
gerv%gerv.net
matty%chariot.net.au
barnboy%trilobyte.net
zach%zachlipton.com
bbaetz%cs.mcgill.ca
kestes%walrus.com
tara%tequilarista.org
waterson%netscape.com
seawood%netscape.com