Граф коммитов

24582 Коммитов

Автор SHA1 Сообщение Дата
Nicolas Chevobbe 453c3d2ade Bug 1646113 - [devtools] Add IE to compatibility panel browser list. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D137146
2022-01-27 15:55:29 +00:00
Norisz Fay c1beee2e91 Bug 1744778 - disable browser_aboutdebugging_addons_debug_popup.js on Win10_2004 64 bits for frequent failures. r=intermittent-reviewers,MasterWayZ DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D137037
2022-01-27 13:40:52 +00:00
Claudia 50fa24f109 Bug 1745410 - [devtools] Allows user to edit the request body (POST body) in New Custom Request Panel r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136633
2022-01-27 10:07:21 +00:00
Claudia 015a4e298b Bug 1745395 - [devtools] Makes URL input into a multi-line text area in New Custom Request Panel r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136478
2022-01-27 10:07:21 +00:00
Alexandre Poirot bea7ff1402 Bug 1751851 - [devtools] Migrate all ui selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136862
2022-01-27 08:31:42 +00:00
Alexandre Poirot 47cee65f87 Bug 1751851 - [devtools] Migrate all source-tree selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136861
2022-01-27 08:31:42 +00:00
Alexandre Poirot 703b5c1d33 Bug 1751851 - [devtools] Migrate all quick-open selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136860
2022-01-27 08:31:41 +00:00
Alexandre Poirot 18174d4f0c Bug 1751851 - [devtools] Migrate all project-text-search selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136859
2022-01-27 08:31:41 +00:00
Alexandre Poirot 1cf1c87327 Bug 1751851 - [devtools] Migrate all preview selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136858
2022-01-27 08:31:41 +00:00
Alexandre Poirot 05a36f0d48 Bug 1751851 - [devtools] Migrate all file-search selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136857
2022-01-27 08:31:40 +00:00
Alexandre Poirot 1801acf3d0 Bug 1751851 - [devtools] Migrate all exceptions selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136856
2022-01-27 08:31:40 +00:00
Alexandre Poirot d922ca4ee4 Bug 1751851 - [devtools] Migrate all event-listeners selectors to a selector module. r=bomsy
I'm also sorting the import from index.js in order to help the maintenance of this list.

Differential Revision: https://phabricator.services.mozilla.com/D136855
2022-01-27 08:31:39 +00:00
Alexandre Poirot b44cd5b678 Bug 1751851 - [devtools] Migrate all ast selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136854
2022-01-27 08:31:39 +00:00
Alexandre Poirot f92cb088f2 Bug 1751851 - [devtools] Remove unused getFramework selector. r=bomsy
Only this jest test was using it.

The react component is using this one instead:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/actions/sources/symbols.js#26-28
which depends on tabs reducer's framework attribute, which uses the ast's getSymbols selector:
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/shared/SourceIcon.js#44
https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/utils/tabs.js#35-38

Differential Revision: https://phabricator.services.mozilla.com/D136853
2022-01-27 08:31:39 +00:00
Julien Wajsberg c68e923e27 Bug 1639716 - [devtools performance] Capture profiles only in non-private windows r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D129518
2022-01-26 17:26:23 +00:00
Julien Wajsberg 66e3718376 Bug 1639716 - [devtools performance] Change a few test helpers so that the window can be specified r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D134338
2022-01-26 17:26:23 +00:00
Julien Wajsberg 900b1c7aeb Bug 1639716 - [devtools performance] Cleanup: pass the openAboutProfiling function from panel.js for more simplicity r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D129421
2022-01-26 17:26:22 +00:00
Julien Wajsberg 44769eadc9 Bug 1639716 - [devtools performance] Remove all actor code related to the profiler locking mechanism by private browsing r=jdescottes,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D129420
2022-01-26 17:26:22 +00:00
Julien Wajsberg c579c9f617 Bug 1639716 - [devtools performance] Use the traits to control the call to the removed functionality r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D129419
2022-01-26 17:26:21 +00:00
Julien Wajsberg 58c4dd6381 Bug 1639716 - [devtools performance] Add a property to the root actor's traits and pass all traits to the gInit function r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D129418
2022-01-26 17:26:21 +00:00
Julien Wajsberg ff988ebecd Bug 1639716 - [profiler] Remove the profiler disabling by private browsing r=jdescottes,gerald,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D129417
2022-01-26 17:26:21 +00:00
Nicolas Chevobbe 8d7ccd7eda Bug 1731612 - [devtools] Display layer name in the rule view. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D136620
2022-01-26 13:01:47 +00:00
Nicolas Chevobbe c72e9161e6 Bug 1751899 - [devtools] Remove compatibility panel Feedback button. r=Honza.
Differential Revision: https://phabricator.services.mozilla.com/D136996
2022-01-26 12:46:44 +00:00
Benjamin VanderSloot f13ae1008d Bug 1750000 - Make tests in devtools/client/test/ dFPI compatible, r=jdescottes,anti-tracking-reviewers,timhuang
We are fixing mochitests that fail when network.cookie.cookieBehavior = 5, i.e. when we enable Total Cookie Protection.
This is most often due to the test assuming that an origin will always have access to its storage state when embedded as
a third party.

My approach: Add third-party storage permission for the net domain when included on the com domain.
This allows the cache for the net domain to be shared in the way that this test is expecting.

Differential Revision: https://phabricator.services.mozilla.com/D136601
2022-01-25 12:08:25 +00:00
Nicolas Chevobbe 8aa8d1be36 Bug 1685187 - [devtools] Fix browser_resources_document_events.js intermittent. r=ochameau.
The test was failing in some case because interactiveEvent and completeEvent had
the same timestamp (which is still valid).
The test is modified to check greater or equal instead of strict greater.
Note that this test still has intermittent around willNavigateEvent and
loadingEvent (see https://searchfox.org/mozilla-central/rev/a2c26b9b49a521f4be39559ca1ca9c345a237c70/devtools/server/actors/webconsole/listeners/document-events.js#11-34)

Differential Revision: https://phabricator.services.mozilla.com/D136839
2022-01-25 08:18:17 +00:00
Hubert Boma Manilla bc42c77238 Bug 1748621 - [devtools] Add tests for blackboxing a source r=nchevobbe
The tests covers most of the blackbox functionality
Notably it covers issues fixed in D135393 and D135614

Differential Revision: https://phabricator.services.mozilla.com/D135496
2022-01-25 08:12:00 +00:00
Randell Jesup acfbcd62fe Bug 1747261: enable ServiceWorker process-isolation for all domains r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D134505
2022-01-24 19:38:01 +00:00
Nicolas Chevobbe a039ea5752 Bug 1747195 - [devtools] Put rule media query above the selector. r=jdescottes.
This is preliminary work before showing the @layer information above the rule view as well.

Differential Revision: https://phabricator.services.mozilla.com/D136619
2022-01-24 16:36:35 +00:00
Nicolas Chevobbe 352cbd5a78 Bug 1749551 - [devtools] In event-collector, only hide jump to debugger button when no source actor were created. r=ochameau.
We don't need to have specific check for dom0 event listeners as the debugger
button should be show as long as we managed to create a source actor.
We can remove usage of `script.source.element` alltogether as we don't need
it for not showing the line number in the location (the line is 0 in such case,
and we already discriminate for such value).

A test case is added to ensure that the debugger can be opened from the
event tooltip on a dom0 event.

Differential Revision: https://phabricator.services.mozilla.com/D136461
2022-01-24 12:54:05 +00:00
Alexandre Poirot 748da20408 Bug 1751235 - [devtools] Fix isPopup flag for iframes loaded via window.open(url, "iframe-name"). r=nchevobbe
This flag should really only be true for document loaded in distinct tabs.

Differential Revision: https://phabricator.services.mozilla.com/D136505
2022-01-24 10:16:04 +00:00
Alexandre Poirot 6abf4cdc59 Bug 1751207 - [devtools] Allow debugging popups when a toolbox is opened for its opener tab. r=nchevobbe
This is only an issue when devtools.popups.debug is false,
when it is true, the toolbox is move and a warning message is printed
if we request to open a new toolbox.

Differential Revision: https://phabricator.services.mozilla.com/D136498
2022-01-24 10:16:04 +00:00
Julian Descottes 2f5682b0df Bug 1751214 - [devtools] Bypass cache in browser_resources_network_events_parent_process.js for test-verify r=ochameau
depends on D136705

Differential Revision: https://phabricator.services.mozilla.com/D136707
2022-01-24 09:27:03 +00:00
Julian Descottes 4876669254 Bug 1751480 - [devtools] Update line:column asserts in browser_resources_network_events_parent_process.js to be more explicit r=ochameau
Depends on D136703

Differential Revision: https://phabricator.services.mozilla.com/D136705
2022-01-24 09:27:03 +00:00
Julian Descottes d0a70b106a Bug 1751480 - [devtools] Force devtools.browsertoolbox.fission in browser_resources_network_events_parent_process.js r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D136703
2022-01-24 09:27:02 +00:00
Sai Hemanth B 5993bb3819 Bug 1748805 - Add setOverflowHighlight method to ReadOnlyEditor. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D136688
2022-01-24 07:15:51 +00:00
Butkovits Atila 5ad2b9480a Merge autoland to mozilla-central. a=merge 2022-01-22 23:47:38 +02:00
Steve Fink 2984f44b93 Bug 1746090 - Switch RootList::init from taking an AutoCheckCannotGC token to returning one r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D135297
2022-01-22 01:34:45 +00:00
Alexandre Poirot d3c1ec720d Bug 1751032 - [devtools] Migrate all tabs selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136399
2022-01-21 16:01:01 +00:00
Alexandre Poirot 6688d3c8fb Bug 1751031 - [devtools] Migrate all thread selectors to a selector module. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136398
2022-01-21 16:01:00 +00:00
Julian Descottes dabf47a8db Bug 1636262 - [devtools] Update Edge browser icon for the compatibility panel r=nchevobbe
The SVG was created from scratch, so no issue with licensing hopefully

Differential Revision: https://phabricator.services.mozilla.com/D136595
2022-01-21 13:18:15 +00:00
Nicolas Chevobbe 161c5b7679 Bug 1669968 - [devtools] Remove lodash from tree.r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D136173
2022-01-21 12:48:22 +00:00
Nicolas Chevobbe e66b0059a3 Bug 1737978 - [devtools] Remove lodash memoize usage. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D136172
2022-01-21 12:48:22 +00:00
Claudia 6748189c7e Bug 1745411 - [devtools] - Allows user to clear the content of the New Custom Request Panel. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136162
2022-01-21 12:23:41 +00:00
Claudia 840135fa1c Bug 1745396 - [devtools] Create a drop down list to HTTP Method in New Custom Request Panel. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D136025
2022-01-21 12:23:41 +00:00
Noemi Erli 3da595ab6f Backed out 10 changesets (bug 1746090) for causing failures in HeapSnapshot.cpp CLOSED TREE
Backed out changeset 132c6be41ec2 (bug 1746090)
Backed out changeset aea63ceb5ff5 (bug 1746090)
Backed out changeset 42586bdfd56f (bug 1746090)
Backed out changeset 86dfecd590e8 (bug 1746090)
Backed out changeset 92a55bc8c1c8 (bug 1746090)
Backed out changeset 3a282a6b5f65 (bug 1746090)
Backed out changeset fe5ac63668b4 (bug 1746090)
Backed out changeset a0b1735ffffd (bug 1746090)
Backed out changeset 2f7a62b93266 (bug 1746090)
Backed out changeset b9b4558c03dc (bug 1746090)
2022-01-21 02:58:48 +02:00
Steve Fink fb8fc947c7 Bug 1746090 - Switch RootList::init from taking an AutoCheckCannotGC token to returning one r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D135297
2022-01-20 23:40:29 +00:00
Alexandre Poirot d11e2bcabb Bug 1747371 - [devtools] Set the session context for the parent process target. r=nchevobbe
We were missing cached image request and probably CSP blocked request
from the parent process because of this.
We are spawning a NetworkEventContentWatcher for the parent process target.
That's semi-intentional. This might better be done via a parent process resource type,
like NETWORK_EVENT. But the current Resource framework doesn't allow to do that easily.

So that we currently spawn the NetworkEventContentWatcher (and NetworkEventStackTraceWatcher)
against the parent process target actor as a "FRAME" resource type.
This is handy as we need at least one of these two watchers for the parent process.

Differential Revision: https://phabricator.services.mozilla.com/D136325
2022-01-20 13:20:33 +00:00
olaoluwa 994590ea3f Bug 1711396- updating grid-gap to make it detectable by the css inspector and adding gap.js test. r=Oriol,devtools-reviewers,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D128666
2022-01-20 08:45:53 +00:00
Nicolas Chevobbe 1937921909 Bug 1737977 - [devtools] Remove lodash isEqual usage. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D136171
2022-01-20 07:21:11 +00:00
Nicolas Chevobbe 258b5b15d1 Bug 1737976 - [devtools] Remove lodash isEmpty usage. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D136169
2022-01-20 07:21:10 +00:00
Nicolas Chevobbe 7032fd4fcc Bug 1737974 - [devtools] Remove lodash has usage. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D136167
2022-01-20 07:21:10 +00:00
Nicolas Chevobbe 95d313e862 Bug 1750514 - [devtools] Remove lodash-move. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D136166
2022-01-20 07:21:09 +00:00
Nicolas Chevobbe 49d84414bf Bug 1750505 - [devtools] Remove lodash uniqBy usage. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D136165
2022-01-20 07:21:09 +00:00
Nicolas Chevobbe c00196fd3f Bug 1737980 - [devtools] Remove lodash omit usage. r=bomsy.
It was only used in storeExpressions, where we can replace it by storing only the input property
instead of removing the value property from the object we store.

Differential Revision: https://phabricator.services.mozilla.com/D136164
2022-01-20 07:21:09 +00:00
Marian-Vasile Laza 5e48e30b98 Backed out 10 changesets (bug 1746090) for causing build bustages on TestingFunctions.cpp. CLOSED TREE
Backed out changeset edbf96722e4b (bug 1746090)
Backed out changeset f4e4bf6ba8ff (bug 1746090)
Backed out changeset c288fe1c6c84 (bug 1746090)
Backed out changeset 2b0caa13d0fc (bug 1746090)
Backed out changeset 1ed9d77885c6 (bug 1746090)
Backed out changeset 54a60388fb11 (bug 1746090)
Backed out changeset a9c16e721533 (bug 1746090)
Backed out changeset 774bdb9939a9 (bug 1746090)
Backed out changeset 5c5742535301 (bug 1746090)
Backed out changeset ff509fe4671d (bug 1746090)
2022-01-20 02:39:17 +02:00
Steve Fink aea0c2fa07 Bug 1746090 - Switch RootList::init from taking an AutoCheckCannotGC token to returning one r=jonco
Differential Revision: https://phabricator.services.mozilla.com/D135297
2022-01-20 00:23:10 +00:00
Dana Keeler b543bb3a2a Bug 1750089 - remove weak certificate signature error console message r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D135943
2022-01-19 21:24:47 +00:00
Henrik Skupin 8fae55637f Bug 1750915 - [devtools] Remove backward compatible code for WebExtension targets supporting the watcher. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D136348
2022-01-19 19:15:20 +00:00
Henrik Skupin b497281e7f Bug 1750915 - [devtools] Remove backward compatible comment for new "parentInnerWindowId" attribute. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D136347
2022-01-19 19:15:20 +00:00
Henrik Skupin f46fac8cad Bug 1750915 - [devtools] Remove backward compatible code for windowGlobalTarget.attach. r=jdescottes,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D136346
2022-01-19 19:15:19 +00:00
Henrik Skupin 4b14e24467 Bug 1750915 - [devtools] Remove backward compatible code for frame.isTopLevel. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D136345
2022-01-19 19:15:19 +00:00
Alexandre Poirot c29b020b4a Bug 1571212 - [devtools] Wait for resume to complete in all xpcshell tests. r=bomsy
test_stepping-12.js wasn't correctly waiting for thread to be resumed between each of its sub test.

Similarly, other tests weren't waiting for thread front's resume request to be resume.
I'm also spreading the usage of resumeAndWaitForPause to better ensure we resume and wait for next paused event
without any race condition. Listening to "paused" after calling "resume" is subject to race conditions.

Differential Revision: https://phabricator.services.mozilla.com/D136125
2022-01-19 17:43:00 +00:00
Nicolas Chevobbe a73d337ea1 Bug 1750227 - [devtools] Register cleanup function in initBrowserToolboxTask. r=ochameau.
If a test involving the Browser Toolbox times out, the Browser Toolbox
would not close and could have impact on next tests.
In this patch we register a cleanup function to make sure we always
close the Browser Toolbox.

Differential Revision: https://phabricator.services.mozilla.com/D136096
2022-01-19 12:51:51 +00:00
Nicolas Chevobbe 7dfca66f06 Bug 1737969 - [devtools] Remove lodash findIndex/findLastIndex usages. r=jdescottes.
We take this opportunity to rename `removeInnerLocations` to `getInnerLocations`
and make it return an array of inner locations rather than returning the list
of original locations with inner locations stripped.
This makes the function easier to understand (not having to deal with indexes
+ splicing), and doesn't harm the only callsite where we can handle those inner
locations into the filter call that was done on the array returned from `removeInnerLocations`

The parser-worker was updated.

Differential Revision: https://phabricator.services.mozilla.com/D136095
2022-01-19 12:51:51 +00:00
Nicolas Chevobbe 6fb80883a7 Bug 1737986 - [devtools] Replace lodash throttle usage with devtools/shared/throttle. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D136094
2022-01-19 12:51:50 +00:00
Hubert Boma Manilla 1735d72fec Bug 1750613 - [devtools] Rename underRoot to isDescendantOfRoot r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D136174
2022-01-19 10:58:32 +00:00
Iulian Moraru d8fce573b5 Backed out 2 changesets (bug 1750089) for causing mochitest failures on browser_webconsole_certificate_messages.js.
Backed out changeset 7ebb345a9293 (bug 1750089)
Backed out changeset 40bd1975208d (bug 1750089)
2022-01-19 04:07:44 +02:00
Dana Keeler e8ae7a370c Bug 1750089 - remove weak certificate signature error console message r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D135943
2022-01-18 23:54:12 +00:00
Henrik Skupin 0eb950d9a0 Bug 1750726 - [devtools] Never enable Marionette for the multi-process browser toolbox process. r=jdescottes
If the browser toolbox is started from a Marionette enabled process,
Marionette should never be started for the browser toolbox process.
If we do as right now the browser toolbox process will immediately
shutdown because Marionette cannot listen on the already in-use
socket port and forces a process shutdown.

Differential Revision: https://phabricator.services.mozilla.com/D136220
2022-01-18 15:57:57 +00:00
Jan Odvarko 21b3090758 Bug 1750190 - [devtools] Fix MDN links in DevTools user docs r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D135992
2022-01-18 12:34:57 +00:00
Oriol Brufau 2ea2ba189e Bug 1688168 - Isolate bidi text in the console. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D135458
2022-01-18 11:47:50 +00:00
Claudia e54f4ec3cc Bug 1744786 - [devtools] Default select the new request that was sent by edit and resend panel r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D135729
2022-01-18 08:23:09 +00:00
Gerald Squelart 18d4946ed0 Bug 1744670 - New feature: "Process CPU Utilization" aka "processcpu" - r=florian,canaltinova
The actual implementation is in the following patch.

Differential Revision: https://phabricator.services.mozilla.com/D133599
2022-01-17 23:01:29 +00:00
Cristian Tuns e30bd08994 Bug 1701439 - correct disabling condition. 2022-01-17 17:43:48 -05:00
Cristian Tuns b83ef4ef99 Backed out changeset 0ba397633624 (bug 1747261) as requested by sparky CLOSED TREE 2022-01-17 14:22:09 -05:00
Hubert Boma Manilla 651cc06518 Bug 1750560 - Update the code to run damp on try r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D136126
2022-01-17 18:18:04 +00:00
Norisz Fay 6b29538a17 Backed out changeset 5284347025e8 (bug 1748621) for causing dt failures on browser_dbg-blackbox.js CLOSED TREE 2022-01-17 17:12:50 +02:00
Hubert Boma Manilla 7dd7e33a94 Bug 1748621 - [devtools] Add tests for blackboxing a source r=nchevobbe
The tests covers most of the blackbox functionality
Notably it covers issues fixed in D135393 and D135614

Differential Revision: https://phabricator.services.mozilla.com/D135496
2022-01-17 14:01:13 +00:00
Alexandre Poirot 94728aa1d9 Bug 1749527 - [devtools] Setup blackboxing information as a SessionData. r=bomsy,devtools-backward-compat-reviewers
This helps:
* registering blackboxing before the page starts loading.
  So that blackboxing better work if we break early during the page load.
* transfert the blackboxing information only once per URL instead of once per source actor.
  We now communicate the ranges once to the BlackboxingActor.
  Also, we can pass a list of ranges instead of range per range.

Differential Revision: https://phabricator.services.mozilla.com/D135614
2022-01-17 13:50:12 +00:00
Nicolas Chevobbe 20feb9a6d2 Bug 1748620 - [devtools] Update "Ignore Source" icon and ignored lines background. r=bomsy.
The icon is now a crossed-out file and is displayed in red.
We set the background for ignored line to a red-ish grey that will hopefully
better convey the fact that those lines are ignored.

Differential Revision: https://phabricator.services.mozilla.com/D135974
2022-01-17 13:27:24 +00:00
Emilio Cobos Álvarez b651bfe99a Bug 1744009 - Simplify combobox <select> code. r=mconley,dholbert
With this patch on its own we get some a11y tests failures, but those
are fixed on a later patch.

Combobox select no longer creates frames for its <options>, nor an
nsListControlFrame. Instead, it computes its right intrinsic size using
the largest size of the options. This is better, because we render the
option text using the select style so if the select and option styles
are mismatched it'd cause changes in the size of the select when text
changes. See the following in a build without the patch, for example:

  <select>
    <option>ABC</option>
    <option style="font-size: 1px">Something long</option>
  </select>

This seems like a rather obscure case, but it's important to get it
right, see bug 1741888.

With this patch we use the same setup in content and parent processes
(this needs bug 1596852 and bug 1744152). This means we can remove a
bunch of the native view and popup code in nsListControlFrame. A couple
browser_* tests are affected by this change and have been tweaked
appropriately (the changes there are trivial).

Not creating an nsListControlFrame for dropdown select means that we
need to move a bunch of the event handling code from nsListControlFrame
to a common place that nsComboboxControlFrame can also use. That place
is HTMLSelectEventListener, and I think the setup is much nicer than
having the code intertwined with nsListControlFrame. It should be
relatively straight-forward to review, mostly moving code from one part
to another.

Another thing that we need to do in HTMLSelectEventListener that we
didn't use to do is listening for DOM mutations on the dropdown. Before,
we were relying on changes like text mutations triggering a reflow of
the listcontrolframe, which also triggered a reflow of the
comboboxcontrolframe, which in turn updated the text of the anonymous
content. Now we need to trigger that reflow manually.

There are some further simplifications that can be done after this
lands (cleanup naming of openInParentProcess and so on, among others),
but I'd rather land this first (after the merge of course) and work on
them separately.

Differential Revision: https://phabricator.services.mozilla.com/D132719
2022-01-17 11:10:05 +00:00
Marian-Vasile Laza 35a88d897e Backed out 2 changesets (bug 1744009) for causing reftest failures on select-3.html.
Backed out changeset 3e44e31d3d12 (bug 1744009)
Backed out changeset 619389788775 (bug 1744009)
2022-01-17 11:14:27 +02:00
Nicolas Chevobbe 90b92483e3 Bug 1750182 - [devtools] Clear FontHighlighter reference on will-navigate. r=jdescottes.
This will cause a new highlighter to be created when onToggleFontHighlight
is called next.
Ideally, we wouldn't have a reference to the highlighter as this is probably
not working for Fission, and we would use the HighlightersOverlay like the
other inspector panel, but that probably requires its own bug.
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D135998
2022-01-17 08:02:38 +00:00
Emilio Cobos Álvarez a8d469a8d0 Bug 1744009 - Simplify combobox <select> code. r=mconley,dholbert
With this patch on its own we get some a11y tests failures, but those
are fixed on a later patch.

Combobox select no longer creates frames for its <options>, nor an
nsListControlFrame. Instead, it computes its right intrinsic size using
the largest size of the options. This is better, because we render the
option text using the select style so if the select and option styles
are mismatched it'd cause changes in the size of the select when text
changes. See the following in a build without the patch, for example:

  <select>
    <option>ABC</option>
    <option style="font-size: 1px">Something long</option>
  </select>

This seems like a rather obscure case, but it's important to get it
right, see bug 1741888.

With this patch we use the same setup in content and parent processes
(this needs bug 1596852 and bug 1744152). This means we can remove a
bunch of the native view and popup code in nsListControlFrame. A couple
browser_* tests are affected by this change and have been tweaked
appropriately (the changes there are trivial).

Not creating an nsListControlFrame for dropdown select means that we
need to move a bunch of the event handling code from nsListControlFrame
to a common place that nsComboboxControlFrame can also use. That place
is HTMLSelectEventListener, and I think the setup is much nicer than
having the code intertwined with nsListControlFrame. It should be
relatively straight-forward to review, mostly moving code from one part
to another.

Another thing that we need to do in HTMLSelectEventListener that we
didn't use to do is listening for DOM mutations on the dropdown. Before,
we were relying on changes like text mutations triggering a reflow of
the listcontrolframe, which also triggered a reflow of the
comboboxcontrolframe, which in turn updated the text of the anonymous
content. Now we need to trigger that reflow manually.

There are some further simplifications that can be done after this
lands (cleanup naming of openInParentProcess and so on, among others),
but I'd rather land this first (after the merge of course) and work on
them separately.

Differential Revision: https://phabricator.services.mozilla.com/D132719
2022-01-16 23:31:22 +00:00
Claudia 4650e8c828 Bug 1745383 - [devtools] Adds basic functionality for the new HTTP Custom request panel r=bomsy
Depends on D135241

Differential Revision: https://phabricator.services.mozilla.com/D135039
2022-01-14 22:33:59 +00:00
Alexandre Poirot 65cecb5a83 Bug 1749769 - [devtools] Lazy load target legacy listeners. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D135832
2022-01-14 17:03:35 +00:00
Alexandre Poirot 3c7dc514f2 Bug 1749769 - [devtools] Lazy load all resource legacy listeners. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D135831
2022-01-14 17:03:35 +00:00
Alexandre Poirot 719c84fb16 Bug 1749769 - [devtools] Lazy load all resource transformers. r=nchevobbe
Doing this helps load resource-command module from jest tests
which were throwing when loading the transformers.
And it probably is a small performance improvement.

Differential Revision: https://phabricator.services.mozilla.com/D135719
2022-01-14 17:03:34 +00:00
Alexandre Poirot be162a1fe8 Bug 1569859 - [devtools] Automagically move the toolbox between the original tab we debug and its popups. r=nchevobbe
This is also behind "devtools.popups.debug", to be set to true manually.

This special mode break the old fundamental principal where a given toolbox
is bound to one unique given tab. Now one toolbox starts being shared between
many tabs.

When we select the original tab we debug, or any of its popups opened in distinct tabs,
we will move the toolbox between each of these tabs.
We will have one toolbox instance, one toolbox iframe, which will be moved
around each tab's host. This is somewhat similar to host switching within the same tab.
This is all based on the same trick where we swap the toolbox iframe to another location.

Differential Revision: https://phabricator.services.mozilla.com/D131802
2022-01-14 12:02:25 +00:00
Alexandre Poirot e515c00f2a Bug 1569859 - [devtools] Fix SourceActor's url having stack trace in it. r=nchevobbe
Debugger.Source.url attribute may be of the form:
   "http://example.com/foo line 10 > inlineScript"
because of the following function `js::FormatIntroducedFilename`:
https://searchfox.org/mozilla-central/rev/253ae246f642fe9619597f44de3b087f94e45a2d/js/src/vm/JSScript.cpp#1816-1846
This isn't so easy to reproduce, but in next changeset, browser_dbg-breakpoints-popup.js's testPausedInTwoPopups covers this

Differential Revision: https://phabricator.services.mozilla.com/D135145
2022-01-14 12:02:25 +00:00
Alexandre Poirot b42e2fdedc Bug 1569859 - [devtools] Always return sync content when using SourcesManager.urlContents with partial=true. r=nchevobbe
With popup debugging (next patches), we trigger a race condition in this code
where `SourcesManager.urlContents` is called *after* `devtools-html-content` is fired.
i.e. after the HTML document is parsed.
This lead to return an async promise instead of an immediate value.
This confuses `SourceActor._getStartLineColumnDisplacement` which no longer apply breakpoints right away.
We miss early breakpoint support for popups.

This isn't easy to reproduce beyond popup debugging,
in next changeset, browser_dbg-breakpoints-popup.js's testPausedByBreakpoint covers this.

Differential Revision: https://phabricator.services.mozilla.com/D135144
2022-01-14 12:02:25 +00:00
Alexandre Poirot 8f7f623182 Bug 1569859 - [devtools] Spawn WindowGlobal targets for popup opened by the currently debugged tab r=nchevobbe,devtools-backward-compat-reviewers
For now, we only do that when "devtools.popups.debug" is manually set to true.

This is introducing some complexity in the way we filter out the WindowGlobal
we should consider or not. Before this patch it was quite straightforward.
We accepted all WindowGlobal's matching the tab's `browserId`.
Now we also accept the WindowGlobal whose `opener`'s `browserId` matches.

With this patch only, popups start appearing in the iframe dropdown.
You still have to manually switch to the popup via the dropdown to debug it in the inspector or console.
In the debugger, you will already start seeing the popup source and break on it.

Differential Revision: https://phabricator.services.mozilla.com/D133350
2022-01-14 12:02:24 +00:00
Nicolas Chevobbe f1670e6b04 Bug 1737972 - [devtools] Remove usage of lodash fromPairs/toPairs from debugger. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D135709
2022-01-14 11:22:16 +00:00
Nicolas Chevobbe c70fae1218 Bug 1737985 - [devtools] Remove lodash sortBy usage. r=bomsy.
This patch replaces sortBy calls by good old Array#sort.

Differential Revision: https://phabricator.services.mozilla.com/D135601
2022-01-14 11:22:16 +00:00
Nicolas Chevobbe 647c857c5f Bug 1749550 - [devtools] Add distinct style to event badge in markup view when an event listener is disabled. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D135680
2022-01-14 10:21:14 +00:00
Claudia f6d60d9cd8 Bug 1745383 - [devtools] Clean up the selected request reducer and adds a new selector to get clicked request r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D135241
2022-01-14 10:04:56 +00:00
Hubert Boma Manilla c150b0a2c0 Bug 1746368 - [devtools] Add blackbox checks for specfic paused frame location lines r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D135393
2022-01-12 23:44:19 +00:00
Nicolas Chevobbe eec59321db Bug 1492497 - [devtools] Add a way to disable (and re-enable) event listener for a given node. r=ochameau,devtools-backward-compat-reviewers,bomsy.
This patch adds a checkbox at the end of each event listeners in the EventTooltip,
which allow the user to disable/re-enable a given event listener.

This is done by managing a Map of nsIEventListenerInfo object in the NodeActor,
which we populate from `getEventListenerInfo`. Each `nsIEventListenerInfo` is
assigned a generated id, which can then be used to call the new NodeActor
methods, `(enable|disable)EventListener`.

We don't support disabling jquery/React event listeners at the moment, so we
display the checkbox for them as well, but disabled.

Differential Revision: https://phabricator.services.mozilla.com/D135133
2022-01-12 18:36:23 +00:00
Hubert Boma Manilla 5eb7f48c3c Bug 1748618 - [devtools] Add blackbox line context menu item r=nchevobbe
This patch adds context menu item to ignore single lines in the editor and in the gutter

Differential Revision: https://phabricator.services.mozilla.com/D135116
2022-01-12 14:26:31 +00:00
Cristian Tuns 52254e1b6b Backed out changeset 5a82b7a2951e (bug 1492497) for causing leaks CLOSED TREE 2022-01-12 09:29:06 -05:00
Alexandre Poirot dc913e4b3e Bug 1749512 - [devtools] Create all SessionContext objects from a single module. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D135603
2022-01-12 13:33:20 +00:00
Nicolas Chevobbe a232d2448c Bug 1492497 - [devtools] Add a way to disable (and re-enable) event listener for a given node. r=ochameau,devtools-backward-compat-reviewers,bomsy.
This patch adds a checkbox at the end of each event listeners in the EventTooltip,
which allow the user to disable/re-enable a given event listener.

This is done by managing a Map of nsIEventListenerInfo object in the NodeActor,
which we populate from `getEventListenerInfo`. Each `nsIEventListenerInfo` is
assigned a generated id, which can then be used to call the new NodeActor
methods, `(enable|disable)EventListener`.

We don't support disabling jquery/React event listeners at the moment, so we
display the checkbox for them as well, but disabled.

Differential Revision: https://phabricator.services.mozilla.com/D135133
2022-01-12 12:42:48 +00:00
Neil Deakin 5f1ff58926 Bug 371900, remove more now-unneeded empty oncommand attributes, r=bgrins,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D135243
2022-01-11 20:02:30 +00:00
Alexandre Poirot 83e6733608 Bug 1749519 - [devtools] Prevent exception when reloading a page while having devtools opened. r=nchevobbe
Unfortunately, I haven't find any useful attribute on JSWindowActorChild/WindowGlobalChild/BrowsingContext
to detect that things are destroyed, or to be destroyed and avoid calling sendAsyncMessage,
or detect in the exception handler that we got destroyed.

So I'm falling back to ignore the exception based on its message...

Differential Revision: https://phabricator.services.mozilla.com/D135608
2022-01-11 16:16:33 +00:00
Nicolas Chevobbe 19bf4f97d1 Bug 1749449 - [devtools] Cleanup hasNativeConsoleAPI state through the codebase. r=jdescottes,devtools-backward-compat-reviewers.
This removes all the mention of this property which aren't
actually used to display the warning message in the end.

Differential Revision: https://phabricator.services.mozilla.com/D135587
2022-01-11 15:17:24 +00:00
Nicolas Chevobbe 4b0411240e Bug 1749123 - [devtools] Include hasNativeConsoleAPI in documentEvent. r=jdescottes,devtools-backward-compat-reviewers.
In the Browser Console, document-event resources are retrieved from a
legacy listener built on top of the documentEvent event, sent by the
webconsole actor.
documentEvent wasn't including hasNativeConsoleAPI, and we were displaying
a misleading overriden console API message there.
This patch fixes this and adds a test case to make sure we don't regress.
Funnily, the mochitest test harness _does_ override the global's console
property, and we have to reset it in the test to make sure the warning message
is not displayed.

Differential Revision: https://phabricator.services.mozilla.com/D135585
2022-01-11 15:17:23 +00:00
Nicolas Chevobbe 4b03a1cb7a Bug 1749025 - [devtools] Re-generate debugger bundles. r=ochameau.
Looks like some past commits had impact on bundles, let's update them.

Differential Revision: https://phabricator.services.mozilla.com/D135360
2022-01-11 12:54:40 +00:00
Randell Jesup cae53dc9cc WIP: Bug 1747261: enable ServiceWorker process-isolation for all domains r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D134505
2022-01-11 11:48:48 +00:00
James Graham 1501d682e7 Bug 1748845 - Update source-relative links in devtools docs, r=firefox-source-docs-reviewers,Honza,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D135382
2022-01-11 10:48:20 +00:00
Kershaw Chang f159addb13 Bug 1741425 - Enable more xpcshell tests with socket process, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D134484
2022-01-11 09:50:14 +00:00
Kershaw Chang 5d806765a0 Bug 1741425 - Enable more mochitest with socket process, r=ahal,webdriver-reviewers,preferences-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D134485
2022-01-11 09:49:45 +00:00
Alexandre Poirot b3b44589a8 Bug 1745240 - [devtools] Factorize some more code around isBrowsingContextPartOfContext. r=nchevobbe,jdescottes
Track all code which may filter BrowsingContext or WindowGlobal in the server codebase
in order to use a unique filtering method.

Differential Revision: https://phabricator.services.mozilla.com/D134423
2022-01-10 17:42:10 +00:00
Alexandre Poirot 6343e9ad93 Bug 1745240 - [devtools] Use only one method to filter both BrowsingContext and WindowGlobals. r=nchevobbe,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D135098
2022-01-10 17:42:09 +00:00
Alexandre Poirot d2db0a255a Bug 1745240 - [devtools] Unify target helpers and JS Window actors to use a shared method to filter BrowsingContext/WindowGlobal's. r=nchevobbe,jdescottes
Popup debugging (bug 1569859) will force to revisit how we filter out the BrowsingContext
that are meant to be debugged. We won't only accept BrowsingContext based on their browserId.
This would force us to carefuly review all the codes where we filter BrowsingContexts.
And if we later have to tweak this, do this again.

It would be nice to have a unique method to filter things out.
It will also be beneficial once we add new debuggable contexts like workers
as we would only have to tweak this method.

For now, this patch focuses only on Target helpers and JSWindowActor's,
but I'll followup to other server modules.

Note that I'm changing the behavior of getAllRemoteBrowsingContexts
in order to also return the top browsing context by default.
We were having a few places where we were re-adding it after,
but that's not trivial. It is easier to remove it in the rare function that need that.

Differential Revision: https://phabricator.services.mozilla.com/D134422
2022-01-10 17:42:09 +00:00
Alexandre Poirot f64039933c Bug 1745240 - [devtools] Move WatcherActor.isServerTargetSwitchingEnabled into session's context. r=nchevobbe,jdescottes
This boolean helps know for which BrowsingContext we should create a target or track resources.
So that it is part of what defines the context we should debug and will be handy to have
in all filtering functions we use to filter browsing context or platform objects.

Differential Revision: https://phabricator.services.mozilla.com/D134421
2022-01-10 17:42:08 +00:00
Greg Tatum 81b009eef2 Bug 1580599 Add a Fluent string helper to shared-head.js - r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D135358
2022-01-10 17:09:17 +00:00
Greg Tatum 302855c2a4 Bug 1580599 - Add pseudo-locale configuration to the browser toolbox; r=platform-i18n-reviewers,devtools-reviewers,fluent-reviewers,nchevobbe,dminor
This commit adds support for setting the pseudo-locale for the browser
UI directly from the Browser Toolbox. This places the icons in the same
place as the "Disable Popup Autohide" command. This will make it easier
for Firefox developers to test that their UI is properly localized.

The SVGs were optimized for size using an optimizer that dropped the
path precision and any extra tags. I tested that they work correctly in
both light and dark modes.

Pseudo-localization is documented here:
https://firefox-source-docs.mozilla.org/l10n/fluent/tutorial.html#pseudolocalization

After this patch lands I'll follow-up with updating that documentation.

Differential Revision: https://phabricator.services.mozilla.com/D134420
2022-01-10 17:09:17 +00:00
Greg Tatum c6eeab3adf Bug 1580599 - Migrate DevTools toolbox meatball menu to fluent; r=devtools-reviewers,fluent-reviewers,nchevobbe,flod
Differential Revision: https://phabricator.services.mozilla.com/D134419
2022-01-10 17:09:16 +00:00
Nicolas Chevobbe 260704f2d1 Bug 1748589 - [devtools] Fix event listener breakpoints toggling. r=bomsy.
In target-actor-mixin, we were calling `setActiveEventBreakpoints` only with the
new events we were receiving, which mean if the user was clicking a first event in
the UI, and then a second one, only the second one would have a functioning event breakpoint.
Also, we were not handling removing event breakpoints at all.
We're adding `(add|remove)EventBreakpoints` to the thread actor so it's easier
to update the list of event breakpoints.

The existing event breakpoints test is modified to ensure we don't regress such behaviour.

The call to `setEventListenerBreakpoints` is moved before dispatch the `UPDATE_EVENT_LISTENERS`
action so we can properly wait for the breakpoint to be set in tests.

Differential Revision: https://phabricator.services.mozilla.com/D135216
2022-01-10 14:10:23 +00:00
Alexandre Poirot 6cd7bcb3bc Bug 1747816 - [devtools] Always use reducer's source's `isOriginal` attribute to know if a source is an original one. r=bomsy
"original" here refers to not being generated.
It overlaps with pretty printed sources, which are considered as original sources.

Differential Revision: https://phabricator.services.mozilla.com/D134751
2022-01-10 13:10:37 +00:00
Oriol Brufau 1da3a93991 Bug 1749013 - Fix browser_jsonview_save_json.js checking disk data too early. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D135446
2022-01-10 10:14:55 +00:00
Sai Hemanth B 8a196d598a Bug 1737968 - Replace lodash difference usage with filter. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D135443
2022-01-10 09:30:10 +00:00
Butkovits Atila 7411a18abf Bug 1701439 - disable browser_jsterm_screenshot_command_warnings.js on Linux_64_opt for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D135439
2022-01-10 06:37:58 +00:00
Alexandre Poirot 618f997097 Bug 1747815 - [devtools] Document sources and source-actors reducers. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D134752
2022-01-09 22:16:50 +00:00
Alexandre Poirot da27f388fa Bug 1747815 - [devtools] Remove unused focusedItem attribute from sources reducer. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D134787
2022-01-09 22:16:50 +00:00
Alexandre Poirot 6c350b4a42 Bug 1747815 - [devtools] Use a single method to create all reducer's source objects. r=bomsy
And better document all types of source objects:
* generated
* source map original sources
* pretty printed sources

As well as source object attributes!

Differential Revision: https://phabricator.services.mozilla.com/D134786
2022-01-09 22:16:49 +00:00
criss e2948093fb Backed out 2 changesets (bug 371900) for causing bug 1749182 . CLOSED TREE
Backed out changeset e59035c65af3 (bug 371900)
Backed out changeset 6434bce9c7d4 (bug 371900)
2022-01-09 16:26:02 +02:00
Neil Deakin 64a4726936 Bug 371900, remove more now-unneeded empty oncommand attributes, r=bgrins,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D135243
2022-01-08 18:07:21 +00:00
Julian Descottes f8849e5bf5 Bug 1748405 - [devtools] Update all storage cache tests to properly wait for setup and clear steps r=Honza
Depends on D135054

Differential Revision: https://phabricator.services.mozilla.com/D135314
2022-01-07 18:08:39 +00:00
Julian Descottes 849351229b Bug 1748405 - [devtools] Wait for caches and cell count in browser_storage_cache_overflow r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D135054
2022-01-07 18:08:38 +00:00
Hubert Boma Manilla 471efce1da Bug 1747494 - [devtools] Should display only one request per URL for images from the cache r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D135038
2022-01-07 15:18:48 +00:00
Hubert Boma Manilla 985ea76fd5 Bug 1747494 - [devtools] Small cleanups r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D135037
2022-01-07 15:18:47 +00:00
Oriol Brufau fa4f6cdf2d Bug 1748688 - Improve browser_jsonview_save_json.js. r=Honza
Avoids using context menu, affected by bug 1478596, so that the test can be
re-enabled in Linux WebRender.

Replaces deprecated OS.File with IOUtils.

Adds try..catch as an attempt to investigate timeouts like bug 1650268.

Adds some extra checks, and some refactorings.

Differential Revision: https://phabricator.services.mozilla.com/D135146
2022-01-07 12:36:25 +00:00
wartmanm 93d857cb3c Bug 1653779 - Lazily create parent map r=nchevobbe,bomsy
parentMap appears to only be used when pressing the left arrow key to navigate
to the parent folder in the source tree.  If this is too slow it could be
replaced with a traverseTree search.

Differential Revision: https://phabricator.services.mozilla.com/D115318
2022-01-07 09:54:21 +00:00
nchevobbe 6f6df94e79 Bug 1748864 - [devtools] Update webidl-deprecated-list.js. r=bomsy.
The file was generated via devtools/shared/webconsole/GenerateDataFromWebIdls.py.

Differential Revision: https://phabricator.services.mozilla.com/D135235
2022-01-07 08:35:37 +00:00
Nicolas Chevobbe fc7bec2470 Bug 1748628 - [devtools] Remove event listener level in the EventTooltipHelper. r=ochameau.
The information it provides is unclear and I don't see how this could be valuable.
We take this opportunity to move the tags before the "capturing" label to get
better alignment between mixed events (e.g. regular and React ones).

Differential Revision: https://phabricator.services.mozilla.com/D135130
2022-01-07 07:50:03 +00:00
Nicolas Chevobbe 3a498acde6 Bug 1748631 - [devtools] Refactor Node event listeners server codepath. r=ochameau.
- Remove `NodeActor#getEventListeners` which was simply a proxy to `EventCollector#getEventListeners`
- Change signature of `EventCollector#processHandlerForEvent` to make code easier to follow

Differential Revision: https://phabricator.services.mozilla.com/D135128
2022-01-07 07:50:02 +00:00
Nicolas Chevobbe face640fe2 Bug 1748431 - [devtools] Remove unnecessary setEventTooltip function. r=ochameau.
The function was only creating an EventTooltip instance, so we can directly modify
the only call site to do the same thing.

Since the EventTooltip isn't responsible for showing the tooltip itself, and given
that the consumer code already does some work when the tooltip gets hidden, we
let the consumer call EventTooltip#destroy instead of having the EventTooltip
register the event listener on the tooltip.

Differential Revision: https://phabricator.services.mozilla.com/D135127
2022-01-07 07:50:02 +00:00
Nicolas Chevobbe a98fcc09e6 Bug 1748431 - [devtools] Fold EventTooltip#init into the constructor. r=ochameau.
The method was only called from one place, just after creating the object.

Differential Revision: https://phabricator.services.mozilla.com/D135042
2022-01-07 07:50:02 +00:00
Nicolas Chevobbe 4b2a8b0d23 Bug 1748431 - [devtools] Turn EventTooltip into an ES class. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D135041
2022-01-07 07:50:01 +00:00
Jonathan Watt 2a9a0b264a Bug 1702501 - Remove print.tab_modal.enabled pref and old frontend print preview code. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D134699
2022-01-06 18:55:38 +00:00
Julian Descottes 759d0d82f3 Bug 1746334 - [devtools] node tests: Suffix yarn command with .cmd on Windows r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D135051
2022-01-06 16:49:40 +00:00
Andreas Pehrson 159966b6d1 Bug 1746347 - Add ipcmessages feature to the profiler's media preset. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D135026
2022-01-05 15:26:24 +00:00
Andreas Pehrson 34655d82ae Bug 1746347 - Simplify the profiler's media preset's thread-set. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D135025
2022-01-05 15:26:23 +00:00
Julian Descottes 4e06581e39 Bug 1720371 - [devtools] Fix eyedropper on pages with CSP r=nchevobbe
Load the png dataURL in a blob instead of an image to avoid CSP issues.

Differential Revision: https://phabricator.services.mozilla.com/D134969
2022-01-05 13:46:22 +00:00
Butkovits Atila a2b23f44a9 Bug 1703465 - disable browser_rules_color_scheme_simulation.js on Win_64_opt for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D135112
2022-01-05 13:29:33 +00:00
Emilio Cobos Álvarez 24dc10c691 Bug 1748174 - Remove touch-action pref. r=hiro
It's been enabled by default since ~forever.

Differential Revision: https://phabricator.services.mozilla.com/D134935
2022-01-05 12:28:07 +00:00
Butkovits Atila 64c8533f75 Backed out 7 changesets (bug 1746361, bug 1748280, bug 1746347) for causing failures at browser_interaction-between-interfaces.js. CLOSED TREE
Backed out changeset eccba94506f0 (bug 1748280)
Backed out changeset baf39ae53772 (bug 1748280)
Backed out changeset 775843562f7e (bug 1748280)
Backed out changeset 0987c68e9683 (bug 1748280)
Backed out changeset 58dd008520da (bug 1746361)
Backed out changeset 6f9e800877a6 (bug 1746347)
Backed out changeset f78e794a9c2f (bug 1746347)
2022-01-05 13:53:57 +02:00
Andreas Pehrson 5124203ce6 Bug 1746347 - Add ipcmessages feature to the profiler's media preset. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D135026
2022-01-05 10:54:20 +00:00
Andreas Pehrson d61adf4a7f Bug 1746347 - Simplify the profiler's media preset's thread-set. r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D135025
2022-01-05 10:54:19 +00:00
Joaquín Serna fab9432277 Bug 1737971 - Remove lodash flatten/flattenDeep usage r=nchevobbe
Depends on D135081

Differential Revision: https://phabricator.services.mozilla.com/D135092
2022-01-05 08:58:46 +00:00
Joaquín Serna 45e4c02ec6 Bug 1737983 - Remove lodash `remove` usage r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D135081
2022-01-05 08:58:46 +00:00
Alexandre Poirot a8f78a3769 Bug 1747804 - [devtools] Fix har export when some requests can't be retrieved. r=nchevobbe
HAR export was still producing empty har files if any of the request
currently displayed in the netmonitor can't be completely retrieved.
This includes all lazy data. But if any request has been destroyed in the server
fetching any lazy data will throw.

Differential Revision: https://phabricator.services.mozilla.com/D134789
2022-01-04 21:37:11 +00:00
Alexandre Poirot e3c4a93028 Bug 1747805 - [devtools] Fix NETWORK_EVENT's innerWindowID and clear requests of iframe when they get destroyed. r=nchevobbe
This also fixes the targetFront attribute for NETWORK_EVENT resources of iframes.

Differential Revision: https://phabricator.services.mozilla.com/D134788
2022-01-04 21:37:11 +00:00
Oriol Brufau 6b44c1166c Bug 1747542 - Avoid intermittent failure in browser_jsonview_expand_collapse.js. r=Honza
It seems synthesizeMouseAtCenter() caused the problem.
clickJsonNode() was fixed in bug 1739320.

Differential Revision: https://phabricator.services.mozilla.com/D134991
2022-01-04 12:06:19 +00:00
Alexandre Poirot 6df6f6816a Bug 1651527 - [devtools] Remove now unused Toolbox's switch-target event. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D134776
2022-01-04 10:27:43 +00:00
Julian Descottes e01a3953b9 Bug 1745242 - [devtools] Cache not showing more than 50 items r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D134946
2022-01-03 15:51:52 +00:00
Nicolas Chevobbe 9384bbbb92 Bug 1737973 - [devtools] Remove lodash groupBy usage. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D134942
2022-01-03 14:17:59 +00:00
Oriol Brufau 70dff99a81 Bug 1720898 - Reenable most JSON Viewer tests in Linux. r=Honza
Only skip browser_jsonview_save_json.js because of bug 1478596.

Differential Revision: https://phabricator.services.mozilla.com/D134674
2022-01-03 13:38:39 +00:00
Nicolas Chevobbe 0c5fb61788 Bug 1737981 - [devtools] Remove lodash range usage. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D134617
2022-01-03 13:25:48 +00:00
Nicolas Chevobbe 652751c863 Bug 1737995 - [devtools] Remove lodash zip usage. r=bomsy.
Differential Revision: https://phabricator.services.mozilla.com/D134615
2022-01-03 13:25:47 +00:00
Nicolas Chevobbe 0577bf26d6 Bug 1747404 - [devtools] Remove unused timings.js. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D134614
2022-01-03 13:25:47 +00:00
Oriol Brufau 80d8efe286 Bug 1739320 - Replace synthesizeMouseAtCenter() with click() in clickJsonNode(). r=Honza
This approach seemed to fix bug 1734940.

Differential Revision: https://phabricator.services.mozilla.com/D134660
2022-01-03 13:24:29 +00:00
Emilio Cobos Álvarez 6b5a53d800 Bug 1747595 - Make color-adjust an alias of print-color-adjust as per spec. r=jwatt
Differential Revision: https://phabricator.services.mozilla.com/D134779
2021-12-29 21:52:25 +00:00
Oriol Brufau add8020c67 Bug 1746303 - Fix browser_jsonview_expand_collapse.js test. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D134094
2021-12-24 06:57:22 +00:00
Daisuke Akatsuka 2696bcc736 Bug 1746832: Update MDN compat data. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D134379
2021-12-24 00:49:34 +00:00
Nicolas Chevobbe eb4b5c901f Bug 1737970 - [devtools] Refactor getBabelFrameIndexes so it does not use lodash. r=jdescottes.
The function was slightly simplified and shouldn't
iterate on frames as much as before.

Differential Revision: https://phabricator.services.mozilla.com/D134612
2021-12-23 15:56:31 +00:00
criss 11de1afc51 Backed out changeset 1c006c34b55d (bug 1746832) for causing failures on browser_rules_css-compatibility-toggle-rules.js 2021-12-23 14:45:34 +02:00
Daisuke Akatsuka 7cfcfad328 Bug 1746832: Update MDN compat data. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D134379
2021-12-23 11:52:55 +00:00
colin_czb 36e240b0dd Bug 1736412 - [devtools] Fix 'Add new rule' button when style node is deleted or moved. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D134447
2021-12-23 06:36:15 +00:00
Gijs Kruitbosch 65e85facbc Bug 1719939 - remove other mentions of browser.proton.enabled, r=jaws
Depends on D134310

Differential Revision: https://phabricator.services.mozilla.com/D134311
2021-12-22 21:41:41 +00:00
Sandor Molnar b1e67de63f Backed out changeset cbfea5546158 (bug 1746832) for causing dt failures. CLOSED TREE 2021-12-22 20:39:02 +02:00
Daisuke Akatsuka 3c2566042c Bug 1746832: Update MDN compat data. r=Honza
Differential Revision: https://phabricator.services.mozilla.com/D134379
2021-12-22 14:51:04 +00:00
Alexandre Poirot f1d437953a Bug 1745238 - [devtools] Use context in NetworkEventActor to know if we are debugging a tab. r=nchevobbe
This is more reliable check and it feels more common type of check
we already do elsewhere.
It also helps expose less convoluted objects to NetworkEventActor and so simplify it.

Differential Revision: https://phabricator.services.mozilla.com/D133474
2021-12-22 13:17:12 +00:00
Alexandre Poirot 2435b208e5 Bug 1745238 - [devtools] Use watcher actor context or target actor to filter out network event requests r=nchevobbe
This will help always use context to filter out resources.

Differential Revision: https://phabricator.services.mozilla.com/D133473
2021-12-22 13:17:11 +00:00
Alexandre Poirot 58dffa20e2 Bug 1745238 - [devtools] Pass watcher actor's `context` down to WindowGlobalTargetActor r=nchevobbe
This will be useful in next patch to know what is the overall debugged context.
We can finally know if that's the browser context/toolbox from almost any part of the server codebase!

Differential Revision: https://phabricator.services.mozilla.com/D133472
2021-12-22 13:17:11 +00:00
Alexandre Poirot d7e364c932 Bug 1745238 - [devtools] Rename WatcherActor and SessionData "context" to "sessionContext". r=nchevobbe
In prevision of a broader use of this existing "context" object,
I'm renaming it in order to make this important object clearer and more easily identifiable.

SessionContext object defines what we are debugging (everything, only one tab, an addon,...)
and so controls which platform data we should expose back to the client.

Differential Revision: https://phabricator.services.mozilla.com/D134411
2021-12-22 13:17:11 +00:00
Alexandre Poirot 5d0f3d320e Bug 1746952 - [devtools] Avoid notifying about same-process storage values when EFT is enabled. r=nchevobbe
We were notifying about same-process storage values twice.
Once with the top document target and another time via the iframe target.
This was probably invisible from the UI. We were probably only updating things twice without any visible breakage.

But this also highlighted that the test was quite wrong.
It was only asserting about the last resource for each storage type.
Luckily, the last resource to be notified was the one from the top document.
So that it contained all the storage values about all the iframes.

When I fix EFT implementation, now, iframe data is only visible in the iframe's related storage resource.
I tweaked the test to correctly assert data against the many resources for a single storage type.

Differential Revision: https://phabricator.services.mozilla.com/D134378
2021-12-22 09:59:09 +00:00
Alexandre Poirot eb9c8a8584 Bug 1746952 - [devtools] Fix targetFront attribute of all storage resources. r=nchevobbe
Most children of the target fronts are target scoped actors,
like console, inspector, thread,...
All these target scoped actor's fronts are created via:
https://searchfox.org/mozilla-central/rev/7d17fd1fe9f0005a2fb19e5d53da4741b06a98ba/devtools/shared/protocol/types.js#539-540
And so aren't going throught this `types.addActorType` inner function.

So fix the targetFront attribute for all fronts created via this `read` method
where the immediate parent is the targetFront.

Differential Revision: https://phabricator.services.mozilla.com/D134377
2021-12-22 09:59:09 +00:00
Alexandre Poirot 589bdcc457 Bug 1746952 - [devtools] Acknowledge the distinct storage resource for each target in browser_storage_dynamic_windows.js. r=nchevobbe
This test was brittle as it was assuming that only one resource was notified per storage type.
But this wasn't the case since fission or EFT!
We were lucky that the assertion were correct only against the latest resource
and not against the aggregate of the many resource (one per target).

Differential Revision: https://phabricator.services.mozilla.com/D134376
2021-12-22 09:59:08 +00:00
Gijs Kruitbosch b095cb0969 Bug 1747065 - remove plugin.load_flash_only setters which are no-ops r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D134398
2021-12-21 14:34:48 +00:00
Julian Descottes e7ba7fca64 Bug 1746461 - [devtools] Add mochitest for color scheme simulation and meta color-scheme r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D134306
2021-12-21 12:54:07 +00:00
Alexandre Poirot 40721e174c Bug 1746370 - [devtools] Pass SOURCE resources down to newGeneratedSources. r=nchevobbe
Actually I was wrong in bug 1745795.
This wasn't SourceFront but SOURCE resources, which are SourceActor's form and not a Front.

Let's make it clear and simplify the code some more.
Also stop calling makeSourceId from create.js
as we already have the reducer's source id via the reducer's source-actor's source attribute.

Differential Revision: https://phabricator.services.mozilla.com/D134006
2021-12-21 09:15:32 +00:00
Alexandre Poirot f326ca5ca0 Bug 1746370 - [devtools] Remove stringToSourceActorId as this was a workaround for flow. r=nchevobbe
This was only useful when flow was used.

Differential Revision: https://phabricator.services.mozilla.com/D134005
2021-12-21 09:15:32 +00:00
Alexandre Poirot 1c6546e6c4 Bug 1746370 - [devtools] Simplify SourceQueue as it only handles original sources. r=nchevobbe
SourceQueue used to throttle both generated and original sources.
But since we migrated to ResourceCommand, and it comes with a builtin throttling,
we only use SourceQueue for original sources.

So we can acknowledge that and simplify this a bit.

Differential Revision: https://phabricator.services.mozilla.com/D134004
2021-12-21 09:15:31 +00:00
Alexandre Poirot 6dad0dbd64 Bug 1746366 - [devtools] Remove outdated backward compat code from debugger frontend. r=nchevobbe
* SourceActor's introductionUrl has been removed in Fx77 in bug 1607639.
* getBreakableLines has been added in Fx68 in bug 1537779.
* getAvailableEventBreakpoints changed to return an array in Fx69 in bug 1549999.

Differential Revision: https://phabricator.services.mozilla.com/D134003
2021-12-21 09:15:31 +00:00
Gerald Squelart 1144535227 Bug 1729815 - Remove unnecessary profiler feature "threads" - r=julienw,perftest-reviewers,AlexandruIonescu
This feature doesn't have any effect anymore.

Differential Revision: https://phabricator.services.mozilla.com/D133860
2021-12-20 21:03:09 +00:00
Emilio Cobos Álvarez c005576535 Bug 1746685 - Fix eye dropper contrast on dark pages. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D134198
2021-12-20 15:25:25 +00:00
Emilio Cobos Álvarez 461f89a0bb Bug 1746683 - Remove hwba since it's not a thing (hwb function supports alpha).
Partially backs out the previous patch.

Differential Revision: https://phabricator.services.mozilla.com/D134256
2021-12-20 02:53:31 +00:00
Sebastian Zartner 87f408eb47 Bug 1743107 - Fixed color incrementation for color functions without commas. r=jdescottes
Color incrementation now also works for color functions following the CSS Color 4 specification, i.e. with spaces as separators and the alpha value separated by a slash.

The test case related to incrementation of color values also got extended to cover this change plus the color functions hsl(), hsla() and hwb().

Differential Revision: https://phabricator.services.mozilla.com/D132993
2021-12-19 12:56:02 +00:00
Sebastian Zartner 3a67d45dd3 Bug 1743107 - Added support for HWB colors. r=jdescottes,kpatenio
This change doesn't cover auto-completion for "hwb" yet because it isn't added automatically when generating the properties-db.js.

Differential Revision: https://phabricator.services.mozilla.com/D132992
2021-12-19 12:56:01 +00:00
Emilio Cobos Álvarez 61ea030cc4 Bug 1746683 - Add hwb/a to devtools autocomplete lists. r=dholbert
The changes to the devtools directory were written automatically via ./mach devtools-css-db

Differential Revision: https://phabricator.services.mozilla.com/D134197
2021-12-18 20:09:29 +00:00
Sandor Molnar e45ac2363d Backed out changeset e9782fd301cc (bug 1746683) for causing mochitest failures in layout/inspector/tests/test_bug877690.html CLOSED TREE 2021-12-18 05:58:39 +02:00
Emilio Cobos Álvarez bd470ae24f Bug 1746683 - Add hwb/a to devtools autocomplete lists. r=dholbert
The changes to the devtools directory were written automatically via ./mach devtools-css-db

Differential Revision: https://phabricator.services.mozilla.com/D134197
2021-12-18 01:09:00 +00:00
Nicolas Chevobbe 4a5cfe7c65 Bug 1745932 - [devtools] Move highlighters.properties to fluent. r=fluent-reviewers,flod,jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D133741
2021-12-17 16:19:04 +00:00
Nicolas Chevobbe f47f462297 Bug 1746150 - [devtools] Reset vertical scroll position when updating HTMLTooltip container. r=jdescottes.
This fixes issues with the iframe dropdown when it overflows and targets are
added/removed.

Differential Revision: https://phabricator.services.mozilla.com/D134039
2021-12-17 16:00:11 +00:00
Nicolas Chevobbe c33cb4b2ec Bug 1743594 - [devtools] Fix browser_styleinspector_tooltip-background-image.js intermittent. r=jdescottes.
Differential Revision: https://phabricator.services.mozilla.com/D134130
2021-12-17 15:52:58 +00:00
Nicolas Chevobbe 997279c94d Bug 1746149 - [devtools] Remove OSX-specific Cmd+G shortcut in debugger. r=jdescottes.
The keyboard shortcut was supposed to move to the next search
result, but was only working on OSX. As you can already cycle
through search results with Enter, and given that Cmd+G only (barely)
work on OSX, it's safe to remove it.

Differential Revision: https://phabricator.services.mozilla.com/D134128
2021-12-17 13:53:55 +00:00
Markus Stange b9622a7b8f Bug 1745978 - Add the ability to fetch source code from disk to the Profiler WebChannel's querySymbolicationApi method. r=canaltinova
This updates profiler-get-symbols to the latest version.
The new /source/v1 entry point was implemented in
edb78205d1

Furthermore, this update also picks up a fix for macOS 12 system library symbolication.

Differential Revision: https://phabricator.services.mozilla.com/D133757
2021-12-17 11:11:48 +00:00
Nicolas Chevobbe 96fd8e5787 Bug 1736183 - [devtools] Add test for reset of node picker hovered node reference. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D133879
2021-12-17 07:18:18 +00:00
Julian Descottes 0b7fd00802 Bug 1736183 - [devtools] Reset hovered node reference when cancelling node picker r=nchevobbe
Quick patch, but needs test coverage

Differential Revision: https://phabricator.services.mozilla.com/D131375
2021-12-17 07:18:17 +00:00
Patrick ab5ce94360 Bug 1743102 Added color-scheme meta tag to remaining about: pages r=Gijs,necko-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D133743
2021-12-17 00:42:23 +00:00
Cristian Tuns 348796281f Backed out changeset f90cb649f371 (bug 1729815) for causing mochitest failures on Mutex_posix.cpp CLOSED TREE 2021-12-16 19:45:55 -05:00
Hubert Boma Manilla 1490eb2f73 Bug 1745940 - [devtools] Implement blackboxing lines UI functionality r=nchevobbe
Basic UI functionality for blackboxing

Enable this feature pref `devtools.debugger.features.blackbox-lines`

This is mainly to gather feeback from the team and webcompat, things
like the selection colors will likely change, maybe we can add a context menu
to the editor gutter as well etc.

Differential Revision: https://phabricator.services.mozilla.com/D132368
2021-12-16 23:53:26 +00:00
Hubert Boma Manilla f1fedb6b37 Bug 1745940 - [devtools] Add blackbox line support for actions and reducers r=ochameau
This patch includes the following:-
- The reducer logic to store the blackbox url and range info matches that on the
  server here https://searchfox.org/mozilla-central/rev/dfc0dea63a16b73078a46b6ae49b2a626b8c11b5/devtools/server/actors/utils/sources-manager.js#289-335
  Note: The client logic supports multiple ranges whhile the server supports one range (maybe we can add support for multiple to the server).
- Added jest tests for some edge cases
- Changed the asyncStore pref from `tabsBlackBoxed` to `blackboxedTabs` for readability ease
  and to avoid and errors as the format of the data stored changes.

  Before: `asyncStore.tabsBlackBoxed = ["foo.com", "bar.com"...]`
  After:  `asyncStore.blackboxedTabs = { "foo.com": [], "bar.com": [range, range, ...] }`


  The range sturcture

  ```
  const range = {
    start: { line: 1, column: 5 },
    end: { line: 3, column: 4 },
  }
  ```

Differential Revision: https://phabricator.services.mozilla.com/D132774
2021-12-16 23:53:26 +00:00
Gerald Squelart c40dcd12b5 Bug 1729815 - Remove unnecessary profiler feature "threads" - r=julienw,perftest-reviewers,AlexandruIonescu
This feature doesn't have any effect anymore.

Differential Revision: https://phabricator.services.mozilla.com/D133860
2021-12-16 23:46:18 +00:00
Alexandre Poirot 4aac2bc737 Bug 1740116 - [devtools] Fix fetching extra data about cancelled navigation request. r=nchevobbe
These exception may happen when some pending request from the previous page
are received lated by the netmonitor, which tries to fetch extra data about these
old requests.
On the server side, these requests are destroyed when devtools.netmonitor.persistlog=false.
(which is the default behavior)

Differential Revision: https://phabricator.services.mozilla.com/D132495
2021-12-16 21:59:09 +00:00
Butkovits Atila c408716df0 Backed out changeset f2f23757c34f (bug 1743102) for causing node failures. CLOSED TREE 2021-12-16 19:23:43 +02:00
Patrick 7aeecb4714 Bug 1743102 Added color-scheme meta tag to remaining about: pages r=Gijs,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D133743
2021-12-16 16:30:30 +00:00
Tom Ritter 47d1ab15d8 Bug 1746239: Load netmonitor devtools scripts via an absolute uri rather than relative r=Honza
Depends on D133931

Differential Revision: https://phabricator.services.mozilla.com/D133932
2021-12-16 15:24:54 +00:00
Alexandre Poirot 6c77e27255 Bug 1689459 - [devtools] Enable server side NETWORK resources for the browser toolbox. r=bomsy
In this patch we need to ensure that all NETWORK resources work correctly for the browser toolbox.

The main fix was to ensure that all Network resources were emitted by browsingContextID set to -1,
otherwise the ResourceCommand may try to lookup for the related target and won't find it.
That's because the browser toolbox uses a unique target for all parent process requests,
and still doesn't use EFT. So same-process iframe should still be debugged by their parent document target.

Also ResourceCommand used isServerTargetSwitchingEnabled on descriptor front,
but for now, only TabDescriptorFront exposes this method.

Differential Revision: https://phabricator.services.mozilla.com/D103770
2021-12-16 14:57:10 +00:00
Alexandre Poirot 5fcf60819d Bug 1689459 - [devtools] Always use matchRequest to filter out channels in the content process. r=bomsy
This watcher wasn't filtering request from http-on-image-cache-response
And request froms http-on-failed-opening-request were using a different filtering code
compared to network-events-stacktraces.js

So now, all network event related resources should be using the exact same filtering.
Then may be filtering by window isn't the best. It might actually be better to filter
by innerWindowId or browsingContextID. But this is another story and thanks
to this match, it will be easier to migrate all these codes to a new filtering.

Also, I had to tweak getWindowForRequest in order to correctly return the window
for the CSS request done in test_network_get.html.
This will probably fix some missing stack trace for some requests like this one!

Differential Revision: https://phabricator.services.mozilla.com/D132989
2021-12-16 14:57:10 +00:00
Jonathan Kew 20ec7ce89f Bug 1746187 - Add CSS support for the hyphenate-character property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D133889
2021-12-16 13:47:55 +00:00
Hubert Boma Manilla 543d221bf6 Bug 1733420 - [devtools] Migrate the remaining tests to http-first r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D133663
2021-12-16 10:03:03 +00:00
Marian-Vasile Laza e3ec8630b1 Backed out 4 changesets (bug 1746187) for causing xpcshell failures on test_css-properties-db.js.
Backed out changeset fa4f889dd0d3 (bug 1746187)
Backed out changeset e3fce2273109 (bug 1746187)
Backed out changeset 6733677ad35d (bug 1746187)
Backed out changeset a4375ff93414 (bug 1746187)
2021-12-16 04:51:13 +02:00
Ting-Yu Lin 8b1e02f532 Bug 1715112 Part 3 - Enable CSS scrollbar-gutter by default. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D133696
2021-12-16 01:01:46 +00:00
Jonathan Kew 83df1246c1 Bug 1746187 - Add CSS support for the hyphenate-character property. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D133889
2021-12-15 23:16:49 +00:00
Marian-Vasile Laza cf9f173039 Backed out 3 changesets (bug 1715112) for causing xpcshell failures on test_css-properties-db.js.
Backed out changeset 6b91412c20e3 (bug 1715112)
Backed out changeset b7cbd5b59fc5 (bug 1715112)
Backed out changeset 9b7d73b6d81e (bug 1715112)
2021-12-16 02:06:25 +02:00
Ting-Yu Lin e2cfa1e52c Bug 1715112 Part 3 - Enable CSS scrollbar-gutter by default. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D133696
2021-12-15 22:40:57 +00:00
Nicolas Chevobbe c2d8af4d9e Bug 1745466 - [devtools] Hide highlighter immediately when picking a node. r=ochameau.
Differential Revision: https://phabricator.services.mozilla.com/D133727
2021-12-15 16:39:34 +00:00
Alexandre Poirot f9dcfd4d71 Bug 1745944 - [devtools] Use new ChromeUtils.getXPCOMErrorName() method to get platform error names. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D133758
2021-12-15 16:12:33 +00:00
Alexandre Poirot ca69083589 Bug 1745944 - [devtools] Make browser_resources_network_events.js generic enough to be used for other test pages. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D133769
2021-12-15 16:12:33 +00:00
Alexandre Poirot 3368fee725 Bug 1745944 - [devtools] Clarify the two tests against ResourceCommand cache for NETWORK_EVENT's. r=nchevobbe
In this test, there is two that are actually dedicated to cover ResourceCommand internal cache
and the precise behavior of ignoreExistingResources: true/false.

I pulled them off in a dedicated test file and tried to simplified them a bit.

Because the server doesn't really support fetch request done before calling watchResources,
this test is a bit hard to understand. So I tried to make it clear via extensive comments.

Then, my goal is to reuse the third and simplier test to extend the coverage of NETWORK_EVENT
with many other assertions.

Differential Revision: https://phabricator.services.mozilla.com/D133768
2021-12-15 16:12:33 +00:00
Alexandre Poirot c7d855b0b4 Bug 1745795 - [devtools] Avoid confusion between "reducer source" and "SourceFront" objects. r=bomsy
I'm also removing the `isBlackBoxed` boolean from source actor in the reducer
in order to ensure we always only use the source reducer one.

And I dropped some comment here and there to help understand where all these sources objects are coming from.

Differential Revision: https://phabricator.services.mozilla.com/D133658
2021-12-15 16:11:23 +00:00
Claudia 1563d9dc45 Bug 1744783 - [devtools] Add new context menu for the New Custom Request panel r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D133649
2021-12-15 15:59:06 +00:00
Claudia 993ac25bd2 Bug 1744782 - [devtools] Add new toolbar button for the New Custom Request panel r=bomsy
This is the first part of this bug, the next patch will include the context menu item

Differential Revision: https://phabricator.services.mozilla.com/D133506
2021-12-15 15:59:05 +00:00
Claudia f90f2e8dc0 Bug 1744790 - [devtools] Add new Edit and resend panel in the left side panel r=bomsy
This patch creates an HTTP Custom request component without functionality, only shows the new panel on the left. Also, it adds a simple test, that will be uptaded as new features are added.

Differential Revision: https://phabricator.services.mozilla.com/D133390
2021-12-15 15:59:05 +00:00
Alexandre Poirot 9650c11691 Bug 1729674 - [devtools] Re-enable browser_aboutdebugging_devtoolstoolbox_navigate_back_forward.js for BFCache. r=nchevobbe
This has been made possible thanks to bug 1675456.

Differential Revision: https://phabricator.services.mozilla.com/D133874
2021-12-15 13:30:57 +00:00
Alexandre Poirot 0f16876834 Bug 1729675 - [devtools] Re-enable browser_aboutdebugging_devtoolstoolbox_navigate_to_url for BFCache. r=nchevobbe
This has been made possible thanks to bug 1675456.

Differential Revision: https://phabricator.services.mozilla.com/D133873
2021-12-15 13:30:56 +00:00
nchevobbe 6072b8f064 Bug 1746142 - [devtools] Fix keyboard shortcut for showing ShortcutsModal on non-OSX OSes. r=ochameau.
The keyboard shortcut was not set properly (and wasn't unset).
A test is added to ensure this works as expected.

Differential Revision: https://phabricator.services.mozilla.com/D133862
2021-12-15 11:22:44 +00:00
Emilio Cobos Álvarez dae5c87696 Bug 1699220 - Add support for the revert-layer keyword. r=boris
This patch looks bigger than it is, but it's mostly because
of plumbing.

To implement revert-layer we need not only the cascade origin of the
declaration, but the whole cascade level, plus also the layer order.

In order to do this, encapsulate these two things inside a 32-bit
`CascadePriority` struct and plumb it through the rule tree and so on.
This allows us to remove the packing and unpacking of CascadeLevel,
though I kept the ShadowCascadeOrder limit for now in case we need to
reintroduce it.

Fix `!important` behavior of layers while at it (implementing it in
`CascadeLevel::cmp`, spec quote included since it was tricky to find)
since some revert-layer tests were depending on it.

The style attribute test is failing now, but follow-up commit fixes
it, see spec issue.

In terms of the actual keyword implementation, it's sort of
straight-forward: We implement revert and revert-layer in a shared
way, by storing the cascade priority that reverted it.

Differential Revision: https://phabricator.services.mozilla.com/D133372
2021-12-14 15:38:34 +00:00
Nicolas Chevobbe 6f823dffcc Bug 1745881 - [devtools] Fix backward-compat comment version number. r=bomsy.
frame.isTopLevel was added in 96, not in 95.

Differential Revision: https://phabricator.services.mozilla.com/D133721
2021-12-14 13:48:15 +00:00
Paul Adenot dd157dc0a0 Bug 1745176 - Add profiler markers to MediaTransportHandler.cpp. r=pehrsons,gerald
Initial patch by Michael Froman <mfroman@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D133348
2021-12-14 13:40:52 +00:00
Hubert Boma Manilla 63495d728e Bug 1745921 - [devtools] Remove unused tabBlackboxed pref r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D133095
2021-12-14 12:50:17 +00:00
Norisz Fay 333caceb64 Backed out 5 changesets (bug 1742865, bug 1744397) for causing wpt failures on attr-meta-http-equiv-refresh/parsing.html CLOSED TREE
Backed out changeset 7b01edc5a0e0 (bug 1744397)
Backed out changeset 41abd4b7d2c0 (bug 1744397)
Backed out changeset 634641e3a05a (bug 1744397)
Backed out changeset 6e7755177481 (bug 1744397)
Backed out changeset e9fc94b33da9 (bug 1742865)
2021-12-14 13:25:58 +02:00
Peter Van der Beken a538f42b2d Bug 1744397 - Simplify refresh code: clean up meta refresh code in nsDocShell. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D132862
2021-12-14 10:13:59 +00:00
Nicolas Chevobbe 737bcdbb0c Bug 1129488 - [devtools] Make it possible to pick elements with pointer-events: none. r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D133070
2021-12-14 09:33:49 +00:00
Nick Alexander 33b7a096e7 Bug 1737117 - Pre: Add a reason to "should process updates at startup" logic. r=bytesized
I've elected to rename the function from `Should...` to
`ShouldNot...`, but not to rename the various test files.  The
functionality under test is both "should" and "should not", so I think
the churn of renaming is not justified.

This rearranges the deck chairs to accommodate testing the new
functionality in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D133556
2021-12-14 07:00:59 +00:00
Butkovits Atila 0a28019a1d Backed out 2 changesets (bug 1737117) for causing bustages at nsAppRunner.cpp. CLOSED TREE
Backed out changeset b78709bc0d0c (bug 1737117)
Backed out changeset b3be1a6a5e3f (bug 1737117)
2021-12-14 06:30:49 +02:00
Nick Alexander 61521bf00c Bug 1737117 - Pre: Add a reason to "should process updates at startup" logic. r=bytesized
I've elected to rename the function from `Should...` to
`ShouldNot...`, but not to rename the various test files.  The
functionality under test is both "should" and "should not", so I think
the churn of renaming is not justified.

This rearranges the deck chairs to accommodate testing the new
functionality in the next commit.

Differential Revision: https://phabricator.services.mozilla.com/D133556
2021-12-14 03:44:14 +00:00
Alexandre Poirot 032cb8a737 Bug 1744556 - [devtools] Avoid exception about server sent events when opening the browser toolbox. r=bomsy
Differential Revision: https://phabricator.services.mozilla.com/D132988
2021-12-13 15:21:57 +00:00
criss 615b164b26 Backed out changeset 227dd11a65eb (bug 1745176) for causing bustages on MediaTransportHandler.cpp. CLOSED TREE 2021-12-13 15:58:44 +02:00
Paul Adenot 4a5e4c886e Bug 1745176 - Add profiler markers to MediaTransportHandler.cpp. r=pehrsons,gerald
Initial patch by Michael Froman <mfroman@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D133348
2021-12-13 11:14:11 +00:00
Claudia 90864a0bd8 Bug 1675762 - [devtools] Use AppErrorBoundary component in the Console panel r=bomsy,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D129946
2021-12-13 08:23:46 +00:00
Andreea Pavel aaa1799be4 Bug 1742672 - disable browser_toolbox_fission_navigation.js on win10_2004 and linux64 r=intermittent-reviewers,MasterWayZ
Differential Revision: https://phabricator.services.mozilla.com/D133564
2021-12-11 17:07:06 +00:00
Nicolas Chevobbe ab7531ceed Bug 1531311 - [devtools] Add more visibility for node picker when debugging remote pages. r=jdescottes,devtools-backward-compat-reviewers.
This patch does a couple things to tell users they can use the node picker when
debugging a remote page:
- changes the node picker button icon (arrow -> hand) when connected to an android phone,
  as well as its tooltip
- adds a notice in the content page (i.e. on the phone) when the picker starts

Differential Revision: https://phabricator.services.mozilla.com/D132705
2021-12-11 10:58:35 +00:00
Jonathan Watt 91da4bcb58 Bug 1745325 - Remove unnecessary setting of `print.tab_modal.enabled=true` in tests. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D133449
2021-12-10 22:56:09 +00:00
Alexandre Poirot f71b6141a2 Bug 1744942 - [devtools] Convert browser_dbg-chrome-debugging.js into a resource command test. r=bomsy
This test was using legacy Thread actor APIs whereas sources are meant
to be received via ResourceCommand.

Differential Revision: https://phabricator.services.mozilla.com/D133189
2021-12-10 11:56:45 +00:00
Alexandre Poirot 50ecc431c2 Bug 1744942 - [devtools] Expose CommandsFactory.spawnClientToDebugSystemPrincipal to easily span Browser Toolbox-like DevToolsClient's. r=nchevobbe
This code could be useful in other places, especially in tests. (See next changeset)

I'm even wondering if `forMainProcess` should be using such type of client by default?
Concretely, in production, when we debug the main process, I think we always use such special client/server.

Differential Revision: https://phabricator.services.mozilla.com/D133188
2021-12-10 11:56:44 +00:00
Iulian Moraru a5854b43a4 Backed out changeset 01eb21de6aef (bug 1745325) for causing mochitest failures on browser_preview_print_coop.js. CLOSED TREE 2021-12-10 07:28:02 +02:00