This "automatic reload" behavior was probably useful as a PoC for the original
bug, but it's no good in a crashtest, because:
(a) the reload probably doesn't even take effect most of the time, since it's
in a setTimeout that the test is under no obligation to wait for.
(b) if the reload *does* get a chance to take effect (e.g. on a slower
test-runner where it takes longer for the test harness to judge the test to be
complete), then the test may simply never terminate (or take a long time to
terminate), because each reload causes some more paints, which the test harness
is then forced to wait on; and another reload may arrive before the test
harness checks back to see if we're done painting.
So: let's just remove the auto-reload behavior from this crashtest.
Differential Revision: https://phabricator.services.mozilla.com/D112686
Mostly mentioning that other completion engines also work, and how to
set jsm files to be treated like other JS files (and thus ESLint etc
would work on them).
Differential Revision: https://phabricator.services.mozilla.com/D112729
Check if a user is a Mozilla employee by checking their
Bugzilla groups, or checking if their VCS email ends
with "@mozilla.com".
When a user is setting up a new build environment, telemetry
will be automatically enabled for them if they are an
employee. If they're not an employee, they'll be asked
if they want to opt in.
Differential Revision: https://phabricator.services.mozilla.com/D106315
Did you know that our version of requests was from 2015? Phwoar!
This bumps `jinja2`, `py`, `pyyaml`, `requests` and `urllib3`.
There's significant risk for regressions due to breaking changes,
though due to the dynamic nature of Python, they're tricky to track
down.
The potential breaking changes I'm expecting to potentially affect
us are:
* `requests@2.11.0`: No longer accepts non-strings as header values.
* `requests@2.16.0`: `requests.packages` namespace was removed due to
packages no longer being vendored. The namespace has been
incrementally restored over future releases, but it's unclear to
what degree.
* `requests@2.24.0`: Redirect resolution now only happens when
`allow_redirects` is `True`.
* `requests` version of `urllib3` was bumped from `1.13.1` to `1.26`,
unsure what repercussions that will have.
This also added dependencies to `flake8_requirements`. This is because
the vendored `importlib-metadata` update (and the new
`typing-extensions` dependency) is found by `pip`, but the
vendored `typing-extensions` is _not_ discovered (perhaps due to
details around "eggs" and the way we add vendored code to the sys.path).
So, `pip` tries to install it manually and fails when it finds no hash.
By re-compiling `flake8_requirements`, the necessary hashes are made
available.
Differential Revision: https://phabricator.services.mozilla.com/D108526
This was required to workaround a driver bug on Adreno devices when
blitting to texture arrays. It is no longer required as we have
stopped using texture arrays, due to all the driver bugs.
It's currently just dead code as we stopped initializing the buffers
when we removed texture array support. This patch just removes the
dead code.
Differential Revision: https://phabricator.services.mozilla.com/D112697
Like the other browsers, we shouldn't allow to user modify content in
`<select>` element. Note that this case won't occur with moving caret
with input devices. This occurs only with Selection API.
FYI: Chrome deletes `<select>` element if children of it are selected,
but it's odd behavior since user don't see where is selected visually
and may cause unexpected data loss (i.e., deleting `<select>` element).
Perhaps, we should investigate the behavior in other replaced elements
like `<textarea>` etc in follow up bugs.
Depends on D112513
Differential Revision: https://phabricator.services.mozilla.com/D112517
It's hard to understand each caller of `HTMLEditor::IsEmptyNode()` tries to
check with multiple `bool` arguments. Therefore, they should be replaced
with an `EnumSet`.
Note that only the first argument is reverted the meaning. Therefore, if
it's omitted or `false`, `EmptyCheckOption::TreatSingleBRElementAsVisible`
is specified explicitly. Otherwise, i.e., `true`, nothing should be
specified.
Differential Revision: https://phabricator.services.mozilla.com/D112513
The test is using a framescript to have an observer for "http-on-opening-request".
That is used for the actual testpage but we need to prevent the next page to enter bfcache, so that
when going back from the session history frameloader isn't changed.
So in this case disabling bfcache should be fine.
Differential Revision: https://phabricator.services.mozilla.com/D112245
Stop supporting toolbar_field_separator in themes. We have no more
vertical separators in toolbar fields, and it could hide functional horizontal
separators in the urlbar panel, because it was misused there.
Introduce an autocomplete_popup_separator experimental color instead and use
a color-mix of currentColor to better adapt to LWT theme colors.
Differential Revision: https://phabricator.services.mozilla.com/D112616
My previous patch triggers a lint failure because it used 'virtual' and
'final' on the same declaration. However we have a gazillion violations
of this same lint (just with 'override', not 'final') on the same file,
so I was just following local style.
Apparently the lint is tier 1 and runs on every push (wtf), so fix the
whole header.
MANUAL PUSH: Silly lint fix on a CLOSED TREE.
This removes some sketchy non-caching of cursors on windows while at it,
now that plugins are gone, but otherwise shouldn't change behavior.
Differential Revision: https://phabricator.services.mozilla.com/D112475
If I'm reading compiler-rt correctly, this and __lsan_default_options
should be additive so we shouldn't need to specify the allow_leaks flag
gobally.
Differential Revision: https://phabricator.services.mozilla.com/D110699
In bug 1630356 we found a driver bug on some Adreno 3xx devices where
flat scalar varyings in shaders incorrectly caused the output of every
fragment in the triangle to be calculated as if flat. To work around
the bug, we pack the scalar varyings in a vector. At the time we
believed it may be limited to varyings used to calculate UV
coordinates, however, we have now seen more cases of this bug (in box
shadows, gradients, and svg filters).
Unfortunately it is not yet clear what precise conditions are required
to trigger this bug, so for now we just apply the workaround to the
varyings we know are affected due to failing wrench tests on the device.
Differential Revision: https://phabricator.services.mozilla.com/D112334
On Android, WebRenderAPI::Resume() call is triggered from Java side. But Java side does not know about fallback to RenderCompositorOGLSWGL. Then in this fallback case, RenderCompositor::Resume() needs to be called from gfx code if it is necessary to be called.
Resume() is necessary only when RenderCompositor::Resume() is implemented. The Resume() is implemented only on RenderCompositorEGL and RenderCompositorOGLSWGL. And only RenderCompositorOGLSWGL uses software WebRender.
Differential Revision: https://phabricator.services.mozilla.com/D107620
Daniel Holbert
Emilio Cobos Álvarez
Mitchell Hentges
smolnar
Joel Maher
Samuel Grasse-Haroldsen
Richa Sharma
Andreea Pavel
Christoph Kerschbaumer
Butkovits Atila
Jamie Nicol
stransky
Masayuki Nakano
Nicolas Chevobbe
Olli Pettay
Marco Bonardo
Claudia
Jonathan Kew
Luz De La Rosa
Florian Quèze
Gabriele Svelto
Edgar Chen
Andi-Bogdan Postelnicu
imoraru
Mirko Brodesser
Dragana Damjanovic
sotaro