d44f4cc342
Bug 1700051: part 35) Reduce accessibility of `mSoftText.mDOMMapping` to `private`. r=smaug
...
Depends on D112551
Differential Revision: https://phabricator.services.mozilla.com/D112552
2021-04-20 07:49:13 +00:00
7198e709e8
Bug 1700051: part 34) Reduce accessibility of `mSoftText.mValue` to `private`. r=smaug
...
Depends on D112550
Differential Revision: https://phabricator.services.mozilla.com/D112551
2021-04-20 07:49:13 +00:00
8e5146d57b
Bug 1700051: part 33) Move `AdjustSoftBeginAndBuildSoftText` to `SoftText`. r=smaug
...
Depends on D112549
Differential Revision: https://phabricator.services.mozilla.com/D112550
2021-04-20 07:49:13 +00:00
5af84ee6ee
Bug 1700051: part 32) Move `InvalidateWords` to `SoftText`. r=smaug
...
It's clearer.
Differential Revision: https://phabricator.services.mozilla.com/D112549
2021-04-20 07:49:12 +00:00
c7077c610e
Bug 1700051: part 31.5) Move `mSoftTextDOMMapping` to `SoftText`. r=smaug
...
Depends on D112544
Differential Revision: https://phabricator.services.mozilla.com/D112545
2021-04-20 07:49:12 +00:00
12f19abd5f
Bug 1700051: part 31.4) Move `mSoftTextValid` to `SoftText`. r=smaug
...
Depends on D112543
Differential Revision: https://phabricator.services.mozilla.com/D112544
2021-04-20 07:49:11 +00:00
64c83abf72
Bug 1700051: part 31.3) Move `mSoftEnd` to `SoftText`. r=smaug
...
Depends on D112542
Differential Revision: https://phabricator.services.mozilla.com/D112543
2021-04-20 07:49:11 +00:00
f9be3581cf
Bug 1700051: part 31.2) Move `mSoftBegin` to `SoftText`. r=smaug
...
Depends on D112541
Differential Revision: https://phabricator.services.mozilla.com/D112542
2021-04-20 07:49:11 +00:00
1b13e1f445
Bug 1700051: part 31.1) Factor `SoftText` out. r=smaug
...
The `mSoft*` members belong together and will be moved to `SoftText` in
the following reviews.
Depends on D112540
Differential Revision: https://phabricator.services.mozilla.com/D112541
2021-04-20 07:49:10 +00:00
acff2bb77d
Bug 1700051: part 30) Narrow scope of `newOffset`. r=smaug
...
Presumably allows simplifying the code around it. See the following
review.
Differential Revision: https://phabricator.services.mozilla.com/D112540
2021-04-20 07:49:10 +00:00
70371eb59b
Bug 1700051: part 29) Refactor `TextNodeContainsDOMWordSeparator` to `FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
...
More descriptive and separates input- from output-arguments.
Differential Revision: https://phabricator.services.mozilla.com/D112180
2021-04-16 08:10:11 +00:00
2ac0000c8a
Bug 1700051: part 28) Refactor `WordSplitState<T>::GetDOMWordSeparatorOffset` to `WordSplitState<T>::FindOffsetOfLastDOMWordSeparatorSequence`. r=smaug
...
The method name is clearer and input and ouput are separated more
clearly.
Differential Revision: https://phabricator.services.mozilla.com/D112026
2021-04-15 08:38:42 +00:00
2357740bfb
Bug 1700051: part 27) Rename `mozInlineSpellWordUtil::BuildSoftText` to `mozInlineSpellWordUtil::AdjustSoftBeginAndBuildSoftText`. r=smaug
...
Ideally, the method itself should be refactored. I'll need to think
about how to properly do that. For now, the new name reflects more
clearly what the method does.
Depends on D110242
Differential Revision: https://phabricator.services.mozilla.com/D110243
2021-03-31 09:04:46 +00:00
74905cb822
Bug 1700051: part 26) Correct typo in comment of `mozInlineSpellWordUtil::BuildSoftText`. r=smaug
...
Depends on D110241
Differential Revision: https://phabricator.services.mozilla.com/D110242
2021-03-31 09:04:46 +00:00
c4cd5efacd
Bug 1700051: part 25) Change `mozInlineSpellWordUtil::BuildRealWords` to return the built words. r=smaug
...
Depends on D110240
Differential Revision: https://phabricator.services.mozilla.com/D110241
2021-03-31 09:04:45 +00:00
7814efb66a
Bug 1700051: part 24) Refactor `mozInlineSpellWordUtil::SplitDOMWord` to `mozInlineSpellWordUtil::SplitDOMWordAndAppendTo`. r=smaug
...
More explicit and preparation for further `const`-correctness.
Depends on D110090
Differential Revision: https://phabricator.services.mozilla.com/D110240
2021-03-31 08:33:09 +00:00
5cf3a4fde1
Bug 1700051: part 23) `const`-qualify more methods of `mozInlineSpellWordUtil`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D110090
2021-03-30 14:43:16 +00:00
8f90ed40d6
Bug 1700051: part 22) `const`-qualify some members of `mozInlineSpellStatus`. r=smaug
...
Depends on D110084
Differential Revision: https://phabricator.services.mozilla.com/D110085
2021-03-30 08:45:04 +00:00
76015c271a
Bug 1700051: part 21) Simplify `mozInlineSpellStatus`'s initialization. r=smaug
...
Depends on D110083
Differential Revision: https://phabricator.services.mozilla.com/D110084
2021-03-30 08:45:03 +00:00
a4864650c7
Bug 1700051: part 20) Merge `mozInlineSpellStatus`'s constructor and its `Init` method. r=smaug
...
Allows to `const`-qualify some members.
Differential Revision: https://phabricator.services.mozilla.com/D110083
2021-03-30 08:45:03 +00:00
b8bb3ce56e
Bug 1700051: part 19) `const`-qualify and rename `mozInlineSpellChecker::SpellCheckSelectionIsFull`. r=smaug
...
Depends on D109895
Differential Revision: https://phabricator.services.mozilla.com/D109896
2021-03-29 08:03:11 +00:00
217df64f78
Bug 1700051: part 18) Throw more `const` on `mozInlineSpellChecker`. r=smaug
...
Depends on D109882
Differential Revision: https://phabricator.services.mozilla.com/D109895
2021-03-29 08:03:11 +00:00
9fbe592b0f
Bug 1700051: part 17) Add `mozInlineSpellChecker::GetDisabledAsyncToken()`. r=smaug
...
Allows unfriending some class from `mozInlineSpellChecker`.
Depends on D109881
Differential Revision: https://phabricator.services.mozilla.com/D109882
2021-03-29 08:03:10 +00:00
2eaf6f3625
Bug 1700051: part 16) Qualify `mozInlineSpellWordUtil::GetRootNode` `const`. r=smaug
...
Depends on D109880
Differential Revision: https://phabricator.services.mozilla.com/D109881
2021-03-29 08:03:10 +00:00
4aabcc8b6a
Bug 1700051: part 15) Qualify `mozInlineSpellWordUtil::MakeRange` `const`. r=smaug
...
Depends on D109879
Differential Revision: https://phabricator.services.mozilla.com/D109880
2021-03-29 08:03:10 +00:00
c3a6b19580
Bug 1700051: part 14) Qualify `mozInlineSpellWordUtil::Init`'s argument `const`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109879
2021-03-29 08:03:09 +00:00
17b3805751
Bug 1700051: part 13) Reduce accessibility of `mozInlineSpellStatus`'s constructor to `private`. r=smaug
...
Prevents users of `mozInlineSpellStatus` forgetting to initialize it.
Differential Revision: https://phabricator.services.mozilla.com/D109748
2021-03-26 09:21:13 +00:00
14313e8270
Bug 1700051: part 12) Declare `mozInlineSpellStatus::mSpellChecker` `const`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109747
2021-03-26 09:21:12 +00:00
c15083e2e7
Bug 1700051: part 11) Change `mozInlineSpellStatus::InitForRange` to static factory method. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109746
2021-03-26 09:21:12 +00:00
7d02c05467
Bug 1700051: part 10) Change `mozInlineSpellStatus::InitForSelection` to static factory method. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109745
2021-03-26 09:21:11 +00:00
ad87ef090b
Bug 1700051: part 9) Change `mozInlineSpellStatus::CreateForNavigation` to return `Result<...,...>`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109744
2021-03-26 09:21:11 +00:00
5dde374aaf
Bug 1700051: part 8) Change `mozInlineSpellStatus::InitForNavigation` to static factory method. r=smaug
...
The next part changes its return type to `Result<..., nsresult>`.
Differential Revision: https://phabricator.services.mozilla.com/D109743
2021-03-26 09:21:11 +00:00
d38cbe5571
Bug 1700051: part 7) Change `mozInlineSpellStatus::CreateForEditorChange` to return `Result<..., ...>`. r=smaug
...
Separates input from output more clearly.
Differential Revision: https://phabricator.services.mozilla.com/D109742
2021-03-26 09:21:10 +00:00
daed84a8f4
Bug 1700051: part 6) Change `mozInlineSpellStatus::InitForEditorChange` to static factory method. r=smaug
...
Preparation so that some members of `mozInlineSpellStatus` can become
`const`-qualified.
The method's return value will be changed to
`Result<UniquePtr<mozInlineSpellStatus>, nsresult>>` in a separate
review.
Differential Revision: https://phabricator.services.mozilla.com/D109741
2021-03-26 09:21:10 +00:00
00a2d5f7d4
Bug 1675614 - Process spellcheck in chunks in the parent process, since it's also async. r=m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D109692
2021-03-26 04:19:46 +00:00
cc730d05dd
Bug 1184468 - Use nsTHashtable::Keys where possible. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108588
2021-03-24 17:56:50 +00:00
613e20d136
Bug 1184468 - Use nsBaseHashtable::Values. r=xpcom-reviewers,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D108587
2021-03-24 17:56:49 +00:00
0954ebd22d
Bug 708901 - Migrate to nsTHashSet in extensions/spellcheck. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109335
2021-03-24 17:56:49 +00:00
bf3ef3a71d
Bug 708901 - Migrate to nsTHashSet in extensions/permissions. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D109334
2021-03-24 17:56:49 +00:00
f54ee076ae
Backed out 13 changesets (bug 708901, bug 1184468) for causing build bustage on GeckoViewHistory.cpp. CLOSED TREE
...
Backed out changeset b1e4c01e63b8 (bug 708901)
Backed out changeset 37b52cce83c0 (bug 708901)
Backed out changeset eee75f33f060 (bug 708901)
Backed out changeset 479bf64c7986 (bug 708901)
Backed out changeset 15a8fb94d15d (bug 708901)
Backed out changeset be31ccd9a61d (bug 708901)
Backed out changeset fc54f4eaedd5 (bug 708901)
Backed out changeset 03c3a56c3d13 (bug 708901)
Backed out changeset 73f11d3c1298 (bug 708901)
Backed out changeset aed22fd80893 (bug 708901)
Backed out changeset 74d8249fbe7e (bug 708901)
Backed out changeset acb725eb3c1d (bug 1184468)
Backed out changeset 70f3ea6efec4 (bug 1184468)
2021-03-24 19:26:20 +02:00
e63cfd0e56
Bug 708901 - Migrate to nsTHashSet in extensions/spellcheck. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109335
2021-03-24 16:59:01 +00:00
d54c92f2e8
Bug 708901 - Migrate to nsTHashSet in extensions/permissions. r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D109334
2021-03-24 16:59:01 +00:00
d1c07416d3
Bug 1700051: part 5) Correct typo. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109501
2021-03-24 10:12:00 +00:00
0be7d4c977
Bug 1700051: part 4) Add `GetOperation()` to `mozInlineSpellStatus`. r=smaug
...
Depends on D109310
Differential Revision: https://phabricator.services.mozilla.com/D109311
2021-03-24 10:12:00 +00:00
7563a8e16b
Bug 1700051: part 3) Add `GetCreatedRange()` to ` mozInlineSpellStatus`. r=smaug
...
Depends on D109309
Differential Revision: https://phabricator.services.mozilla.com/D109310
2021-03-24 10:12:00 +00:00
77b3add57e
Bug 1700051: part 2) Add `GetNoCheckRange()` to `mozInlineSpellStatus`. r=smaug
...
Depends on D109308
Differential Revision: https://phabricator.services.mozilla.com/D109309
2021-03-24 10:11:59 +00:00
3691a72cd6
Bug 1700051: part 1) Reduce accessibility of some members of `mozInlineSpellStatus` to `private`. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D109308
2021-03-24 10:11:59 +00:00
58f319b15f
Bug 1698786: part 7) Add more `MOZ_LOG`ging to `mozInlineSpellWordUtil`. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109277
2021-03-24 08:15:52 +00:00
22d17f7692
Bug 1698786: part 6) Add some `const`-correctness to `mozInlineSpellWordUtil`. r=smaug
...
Depends on D109038
Differential Revision: https://phabricator.services.mozilla.com/D109269
2021-03-22 14:34:09 +00:00
915b67f69b
Bug 1698786: part 5) Change compile-time debug printfs to `MOZ_LOG` in `mozInlineSpellWordUtil`. r=masayuki
...
Differential Revision: https://phabricator.services.mozilla.com/D109038
2021-03-22 08:17:38 +00:00
Mirko Brodesser
Matt Woodrow
Simon Giesecke
Csoregi Natalia