Automatic update from web-platform-tests
De-flake two tests
These tests were timing out because window.screenX and window.screenY
were never set during the test run, leading to the code to wait 15
seconds before giving up trying to find them. But once it gave up,
it got the correct result, because there is no expected_screenX
or expected_screenY for these tests anyway.
Tests are:
external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-innerwidth.html
external/wpt/html/browsers/the-window-object/open-close/open-features-non-integer-width.html
Fixed: 1048149
Change-Id: I9e9620254b0e9284923e7a683213b1c0721ffc81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4347589
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118959}
--
wpt-commits: cb19b01d65d9677bf53223322e32211c190eee5c
wpt-pr: 39060
Automatic update from web-platform-tests
[anchor-position] Make `anchor` attribute work for non-popovers
This patch reimplements how we mark elements that are implicit anchors.
Previously it was only marked for popover element's implicit anchors,
and now it works for all implicit anchors. This is done by a new class
AnchorElementObserver that observes all possible changes in implicit
anchor and replaces the old PopoverAnchorObserver.
This patch also reveals two existing issues:
1. Element::GetElementAttribute() may return non-null result even if
the element is out of tree scope. As fixing the bug is out of the
scope here, this patch just works around it. crbug.com/1425215 was
filed.
2. popover-anchor-idl-property.html has some bugs that made it pass
previously. This patch fixes those bugs.
Fixed: 1417346
Change-Id: I798977ab1ed7df0c528b7eb98c64fc04476e6106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4338487
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118933}
--
wpt-commits: e1dabe08c494d1b7aaf5e2e9437b71e51997c299
wpt-pr: 39041
Automatic update from web-platform-tests
[anchor-position] Use scroll-adjusted IMCB for position fallback
Previously, we've been using the inset-modified containing block for
position fallback, which doesn't work well with scrolling.
This patch fixes the issue by using the scroll-adjusted IMCB instead,
which was introduced earlier on the spec side [1].
As an implementation detail, this patch also calculates and stores
the non-overflowing scroll ranges [2] for each fallback position, so
that we can still use composited scrolling, and need to invalidate
layout only when we have scrolled out of that range.
This patch also adds WPT tests under various writing modes and
directions to cover all the new code paths.
[1] https://drafts4.csswg.org/css-anchor-position-1/#determine-the-position-fallback-styles
[2] https://github.com/w3c/csswg-drafts/issues/8059#issuecomment-1444616906
Bug: 1418725
Change-Id: If9e104c6ac3c51ccdfc4fa7d3cf9cbffcc5af46d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4292618
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118926}
--
wpt-commits: e2169b6b0b5ca89b61b976f512e9ad52bace8597
wpt-pr: 38998
Automatic update from web-platform-tests
Scheduling APIs: Implement scheduler.yield() prototype (part 2: inherit)
This CL implements the scheduler.yield() "inherit" option:
- Signal selection: GetTaskSignalFromOptions() is updated to take
inheritance into account. If either the signal or priority options
are to inherit, the inherited signal is retrieved from V8 and used
in the computation:
- signal: "inherit", priority: unset - use the inherited signal
if there is one, otherwise default priority.
- signal: "inherit", priority: fixed - create a composite signal
from the inherited signal and fixed priority. If the inherited
signal is null, just use a fixed priority signal.
- signal: unset, priority: "inherit" - if there's nothing to
inherit use the default priority; if the inherited signal has
fixed priority and can't abort, use that; otherwise create a
new composite signal.
- DOMTask is updated to support continuation, passing its signal
when creating a task scope (main thread). For workers, DOMTask
will set the continuation preserved embedder data manually before
running the task.
- WPT tests are added and modified to cover the "inherit" option.
Bug: 979020
Change-Id: Ia9776b9292d70636e2b1eea191e9c09b1809fa84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4326152
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118868}
--
wpt-commits: c19eb6a201cf1dd04915ef9a2de24b779532df9d
wpt-pr: 39040
Automatic update from web-platform-tests
view-transitions: Update CSS to name the root element.
Default UA CSS is supposed to add view-transition-name to the root
element. Currently it targets html which is incorrect since multiple
html elements can exist on the page. Update it to target :root.
This also aligns with the spec. See
https://drafts.csswg.org/css-view-transitions-1/#ua-styles.
Bug: 1425445
Change-Id: If989e5549f1977c248b4f7e933379e2bfc17d07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4350707
Auto-Submit: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Khushal Sagar <khushalsagar@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118792}
--
wpt-commits: c2a197e2cbb2afc7cc7849f926884bb1ffdd3109
wpt-pr: 39058
Automatic update from web-platform-tests
[CSSTransitionDiscrete] Fix custom property issues
When attempting to transition a custom property with universal syntax,
we hit a DCHECK in StyleBuilder::ApplyProperty because we send
a CSSVariableReferenceValue, which is normally expected to be resolved
at this point. However, such custom properties represent their
computed values as CSSVariableReferenceValues, and the discrete
transitions machinery sends those computed values to ApplyProperty
without "transformations". This is expected behavior as of CL:4315803.
Representing the computed value of universal custom properties with
CSSVariableReferenceValue is a bit suspicious and might warrant further
investigation, but this CL does not attempt to address that. Instead
we alter the DCHECK to expect CSSVariableReferenceValues for relevant
custom properties.
Also:
- Fixed usage of irrelevant custom property in the WPT
token-stream-type-type-interpolation.html.
- Fixed accumulation of "transitionrun" event listeners when
testing multiple transitions in the same .html file
(e.g. custom-property-transition-mismatched-list.html).
WPTs related to <transform-function> and <transform-list> are still
failing, because we don't implement interpolation for those syntaxes
yet.
Bug: 1399631
Change-Id: I22f0766921061216421839def84bc305edda2a41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4334509
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118779}
--
wpt-commits: e6c2d4cacfa621bc2656b577c1fb63f080bac2f5
wpt-pr: 39051
Automatic update from web-platform-tests
Test which XSLT functions are defined
This currently expects only functions defined in XSLT 1.0 (and references) to be defined. This matches what all browsers currently implement.
--
wpt-commits: d963cd40e87f20bbfaaffdb9eca2e539bac4d631
wpt-pr: 39057
Automatic update from web-platform-tests
CSSTransitionDiscrete: Fix counter related crashes
The generated code in CounterIncrement::ApplyValue expects to receive a
CSSValueList with a CSSValuePair inside of it, so this patch adds a
CSSValuePair to ComputedStyleUtils::ValueForCounterDirectives
Bug: 1399631, 1413556
Change-Id: If38d51d026965b2f481a9ed6432ce519587847ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4310132
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118697}
--
wpt-commits: 98afc8a86461237414d32da9e6628499c0a0022a
wpt-pr: 38817
Automatic update from web-platform-tests
Fix#8122: Upstream Mozilla counter-style tests
These don't cover all of the counter styles, but they give us automated tests
for most of them.
They are all originally authored by @dbaron and @upsuper.
--
wpt-commits: 5e9421703a3de453d0792109a714f624e5185f27
wpt-pr: 8150
Automatic update from web-platform-tests
Collect popover invokers on root instead of document
See this HTML spec PR:
https://github.com/whatwg/html/pull/8993
It points out that it would be better to look within `root`
rather than `document` for invokers. Otherwise this use case
will be broken:
<div>
<template shadowrootmode=open>
<button popovertarget=p1>Click</button>
<div popover id=p1>Popover 1
<button popovertarget=p2>Click</button>
</div>
<div popover id=p2>Popover 2 (I'm not detected as a being related to p1)</div>
</template>
</div>
I.e. nested popovers entirely within a shadow tree. This CL
fixes that behavior and adds a test.
Bug: 1307772
Change-Id: I28521ec1008d43994ca738c5673da3b704d7ba9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4335444
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118671}
--
wpt-commits: 887ed601ff82d1cee8a358559e2c963528e6520b
wpt-pr: 38981
Automatic update from web-platform-tests
Fix inconsistent hasStorageAccess behavior for A(B(A)) frame tree case
This change for document.hasStorageAccess() is based on spec PR
fd28dc0543.
Bug: 1422628
Change-Id: I72cc1bb21a5d075a00b4b6719e2010855e5c2a63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340989
Reviewed-by: Johann Hofmann <johannhof@chromium.org>
Commit-Queue: Shuran Huang <shuuran@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118658}
--
wpt-commits: 186820b4ea00e96be00a7f57a2f709c67d78d05c
wpt-pr: 39019
Automatic update from web-platform-tests
Use base::ValuesEquivalent for custom property style queries
We previously compared the tokens from the tokenizated string instead.
Add tests for matching and serializing original string in style()
queries.
Bug: 1302630
Change-Id: I2768b930407f65c979b320597276e0d5d01a1b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4342894
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118626}
--
wpt-commits: 0b9590a78d353217ae0bc6321ecc456f2da197ec
wpt-pr: 39052
Automatic update from web-platform-tests
Initial implementation of the X25519 algorithm
This CL implements the DeriveBits and import/export operations
for the X25519 algorithms (spki, pkcs, raw and jwk).
Additionally, it adds the new algorithm in the registry and implements
its normalization, which is quite simple due to the lack of parameters.
The feature is implemented behind the WebCryptoCurve25519 runtime flag
for now. See the intent-to-prototype request [1] for details.
[1] https://groups.google.com/a/chromium.org/g/blink-dev/c/n0uKIqfypW0/m/xu5UBbaBAwAJ
Bug: 1370697
Change-Id: Ibad2a728a5b25b40c130e4da270747104ae056ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016576
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1118402}
--
wpt-commits: 1406b5c0d07b5e8dd08e328c451e42c23f3b96c8
wpt-pr: 37063
Automatic update from web-platform-tests
Split vr_services.mojom to multiple files based on its functionality.
Method moved from vr_service to xr_session:
enum XRSessionFeature()
enum XRSessionMode()
Bug:1420093
Change-Id: Ide102ec4495d32aca6aedc5f2233b2ed6a101058
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4307278
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Brendon Tiszka <tiszka@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118389}
--
wpt-commits: 4904eff5021a5ab057de49fbbf0b4916b5a1f336
wpt-pr: 38962
Automatic update from web-platform-tests
InlineLayout: add parsing logic for the text-box-trim property
This CL includes:
- Introducing the new property.
- Adding a new RuntimeEnabledFeature
- Adding the parsing logic
- Adding initial web tests for parsing
Bug: 1411581
Change-Id: I8e9f6f023a505ac1ae97a827048d836972e97a73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4296655
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Lingqi Chi <lingqi@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118311}
--
wpt-commits: 1eb5a3613d962922f982715e3ca09d4aedbb6a35
wpt-pr: 38762
Automatic update from web-platform-tests
[wptrunner] Downgrade URL validation in content shell driver (#39036)
See the comment in `testharnessreport-content-shell.js`. URL mismatches
will no longer be treated as a harness `ERROR`.
For the URLs to match as much as possible, this change partially undoes
web-platform-tests/wpt#39007, which broke validation for final URLs with
fragments. Instead, we use the standard `URL(...)` instead of `<a>` to
parse the original `location.href`.
--
wpt-commits: 071134cb4d44b95f8068828830498a19c60ad120
wpt-pr: 39036
Automatic update from web-platform-tests
Scheduling APIs: Implement scheduler.yield() prototype (part 1)
This adds the full API surface of scheduler.yield() to the IDL and
implements all the options except inheritance (split off to keep the
size reasonable). Details:
- The scheduler's fixed and dynamic priority collections are
mirrored for continuations, and algorithms have been updated to
select the collection based on WebSchedulingQueueType.
- When yield is called, the options are used to get a TaskSignal
for the continuation, using the same algorithm as postTask().
This in turn is used to select the continuation queue which is
used to schedule a DOMTaskContinuation (wrapper around resolving
the yield() promise).
- Passing "inherit" for the signal or priority option will CHECK.
This will be implemented in a follow-up CL.
- Tentative WPT test coverage is added for the implemented portion
of the API.
Bug: 979020
Change-Id: I601cd0ce801f02bdc236995124a36951431da5b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4324266
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118256}
--
wpt-commits: 8ab8d9d6ae09d7cf62657115a1fd4366b7de8b11
wpt-pr: 39001
Automatic update from web-platform-tests
Only add trailing border/padding to the right fragment.
We used to always subtract trailing border/padding for every fragment
that shouldn't have it, but this changed for table cells in CL:4303193.
To fix this, make sure that we only include trailing border/padding when
at the fragment that has the block-end edge of the box.
Bug: 1425075
Change-Id: Id7afa2eee764e1a8bb3017a90b212495278fe623
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4345873
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118245}
--
wpt-commits: e385e89cfcfb7170f098736c8ecefa89451aa62a
wpt-pr: 39035
Automatic update from web-platform-tests
Add test coverage for VP9 simulcast in WPTs.
The majority of this work already happened inside third_party/webrtc (webrtc:14884). This CL simply adds test coverage for VP9 simulcast,
with and without using scalabilityMode.
For now, a field trial is needed in order for the scalabilityMode path
to opt-in and pass the test.
Bug: webrtc:14884
Change-Id: I453e15f329f424b74c6f82befe718c237dc9bff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4340569
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118156}
--
wpt-commits: d70009880ec0c8cff26adf08f56cd44945cde35d
wpt-pr: 39027
Automatic update from web-platform-tests
[css-color] unwrap lab/oklab and lch/oklch for-loops (#39029)
Make separate tests for lab() vs. oklab() and lch() vs. oklch(), since with clamping of L > 100% they will have different computed values (#39000).
--
wpt-commits: 490fc650dac1e61fd2be2dc76ce571a9a89e0135
wpt-pr: 39029
Automatic update from web-platform-tests
[rsafor] Rename requestStorageAccessForOrigin to requestStorageAccessFor
This allows for evolution of the scope of the permission without
requiring deprecation of the old name.
Change-Id: Iee11f56a41ec116b800515adaf4ee3fe7fc91e26
Bug: 1424452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4337982
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Matt Reichhoff <mreichhoff@chromium.org>
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1118038}
--
wpt-commits: b185124819558842359d60f2715797ceaf997fa6
wpt-pr: 38996
Automatic update from web-platform-tests
webcodecs: Support for per-frame QP configuration in VideoEncoder
This is a resubmit of https://crrev.com/1117235
Currently only software AV1 and VP9 are supported.
- IDL changes necessary pluming
- web tests and
- improved error messaging for profiles and config params
Demo: https://webcodecs-qp.glitch.me/
Bug: 1424154, 1406372
Change-Id: Ia7a89364700184fcfe55d0b6b298785784f1332d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4342072
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1117801}
--
wpt-commits: eb59e8b777bb8d80932cc241a6a417c69a891c15
wpt-pr: 39018
Chris Harrelson
Xiaocheng Hu
moz-wptsync-bot
Scott Haseley
Khushal Sagar
Anders Hartvoll Ruud
Sam Sneddon
Joey Arhar
Geoffrey Sneddon
Mason Freed
Shuran Huang
Rune Lillesveen
Frédéric Wang
Arnaud Mandy
Ming-Ying Chung
Javier Fernández García-Boente
hungngo04
lingqi
Jonathan Lee
Morten Stenshorne
Henrik Boström
Dan Burzo
Matt Reichhoff
Noam Rosenthal
Hiroki Nakagawa
Eugene Zemtsov
fantasai
Kevin Ellis
Gérard Talbot