Граф коммитов

2686 Коммитов

Автор SHA1 Сообщение Дата
Brian Hackett 18578fbd02 Bug 1544170 Part 4 - Don't infinitely recurse in newChannelForURL on failure, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27411

--HG--
extra : rebase_source : 658df8227afa78826ef32b63f87e7c0f9554bda2
2019-04-12 16:37:00 -10:00
Brian Hackett a151fd40c6 Bug 1544170 Part 2 - ReplayInspector changes to support showing styles, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27409

--HG--
extra : rebase_source : fa3dde431c55e731c58297bb64dc405c3b8f7dd8
2019-04-12 16:35:18 -10:00
Andreea Pavel 1d5a79ec29 Merge mozilla-central to mozilla-inbound. on a CLOSED TREE 2019-04-19 00:50:26 +03:00
Andreea Pavel e5b695eefd Merge mozilla-inbound to mozilla-central. a=merge 2019-04-19 00:36:23 +03:00
Brian Grinstead 381332c51e Bug 1544051 - Part 3 - Scripted change to remove references to AddTask.js r=ahal
This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672

Differential Revision: https://phabricator.services.mozilla.com/D27761

--HG--
extra : moz-landing-system : lando
2019-04-18 16:51:01 +00:00
Julian Descottes bbcab0f303 Bug 1544749 - Add shared helper to retrieve the top window r=bgrins
Some classes in DevTools will not have an easy way to get access to the toolbox.
However they might still want to use the topmost chrome window.
Extract the logic from toolbox.js to a shared helper.

Differential Revision: https://phabricator.services.mozilla.com/D27672

--HG--
extra : moz-landing-system : lando
2019-04-18 09:06:32 +00:00
Daisuke Akatsuka f145a56427 Bug 1539328: Introduce new unique id for service worker actor. r=jdescottes
Depends on D25771

Differential Revision: https://phabricator.services.mozilla.com/D25772

--HG--
extra : moz-landing-system : lando
2019-04-18 00:47:37 +00:00
Daisuke Akatsuka 6f3ba76797 Bug 1539328: Introduce new unique id for normal worker actor. r=jdescottes,bhackett
Depends on D25207

Differential Revision: https://phabricator.services.mozilla.com/D25771

--HG--
extra : moz-landing-system : lando
2019-04-18 00:47:24 +00:00
Daisuke Akatsuka c21d56872c Bug 1539328: Introduce getWorker(id) to RootFront to avoid re-using client debugger. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25207

--HG--
extra : moz-landing-system : lando
2019-04-18 00:45:20 +00:00
Gabriel Luong 468b74194b Bug 1544829 - Implement print media type emulation in the new rules view. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D27814
2019-04-16 16:37:11 -04:00
Brian Hackett 87d3e60af3 Bug 1533202 Part 2 - Enumerate WeakMap/WeakSet entries in workers, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D27610

--HG--
extra : rebase_source : da6f0d2dac40be4cfa1897e2247487711f9bf6d4
2019-04-15 12:05:38 -10:00
Yura Zenevich 08eb4962e6 Bug 1536802 - add contrast badge for accessible objects in accessibility tree. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D26460

--HG--
extra : moz-landing-system : lando
2019-04-16 14:53:07 +00:00
Art-Vanderlay 1174054e9b Bug 1514766 - Change the order of the autocomplete popup to display lowercase items and perfect matches first. r=nchevobbe.
The autocomplete popup in the web console now favours matches
with the user input in alphabetical order with lowercase letters and
perfect matches brought to the top of the list.
e.g.

Typing 'document.styleSheets' brings up the result:

-styleSheets
-styleSheetSets

Differential Revision: https://phabricator.services.mozilla.com/D19330

--HG--
extra : moz-landing-system : lando
2019-04-16 12:31:51 +00:00
Brian Grinstead c4fa4cfc0c Bug 1544322 - Part 4 - Remove the [type] attribute for multiline <script> tags loading files in /tests/SimpleTest/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the case where the script src is on the line below the script tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 4` argument.

Differential Revision: https://phabricator.services.mozilla.com/D27459

--HG--
extra : moz-landing-system : lando
2019-04-16 04:01:46 +00:00
Brian Grinstead 6515f97bcb Bug 1544322 - Part 1 - Remove the [type] attribute for one-liner <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 1` argument.

Differential Revision: https://phabricator.services.mozilla.com/D26812

--HG--
extra : moz-landing-system : lando
2019-04-15 20:56:58 +00:00
Julian Descottes 5091f67021 Bug 1505289 - Move unknown runtime logic to aboutdebugging r=Ola,ladybenko
The notion of unknown runtime is only relevant to aboutdebugging
As we will complexify this to handle unplugged devices, moving it to aboutdebugging seems reasonable.

Differential Revision: https://phabricator.services.mozilla.com/D25779

--HG--
extra : moz-landing-system : lando
2019-04-15 22:23:01 +00:00
Hiroyuki Ikezoe f7645a5770 Bug 1531228 - Enable the new scroll snap and disable the old scroll snap on nightly. r=botond
Differential Revision: https://phabricator.services.mozilla.com/D22804

--HG--
extra : moz-landing-system : lando
2019-04-11 06:22:01 +00:00
Hiroyuki Ikezoe eab764a7ae Bug 1312163 - Switch to the new scroll-snap-type syntax for the old scroll snap implementation and drop the scroll-snap-type-{x,y} longhands. r=emilio
Now scroll-snap-type is a longhand property.

Depends on D21621

Differential Revision: https://phabricator.services.mozilla.com/D21622

--HG--
extra : moz-landing-system : lando
2019-04-11 06:19:31 +00:00
Yura Zenevich 4c0b4af80b Bug 1540904 - added full page API for accessibility walker actor. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D26458

--HG--
extra : moz-landing-system : lando
2019-04-10 18:36:02 +00:00
Yura Zenevich 2c9b6e5406 Bug 1541446 - added audited event to AccessibleActor/Front. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D26457

--HG--
extra : moz-landing-system : lando
2019-04-10 18:36:00 +00:00
Brindusan Cristian 04da27ce4e Backed out 4 changesets (bug 1541666, bug 1541446, bug 1540904, bug 1540601) for dt failures at browser_accessibility_node_audit.js
Backed out changeset 7bcd00bbcb71 (bug 1541666)
Backed out changeset a27b2d203885 (bug 1540904)
Backed out changeset 9f43419c7b40 (bug 1541446)
Backed out changeset e3294a1be947 (bug 1540601)
2019-04-10 07:13:57 +03:00
Yura Zenevich a2e55d282e Bug 1540904 - added full page API for accessibility walker actor. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D26458

--HG--
extra : moz-landing-system : lando
2019-04-10 00:58:31 +00:00
Yura Zenevich a26dda1735 Bug 1541446 - added audited event to AccessibleActor/Front. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D26457

--HG--
extra : moz-landing-system : lando
2019-04-10 00:58:24 +00:00
Alexandre Poirot 859279017c Bug 1541819 - Expose the number of still-allocated objects via the allocation tracker. r=jdescottes
Depends on D26106

Differential Revision: https://phabricator.services.mozilla.com/D26107

--HG--
extra : moz-landing-system : lando
2019-04-09 18:58:29 +00:00
Alexandre Poirot 93a3d67506 Bug 1541819 - Ship allocation-tracker when running tests and test it. r=jdescottes
Using official build flag was breaking tests on try as the builds
are done with the official build flag turned on.
Convert this module into a "supports" file, like other test-only files.
And also introduce a test for this module. It helps as we have to have
a browser.ini file in order to reference allocation-tracker.js,
and you can't have a browser.ini without any test in it.

Depends on D26105

Differential Revision: https://phabricator.services.mozilla.com/D26106

--HG--
extra : moz-landing-system : lando
2019-04-09 18:58:27 +00:00
Alexandre Poirot 1b208f0f0e Bug 1541819 - Allow the loader to load modules in a distinct system compartment. r=jdescottes
Depends on D26104

Differential Revision: https://phabricator.services.mozilla.com/D26105

--HG--
extra : moz-landing-system : lando
2019-04-09 18:58:25 +00:00
Alexandre Poirot 74167a96b0 Bug 1541819 - Allow tracking memory only for one global or only DevTools ones. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D26104

--HG--
extra : moz-landing-system : lando
2019-04-09 18:58:23 +00:00
Oriol Brufau 0c1218e4d5 Bug 1541422 - Escape special characters in autocomplete. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D26617

--HG--
extra : moz-landing-system : lando
2019-04-09 16:46:34 +00:00
Alexandre Poirot 953f28d1a8 Bug 1540694 - Fix DEBUG_DEVTOOLS_ALLOCATIONS now that DevTools share the unique system compartment. r=jdescottes
In bug 1517210, DevTools started sharing the same compartment than JSMs.
So we can no longer use a Debugger instance bound to jsdebugger.jsm as it
would run in the same compartment than DevTools code we want to inspect
from the allocation tracker.
Instead, we instantiate the Debugger from a custom Sandbox loaded
in a unique and distinct compartment.

Depends on D26077

Differential Revision: https://phabricator.services.mozilla.com/D26078

--HG--
extra : moz-landing-system : lando
2019-04-09 08:41:19 +00:00
Noemi Erli dd7e27f4a8 Merge inbound to mozilla-central. a=merge 2019-04-09 12:55:19 +03:00
Brian Hackett 7154d679ab Bug 1542659 Part 1 - Hook require() when replaying, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D26451

--HG--
extra : rebase_source : 6697485b1dc098d6b276957953b537bfdcfb1109
2019-04-07 16:00:49 -10:00
Micah Tigley 270557bf86 Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl
Differential Revision: https://phabricator.services.mozilla.com/D25142

--HG--
extra : moz-landing-system : lando
2019-04-08 20:22:12 +00:00
Dorel Luca ca1e4e263d Backed out changeset 4fef2150bef9 (bug 1534984) for DevTools Failures in devtools/client/responsive.html/test/browser/browser_toolbox_swap_browsers.js. CLOSED TREE 2019-04-08 19:23:02 +03:00
Micah Tigley a17d89a9d3 Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl
Differential Revision: https://phabricator.services.mozilla.com/D25142

--HG--
extra : moz-landing-system : lando
2019-04-08 14:58:57 +00:00
Brian Hackett f4af857cef Bug 1497393 Part 7 - Server side changes for inspector support while replaying, r=pbro.
Differential Revision: https://phabricator.services.mozilla.com/D22863

--HG--
extra : rebase_source : 1069a8534dd79e1d2cf309c9d3f3c27079077087
extra : histedit_source : 1a750a022d46da836181f913d012081ea608da7f
2019-03-09 16:45:50 -10:00
Brian Hackett eefdeac0e8 Bug 1497393 Part 5 - Add ReplayInspector module for accessing objects in a replaying process, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22861

--HG--
extra : rebase_source : 63c20073bb6e76d882ed0719e550685b2874a28e
2019-03-09 16:41:32 -10:00
Brian Hackett f5672e6b59 Bug 1497393 Part 2 - Tweak definition of target.isReplayEnabled(), r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22858

--HG--
extra : rebase_source : a8d0aeaf08920454dd27084c3e1663719d0116bf
2019-03-09 16:38:34 -10:00
Brian Hackett 0e51aaf966 Bug 1497393 Part 1 - Add isReplaying global to server bindings, r=loganfsmyth.
Differential Revision: https://phabricator.services.mozilla.com/D22857

--HG--
extra : rebase_source : 14b0daad9f6ef4f372b44e0081bd5ff9b1d270cf
2019-03-09 16:37:20 -10:00
Gerald Squelart e1bd1f5588 Bug 1429613 - Using upgraded Variant::match where appropriate - r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D24891

--HG--
extra : moz-landing-system : lando
2019-04-02 11:53:55 +00:00
Gerald Squelart e2d15a1cfb Bug 1429613 - Variant matcher callbacks renamed from `match` to `operator()` - r=froydnj
Mechanical change from Matcher::match(...) to Matcher::operator()(...).
This will now permit the use of generic lambdas, and facilitate the
implementation of multi-lambda match.

Differential Revision: https://phabricator.services.mozilla.com/D24889

--HG--
extra : moz-landing-system : lando
2019-04-02 11:53:47 +00:00
Ian Moody adf896c1ab Bug 1539265 - Don't represent ::marker pseudo-elements with the internal _moz_generated_content_marker tagName in the markup view. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25108

--HG--
extra : moz-landing-system : lando
2019-04-02 07:45:55 +00:00
Ian Moody 85f74da0e4 Bug 1539265 - Add a few optimisations for ::marker pseudos. r=jdescottes
Where there is existing for ::before and ::after.

Differential Revision: https://phabricator.services.mozilla.com/D25107

--HG--
extra : moz-landing-system : lando
2019-04-02 07:45:53 +00:00
Ian Moody 53e960c394 Bug 1539265 - Add isMarkerPseudoElement function to layout/utils.js. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25105

--HG--
extra : moz-landing-system : lando
2019-04-02 07:45:38 +00:00
Ian Moody 71b7e1fa5d Bug 1539265 - Handle ::marker pseudo-elements in css-logic.js, so their rules show in the rule view. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25071

--HG--
extra : moz-landing-system : lando
2019-04-02 07:45:31 +00:00
arthur.iakab cf3b3f1eb5 Backed out 11 changesets (bug 1539265) for causing debugger failures CLOSED TREE
Backed out changeset 8206b880f9ec (bug 1539265)
Backed out changeset be9f5f73bdfe (bug 1539265)
Backed out changeset f78146b8aa17 (bug 1539265)
Backed out changeset 18fa7e971a0d (bug 1539265)
Backed out changeset 6eaf5bdd945c (bug 1539265)
Backed out changeset 3add7d4d4853 (bug 1539265)
Backed out changeset 8015aeb5279d (bug 1539265)
Backed out changeset 19c8e404ac5f (bug 1539265)
Backed out changeset 637a9d6af0f3 (bug 1539265)
Backed out changeset 72bbb4b28932 (bug 1539265)
Backed out changeset 931e98129878 (bug 1539265)
2019-04-02 02:44:43 +03:00
Ian Moody efc53df901 Bug 1539265 - Don't represent ::marker pseudo-elements with the internal _moz_generated_content_marker tagName in the markup view. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25108

--HG--
extra : moz-landing-system : lando
2019-04-01 21:45:49 +00:00
Ian Moody 76dd66e399 Bug 1539265 - Add a few optimisations for ::marker pseudos. r=jdescottes
Where there is existing for ::before and ::after.

Differential Revision: https://phabricator.services.mozilla.com/D25107

--HG--
extra : moz-landing-system : lando
2019-04-01 21:45:44 +00:00
Ian Moody addac983bb Bug 1539265 - Add isMarkerPseudoElement function to layout/utils.js. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25105

--HG--
extra : moz-landing-system : lando
2019-04-01 21:45:33 +00:00
Ian Moody 8e985aa314 Bug 1539265 - Handle ::marker pseudo-elements in css-logic.js, so their rules show in the rule view. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D25071

--HG--
extra : moz-landing-system : lando
2019-04-01 21:45:28 +00:00
Philip Chimento 7262bcdffb Bug 1506324 - Use DefaultGlobalClassOps in existing code. r=tcampbell
Reviewers: tcampbell

Subscribers: jandem

Bug #: 1506324

Differential Revision: https://phabricator.services.mozilla.com/D11571
2019-03-31 15:30:45 -07:00
Patrick Brosset bcfd6cd961 Bug 1409085 - Tell RDM when picking to stop simulating touch; r=mtigley,gl
Differential Revision: https://phabricator.services.mozilla.com/D25231

--HG--
extra : moz-landing-system : lando
2019-03-29 09:47:35 +00:00
Julian Descottes b3ffc1fee6 Bug 1538708 - Stop storing sockets in adb-client.js;r=ochameau
The client close() method is not used anywhere. Individual callers should be responsible for closing opened sockets if needed.
Removing this method and the _sockets array, we no longer leak strings when calling adb.updateRuntimes()

Differential Revision: https://phabricator.services.mozilla.com/D25213

--HG--
extra : moz-landing-system : lando
2019-03-28 15:21:21 +00:00
Christoph Kerschbaumer 64005a8818 Bug 1524970: Update more frontend code to explicitly pass a csp. r=Gijs,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D24959

--HG--
extra : moz-landing-system : lando
2019-03-27 16:38:01 +00:00
Yoshi Cheng-Hao Huang 7f012345b7 Bug 1521732 - Part 5: RootedObjectVector. r=sfink,jonco
s/AutoObjectVector/RootedObjectVector/g

Depends on D23185

Differential Revision: https://phabricator.services.mozilla.com/D23186

--HG--
extra : moz-landing-system : lando
2019-03-26 14:00:51 +00:00
Yoshi Cheng-Hao Huang edbc333422 Bug 1521732 - Part 3: Use RootedValueVector instead. r=sfink,jonco
s/AutoValueVector/RootedValueVector/g

Depends on D23183

Differential Revision: https://phabricator.services.mozilla.com/D23184

--HG--
extra : moz-landing-system : lando
2019-03-26 13:58:20 +00:00
Michael Ratcliffe 639bed7bb2 Bug 1509620 - Computed style inspector CSS cascade calculation is wrong r=ladybenko
### Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1bad5e5282812225da95c0ea9e2ef173640b5da

### Summary

!!Comparing numerous complex websites such as github, facebook, cnn etc. the cascade now matchers that of Chrome so we are in a much better place.!!

According to https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading we should now be doing this (descending order):

  - Transition declarations
  - User-Agent & !important
  - User & !important
  - Author & !important
  - CSS Animations, @keyframes
  - Author, normal weight
  - User, normal weight
  - User-Agent, normal weight
  - specificity
  - Sheet Index
  - Rule Line
  - Rule Column

We are only dealing with CSS selectors here so we can safely drop Transition declarations and CSS Animations because their presence here is irrelevant when it comes to the CSS cascade information we display in the computed view.

This leaves us with:

  - User-Agent & !important
  - User & !important
  - Author & !important
  - Author, normal weight
  - User, normal weight
  - User-Agent, normal weight
  - specificity
  - Sheet Index
  - Rule Line
  - Rule Column

### Changes

- References to content stylesheets have been changed to author stylesheet to closely match the technical terms author, user and agent stylesheets.
- Simplified and modernized a bunch of for loops to make the code easier to understand.
- Previous to these changes all matching parent rules were classed as equal e.g. color on the body tag was equal to color on a node's immediate container. We now use the `distance` variable to tell how close a rule is to the current node. This is the highest qualifier in our cascade calculation.
- The `_agentSheet`, `_authorSheet` and `_userSheet` properties are now used to obtain a sheets origin.
- `elementStyle` was renamed to `inlineStyle` in order to correctly identify the rule's origin.
- We used to sort the matchedSelectors to move rules with `STATUS.MATCHED` above `STATUS.PARENT_MATCH` but this is unnecessary now that we have the `distance` property so we no longer do this.
- The `compareTo()` method has been updated to match https://www.w3.org/TR/css-cascade-3/#cascading (which platform follows now) and https://www.w3.org/TR/css-cascade-4/#cascading. It has also been simplified and made far less prone to error.

Differential Revision: https://phabricator.services.mozilla.com/D23711

--HG--
extra : moz-landing-system : lando
2019-03-25 16:32:19 +00:00
arthur.iakab ee02cd6515 Merge inbound to mozilla-central a=merge 2019-03-25 17:53:27 +02:00
Julian Descottes 9fc4dd6f7a Bug 1528912 - Do not stop ADB when closing aboutdebugging or webide;r=daisuke
It looks like we don't need to stop ADB. Most of the logic can stay, in order to start and stop the devices polling.

Differential Revision: https://phabricator.services.mozilla.com/D24398

--HG--
extra : moz-landing-system : lando
2019-03-25 08:05:18 +00:00
sakshaat d781937a67 Bug 1517483 - Get rid of nsIScriptSecurityManager::IsSystemPrincipal r=bzbarsky
Replaced instances of callers in both C++ and JS files to query the state from the principal directly.

Differential Revision: https://phabricator.services.mozilla.com/D22532

--HG--
extra : moz-landing-system : lando
2019-03-24 20:36:25 +00:00
Daisuke Akatsuka 0a497fb56e Bug 1114929: Add a test for multiline comment. r=pbro
Depends on D24118

Differential Revision: https://phabricator.services.mozilla.com/D24119

--HG--
extra : moz-landing-system : lando
2019-03-21 09:18:31 +00:00
Daisuke Akatsuka 2f478513a6 Bug 1114929: Apply line count of comments. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D24118

--HG--
extra : moz-landing-system : lando
2019-03-20 22:31:14 +00:00
Julian Descottes ef7c431b40 Bug 1531704 - Remove isClosed flag from WorkerTargetFront r=ochameau
Depends on D21673

The test is already relying on events triggered by the destroy method of the front to progress
I don't think having a flag brings anything here.

Differential Revision: https://phabricator.services.mozilla.com/D21675

--HG--
extra : moz-landing-system : lando
2019-03-21 07:54:03 +00:00
Julian Descottes d9c03fac20 Bug 1531704 - Stop calling WorkerTargetFront::destroy() from detach() r=ochameau
Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=02f79fac79a313124cfe6368812e84d823fab685

Differential Revision: https://phabricator.services.mozilla.com/D21673

--HG--
extra : moz-landing-system : lando
2019-03-21 07:52:15 +00:00
Oana Pop Rus b01d230f27 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-25 12:04:50 +02:00
Mats Palmgren 53f517142f Bug 205202 part 1 - [css-lists][css-pseudo] Add support for the ::marker pseudo element on list items. Alias :-moz-list-bullet/number to that in the parser. r=emilio 2019-03-24 23:13:53 +01:00
Mats Palmgren 426b73e37a Bug 1518201 - [css-lists] Implement the counter-set property. r=emilio 2019-03-24 23:13:52 +01:00
Patrick Brosset dff1494aa0 Bug 1536834 - Remove leftover csscoverage code; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D24191

--HG--
extra : moz-landing-system : lando
2019-03-20 16:06:59 +00:00
Daniel Holbert e76186a6e9 Bug 1532471 part 2: Enable CSS containment for early beta and earlier. r=emilio
Depends on D23362

Differential Revision: https://phabricator.services.mozilla.com/D23363

--HG--
extra : moz-landing-system : lando
2019-03-19 17:35:45 +00:00
Francesco Lodolo (:flod) 618c926865 Bug 1533688 - Sync DevTools plural-form.js with intl/PluralForm.jsm (add rule #19) r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D22673

--HG--
extra : moz-landing-system : lando
2019-03-19 08:41:43 +00:00
Emilio Cobos Álvarez 09763b1ac3 Bug 1533201 - Make cssPropertySupportsType take an enum. r=heycam,rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D22427

--HG--
extra : moz-landing-system : lando
2019-03-18 16:38:48 +00:00
yulia 994e78fd2f Bug 1532567 - remove unused eval method from threadClient and threadActor; r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D21700

--HG--
extra : moz-landing-system : lando
2019-03-12 15:03:47 +00:00
yulia d8f0e4a4eb Bug 1528296 - remove unused function call r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D22497

--HG--
extra : moz-landing-system : lando
2019-03-13 16:52:10 +00:00
yulia 58c5e6cec7 Bug 1403944 - Remove Web Audio Editor actor and spec; r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D19528

--HG--
extra : moz-landing-system : lando
2019-03-13 16:49:15 +00:00
yulia 824ce51c8e Bug 1403944 - Remove Web Audio Editor front and panel; r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D19527

--HG--
extra : moz-landing-system : lando
2019-03-13 16:48:42 +00:00
yulia 12c5ac3425 Bug 1342237 - remove Shader Editor Actor and Front; r=vporof
Depends on D14732

Differential Revision: https://phabricator.services.mozilla.com/D14734

--HG--
extra : moz-landing-system : lando
2019-03-13 16:47:48 +00:00
yulia 83e3a56687 Bug 1403938 - remove Canvas Debugger actor from the server; r=vporof
Depends on D14730

Differential Revision: https://phabricator.services.mozilla.com/D14731

--HG--
extra : moz-landing-system : lando
2019-03-13 16:46:42 +00:00
Edouard Oger d391c790bc Bug 1532514 - Update sinon to v7.2.7. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D22046

--HG--
extra : moz-landing-system : lando
2019-03-12 19:32:40 +00:00
Jason Laster d11dedc8c5 Bug 1532791 - Breaking on exception even if option is off. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D22186

--HG--
extra : moz-landing-system : lando
2019-03-12 19:01:40 +00:00
Ciure Andrei 1cea309572 Backed out changeset e2316f37b988 (bug 1532791)for perma failing test_blackboxing-05.js, test_pause_exceptions-01.js CLOSED TREE 2019-03-12 19:45:39 +02:00
Ciure Andrei 9f4ebc07f7 Backed out 13 changesets (bug 1342237, bug 1403944, bug 1403938, bug 1528296) for subsuite gpu failures CLOSED TREE
Backed out changeset eee6b5f77d67 (bug 1528296)
Backed out changeset 285c56c29146 (bug 1528296)
Backed out changeset 47fff0f9b424 (bug 1528296)
Backed out changeset cebff9f6f811 (bug 1528296)
Backed out changeset 78be67cfabe8 (bug 1528296)
Backed out changeset 3e055733ee57 (bug 1528296)
Backed out changeset 2d321819c273 (bug 1528296)
Backed out changeset c8fcdc7c2e0b (bug 1403944)
Backed out changeset f1003c2742c2 (bug 1403944)
Backed out changeset 06a583daf142 (bug 1342237)
Backed out changeset f75b89bf0aa4 (bug 1342237)
Backed out changeset 90579bc6554c (bug 1403938)
Backed out changeset 488d49d434f8 (bug 1403938)
2019-03-12 18:57:01 +02:00
Jason Laster 34482fc99e Bug 1532791 - Breaking on exception even if option is off. r=davidwalsh
Differential Revision: https://phabricator.services.mozilla.com/D22186

--HG--
extra : moz-landing-system : lando
2019-03-12 15:41:39 +00:00
yulia f70aa72ebf Bug 1529247 - remove unused cachedScript property; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D21672

--HG--
extra : moz-landing-system : lando
2019-03-12 14:02:05 +00:00
yulia 408d434de2 Bug 1529247 - remove unused releaseMany method from thread client and actor; r=ochameau
There is one spot I am unsure about, and that is the test:
devtools/server/tests/unit/test_threadlifetime-06.js -- should this be kept or do we want to remove
it as well?

Differential Revision: https://phabricator.services.mozilla.com/D21674

--HG--
extra : moz-landing-system : lando
2019-03-12 14:06:35 +00:00
Razvan Caliman 4626e42237 Bug 1534567 - Ensure inherited CSS variables are case sensitive; r=pbro
Bug 1512634 introduced a case-insensitive check for CSS properties. This caused a regression whereby inherited CSS variables with mixed case were incorrectly unmatched when shown in the Rules view.

To fix this, we do a strict check for CSS variables in CSSProperties front because they are case sensitive (--color and --COLOR are different CSS variables).
See: https://www.w3.org/TR/css-variables-1/
> Unlike other CSS properties, custom property names are case-sensitive.

Differential Revision: https://phabricator.services.mozilla.com/D23113

--HG--
extra : moz-landing-system : lando
2019-03-12 13:45:00 +00:00
yulia 1ce2d19ed1 Bug 1528296 - remove unused function call r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D22497

--HG--
extra : moz-landing-system : lando
2019-03-12 15:00:29 +00:00
yulia fe4252e6e1 Bug 1403944 - Remove Web Audio Editor actor and spec; r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D19528

--HG--
extra : moz-landing-system : lando
2019-03-12 14:52:33 +00:00
yulia f3cd627b57 Bug 1403944 - Remove Web Audio Editor front and panel; r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D19527

--HG--
extra : moz-landing-system : lando
2019-03-12 14:50:18 +00:00
yulia ade28a1f24 Bug 1342237 - remove Shader Editor Actor and Front; r=vporof
Depends on D14732

Differential Revision: https://phabricator.services.mozilla.com/D14734

--HG--
extra : moz-landing-system : lando
2019-03-12 14:49:53 +00:00
yulia 0d4cd33f2f Bug 1403938 - remove Canvas Debugger actor from the server; r=vporof
Depends on D14730

Differential Revision: https://phabricator.services.mozilla.com/D14731

--HG--
extra : moz-landing-system : lando
2019-03-12 14:47:07 +00:00
Dorel Luca eb794cd9b8 Backed out changeset 4b280518c7b1 (bug 1532514) for Browser-chrome failures in browser/components/syncedtabs/test/browser/browser_sidebar_syncedtabslist.js. CLOSED TREE 2019-03-12 03:59:56 +02:00
Edouard Oger 565385661c Bug 1532514 - Update sinon to v7.2.7. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D22046

--HG--
extra : moz-landing-system : lando
2019-03-12 00:18:16 +00:00
Emilio Cobos Álvarez 0b5807bc62 Bug 1215878 - Implement CSS revert keyword. r=heycam,birtles
The only fishy bit is the animation stuff. In particular, there are two places
where we just mint the revert behavior:

 * When serializing web-animations keyframes (the custom properties stuff in
   declaration_block.rs). That codepath is already not sound and I wanted to
   get rid of it in bug 1501530, but what do I know.

 * When getting an animation value from a property declaration. At that point
   we no longer have the CSS rules that apply to the element to compute the
   right revert value handy. It'd also use the wrong style anyway, I think,
   given the way StyleBuilder::for_animation works.

   We _could_ probably get them out of somewhere, but it seems like a whole lot
   of code reinventing the wheel which is probably not useful, and that Blink
   and WebKit just cannot implement either since they don't have a rule tree,
   so it just doesn't seem worth the churn.

The custom properties code looks a bit different in order to minimize hash
lookups in the common case. FWIW, `revert` for custom properties doesn't seem
very useful either, but oh well.

Differential Revision: https://phabricator.services.mozilla.com/D21877

--HG--
extra : moz-landing-system : lando
2019-03-07 11:59:36 +00:00
sole ec976d82a9 Bug 1522511 - [remote-dbg-next] Do not prevent service-worker debugging if new sw implementation is enabled r=ladybenko
Take into account new service worker implementation to decide if workers can be debugged

Differential Revision: https://phabricator.services.mozilla.com/D20677

--HG--
extra : moz-landing-system : lando
2019-03-07 09:35:52 +00:00
Alexandre Poirot e81a254114 Bug 1532237 - Use a Debugger loaded in a distinct compartment when debugging chrome in the event collector codebase. r=miker
Now that the server is by default loaded in the shared system compartment,
we have to special cases the code debugging system compartments.
When devtools.chrome.enabled is turned on, the event collector is
inspecting the system compartment's event listener.
In this case, we are using a special Debugger instance loaded in
a sandbox flagged with invisibleToDebugger=true. This forces loading it
in a distinct compartment and helps the debugger know about the boundaries
between debugger and debuggee code.
It should be safe to only load the Debugger and not the whole server here
as event collector is only inspecting and doesn't register any callback on
the Debugger API.

Differential Revision: https://phabricator.services.mozilla.com/D22070

--HG--
extra : moz-landing-system : lando
2019-03-05 14:58:05 +00:00
Alexandre Poirot 24ef486f1d Bug 1530861 - Fix typo in deprecated firefox version comment. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D21511

--HG--
extra : moz-landing-system : lando
2019-03-05 11:13:28 +00:00
yulia 6f475afa31 Bug 1529247 - remove unused eventlisteners method; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D21703

--HG--
extra : moz-landing-system : lando
2019-03-05 10:42:20 +00:00
Brian Hackett 448cf790fe Bug 1522244 - Fix previewing in worker threads for several builtin classes, r=lsmyth. 2019-03-03 07:05:07 -10:00
Dorel Luca 5d73bddbc6 Merge mozilla-central to autoland 2019-03-02 01:23:22 +02:00
Daniel Varga 74f08acf9b Backed out changeset 4047bcadec73 (bug 1522244) for mochitest failure at devtools/client/debugger/new/test/mochitest/browser_dbg-worker-scopes.js a=backout
--HG--
extra : rebase_source : 3ad963907a2364fa351e67b957f49d3d754e5efb
2019-03-02 00:01:01 +02:00
Gurzau Raul cdf9392948 Merge inbound to mozilla-central. a=merge 2019-03-01 15:01:31 +02:00
Emilio Cobos Álvarez 3d044b1111 Bug 1296042 - Make word-break: break-word behave like word-break: normal; overflow-wrap: anywhere. r=jfkthame
Differential Revision: https://phabricator.services.mozilla.com/D21398

--HG--
extra : moz-landing-system : lando
2019-03-01 02:33:07 +00:00
Logan Smyth 6a327e3d2b Bug 1531874 - Add a no-op event-breakpoint API. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D21764

--HG--
extra : moz-landing-system : lando
2019-03-01 19:47:25 +00:00
yulia beb91522fe Bug 1529247 - clean up frames methods on thread client; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D20834

--HG--
extra : moz-landing-system : lando
2019-03-01 15:26:18 +00:00
Gurzau Raul 6b94d177d1 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-01 09:28:28 +02:00
Razvan Caliman 9aba44b1e3 Bug 1529599 - (Part 2) Rename Copy Property Declaration to Copy Declaration in Rules panel context menu; r=gl
Depends on D21526
This is a request from @mbalfanz in order to keep the naming of the option consistent.
This patch just replaces the l10n string and renames all the places where copyPropertyDeclaration is used in order to avoid confusion.

No functional changes are introduced.

Differential Revision: https://phabricator.services.mozilla.com/D21527

--HG--
extra : moz-landing-system : lando
2019-02-28 17:31:54 +00:00
Alexandre Poirot b37d7ca095 Bug 1517210 - Stop always loading DevTools modules in fresh compartments. r=jandem,nchevobbe
Now, DevTools server is loaded with a custom loader every time we want to debug chrome
resources. We ensure toggling the "invisibleToDebugger" flag on Loader.jsm which itself
propagates to DevTools Sandboxes.

We added calls to force GC in console test to prevent crashes on Windows 7.

Differential Revision: https://phabricator.services.mozilla.com/D20347

--HG--
extra : moz-landing-system : lando
2019-02-28 16:03:26 +00:00
Alexandre Poirot 567eb5fdc3 Bug 1530861 - Acknowledged newSource events sent by remote devices on FF66 and less. r=jdescottes
newSource events used to be sent on the target actors on FF66 and before,
this is no longer the case. But we still have to accept them if we connect
to old remotes, otherwise the events are considered as a method reply
and confuses packet ordering.

Differential Revision: https://phabricator.services.mozilla.com/D21394

--HG--
extra : moz-landing-system : lando
2019-02-28 08:25:36 +00:00
Julian Descottes 8afe065885 Bug 1524731 - Fix ADB tests in aarch64;r=m_kato
Differential Revision: https://phabricator.services.mozilla.com/D21424

--HG--
extra : moz-landing-system : lando
2019-02-28 07:07:55 +00:00
Jonathan Kingston f6680698bd Bug 1525319 - Removing context from OnDataAvailable r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20881

--HG--
extra : moz-landing-system : lando
2019-02-27 23:42:27 +00:00
Jonathan Kingston dd4c731d8c Bug 1525319 - Changing js to remove context from onStartRequest and onStopRequest r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D20771

--HG--
extra : moz-landing-system : lando
2019-02-27 23:41:54 +00:00
Razvan Caliman 294be58640 Bug 1530972 - Remove obsolete modifySelctor2 method from StyleRule actor, front and spec. r=gl
Differential Revision: https://phabricator.services.mozilla.com/D21342

--HG--
extra : moz-landing-system : lando
2019-02-27 15:33:33 +00:00
Alexandre Poirot f439c41435 Bug 1520835 - Removed now-useless front pool from DebuggerClient. r=jdescottes
Depends on D20704

Differential Revision: https://phabricator.services.mozilla.com/D20705

--HG--
extra : moz-landing-system : lando
2019-02-22 18:32:38 +00:00
Alexandre Poirot 252ea7758f Bug 1520835 - Remove unused attachTarget methods. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D20704

--HG--
extra : moz-landing-system : lando
2019-02-22 18:32:52 +00:00
Nicolas Chevobbe afd0f67662 Bug 1529497 - Remove `promise` and `defer` usage in `devtools/shared/DevToolsUtils.js`; r=yulia.
The `yieldingEach` is moved into the only file that
is using it, in canvas debugger, and is not migrated
as the panel will be removed in a few months.

Differential Revision: https://phabricator.services.mozilla.com/D20641

--HG--
extra : moz-landing-system : lando
2019-02-27 13:28:16 +00:00
yulia 69d42691df Bug 1529247 - remove unused getPrototypesAndProperties method; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D20835

--HG--
extra : moz-landing-system : lando
2019-02-26 16:24:49 +00:00
Ryan Hunt 83a1b0c542 Bug 1523969 part 4 - Move method definition inline comments to new line in 'devtools/'. r=fitzgen
Differential Revision: https://phabricator.services.mozilla.com/D21104

--HG--
extra : rebase_source : 441d0a75c2bfda6e170cb325106ea945d9a7cb10
2019-02-25 16:04:29 -06:00
Oana Pop Rus 775c1e3f87 Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-03-01 00:08:19 +02:00
Brian Hackett 75c921ea5c Bug 1522244 - Fix previewing in worker threads for several builtin classes, r=lsmyth.
--HG--
extra : rebase_source : cdd1d02a69a17709aff17ac2d6d13f6f0039d5bb
2019-02-28 06:24:46 -10:00
Brian Hackett 70866753cc Bug 1523262 Part 2 - Provide atob/btoa in worker debugger scope, r=lsmyth,baku.
--HG--
extra : rebase_source : 41a30811bee43bfb5ac9fe1e98868b335d607073
2019-02-21 17:25:39 -10:00
Razvan Caliman 38e6367521 Bug 1512956 - Ensure empty string is considered valid CSS authoredText; r=pbro
When removing all declarations from a rule via the Rule view, the authoredText value ends up as an empty string.
This patch ensures that the fallback cssText is not used in that case because that accidentally restores the whole declaration block when re-parsing the text of the rule.

Differential Revision: https://phabricator.services.mozilla.com/D14753

--HG--
extra : moz-landing-system : lando
2019-02-25 09:49:41 +00:00
Brian Hackett e2c9ceed8d Bug 1447244 Part 2 - Track source ID in saved frames, r=jimb.
--HG--
extra : rebase_source : 6d585a37588dae528e0d37d53d0629f9b509e82d
2019-01-16 11:59:03 -10:00
yulia f1efb1c816 Bug 1529247 - Remove environment method from the threadClient; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D20467

--HG--
extra : moz-landing-system : lando
2019-02-22 16:13:54 +00:00
Alexandre Poirot 2ffe546245 Bug 1269919 - Stop emitting newSource on the target actors. r=jdescottes
Now that the base Target class is managing the thread client,
we no longer have to send "newSource" on the target actor, and instead,
listen for newSource directly on the thread client.
We should probably align updatedSource and have this event being emitted on
the thread actor as well.

Depends on D18813

Differential Revision: https://phabricator.services.mozilla.com/D18814

--HG--
extra : moz-landing-system : lando
2019-02-21 18:41:08 +00:00
Alexandre Poirot 412b285031 Bug 1269919 - Unify all the attachThread methods on Target class. r=jdescottes
There is still some tight connection between ThreadClient and Target,
- Target.threadClient, which should ideally disappear in favor of
  target.getFront("thread")
- Target.threadClient is manually nullified from ThreadClient.detach,
  but that should disappear as well thanks to getFront.

Differential Revision: https://phabricator.services.mozilla.com/D18813

--HG--
extra : moz-landing-system : lando
2019-02-21 15:05:49 +00:00
Razvan Caliman a2b510c934 Bug 1524547 - (Part 2) Add context menu option to copy the contents of a changed CSS rule. r=gl
Depends on D20195

This series of patches depends on the patch from [Bug 1525238](https://bugzilla.mozilla.org/show_bug.cgi?id=1525238)

- adds method to identify a CSS Rule actor by id
- adds context menu option to the Changes panel to allow copying the rule's authored text to the clipboard

Differential Revision: https://phabricator.services.mozilla.com/D20196

--HG--
extra : moz-landing-system : lando
2019-02-20 21:45:03 +00:00
Razvan Caliman aa000809a8 Bug 1524547 - (Part 1) Add method to StyleRuleActor to get complete authored text for a CSS rule. r=gl
This series of patches depends on the patch from [Bug 1525238](https://bugzilla.mozilla.org/show_bug.cgi?id=1525238)

This patch adds a new method to the StyleRuleActor on the server to expose the full text content of a CSS rule over the protocol to the client. This means exposing the CSS rule's authored text including comments and any nested rules if the target rule is an ancestor rule, like @media or @supports.

There's minor refactoring to include additional rule types for which StyleRuleActors will be created: @supports, @media, @keyframes. These are not explicitly rendered in the Rule view and shouldn't impact it. The Rule view filters for CSS Style Rules, element inline style and has special handling for keyframe at-rules.

Differential Revision: https://phabricator.services.mozilla.com/D20195

--HG--
extra : moz-landing-system : lando
2019-02-20 20:41:44 +00:00
yulia eed3621d24 Bug 1485664 - guard webconsole destroy method from being called when there is no client; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D20152

--HG--
extra : moz-landing-system : lando
2019-02-20 10:28:23 +00:00
yulia e7f1f95776 Bug 1485664 - remove attachConsole from the debugger client; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D20150

--HG--
extra : moz-landing-system : lando
2019-02-20 10:27:50 +00:00
yulia 1c4e7ce305 Bug 1485664 - move webconsole client to front directory; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18838

--HG--
rename : devtools/shared/webconsole/client.js => devtools/shared/fronts/webconsole.js
extra : moz-landing-system : lando
2019-02-19 16:00:45 +00:00
yulia 63ec6c691d Bug 1485664 - Change "attachConsole" in the debuggerClient so that it is compatible with a front; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18837

--HG--
extra : moz-landing-system : lando
2019-02-19 16:04:30 +00:00
yulia d9e63a9d50 Bug 1485664 - remove from field from jsterm tests; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18836

--HG--
extra : moz-landing-system : lando
2019-02-19 15:59:41 +00:00
yulia d3412c26b4 Bug 1485664 - use protocol js methods instead of hard coding it in the console front; r=ochameau
Just updating the stubs for tests

Differential Revision: https://phabricator.services.mozilla.com/D18835

--HG--
extra : moz-landing-system : lando
2019-02-19 15:58:25 +00:00
yulia 56b3c13f02 Bug 1485664 - adjust webconsole-connection-proxy to listen to webconsole front events, and fix r=ochameau
tests; r=ochameau

this migrates the proxy to the new webconsole front events. This resulted in a number of
test failures once the migration was finished, and those were fixed

Differential Revision: https://phabricator.services.mozilla.com/D18834

--HG--
extra : moz-landing-system : lando
2019-02-19 15:57:52 +00:00
yulia aed02d496b Bug 1485664 - adjust events to front events; r=ochameau
this patch introduces events for the webconsoleFront -- not all of them are being listened
to by their subscribers yet, but this is the bulk of the effort to move events to Protocol.js

Differential Revision: https://phabricator.services.mozilla.com/D18832

--HG--
extra : moz-landing-system : lando
2019-02-20 10:49:09 +00:00
yulia e3b15c8fe4 Bug 1485664 - remove echoed events and unused events; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18830

--HG--
extra : moz-landing-system : lando
2019-02-20 10:49:03 +00:00
yulia 2f32d68c4c Bug 1485664 - convert webconsoleClient to front; r=ochameau
initial move of the webconsoleClient to a front. Events do not work yet, but methods do.

Differential Revision: https://phabricator.services.mozilla.com/D18829

--HG--
extra : moz-landing-system : lando
2019-02-19 15:54:37 +00:00
Dorel Luca 44f23b0508 Backed out changeset 67fac975c2f8 (bug 1517210) for devtools failures in devtools/client/inspector/rules/test/browser_rules_user-agent-styles.js. CLOSED TREE 2019-02-19 23:59:32 +02:00
Alexandre Poirot e3b1b7660f Bug 1517210 - Stop always loading DevTools modules in fresh compartments. r=jandem,nchevobbe
Now, DevTools server is loaded with a custom loader every time we want to debug chrome
resources. We ensure toggling the "invisibleToDebugger" flag on Loader.jsm which itself
propagates to DevTools Sandboxes.

We added calls to force GC in console test to prevent crashes on Windows 7.

Differential Revision: https://phabricator.services.mozilla.com/D20347

--HG--
extra : moz-landing-system : lando
2019-02-19 16:09:48 +00:00
Hiroyuki Ikezoe 64a777f7b5 Bug 1528834 - Implement scroll-snap-align parser and serializer. r=emilio
https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align

Differential Revision: https://phabricator.services.mozilla.com/D20205

--HG--
extra : moz-landing-system : lando
2019-02-18 23:10:08 +00:00
Hiroyuki Ikezoe 0a5721ad9c Bug 1528640 - Implement scroll-padding parser and serializer. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D20103

--HG--
extra : moz-landing-system : lando
2019-02-18 02:46:09 +00:00
Hiroyuki Ikezoe 842f78da12 Bug 1528639 - Implement scroll-margin parser and serializer. r=emilio
The reason why we use  RelaxedAtomBoolis that
ScrollSnapUtils::GetSnapPointForDestination() is called both from the main and
the compositor threads, and the function will have a branch depending on the
pref value.

Differential Revision: https://phabricator.services.mozilla.com/D20101

--HG--
extra : moz-landing-system : lando
2019-02-18 02:25:54 +00:00
Brian Hackett f59a4bacc3 Bug 1526832 Part 2 - Use onConsoleAPICall when sending log point messages to the client, r=lsmyth.
--HG--
extra : rebase_source : 130a120fee300d6bcdd62e3b3f0f0115cb7ae3cd
2019-02-10 14:52:20 -10:00
Nicolas Chevobbe 2884ad3d7c Bug 1527238 - Speed up webconsole server's autocomplete function; r=Honza.
There are 2 changes in this patch.

In js-property-provider, we iterate over a Set
and delete item we don't want into instead of
turning the Set into an array, filter on it, and
convert it back to a new Set.

In the autocomplete function, we don't use regexp
anymore in the sort callback as we already have
a way to tell if we're performing an element access.

Differential Revision: https://phabricator.services.mozilla.com/D19471

--HG--
extra : moz-landing-system : lando
2019-02-15 15:02:51 +00:00
Julian Descottes 60c1290864 Bug 1525654 - Move version compatibility check to dedicated module and add unit-tests;r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D18934

--HG--
extra : moz-landing-system : lando
2019-02-12 18:20:40 +00:00
Yura Zenevich dcb8caf985 Bug 1518487 - ensure that accessible audit can be performed without requiring highlighting. r=pbro
MozReview-Commit-ID: CUFTQIS9WPv

Differential Revision: https://phabricator.services.mozilla.com/D19048

--HG--
extra : moz-landing-system : lando
2019-02-12 19:39:09 +00:00
Jonathan Kingston 3421b8fcff Bug 1520868 - Replacing AsyncOpen2 with AsyncOpen always r=valentin
Replacing js and text occurences of asyncOpen2
Replacing open2 with open

Differential Revision: https://phabricator.services.mozilla.com/D16885

--HG--
rename : layout/style/test/test_asyncopen2.html => layout/style/test/test_asyncopen.html
extra : moz-landing-system : lando
2019-02-12 16:08:25 +00:00
Csoregi Natalia 577b9d88b8 Backed out 7 changesets (bug 1518487) for failures on devtools/client/accessibility/test/browser/browser_accessibility_sidebar_checks.js. CLOSED TREE
Backed out changeset 7a4f96a4d71c (bug 1518487)
Backed out changeset 8031278b4a17 (bug 1518487)
Backed out changeset d55e9ed92676 (bug 1518487)
Backed out changeset fc1687cc488d (bug 1518487)
Backed out changeset 0d2800976a32 (bug 1518487)
Backed out changeset 62f78c63d9f1 (bug 1518487)
Backed out changeset bc6cc126a9b4 (bug 1518487)
2019-02-12 00:33:42 +02:00
Yura Zenevich fe0d32795e Bug 1518487 - ensure that accessible audit can be performed without requiring highlighting. r=pbro
MozReview-Commit-ID: CUFTQIS9WPv

Differential Revision: https://phabricator.services.mozilla.com/D19048

--HG--
extra : moz-landing-system : lando
2019-02-11 20:45:04 +00:00
yulia d41426aa26 Bug 1485664 - remove unused inspectObjectProperties; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D19340

--HG--
extra : moz-landing-system : lando
2019-02-11 15:48:41 +00:00
Brian Hackett 56d2836638 Bug 1524374 - Remove breakpoint actors, r=jlast.
--HG--
extra : rebase_source : 066264dbc1f73f3afb403a9c04f5b5dbd7d53613
2019-02-06 09:18:33 -10:00
Narcis Beleuzu df649fe94e Merge inbound to mozilla-central. a=merge 2019-02-09 05:35:25 +02:00
Brian Hackett 2f2cc2e383 Bug 1525685 - Remove server side breakpoint sliding code, r=jlast.
--HG--
extra : histedit_source : 926bce1cf87ccce1d586743b4f538a783dd67def%2C949bf19df412fa09cb750ec9c6ee1253616f75cd
2019-02-08 11:50:55 -10:00
Michael Ratcliffe d755ee3bf4 Bug 1524319 - Alpha values in #RRGGBBAA format can lose accuracy r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D18554

--HG--
extra : moz-landing-system : lando
2019-02-08 06:36:28 +00:00
Brindusan Cristian b35a76a700 Backed out changeset 95bfbc0f513d (bug 1525685) for xpcshell failures at test_setBreakpoint-on-line-with-no-offsets.js. 2019-02-08 20:56:34 +02:00
Brian Hackett 45faa3d507 Bug 1525685 - Remove server side breakpoint sliding code, r=jlast.
--HG--
extra : rebase_source : ed6bab4729ec9133b92bbfef8fbd594c53df0b2f
2019-02-07 14:05:12 -10:00
Brian Hackett 2698b171b3 Bug 1525482 - Remove pauseOnDOMEvents logic, r=lsmyth.
--HG--
extra : rebase_source : f38155b0fc6e18a31f0cfb7848ef71042635d793
2019-02-05 15:32:44 -10:00
Alexandre Poirot c5e4b01f95 Bug 1520774 - Remove TargetFactory.forRemoteTab. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D18539

--HG--
extra : moz-landing-system : lando
2019-02-06 16:17:15 +00:00
Michael Ratcliffe 991e8e8313 Bug 1523335 - Make use of parentFlexElement in Flexbox inspector r=pbro
This gives a very noticable increase in speed. When Brad finishes https://bugzil.la/1523336 we can stop walking the DOM and simply use `parentFlexElement` and `parentGridElement`.

#### Try

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47d38f2c7dca6ca764862c8b00921644a974a975&group_state=expanded

Differential Revision: https://phabricator.services.mozilla.com/D18674

--HG--
extra : moz-landing-system : lando
2019-02-06 17:35:20 +00:00
Jason Laster 32016ba41e Bug 1522663 - Stop referencing sourceClient.isBlackboxed. r=loganfsmyth
Differential Revision: https://phabricator.services.mozilla.com/D17549

--HG--
extra : moz-landing-system : lando
2019-02-06 05:04:37 +00:00
Jason Laster 3359b0db75 Bug 1520972 - return setOptionsRequester. r=bhackett
Differential Revision: https://phabricator.services.mozilla.com/D18770

--HG--
extra : moz-landing-system : lando
2019-02-06 16:51:01 +00:00
Alex Gaynor 0f01791ffc Bug 1512990 - Part 4 - remove declarations of Recv/Answer methods from IPDL protocol base class; r=froydnj
For cases where the class has direct calls (that is, we cast `this` to the
subclass before making the call) no longer declare Recv/Answer methods on the
base class at all. This should ensure that slots for them are not generated in
vtables, and also allow the derived class to choose the method signature (e.g.
whether it wants to take something by reference or by value).

Differential Revision: https://phabricator.services.mozilla.com/D18132

--HG--
extra : moz-landing-system : lando
2019-02-06 15:58:43 +00:00
Alex Gaynor 75c7d1fa76 Bug 1512990 - Part 2 - implement direct calls in the IPDL compiler; r=froydnj
When calling a Recv/Alloc/Dealloc method on most types, cast `this` to the
derived class.

There is a heuristic to figure out what the correct derived type is. There is a
blacklist of types which we can't do direct calls on for the moment, as well as
an override for types that do work with direct calls but which don't match the
heuristic.

Differential Revision: https://phabricator.services.mozilla.com/D16492

--HG--
extra : moz-landing-system : lando
2019-02-06 15:57:37 +00:00
Andrew Swan f527f0e6ff Bug 1504056 Part 1: Refactor AddonManager.getInstallForURL() arguments r=kmag
AddonManagergetInstallForURL() has a number of optional arguments, most
of which are passed infrequently.  Convert them from positional arguments
to a single options object.

Differential Revision: https://phabricator.services.mozilla.com/D18475

--HG--
extra : rebase_source : 503c09b54fab90cefe69286b05def43ef70074df
2019-02-01 15:23:55 -08:00
Gabriel Luong b8946f9b80 Bug 1524024 - Extract RuleRewriter into its own module. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D18359

--HG--
rename : devtools/shared/css/parsing-utils.js => devtools/shared/fronts/inspector/rule-rewriter.js
2019-02-01 11:07:25 -05:00
Gurzau Raul ee6ee38211 Backed out changeset 3d835071d160 (bug 1524024) for failing at unit/test_rewriteDeclarations.js on a CLOSED TREE 2019-02-04 19:33:10 +02:00
Gabriel Luong 00f9cbee19 Bug 1524024 - Extract RuleRewriter into its own module. r=pbro
Differential Revision: https://phabricator.services.mozilla.com/D18359

--HG--
rename : devtools/shared/css/parsing-utils.js => devtools/shared/fronts/inspector/rule-rewriter.js
2019-02-01 11:07:25 -05:00
Alexandre Poirot df5faf8f9f Bug 1465635 - Ensure removing BrowsingContextTarget front events when destroying it. r=jdescottes
When destroying the target, Target.destroy (for local tabs) only calls DebuggerClient.close,
which isn't going to call `detach`. But we still do need to unregister
the tabNavigated/frameUpdate listener to prevent unecessary event from firing.

Depends on D17609

Differential Revision: https://phabricator.services.mozilla.com/D17610

--HG--
extra : moz-landing-system : lando
2019-02-02 11:24:04 +00:00
Alexandre Poirot ef1c99b06e Bug 1465635 - Remove Target.activeTab property. r=yulia
Depends on D15831

Differential Revision: https://phabricator.services.mozilla.com/D16874

--HG--
extra : moz-landing-system : lando
2019-02-02 11:24:24 +00:00
Alexandre Poirot dddc73fb49 Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes
This patch makes it so that all target fronts inherits from a Target class mixin.
We are using a mixin as fronts should inherit from a custom Front class,
which is augmented with its own RDP request and events defined in its spec.
(This is done via FrontClassWithSpec(spec))

Depends on D15830

Differential Revision: https://phabricator.services.mozilla.com/D15831

--HG--
extra : moz-landing-system : lando
2019-02-02 11:24:32 +00:00
Michael Ratcliffe ed1053338d Bug 1522809 - Nodes with `name="attributes"` break the markup view r=rcaliman
This is another very specific issue.

If you have `<img name="attributes"/>` in the dom then `document.attributes` will return the `<img>` tag.

In the source we bail if `!this.rawNode.attributes` but if we are on the document node this returns the image tag. Because the image tag is not a `NamedNodeMap` trying to iterate over the tag throws the error.

There is a test file [here](https://bugzilla.mozilla.org/attachment.cgi?id=9040577).

Differential Revision: https://phabricator.services.mozilla.com/D18340

--HG--
extra : moz-landing-system : lando
2019-02-01 14:03:44 +00:00
Brian Hackett 96d60971db Bug 1520972 - Handle log points in the devtools server, r=jlast.
--HG--
extra : rebase_source : cbff40bc197b6a7cac66bd4698e0059860662a2c
2019-01-17 16:04:17 -10:00
Brian Hackett cbd795860b Bug 1513118 Part 3 - Devtools server/client support for virtual console logs, r=lsmyth.
--HG--
extra : rebase_source : fb5f80d245c145e3d5c4fea9db3a7d648694f585
extra : source : 4abb81088a9b49d700cfea840848a9dac6a0010d
2018-12-29 08:24:31 -10:00
Daniel Varga 325e31df1d Merge mozilla-central to mozilla-inbound. a=merge 2019-01-31 06:30:06 +02:00
Daniel Varga 07e1eb0f18 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2019-01-31 00:02:55 +02:00
Emilio Cobos Álvarez a155f63750 Bug 1523712 - Make -moz-binding chrome / UA only. r=boris
But enable it in all tests because a lot of them rely on using it in the
style="" attribute for example, or in inline stylesheets, which will no longer
parse this (even in chrome documents), and we don't want to rewrite all the XUL
and XBL tests.

Differential Revision: https://phabricator.services.mozilla.com/D18027

--HG--
extra : moz-landing-system : lando
2019-01-30 20:55:54 +00:00
Brian Hackett 3057b313f6 Bug 1520993 - Fix ESLint failures. 2019-01-30 07:47:41 -10:00
Bogdan Tara 19bcfc41e1 Backed out 8 changesets (bug 1465635) for failures on browser_canvas-actor-test-10.js, browser_target_server_compartment.js CLOSED TREE
Backed out changeset e8e363f98525 (bug 1465635)
Backed out changeset 9ec017a91e78 (bug 1465635)
Backed out changeset 11413ebfbcaf (bug 1465635)
Backed out changeset 52728b761d5d (bug 1465635)
Backed out changeset 734646bf9829 (bug 1465635)
Backed out changeset d9ae7cd34c1a (bug 1465635)
Backed out changeset 00d325ab677a (bug 1465635)
Backed out changeset a9b181f32189 (bug 1465635)
2019-01-30 18:54:05 +02:00
Alexandre Poirot 0b98a1f393 Bug 1465635 - Ensure removing BrowsingContextTarget front events when destroying it. r=jdescottes
When destroying the target, Target.destroy (for local tabs) only calls DebuggerClient.close,
which isn't going to call `detach`. But we still do need to unregister
the tabNavigated/frameUpdate listener to prevent unecessary event from firing.

Depends on D17609

Differential Revision: https://phabricator.services.mozilla.com/D17610

--HG--
extra : moz-landing-system : lando
2019-01-30 13:28:29 +00:00
Alexandre Poirot dc852753a8 Bug 1465635 - Remove Target.activeTab property. r=yulia
Depends on D15831

Differential Revision: https://phabricator.services.mozilla.com/D16874

--HG--
extra : moz-landing-system : lando
2019-01-30 13:28:25 +00:00
Alexandre Poirot ebfbdd02fa Bug 1465635 - Merge all target fronts with Target class. r=yulia,jdescottes
This patch makes it so that all target fronts inherits from a Target class mixin.
We are using a mixin as fronts should inherit from a custom Front class,
which is augmented with its own RDP request and events defined in its spec.
(This is done via FrontClassWithSpec(spec))

Depends on D15830

Differential Revision: https://phabricator.services.mozilla.com/D15831

--HG--
extra : moz-landing-system : lando
2019-01-30 13:28:23 +00:00
Cosmin Sabou 599a15d354 Merge mozilla-inbound to mozilla-central. a=merge 2019-01-29 12:01:56 +02:00
Sebastian Hengst 725402f21f Merge mozilla-central to autoland. CLOSED TREE 2019-01-29 02:05:49 +02:00
Alexandre Poirot a0066e8731 Bug 1515862 - Remove Front's form argument. r=jdescottes
Now that form argument is no longer used by any front to set its actor ID,
we can remove this argument.

Have a particular look at:
* devtools/client/shared/test/test-actor-registry.js
which was the last Front to be manually instantiated and need some tweaks,
* canvas head.js to create canvas front via getFront,
* RDM manager.js, which requires the EmulationFront to be self managed.

Depends on D17615

Differential Revision: https://phabricator.services.mozilla.com/D17616

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:52 +00:00
Alexandre Poirot 9a08694477 Bug 1515862 - Set global and target scope front IDs from getFront helper. r=jdescottes
Ideally, formAttributeName would be a field on the prototype of each front,
but unfortunately, Firefox doesn't support ES Class's fields yet. So it is
put as an instance attribute instead.

This patch streamline the manually set actorID and the retrieval of actor ID
from root or target front's form into `getFront` helper method.
So that all the specific related to the lazy actor is now inside of this helper.
It also moves the special "this.manage(this)" to this helper.
We might be able to followup on this one and finally have only the root front
being self managed. But the initialize method makes it hard.

Note the special tweak made to devtools/client/responsive.html/manager.js
Hopefully this can be removed once the target classes are merged.

Depends on D15832

Differential Revision: https://phabricator.services.mozilla.com/D17615

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:50 +00:00
Alexandre Poirot 9db10d1d30 Bug 1515862 - Remove form passed as Front constructor. r=jdescottes
Only a couple of special cases where expecting to pass a full form object
as Front's second constructor argument.
Refactor them to ensure calling Front's form method instead in order to align
with typical protocol.js's behavior.

Depends on D17614

Differential Revision: https://phabricator.services.mozilla.com/D15832

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:48 +00:00
Alexandre Poirot 4199139118 Bug 1515862 - Remove detail feature from protocol.js. r=jdescottes
This feature is only used by node and domrulestyle actors and that, only for actor ID.
Instead of this, support this "pass only actor ID rather than full form" feature
in a more dedicated way.

We might followup on that to clarify/simplify doing this: passing only the actor ID
rather than its full form.

Depends on D17613

Differential Revision: https://phabricator.services.mozilla.com/D17614

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:46 +00:00
Alexandre Poirot d028804ade Bug 1515862 - Remove unecessary usages of actorid checks in actor and front's form method. r=jdescottes
Remove all actorid checks in actors and fronts as we never pass a defined `detail` argument in them.
Only domstylerule and node are using detail and that, always with detail="actorid".
Also remove ctx and detail in Front constructor as that's not used by these two actors.

Depends on D17612

Differential Revision: https://phabricator.services.mozilla.com/D17613

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:39 +00:00
Alexandre Poirot 385ac7de96 Bug 1515862 - Remove protocol.js's formType. r=jdescottes
None of our actor define a `formType` in its specification.
This feature has never been used, so remove it and its test.

Differential Revision: https://phabricator.services.mozilla.com/D17612

--HG--
extra : moz-landing-system : lando
2019-01-28 18:42:33 +00:00
Gabriel Luong dc2738771b Bug 1523171 - Remove the authoredStyles trait. r=pbro 2019-01-28 09:25:39 -05:00
yulia d5b3aa8f66 Bug 1518777 - move webConsoleClient.detach to destroy; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16681

--HG--
extra : moz-landing-system : lando
2019-01-24 11:50:36 +00:00
yulia 464195ce69 Bug 1518777 - make stoplisteners use promise style callbacks; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16680

--HG--
extra : moz-landing-system : lando
2019-01-24 11:50:34 +00:00
yulia 1e21fdffad Bug 1518777 - move stopListeners from the client detach method to the actor destroy method; r=nchevobbe
r=ochameau,nchevobbe

This patch moves stopListeners to the actor, and removes the need for the callback in the
detach call on the client.

Differential Revision: https://phabricator.services.mozilla.com/D16178

--HG--
extra : moz-landing-system : lando
2019-01-24 11:48:37 +00:00
vinoth cc6d429241 Bug 1512949 - Remove eval from tests and flip assertion flag r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D14054

--HG--
extra : moz-landing-system : lando
2019-01-24 09:06:07 +00:00
Brian Hackett 3c8ef4c0ea Bug 1520993 - Remove debuggerSourceActors trait, r=jlast.
--HG--
extra : rebase_source : cce3ad5e1bf2765cc8c5a695c02f8100cf5cb3c3
2019-01-17 10:07:48 -10:00
Brian Hackett 460678139f Bug 990137 - Remove obsolete handling code for client side conditional breakpoints, r=jlast.
--HG--
extra : rebase_source : 41c8016979e088534e3e4bdea1d7af91ed6ace87
2019-01-17 08:36:37 -10:00
Kris Maglione e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Alexandre Poirot 34cccbbf19 Bug 1521052 - Add DebuggerServer.hasConnection to track if it still has active connections. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D16961

--HG--
extra : moz-landing-system : lando
2019-01-23 14:46:10 +00:00
Patrick Brosset de44cc12fc Bug 1521776 - Add new scrollable markup badges; r=gl
Detect when nodes are scrollable on the actor side, and use this
information to display new [scrollable] markup-badges in the inspector.
Also track this dynimically so badges are added/removed when necessary.
Hide this behind a pref for now, until this gets tested by users and
validated.

Differential Revision: https://phabricator.services.mozilla.com/D17246

--HG--
extra : moz-landing-system : lando
2019-01-23 14:07:47 +00:00
Alexandre Poirot afc0fa1a25 Bug 1520782 - Convert console tests using chrome documents and using server references directly to browser mochitests. r=nchevobbe
These two tests were using chrome mochitest which forces the test page to be running in chrome and in parent process.
This doesn't reflect typical setup where the page runs unprivileged in content process.
Also, with the current bug, the pages running in system principal will be debugged with a special setup.
Actors will be run with modules loaded in a distinct loader in order to be executed
in a distinct compartment, distinct from the shared system principal compartment.
That a prerequisite for the Debugger API. It has to run in a distinct compartment than its debuggee.

Depends on D16826

Differential Revision: https://phabricator.services.mozilla.com/D16827

--HG--
rename : devtools/shared/webconsole/test/test_network_longstring.html => devtools/shared/webconsole/test/browser/browser_network_longstring.js
extra : moz-landing-system : lando
2019-01-23 08:53:06 +00:00
Michael Ratcliffe 6928727511 Bug 1521026 - Flex highlighter shouldn't scroll for position:fixed elements r=gl
This fixes the issue but because of our virtual canvas implementation and the
fact that reflow events are batched there is quite a bit of flicker and some
drag (see attached video).

Unfortunately, until bug 1509071 is implemented (full screen canvas using
`position:fixed`) we can't really do anything about the flicker... I suppose we
could stop batching reflow events but that would make all of our highlighters
unusably slow.

Differential Revision: https://phabricator.services.mozilla.com/D16988

--HG--
extra : moz-landing-system : lando
2019-01-21 16:49:24 +00:00
Alexandre Poirot 76f1d25301 Bug 1520772 - Construct the WebExtension target front before instantiating the Target object. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D15829

--HG--
extra : moz-landing-system : lando
2019-01-21 11:04:31 +00:00
Alexandre Poirot a75ca7eaa0 Bug 1520773 - Prevent infinite loops in DebuggerClient.close. r=yulia
If any callback fired by DebuggerClient.close ends up calling close again, it will introduce an infinite loop.

Depends on D15826

Differential Revision: https://phabricator.services.mozilla.com/D15827

--HG--
extra : moz-landing-system : lando
2019-01-21 11:04:08 +00:00
yulia fc04dc76f6 Bug 1519107 - use promise pattern for other webconsole methods rather than callbacks; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16196

--HG--
extra : moz-landing-system : lando
2019-01-21 13:49:22 +00:00
yulia 61ab41870c Bug 1519107 - use promise pattern for getCachedMessage rather than callbacks; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16195

--HG--
extra : moz-landing-system : lando
2019-01-21 13:47:03 +00:00
yulia f87d14c8d9 Bug 1519107 - make evaluateJS calls use promise pattern rather than callbacks; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16194

--HG--
extra : moz-landing-system : lando
2019-01-21 13:45:03 +00:00
Emilio Cobos Álvarez d3c8dea1ae Bug 1520229 - [css-logical] Implement the inset shorthand. r=mats
Reviewers: mats

Reviewed By: mats

Bug #: 1520229

Differential Revision: https://phabricator.services.mozilla.com/D16704
2019-01-20 18:32:11 +01:00
Margareta Eliza Balazs 0ba2ee586d Backed out changeset 92c56dcf69b8 (bug 1512949) for mochitest failures setup | Login to delete is defined: login0 - false == true - got false, expected true (operator ==) CLOSED TREE 2019-01-18 14:19:05 +02:00
vinoth 5d09ad138e Bug 1512949 - Remove eval from tests and flip assertion flag r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D14054

--HG--
extra : moz-landing-system : lando
2019-01-15 13:11:19 +00:00
Csoregi Natalia 050a4e7524 Merge mozilla-central to mozilla-inbound. CLOSED TREE 2019-01-17 23:59:29 +02:00
Csoregi Natalia a56ec21b2b Merge inbound to mozilla-central. a=merge 2019-01-17 23:54:34 +02:00
Mats Palmgren 9c04886e64 Bug 1520684 part 2 - [css-logical] Implement the flow-relative border-radius properties. r=emilio 2019-01-17 21:49:07 +01:00
Mats Palmgren e11d61d0d9 Bug 1520236 - [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands. r=emilio 2019-01-17 20:02:41 +01:00
yulia a102b06be0 Bug 1519133 - replace _actor field with protocol.js actorID field; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16702

--HG--
extra : moz-landing-system : lando
2019-01-17 10:11:36 +00:00
Michael Ratcliffe e1fb58b951 Bug 1504743 - Combine the box-model highlighter and the flexbox highlighter when highlighting flex containers/items r=gl
Differential Revision: https://phabricator.services.mozilla.com/D12046

--HG--
extra : moz-landing-system : lando
2019-01-17 17:42:04 +00:00
yulia ac50ddf7b6 Bug 1519133 - remove unused methods; r=ochameau
Differential Revision: https://phabricator.services.mozilla.com/D16701

--HG--
extra : moz-landing-system : lando
2019-01-16 14:57:01 +00:00
arthur.iakab 48fa943d27 Merge inbound to mozilla-central a=merge 2019-01-17 06:21:08 +02:00
Noemi Erli d3bda31250 Backed out changeset 009cf5f885ba (bug 1520236) for multiple failures in logical-box-border-color-visited-link-002.html 2019-01-17 01:18:00 +02:00
Mats Palmgren 790c50dcf0 Bug 1520396 - [css-logical] Implement the border-block/border-inline shorthands. r=emilio 2019-01-16 19:26:15 +01:00
Mats Palmgren 1db6a31ac4 Bug 1520236 - [css-logical] Implement the border-{block,inline}-{color,style,width} shorthands. r=emilio 2019-01-16 19:26:15 +01:00
Mats Palmgren 0cdadab9e8 Bug 1520229 - [css-logical] Implement the inset-block/inline shorthands. r=emilio 2019-01-16 19:26:14 +01:00
Michael Ratcliffe c32301ea8a Bug 1520544 - Expose NodeFilter to DevTools modules r=gl
Differential Revision: https://phabricator.services.mozilla.com/D16721

--HG--
extra : moz-landing-system : lando
2019-01-16 20:55:23 +00:00
Yura Zenevich 65450f63bd Bug 1514856 - move image data array traversal to worker thread when calculating contrast ratio for text nodes. r=jdescottes,ochameau
MozReview-Commit-ID: K3twiMih7e9

Differential Revision: https://phabricator.services.mozilla.com/D15113

--HG--
rename : devtools/server/actors/utils/accessibility.js => devtools/server/actors/accessibility/contrast.js
extra : moz-landing-system : lando
2019-01-16 19:00:45 +00:00
Mats Palmgren 663f6ee46c Bug 1519944 - [css-logical] Implement the margin-block/inline shorthands. r=emilio 2019-01-15 02:27:44 +01:00
Mats Palmgren 9a48b50d31 Bug 1519847 - [css-logical] Implement the padding-block/inline shorthands. r=emilio 2019-01-14 19:22:03 +01:00
Daniel Varga 1b2c69a5c1 Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2019-01-11 06:23:02 +02:00
Julian Descottes dc192a4fd7 Bug 1510654 - Reorder specs to be alphabetically sorted;
Depends on D16022 . Minor fix, just reordering a spec definition.

Differential Revision: https://phabricator.services.mozilla.com/D16218

--HG--
extra : moz-landing-system : lando
2019-01-10 18:42:11 +00:00
Julian Descottes cf82f78c6e Bug 1510654 - Extract service worker actors to dedicated files;r=ochameau,ladybenko
Depends on D15377

Differential Revision: https://phabricator.services.mozilla.com/D15378

--HG--
rename : devtools/server/actors/worker/service-worker.js => devtools/server/actors/worker/push-subscription.js
rename : devtools/server/actors/worker/service-worker.js => devtools/server/actors/worker/service-worker-registration.js
rename : devtools/shared/fronts/worker/service-worker.js => devtools/shared/fronts/worker/push-subscription.js
rename : devtools/shared/fronts/worker/service-worker.js => devtools/shared/fronts/worker/service-worker-registration.js
rename : devtools/shared/specs/worker/service-worker.js => devtools/shared/specs/worker/push-subscription.js
rename : devtools/shared/specs/worker/service-worker.js => devtools/shared/specs/worker/service-worker-registration.js
extra : moz-landing-system : lando
2019-01-10 17:28:27 +00:00
Julian Descottes c468557cf4 Bug 1510654 - Return ServiceWorker fronts for installing, active and waiting workers;r=ochameau,ladybenko
Depends on D15376

Differential Revision: https://phabricator.services.mozilla.com/D15377

--HG--
extra : moz-landing-system : lando
2019-01-10 17:26:48 +00:00
Julian Descottes 49deed3186 Bug 1510654 - Create fronts for ServiceWorkerRegistration, PushSubscription and ServiceWorker;r=ochameau,ladybenko
Depends on D15375

Differential Revision: https://phabricator.services.mozilla.com/D15376

--HG--
extra : moz-landing-system : lando
2019-01-10 17:26:35 +00:00
Oriol Brufau 69e25dc980 Bug 1515046 - Add receiverId parameter in objectClient.getPropertyValue. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D15788

--HG--
extra : moz-landing-system : lando
2019-01-09 06:42:58 +00:00
Julian Descottes fb34f9ae99 Bug 1495382 - Check isMultiE10s from runtime info;r=daisuke,ladybenko
Depends on D15081

Differential Revision: https://phabricator.services.mozilla.com/D15399

--HG--
rename : devtools/client/shared/multi-e10s-helper.js => devtools/shared/multi-e10s-helper.js
extra : moz-landing-system : lando
2019-01-09 09:44:15 +00:00
Julian Descottes bb71a1eb72 Bug 1497264 - Remove AddonTargetActor and AddonConsoleActor;r=ochameau,yulia
This should be rather safe. We can do more refactoring and renaming once LegacyExtension support is fully removed (ie Fx 65 hits release)

Differential Revision: https://phabricator.services.mozilla.com/D15383

--HG--
extra : moz-landing-system : lando
2019-01-08 18:17:17 +00:00
Nicolas Chevobbe 415af1ba97 Bug 1499289 - Change how we deal with getter evaluation in JsPropertyProvider; r=bgrins.
While trying to implement the invoke getter from
autocomplete popup, it became clear to me that the
initial implementation in js-property-provider wasn't
good enough, as we need to keep track of all the
authorizations the user gave when working on a given
expression.

In order to handle this, JsPropertyProvider now
returns an array of strings representing the path
to the unsafe getter when no matching authorizations
are provided.

If authorizations are provided, we can check for each
properties that the user authorized the execution.
This way, we can handle deep object access after a getter
(e.g. `x.myGetter.foo.bar.baz.entries`) without asking
the user if they want to invoke `myGetter` on each
step of the completion.

This makes handling intermediary getters (e.g.
`x.myGetter.foo.myOtherGetter.bar`) way easier as well.
In the UI, the user will be prompted to invoke the getter one
after the other (if for example they try to complete a pasted
expression which contains multiple getters, they will have
prompts for `myGetter`, and then for `myOtherGetter`).

We wire-up the webconsole client and the webconsole actor for
the autocomplete function, to make them ready for frontend
use.

The existing JsPropertyProvider getters test are updated to
match the change of parameter (invokeGetter -> authorizedEvaluations),
and some tests are added to make sure everything work as intended.

Differential Revision: https://phabricator.services.mozilla.com/D12940

--HG--
extra : moz-landing-system : lando
2019-01-07 09:49:10 +00:00
Nicolas Chevobbe 09c8a73d83 Bug 1231489 - Use content prototype for autocompletion of String, Number and Array literals; r=bgrins.
When provided a string, number or array literals, we use to
simply return the properties from String.prototype, Number.prototype
and Array.prototype.
This is working fine unless the content prototypes are modified.
In order to make it work properly, we retrieve the actual content
prototype.
The js-property-provider unit test is modified to ensure this is
working as expected.

Differential Revision: https://phabricator.services.mozilla.com/D15843

--HG--
extra : moz-landing-system : lando
2019-01-08 07:59:24 +00:00
Nazım Can Altınova 89859d7246 Bug 1515197 - Remove the window length setting from devtools performance panel r=julienw
Differential Revision: https://phabricator.services.mozilla.com/D15655

--HG--
extra : moz-landing-system : lando
2019-01-07 21:37:05 +00:00
Ryan Hunt 9f09201ef2 Bug 1305957 part 2 - Add 'overflow-anchor' CSS property. r=emilio
https://drafts.csswg.org/css-scroll-anchoring/#exclusion-api

Differential Revision: https://phabricator.services.mozilla.com/D13265

--HG--
extra : rebase_source : 14d4a6282274b125a6153a05daff5d93e34a29b7
extra : source : c66c00f7329619d53bc14ec615a0d92f06b6a892
2018-11-21 22:33:15 -06:00
Hiroyuki Ikezoe 88483b9261 Bug 1517682 - Drop layout.css.background-blend-mode.enabled pref. r=heycam
It was enabled by default in bug 970600.

Depends on D15707

Differential Revision: https://phabricator.services.mozilla.com/D15708

--HG--
extra : moz-landing-system : lando
2019-01-04 07:21:32 +00:00
Hiroyuki Ikezoe 1415d28adf Bug 1517682 - Drop layout.css.scroll-behavior.property-enabled pref. r=heycam
It was enabled by default in bug 1041833 (for desktops) and
bug 1087562 (for Fennect).

Depends on D15706

Differential Revision: https://phabricator.services.mozilla.com/D15707

--HG--
extra : moz-landing-system : lando
2019-01-04 07:21:53 +00:00
Hiroyuki Ikezoe 602a0bb6c3 Bug 1517682 - Drop layout.css.mix-blend-mode.enabled pref. r=heycam
It was enabled by default in bug 952643.

Depends on D15705

Differential Revision: https://phabricator.services.mozilla.com/D15706

--HG--
extra : moz-landing-system : lando
2019-01-04 07:22:13 +00:00
Hiroyuki Ikezoe bed5a404f1 Bug 1517682 - Drop layout.css.isolation.enabled pref. r=heycam
It was enabled by default in bug 1091885.

Depends on D15704

Differential Revision: https://phabricator.services.mozilla.com/D15705

--HG--
extra : moz-landing-system : lando
2019-01-04 07:22:27 +00:00
Hiroyuki Ikezoe 9bdfa0cf64 Bug 1517682 - Drop layout.css.image-orientation.enabled pref. r=heycam
It was enabled by default in bug 825771.

Depends on D15703

Differential Revision: https://phabricator.services.mozilla.com/D15704

--HG--
extra : moz-landing-system : lando
2019-01-04 07:22:52 +00:00
Hiroyuki Ikezoe 6aaa816a8a Bug 1517682 - Drop layout.css.color-adjust.enabled pref. r=heycam
It was enabled by default in bug 1209273.

Depends on D15702

Differential Revision: https://phabricator.services.mozilla.com/D15703

--HG--
extra : moz-landing-system : lando
2019-01-04 07:23:38 +00:00
Hiroyuki Ikezoe f2d516f849 Bug 1517682 - Drop layout.css.box-decoration-break.enabled pref. r=heycam
It was enabled by default in bug 1006326.

Differential Revision: https://phabricator.services.mozilla.com/D15702

--HG--
extra : moz-landing-system : lando
2019-01-04 07:23:07 +00:00
Alexandre Poirot e5a27afe74 Bug 1512154 - Convert protocol.js to es classes. r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D14840

--HG--
extra : moz-landing-system : lando
2019-01-02 13:38:54 +00:00
Alexandre Poirot 10ba88604c Bug 1515116 - Let Front's constructor set the actorID instead of doing it manually. r=jdescottes
Depends on D14915

Differential Revision: https://phabricator.services.mozilla.com/D14916

--HG--
extra : moz-landing-system : lando
2019-01-03 10:20:35 +00:00
Alexandre Poirot 2f8299a363 Bug 1515116 - Remove all useless constructor methods on Fronts. r=jdescottes
Depends on D14914

Differential Revision: https://phabricator.services.mozilla.com/D14915

--HG--
extra : moz-landing-system : lando
2019-01-03 10:09:42 +00:00
Alexandre Poirot 460c16cd22 Bug 1515116 - Remove all useless destroy methods on Fronts. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D14914

--HG--
extra : moz-landing-system : lando
2019-01-03 10:09:40 +00:00
Jan de Mooij 9f6f1773d0 Bug 1514210 part 1 - Create the devtools sandbox in a new compartment for now. r=bzbarsky
There's a small number of devtools test failures that will be fixed by Alexandre
in bug 1515290. When that lands we can revert this change.

Differential Revision: https://phabricator.services.mozilla.com/D15290

--HG--
extra : moz-landing-system : lando
2019-01-03 10:02:33 +00:00
Jan de Mooij 0e4c73be9d Bug 1515590 part 7 - Null out proxy1 and proxy2 in test_jsterm_autocomplete.html to fix a shutdown leak. r=jlast
Differential Revision: https://phabricator.services.mozilla.com/D15566

--HG--
extra : moz-landing-system : lando
2019-01-02 13:24:10 +00:00
yulia 9acadd4e5b Bug 1508656 - migrate cancel picker to nodePicker; r=ochameau
Depends on D12126

Differential Revision: https://phabricator.services.mozilla.com/D12290

--HG--
extra : moz-landing-system : lando
2018-12-18 08:45:16 +00:00