83d7acfbb7
Hi Norris, Simon,
...
I looked into this somewhat and I noticed the following:
1) There is a bug in Interpreter.java, line 1695. It sets the variable "i" to
the line number of the special call, but overwrites it on line 1699. It then
passes this value to ScriptRuntime.callSpecial
2) In "generateScriptICode" in Interpreter.java the variable
itsData.itsSourceFile fails to be set to itsSourceFile. This causes a null
source file name to be passed to handleCompilationDone when "Widget.js" is
compiled. That is why you
initially see "<stdin>, line 6" when the debugger comes up (the debugger
interprets a null source name as "stdin"). I simply modified it as follows
(this might not be the right thing to do?):
private InterpretedScript generateScriptICode(Context cx,
Scriptable scope,
Node tree,
Object securityDomain)
{
itsSourceFile = (String) tree.getProp(Node.SOURCENAME_PROP);
itsData.itsSourceFile = itsSourceFile;
...
and that corrected the problem.
However there seems to be no way for the debugger to detect that the script
passed to handleCompilationDone() is the argument of an "eval()". So I modifed
NativeGlobal.evalSpecial() to munge the filename to indicate this (by appending
"(eval)" to it). That way a separate window is created in the debugger to hold
the compiled eval code. This is probably not be the best way to solve the
problem.
I have attached the files I modified.
Cheers,
Chris
Simon Massey wrote:
> Christopher,
>
> Attached is the code that trips the debugger up. The debugger comes up. You
minimize the console to reveal Widget.js file window. You click 'Go'. The
Widget.js window looses all the code in it and is just replaced by the evaluated
code:
>
> this.invokedByEval()
>
> The rhino tip I have is rhino15R2pre.zip
>
> I am running it with the command:
>
> start javaw org.mozilla.javascript.tools.debugger.JSDebugger -f Widget.js -f
Main.js
>
> using the JVM:
>
> java version "1.3.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.0-C)
> Java HotSpot(TM) Client VM (build 1.3.0-C, mixed mode)
>
> on Win2k.
>
> Just in case you are wondering why on earth my code wants to do this, it is
because I want to do some introspection. The real Widget invokes all its methods
that have a particular substring in their names:
>
> for( key in this ){
> if( key.indexOf('reflect') == 0 ){
> var evalStr = "this."+key+"()";
> eval(evalStr);
> }
> }
>
> Thanks for the great code. I have the real Widget stabilized and am happily
using the debugger on my other files.
>
> Thanks again!
>
> Simon Massey
>
2001-06-19 19:27:21 +00:00
03cf8f309c
final checkin of NSCP roots to mozilla. changed USPS roots per request.
2001-06-19 17:12:04 +00:00
624dd88ec7
This should've gone in with yesterday's checkin. Should fix OS/2 bustage
2001-06-19 17:07:12 +00:00
a2141f9e7c
resurrect lost file
2001-06-19 14:58:03 +00:00
90a5de9e89
removing file that was added by accident (typo in file name).
2001-06-19 14:58:00 +00:00
9823dc5c59
resurrecting lost file
2001-06-19 14:55:51 +00:00
338baf63a0
restore
2001-06-19 14:52:02 +00:00
e593e4d8f9
resurrecting some lost files
2001-06-19 14:51:05 +00:00
23c3f7553b
restore
2001-06-19 14:46:04 +00:00
fa095d6c77
readding dead file
2001-06-19 14:36:11 +00:00
43c2b84ad8
restored
2001-06-19 14:35:44 +00:00
7d86073839
readding files from the cvs-file-eating
2001-06-19 14:34:30 +00:00
f7af150202
readding shit to the trunk since cvs ate it.
2001-06-19 11:16:54 +00:00
d66bcf6453
file nsImageLoader.h was initially added on branch IMG2_20010618_BRANCH.
2001-06-19 08:49:47 +00:00
94f39c6453
file nsImageLoader.cpp was initially added on branch IMG2_20010618_BRANCH.
2001-06-19 08:49:46 +00:00
c3257cb477
removing libimg
2001-06-19 08:47:13 +00:00
cfa0ec9b73
Bug 68012: Allow frames in a frameset to be manually resized by dragging the border. This is accomplished by changing the reflow from a ResizeReflow, which was blocked by block to box adapter optimizations as the window had not changed size, to a ReflowDirtyChild. r=jst@netscape.com, sr=attinasi@netscape.com, a=drivers@mozilla.org (blizzard)
2001-06-19 08:29:13 +00:00
b107830d2d
Bug 68321: Remove nsSecureBrowserUIImpl from form submit observer list on destruction, and ignore failures when enumerating observer list. These failures were causing spurious NS_ERROR_INVALID_POINTER messages on the console, and preventing form submission. This is part 1 of 2, simply ignoring the error return codes in nsFormFrame when enumerating the observer list. The remaining part is in mozilla/security/manager/ssl/src/nsSecureBrowserUIImpl.cpp, to unregister the nsSecureBrowserUIImpl on destruction. r=javi@netscape,com, sr=jst@netscape.com, a=drivers@mozilla.org (asa)
2001-06-19 08:01:46 +00:00
5374a1604b
fix for 73605: nsHTMLContentSerializer outputs <textarea> contents as attributes
...
r=kin@netscape.com
sr=jst@netscape.com
a=dbaron
2001-06-19 07:37:15 +00:00
4edbb223f6
Fix for bug # 80060. Fixed removedirectory() such that the selected directory gets
...
deleted and also it gets deleted when user clicks on ok
r=bhuvan, sr=sspitzer, a=asa
2001-06-19 06:06:21 +00:00
b31514c245
Bug 77913 - tab focus not cycling around in dialogs. r=jag, sr=jst, a=blizzard.
2001-06-19 05:35:24 +00:00
519b4c775c
Get rid of compiler warnings caused by my last check-in.
2001-06-19 05:34:47 +00:00
9134754ec6
Fix for Bug 83675 r=mcgreer, sr=blizzard, a=asa
...
If a user has a PKCS11 smart card installed, then give the user
the option of restoring a p12 file onto the smart card.
2001-06-19 05:29:56 +00:00
199ed6f301
Changing despot owner to endico@mozilla.org with her permission
2001-06-19 04:04:34 +00:00
62bb35349f
Fix for 85986. If we find a shortcut and we are not resolving it, it is ok to
...
return we found it. r=dougt, sr=mscott, a=drivers
2001-06-19 03:17:20 +00:00
96a84d6c9d
Fix for bug 79933. Added some error messages when user enters invalid data into the
...
directory server properties dialog
r=mohanb, sr=sspitzer, a=blizzard
2001-06-19 02:34:56 +00:00
936d1b7a02
Running a query using the Added Comment option was very slow (bug 57350).
...
Patch by Myk Melez <myk@mozilla.org> and Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-06-19 02:05:08 +00:00
cbe38ef9a2
Fix for bug 86107. Preferences needs to implement nsISupportsWeakReference. r=mitesh, sr=alecf, a=asa.
2001-06-19 01:40:19 +00:00
e2a4f69185
Fix to allow caching of https plugin streams and also fix a leak in byte range streams bug 54689 and bug 83183 patches by peterl & dougt r=av sr=attinasi a=asa
2001-06-19 01:38:20 +00:00
aca8112d7e
Refixing bug 71396. Each PushGlobalSQLState() needs a PopGlobalSQLState() and this file instead had two "pushes".
2001-06-19 01:37:02 +00:00
e519e441c4
Scragglers for bug 75819, I applied the patch by hand and missed a couple instances. Original patch by Bhart00@yahoo.com (Bradley Hart) r=me/robinf/jglick sr=scc a=asa
2001-06-19 01:27:38 +00:00
f53b52825b
Remove #if defined(XP_WIN) since it's redundant. Bug 84584.
2001-06-19 01:16:22 +00:00
755002a129
75819 - Wording in HTML mail question dialog for 'Plaintext' should be 'Plain Text'. Patch by Bradley Hart <bhart00@yahoo.com> r=stephen@netscape.com, robinf@netscape.com/jglick@netscape.com sr=scc@mozilla.org a=asa@mozilla
2001-06-19 01:13:36 +00:00
d753791beb
#70236 , "new folder" button in filter-editor should be disabled if an action other than "Move to folder" is selected. r=doron, sr=sspitzer, a=asa.
...
#68175 , fix bug where we opened the filter-editor seemingly at random sometimes when clicking around in the filter-list dialog. r=naving, sr=sspitzer, a=asa.
2001-06-19 01:08:41 +00:00
078d452f99
Cleaning up whitespace that was missed with cvs diff -uw on bug 58783, that bug has r=naving, sr=sspitzer, a=asa
2001-06-19 00:58:15 +00:00
2dae2670b7
Bug 58783 - Title isn't cleared in a folder when the last message is deleted. r=naving@netscape.com sr=sspitzer@netscape.com a=asa@mozilla.org
2001-06-19 00:33:09 +00:00
0bc5ecce7f
Fixes bug 84847 "refresh displays stale content when using squid proxy"
...
r=gagan, sr=dougt, a=asa
2001-06-19 00:29:23 +00:00
668fd620fc
place clicked-link events on the current active queue, rather than the one that was active at the time of the webshell's creation. bug 71222 r=hyatt,rpotts a=asa
2001-06-19 00:28:10 +00:00
f807653c73
Fixes bug 85887 "Gzip content not properly displayed when using Content-Encoding: x-gzip"
...
r=bbaetz, sr=dougt, a=asa
2001-06-19 00:25:02 +00:00
315d8382c6
Landing minimal patch for bug 82873 "HTTP/1.1 trailers not supported"
...
r=gagan, sr=dougt, a=asa
2001-06-19 00:22:43 +00:00
8e6c262c2b
increase slop size when forcing newly opened windows onscreen, and force it onto the closest monitor, rather than the grayrgn's rect. bug 76790 r=hyatt,pchen a=blizzard
2001-06-19 00:21:17 +00:00
97cd994126
Fix for Bug 85993 patch submitted by Bradley Hart,
...
r=ssaux, db48x sr=scc a=asa
Wording change to dialog for Restore.
2001-06-19 00:20:58 +00:00
78237621ec
increase slop size when forcing newly opened windows onscreen. bug 76790 r=hyatt,pchen a=blizzard
2001-06-19 00:20:10 +00:00
00e9470392
*not part of the build*
...
urpConnect update
a=lsv@sparc.spb.su
2001-06-19 00:16:08 +00:00
7657bb0805
Set DEF_FILE & IMPORT_LIBRARY to NULL when setting SHARED_LIBRARY to NULL. Should fix OS/2 tinderbox bustage.
2001-06-19 00:08:53 +00:00
e2c879944e
author=ashuk
...
fixes problems with parallel builds on Solaris. Changed target
dependencies in webclient/import/Makefile.in
2001-06-19 00:08:10 +00:00
8efa22c63a
bug 56936 Can't copy Japanese string from emacs by mouse
...
(check in for katakai@japan.sun.com )
r=ftang sr=blizzard a=asa@mozilla.org
2001-06-18 23:52:02 +00:00
a520791008
Allow '\' as a path delimiter (bug 29064)
...
Patch Concept by <timeless@mac.com>
r= jake@acutex.net
2001-06-18 23:13:18 +00:00
5c0aa97a36
[Not part of build] Support for sending all console output to the Mac OS X Console application / or command line terminal. Replaces all of the standard SIOUX routines.
2001-06-18 22:29:30 +00:00
5584f0e249
Missed one.
...
Bug #46775 r=mcafee a=leaf
2001-06-18 22:28:54 +00:00
nboyd%atg.com
mcgreer%netscape.com
cls%seawood.org
leaf%mozilla.org
brade%netscape.com
pavlov%netscape.com
pollmann%netscape.com
anthonyd%netscape.com
srilatha%netscape.com
bryner%uiuc.edu
javi%netscape.com
dmose%mozilla.org
syd%netscape.com
jake%acutex.net
bnesse%netscape.com
peterlubczynski%netscape.com
stephend%netscape.com
nelsonb%netscape.com
hwaara%chello.se
darin%netscape.com
danm%netscape.com
idk%eng.sun.com
ashuk%eng.sun.com
tajima%eng.sun.com
beard%netscape.com