When I try to enable -Wconversion, CheckedInt triggers it because it has an
implicit type conversion in its templated two-arg constructor.
That constructor doesn't really need to be templated, as far as I can tell.
Differential Revision: https://phabricator.services.mozilla.com/D63384
--HG--
extra : moz-landing-system : lando
Allows to move `nsFrameSelection::AddCellsToSelection`, a caller of
`SelectCellElement, from `nsFrameSelection` to `TableSelection` in a
subsequent step.
Differential Revision: https://phabricator.services.mozilla.com/D63158
--HG--
extra : moz-landing-system : lando
Slightly clarfifies the relation of `Selection` and `nsFrameSelection`.
This requires undesirable 'kungFuDeathGrips'. However, they existed
already, only via an indirect call.
Differential Revision: https://phabricator.services.mozilla.com/D63479
--HG--
extra : moz-landing-system : lando
Removed unused function BuildCache(LookupCacheV2* cache, const _PrefixArray& aPrefixArray). This also required removal of RefPtr<T> SetupLookupCache(const _PrefixArray& aPrefixArray) (formerly line 229).
Differential Revision: https://phabricator.services.mozilla.com/D62614
--HG--
extra : moz-landing-system : lando
This patch will support all of `-std:`, `-std=`, and `-Xclang -std=`.
This patch will also a bit faster because the current code will call `sed` for
each argument.
Differential Revision: https://phabricator.services.mozilla.com/D63472
--HG--
extra : moz-landing-system : lando
- Enable GL_TEXTURE_RECTANGLE_ARB only when the extension is supported
- Switch Green and Alpha colors in NV12 shader when compositing on Wayland. Is's because vaExportSurfaceHandle() exports UV plane in DRM_FORMAT_GR88 format so we have to use R and G channels and not R and A as we have now.
Differential Revision: https://phabricator.services.mozilla.com/D63349
--HG--
extra : moz-landing-system : lando
ServiceWorkerRegistration::UpdateState can call content code, which
in turn can result in the registrations getting deleted. This
commit moves the call outside the constructor, so the
registration's creator has a chance to get a proper RefPtr to it.
Differential Revision: https://phabricator.services.mozilla.com/D61706
--HG--
extra : moz-landing-system : lando
This removes the need for explicit #ifdef NS_BUILD_REFCNT_LOGGING without
introducing user-defined destructors when it is not defined.
Also, some uses of virtual for declaring destructors are replaced by the
appropriate override declaration through these changes.
Differential Revision: https://phabricator.services.mozilla.com/D62604
--HG--
extra : moz-landing-system : lando
This assert was wrong. The assert may fire if we resurrect the node from a
different thread and insert a kid fast enough.
We allow resurrecting nodes (bumping the nodes from zero to one) to avoid
allocation churn.
In particular, while the thread dropping the node gets to read the children (so
after the fetch_sub from the refcount, but before the read() of the children),
another thread could plausibly bumped the refcount back, and added a children.
This is a very big edge case of course, but I'm kinda sad I hadn't realized
before.
Differential Revision: https://phabricator.services.mozilla.com/D63286
--HG--
extra : moz-landing-system : lando
This implements the special clearKeptObjects() function for the browser and turns on the pref to allow the tests to run.
Differential Revision: https://phabricator.services.mozilla.com/D63193
--HG--
extra : moz-landing-system : lando
Added assertion and removed unnecessary (and incorrect) use of this via ObjectGroup's finalizer.
Differential Revision: https://phabricator.services.mozilla.com/D63188
--HG--
extra : moz-landing-system : lando
Previously we passed a potentially NULL pointer to
CrashReporterHost::FinalizeOrphanedMinidump() which always assumed it to be
non-NULL. This patch solves the issue but preventing the pointer from being
NULL and making CrashReporterHost::GenerateCrashReport() infallible. In the
case we fail to take a minidump the only visible effect will be that the
minidump ID will be empty, and existing code already expects and handles this
scenario correctly.
Differential Revision: https://phabricator.services.mozilla.com/D63179
--HG--
extra : moz-landing-system : lando
takeWindowSnapshot() could take long time with WebRender native compositor. Then skip takeWindowSnapshot() with WebRender. It was fall out from D63125.
Differential Revision: https://phabricator.services.mozilla.com/D63431
--HG--
extra : moz-landing-system : lando
2020-02-20 09:10:51 +00:00
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)
Opening modal dialogs seems to cause focus misbehavior on Linux, run tests in new tabs to better isolate them.
Differential Revision: https://phabricator.services.mozilla.com/D63347
--HG--
extra : moz-landing-system : lando
James Graham
Boris Zbarsky
Michal Novotny
Mirko Brodesser
Byron Campen [:bwc]
Andreea Pavel
Philipp Zech
Masatoshi Kimura
Martin Stransky
Marian Raiciof
Razvan Maries
John Elliot V
Dão Gottwald
egao
Nicolas Silva
ffxbld
Yaron Tausky
prathiksha
Daisuke Akatsuka
Christian Holler
Simon Giesecke
sotaro
Emilio Cobos Álvarez
Jon Coppeard
Mathieu Leplatre
Gabriele Svelto
Jonathan Kew
Bastien Abadie
Tooru Fujisawa
Marco Bonardo ext:(%20%3Cmbonardo%40mozilla.com%3E)