Ryan VanderMeulen
3d0158833d
Merge autoland to m-c. a=merge
2017-08-24 20:20:08 -04:00
Marco Bonardo
7f569f98d9
Bug 1320301 - Add partial support to sqlite3_interrupt. r=asuth
...
MozReview-Commit-ID: V3ZjLEjqmT
--HG--
extra : rebase_source : 6f559b473c32dfcfb2bfe919c53199e202f7d636
2017-07-31 22:27:23 +02:00
Jan de Mooij
2cc6df95c3
Bug 1392554 - Port (Async)StatementParams to WebIDL bindings. r=asuth,qdot
2017-08-24 10:52:52 +02:00
Jan de Mooij
3912244f0b
Bug 1390489 - Port StatementRow to WebIDL bindings. r=asuth,qdot
2017-08-22 09:25:37 +02:00
Nathan Froyd
a6c96367a7
Bug 1347963 - part 1 - introduce mozilla::RecursiveMutex; r=erahm
...
Having a proper recursively-acquirable mutex type makes intent clearer,
and RecursiveMutex also happens to be somewhat faster than
ReentrantMonitor.
2017-03-14 14:05:51 -04:00
Sylvestre Ledru
4e9cf83ee8
Bug 1378712 - Remove all trailing whitespaces r=Ehsan
...
MozReview-Commit-ID: Kdz2xtTF9EG
--HG--
extra : rebase_source : 7235b3802f25bab29a8c6ba40a181a722f3df0ce
2017-07-06 14:00:35 +02:00
Bill McCloskey
f115503a0b
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Florian Quèze
2924991bf6
Bug 1368456 - remove Promise.jsm imports in tests, r=mconley.
2017-06-23 11:25:52 +02:00
Florian Quèze
5b8f8b884c
Bug 1374282 - script generated patch to remove Promise.defer calls, r=Mossop.
2017-06-22 12:51:42 +02:00
Florian Quèze
66f6d259bc
Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop.
2017-06-22 12:51:42 +02:00
Nathan Froyd
452dc60022
Bug 1372670 - part 4 - use nsIThreadManager::dispatchToMainThread more from JS; r=florian
...
We did an automated conversion for many of these in another bug, but
these instances were either missed or have been added since then.
2017-06-21 12:59:28 -04:00
Nathan Froyd
27c58cf89f
Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian
2017-06-21 12:59:28 -04:00
Carsten "Tomcat" Book
8a1350b5a6
Backed out changeset 4f6302a98ae4 (bug 1372405
)
...
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Bill McCloskey
6b3e84ed5f
Bug 1372405
- Provide names for all runnables in the tree (r=froydnj)
...
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Marco Bonardo
8d20cc6802
Bug 1355561 - Add a new API to spinningly close the database when strictly needed, and ensure Close() does what it's named after. r=asuth
...
Introduce a new SpinningSynchronousClose API that allows to synchronously close
a connection that executed asynchronous statements, by spinning the events loop.
This is expected to be used rarely in particular cases like database corruption.
It is currently [noscript] since the only consumer is cpp, in the future we can
evaluate removing that, if we find more uses for it.
MozReview-Commit-ID: 7SPqutoF9jJ
--HG--
extra : rebase_source : d053e308192f335dfdca089668e56115b068ff8c
2017-04-12 17:44:39 +02:00
Marco Bonardo
1d88de7d2f
Bug 1371945 - Avoid a possible thread-safety problem with unfinalized statements. r=asuth
...
Avoids a thread-safety race condition on shutdown where we could try to finalize a statement twice.
Allows the async thread to be referenced until ShutdownAsyncThread, so async finalizers can make use of it.
Removes the no more useful mAsyncExecutionThreadIsAlive.
Nullifies the sqlite3_mutex pointer when the connection is closed, since it would be a dangling pointer.
Use a ScopeExit to ensure the connection and the mutex pointers are always nullified on failure.
Makes asyncClose bailout early if a Close method was already invoked before.
Makes AsyncInitDatabase not use AsyncClose to just shutdown the async thread.
Fixes various unfinalized statements in consumers code.
Makes mConnectionClosed better follow mDBConn status.
Replaces some mutex locking isClosed() calls with lockless isConnectionReadyOnThisThread.
MozReview-Commit-ID: 6sftFehsQTt
--HG--
extra : rebase_source : 2bf3088b500376e58e62e8f078d9950588adc649
2017-06-16 17:43:23 +02:00
Florian Queze
f935ddc4b3
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
37ff4fc7cc
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Sebastian Hengst
a07223d699
Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout
2017-04-14 23:39:22 +02:00
Sebastian Hengst
738d097aae
Backed out changeset 55f3df15eaa6 (bug 1356569)
2017-04-14 23:39:17 +02:00
Florian Queze
3c564a2b02
Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws.
2017-04-14 21:51:39 +02:00
Florian Queze
95d4d20c17
Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws.
2017-04-14 21:51:38 +02:00
Mark Banner
bd625e4e9f
Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
...
MozReview-Commit-ID: LH0CQOPfoe6
--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Zibi Braniecki
b8f991e41b
Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
...
MozReview-Commit-ID: 5GEnL7Kihpj
--HG--
extra : rebase_source : 413d880035b49da82db0530379425d31ac31a82e
2017-02-07 12:52:03 -08:00
Wes Kocher
a9ce32d9a5
Backed out 2 changesets (bug 1335983) for build bustage a=backout
...
Backed out changeset 5a9559ded976 (bug 1335983)
Backed out changeset de2b0d90e2da (bug 1335983)
MozReview-Commit-ID: 377KQDU1QqJ
2017-02-07 12:34:30 -08:00
Zibi Braniecki
6d98bad59d
Bug 1335983 - Migrate nsCollation::CreateCollection to use LocaleService::GetAppLocale. r=jfkthame
...
MozReview-Commit-ID: bJVrVj2dAS
--HG--
extra : rebase_source : f3a28e003415f0c58462a73b5fd987455e102fc5
2017-02-06 14:57:09 -08:00
Mark Banner
16e6d381ac
Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
...
MozReview-Commit-ID: 62Hp5ISxowJ
--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Jared Wein
43bac26d30
Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
...
MozReview-Commit-ID: 6tv0Z06CO4a
--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Markus Stange
692210bd80
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
--HG--
extra : rebase_source : c7e335dac2e0f02782f0eb229a7181c8d01317a2
2016-12-21 11:43:50 +01:00
Mark Banner
80afb72ae6
Bug 1328851
- Enable eslint rule no-undef for storage/. r=mak
...
MozReview-Commit-ID: AemgF8H2ySH
--HG--
extra : rebase_source : dcbc2210fcfc9abf0e96b38b9306fd158f9dcfed
2017-01-05 11:54:49 +00:00
Jared Wein
9141469edf
Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
...
MozReview-Commit-ID: FuVu8skcqOe
--HG--
extra : rebase_source : 8ab34c4e46a7c3075b459bf44786ec184d10d203
2016-12-30 21:47:25 -05:00
Wes Kocher
26a1ba5c14
Backed out 27 changesets (bug 1323100) for clipboard leaktest failures a=backout
...
Backed out changeset 84fb749698ab (bug 1323100)
Backed out changeset d6d25e8bd001 (bug 1323100)
Backed out changeset 1b0855bb0c38 (bug 1323100)
Backed out changeset b6953e3f5739 (bug 1323100)
Backed out changeset 5572f3b63215 (bug 1323100)
Backed out changeset 12fb4c533659 (bug 1323100)
Backed out changeset c36524e4e919 (bug 1323100)
Backed out changeset 1e3b3eddbe26 (bug 1323100)
Backed out changeset 061110f1ae12 (bug 1323100)
Backed out changeset 413dbd31725b (bug 1323100)
Backed out changeset 06550f7eca62 (bug 1323100)
Backed out changeset 940933b13b36 (bug 1323100)
Backed out changeset a6d75c1cd724 (bug 1323100)
Backed out changeset 681cacbbaa3b (bug 1323100)
Backed out changeset 3d53787293f6 (bug 1323100)
Backed out changeset c0340dfe4766 (bug 1323100)
Backed out changeset 9f554991549d (bug 1323100)
Backed out changeset 757539e7039a (bug 1323100)
Backed out changeset a3c9b45aa917 (bug 1323100)
Backed out changeset 23d69df98a66 (bug 1323100)
Backed out changeset 1297ded6a01d (bug 1323100)
Backed out changeset f4235b97257f (bug 1323100)
Backed out changeset 93419cb4f29f (bug 1323100)
Backed out changeset 865d1b81c804 (bug 1323100)
Backed out changeset 54acf4ef8e84 (bug 1323100)
Backed out changeset 88d17bcd8205 (bug 1323100)
Backed out changeset 0c466e5e8933 (bug 1323100)
2016-12-29 16:28:36 -08:00
Markus Stange
1b72f37c98
Bug 1323100 - Assign names to all remaining threads that are created through NS_NewThread and create them using NS_NewNamedThread instead. r=froydnj
...
MozReview-Commit-ID: 7W1dt2BBKJZ
--HG--
extra : rebase_source : ad47978ef81d048a90b9803803201eee32974024
2016-12-21 11:43:50 +01:00
Jared Wein
ecab54a7c9
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 7E7LPorrEje
--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher
0dfb7c2b5c
Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
...
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
7255df4e9a
Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
...
MozReview-Commit-ID: 8WoGr8i6oCR
--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Mark Banner
4f94e4bd68
Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop
...
MozReview-Commit-ID: CiIsUjQzp4D
--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
2016-11-09 22:06:32 +00:00
Tomislav Jurin
348bfffc19
Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj
2016-12-02 13:46:53 -08:00
Phil Ringnalda
feef954874
Merge m-i to m-c, a=merge
...
MozReview-Commit-ID: EDVoIcyWOhi
--HG--
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
2016-11-22 20:03:03 -08:00
Nicholas Nethercote
7e1a8cf56c
Bug 1315138 - gtestify storage/test/*.cpp. r=mak,erahm.
...
This change is mostly straightforward, except for the following.
- It removes all the printing from the do_check_* macros because gtest macros
do appropriate printing.
- test_StatementCache.cpp needs some special gtest magic for the type
parameterization.
- It merges the four tests in test_unlock_notify.cpp because they rely on being
executed in order, and so aren't independent.
- storage_test_harness_tail.h is no longer necessary because gtest provides the
test looping functionality.
- It uses #include and the preprocessor to remove the duplication between
test_deadlock_detector.cpp and xpcom/tests/DeadlockDetector.cpp.
- It makes the test in test_service_init_background_thread.cpp a death test to
force it to be the first storage gtest, because it fails otherwise.
- It adds code to undo the SQLite mutex hooking as necessary, so that tests
don't interfere with each other.
- It de-virtualizes Spinner's destructor (as identified in bug 1318282).
--HG--
rename : storage/test/storage_test_harness.h => storage/test/gtest/storage_test_harness.h
rename : storage/test/test_AsXXX_helpers.cpp => storage/test/gtest/test_AsXXX_helpers.cpp
rename : storage/test/test_StatementCache.cpp => storage/test/gtest/test_StatementCache.cpp
rename : storage/test/test_asyncStatementExecution_transaction.cpp => storage/test/gtest/test_asyncStatementExecution_transaction.cpp
rename : storage/test/test_async_callbacks_with_spun_event_loops.cpp => storage/test/gtest/test_async_callbacks_with_spun_event_loops.cpp
rename : storage/test/test_binding_params.cpp => storage/test/gtest/test_binding_params.cpp
rename : storage/test/test_deadlock_detector.cpp => storage/test/gtest/test_deadlock_detector.cpp
rename : storage/test/test_file_perms.cpp => storage/test/gtest/test_file_perms.cpp
rename : storage/test/test_mutex.cpp => storage/test/gtest/test_mutex.cpp
rename : storage/test/test_service_init_background_thread.cpp => storage/test/gtest/test_service_init_background_thread.cpp
rename : storage/test/test_statement_scoper.cpp => storage/test/gtest/test_statement_scoper.cpp
rename : storage/test/test_transaction_helper.cpp => storage/test/gtest/test_transaction_helper.cpp
rename : storage/test/test_true_async.cpp => storage/test/gtest/test_true_async.cpp
rename : storage/test/test_unlock_notify.cpp => storage/test/gtest/test_unlock_notify.cpp
extra : rebase_source : dbb695c112564efa1945116be1a8435988982e74
2016-11-11 09:59:23 +11:00
Andi-Bogdan Postelnicu
64312a6104
Bug 1318282 - Use C++11's override and remove virtual where applicable in storage/. r=mak
...
MozReview-Commit-ID: AXchuOpF65X
--HG--
extra : rebase_source : 47536d5918bdb66cd467a1c31ca6545817e922d3
2016-11-17 12:36:25 +02:00
Andi-Bogdan Postelnicu
7f5f07c638
Bug 1318282 - Replace string literals containing escaped characters with raw string literals in storage/. r=mak
...
MozReview-Commit-ID: 7iVr1Ug0Oot
--HG--
extra : rebase_source : 7590b2f78454d2497dcc7f9c4275e463a2fe6c81
2016-11-17 12:35:02 +02:00
Andi-Bogdan Postelnicu
e874c4bda7
Bug 1318282 - Replace default bodies of special member functions with = default; in storage/. r=mak
...
MozReview-Commit-ID: DLgi8Oa7X2b
--HG--
extra : rebase_source : b18f05c361469d5d276c8a80b371aa001ec58cd4
2016-11-17 12:34:23 +02:00
Andi-Bogdan Postelnicu
a71b3f4e14
Bug 1318282 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in storage/. r=mak
...
MozReview-Commit-ID: HuudUDUcQYu
--HG--
extra : rebase_source : 2b7591b118fea1e0a1b42ae929106191e2b2e1f6
2016-11-17 12:33:18 +02:00
Dave Townsend
8de07a19a0
Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
...
MozReview-Commit-ID: 2ZvTiZDHchz
--HG--
extra : rebase_source : db6482481b7338df491afd6f6fd376eccec84d7e
2016-11-11 08:10:51 -08:00
Sebastian Hengst
f8c9d72cfd
Bug 1310297 - Remove test annotations using b2g, mulet or gonk: storage. r=RyanVM
...
MozReview-Commit-ID: D3QcehYvTpx
--HG--
extra : rebase_source : 842c9bd007676e1d760eaca67e3eb30cb751d5de
2016-11-05 11:29:21 +01:00
Marco Bonardo
100acd6188
Bug 1313309 - Remove getColumnDecltype and compile with SQLITE_OMIT_DECLTYPE. r=asuth
...
MozReview-Commit-ID: 2QR8P7ylg9m
--HG--
extra : rebase_source : 37ed75d0cf724a6c373df6d12df1f36fddc0a646
2016-11-03 21:04:00 +01:00
Jared Wein
87b2d4c295
Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
...
MozReview-Commit-ID: HIUTSdkXxbY
--HG--
extra : rebase_source : 2f05e2f275ac7f293f9c650bdec8943189e3ce01
2016-11-03 14:42:06 -04:00
Marco Bonardo
792726a2c3
Bug 1310152 - AsyncClone may try to reuse a freed Critical Section in Sqlite. r=asuth
...
MozReview-Commit-ID: LW0esWlNfQQ
--HG--
extra : rebase_source : 59e2510a9d4c2343dcde91a572a3d354a15c162f
2016-11-03 15:31:31 +01:00
Jared Wein
5040f17e00
Bug 1312486
- Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
...
MozReview-Commit-ID: 7Gx90a5y8t6
--HG--
extra : rebase_source : 9c8a6b15c19982d720b0163fbbf19d465da786fe
2016-10-24 13:14:19 -04:00