Automatic update from web-platform-tests
[css-backgrounds-3] Add reference, make test more rigorous.
--
[css-backgrounds-3] Make border-radius clipping test cover more cases. https://github.com/w3c/csswg-drafts/issues/5680
--
[css-backgrounds-3] Remove redundant test.
--
wpt-commits: cf9c20c341c9eaff9477c005943864aee35db1f3, e8be8a31f4e0964c817b000332009f5477631eaa, 9219aa2192fc3a52b4323f3908270562b1c21e97
wpt-pr: 26342
Automatic update from web-platform-tests
Cleanup quaternion operations for rotation transforms.
The computation of quaternions during matrix decomposition appeared
to be based off of the matrix transpose. Indexing in the quaternion
calculation is consistent with row-major ordering; however, the "rows"
variable is actually column major order (goes back to the original
implementation of unmatrix in Graphics Gems II). The rotation matrix
constructed from the quaternions also appeared to be assuming row-major
ordering. These discrepancies were mostly corrected for by flipping the
direction of the quaternion when extracting from the matrix.
This patch cleans up the implementation to avoid implicit coordinate
transformations and making the calculations consistent for column-major
ordering in the rotation matrix. Additional comments in the code should
help prevent similar errors in the future.
Combining rotations without a common axis or rotation was needlessly
complex, requiring a conversion to matrices, followed by matrix
blending and rotation extraction from the resulting matrix. In addition
to being computationally expensive, the extra steps reduce numerical
stability and introduce orientation artifacts (the quaternions
(x,y,z,w) and (-x,-y,-z,-w) are effectively equivalent transformations).
The SLERP algorithm in blink::TransformationMatrix and blink::Rotation
now directly call gfx::Quaternion::Slerp. The SLERP algorithm contained
an error in that it always returned the counterclockwise rotation even
if clockwise rotation was shorter. This problem was fixed by flipping
the orientation of the first quaternion if the half angle is greater
than 90 degrees. This ensures that we take the shortest path.
Test expectation were updated for the rotation-composition test. These
tests recorded expectations based on Blink's evaluations which where not
consistent with the spec. In particular, Blink short-circuits the
interpolation process at progress 0 and 1. This leads to boundaries
begin left in a non-canonical form (e.g. "1 1 0 45deg" should be
normalized to "0.707 0.707 0 45deg"). Furthermore, transforms to and
from "none" should be converted to a neutral operator based on its
counterpart (e.g none -> rotate 45deg at 0 should be rotate 0deg). One
of the tests contained a degenerate case of a 180 degree rotation which
is ill defined. This test was updated to avoid the problem. We have unit
tests for edge cases to ensure no division-by-zero errors.
One non-WPT test was affected. Manually confirmed that the SLERP
algorithm was computing a negative value for the scalar component
of the quaternion product. This component in fact is the cos of the half
angle. Since the value was negative, it implies that the rotation angle
was exceeding 180 degrees. We were rotating in the wrong direction.
Design doc: https://docs.google.com/document/d/1RUd5Nt-ZUnKt-P6OZEDurx9g60TjfD0gx_iYAMbkAfE/edit?usp=sharing
Access via chromium credentials
Bug: 998175, 929841
Change-Id: Iaf057eb576aacfd2029342246ac314d783022997
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489727
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822771}
--
wpt-commits: a4474491902bcbd62bc9437e0afc5b0a314c33aa
wpt-pr: 26268
Automatic update from web-platform-tests
css-pseudo: ::placeholder should not support 'writing-mode', 'direction', and 'text-orientation'
https://drafts.csswg.org/css-pseudo-4/#placeholder-pseudo
> All properties that apply to the ::first-line pseudo-element also
> apply to the ::placeholder pseudo-element.
https://drafts.csswg.org/css-pseudo-4/#first-line-styling
> User agents may apply other properties as well except for the
> following excluded properties:
> * writing-mode
> * direction
> * text-orientation
Bug: 1144040
Change-Id: Ia8c74ec80a7d94dc11053e4d95e3facae148f094
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509073
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822556}
--
wpt-commits: a24d40776a2fea52f1a698e10d5bd98f3f46dee5
wpt-pr: 26343
Automatic update from web-platform-tests
Move mixed content autoupgrade test to WPT
This CL moves the existing web_tests for mixed image autoupgrades to
web platform tests and adds similar tests for audio and video mixed
content.
Change-Id: If034df3a85dca428d630c22f5dc661f06eb1ca24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506174
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822330}
--
wpt-commits: 8111339dc6cfb9e3aeef0ce3466ee75958ea1c53
wpt-pr: 26321
Automatic update from web-platform-tests
Load specialPowers web extension in gecko-only wpt tests
Lack of support for specialPowers is often cited as a reason for
developers to write mochitests rather than wpt. Although using
specialPowers means that the tests can't be upstreamed, having it
available in gecko-only tests should reduce the need to write
mochitests and potentially means that a patch which previously would
be written with just mochitests would instead be written with just
wpt, a fraction of which would be unsuitable for sharing.
Nevertheless a gecko-only specialPowers-using test should be
considered the option of last resort when cross-browser APIs such as
testdriver aren't sufficient.
This patch installs the specialPowers extension when the path to the
XPI is provided via a --specialpowers-path command line argument. To
ensure this only happens for gecko-only tests, the url_base is added
to the Test object, and the firefox settings() method is updated to
contain a specialpowers setting, which uses the url_base of the test
to determine if this is a gecko-only test.
Because the extension has to be enabled using marionette, we also need
to route this setting through the to executor, along with the provided
XPI path.
Differential Revision: https://phabricator.services.mozilla.com/D92035
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1668458
gecko-commit: 7be538be385a10b7e17a0b7cbcbe28c57e18e462
gecko-reviewers: jmaher, twisniewski, whimboo
--
wpt-commits: 5dbb0a3fa631ef73da06f37eabf30aeca712672c
wpt-pr: 25982
Automatic update from web-platform-tests
Schemeful Websockets WPT sets its own SameSite=None cookie
By setting its own SSN cookie and checking for it this test no longer
assumes that the cookie jar is empty at the start of its run and should
therefore become more robust against failures.
Because it's setting cookies with, potentially, the same name as other
tests this test will now also use a random value for added confidence
in its results.
Bug: 1143288
Change-Id: Ib256e6366caf4c2edf40637c8caf98955b97924d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505578
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822243}
--
wpt-commits: 5acf9964685d77d48e08c0d68c7983757e2f8789
wpt-pr: 26318
Automatic update from web-platform-tests
JPEG decoder: Reading offsets from EXIF was off by two bytes.
For rational numbers this worked OK by chance when both the nominator and
the denominator were < 65536, because the error was cancelled by the
division. However, this doesn't work when the nominator/denominator are
larger than 65535.
Fixed the offset, and added a test with large nom/denom.
Bug: 1143645
Change-Id: Ic8e46c580437fb4585197807c89a48f43435852a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507110
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822179}
--
wpt-commits: 7f969eb068a87b2ec9cc38f4827b321f43f1ba5e
wpt-pr: 26325
Automatic update from web-platform-tests
[Sanitizer API] Add Document and DocumentFragment as inputs on all methods
Add Document and DocumentFragment as inputs on both sanitize and
sanitizeToString methods.
Bug: 1116418
Change-Id: I06cd10dde9a5ca637140f7c4a71a302faa77abc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487085
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Yifan Luo <lyf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822147}
--
wpt-commits: 66b111d31e69d3856f9d932d75b4f83562361b32
wpt-pr: 26203
Automatic update from web-platform-tests
[:is/:where] Add WPT is-specificity-shadow.html
Our specificity calculation for :host() incorrectly uses the
maximum specificity for the selector that _matched_ inside :host().
Since no selector matches in this case, the specificity is zero, and
we end up applying the wrong thing.
Bug: 1143404
Change-Id: Ib3f4d132c36aedeade3fd79d86c960c352eba120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505896
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822070}
--
wpt-commits: a5251aa8d5a4648c6cf42c470ad017246cf7b4b9
wpt-pr: 26324
Automatic update from web-platform-tests
[WPT] Fix muted errors flag around setTimeout/setInterval
According to the spec
https://html.spec.whatwg.org/C/#timer-initialisation-steps
setTimeout()/setInterval() don't inherit
initiating script's muted errors flag,
which matches with Chromium/Firefox/Safari.
This CL fixes WPT tests to match with the spec/impl, i.e.
to expect errors from setTimeout()/setInterval()
from cross-origin scripts not to be muted.
Bug: 1111134
Change-Id: I3b4d0a5450ccee8fb04113846c9e9773d476cfe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485416
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822054}
--
wpt-commits: d7e3966f8c9ada639ffbdf2f5fcd4939e0d89a7f
wpt-pr: 26180
Automatic update from web-platform-tests
Add webgl2 tests for WebXR (#26038)
This change adds tests to cover a using a WebGL2 XRWebGLLayer for WebXR
Bug: 1087356
Change-Id: I26c262bdd4945a5067c14131ba5d32659f3ffc95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460969
Commit-Queue: Patrick To <patrto@microsoft.com>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821471}
Co-authored-by: Patrick To <patrto@microsoft.com>
--
wpt-commits: 5fe9553936ab4d7ba2b41bce49dbf289aaeca886
wpt-pr: 26038
Automatic update from web-platform-tests
Make xhr/cookies test work when we accept secure cookies on localhost
...by converting it into a WPT test that runs on a different hostname
Bug: 1076138
Change-Id: I2e687685ea32a4c742383900cd0b871dcc5b9c37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475934
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821844}
--
wpt-commits: c54ef34f033f406d5e046b23f5b45db2c34ab869
wpt-pr: 26265
Automatic update from web-platform-tests
[scroll-animations] Handle changes to selector(#id) references
An @scroll-timeline rule may reference elements with selector(#id)
syntax. Whenever the element represented by the selector() function
changes, the "effective" CSSScrollTimeline produced by the
@scroll-timeline rule changes as well.
This CL solves this problem by registering IdTargetObservers
for the IDs a CSSScrollTimeline depends on. The IdTargetObservers
are registered when at least one Animation is attached, and
unregistered when the last Animation is detached. This is
similar to how the ScrollTimeline itself is registered/
unregistered with the resolved scroll source when Animations
attach/detach.
Marking the animation target elements for style recalc
(non-animation-style-change) means we'll re-evaluate the
@scroll-timeline rule against the current DOM state, and consider
whether or not we need a new CSSScrollTimeline for the animation.
Bug: 1074052
Change-Id: Iab0c6b8d8b57d7d63283e97355ee5d9948b831a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356506
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821724}
--
wpt-commits: 326f137f2c3d23cd72b7163707def783f0a1e15b
wpt-pr: 25048
Automatic update from web-platform-tests
Update urllib3 from 1.25.10 to 1.25.11 (#26172)
Co-authored-by: Robert Ma <robertma@chromium.org>
--
wpt-commits: 6770e23f2fe9741d7304c65c245426facb396d0a
wpt-pr: 26172
Automatic update from web-platform-tests
Python 3: Make resource unit tests run on both Py2 and Py3 (#26258)
--
wpt-commits: 001e50de41dc35820774b27e31f77a165f4c0b9b
wpt-pr: 26258
Automatic update from web-platform-tests
[scroll-animations] Handle dynamically changing @scroll-timelines
We are currently able to create new CSSAnimations linked to
CSSScrollTimelines, but we can not change the timeline of a
CSSAnimation that is already running.
There are three types of changes that can trigger a timeline change
for a running animation:
1. When a @scroll-timeline rule is inserted, either via DOM
mutation, or via a change in @media query evaluation.
2. When the computed value of 'animation-timeline' changes.
3. When the elements referenced by a @scroll-timeline rule changes,
for example 'source:selector(#foo)' references an element with
#foo, hence we need a new timeline if #foo is reassigned to
point to a different element.
This CL implements "timeline change detection" in CSSAnimations,
which can discover whether a new timeline is needed or not.
This detection runs whenever there's a non-animation-style-change,
in other words, whenever something is marked for regular style
style recalc, we will check if the timeline currently associated with
an animation is up-to-date, and create a new one if needed.
In this CL, only Item 1 in the above list is fully solved. However,
since this adds the general capability to reconsider previous timeline
choices upon style recalc, it also lays the groundwork for solving
Item 2 & 3.
InertEffect makes things a bit awkward, as usual: we basically have to
predict the effect setTimeline will have on the current time of the
Animation, without actually calling setTimeline. Hence there's a
rather complicated if-statement which makes this prediction. We should
ideally try to get rid of InertEffect and do the setTimeline call
right away.
In the WPT I'm also trying to cover both the result produced by
InertEffect, _and_ the result produced by setTimeline. Hence each test
is run twice: once for the result produced the same frame the style
recalc took place, and once again after scrolling a bit.
Bug: 1074052
Change-Id: Ida36a00eb91e26b493c1e70c20dc7b23be7c9a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335282
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821697}
--
wpt-commits: 01f96b146f09add00bfbeb6c2d12321a666684e4
wpt-pr: 26281
Automatic update from web-platform-tests
[scroll-animations] Handle element-based offsets with null targets
Currently we assume that element-based offsets always have non-null
targets ResolveOffset-time, since we enforce this during the creation
of the (non-CSS) ScrollTimelines.
However, for CSSScrollTimelines, we can't invalidate the rule this way,
since we're referring to an element indirectly via an ID, not with a
pointer to a specific element.
Checking whether or not the target is null during ResolveOffset fixes
this, and it's also what we're supposed to be doing per spec.
This fixes a crash when using @scroll-timelines with element-based
offsets that reference non-existent IDs.
Also removed a nearby comment that's outdated (but not strictly
related to the change in this CL).
Bug: 1074052, 1102788
Change-Id: I4e138b55c3ef8cb122c58755a72a586e94c97e69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498463
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821682}
--
wpt-commits: 305dadc1abc586626e8605a3f9301b46f8baa4bb
wpt-pr: 26284
Automatic update from web-platform-tests
[scroll-animations] Test that orientation resolves against source
I made a mistake when writing this test initially: I wrote tests that
verified that logical orientations (inline/block) resolve against the
writing mode of the target element of the animation attached to a
scroll timeline. This is not correct, it's supposed to resolve against
the writing mode of the *source* of the scroll timeline.
Bug: 1074052
Change-Id: I12f54502575e182f1a4b65df36f402b32632a2ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501623
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821674}
--
wpt-commits: f6deafa6bfa372a86ae542dac0d6dcbfdea7fa5b
wpt-pr: 26306
Automatic update from web-platform-tests
[css-text] Set should_create_line_box on ItemResult of empty lines
When a sequence of preserved space is longer than the line size, we are
handle it as trailing space. The HandleTrailingSpace function creates a
new ItemResult to handle this trailing preserved spaces. In general, it
doesn't need to enable the 'should_create_line_box' flag, since the
previous ItemResult associated to that line already has it.
However, in case of a ItemResult longer than the line, we would end up
with this newly created instance, which flag is disabled by default.
This CL enables the 'should_create_line_box' flag for ItemResult with
'end' offset exceeding the line size. This ensures that lines that are
all preserved spaces will required a LineBox, hence it should account
for computing the box's size.
Bug: 1136748
Change-Id: I0df602d3c13129e4369e351c142601c1806214c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503550
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821530}
--
wpt-commits: 9d4ac1a6aece5742bdb7e797d971de42f39a974b
wpt-pr: 26312
Automatic update from web-platform-tests
Issue #20932 - Part 1. Add a subdomain property getter to URLManifestItem
--
Issue #20932 - Part 2. Add subdomain as an optional arg for server_url
And pipe it through accordingly.
--
Issue #20932 - Part 3. Add tests for the simple "www" subdomain case
--
Issue #20932 - Part 4. Update file-names.md documentation
--
Issue #20932 - Part 5. Add server infrastructure test for www filename flag
--
wpt-commits: 4963140747962d11e715955a046f7f6f07709f1d, 55645b24f6f775fd232e3bd0cee4ee0385f88d63, f6352c9b43ac8c8cf261caaa0b62a9689a891cc5, 5ea5a8a9af11548a3f5ef9c2d1c377f2886abcb7, 6aeae52f01c6f1ed528fd03cc1b3832cda9d2a65
wpt-pr: 26263
Automatic update from web-platform-tests
[LargestContentfulPaint] Allow removed content by default
In this CL we upgrade ExperimentalLargestContentfulPaint to become the
default version. To do this, we do the following:
* Update the LargestContentfulPaintCalculator in Blink since the web
API now should report according to the Experimental version, which is
equivalent to reporting by the values in the detectors monotonically.
That is, we just store the largest text or image size and we report a
new entry whenever we find a candidate with a larger size.
* In Blink's PaintTimingDetector, swap the experimental values with the
non-experimental ones, so that ExperimentalLCP becomes the 'actual' LCP
and the previous LCP becomes 'experimental'.
* In the browser side, change the naming of the experimental vs current
LCP histogram names in both UMA and UKM, so that the experimental name
becomes LCP while the current version becomes LCP2. This means that the
current 'experimental' histograms become obsolete as they are no longer
reported. This is done to continue reporting LCP for some time to
support Finch and other users of these metrics while the transition
occurs.
In a couple of months or so, we will stop reporting the 'experimental'
version of LCP, which means not reporting the LCP (not LCP2) histograms.
This will also enable simplifying the Image and Text
PaintTimingDetectors in Blink, as we will no longer need to keep track
of the paint timestamps of all nodes being painted.
Ukm collection review:
https://docs.google.com/document/d/1gIQ6XuUZtaRb-BmqW8QWpt_cJdIeCsHsAvPVQkiaOhM/edit
Bug: 1045640
Change-Id: I2e27c0f940656b12766feeff3d506c90152f28d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480845
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821436}
--
wpt-commits: 42302f60cf1431543507a09add40a93bd88453fb
wpt-pr: 26234
Automatic update from web-platform-tests
Fix LazyLoad crash when multiple navigations are queued
Putting `loading=lazy` on an out-of-view iframe creates an internal
LazyLoadFrameObserver owned by the HTMLFrameOwnerElement associated with
the iframe element.
Before this CL, `src` mutations reset the HTMLFrameOwnerElement's
LazyLoadFrameObserver member, however old observers may hang around
until they are garbage collected. Until this happens, they are
technically active observers and still reference the
HTMLFrameOwnerElement.
This means if you queue multiple lazy loaded navigations via `src`
attribute mutations, there may be multiple LazyLoadFrameObservers that
are "active" and referencing the element. When the iframe is scrolled
into view, the old still-alive LazyLoadFrameObserver's LoadImmediately()
method may is called before the observer is GC'd. In that case, we start
to navigate the iframe. This calls Frame::Navigate, which is expected to
call LazyLoadFrameObserver::CancelPendingLazyLoad(), which is ensured by
this CHECK [1].
However, the "old" LazyLoadFrameObserver::LoadImmediately() method
invokes Frame::Navigate(), which invokes the "new"
LazyLoadFrameObserver::CancelPendingLazyLoad() method. Therefore the
CHECK mentioned above actually fails, because the "old"
LazyLoadFrameObserver was not cancelled correctly during the navigation
flow.
After this CL, upon creating a new LazyLoadFrameObserver for the
HTMLFrameOwnerElement we reset old LazyLoadFrameObservers by calling
CancelPendingLazyLoad() on them. Then they are effectively disabled
until they are GC'd.
This CL also includes a test which crashes Chrome's renderer before
the fix.
[1]: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/html/lazy_load_frame_observer.cc;l=197;drc=6e8b6ca4b8f8f7ff0b41ba613edd47453bb3aafeR=dcheng@chromium.org, sclittle@chromium.org
Bug: 1137708, 1126127
Change-Id: I0a7eef854bed3e192a5ef68b9cec18c95353298a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497424
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821313}
--
wpt-commits: e41b01508f45f64c321753d142f72c408a2c43c3
wpt-pr: 26279
Automatic update from web-platform-tests
[css-flex] Fix min-width: auto for replaced elements
This is the 'width' version of
https://chromium-review.googlesource.com/c/chromium/src/+/2462574
min-width:auto had been using the image's intrinsic widths as the
content size suggestion, as returned by image_node.ComputeMinMaxSizes().
But that function honors specified min/main/max widths and the content
size suggestion is supposed to ignore those.
Now content size suggestion ignores specified width properties and also
honors the transferred size -- if the specified height is definite, we
pass it through the aspect ratio to determine the content size suggested
width.
Change-Id: I74ed9d96e584605ad8154cc9cb5a94ef84f78544
Bug: 1132627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500448
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821309}
--
wpt-commits: b930c9e45d0e6f2ae21afe4de815164bfd820767
wpt-pr: 26299
Automatic update from web-platform-tests
Reland "[GridNG] Implement alignment within grid-areas."
This is a reland of f6a053018ae3a5fdfe08a0f1bb15ad61d79026cd
Marked:
virtual/layout-ng-grid/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-*.html
as failing.
Original change's description:
> [GridNG] Implement alignment within grid-areas.
>
> This patch implements alignment within a grid-item's grid-area.
> When creating the GridItemData we read of the containers, and
> grid-item's style, or determine its alignment axis-edge, and if it
> should be stretched, saving this information on the GridItemData.
>
> When placing the grid-item it will use this to adjust the offset.
>
> This doesn't implement baseline alignment which requires a secondary
> pass to correctly determine the baseline for the column/row.
>
> The other TODO relates to the constraint-space API, and how grid will
> need a slightly new concept in order to do block-axis stretching
> easily. By default non-replaced grid-items will stretch to the available
> space. A new bit on the space can indicate that we should stretch to
> the available space (if possible), this is similar to the shrink-to-fit
> bit we have today.
>
> This adds a self-start/self-end test as after implementing this now new
> tests passed immediately, and I don't believe we had good test
> coverage for inflow content with these keywords.
>
> Bug: 1045599
> Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176
> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#821043}
Bug: 1045599
Change-Id: I3252d9c72ac57bb38c873004ce3a2436a0b5ed83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502832
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821303}
--
wpt-commits: 3bdd002debcfb965ea5981ace97b1209c080ccbe
wpt-pr: 26307
Automatic update from web-platform-tests
Fix referrer policy inheritance WPT for javascript: URLs
According to the specification, executing a javascript: URL in a
document does not commit a new document. Indeed, following
https://html.spec.whatwg.org/multipage/browsing-the-web.html#javascript-protocol
executing a javascript: URL request gives a response whose status is
204, and processing a response with status 204 does not commit a new
document:
https://html.spec.whatwg.org/multipage/browsing-the-web.html#process-a-navigate-response
In particular, executing a javascript: URL does not change the
document's URL. So if we create a new (empty) iframe and execute right
away some javascript: URL in it, the URL of the iframe document will
be "about:blank".
On the other side, a document with URL "about:blank" will usually not
send any Referer header, since the algorithm for determining the
outgoing referrer goes through the stripping section
https://w3c.github.io/webappsec-referrer-policy/#strip-url which
returns `no-referrer` for a local scheme.
As a consequence, we should always expect the Referer header of an
outgoing fetch request from an `<iframe src="javascript:...">` without
custom referrer to be empty.
This CL adjusts the referrer policy inheritance WP test to that.
Still, we want to test that the referrer policy is inherited correctly
for javascript: URLs. For doing that, we add a custom referrer to the
outgoing fetch request, and we check that the content of the received
Referer header corresponds to the custom referrer modulo the inherited
referrer policy.
Change-Id: Ib3fe0808d3f8a1790e3f565cf2b1648fd2ea6c13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464930
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821284}
--
wpt-commits: a4d3b113bd16fad63c3f32d557dd5b2bc401eba7
wpt-pr: 26081
Automatic update from web-platform-tests
[css-pseudo] Support 'line-height' property in ::marker
The CSSWG resolved in https://github.com/w3c/csswg-drafts/issues/4568
that inherited properties that apply to text can be set on ::marker and
should affect the marker text.
And in https://github.com/w3c/csswg-drafts/issues/5303 it resolved that
'line-height' applies to text (as it already does in Chromium).
Therefore, this patch allows 'line-height' in ::marker. Note it was
already possibly to set it to the list item and the ::marker would
inherit it. Just letting authors set it directly to the ::marker.
Bug: 1031667
TEST=external/wpt/css/css-pseudo/marker-line-height.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html
TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html
marker-line-height.html fails in legacy because ::markers with
'content: normal' are not implemented with actual text.
Change-Id: If63095d046150a2b5f76c40fce93fce1c0e7741c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438413
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821293}
--
wpt-commits: 91da84149d57c560e3435866fd198d1910c22e3f
wpt-pr: 25886
Automatic update from web-platform-tests
Add epislon to matrix tests to fix 0 = -0 problem
This test has a pretty brittle expectation of failure for 0 != -0/
This is of course nonsense. (The astute reader will no doubt notice
that 0 does indeed exactly equal -0).
Fortunately there was already the idea of epsilon differences in the
test that were unused. Turning them on fixes the problem and allows up
to delete the expectation.
Also, in testharness assert_approx_equals(Infinity, Infinity, epsilon)
and assert_approx_equals(NaN, NaN, epsilon) were both returning false.
Considering assert_equals(Infinity, Infinity) and assert_equals(NaN, NaN)
are both true, this seems silly.
Bug: 1140535
Change-Id: Ie8a3977b3d97b920903a08a6301705c8c14fc6e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498791
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821249}
--
wpt-commits: 178d0b3f04a40c1e12a24227dfb47ace3441b284
wpt-pr: 26292
Automatic update from web-platform-tests
Add WP test for referrer policy inheritance when navigating back
When navigating back (through history navigation) to a srcdoc iframe,
we should expect the iframe to apply the same referrer policy it had
originally, even if in the mean time the referrer policy of the main
frame changed.
This CL adds a web platform test for this behaviour. Although the test
is failing at the moment in Chrome, we plan to fix this with the
Policy Container (https://crbug.com/1130587).
Bug: 1130587
Change-Id: I843808fddfc0c6fa5d65ce88599bce51471aa691
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475033
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821243}
--
wpt-commits: a16f810e4ee60d68b71120266c6668b155fbfb63
wpt-pr: 26129
Automatic update from web-platform-tests
Remove Signature-based Resource Loading Restrictions
Signature-based Resource Loading Restrictions is an experimental
feature of Content Security Policies for allowing execution of
scripts only if they have a valid signature. The feature was
prototyped, but it looks like we are not shipping it as it is
for the time being.
Let's remove it from now, we will get it back in the future when
we decide to come back to this.
Bug: 753349
Change-Id: I8fb808999144c32d6fa94ae5bf9299e1da275e3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494882
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821222}
--
wpt-commits: 8fefedccb9ae49bddd9c84d22b21177f156a561e
wpt-pr: 26260
This should have no behavior changes, but allows authors to customize
the amount of spacing between the label and the button of a file control
by applying it as margin of the file selector pseudo rather than as
padding of the label.
Differential Revision: https://phabricator.services.mozilla.com/D95620
Basically, we compute aspect-ratio property only when aspect-ratio is
finite non-zero, so just need to drop the comment and add the wpts.
Differential Revision: https://phabricator.services.mozilla.com/D95411
This matches other browsers, and common sense to some extent.
The code is a bit awkward because I want this behind a pref for now, as
it's not precisely a zero-risk change.
Differential Revision: https://phabricator.services.mozilla.com/D95065
This matches other browsers, and common sense to some extent.
The code is a bit awkward because I want this behind a pref for now, as
it's not precisely a zero-risk change.
Differential Revision: https://phabricator.services.mozilla.com/D95065
In order to determine whether classes or ids are case insensitive we
need the document quirks mode. The sheet quirks mode almost always
matches, but may not match when sheets are added by privileged APIs.
Differential Revision: https://phabricator.services.mozilla.com/D95061
Actually, `DeleteNodeWithTransaction` cannot remove non-editable node. But
we should allow it which parent node is ediatble.
Differential Revision: https://phabricator.services.mozilla.com/D94937
Flex item's content size suggestion is the min-content size in the main
axis. Quoting from the CSS Sizing spec, section "5.1. Intrinsic Sizes",
The min-content size of a box in each axis is the size it would have
if it was a float given an auto size in that axis (and no minimum or
maximum size in that axis) and if its containing block was
zero-sized in that axis. (In other words, the minimum size it has
when sized as “shrink-to-fit”.)
However, all the frame types' GetMinISize() doesn't consider aspect
ratio (either the intrinsic aspect ratio on images or svg, or the
preferred aspect ratio set by the aspect-ratio property). That is, we
currently don't allow `aspect ratio * definite block-size` as part of
the equation in `inline-size:min-content` (bug 1646100 or bug 1670151).
Luckily, nsIFrame::ComputeSize() already takes care of this [2]. We just
need to add a flag to let ComputeSize() behave as if the flex item had
an auto inline size. The code should be similar to FloatMarginISize() in
BlockReflowInput.cpp except we are calculate the flex item's content-box
size.
[1] https://drafts.csswg.org/css-sizing-3/#intrinsic-sizes
[2] https://searchfox.org/mozilla-central/rev/dbced93f1c57942501c23d4633d01ce59d9087a1/layout/generic/nsContainerFrame.cpp#2732,2735-2736
Differential Revision: https://phabricator.services.mozilla.com/D94802
This fixes the failures in bug 1671573 and just works thanks to the
invalidation improvements I did for :is / :where.
Added a couple tests for invalidation which is the tricky bit. 001 is a
very straight-forward test, 002 is the :is test but with :is() replaced
by double-:not().
This also fixes default namespaces inside :is() / :where(), which are
supposed to get ignored, but aren't. Added tests for that and for the
pre-existing :not() behavior which Chrome doesn't quite get right.
Differential Revision: https://phabricator.services.mozilla.com/D94142
Automatic update from web-platform-tests
Use sys.executable instead of "python"
when invoking a Python subprocess from a test to make sure venv is
honoured in the subprocess (especially on Windows where PATH is more
finicky).
Potentially relevant: https://bugs.python.org/issue38905
--
Explicitly set the default branch in tests
to avoid relying on the default config of git
--
Stop using Headless Chrome to run tools/wpt tests
On Windows, using Headless Chrome is suspected to cause ChromeDriver
(and potentially Chrome) to repeatedly crash (see
https://github.com/web-platform-tests/wpt/issues/26131#issuecomment-715584610).
It's unclear what the root cause is yet, but disabling Headless mode is
closer to our real test setup anyway.
On Linux, this requires X (or Xvfb). We already enabled Xvfb for tools/
integration tests on Taskcluster, but forgot to pass the DISPLAY env var
into tox. This change fixes that as well.
--
Mark click_iframe_crossorigin.sub.html.ini as flaky on macOS
--
wpt-commits: 8cede6f45c078d87c4642b7c9ac202f5548dc284, e4346bb55a6070106fbc0d1522316b7e79d0154f, fa0d2c411b5470b9815a8696d7e49f6685fffb91, 4628d18de8c967a6b0b63dba8278478beb391472
wpt-pr: 26267
Automatic update from web-platform-tests
Paint timing: test that iframe painting does not influence root document paint timing. (#26303)
Previous test with similar title didn't actually test that.
Co-authored-by: Noam Rosenthal <noam@webkit.org>
--
wpt-commits: f0497e9cce81acbd936bd0772103d71cf9643514
wpt-pr: 26303
Automatic update from web-platform-tests
[LayoutNG] Paint / hit-test block-fragmented relpos inlines correctly.
PaintLayer does one fragmentainer at a time, but we were painting and
hit-testing everything in each iteration, leading to DCHECK failures
(duplicate paint entries) for painting, and false hit-test matches.
Bug: 829028
Change-Id: Iededd014d84b4db9c29e4df6332033b0138da42b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490111
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821117}
--
wpt-commits: 3b7bd62618cf24bfb1dc12562e95f7d88557d924
wpt-pr: 26237
Automatic update from web-platform-tests
Add StreamPipeOptions to Readable Streams
In an effort to change the blink implementation of readable
streams to better match the Web IDL descriptions in the Streams
API Standard, this CL adds the StreamPipeOptions dictionary [1]
to the ReadableStream class.
[1] https://streams.spec.whatwg.org/#dictdef-streampipeoptions
Bug: 1093862
Change-Id: Ic03fff0d645786dd48c4d8b7cd8682e0442bff0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488329
Commit-Queue: Nidhi Jaju <nidhijaju@google.com>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821113}
--
wpt-commits: 715288c8dc1b021662c4ff259104b040337f6037
wpt-pr: 26251
Automatic update from web-platform-tests
Fieldset NG: Percentage heights for content elements are incorrect
They referred to the container of the fieldset incorrectly.
Bug: 1140595
Change-Id: Ib70048c4e5e59bfd96f44b04ae0c23271e47e840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497945
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821092}
--
wpt-commits: 8c3d050cdd2404e8aed5d34c71636f4125d894ce
wpt-pr: 26282
Automatic update from web-platform-tests
Revert "[GridNG] Implement alignment within grid-areas."
This reverts commit f6a053018ae3a5fdfe08a0f1bb15ad61d79026cd.
Reason for revert: virtual/layout-ng-grid/fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-*.html are failing in multiple bots.
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/75331https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/9841https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17342
Original change's description:
> [GridNG] Implement alignment within grid-areas.
>
> This patch implements alignment within a grid-item's grid-area.
> When creating the GridItemData we read of the containers, and
> grid-item's style, or determine its alignment axis-edge, and if it
> should be stretched, saving this information on the GridItemData.
>
> When placing the grid-item it will use this to adjust the offset.
>
> This doesn't implement baseline alignment which requires a secondary
> pass to correctly determine the baseline for the column/row.
>
> The other TODO relates to the constraint-space API, and how grid will
> need a slightly new concept in order to do block-axis stretching
> easily. By default non-replaced grid-items will stretch to the available
> space. A new bit on the space can indicate that we should stretch to
> the available space (if possible), this is similar to the shrink-to-fit
> bit we have today.
>
> This adds a self-start/self-end test as after implementing this now new
> tests passed immediately, and I don't believe we had good test
> coverage for inflow content with these keywords.
>
> Bug: 1045599
> Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176
> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
> Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
> Cr-Commit-Position: refs/heads/master@{#821043}
TBR=cbiesinger@chromium.org,ikilpatrick@chromium.org,kschmi@microsoft.com,ansollan@microsoft.com
Change-Id: I0a9398ce4bf339a632c3baed7374754f3c664496
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500969
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821074}
--
wpt-commits: 8d8534d5d89e72210e1e13587d2f74022b094715
wpt-pr: 26301
Automatic update from web-platform-tests
[GridNG] Implement alignment within grid-areas.
This patch implements alignment within a grid-item's grid-area.
When creating the GridItemData we read of the containers, and
grid-item's style, or determine its alignment axis-edge, and if it
should be stretched, saving this information on the GridItemData.
When placing the grid-item it will use this to adjust the offset.
This doesn't implement baseline alignment which requires a secondary
pass to correctly determine the baseline for the column/row.
The other TODO relates to the constraint-space API, and how grid will
need a slightly new concept in order to do block-axis stretching
easily. By default non-replaced grid-items will stretch to the available
space. A new bit on the space can indicate that we should stretch to
the available space (if possible), this is similar to the shrink-to-fit
bit we have today.
This adds a self-start/self-end test as after implementing this now new
tests passed immediately, and I don't believe we had good test
coverage for inflow content with these keywords.
Bug: 1045599
Change-Id: I8c9cc51381c3d75519e52b32472b58ec96a6a85a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492176
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#821043}
--
wpt-commits: 75aeef19a407d18832cf0c3946781f97266f74a2
wpt-pr: 26269
In this patch, we changed a lot of tests from PRECONDITION_FAILED to
timeout because we added the PerformancePaintTiming API so the
precodition is no longer failed. TIMEOUT is required because
these tests expect two performance paint entries, but we only
support one of them.
Depends on D68645
Differential Revision: https://phabricator.services.mozilla.com/D68646
This patch includes a couple of changes.
1) Notify contentful paint only during refresh driver ticks.
2) Not only the root document, sub document should also have their own
contentful paint entry.
3) Consider invisible text as contentful as well.
Differential Revision: https://phabricator.services.mozilla.com/D89498
Automatic update from web-platform-tests
[WebCodecs] Add exceptions to decoder errors
This CL creates an exception to be reported by the error callback when
decoders encounter a error. The error is also logged as a message in the
DevTools media tab.
Bug: 1139089
Change-Id: Ib8f71505303cb7ff535928055df05163bc57c267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499422
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#821025}
--
wpt-commits: 29d183c853ecfcbd6aaf75063ca5eddfedb6096f
wpt-pr: 26294
Automatic update from web-platform-tests
Propagate previous fragment's break token for OOF fragmentation layout
When adding out-of-flow results to a fragmentainer, we currently are not
setting up the break token sequence number on the NGBoxFragmentBuilder
for the NGSimplifiedOOFLayoutAlgorithm. This results in painting
different fragments with the same fragmentainer identifier in
NGBoxFragmentPainter::PaintBlockChildren, which causes a DCHECK in
display item caching code.
Instead, use the previous fragment's BreakToken when creating the
NGSimplifiedOOFLayoutAlgorithm. This gets the sequence numbers correct,
whether we replace or create new fragments (for the former
we could just use the existing break token/sequence number).
This adds a WPT test for the unit test that exposed this issue:
NGOutOfFlowLayoutPartTest::PositionedFragmentationWithOverflow
Bug: 1134763
Change-Id: I48a230f8153b8ea63c3a376629c645656423fc2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490209
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#820944}
--
wpt-commits: 779dc12974e409ffe4b998bddf740cfb883f2e50
wpt-pr: 26247
Automatic update from web-platform-tests
Revised test to match behaviour in spec, as revised in issue #245 (#26259)
Co-authored-by: Mike <mike@qtunes.org>
--
wpt-commits: 080385a6d06fe04feaf857ccc6e29b97f9caee24
wpt-pr: 26259
Automatic update from web-platform-tests
[mathml] Support scriptlevel attribute
Implement scriptlevel attribute mapping to the math-depth CSS property
as described here [1].
Adapt attribute-mapping-002.html to expect strings rather than numbers.
[1] https://mathml-refresh.github.io/mathml-core/#dfn-scriptlevel
Bug: 6606
Change-Id: I9bd59bcca840762ee1278ec064e5b81d96dda91c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2474780
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#820720}
--
wpt-commits: 7677719415fdc2ddbd71d8f4242cba736a2f7c30
wpt-pr: 26134
Automatic update from web-platform-tests
[webauthn] Move large blob tests to WPT (#26241)
Move the internal chromium large blob tests to web platform tests. The
tests are designed to be able to run without testdriver support (i.e
using a real authenticator) if support is not available.
Bug: 1114875
Change-Id: Ie87053bd97b8b25b80f8613c366778ea287b909c
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490278
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#820407}
Co-authored-by: Nina Satragno <nsatragno@chromium.org>
--
wpt-commits: 0c780caced8192d6a327acbcc8e074f309dcad45
wpt-pr: 26241
Automatic update from web-platform-tests
FontAccess: Initial font chooser interface
This creates the initial API to initiate a font chooser, behind a flag.
It is different from enumeration at this point for now because the
use-cases they are trying to solve are different.
Both could be unified in the future.
Change-Id: I55d2ac5079f325d86e62e2a348380507b53ea681
Bug: 1138621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488602
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Olivier Yiptong <oyiptong@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820658}
--
wpt-commits: 9a3ff40283ad3fca7299385b82c9b11c05ff7862
wpt-pr: 26207
Automatic update from web-platform-tests
Setup classes for native paintworklet
This CL creates classes to build the infra of native paint worklet.
Specifically, we create a NativePaintWorklet class, and when
we paint the background color, we ask the NativePaintWorklet
to do the paint. Because NativePaintWorklet lives under the
modules/ and paint part is in core/, we need some other classes
to be there so that the paint can call NativePaintWorklet APIs.
Design doc here:
https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit
Bug: 1138997
Change-Id: Ifdabf3ce5226ee4cacac03eec46029e74c3fa9c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464428
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820663}
--
wpt-commits: 99bc1463b81dd53ce802de1165094cadfcc9157f
wpt-pr: 26240
Automatic update from web-platform-tests
Reland "[mathml] Implement special drawing of largeop operator in displaystyle"
This relands commit 02278791d0f1932f7aa6a96b24baa9992521b505, the
problem was that code_point was not initialized.
Change-Id: Iceb747c9bd5d9c9256caefff1b0100958c7f56ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495142
Reviewed-by: Frédéric Wang <fwang@igalia.com>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#820571}
--
wpt-commits: 0f719cd84c4a0a47dc029a8cd4729b50d93b1991
wpt-pr: 26272
Automatic update from web-platform-tests
[css-flex] Fix a test that had bad expectations
Some hand calculations in the reference didn't age well. I replaced the
-ref.html with checkLayout.
The test failed in Firefox in an identical fashion. New test passes in
both browsers.
Just a test, no behavior change.
Fixed: 1111708
Change-Id: I7fc82e5d990c57db6c0d205e30aacaed88990418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490251
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820506}
--
wpt-commits: 1c0b752760fb1ecad549c887a0829c43196b5a8b
wpt-pr: 26208
Automatic update from web-platform-tests
[weakref] HostCleanupFinalizationRegistry is expected to call CleanupFinalizationRegistry(finalizationRegistry) at some point in the future, if possible.
HostCleanupFinalizationRegistry is an implementation-defined abstract operation that is expected to call CleanupFinalizationRegistry(finalizationRegistry) at some point in the future, if possible. The host's responsibility is to make this call at a time which does not interrupt synchronous ECMAScript code execution.
--
Update per review
--
wpt-commits: 603a02ac17d31900edd2701780dab1df68445192, 731cc1d303d9a72422144690101765492e1d3e6c
wpt-pr: 26072
Automatic update from web-platform-tests
[CSS] Apply first line style even if there are out-of-flow blocks
This patch means the code change to apply first line style on the first
innermost in-flow block even if there are out-of-flow blocks.
Following the spec (https://drafts.csswg.org/css-pseudo-4/#first-line-pseudo),
The first formatted line of an element must occur inside a block-level
descendant in the same flow (that is not out-of-flow due to floating or
positioning). So, we should skip out-of-flow children in
LayoutBlock::EnclosingFirstLineStyleBlock().
Bug: 979253
Change-Id: I58836b223b58816f731096a7a9f93e612278d42f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485667
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820337}
--
wpt-commits: 75326ab67bc7c2915fb50c3ecd5c09d57f494d37
wpt-pr: 26205
So, the root cause of this assertion hit was, I forgot to add this path
when I implement the methods to compute target ranges. Although the other
browsers don't support multiple selection ranges, this patch adds WPTs
for the cases.
Depends on D94241
Differential Revision: https://phabricator.services.mozilla.com/D94242
Without using the browser's bfcache the currently selected iframe will
be destroyed. Make sure that the commands don't run into a timeout error.
Differential Revision: https://phabricator.services.mozilla.com/D94721
These files were omitted from the original patch because reformatting them required some manual intervention in order to avoid breaking unit tests. Generally the `noqa` lines were already there and just needed to be moved from one line to another (due to the reformatting by `black`), but sometimes `black` saw fit to move a bunch of stuff all onto one line, requiring me to introduce new `noqa` lines.
Besides the autoformat by `black` and some manual fixups, this patch contains no other changes.
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94052
Depends on D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
moz-wptsync-bot
fantasai
Kevin Ellis
Stephen McGruer
Kent Tamura
Christian Liebel
Carlos IL
James Graham
Steven Bingler
autofoolip
Noam Rosenthal
Yifan Luo
Anders Hartvoll Ruud
Maxim Tsoy
Hiroshige Hayashizaki
Nate Chapin
Blink WPT Bot
Maks Orlovich
pyup.io bot
ziransun
Javier Fernández García-Boente
Xianzhu Wang
Nicolás Peña Moreno
yiyix
Dominic Farolino
David Grogan
Ian Kilpatrick
Antonio Sartori
Oriol Brufau
Aaron Krajeski
Kartikaya Gupta
Emilio Cobos Álvarez
Razvan Maries
Sebastian Hengst
Dorel Luca
Andreas Pehrson
alwu
Cosmin Sabou
Boris Chiou
Narcis Beleuzu
Olli Pettay
Tom Tung
Christoph Kerschbaumer
Edgar Chen
Makoto Kato
Mats Palmgren
Ting-Yu Lin
Byron Campen [:bwc]
Yaron Tausky
Corentin Arnould
Philip Jägenstedt
Robert Ma
Noam Rosenthal
Morten Stenshorne
Nidhi Jaju
Kunihiko Sakamoto
Henrik Skupin
Aaron Klotz
Sean Feng
Frederic Wang
Thomas Guilbert
Daniel Libby
Philipp Hancke
Mike Bremford
Rob Buis
Kagami Sascha Rosylight
Olivier Yiptong
Xida Chen
Rick Waldron
Jaeyong Bae
Henri Sivonen
Kagami Sascha Rosylight
Masayuki Nakano
Ricky Stewart
Tim Huang