The stack object might be a CCW and we want to make it impossible to get a CCW's global. Now the caller has to supply a same-compartment global object, so we no longer rely on getting the CCW's global.
* A new CompletionErrorPage / completion-error-page element which represents the content of the completion error
* Leave the dialog open when complete() results in a 'fail' or 'timeout'.
* The 'done' button on the fail & timeout error page closes the dialog by sending a message up to the paymentDialogWrapper.
* Rewrite the pay button rendering logic to ensure it is disabled when it should be
* Retry handling and UI not addressed here. Will need a new bug when the DOM support has landed.
* Extend completeStatus support in debugging.html and group like actions to tidy up a bit
MozReview-Commit-ID: GDhJqrj14uT
* Add tests to verify that the dialog stays open when completion fails or times out
* Add tests to verify that complete() throws after the timeout
* Rework completeStatus mochitest for PaymentDialog
MozReview-Commit-ID: 4ZNVEYMp7h5
--HG--
extra : rebase_source : 1d8e691eb44e74156a956dff73e1359af2a6934a
These typically run for 25-50 minutes. So, if they are taking longer than that,
there is likely a problem.
Differential Revision: https://phabricator.services.mozilla.com/D2252
--HG--
extra : moz-landing-system : lando
* Spot-fix order details test to clone request before modifying it
MozReview-Commit-ID: AXjI1veRSk9
--HG--
extra : rebase_source : ee12efc493c343b9f18cee2cb281a5fe6731731d
We want our clang bootstrap to use the GCC headers we're building with,
not whatever sysroot it happens to find on the server we're building on.
The -gcc-toolchain argument we specify when building clang will also be
picked up by llvm-config, so we need to strip it out when building the
plugin. Otherwise, we will get peculiar failures about not being able
to find C++ header files.
If the preference security.enterprise_roots.enabled is set to true, the platform will import trusted TLS certificates from the OS X keystore.
Differential Revision: https://phabricator.services.mozilla.com/D2169
--HG--
extra : moz-landing-system : lando
I mistranslated the boolean success value of the old initListBuild
method. Simplifying it to just use a promise rejection should be
equivalent and simpler, since this is only run from the update
method of WindowsJumpLists, and the call sites for that don't do
anything afterwards.
Differential Revision: https://phabricator.services.mozilla.com/D2244
--HG--
extra : moz-landing-system : lando
For reducing virtual calls of nsIPlaintextEditor::OutputToString(),
TextEditor should have new non-virtual public method, ComputeTextValue() and
shared code between it and OutputToString() as ComputeValueInternal().
MozReview-Commit-ID: KFeovQ568bf
--HG--
extra : rebase_source : a5cfb24cefe44f7c60e649959ed49350ed00d4d6
This patch creates non-virtual method, EditorBase::GetDocumentCharsetInternal(),
for internal use of nsIEditor::GetDocumentCharacterSet() since the virtual
call method is redundant and the caller cannot be marked as const.
MozReview-Commit-ID: v6kDo2eKg3
--HG--
extra : rebase_source : 07f6dd8341cb6686835db2ee3ded479323cccca9
TextEditor::GetAndInitDocEncoder() modifies only mCachedDocumentEncoder and
mCachedDocumentEncoderType which are cache of the method to save recreation
cost of document encoder when same type document encoder is requested.
So, with marking them mutable, we can change the method to a const method.
MozReview-Commit-ID: 80W0NtQhJOR
--HG--
extra : rebase_source : 84f4b49fe3a3124c0de99b39a2141a8cee553e54
When migrating GeckoService to Oreo (Bug 1467840), the Gecko initialization was
inadvertently moved on a background thread.
This patch moves the initialization back on main thread.
MozReview-Commit-ID: Cxp7lGzPgXH
--HG--
extra : rebase_source : cf12c311dcae47cad42235587ace684788a848a1
After API 24 DownloadManager.COLUMN_LOCAL_FILENAME got deprecated and querying
for it would throw an error.
To get around this DownloadManager.COLUMN_LOCAL_URI can be used but which adds
the "file://" prefix.
MozReview-Commit-ID: CvkoFyRCLo6
--HG--
extra : rebase_source : 66b0eeecf40b1b1b9fa51860f29032e02ebe507b
Jan de Mooij
Olli Pettay
shindli
Cosmin Sabou
Sam Foster
Ryan VanderMeulen
André Bargull
Tiberius Oros
Sebastian Hengst
Tooru Fujisawa
Bob Clary
Tom Prince
Bobby Holley
Edgar Chen
Kris Maglione
Nicolas Silva
Jeff Muizelaar
Nathan Froyd
Kristen Wright
Johann Hofmann
Miko Mynttinen
Bharat Raghunathan
Alexandre Poirot
David Keeler
Michael Kaply
Doug Thayer
Masayuki Nakano
Petru Lingurar