9ff49a844a
Bug 1669108 - Unused MOZ_ASSERTed variable in non-DEBUG opt gcc compile r=anba
...
Differential Revision: https://phabricator.services.mozilla.com/D92349
2020-10-06 17:56:05 +00:00
915c793341
Bug 1658308 - Implement String.prototyp.item in Nightly. r=anba
...
Differential Revision: https://phabricator.services.mozilla.com/D92640
2020-10-06 16:58:11 +00:00
e39bac7f69
Bug 1669358 - Performance tweaks for XDR-Stencil. r=arai
...
Avoid well-known checks for XDR ParserAtoms and reserve container sizes when
we know them. Also avoid building delazification map if not needed.
Differential Revision: https://phabricator.services.mozilla.com/D92510
2020-10-06 16:37:26 +00:00
d9cd198ba1
Bug 1519636 - Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D92459
2020-10-06 16:12:00 +00:00
0cdf64bae1
Bug 1668375 - wasm: Decode ref.null in element segments as heap type. r=lth
...
Because we special case the decoding code for element segments, the change
to use heap types for ref.null wasn't propagated from OpIter. We should
decode as a heap type here.
Differential Revision: https://phabricator.services.mozilla.com/D91997
2020-10-05 15:47:37 +00:00
fb950b7f4d
Bug 1668373 - wasm: Split CompilerEnvironment from ModuleEnvironment. r=lth
...
ModuleEnvironment contains a CompilerEnvironment pointer, which describes the compiler selection,
tiering, and whether debugging is enabled. None of this information is needed for validation,
so wasm::Validate() has to create a synthetic CompilerEnvironment which is never read. This
isn't a large issue, but indicates ModuleEnvironment is doing too many things.
This commit removes CompilerEnvironment from ModuleEnvironment and pipes it
through the compiler pipeline. This is fairly straightforward except for:
* wasm::Validate() no longer needs to create a synthetic compiler env
* DecodeModuleEnvironment() used to invoke moduleEnv.compilerEnv.computeParameters(d)
after the preamble was decoded. I believe this was needed for handling the GC opt-in
section, which is no longer used. I moved this call to computeParameters() to after
all callers of DecodeModuleEnvironment().
* I added an assertion in IonCompileFunctions/CraneliftCompileFunctions that they are
not being invoked for debugged modules.
Differential Revision: https://phabricator.services.mozilla.com/D91995
2020-10-05 15:47:27 +00:00
ab7788915e
Bug 1668373 - wasm: Rename future ambiguous uses of 'env_' to 'moduleEnv_'. r=lth
...
The next commit will move CompilerEnvironment out of ModuleEnvironment and pass it
through the compiler pipeline. The compiler pipeline typically uses 'env_' to refer
to the module environment, with a 'compilerEnv_' being used as well I think we should
rename 'env_' to 'moduleEnv_'.
The one exception is within validation/decoding where I think using just 'env_' to
refer to the module environment is fine.
Differential Revision: https://phabricator.services.mozilla.com/D91994
2020-10-05 17:01:32 +00:00
907323e1fd
Bug 1669428 - Properly control experimental SIMD instructions. r=jseward
...
This gets rid of an ad-hoc boolean constant and introduces a configuration flag
for experimental SIMD instructions. The flag is on by default in Nightly if
SIMD is also enabled; otherwise off. This patch therefore disables support for
experimental SIMD instructions in beta and release, where they have been
available with the other SIMD instructions behind a pref. This seems OK:
code using unstable bits of an in-progress proposal should stick to Nightly.
Differential Revision: https://phabricator.services.mozilla.com/D92554
2020-10-06 12:10:56 +00:00
dad6bfc0e8
Bug 1668729 - Disable GC zeal for Environment-getVariable-13.js to fix intermittent failures. r=jonco
...
The test is asserting that certain code runs in Ion.
Differential Revision: https://phabricator.services.mozilla.com/D92549
2020-10-06 11:37:00 +00:00
45b32d3b4f
Bug 1669196 - Guard a test on word width. r=jseward
...
A test introduced in bug 1669003 should only be run on 32-bit systems
for now because (a) that's what it's intended for and (b) it will fail
on aarch64 due to bug 1666747 (bad unaligned writes at the end of
memory):
On 32-bit ARM, the test case performs aligned writes and thus tests
what it's supposed to test. On 64-bit ARM, the write will be
unaligned and hence fail due to the latter bug.
Differential Revision: https://phabricator.services.mozilla.com/D92544
2020-10-06 08:08:56 +00:00
6d87f384ee
Bug 1666983 - Set ScriptStencil.extent.toStringEnd of class constructor to correct value when delazifying. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D92402
2020-10-06 02:18:16 +00:00
75d6f17ffd
Bug 1667203 - Check for a jitScript before spewing anything in rateMyCacheIR. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91349
2020-10-05 20:17:05 +00:00
cf8a7fbc60
Bug 1667203 - Have rateMyCacheIR return void. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91348
2020-10-05 20:17:18 +00:00
5f684ebd61
Bug 1666615 - Update comments for CacheIR health report. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91347
2020-10-05 20:16:35 +00:00
1d6a1aa539
Backed out changeset 5a5bb14b79fe (bug 1666983) for SM bustages on Stencil.cpp
2020-10-06 02:59:32 +03:00
b6c29c2250
Bug 1669012 - Make MToString hoistable. r=iain
...
Enabling this code allows us to hoist some additional well typed cases.
Compared to normal Ion of course we quite often have Value typed PHIs etc.
Differential Revision: https://phabricator.services.mozilla.com/D92473
2020-10-05 20:05:46 +00:00
f6c4220fae
Bug 1666983 - Bug 1666983 - Set ScriptStencil.extent.toStringEnd of class constructor to correct value when delazifying. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D92402
2020-10-05 19:09:19 +00:00
f542b51fae
Bug 1667697 - Do not transcode well-known parser atoms and short atoms. r=djvj,tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91922
2020-10-05 19:00:50 +00:00
8d1987c5dd
Bug 1668237 - Make CompilationInfoVector::deserializeStencils succeededOut parameter required. r=djvj
...
The failure case happens only if encoder or decoder is buggy,
and basically happens only while developing.
Thus this doesn't have a testcase that can hit the case.
Differential Revision: https://phabricator.services.mozilla.com/D91915
2020-10-05 18:36:10 +00:00
14b628d060
Bug 1664547: Hold mSaveMonitor while changing mCacheInvalidated. r=mccr8
...
Differential Revision: https://phabricator.services.mozilla.com/D91985
2020-09-30 21:30:39 +00:00
6c32abf86e
Backed out 36 changesets (bug 1661256) for bustages on ABIFunctionList-inl.h . CLOSED TREE
...
Backed out changeset b8b4abf7dee6 (bug 1661256)
Backed out changeset 1aa852081aef (bug 1661256)
Backed out changeset b566932212e8 (bug 1661256)
Backed out changeset 87e04a5bd5ff (bug 1661256)
Backed out changeset 3b67e71d0f0c (bug 1661256)
Backed out changeset 026239352468 (bug 1661256)
Backed out changeset 6ab9cb022dd4 (bug 1661256)
Backed out changeset 1832ad83cf48 (bug 1661256)
Backed out changeset bb5e596c36e8 (bug 1661256)
Backed out changeset 79c13af90973 (bug 1661256)
Backed out changeset 5202146b8fe4 (bug 1661256)
Backed out changeset 8cb65ed23449 (bug 1661256)
Backed out changeset f6fee4dfa4a6 (bug 1661256)
Backed out changeset 0068dd86305a (bug 1661256)
Backed out changeset 0de744f52b50 (bug 1661256)
Backed out changeset 71478b8febf9 (bug 1661256)
Backed out changeset da67f68ff283 (bug 1661256)
Backed out changeset 8bc6fafde18c (bug 1661256)
Backed out changeset 66b93aec837d (bug 1661256)
Backed out changeset 79f12bfd02c9 (bug 1661256)
Backed out changeset f7befef7cc09 (bug 1661256)
Backed out changeset e2039874b3be (bug 1661256)
Backed out changeset 26f99770a459 (bug 1661256)
Backed out changeset 958906054082 (bug 1661256)
Backed out changeset 86f20015ac25 (bug 1661256)
Backed out changeset 350afbd70d33 (bug 1661256)
Backed out changeset 7c47162a0274 (bug 1661256)
Backed out changeset c543d4605379 (bug 1661256)
Backed out changeset 5502d812c16c (bug 1661256)
Backed out changeset bf92594d6969 (bug 1661256)
Backed out changeset 785c118aafde (bug 1661256)
Backed out changeset 0eccae5085df (bug 1661256)
Backed out changeset 4ac6aec3ab01 (bug 1661256)
Backed out changeset ad96857a613a (bug 1661256)
Backed out changeset e8efad448dcd (bug 1661256)
Backed out changeset 92663cbff599 (bug 1661256)
2020-10-05 21:39:17 +03:00
e3c0f4f6dc
Bug 1661256 part 36 - Convert __aeabi_*divmod callWithABI calls. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91816
2020-10-05 16:55:00 +00:00
6899644a28
Bug 1661256 part 35 - Convert various analysis functions called with callWithABI. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D91815
2020-10-05 16:54:59 +00:00
f842eb0ac4
Bug 1661256 part 34 - Convert InvokeFomInterpreterStub callWithABI call. r=lth
...
Differential Revision: https://phabricator.services.mozilla.com/D91814
2020-10-05 16:56:32 +00:00
83bfd111d3
Bug 1661256 part 33 - Convert String-related callWithABI calls. r=djvj
...
Differential Revision: https://phabricator.services.mozilla.com/D91813
2020-10-05 16:56:30 +00:00
690d601f54
Bug 1661256 part 32 - Convert GC-related callWithABI calls. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D91812
2020-10-05 16:56:27 +00:00
bb62e3366b
Bug 1661256 part 31 - Convert BigInt's callWithABI calls. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91811
2020-10-05 16:56:24 +00:00
4688bba3ec
Bug 1661256 part 30 - Convert EmulatesUndefined callWithABI calls. r=caroline
...
Differential Revision: https://phabricator.services.mozilla.com/D91810
2020-10-05 16:56:22 +00:00
2959ab045c
Bug 1661256 part 29 - Convert LazyLinkTopActivation callWithABI calls. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D91809
2020-10-05 16:56:19 +00:00
4f80f732cd
Bug 1661256 part 28 - Convert NativeObject's callWithABI calls. r=djvj
...
Differential Revision: https://phabricator.services.mozilla.com/D91808
2020-10-05 16:56:17 +00:00
72b3b6890e
Bug 1661256 part 27 - Convert HandleCodeCoverage* callWithABI calls. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91807
2020-10-05 16:56:14 +00:00
94d84aaa96
Bug 1661256 part 26 - Convert Property accessors used with callWithABI. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D91806
2020-10-05 16:56:12 +00:00
8436df2d84
Bug 1661256 part 25 - Convert Allocate* and CreateMathResult* callWithABI calls. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91805
2020-10-05 16:56:09 +00:00
0c245228e1
Bug 1661256 part 24 - Convert Atomics*Fn callWithABI dynamic calls. r=lth
...
Differential Revision: https://phabricator.services.mozilla.com/D91804
2020-10-05 16:56:07 +00:00
7946029c43
Bug 1661256 part 23 - Convert js_free callWithABI calls. r=lth
...
Differential Revision: https://phabricator.services.mozilla.com/D91803
2020-10-05 16:56:01 +00:00
c66628cfa2
Bug 1661256 part 22 - Convert DOM/JSNative calls called with callWithABI. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91802
2020-10-05 16:55:59 +00:00
a49b62bd9c
Bug 1661256 part 21 - Convert jsnum.h functions called with callWithABI. r=caroline
...
Differential Revision: https://phabricator.services.mozilla.com/D91801
2020-10-05 16:55:56 +00:00
58b77b84bc
Bug 1661256 part 20 - Convert calls to *IteratorObject callWithABI calls. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91800
2020-10-05 16:55:54 +00:00
198adb74f1
Bug 1661256 part 19 - Convert js::ExecuteRegExpAtomRaw callWithABI call. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91799
2020-10-05 16:55:51 +00:00
d3688b138d
Bug 1661256 part 18 - Convert js::jit::AssertValid* functions called with callWithABI. r=caroline
...
Differential Revision: https://phabricator.services.mozilla.com/D91798
2020-10-05 16:55:49 +00:00
d2db13a608
Bug 1661256 part 17 - Convert UnaryMathFunction to use DynamicFunction. r=mgaudet
...
Differential Revision: https://phabricator.services.mozilla.com/D91797
2020-10-05 16:55:47 +00:00
ad12c6c649
Bug 1661256 part 16 - Convert JitMarkFunction to return the DynFn type. r=djvj
...
Differential Revision: https://phabricator.services.mozilla.com/D91796
2020-10-05 16:55:44 +00:00
7ba4af9e43
Bug 1661256 part 15 - Convert TraceLogging.h functions called with callWithABI. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91795
2020-10-05 16:55:42 +00:00
091ec266a9
Bug 1661256 part 14 - Add typed callWithABI functions calls for computed function pointer. r=jandem
...
Differential Revision: https://phabricator.services.mozilla.com/D91794
2020-10-05 16:55:39 +00:00
f91e2f9be9
Bug 1661256 part 13 - Convert HandleException callWithABI calls and make them explicit. r=tcampbell
...
Differential Revision: https://phabricator.services.mozilla.com/D91793
2020-10-05 16:55:37 +00:00
324ad1fd7b
Bug 1661256 part 12 - Convert calls to JS_MASM_VERBOSE functions called with callWithABI. r=lth
...
Differential Revision: https://phabricator.services.mozilla.com/D91792
2020-10-05 16:55:34 +00:00
f4c5045f13
Bug 1661256 part 11 - Convert js::jit::InitBaselineFrameForOsr callWithABI calls. r=djvj
...
Differential Revision: https://phabricator.services.mozilla.com/D91791
2020-10-05 16:55:32 +00:00
947fd357bc
Bug 1661256 part 10 - Convert Bailout.h functions called with callWithABI. r=djvj
...
Differential Revision: https://phabricator.services.mozilla.com/D91790
2020-10-05 16:55:30 +00:00
8f5c579336
Bug 1661256 part 9 - Convert js::ArrayShiftMoveElements callWithABI call. r=caroline
...
Differential Revision: https://phabricator.services.mozilla.com/D91789
2020-10-05 16:54:24 +00:00
18d09de854
Bug 1661256 part 8 - Convert js::RegExp*OptimizableRaw callWithABI calls. r=iain
...
Differential Revision: https://phabricator.services.mozilla.com/D91788
2020-10-05 16:54:22 +00:00
Steve Fink
Tom Schuster
Ted Campbell
Sylvestre Ledru
Ryan Hunt
Lars T Hansen
Jan de Mooij
Tooru Fujisawa
Caroline Cullen
Narcis Beleuzu
Kris Maglione
Nicolas B. Pierron