Граф коммитов

6965 Коммитов

Автор SHA1 Сообщение Дата
Alex Lopez 75dfe35468 Bug 1696251 - Pass MachCommandBase object as first argument for Mach Commands. r=mhentges,remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers
As an intermediate step to allow mach commands as standalone functions, the MachCommandBase
subclass instance that currently corresponds to self has to be made available as a separate
argument (named command_context).

Differential Revision: https://phabricator.services.mozilla.com/D109650
2021-04-19 16:15:11 +00:00
Steve Fink 06fa1e33cc Bug 1697929 - Make mach work in the spidermonkey release package r=firefox-build-system-reviewers,glandium
Differential Revision: https://phabricator.services.mozilla.com/D108129
2021-04-19 14:21:43 +00:00
Bogdan Tara b88a6d9d04 Backed out 2 changesets (bug 1704827, bug 1703012) for screenshots mochitest timeouts CLOSED TREE
Backed out changeset 95a07d286cd7 (bug 1704827)
Backed out changeset 5e8a1732b021 (bug 1703012)
2021-04-16 22:40:48 +03:00
Emma Malysz 4f7010a85c Bug 1703012: fix control center and identity panel proton styling r=desktop-theme-reviewers,fluent-reviewers,mconley,flod,pbz,Itiel
Migrates two strings to fluent and uses sentence casing.
Places identity security block into a toolbar button.
Fixes margin spacing.
Removes green color from secure connection.

Differential Revision: https://phabricator.services.mozilla.com/D111368
2021-04-16 16:38:02 +00:00
Brindusan Cristian e2c4d3a898 Backed out 2 changesets (bug 1704827, bug 1703012) for causing bc failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset e3567ea32072 (bug 1704827)
Backed out changeset 43bb3216b816 (bug 1703012)
2021-04-16 18:53:26 +03:00
Emma Malysz ae77fc5e90 Bug 1703012: fix control center and identity panel proton styling r=desktop-theme-reviewers,fluent-reviewers,mconley,flod,pbz,Itiel
Migrates two strings to fluent and uses sentence casing.
Places identity security block into a toolbar button.
Fixes margin spacing.
Removes green color from secure connection.

Differential Revision: https://phabricator.services.mozilla.com/D111368
2021-04-16 14:42:57 +00:00
Noemi Erli 40d417bd3c Bug 1704126 - Fix lint failure r=fix CLOSED TREE 2021-04-16 04:20:52 +03:00
Mike Hommey f2dafefef4 Bug 1704126 - Make mach create-mach-environment fail when running under Rosetta. r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D112151
2021-04-16 01:03:56 +00:00
Mike Hommey 3b212b0272 Bug 1705296 - Don't create a python2 mach virtualenv. r=firefox-build-system-reviewers,mhentges
No mach command uses python2 anymore, so we don't need to create a
virtualenv for python2.

Differential Revision: https://phabricator.services.mozilla.com/D112148
2021-04-16 01:00:09 +00:00
Andrew Halberstadt 002c099fc4 No Bug - [mozversioncontrol] xfail 'test_branch.py' with git < 2.22.0, r=bhearsum
The 'git branch --show-current' flag didn't exist prior to that version.

Differential Revision: https://phabricator.services.mozilla.com/D112043
2021-04-14 20:49:26 +00:00
Andrew Halberstadt 408f22ce3b No Bug - [mozversioncontrol] Add a test for vcs.branch, r=bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D112015
2021-04-14 14:03:10 +00:00
Ben Hearsum 93969911bd No bug: ensure ./mach taskgraph --diff returns you to your starting branch when using git. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D111848
2021-04-14 13:49:01 +00:00
Claudia 69e599d847 Bug 1651012 - Organize certerror code into its own directory in browser/base/content/ r=prathiksha,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D110951
2021-04-14 10:24:38 +00:00
Alexandru Michis 9b58a1c6f5 Backed out changeset 8a21200047bb (bug 1651012) for causing bc failures in browser_parsable_script.js
CLOSED TREE
2021-04-14 01:52:26 +03:00
Claudia d6b7c6e76b Bug 1651012 - Organize certerror code into its own directory in browser/base/content/ r=prathiksha,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D110951
2021-04-13 18:54:28 +00:00
Nick Alexander faad7e9113 Bug 1391106 - Support `mach watch` for non-artifact builds. r=firefox-build-system-reviewers,mhentges
I manually compared `$TOPOBJDIR/faster/unified_install_dist_bin` for
an artifact and a non-artifact build, and found only a few
pre-processing differences.  I can't recall why this wasn't supported
initially; I think it used to be that manifests overlapped and that
the interaction with the RecursiveMake backend was more complicated.
But I see no reason why this shouldn't work, and would like to get
some folks to test it in the wild.

Differential Revision: https://phabricator.services.mozilla.com/D110311
2021-04-13 16:02:21 +00:00
Mike Hommey 9bce63da4f Bug 1704685 - Remove leftover from bug 1686888. r=firefox-build-system-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D111765
2021-04-13 04:57:48 +00:00
Nisarg 4b18d50091 Bug 1698838 - Create a format command as an alternative to lint --fix. r=ahal
***
Bug 1698838 - Restrict the list of linters to valid formatters r=ahal

***
Bug 1698838 - Abort formatting even if one of the linters passed is invalid r=ahal

***

***

Differential Revision: https://phabricator.services.mozilla.com/D109231
2021-04-12 18:01:14 +00:00
Kagami Sascha Rosylight d9f6cded53 Bug 1704375 - Close tar file after use in vendor_manifest.py r=firefox-build-system-reviewers,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D111566
2021-04-12 03:14:06 +00:00
Nick Alexander 29fc399d04 Bug 1703886 - Let `MOZ_BACKGROUNDTASKS` and `MOZ_UPDATE_AGENT` ride the trains. r=application-update-reviewers,firefox-build-system-reviewers,mhentges,bytesized
This also makes `MOZ_UPDATE_AGENT` depend on `MOZ_BACKGROUNDTASKS`.

There's no need to lint the `tools/update-programs` project, since
it's not a supported configuration.  The next consumer can
rehabilitate it or remove it.

Differential Revision: https://phabricator.services.mozilla.com/D111313
2021-04-11 20:50:15 +00:00
Cosmin Sabou 79873d0515 Bug 1703664 - Fix linting opt failure on mozlint/roller.py.
CLOSED TREE
2021-04-09 18:56:25 +03:00
Marco Castelluccio 2f5bc535f6 Bug 1703664 - Enable showing all warnings from mozlint-based linters in reviewbot. r=ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D111166
2021-04-09 15:08:57 +00:00
Chris Fallin e888f83b57 Bug 1701603 part 1 - Support WASI as a new target for compilation. r=glandium
Add new OS - WASI and new processor - wasm32 to the SM's build system.

Differential Revision: https://phabricator.services.mozilla.com/D110067
2021-04-08 08:02:15 +00:00
Csoregi Natalia bd01562887 Backed out changeset 3ec9f9951ffe (bug 1377445) for bustage due to missing file. CLOSED TREE 2021-04-08 11:04:47 +03:00
Bryan Quigley a1b5fde57c Bug 1377445 - Drop gtk2 depends r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D111121
2021-04-08 07:38:40 +00:00
Nicklas Boman 2722651b9d Bug 1702896 - Mach bootstrap does not work on openSUSE Leap 15.2 (anymore) r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D110771
2021-04-07 19:21:54 +00:00
Nicklas Boman 361cf9d1e8 Bug 1703305 - Mach bootstrap for openSUSE will try to install pip/mercurial as root. maby use --user instead? r=firefox-build-system-reviewers,mhentges
To me this sounds like a good idea, but im not sure :)

Differential Revision: https://phabricator.services.mozilla.com/D110960
2021-04-07 19:21:17 +00:00
Steve Fink b5836beb66 Bug 1702763 - Fix check for verbose flag in mozperftest r=perftest-reviewers,Bebe
Differential Revision: https://phabricator.services.mozilla.com/D110677
2021-04-06 19:46:00 +00:00
Francesco Lodolo (:flod) 830a1bba6e Bug 1703003 - Migrate Bookmark panel Cancel/Remove buttons to Fluent and fix capitalization, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110894
2021-04-06 17:15:31 +00:00
Emma Malysz fb284a526f Bug 1702461, set fxa submenu header correctly when opening the panel r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110633
2021-04-02 15:27:01 +00:00
Cosmin Sabou f06d692475 Backed out changeset 23251cfb884e (bug 1616239) for causing windows aarch bustages. 2021-04-01 23:03:29 +03:00
Kershaw Chang 93423e9aa1 Bug 1616239 - Enable http3 tests for asan r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D108635
2021-04-01 18:31:23 +00:00
Mitchell Hentges 66008bc119 Bug 1702279: Sentry should patch absolute paths without leading slash r=sheehan
Due to strange module-name generation we do (e.g.:
`mach.commands.be68b9824a51408e815262b2e8f21d6b`), Sentry's conversion
of absolute paths to local paths fails - instead, the path remains
absolute, but without the leading forward slash. (Except on Windows,
where `c:/` is maintained).

We resolve this by not requiring the leading slash when patching
absolute paths.

Differential Revision: https://phabricator.services.mozilla.com/D110436
2021-04-01 16:30:57 +00:00
Mitchell Hentges 9511c83afa Bug 1702353: Don't submit exception to Sentry if revision can't be found r=sheehan
This can occur if the user is using cinnabar and it fails to find the
equivalent hg revision for their current base commit.

It's significantly less valuable to have exceptions with an "anonymous
release", so we skip these exceptions instead.

Differential Revision: https://phabricator.services.mozilla.com/D110481
2021-04-01 16:23:57 +00:00
Emma Malysz caad0a1fe9 Bug 1698062: set app menu width and ensure text can wrap r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D110461
2021-04-01 14:58:05 +00:00
Gabriele Svelto 831c355e81 Bug 1701576 - Improve openSUSE detection during bootstrap r=glandium,mhentges DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D110059
2021-04-01 10:04:31 +00:00
june wilde 9a74eac849 Bug 1699448 - Allow any valid git reference in moz.yaml revision field; r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D108953
2021-03-31 14:17:19 +00:00
Francesco Lodolo (:flod) 454d8daa57 Bug 1702118 - Migrate more FxA toolbar button strings to Fluent, r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D110366
2021-03-31 13:39:10 +00:00
Mitchell Hentges 9043e515e9 Bug 1645425: Annotate Sentry reports with base revision r=sheehan
To track whether issues being reported are for old versions, we attach
an hg revision hash as a release version with each report.

We use the base_ref because:
* It's a public revision that we can look up, and
* Since we only submit Sentry events when mach is unmodified,
  it's essentially acting as a version identifier.

Differential Revision: https://phabricator.services.mozilla.com/D108307
2021-03-30 16:22:58 +00:00
Chris H-C ea2a18d757 Bug 1697555 - Remove Telemetry portions of Accounts Ecosystem Telemetry r=Dexter
Differential Revision: https://phabricator.services.mozilla.com/D110091
2021-03-29 20:03:38 +00:00
Andrew Halberstadt a0922d0765 Bug 1700632 - [mach] Fix bug in zsh completion script generation, r=tjr
We want to make sure to only strip a single leading or trailing quote, and
not all of them.

Differential Revision: https://phabricator.services.mozilla.com/D109804
2021-03-29 19:14:30 +00:00
Agi Sferro 674d630320 Bug 1697844 - Remove unused FENNEC_NIGHTLY. r=esawin
Differential Revision: https://phabricator.services.mozilla.com/D108049
2021-03-24 20:06:24 +00:00
Alexandru Michis ced948f22d Backed out 10 changesets (bug 1697844) for causing mpu failures in test_visualmetrics.py
CLOSED TREE

Backed out changeset 63b3268b0d2d (bug 1697844)
Backed out changeset 875b2aa342d9 (bug 1697844)
Backed out changeset 4fb528aaf7d5 (bug 1697844)
Backed out changeset 6ef5e1c9ca21 (bug 1697844)
Backed out changeset 430d6c940eb9 (bug 1697844)
Backed out changeset 7a306f28dc64 (bug 1697844)
Backed out changeset 871a40e2fc00 (bug 1697844)
Backed out changeset 083e9ce71d14 (bug 1697844)
Backed out changeset b53930a3f065 (bug 1697844)
Backed out changeset 24326d04dd37 (bug 1697844)
2021-03-24 21:59:28 +02:00
Emilio Cobos Álvarez 22061e8965 Bug 1697053 - Let non-native-theme ride the trains in Firefox 89. r=cpeterson,mstange
Differential Revision: https://phabricator.services.mozilla.com/D109555
2021-03-24 19:11:05 +00:00
Agi Sferro a6f7203643 Bug 1697844 - Remove unused FENNEC_NIGHTLY. r=esawin
Differential Revision: https://phabricator.services.mozilla.com/D108049
2021-03-24 18:54:45 +00:00
Tom Ritter 7d6a463f12 Bug 1700621: Add needinfo field to the moz.yaml schema r=jewilde
Differential Revision: https://phabricator.services.mozilla.com/D109615
2021-03-24 17:17:11 +00:00
Mike Conley f7505a1445 Bug 1697617 - Update Synced Tabs menu for Proton. r=emalysz,flod,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D109404
2021-03-24 07:20:46 +00:00
Scott 1e202523c4 Bug 1693376 - Move save to Pocket to the toolbar. r=Gijs,fluent-reviewers,gvn,flod
Differential Revision: https://phabricator.services.mozilla.com/D107744
2021-03-23 20:06:03 +00:00
Mike Hommey 8e4cf752da Bug 1699613 - Allow the build resources usage report to display arbitrary resource usage json files. r=firefox-build-system-reviewers,sheehan,mhentges
AFAIK, while mochitests have resource-usage.json data with the same
format as build_resources.json, there isn't much of anything to display
that data in a human-friendly manner. As a helper of sort for all the
tasks that already expose their json data without a nice way to display
it, allow the build resources usage report UI that `mach resource-usage`
displays (or build_resources.html on build tasks on treeherder), to load
arbitrary json files if their url is dropped on the page (from e.g.
drag-and-dropping the link to the file from treeherder).

Differential Revision: https://phabricator.services.mozilla.com/D109030
2021-03-22 21:46:53 +00:00
june wilde e1938af8e9 Bug 1699453 - Check if exclude is populated from moz.yaml before accessing it; r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D108956
2021-03-22 20:06:01 +00:00
Tom Ritter b33f2f2170 Bug 1699808: Fix test exception to use quotes r=jewilde
Differential Revision: https://phabricator.services.mozilla.com/D109345
2021-03-22 14:42:10 +00:00
Andrew Creskey b70829a366 Bug 1695252 - Add a pageload test that reports PerfStats r=sparky,perftest-reviewers
This commit adds a simple pageload test, a warm pageload of https://www.google.com.
Low-level perfstats are collected.

All platforms were included. Not running as a cron job.

The motivation is that we can now collect low-level perfStats timings and determine how useful they will be for performance work.

Differential Revision: https://phabricator.services.mozilla.com/D109072
2021-03-22 13:50:32 +00:00
Francesco Lodolo (:flod) dd2b688041 Bug 1700036 - Remove Fluent migration recipes for Firefox 83-87, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D109267
2021-03-22 13:23:12 +00:00
Tom Ritter d68a653330 Bug 1691975: Take into account that the vendoring directory may be different from the moz.yaml directory r=andi
Differential Revision: https://phabricator.services.mozilla.com/D104791
2021-03-19 19:23:06 +00:00
Tom Ritter c781fce5dd Bug 1691975: Wire up removing files from moz.build files r=andi
Differential Revision: https://phabricator.services.mozilla.com/D104758
2021-03-19 19:23:06 +00:00
Tom Ritter 51f7eb3ae9 Bug 1691975: Add logic to remove a file from a moz.build file r=andi
Differential Revision: https://phabricator.services.mozilla.com/D104757
2021-03-19 19:23:05 +00:00
Tom Ritter c459ca2966 Bug 1691975: Integrate the new code into ./mach vendor r=firefox-build-system-reviewers,mhentges
This does not address files that should be removed from the moz.build file

Differential Revision: https://phabricator.services.mozilla.com/D104756
2021-03-19 19:23:05 +00:00
Tom Ritter 015084cc33 Bug 1691975: Extend the algorithm to actually rewrite the moz.build file r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104755
2021-03-19 19:23:04 +00:00
Tom Ritter b4a8c15931 Bug 1691975: Logic for editing moz.build files r=firefox-build-system-reviewers,mhentges
This commit adds the core algorithm for editing moz.build files, tests for a few
pieces of it, and the code to manually run the algorithm over the gecko codebase
and see dynamically how well it performs at trying to assigning existing source
files back into their original locations.

Differential Revision: https://phabricator.services.mozilla.com/D104754
2021-03-19 19:23:04 +00:00
Tom Ritter 09a3343784 Bug 1695311: If Updatebot tasks are present, enforce certain values in the moz.yaml schema r=jewilde
Differential Revision: https://phabricator.services.mozilla.com/D106659
2021-03-19 19:02:34 +00:00
Molly Howell ce9daf2f2a Bug 1695792 - Update copy for accounts error notifications. r=mconley,fluent-reviewers
Also take the opportunity to convert these two strings to Fluent,
since we're changing the text here anyway.

Differential Revision: https://phabricator.services.mozilla.com/D108530
2021-03-18 21:45:09 +00:00
Andrew Creskey e439b1e266 Bug 1698620 - Update perftest browsertime r=sparky,perftest-reviewers
Update to the latest browsertime so we can collect PerfStats

Differential Revision: https://phabricator.services.mozilla.com/D108499
2021-03-18 13:26:34 +00:00
Emma Malysz 07e9a5b088 Bug 1691140, add Task Manager to browser tools menu for proton r=mconley,fluent-reviewers,flod
Revert changes that added Task Manager to help menu.
With proton disabled, it should remain in the "More" section

Differential Revision: https://phabricator.services.mozilla.com/D108055
2021-03-17 15:44:17 +00:00
Connor Sheehan 17a15ff0aa Bug 1697956: install `m4` as a common package on Debian/Ubuntu r=firefox-build-system-reviewers,mhentges DONTBUILD
During `mach bootstrap` for Firefox desktop, m4 is installed via `libgtk2.0-dev`.
Since we don't install that package for Android bootstrap, this causes
configure failures.

Install `m4` as a common package to fix configure on Android. Since we plan
to remove `libgtk2.0-dev` soon, this will also avoid breakage when that change
lands.

Differential Revision: https://phabricator.services.mozilla.com/D108692
2021-03-17 14:19:35 +00:00
Alex Lopez 9de1a47962 Bug 1696251 - Move metrics_path parameter from @CommandProvider to @Command/@SubCommand . r=mhentges
As a step to remove the need to use @CommandProvider, we are moving
the metrics_path parameter to @Command.

Differential Revision: https://phabricator.services.mozilla.com/D108092
2021-03-17 14:14:14 +00:00
Mike Hommey 0ea5ad6742 Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges
The build always uses them anyways, but configure tests don't, and some
of them fail as a consequence in some cases (example: when UBsan is
enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had
similar problems in the past, such as bug 1513605.

By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure
tests use the flags as well.

While here, we also remove DSO_CFLAGS, which was always empty, and we
stop passing -fPIC to wasm compiles, because it has no effect there.

Differential Revision: https://phabricator.services.mozilla.com/D108560
2021-03-17 02:27:22 +00:00
Mike Hommey f74f871db7 Bug 1697950 - Partial support for mach bootstrap on arm64 mac. r=firefox-build-system-reviewers,sheehan,mhentges
This is enough to make the instructions on the Google doc unnecessary.

Differential Revision: https://phabricator.services.mozilla.com/D108132
2021-03-17 02:11:51 +00:00
Csoregi Natalia 1fe0f680de Backed out changeset 86089c4629b5 (bug 1698706) for spidermonkey bustage. CLOSED TREE 2021-03-17 03:48:31 +02:00
Mike Hommey 473d31abfb Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges
The build always uses them anyways, but configure tests don't, and some
of them fail as a consequence in some cases (example: when UBsan is
enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had
similar problems in the past, such as bug 1513605.

By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure
tests use the flags as well.

While here, we also remove DSO_CFLAGS, which was always empty, and we
stop passing -fPIC to wasm compiles, because it has no effect there.

Differential Revision: https://phabricator.services.mozilla.com/D108560
2021-03-17 01:27:39 +00:00
Mitchell Hentges c7550c57b3 Bug 1698889: Consistently alias paths in Sentry reports r=sheehan
When Sentry slurps context, it doesn't normalize os path separators for
us. So, we adapt our path aliasing to always catch both forward slashes
and backslashes.

Removed the `needle is None` guard because it because obsolete after
1695366, which removed the case where `topsrcdir` was `None`.

Differential Revision: https://phabricator.services.mozilla.com/D108667
2021-03-16 20:30:30 +00:00
Mitchell Hentges 4672929606 Bug 1695366: Only submit Sentry events when Mach is unmodified r=sheehan
If the "mach" file and all "*.py" files are unchanged, then the reported
exception is likely legitimate and can be reproduced on the public tree.

Differential Revision: https://phabricator.services.mozilla.com/D108262
2021-03-12 22:29:28 +00:00
Emma Malysz 6e4c1b1588 Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-12 21:41:46 +00:00
Mike Hommey a34d14071f Bug 1697960 - Don't prompt for telemetry when glean couldn't be installed. r=firefox-build-system-reviewers,mhentges,sheehan
Bootstrap runs mach create-mach-environment, which may or may not
successfully install glean. When it doesn't, it's not useful to ask
whether to enable telemetry when it's not going to work.

Differential Revision: https://phabricator.services.mozilla.com/D108131
2021-03-12 21:14:40 +00:00
Mitchell Hentges 9501e0ca97 Bug 1507272: Removes unused parameter in bootstrap function r=firefox-build-system-reviewers,glandium
Differential Revision: https://phabricator.services.mozilla.com/D106813
2021-03-12 16:07:12 +00:00
Mitchell Hentges b7e0dfe1d1 Bug 1695272: Move `--no-interactive` to global mach args r=firefox-build-system-reviewers,glandium
Updates `./mach bootstrap` to use `--no-interactive` from global args.
Ensures all bootstrap prompts have a default option.

Differential Revision: https://phabricator.services.mozilla.com/D106814
2021-03-12 16:07:11 +00:00
Mitchell Hentges 8133abcb41 Bug 1695973: Remove retry limit from bootstrap prompt r=firefox-build-system-reviewers,sheehan,glandium
The retry limit doesn't add much value - if user doesn't want
to answer a prompt, they can CTRL-C.

Additionally, `prompt_yesno` doesn't have a retry limit, so
this increases prompt behaviour consistency.

Differential Revision: https://phabricator.services.mozilla.com/D107122
2021-03-12 16:07:11 +00:00
Mitchell Hentges 526231ce1e Bug 1694981: Add missing items to mach telemetry doc r=firefox-build-system-reviewers,glandium,andi
`mach doc mach-telemetry` wasn't run the last time the telemetry
changed. By running it now, the docs are now up-to-date.

Differential Revision: https://phabricator.services.mozilla.com/D106544
2021-03-12 16:07:11 +00:00
Alex Lopez e5e9c8e9a5 Bug 1697042 - Remove "DeprecatedCommands" logic. r=mhentges,sheehan
Since there's no DeprecatedCommands class defined in-tree,
we can remove logic that checks that a class has that name.

Differential Revision: https://phabricator.services.mozilla.com/D107836
2021-03-11 21:42:28 +00:00
Alex Lopez 2f20882d97 Bug 1696251 - Add tests to mach command decorators. r=mhentges
In preparation for future changes in how these decorators work,
add a few basic tests.

Differential Revision: https://phabricator.services.mozilla.com/D107377
2021-03-11 21:42:27 +00:00
Mike Hommey b09eaee3e9 Bug 1379426 - Simplify Xcode/command line tools setup on macOS. r=firefox-build-system-reviewers,mhentges
Xcode hasn't been necessary to build Firefox for a while. Command line
tools are enough, but if Xcode is available, that's also sufficient.

Mach bootstrap, however, for historic reasons, mostly, ends up wanting
to install both, which is a waste of time and disk space.

Differential Revision: https://phabricator.services.mozilla.com/D107770
2021-03-10 22:33:21 +00:00
Mitchell Hentges d81ec85207 Bug 1695994: Removes some mach unused parameters and dead code r=sheehan,firefox-build-system-reviewers,glandium
* `_format_metadata()` had unused parameters
* `debugger_args` weren't used after being `shellutil.split(...)`
* There was dead python2-specific-code after a `return` statement

Differential Revision: https://phabricator.services.mozilla.com/D106970
2021-03-10 15:08:34 +00:00
Kagami Sascha Rosylight eeade44d84 Bug 1694675 - Add _tests/modules to symlink denylist r=firefox-build-system-reviewers,glandium
Differential Revision: https://phabricator.services.mozilla.com/D106288
2021-03-10 04:52:04 +00:00
Nisarg 3e0b107e69 Bug 1369784 - Improve the default behaviour of mozlint if no file paths or linters are specified r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D107394
2021-03-09 20:07:00 +00:00
nisarg 79603524c1 Bug 1646161 - Add command to run linters for the exclude list r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D105115
2021-03-09 20:07:00 +00:00
Andrew Halberstadt 155dabdde2 Bug 1697272 - [mozboot] Consider 'MACHRC' environment variable when enabling telemetry, r=firefox-build-system-reviewers,mhentges DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D107705
2021-03-09 20:04:57 +00:00
Andrew Halberstadt 572bdc8e0e Bug 1409733 - [mozversioncontrol] Add ability to update/checkout another revision, r=firefox-build-system-reviewers,mhentges
The specific use case here will be to help implement a new |mach taskgraph
--diff| command later on in this stack.

Differential Revision: https://phabricator.services.mozilla.com/D107270
2021-03-09 16:18:23 +00:00
Mike Hommey 88789bd14f Bug 1696091 - Add arm64 mac rustup. r=firefox-build-system-reviewers,sheehan,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D107028
2021-03-08 21:31:25 +00:00
Mike Hommey c3a31b9c58 Bug 1696091 - Upgrade rustup to 1.23.1. r=firefox-build-system-reviewers,sheehan,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D107027
2021-03-08 21:31:24 +00:00
Mike Hommey 9367a34337 Bug 1696091 - Convert python/mozboot/mozboot/rust.py's __main__ to python 3. r=firefox-build-system-reviewers,sheehan,mhentges
- Replace urllib2.urlopen with requests.get. We use requests because
  http_download_and_hash, which is also used by __main__ uses it already.
- Convert byte strings to unicode strings.
- Don't wrap sys.stdout, and instead explicitly flush when wanted.

Differential Revision: https://phabricator.services.mozilla.com/D107026
2021-03-08 21:31:24 +00:00
Connor Sheehan a977bf134b Bug 1696509: move to bash installer for Homebrew r=firefox-build-system-reviewers,mhentges
Download `installer.sh` from the same source and pass it to
 `bash` instead of `ruby`.

Differential Revision: https://phabricator.services.mozilla.com/D107279
2021-03-08 17:41:15 +00:00
Connor Sheehan c5d34d14ef Bug 1688263: remove macports as a package manager in bootstrap r=firefox-build-system-reviewers,mhentges
Removes MacPorts as an option for package management on OSX. Changes
most error messages to be Homebrew specific, and rips out the `getattr`
based function resolution used to support both managers.

Differential Revision: https://phabricator.services.mozilla.com/D107277
2021-03-08 17:41:14 +00:00
Emilio Cobos Álvarez 57fdd2a011 Bug 1696437 - Enable non-native theme on Android Nightly. r=mstange
Last platform that remains! Will send fixes for the couple failures in a sec.

Differential Revision: https://phabricator.services.mozilla.com/D107231
2021-03-04 20:35:24 +00:00
Mike Conley 06e88e30db Bug 1695707 - Update copy for DRM panel buttons and migrate to Fluent. r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D106819
2021-03-03 23:12:13 +00:00
Emilio Cobos Álvarez 7164cffed3 Bug 1687022 - Whoops, update mozinfo so it picks nnt wpt annotations.
Quite embarrassing I missed this.

MANUAL PUSH: Unexpected passes on a CLOSED TREE
2021-03-03 15:50:47 +01:00
James Graham 7814585840 Bug 1695263 - Vendor in a copy of wptserve that's still Python 2 compatible, r=marionette-reviewers,whimboo
Upstream wptserve just switched to Python 3 only. That's fine for
web-platform-tests, but it turns out that some marionette harness
tests are also using wptserve and are still on Python 2.

Since fixing marionette harness turns out to be non-trivial and this
blocks other wpt work, this patch does the following:

* Temporarily vendors the last wptserve revision that works with
  Python 2 in to testing/web-platform/mozilla/tests/tools/wptserve_py2

* Configures the mach virtualenv to use that copy for Python 2 modules
  only.

* Configures the test packaging system to also put that copy in the
  common tests zip. Requirements files are updated to use either the
  Python 2 version or the Pyhton 3 version as required.

Differential Revision: https://phabricator.services.mozilla.com/D106764
2021-03-03 10:03:05 +00:00
Csoregi Natalia f8043879e3 Backed out changeset 44ff4cb38ce1 (bug 1694678) for failures on browser_sync.js. CLOSED TREE 2021-03-03 09:56:35 +02:00
Emma Malysz bfd4f5a6d1 Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-03 06:52:10 +00:00
Agi Sferro c6942877da Bug 1695051 - Add /security to .lldbinit. r=aklotz
This is required to debug code in libnss3.

Differential Revision: https://phabricator.services.mozilla.com/D106541
2021-03-02 20:39:12 +00:00
Mihai Alexandru Michis 1c9566c96e Backed out changeset 7692908f97e7 (bug 1694678) for causing bc failures in browser_sync.js
CLOSED TREE
2021-03-02 19:56:17 +02:00
Emma Malysz 4d02027b4d Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-02 16:02:35 +00:00
Alex Lopez 201a891006 Bug 1694646 - Remove old build telemetry. r=mhentges
Now that telemetry is gathered with glean, we can remove the old telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D106735
2021-03-02 15:04:27 +00:00
Mike Hommey 39a14165d0 Bug 1694318 - Remove the mozjs_sys rust crate. r=jandem
The mozjs_sys crate is actually responsible for all the problems
encountered with the js crate we just removed, but the sm-mozjs-crate
task that builds and runs tests for it doesn't fail because... there is
actually no test to build and run, so all it builds is a static library,
which doesn't expose all the problems that exist.

The content of this crate in mozilla-central is also outdated compared
to servo upstream.

Differential Revision: https://phabricator.services.mozilla.com/D106390
2021-03-02 08:09:35 +00:00
Mike Hommey 93e7a214c2 Bug 1694318 - Remove the js rust crate. r=jandem,sheehan
The sm-rust-bindings task that builds and runs tests for it actually only
doesn't fail by three(!) distinct happenstances of chance:
- It somehow doesn't hit a race condition that can happen, but that
  attempting to change the build process for jsglue.cpp did,
- The second call to `cargo test` without `--feature debugmozjs` only
  works because nothing was cleaned up from the first and the second
  build uses artifacts from the first that are otherwise not there if
  only running the second.
- The addition of rust code to spidermonkey (the jsrust crate in
  js/src/rust) somehow didsn't cause problems in the current
  configuration, but in other configurations (which fixing the second
  thing above unveils) the build fails because of the multiple
  definition of rust_eh_personality between the jsrust staticlib and the
  rust stdlib that rustc links to test programs.

On top of all the above, the content of the crate in mozilla-central
has not received updates from upstream servo in years, and doesn't
reflect what servo actually uses.

Differential Revision: https://phabricator.services.mozilla.com/D106389
2021-03-02 08:09:35 +00:00
Agi Sferro d7c56b38e4 Bug 1688062 - Update target SDK to API 30. r=esawin,jnicol
Differential Revision: https://phabricator.services.mozilla.com/D106556
2021-03-01 19:12:16 +00:00
Aaron Klotz aa458e10e9 Bug 1695714: Clear Android's debug app setting when cleaning up after a mach run --debug session for GeckoView; r=firefox-build-system-reviewers,andi,mhentges
We always set the app as Android's debug app, which causes Android to wait for
a debugger to connect to the app before allowing it to start. We should clear
that setting once the debugger exits so that other developer activities (such as
manual testing) aren't blocked on the need to connect a debugger.

Differential Revision: https://phabricator.services.mozilla.com/D106807
2021-03-01 17:55:32 +00:00
Dave Hunt 0795acbc2a Bug 1672422 - Default to mozperftest as the framework instead of browsertime r=perftest-reviewers,sparky
Differential Revision: https://phabricator.services.mozilla.com/D104731
2021-03-01 15:32:10 +00:00
Noemi Erli 67edd199af Backed out changeset 0ca845833464 (bug 1688062) for causinf Android Webrender bustages CLOSED TREE 2021-02-27 14:15:09 +02:00
Butkovits Atila 8ed8707b3d Backed out changeset 962540b712f9 (bug 1694678) for causing failure at browser_sync.js. CLOSED TREE 2021-02-27 05:05:08 +02:00
Emma Malysz cc6a25c9cc Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-02-27 01:16:40 +00:00
Agi Sferro b69e57d56f Bug 1688062 - Update target SDK to API 30. r=esawin
Differential Revision: https://phabricator.services.mozilla.com/D106556
2021-02-26 21:45:15 +00:00
Dorel Luca 0875c78fec Backed out changeset 0e3e3b8a55b4 (bug 1688062) for Linting failure in java/org/mozilla/gecko/GeckoAppShell.java. CLOSED TREE 2021-02-26 19:02:12 +02:00
Agi Sferro c0dc6e84b0 Bug 1688062 - Update target SDK to API 30. r=esawin
Differential Revision: https://phabricator.services.mozilla.com/D106556
2021-02-26 16:34:02 +00:00
Alex Lopez ad68ed0ba9 Bug 1682959 - Remove legacy_resolver support from mach. r=mhentges
Now that all the conflicts in python dependencies that made the
new pip resolver fail have been resolved, we no longer need to support
the legacy resolver that was added as a temporary measure.

Depends on D106154

Differential Revision: https://phabricator.services.mozilla.com/D106503
2021-02-25 18:37:00 +00:00
Ian Neal 22e0c0b5b8 Bug 1692706 - Update ccache stats parser for ccache 4.x. r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D105863
2021-02-25 07:00:39 +00:00
Mike Conley 3da2d710da Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105081
2021-02-24 02:52:30 +00:00
Dorel Luca df1d85fc90 Backed out 2 changesets (bug 1688960, bug 1693177) for Browser-chrome failures in browser/base/content/test/sync/browser_sync.js. CLOSED TREE
Backed out changeset 13e08408add0 (bug 1693177)
Backed out changeset a34474998cd6 (bug 1688960)
2021-02-24 03:36:21 +02:00
Mike Conley 7404b84286 Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105081
2021-02-23 23:16:12 +00:00
Tom Ritter 9535519563 Bug 1692575: Refactor the updatebot part of the moz.yaml schema to support multiple task types r=jewilde
Differential Revision: https://phabricator.services.mozilla.com/D105096
2021-02-23 16:34:31 +00:00
Andi-Bogdan Postelnicu fc5eb87bb7 Bug 1648941 - fix for Coverity Static Analysis crash in layout. r=marco
Differential Revision: https://phabricator.services.mozilla.com/D106076
2021-02-23 11:44:53 +00:00
Mike Hommey e5c73b99a0 Bug 1692940 - Don't bootstrap yasm. r=firefox-build-system-reviewers,dmajor
Differential Revision: https://phabricator.services.mozilla.com/D105599
2021-02-23 01:26:47 +00:00
Mike Hommey fbbe02d958 Bug 1692940 - Remove build system support for yasm. r=firefox-build-system-reviewers,dmajor
Differential Revision: https://phabricator.services.mozilla.com/D105432
2021-02-23 01:26:46 +00:00
Mike Hommey 3485076564 Bug 1692940 - Turn the USE_YASM unit test into a USE_NAME one. r=firefox-build-system-reviewers,dmajor
Differential Revision: https://phabricator.services.mozilla.com/D105431
2021-02-23 01:26:46 +00:00
Mike Hommey ac09a33318 Bug 1692940 - Remove test case for yasm version validation. r=firefox-build-system-reviewers,dmajor
We're going to remove arguments to the function, and eventually remove
it.

Differential Revision: https://phabricator.services.mozilla.com/D105426
2021-02-23 01:26:44 +00:00
Mike Conley d4da30ccf4 Bug 1690573 - Migrate the report-site-issue UI access point to the Help menu. r=denschub,mixedpuppy,fluent-reviewers,webcompat-reviewers,flod
We're not 100% certain if Help is the right spot for this, but we're going
to give it a shot and see. If it turns out it _is_ the right spot, we'll
probably do something a little more self-contained, and less hacky.

I'm leaving the old .properties file just in case we change our mind here.
Yes, we'll want to port to Fluent anyways, but our ultimate choice of where
we put this thing is probably going to dictate where the string lives.

Differential Revision: https://phabricator.services.mozilla.com/D104832
2021-02-23 00:11:05 +00:00
Mike Hommey caa72b33bd Bug 1693215 - Don't check for yasm for libav. r=firefox-build-system-reviewers,dmajor
Bug 1476231 actually removed libav, so we don't build it, and don't need
neither the yasm check nor the LIBAV_FFT_ASFLAGS variable.
However, we still have checks, both in moz.build and code, for
MOZ_LIBAV_FFT, so we need to keep that.

Differential Revision: https://phabricator.services.mozilla.com/D105399
2021-02-22 22:11:26 +00:00
Stephen A Pohl 3ebbac5e0c Bug 1690842: Disable the native theme in content on macOS. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D105889
2021-02-22 13:45:56 +00:00
Aaron Klotz 31c74eb891 Bug 1581971: Part 6 - Support mach run --debug with lldb for Android; r=mhentges
* We add new options to the Android variant of `mach run`:
  * `--debug`: enables running with a debugger;
  * `--debugger`: Allows the user to override the default debugger (`lldb`).
                  The provided argument must still be `lldb` compatible; this
                  is for enabling the ability to specify some kind of wrapper
                  script or other debugger front-end, if desired;
  * `--debugger-args`: Additional arguments to pass to the debugger's command line;
  * `--no-attach`: Runs the app and prepares the device for debugging, but does
                   not actually attach any debuggers. The required ports are
                   printed to the log, and then `mach` exits, thus allowing for
                   the user to manually connect.
  * `--use-existing-process`: This allows the user to attach to an existing
                              process, instead of killing existing process(es)
                              and starting from scratch. This is useful for
                              users who want to attach to an existing process
                              that is already in a desired state.

When debugging is enabled:

BEFORE the app starts:
* `verify_android_device` will install `lldb-server` if necessary;
* We run `am set-debug-app -w --persistent` to ensure that the app is set as the
  device's debug app. Since we pass `-w`, when Android starts the target app, it
  will wait for `jdb` to attach before proceeding.

AFTER the app starts:
* We start `lldb-server` and obtain the name of its socket file;
* We obtain the pid of the parent process. Alternatively, if
  `--use-existing-process` was specified and there are already extant child
  processes, we prompt the user to choose which process to which they would
  initially like to attach.
* We forward a local TCP port for `jdb` debugging.
* We run `jdb` in the background to connect to the process and then quit.
  This is solely for the purpose of dismissing Android's "waiting for debugger"
  dialog.
* In the foreground, we run `lldb`, specifying a set of initial commands that
  are required to for symbol resolution and to automatically connect to the
  target pid.


Why `lldb`? I chose it for consistency with Android Studio. Somebody else is
welcome to implement `gdb` support if they wish. :-)

Differential Revision: https://phabricator.services.mozilla.com/D94384
2021-02-19 21:07:20 +00:00
Aaron Klotz 7847613f0d Bug 1581971: Part 1 - Bump Android NDK requirement to 21d; r=snorp,firefox-build-system-reviewers,mhentges
NDK 21 includes `lldb-server`, which we need in order to support
`./mach run --debug` with `lldb`.

The Android SDK manager no longer includes a standalone `lldb` package; perhaps
it was deprecated? Anyway, this appears to currently be the best way to get
`lldb-server` into a location that is easy to find during build configuration.

Differential Revision: https://phabricator.services.mozilla.com/D94379
2021-02-19 21:07:18 +00:00
Mike Hommey 2bfb5b72cb Bug 1692943 - Wrap subprocess.run in the configure sandbox. r=firefox-build-system-reviewers,andi,mhentges
The subprocess.* wrapping in configure alters the environment sent
to the subprocess in two ways:
- variable keys and values are normalized to unicode to make python
  happy.
- when no explicit environment is passed, default to the sandbox
  environment.

The sandbox environment has one major difference with the original
environment, which is that PYTHONEXECUTABLE is unset, and that's known
to cause problems on mac, which it does when configure executes
`mach artifact toolchain` for --enable-bootstrap.

Differential Revision: https://phabricator.services.mozilla.com/D105265
2021-02-18 22:50:35 +00:00
Mike Hommey fa35a4b8c7 Bug 1692939 - Turn namespace() into a builtin in python configure. r=firefox-build-system-reviewers,mhentges
This removes the need for some --help dependencies.

Differential Revision: https://phabricator.services.mozilla.com/D105263
2021-02-18 22:44:40 +00:00
Mike Hommey 5e19605601 Bug 1692939 - Add sorted() as an allowed builtin in python configure. r=firefox-build-system-reviewers,mhentges
It has no side effects and is safe to use in the configure sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D105262
2021-02-18 22:44:39 +00:00
Mike Hommey 454656b5cc Bug 1692939 - Detect when builtins are imported that don't need to be. r=firefox-build-system-reviewers,andi,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D105261
2021-02-18 22:44:39 +00:00
Mike Hommey 8e2ec28550 Bug 1692611 - Add a handler to the logger added in bug 1692103. r=firefox-build-system-reviewers,mhentges
Indidentally, this fixes the failure code path, because the change in
bug 1692103 was such that the logger output was not captured in `out`.

Differential Revision: https://phabricator.services.mozilla.com/D105390
2021-02-18 22:39:10 +00:00
Itiel 05d88b715b Bug 1692301 - Add dark mode support for about:buildconfig r=mconley,glandium
Also make it so it'd match the style of other about: pages.

Differential Revision: https://phabricator.services.mozilla.com/D104877
2021-02-18 22:05:09 +00:00
Mike Hommey 3713567f10 Bug 1692941 - Use zip and unzip paths per configure in make_{zip,unzip}. r=firefox-build-system-reviewers,andi,dmajor
Differential Revision: https://phabricator.services.mozilla.com/D105264
2021-02-17 21:30:28 +00:00
Sylvestre Ledru 522855d598 no bug - fix(fluent) - Remove Windows CR r=zbraniecki DONTBUILD
Done with
./mach lint -l file-whitespace -n --fix python/l10n/convert_xul_to_fluent/lib/migration.py

Differential Revision: https://phabricator.services.mozilla.com/D105298
2021-02-17 20:50:25 +00:00
Mike Hommey b6d915dd07 Bug 1692383 - Upgrade python-zstandard to 0.15.1. r=firefox-build-system-reviewers,mhentges
As far as I can tell, we don't use zstandard from python2. As the last
version supporting python2 is 0.14.1, drop installing the python2
version.

Differential Revision: https://phabricator.services.mozilla.com/D105075
2021-02-17 00:53:38 +00:00
Tarek Ziadé 31380bc0c1 Bug 1681669 - Add vision document for mozperftest. r=davehunt
Differential Revision: https://phabricator.services.mozilla.com/D99318
2021-02-16 18:37:23 +00:00
Sean Feng 2502c7c5dd Bug 1688995 - Fall back to default PATH if fzf doesn't exist in mozbuild r=sparky
Differential Revision: https://phabricator.services.mozilla.com/D103115
2021-02-16 18:11:38 +00:00
Mitchell Hentges a3eb85e571 Bug 1687980: Make macOS quickstart docs more concise r=sylvestre,mhoye
* Puts the docs in order, so that contributors aren't jumping to the
  middle of the page to install system tools, then back to the top to
  clone Firefox.
* Removes docs on MacPorts since it's being removed in bug 1688263.
* Removes step to manually install brew packages since that happens
   automatically in bootstrap now.
* Simplifies mercurial installation docs
* Removes unnecessary mozconfig-tweaking instructions
* Removes almost-always-unnecessary DEFINE and troubleshooting
  information.

Differential Revision: https://phabricator.services.mozilla.com/D102973
2021-02-16 17:48:11 +00:00
Mike Hommey 6f9a7abe9b Bug 1692416 - Allow toolchain-alias to be a list. r=taskgraph-reviewers,firefox-build-system-reviewers,jmaher,mhentges
Original patch by Rob Lemley [:rjl], with a small simplification, and an
additional change to make `mach artifact toolchain` happy.

Original discussion in https://phabricator.services.mozilla.com/D66837

Differential Revision: https://phabricator.services.mozilla.com/D104976
2021-02-12 22:28:01 +00:00
Kagami Sascha Rosylight 30ec71696c Bug 1692300 - Disable symlinking in dist/bin r=firefox-build-system-reviewers,andi,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104873
2021-02-12 21:50:15 +00:00
Mike Hommey ecfbd1076c Bug 1692390 - Skip the creation of a python2 virtualenv on arm64 mac. r=firefox-build-system-reviewers,andi,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104950
2021-02-12 21:31:10 +00:00
Tom Ritter 2f17e8f817 Bug 1689454 - Reenable moz_yaml python tests; r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D103374
2021-02-12 21:04:07 +00:00
Mike Hommey 5f86b697af Bug 1692137 - Allow local linux builds to use a bootstrapped sysroot. r=firefox-build-system-reviewers,andi,mhentges
Bug 1690930 added sysroots that can be bootstrapped. With this change,
we allow --enable-bootstrap=install to pull the right sysroot for the
configured target, and --enable-bootstrap to update it if it was already
there.

Differential Revision: https://phabricator.services.mozilla.com/D104797
2021-02-12 20:31:49 +00:00
Mike Hommey 2f408c9631 Bug 1692137 - Properly handle env=None passed to subprocess functions in configure. r=firefox-build-system-reviewers,andi,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D104796
2021-02-12 20:31:49 +00:00
Mike Hommey 35f65167bd Bug 1692103 - When getting mozconfig info for MozbuildObject, log separately. r=firefox-build-system-reviewers,mhentges
The code in MozbuildObject.get_mozconfig_and_target relies on the
configure sandbox to find mozconfig (and target). With
--enable-bootstrap, configure itself ends up calling into taskgraph code
that, eventually ends in in MozbuildObject.get_mozconfig_and_target,
which, because it currently logs to the same place, has at least the
following two effects:
- MOZ_CONFIGURE_TRACE logging breaks. I'm not sure exactly why, but the
log level is lost.
- the output from the configure code that runs for
MozbuildObject.get_mozconfig_and_target ends up mixed with the output
from configure itself, and it appears to the user as if things happened
twice (which it did, actually, but that's not something that should be
shown to the user).

So, we redirect to a separate logger.

Differential Revision: https://phabricator.services.mozilla.com/D104776
2021-02-11 03:37:15 +00:00
Sebastian Hengst 95efea0752 Bug 1691508 - label messages about missing mappings of files to Bugzilla tasks as error. r=jmaher
This lets Treeherder pick up the line as failure line and show it to Try users
and code sheriffs.
Rule used: "^[A-Za-z.]+Error: "

It also adds an instruction how to fix the reported issue.

Differential Revision: https://phabricator.services.mozilla.com/D104452
2021-02-08 21:38:47 +00:00
Akshat Dixit ad11827401 Bug 1591991 Add lint Fixed count support to linters r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D102082
2021-02-08 19:00:10 +00:00
Emilio Cobos Álvarez 34a6457e63 Bug 1690898 - Add a mozinfo entry for nnt, and update WPT test expectations. r=jgraham
Other platforms are going to need more annotations, so this allows us to
update one line while rolling out the feature, rather than updating a
bunch of test expectations. Also should be clearer.

Let me know if there are better ways to do this.

Differential Revision: https://phabricator.services.mozilla.com/D104102
2021-02-05 14:27:47 +00:00
Bogdan Tara b3d9616178 Backed out changeset e21ae6fdc524 (bug 1690898) for Event-dispatch-redispatch.html failures CLOSED TREE 2021-02-05 16:12:09 +02:00
Emilio Cobos Álvarez 874b18c2d3 Bug 1690898 - Add a mozinfo entry for nnt, and update WPT test expectations. r=jgraham
Other platforms are going to need more annotations, so this allows us to
update one line while rolling out the feature, rather than updating a
bunch of test expectations. Also should be clearer.

Let me know if there are better ways to do this.

Differential Revision: https://phabricator.services.mozilla.com/D104102
2021-02-05 08:59:34 +00:00
Akshat Dixit 43b65bee68 Bug 1646433 ./mach lint -l foobar handles the error correctly r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D102806
2021-02-04 22:04:11 +00:00
Emma Malysz d2e6a106ee Bug 1690359 - Move task manager to help menu r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D103843
2021-02-03 16:46:57 +00:00
Emma Malysz e7e6abb53d Bug 1689366, simplify bookmark panel r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D103402
2021-02-02 18:56:19 +00:00
Mike Hommey 4030da2448 Bug 1689494 - Don't include gmp-clearkey in test archives. r=releng-reviewers,jmaher
It's already part of Firefox, and makes the gtest initialization print
an error message because the one already in Firefox can't be
overwritten.

Differential Revision: https://phabricator.services.mozilla.com/D103475
2021-01-29 13:31:07 +00:00
june wilde 44072640b0 Bug 1689449 - Add libpng to mach vendor's valid licenses; r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D103372
2021-01-28 21:09:43 +00:00
Mike Hommey 5d9084e8a0 Bug 1689058 - Rename clang-cl toolchains to clang. r=firefox-build-system-reviewers,dmajor
Bug 1553230 made configure automatically get toolchain artifacts in some
cases. The artifacts for clang-cl builds are clang.tar.zst, and extract to
clang/. Configure derives the task name from that knowledge, and fails
to find clang-cl tasks because of that.

For consistency, these tasks should be called clang. They are clang
builds anyways, and like any other clang builds, they also contain
clang-cl.

Differential Revision: https://phabricator.services.mozilla.com/D103150
2021-01-28 00:30:56 +00:00
Kershaw Chang 0d82c1d0d8 Bug 1684041 - Add ODoH test r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D102629
2021-01-27 22:04:25 +00:00
Dan Minor fd50ec0311 Bug 1510797 - Migrate about:webrtc to Fluent; r=ng,flod
Differential Revision: https://phabricator.services.mozilla.com/D102931
2021-01-27 12:11:47 +00:00
Nick Alexander dc4f42262e Bug 1675848 - Part 1: Add "backgroundtask" filter to chrome manifest parsing. r=mossop,kmag
This allows to filter chrome manifest registration by the current
background task(s, in the future).  Filtration behaves just like
filtering by "application":

* filter with `backgroundtask=` means disable for all background
  tasks, since no background task will match ""

* filter with `backgroundtask!=` means enable for all background task,
  since every background task will not match ""

Differential Revision: https://phabricator.services.mozilla.com/D96482
2021-01-25 23:44:46 +00:00
Erica Wright d5c15eaf57 Bug 1686331 - Library menu should not have a scroll bar. r=prathiksha,flod
Differential Revision: https://phabricator.services.mozilla.com/D102471
2021-01-21 06:20:55 +00:00
Mike Hommey 49a9eeaf91 Bug 1687594 - Don't take path@task-id arguments on `mach artifact toolchain`. r=firefox-build-system-reviewers,mhentges
This form hasn't been used since bug 1573435.

Differential Revision: https://phabricator.services.mozilla.com/D102375
2021-01-20 15:04:49 +00:00
Mike Hommey 32ec3e64de Bug 1687594 - Remove the --authentication-file option to `mach artifact toolchain`. r=firefox-build-system-reviewers,mhentges
It has been a no-op since bug 1595368.

Differential Revision: https://phabricator.services.mozilla.com/D102374
2021-01-20 15:03:45 +00:00
Mike Conley c6ce5fa932 Bug 1683419 - Fork Help menu strings for use in the AppMenu. r=Gijs,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D100957
2021-01-20 18:12:33 +00:00
Dana Keeler b20d3edb85 Bug 1682989 - remove CertBlocklist implementation and MOZ_NEW_CERT_STORAGE build variable r=rmf
Differential Revision: https://phabricator.services.mozilla.com/D100034
2021-01-19 22:11:25 +00:00
Mike Conley 161d8c6503 Bug 1568133 - Migrate the rest of the menubar to Fluent. r=fluent-reviewers,flod,Gijs
Original patch by Brendan Dahl <bdahl@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D46203
2021-01-18 18:23:18 +00:00
Mike Hommey 66a79a59fe Bug 1553230 - Allow to opt-in to automatically update some bootstrapped toolchains. r=firefox-build-system-reviewers,nalexander,mhentges
This adds a --enable-bootstrap build flag that will automatically update
cbindgen, node, clang, sccache, nasm, wine, lucetc, dump_syms, pdbstr,
and winchecksec if they are already installed in ~/.mozbuild.

Eventually, we'll want to allow to install toolchains that weren't
already install, but one step at a time.

This explicitly doesn't cover rustc, which is its own can of worms, or
android-{ndk,sdk}, which are not installed via toolchain artifacts
currently.

Differential Revision: https://phabricator.services.mozilla.com/D101723
2021-01-15 22:15:51 +00:00
Mike Hommey e4bf32e4f8 Bug 1686888 - Stop building dump_syms. r=gsvelto
Now that we use an external dump_syms, we don't need to build
breakpad's.

This means we also don't need the dump_syms_rust_demangle crate anymore.

Differential Revision: https://phabricator.services.mozilla.com/D101865
2021-01-15 10:31:48 +00:00
june wilde 6c0883d216 Bug 1686629 - Remove extra / from mach vendor's github url construction; r=tjr
Differential Revision: https://phabricator.services.mozilla.com/D101696
2021-01-14 14:48:12 +00:00
Aaron Klotz 8892b9c2f6 Bug 1611554: Part 1 - Add capability for build system to generate files during pre-export tier when building GeckoView; r=nalexander,rstewart
These are the minimum changes that we need to make to common build system code
to allow us to generate files during pre-export.

We add a `required_before_export` flag to `GeneratedFile` to indicate when a
particular file must be generated in `pre-export`. We set that flag when there
are `.jinja` input files and we're configured for a GeckoView build, otherwise
it is set to `False`.

Then the recursive `make` backend assigns any `GeneratedFile`s that have
`required_before_export` set to run in the `pre-export` tier.

Differential Revision: https://phabricator.services.mozilla.com/D82576
2021-01-13 01:19:20 +00:00
Butkovits Atila bcdf48f6d6 Backed out 3 changesets (bug 1611554) for causing bustage on recurse.mk. CLOSED TREE
Backed out changeset bb1ce63d73ec (bug 1611554)
Backed out changeset 0d4317da1006 (bug 1611554)
Backed out changeset dc905e5db0cc (bug 1611554)
2021-01-13 03:16:17 +02:00
Aaron Klotz a0981d658b Bug 1611554: Part 1 - Add capability for build system to generate files during pre-export tier when building GeckoView; r=nalexander,rstewart
These are the minimum changes that we need to make to common build system code
to allow us to generate files during pre-export.

We add a `required_before_export` flag to `GeneratedFile` to indicate when a
particular file must be generated in `pre-export`. We set that flag when there
are `.jinja` input files and we're configured for a GeckoView build, otherwise
it is set to `False`.

Then the recursive `make` backend assigns any `GeneratedFile`s that have
`required_before_export` set to run in the `pre-export` tier.

Differential Revision: https://phabricator.services.mozilla.com/D82576
2021-01-13 00:24:03 +00:00
Nick Alexander e74edb8950 Bug 1686089 - Make `mach package-multi-locale` handle Desktop on macOS. r=zbraniecki
There's a macOS-specific wrinkle for browser/ that populates the
`.app` directory.  This makes that happen as part of `mach
package-multi-locale`.  It's the equivalent, I suppose, of `mach
android assemble-app` for Desktop.

Differential Revision: https://phabricator.services.mozilla.com/D101502
2021-01-12 23:12:40 +00:00
Connor Sheehan 57d304dec4 Bug 1686333: don't install `libpython2-dev` r=firefox-build-system-reviewers,mhentges
Seems it isn't always available. Since Py2 is optional anyways, it
shouldn't cause failures in `mach bootstrap`.

Differential Revision: https://phabricator.services.mozilla.com/D101499
2021-01-12 21:55:57 +00:00
Connor Sheehan 5f3ac9bc5b Bug 1684915: install Python development headers during bootstrap on Fedora/Debian flavors r=firefox-build-system-reviewers,mhentges
Since zstandard has native code that must be compiled, and that code
uses Python headers, we should be installing those headers as part
of bootstrap.

Most users will have these packages on their machines through various
other means (notably installing `pip`, ie `sudo apt install python3-pip`),
but since it is possible to avoid a pip installation (for example
by installing Mercurial through `yum` and then running bootstrap
immediately after cloning) we should specify these packages as required
by bootstrap.

Differential Revision: https://phabricator.services.mozilla.com/D101479
2021-01-12 20:35:24 +00:00
Dan Mosedale e91d8deeea Bug 1684936 - update NodeJS to 10.23.1 for latest sec fixes r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D100810
2021-01-07 17:06:42 +00:00
Connor Sheehan 44d4f310aa Bug 1685811: recommend saving `bootstrap.py` to disk instead of piping directly to `python` r=mhentges DONTBUILD
The current recommendation fails while waiting on user input. Instead, just
save the script to disk as an intermediate step, then invoke it.

Differential Revision: https://phabricator.services.mozilla.com/D101228
2021-01-11 16:53:32 +00:00
ankushduacodes fd084434a1 Bug 1684348 - Patching error occuring while running brew cask list as this method has been deprecated by homebrew r=mhentges
Differential Revision: https://phabricator.services.mozilla.com/D100496
2021-01-08 19:51:41 +00:00
Mitchell Hentges 633efc7476 Bug 1680630: Generate android mozconfig without pkg manager r=nalexander
Knowing whether `brew` or `macports` is available isn't necessary
to generate the android mozconfig.
This should fix the generation of android mozconfig when a package
manager isn't available.

Differential Revision: https://phabricator.services.mozilla.com/D99496
2021-01-05 20:30:56 +00:00
Mitchell Hentges f4a03e538f Bug 1680802: Install pylint requirements with legacy resolver r=firefox-build-system-reviewers,sheehan,glandium
pylint_requirements.txt fail to install with the new pip resolver due
to a conflict between astroid and lazy-object-proxy.
Rather than bumping those packages and handling the potential fallout,
the package-upgrade has been deferred and we will use the legacy
resolver in the interrim.

Differential Revision: https://phabricator.services.mozilla.com/D99940
2021-01-05 20:14:25 +00:00
Connor Sheehan 1266f6cfb7 Bug 1684584: move call to `_check_clobber` to `mach build` instead of running in `_run_client_mk` r=firefox-build-system-reviewers,mhentges
The `AUTOCLOBBER` mozconfig option is reliably causing builds to fail when
a clobber is triggered. When we auto-clobber a build we do so after running
`configure` but before running `make client.mk`. This means we destroy all
the gathered information from the `configure` step in the objdir and then
attempt to run `make` using the previously destroyed information.

This commit moves the call to `_check_clobber` to an earlier stage in the
build process, before `configure` is called, so any clobber that takes place
will happen before setting up the objdir via `configure`.

Since `_check_clobber` is only called once in the codebase, and both cases
are now adding clobber metrics one after another, we remove the metrics
gathering from `_check_clobber` and rely on callers to set metrics instead.

Also clean up some nested `if` statements that can be flattened.

Differential Revision: https://phabricator.services.mozilla.com/D100794
2021-01-06 17:19:34 +00:00
Connor Sheehan 3d9fb0766a Bug 1684584: add a comment describing what `_check_clobber` does r=firefox-build-system-reviewers,mhentges
This function has a few code paths and has a slightly confusing return value.
Add a comment describing what it does and what the return value actually
means.

Differential Revision: https://phabricator.services.mozilla.com/D100793
2021-01-06 17:07:51 +00:00
Connor Sheehan 0e3bf9f599 Bug 1684584: do not encode `topobjdir` before printing to screen during clobber r=firefox-build-system-reviewers,mhentges
Since the printed value is a `str` anyways, this causes the converted `bytes`
to be printed to the terminal as `b'/path/to/topobjdir'`. Just print the `str`
version to the screen instead.

Differential Revision: https://phabricator.services.mozilla.com/D100792
2021-01-06 01:53:13 +00:00
Mike Conley 1dcbb9ec4d Bug 1682022 - Fork strings from the context menu and browser.dtd for use in the AppMenu. r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D100832
2021-01-06 08:04:06 +00:00
Andi-Bogdan Postelnicu d7fb68e56d Bug 1683613 - For `non-unified` build have a task that runs checks when merging to mozilla-central r=mhentges
Differential Revision: https://phabricator.services.mozilla.com/D100796
2021-01-05 19:40:23 +00:00
Connor Sheehan 813445ccd8 Bug 1678668: print sentry error report number on mach command failure r=firefox-build-system-reviewers,mhentges
When mach errors out, an error report is sent to Sentry. This error
report contains information about the state of the interpreter during
the failure, details about the environment, installed packages and more.
Having this information available immediately when attempting to resolve
a bug report is generally desirable, instead of going through a back-and-forth
needinfo tag on Bugzilla or spending time asking the reporter questions on
Matrix.

This commit captures the Sentry ID returned from `sentry_sdk.capture_exception`
and prints it to the screen. If a user adds this line to their bug report (as
the error messages suggest) a build team member can enter this number into
Sentry to identify the exact report and debug the error. At minimum this will
reduce the amount of back-and-forth between the reporter and the assignee
required to resolve a bug. Optimally it should make bugs easier to spot and
reduce the time spent on end user support requests.

To use the Sentry ID to identify information about a specific bug report, the
bug assignee should open the Mozilla Sentry page for the `mach` project and
paste the ID into the search box, which will produce the full stack trace with
all submitted information.

Differential Revision: https://phabricator.services.mozilla.com/D100247
2021-01-05 16:39:22 +00:00
Sylvestre Ledru afb5a86375 no bug - doc: disable flake8 check on the long line. r=rmaries CLOSED TREE DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D100795
2021-01-05 16:03:45 +00:00
Sylvestre Ledru 635ee5f1cd no bug - doc: replaces mdn links by in-tree docs r=marco,andi DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D100782
2021-01-05 15:46:00 +00:00
Cosmin Sabou 8a46d2e9d6 Backed out 3 changesets (bug 1680802, bug 1680630) for turning Bug 1521378 into permafail. CLOSED TREE
Backed out changeset 3464c8f10994 (bug 1680630)
Backed out changeset 591d32364c0f (bug 1680802)
Backed out changeset 3e9350fd509d (bug 1680802)
2021-01-04 18:47:44 +02:00
Mitchell Hentges 043990b9c4 Bug 1680630: Generate android mozconfig without pkg manager r=nalexander
Knowing whether `brew` or `macports` is available isn't necessary
to generate the android mozconfig.
This should fix the generation of android mozconfig when a package
manager isn't available.

Differential Revision: https://phabricator.services.mozilla.com/D99496
2020-12-17 17:41:39 +00:00
Mitchell Hentges cdf668d1ae Bug 1680802: Install pylint requirements with legacy resolver r=firefox-build-system-reviewers,sheehan,glandium
pylint_requirements.txt fail to install with the new pip resolver due
to a conflict between astroid and lazy-object-proxy.
Rather than bumping those packages and handling the potential fallout,
the package-upgrade has been deferred and we will use the legacy
resolver in the interrim.

Differential Revision: https://phabricator.services.mozilla.com/D99940
2021-01-04 15:20:21 +00:00
Mitchell Hentges e370b9e0e8 Bug 1677994: Clarify that configure executes progs without using shell r=firefox-build-system-reviewers,dmajor,glandium
Some distros include flags when they specify the location of a binary,
such as: `XARGS=xargs -r`.
This was confusing in `configure`, since:
* We require that environment variables contain only path
  overrides (without flags).
* The error message thrown when configure chokes was unclear: "why
  would `$ xargs -r` fail?"

This patch should make our "path-only" requirement more clear.

Differential Revision: https://phabricator.services.mozilla.com/D100044
2021-01-04 15:18:33 +00:00
Andi-Bogdan Postelnicu 8f74adf68e Bug 1683479 - for `clangd` pass arguments to `clang-tidy` as string instead as list. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D100184
2020-12-21 10:01:59 +00:00
longsonr 5bc0a7bf2c Bug 1683929 - fix brew list r=mhentges
Differential Revision: https://phabricator.services.mozilla.com/D100347
2020-12-22 19:38:46 +00:00
Mike Conley 5785d877ce Bug 1682022 - Fluent migrations for bookmarks and menubar string changes. r=flod
Differential Revision: https://phabricator.services.mozilla.com/D100062
2020-12-18 19:56:45 +00:00
Andi-Bogdan Postelnicu da4ccdb84c Bug 1675417 - static-analysis autotest for `clang-tidy` should filter out colours. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D100028
2020-12-18 17:56:57 +00:00
Tarek Ziadé 4c874857ed Bug 1682829 - Automate a fuzzing smoke test in the CI r=decoder
Adds a smoke test script we can use in the CI to smoke test Firefox prior to
bigger tests.

Differential Revision: https://phabricator.services.mozilla.com/D100008
2020-12-17 13:22:16 +00:00
Connor Sheehan 7e2347b01a Bug 1681560: install native packages using requirements files with pinned hashes r=firefox-build-system-reviewers,mhentges
At the moment installing Python packages with native code is done by calling
`pip install <package>` and does not enforce any SHA hash for installed
dependencies, nor does it enforce a specific version to be installed.

This commit adds `requirements.in` and `requirements.txt` files for native
packages and changes these packages to be installed by running `pip install`
and passing the requirements file for the package. This allows us to pin the
SHA of the various dependencies. The `.txt` files are generated using
`pip-compile`.

We also add the new requirements files to the sparse profile for `mach`.

Differential Revision: https://phabricator.services.mozilla.com/D99912
2020-12-16 21:02:02 +00:00
Dorel Luca 780ce73d25 Backed out 2 changesets (bug 1680802, bug 1680630) for Linting failure. CLOSED TREE
Backed out changeset 9385e7989433 (bug 1680630)
Backed out changeset 19db3f7eb204 (bug 1680802)
2020-12-16 01:07:11 +02:00