addon.uninstall would return immediately, not waiting for the
onUninstalled listener event to fire. We can eliminate this race
condition by using a promise that resolves when it fires.
MozReview-Commit-ID: E4Mh797X9n8
--HG--
extra : rebase_source : 473e60cc393553302dcf1a2f7a18d2a45091652f
The error descriptions are rather vague and may obfuscate the
real problem. This changes the messages to be more in line with
the underlying error, and also ensures the original error is propagated.
MozReview-Commit-ID: EjctkgeUgNH
--HG--
extra : rebase_source : be10efb18f581d4643e5f52a982b888a72ef27be
Not doing this can cause a leak because there is a cycle between the
load request and the script element.
MozReview-Commit-ID: E7GbH5iDBP6
--HG--
extra : rebase_source : b9c16b5a40bf465f28f792cbf727909d1f976c31
Repurpose the previously unused Begin() function to initialize
ProtocolParser objects and also assert that we are not reusing
objects across update since that's not supported.
MozReview-Commit-ID: HIGGgOr388h
--HG--
extra : rebase_source : f9f83b1c7bd79faa40fc1d7cb594dcb14a66fe09
This check was added in bug 1296820 to disable V4 updates prior
to their being implemented. It should have been removed once we
landed working support for V4 updates.
MozReview-Commit-ID: 828DIS72LNi
--HG--
extra : rebase_source : df3bf169fb077891d5096d7cbeb68c2bb657f834
This is a generalization of the reset code that's used in pver2
to reset all tables when a `pleasereset` command is received.
MozReview-Commit-ID: LF4RegQHqoT
--HG--
extra : rebase_source : 5c100f179a23c805fe245a361f4e89c8d5f5ce0a
Currently Fennec remote debugging has a bug where custom tabs / PWA can
permanently override debugging of Fennec tabs. Fix that bug by switching
between the browser/geckoview window types depending on if the Fennec
window is gaining or losing focus.
MozReview-Commit-ID: 2BhAOPFz3c0
--HG--
extra : rebase_source : b9b6059241549bdb6badcc5702c9e47e7228edb3
Move the remote debugging setting to GeckoRuntimeSettings and use it in
geckoview_example.
MozReview-Commit-ID: G2IINILQAOm
--HG--
extra : rebase_source : fad2c96241593c6ce8898691ebf03c224815f339
Move GeckoViewRemoteDebugger.jsm usage from geckoview.js to
GeckoViewStartup.js.
MozReview-Commit-ID: 92qNB3vMH0a
--HG--
extra : rebase_source : 8d2808abf05d241e8c212c11e92c072c1cd84d29
Add a convenience function to add lazy pref observers that only load a
given module if the pref value deviates from default or when the pref
value changes.
MozReview-Commit-ID: Gh0zFC8FZih
--HG--
extra : rebase_source : b92b9324c9987f60cbc9add7748feef858301985
* getModifierForPaymentMethod helper
* Use selectedPaymentMethod from state store.
* Update and add tests for the modifier case for the main total in PaymentDialog
* Update and add tests for handling modifiers and additionalDisplayItems in the OrderDetails component
MozReview-Commit-ID: FmlovZjP0t1
--HG--
extra : rebase_source : e3a3d7ffbcb6602ec14d0bc27b20b0d7804f1694
HTMLEditor::InsertElementAtSelection() doesn't check if selection is in
native anonymous subtree. Therefore, it could insert element into <input>
element etc.
This patch adds new API to EditorDOMPointBase to compute ancestor point which
is not in native-anonymous subtree and make
HTMLEditor::GetBetterInsertionPointFor() use it to not return point in any
native-anonymous subtrees.
For reasons unknown, if you give MSVC:
// Foo.h
struct Foo
{
...
};
extern const Foo gFoo;
// Foo.cpp, which necessarily includes Foo.h.
extern constexpr Foo gFoo = {
};
MSVC will create a static initializer for gFoo and place it in the
read/write data section, rather than the read-only data section.
Removing the `extern const` declaration seems to be enough to make this
problem go away. We need to adjust the declaration of other variables
to compensate for the non-visibility of gFoo in the header file.
To allow users to opt-out from receiving LeanPlum messages we need a new setting added.
This are the Strings for the title and summary of that setting.
Localization notes also added as this Strings will ship before the feature.
MozReview-Commit-ID: 9Kx567ruY3n