This patch fixes several issues:
1. the styling of the bookmarks toolbar items was missing
background-origin/clip: padding-box
when not hovered
2. the devedition colours for toolbar buttons were not applying on Windows
in the nav-bar because we set different ones on #nav-bar:-moz-lwtheme
and on #nav-bar[brighttext]. Variables function like inherited CSS
properties and so the ones set on the #nav-bar take precedence for items
inside the #nav-bar over other ones set on :root, even if those are set
later.
3. The lwtheme and [brighttext] styling should apply to all toolbars now,
because the bookmarks toolbar items can be moved to other toolbars and
they use these CSS variables as well.
For (2) I moved the devedition definitions of toolbar color variables into
their own block that is set on both :root and on toolbar:-moz-lwtheme.
I'm not sure if having it set on :root affects e.g. devtools styling, so I
kept that rather than only setting the custom properties on the toolbars.
MozReview-Commit-ID: Jzdb8OWmC3c
--HG--
extra : rebase_source : 43322b320fe244d991562c92e01fc0ce26e94540
Bug 1305498 - 1. Remove NotificationClient task queue; r=sebastian
Not sure why we needed a task queue for NotificationClient actions. The
actions all go through IPC and are non-blocking, so it's perfectly fine
to perform them off of whatever thread we're on.
Bug 1305498 - 2. Integrate NotificationHandler et al into NotificationCllient; r=sebastian
There's no reason to have NotificationHandler, AppNotificationClient,
and ServiceNotificationClient all separate from the base
NotificationClient class. This patch adds the functionality of
those three classes to NotificationClient.
The notifications hash map is changed from a ConcurrentHashMap to a
regular HashMap with synchronization because I think the use case here
doesn't warrant the added performance and overhead of ConcurrentHashMap.
NotificationService is changed to match the new NotificationClient. Now
the only job for NotificationService is to set a notification as
foreground, rather than to manage all notifications like before.
NotificationHandler, AppNotificationClient, and
ServiceNotificationClient will be removed in a later patch.
Bug 1305498 - 3. Set NotificationListener in GeckoApplication; r=sebastian
Set NotificationListener once in GeckoApplication.onCreate, instead of
spreading it out in GeckoApp, BrowserApp, and GeckoService. This is
possible because there's no longer a distinction between
AppNotificationClient and ServiceNotificationClient in the new,
consolidated NotificationClient.
Bug 1305498 - 4. Remove obsolete notification classes; r=sebastian
Remove AppNotificationClient, ServiceNotificationClient, and
NotificationHandler, now that they've all been replaced by the new,
consolidated NotificationClient.
Bug 1305498 - 5. Use NotificationReceiver for web notification callbacks; r=sebastian
Previously, web notification callbacks went to GeckoApp directly, but
that presented some problems such as not being able to implement the
on-close callback, because we don't want to launch GeckoApp when the
notification is closed by swiping. This patch makes us use
NotificationReceiver for callbacks, and let NotificationReceiver launch
GeckoApp if necessary.
Bug 1305498 - 6. Don't keep notification cookie in native code; r=sebastian
Keep the notification cookie a single location (in the notification
intent itself), and simplify the native notification handling code.
Bug 1305498 - 7. Use NotificationReceiver for persistent notifications; r=sebastian
Currently, persistent notification callbacks go through a different code
path, but it'd be more consistent and correct to let persistent
notification callbacks go through NotificationReceiver as well.
This takes care of some housekeeping work that was missing for
persistent notifications, such as deleting the mNotifications entry when
the notification is closed.
Geoff Brown
Sebastian Hengst
George Wright
Ryan VanderMeulen
Sander Mathijs van Veen
Kartikaya Gupta
Gijs Kruitbosch
Tooru Fujisawa
David Anderson
Sotaro Ikeda
Phil Ringnalda
Iris Hsiao
Randell Jesup
Brian Grinstead
Dale Harvey
Thom Chiovoloni
Carsten "Tomcat" Book
Matt Woodrow
Deepjyoti Mondal
Jim Chen
Don Marti
Catalin Badea
Andrzej Hunt