Xidorn Quan
e98d75a60e
Bug 1374625 - Null-check result from GetTextRun in nsRubyBaseContainerFrame. r=jfkthame
...
MozReview-Commit-ID: CfXYCJ7wpj
--HG--
extra : rebase_source : 3a5040e597ac2a1ac714eb5e1f5da60fdc9b4115
2017-06-20 23:00:26 +10:00
Alexis Beingessner
adb013669b
Bug 1088760 - Remove nsRenderingContext, replacing all of its uses with gfxContext. r=jwatt,jrmuizel
...
MozReview-Commit-ID: K1WUIOnvazF
2017-06-13 11:00:10 -04:00
Sebastian Hengst
f3bf820bfd
Backed out changeset 3d1ce85e6348 (bug 1088760) for bustage, at least on Android at layout/generic/nsPluginFrame.cpp:1612. r=backout
2017-06-13 00:30:03 +02:00
Alexis Beingessner
c75211cb95
Bug 1088760 - Remove nsRenderingContext, replacing all of its uses with gfxContext. r=jwatt,jrmuizel
...
MozReview-Commit-ID: K1WUIOnvazF
2017-06-12 17:32:48 -04:00
Emilio Cobos Álvarez
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
Ting-Yu Lin
8f840dc923
Bug 775624 Part 22 - Remove NS_FRAME_COMPLETE. r=dholbert
...
This patch is written by the following script with some manual adjustment to
the comment in nsRubyTextContainerFrame.cpp and nsRubyFrame.cpp, and
nsColumnSetFrame's constructor.
function rename() {
find layout\
-type f\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "nsReflowStatus *([a-zA-Z0-9]*) = NS_FRAME_COMPLETE" "nsReflowStatus \1"
rename "([a-zA-Z0-9.*]*) *= NS_FRAME_COMPLETE;" "\1.Reset();"
rename "([a-zA-Z0-9.*]*) == NS_FRAME_COMPLETE" "\1.IsEmpty()"
MozReview-Commit-ID: 9tqQAHvdQex
--HG--
extra : rebase_source : 3119776946dc2c8350098b7bf9f3ceff29bdffb5
2017-02-14 17:55:48 +08:00
Ting-Yu Lin
65116ee49c
Bug 775624 Part 18 - Convert NS_INLINE_IS_BREAK to a method. r=dholbert
...
MozReview-Commit-ID: 7Tw1BUjOYgg
--HG--
extra : rebase_source : 907596f5a59dea709063d1f329a2155a430f41fc
2017-02-14 16:33:37 +08:00
Ting-Yu Lin
8f66d2167b
Bug 775624 Part 17 - Convert NS_INLINE_IS_BREAK_AFTER to a method. r=dholbert
...
MozReview-Commit-ID: CD9uuOC3CzP
--HG--
extra : rebase_source : e7a12a1b37f591ba33e4ed8e73502f7cddf5d619
2017-02-14 16:22:04 +08:00
Ting-Yu Lin
d5c6d28836
Bug 775624 Part 16 - Convert NS_INLINE_IS_BREAK_BEFORE to a method. r=dholbert
...
MozReview-Commit-ID: 8vxRpqbZNnk
--HG--
extra : rebase_source : 195e2da23d64da9e9a888968a45eaae2e6539585
2017-02-14 16:05:24 +08:00
Ting-Yu Lin
d1e11eca37
Bug 775624 Part 13 - Convert NS_INLINE_LINE_BREAK_AFTER to a method. r=dholbert
...
NS_INLINE_MAKE_BREAK_TYPE is used only in BRFrame. Delete it, too.
MozReview-Commit-ID: GC4vF0GFsAD
--HG--
extra : rebase_source : d7727fe41410a8998142d9ded8dcd8ae9c2a780f
2017-02-14 11:52:53 +08:00
Ting-Yu Lin
56ebb62910
Bug 775624 Part 12 - Add bit-fields for inline break status, and convert NS_INLINE_LINE_BREAK_BEFORE. r=dholbert
...
NS_INLINE_LINE_BREAK_BEFORE() was replaced by the help of the following script.
function rename() {
find layout\
-type f\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename " = NS_INLINE_LINE_BREAK_BEFORE\(\);" ".SetInlineLineBreakBeforeAndReset();"
MozReview-Commit-ID: mz6L8zay7q
--HG--
extra : rebase_source : fddffa1288c7a52c7245aec0839a65f8d1d3f008
2017-02-14 11:52:53 +08:00
Ting-Yu Lin
14b6536193
Bug 775624 Part 7 - Remove NS_FRAME_SET_INCOMPLETE. r=dholbert
...
This patch is written by the help of the following script.
function rename() {
find layout\
-type f\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "NS_FRAME_SET_INCOMPLETE\(\*([a-zA-Z0-9.*]*)\)" "\1->SetIncomplete()"
rename "NS_FRAME_SET_INCOMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.SetIncomplete()"
MozReview-Commit-ID: GOd4y2N6dcz
--HG--
extra : rebase_source : 185f5d6f5a3c8306761860c579eff10d931f3b35
2017-02-11 23:06:17 +08:00
Ting-Yu Lin
f7a393e947
Bug 775624 Part 5 - Remove NS_FRAME_IS_COMPLETE. r=dholbert
...
This patch is written by the help of the following script.
function rename() {
find layout\
-type f\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "NS_FRAME_IS_COMPLETE\(([a-zA-Z0-9.*]*)\)" "\1.IsComplete()"
MozReview-Commit-ID: GOd4y2N6dcz
--HG--
extra : rebase_source : aa8b11d3a756c9e7c521e6ffd70713af0174bd98
2017-02-11 22:45:07 +08:00
Xidorn Quan
6dc3678ea2
Bug 1321394 - Remove unnecessary loop in nsRubyBaseContainerFrame. r=dholbert
...
MozReview-Commit-ID: DqRD0w823Sv
--HG--
extra : rebase_source : 5d4e55c12a411e9f0c3579eca362d0b793aef445
2016-12-01 13:47:26 +11:00
Daniel Holbert
ad5f5d35eb
Bug 1321387 part 2: Add missing "using namespace" declarations to a few .cpp files in layout/generic. r=TYLin
...
This adds 2 "using namespace mozilla" (to provide various types),
and 2 "using namespace mozilla::gfx" (to provide mozilla::gfx::DrawTarget).
MozReview-Commit-ID: 2bXbMlr4Dbn
--HG--
extra : rebase_source : 9884419f08529469f23e3fc306ce6e4c57640f0d
2016-11-30 14:47:45 -08:00
Xidorn Quan
a4a78e1951
Bug 1267515 part 2 - Place ruby annotations outside annotations from ruby descendants. r=dholbert
...
MozReview-Commit-ID: Gbo43pC5jqr
--HG--
extra : rebase_source : 893fe9d419be59679febe2de07bbd495ce23e609
2016-10-26 17:40:58 +11:00
Nicholas Nethercote
b71747b2ac
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
...
The new name makes the sense of the condition much clearer. E.g. compare:
NS_WARN_IF_FALSE(!rv.Failed());
with:
NS_WARNING_ASSERTION(!rv.Failed());
The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Ting-Yu Lin
d77152fcd0
Bug 1277129 Part 7c - Rename various RS variables to RI. r=dbaron
...
This patch is generated by the following script:
function rename() {
find layout\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename aChildRS aChildRI
rename aContainingBlockRS aContainingBlockRI
rename aFrameRS aFrameRI
rename aLastRS aLastRI
rename aOuterRS aOuterRI
rename aRS aRI
rename blockHtmlRS blockHtmlRI
rename captionRS captionRI
rename cellRS cellRI
rename childRS childRI
rename firstAncestorRS firstAncestorRI
rename flexContainerRS flexContainerRI
rename gridRS gridRI
rename innerRS innerRI
rename lastButOneRS lastButOneRI
rename LineContainerRS LineContainerRI
rename mBlockRS mBlockRI
rename parentRS parentRI
rename secondAncestorRS secondAncestorRI
rename lastRSSize lastRISize
rename lastRSPadding lastRIPadding
MozReview-Commit-ID: YEgZs3WMow
--HG--
extra : rebase_source : c26050c71a3a5b13ef46e6d3582e581702d49ee8
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
40fcd21b9a
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
--HG--
extra : rebase_source : c91a2e174a0baec60c1b0111ac7636295004ab35
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
7a5825e82f
Bug 1277129 Part 7a - Rename ReflowState to RubyReflowInput in nsRubyBaseContainerFrame. r=dbaron
...
This is a prerequisite for the mass rename variables whose name
containing ReflowState in the next patch. Otherwise
nsRubyBaseContainerFrame::ReflowInput will conflict with
mozilla::ReflowInput.
MozReview-Commit-ID: KUU51Rjn6z
--HG--
extra : rebase_source : fcb3aefaea40f57e59cc81349b9fcc0f3a88394a
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
55cde36029
Bug 1277129 Part 6b - Rename rendContext to mRenderingContext in SizeComputationInput. r=dbaron
...
MozReview-Commit-ID: LczLJDtDncy
--HG--
extra : rebase_source : c32e928ae25f94305fb907db89278dce7304a903
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
4053c4c028
Bug 1277129 Part 5c - Rename nsHTMLReflowMetrics to ReflowOutput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics" "ReflowOutput"
MozReview-Commit-ID: 2HBb7DkooH5
--HG--
extra : rebase_source : acfa442a6483772fcb5748dc6f5e7072e599032a
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
820f88de49
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
--HG--
extra : rebase_source : 623ec822996ba0ea0058dd137acf5a658cdea04a
2016-07-21 18:36:35 +08:00
Ting-Yu Lin
a649636701
Bug 1276870 - Rename parentReflowState to mParentReflowState in nsHTMLReflowState. r=dholbert
...
MozReview-Commit-ID: ETfT1Iow7kF
--HG--
extra : rebase_source : 0f679077ccb91a1873cb9be9def4008d55579725
2016-05-31 17:40:31 +08:00
Mats Palmgren
d4dfb9f81d
Bug 645647 part 4 - Add an 'm' prefix to some members to follow our naming conventions. r=dholbert
2016-04-14 01:32:12 +02:00
Birunthan Mohanathas
d7371d07d0
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
Phil Ringnalda
d381b4bca6
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
Birunthan Mohanathas
373593275e
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
Ting-Yu Lin
1889f6bc41
Bug 1227927 Part 2 - Remove nsIFrame::GetFirstPrincipalChild(). r=mats
...
--HG--
extra : commitid : 5qtaK1nS8RC
extra : rebase_source : dcc98f423b2446269beb6fa6a9d092ae8213f38e
2016-01-29 22:42:14 +08:00
Xidorn Quan
050d22afea
Bug 1229437 part 4 - Reparent floats inside pulled ruby column. r=dbaron
...
--HG--
extra : source : 3ae85c4b74e6791ac8d30dbc2376455d32745e1c
2016-01-27 16:58:53 +11:00
Nigel Babu
89cf5102fe
Backed out changeset 04c819d845d5 (bug 1229437)
...
--HG--
extra : commitid : 7mKaiGMvXOG
2016-01-27 11:19:50 +05:30
Xidorn Quan
4c680388ca
Bug 1229437 part 4 - Reparent floats inside pulled ruby column. r=dbaron
...
--HG--
extra : rebase_source : 8685d4aabbc0e0569cf453916d9cfb28bbe37ec9
2015-12-21 14:02:46 +11:00
Nicholas Nethercote
06e901cb9f
Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
...
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.
The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:
- It adds a comment about the null check in
gfxGlyphExtents::GetTightGlyphExtentsAppUnits().
- A couple of functions simply had an unused gfxContext or nsRenderingContext
parameter removed, e.g. SetLineBreaks().
--HG--
extra : rebase_source : 8f56994bb4d254a86788b17ab2864ebc758a7e6b
2015-12-15 13:56:41 -08:00
Nicholas Nethercote
ac18a09064
Bug 1230413 (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak(). r=mattwoodrow.
...
--HG--
extra : rebase_source : 750496661635e7db65b26c625834f2d14a1b3e59
2015-12-06 14:13:57 -08:00
Xidorn Quan
1ed71b2fe7
Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013
) for reftest failures on CLOSED TREE
...
--HG--
extra : amend_source : ee1d38ab6715e193cb1462614b3395c96ca06a0c
extra : histedit_source : 65b6dcb58b89c3cbcfe9a47834baf3181a2990c8%2Cc19e313c6800de1a1906c0db2f2bd4680fe67b78
2015-12-04 13:08:17 +11:00
Xidorn Quan
45ebb9aa0e
Bug 1224013
part 2 - Move leading fix to ruby base container. r=dholbert
...
Per spec, the additional leading is added on side of ruby base container, not
ruby container. This could lead to some trivial behavior changes on edge cases.
--HG--
extra : source : 495e466ebdb628fecd9a546b539001ac316fc133
2015-12-04 12:02:41 +11:00
Jonathan Kew
022c161e17
Bug 1224230 - Explicitly store the lineContainer's writing mode in InlineIntrinsicISizeData. r=dbaron
2015-11-14 08:46:11 +00:00
Xidorn Quan
300011c44e
Bug 1197765 - Compare text content inside frame instead of the content node for ruby autohiding. r=dbaron
...
--HG--
extra : source : d265d1e03757b1f886e435ef9b60aa962787e676
2015-09-01 09:24:37 +10:00
Xidorn Quan
7e8beb711d
Bug 1180443 - Consider whitespace collapse when calculating intrinsic isize of ruby. r=dbaron
...
--HG--
extra : source : f3bc6f334e57602ee8be8d9fd32f87c3d0af7db3
2015-07-09 16:05:26 +10:00
David Major
db2b1e973b
Bug 1167189: Add an infallible version of nsContentUtils::GetNodeTextContent. r=jst
...
--HG--
extra : rebase_source : 880d1f717ad3d6789ffe3c422cc35fdf3965f55c
2015-05-22 14:16:20 -04:00
Xidorn Quan
7d994fe0ce
Bug 1153764 - Avoid explicitly doing break before when there is ruby span. r=roc
...
--HG--
extra : source : c4436462f86b0c33f98254b9d067c173702b666a
2015-04-16 13:42:45 +12:00
Xidorn Quan
59d1864c8a
Bug 1141931 part 7 - Move [Auto]RubyTextContainerArray to RubyUtils and merge RubyTextContainerIterator into AutoRubyTextContainerArray. r=dholbert
...
--HG--
extra : source : 89ae2f9a195fe10f4db19d0a51fd3ec7bafb0ecc
2015-04-08 11:22:34 +12:00
Xidorn Quan
966ef97045
Bug 1141931 part 6 - Move Ruby{Segment,Column}Enumerator to RubyUtils. r=dholbert
...
--HG--
extra : source : 2327584c7a0740617388bc544d2bb8433d034fe7
2015-04-08 11:22:34 +12:00
Xidorn Quan
ddd0a788fa
Bug 1141931 part 5 - Eliminate unnecessary includes in header files of ruby frames. r=dholbert
...
--HG--
extra : source : 860c66b5f319ed0744decf84c8c2145efd85ce83
2015-04-08 11:22:34 +12:00
Xidorn Quan
9576de22a9
Bug 1141931 part 2 - Eliminate writing-mode mismatch in ruby reflow. r=dholbert
...
--HG--
extra : source : f74929af31891aa223da8a7d0ff01d9ccd19cacd
2015-04-08 11:22:34 +12:00
Wes Kocher
74f58c915e
Backed out 10 changesets (bug 1141931) for mochitest-5 failures CLOSED TREE
...
Backed out changeset c90940067de6 (bug 1141931)
Backed out changeset 96b48288abab (bug 1141931)
Backed out changeset 87281c7ded34 (bug 1141931)
Backed out changeset 6a914ba0b8ec (bug 1141931)
Backed out changeset 9cfea55b5e95 (bug 1141931)
Backed out changeset f432612b6475 (bug 1141931)
Backed out changeset 48cf9568a4b1 (bug 1141931)
Backed out changeset f1ab848b3fa6 (bug 1141931)
Backed out changeset 8a3c71a3b525 (bug 1141931)
Backed out changeset 119d3c0fd0f6 (bug 1141931)
2015-04-07 14:23:57 -07:00
Xidorn Quan
53a7f5a9f8
Bug 1141931 part 7 - Move [Auto]RubyTextContainerArray to RubyUtils and merge RubyTextContainerIterator into AutoRubyTextContainerArray. r=dholbert
...
--HG--
extra : source : 89ae2f9a195fe10f4db19d0a51fd3ec7bafb0ecc
2015-04-08 08:40:31 +12:00
Xidorn Quan
1bbf61d898
Bug 1141931 part 6 - Move Ruby{Segment,Column}Enumerator to RubyUtils. r=dholbert
...
--HG--
extra : source : 2327584c7a0740617388bc544d2bb8433d034fe7
2015-04-08 08:40:31 +12:00
Xidorn Quan
27d78f6b41
Bug 1141931 part 5 - Eliminate unnecessary includes in header files of ruby frames. r=dholbert
...
--HG--
extra : source : 860c66b5f319ed0744decf84c8c2145efd85ce83
2015-04-08 08:40:31 +12:00
Xidorn Quan
3d1eed1f20
Bug 1141931 part 2 - Eliminate writing-mode mismatch in ruby reflow. r=dholbert
...
--HG--
extra : source : f74929af31891aa223da8a7d0ff01d9ccd19cacd
2015-04-08 08:40:31 +12:00