This is regression of bug 1423835.
When I fixed the bug, I accidentally changed the result of
HTMLEditRules::JoinNodesSmart() to use new API. However, it was simple
misunderstand. The original code sets the initial value of result to
{ aRightNode - aLeftNode.Length() } but I understood it as
{ aRightNode - aRightNode.Length() }. Therefore, this patch backs out the
patch only for this line.
MozReview-Commit-ID: 5rD7YFij8v
--HG--
extra : rebase_source : c11770892ab7416b9bf5d3329fc8b7b413387747
If the content process crashes, marionette can return None rather
than a valid result. In this case we want the test status to end up
as crash, which happens if we just propogate the None upwards.
Automatic update from web-platform-testsAdd tests for Event.srcElement
See https://github.com/whatwg/dom/issues/625 for details.
--
Add tests for Event.returnValue
See https://github.com/whatwg/dom/issues/625 for details.
wpt-commits: 13597c4af7ac923309e740920cd42bed88113e5f, 24f49ff15e22f7d81dbb87908efa0b5970b7add6
wpt-pr: 10258
wpt-commits: 13597c4af7ac923309e740920cd42bed88113e5f, 24f49ff15e22f7d81dbb87908efa0b5970b7add6
wpt-pr: 10258
Automatic update from web-platform-testsAvoid async/await in /webstorage/idlharness.html
Am sorry, Servo is dumb, we are actively trying to fix that on our side.
wpt-commits: 95992cd324d80acc68707b203be8c6cc2aebc6d5
wpt-pr: 10357
wpt-commits: 95992cd324d80acc68707b203be8c6cc2aebc6d5
wpt-pr: 10357
Automatic update from web-platform-testsservice worker: Add tests for inteception of workers after redirects.
This tests behavior discussed here:
https://github.com/w3c/ServiceWorker/issues/1289
Namely it tests when a request for a worker goes through a redirect
chain:
1) On redirect from A -> B, whether the service worker at B
sees the request.
2) After the final redirect, which service worker controls the
resulting client.
The tests are written as specified today. Therefore, Firefox
passes this test (verified in Nightly) and Chrome does not.
(Actually a small change is required to the test to make Firefox
pass it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1452528)
Currently it only tests shared worker but dedicated worker can
be added in a follow-up patch.
Bug: 829720
Change-Id: Id3b1ea8b952760be0ef9917f2c6a3afe60ca1fb5
Reviewed-on: https://chromium-review.googlesource.com/999241
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549125}
wpt-commits: 6fe36d79072d5261ea504435b0dfedaf39f5805a
wpt-pr: 10340
wpt-commits: 6fe36d79072d5261ea504435b0dfedaf39f5805a
wpt-pr: 10340
Automatic update from web-platform-testsCorrect serialization of box-shadow and text-shadow
Following https://github.com/w3c/csswg-drafts/issues/2305, the canonical serialization for box-shadow was changed to the color then lengths. https://drafts.csswg.org/css-text-decor-3/#text-shadow-property also defines the canonical serialization for text-shadow as the color and then lengths. This caused the test to fail in Firefox, Chrome, and Safari. Update the test to match the spec in both instances.
wpt-commits: a835486e59a94236a55107fe34925079b33ef247
wpt-pr: 9800
wpt-commits: a835486e59a94236a55107fe34925079b33ef247
wpt-pr: 9800
Automatic update from web-platform-tests[css-typed-om] Implement support for text-* properties.
There's a failing test due to Blink computing keyword values for
text-size-adjust to percentages, even though the spec says the computed
value is as specified.
Bug: 820299
Change-Id: I53c4177f1ce2205a4f2b6af00b1c61da4f5e774f
Reviewed-on: https://chromium-review.googlesource.com/994594
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549095}
wpt-commits: 8a4cdaf6df416d33c0b2cb591fb078d7448591db
wpt-pr: 10301
wpt-commits: 8a4cdaf6df416d33c0b2cb591fb078d7448591db
wpt-pr: 10301
Automatic update from web-platform-testsUpdate expected cssText for custom property serialization
See https://github.com/w3c/csswg-drafts/issues/2509#issuecomment-379152590 for the change to target9. Also remove the extra whitespace in target8 and target1 which causes these tests to fail in Chrome and Firefox.
Also remove testcase.propertyName from each test's name as this doesn't exist and just outputs undefined.
wpt-commits: d0d62244432d329aa22e9278d3e83184301c3e7f
wpt-pr: 10353
wpt-commits: d0d62244432d329aa22e9278d3e83184301c3e7f
wpt-pr: 10353
Automatic update from web-platform-testsImprove idlharness error message for exposure test (#10336)
When `obj` is not created successfully, there's an error like
> Cannot use 'in' operator to search for [member.name] in undefined
NB: I'm not a fan of having each sub-test re-test the same thing, but this is at least _consistent_ with the other code..
wpt-commits: 6e68c444ed00317ee7035fd2e1e144eb4a6a6091
wpt-pr: 10336
wpt-commits: 6e68c444ed00317ee7035fd2e1e144eb4a6a6091
wpt-pr: 10336
Automatic update from web-platform-testsCookie Store: Tentatively deflake special names test
The "expires" cases are flaky on all platforms on the bots, although
I can't reproduce locally. The test case sets a cookie that expires
"now" then expects it can't read it. It may be flaky due to "now"
being slightly different between processes, threads, and libraries,
allowing the read to succeed.
Set the expiry date to be an hour before "now", which should be
sufficient.
Bug: 829761
Change-Id: Icda1891310dd0a56769877f32405226390e729de
Reviewed-on: https://chromium-review.googlesource.com/999743
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548903}
wpt-commits: a4c17db5364ca97ffa9bb76f9c8e6e155ecd3ddb
wpt-pr: 10349
wpt-commits: a4c17db5364ca97ffa9bb76f9c8e6e155ecd3ddb
wpt-pr: 10349
Automatic update from web-platform-testsMove AudioNode tests to WPT
Move the AudioNode tests to WPT.
Can't move tail-processing.html because it's specific to Chrome's tail
processing.
Firefox passes all tests except:
* audionode.html (because new AudioContext(1,44100,44100) succeeds but
shouldn't
* tests that use oac.suspend
* audionode-connect-method-chaining.html with an IndexSizeError
connecting
Bug: 745778
Change-Id: I0e21e2117a75246367ea2642759ed917ee3e028f
Reviewed-on: https://chromium-review.googlesource.com/994136
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548843}
wpt-commits: 68b07988d40f8a0250675fd0de3c6ae96921608e
wpt-pr: 10320
wpt-commits: 68b07988d40f8a0250675fd0de3c6ae96921608e
wpt-pr: 10320
Automatic update from web-platform-testsCookie Store: rework tests for 'expires' option
Simplify/rework the tests for the 'expires' options. Don't run the
tests with the special secure-only prefixes, as that's orthogonal to
the behvior.
In Chromium, this also reveals that support for HTTP date strings as
'expires' values, as described in the explainer[1] is not yet
supported.
[1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md
Bug: 729800
Change-Id: I015fd643f18b59c8294f9dc62d576682132795fd
Reviewed-on: https://chromium-review.googlesource.com/994284
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548818}
wpt-commits: 8b9501b721963f2b3886f25e20f17a2afe6bc381
wpt-pr: 10298
wpt-commits: 8b9501b721963f2b3886f25e20f17a2afe6bc381
wpt-pr: 10298
Automatic update from web-platform-testsUpdate ReadableStream to latest standard version
Update Blink's implementation of ReadableStream to
https://streams.spec.whatwg.org/commit-snapshots/37ace3d5f16cbea7aec4a0c80532c95059994d51/
This also updates TransformStream to use CreateReadableStream() instead
of calling the ReadableStream constructor.
Several common operations have become unused and have been removed.
The EXTERNALLY_CONTROLLED flag has been renamed to the slightly more
specific name "BLINK_LOCK_NOTIFICATIONS".
All external/wpt/streams/readable-streams tests now pass, and failing
expectations have been removed.
Most changes were already covered by the web-platform-tests. A new
readable-streams/patched-global.js test verifies that
ReadableStreamTee() does not use the global ReadableStream constructor
or otherwise touch the global object.
BUG=710728
Change-Id: I2b799045f47376adef305f5f88ad106161425b46
Reviewed-on: https://chromium-review.googlesource.com/992077
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548784}
wpt-commits: 8314b7b5ae86ebf5bc435558ae5b0af32b1d7756
wpt-pr: 10277
wpt-commits: 8314b7b5ae86ebf5bc435558ae5b0af32b1d7756
wpt-pr: 10277
Automatic update from web-platform-testsFix the |name| of PerformanceNavigationTiming
Previously, the |name| of a PerformanceNavigationTiming entry was the initial
URL (the request URL). After this CL, it is the response URL, so for example
a url of the form 'redirect?location=newLoc' will have 'newLoc' as the |name|.
Bug: 797465
Change-Id: Icab53ad8027d066422562c82bcf0354c264fea40
Reviewed-on: https://chromium-review.googlesource.com/996579
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548773}
wpt-commits: a0091fbff26091db1fd4b6ca07d9512edf7e6a95
wpt-pr: 10339
wpt-commits: a0091fbff26091db1fd4b6ca07d9512edf7e6a95
wpt-pr: 10339
Automatic update from web-platform-testsMake BlueTooth/USB requestDevice non-consuming.
The specs for both WebBlueTooth & WebUSB only require a user
activation during a requestDevice call. So consuming the activation
(vs just checking) is not a strong requirement. There was a concern
that "not consuming" could possibly mean multiple choosers for a single
user activation but our browser code already handles the situation
gracefully. Multiple requests to browser is possible from different
tabs anyway, even with (isolated) consumptions in individual tabs.
Therefore it makes sense to remove the consumption behavior here,
which is not spec-ed anyway. This would fit our goal of a simple
user activation model ("UserActivationV2" project) which should be
simple enough for cross-browser implementation and for a complete spec.
Bug: 786407
Change-Id: I3c9dbf43df34d4cb4a2a33214a6c44847fa7435b
Reviewed-on: https://chromium-review.googlesource.com/775866
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548768}
wpt-commits: 6ba01ea2ffbafbb329352628b244815654b38156
wpt-pr: 10130
wpt-commits: 6ba01ea2ffbafbb329352628b244815654b38156
wpt-pr: 10130
Automatic update from web-platform-testsImprove error message for exposure_set test
`memberName` is undefined; error message is (was) `ReferenceError: memberName is not defined`.
Clearly supposed to be a check for duplication - `array.length < 0` was a really weird thing to see, though. Spec says it's always non-negative, so deleted that.
Error I see now is
"Multiple 'Exposed' extended attributes on Navigator"
wpt-commits: 6dd31359159f88202ef73da68c4ad2eef2a3bc99
wpt-pr: 10337
wpt-commits: 6dd31359159f88202ef73da68c4ad2eef2a3bc99
wpt-pr: 10337
Automatic update from web-platform-testsWebNFC: Use [SecureContext] instead of manual check
Until now, we had to use IsSecureContext() to check whether an execution
context is a secure context manually. But we can use [SecureContext]
instead of the manual check now.
Related spec change:
https://github.com/w3c/web-nfc/pull/143https://github.com/w3c/web-nfc/pull/144
Bug: none
Change-Id: I1396470cc57aeba137ddba65d1f29eb58cf9cf9b
Reviewed-on: https://chromium-review.googlesource.com/989537
Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#548744}
wpt-commits: 11740d8ae8381b28655ef3811a3fc8afd3a9ded1
wpt-pr: 10284
wpt-commits: 11740d8ae8381b28655ef3811a3fc8afd3a9ded1
wpt-pr: 10284
Automatic update from web-platform-testsFix all lint errors in svg/import/*
First dos2unix was used and for text-fonts-202-t-manual.svg this also
removes a UTF-8 BOM.
Then all files were passed through git stripspace, which also removed
some double blank lines which don't look to have been meaningful.
Finally all tabs were replaced by two spaces, as that's the tab width
that seems to have been used when editing these files. Some odd
indentation remains and would have to be fixed manually.
wpt-commits: 0fb0745ad0ebcb51e262f043115ff1fa5b26f876
wpt-pr: 10345
wpt-commits: 0fb0745ad0ebcb51e262f043115ff1fa5b26f876
wpt-pr: 10345
Automatic update from web-platform-testsMerge pull request #10344 from nox/var-gt-const
Change a const in var in idlharness.js
wpt-commits: b80da5dcd487fa46b68eb2ae2e3fcaac32c53427
wpt-pr: 10344
wpt-commits: b80da5dcd487fa46b68eb2ae2e3fcaac32c53427
wpt-pr: 10344
Automatic update from web-platform-testsFix RTCPeerConnection-track-stats.https.html flake.
The assert_object_equals would fail due to timestamps being different in
rare runs where the getStats() cache was invalidated between the two
calls.
external/wpt/webrtc should make no assumptions about any cache. Tests
are updated only to compare stats IDs, not individual metrics.
Bug: 829401
Change-Id: I6fcc781a1827af69f47a5c4416dd5e6bae0c98b3
Reviewed-on: https://chromium-review.googlesource.com/999477
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548721}
wpt-commits: 603e2776a1663e0790db8887204d22547ddc90de
wpt-pr: 10342
wpt-commits: 603e2776a1663e0790db8887204d22547ddc90de
wpt-pr: 10342
Automatic update from web-platform-tests[css-typed-om] Add support for border properties.
border-radius-* tests are failing because the computed value should
always be a pair of values, but Blink currently returns a CSSValuePair
with kDropIdenticalValue, so we sometimes compute to a single value.
Fixing this requires either changing computed border-radius-* to use
kKeepIdenticalValue, or overriding the computed value just for Typed OM
[1]
[1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229
Bug: 820299
Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8
Reviewed-on: https://chromium-review.googlesource.com/994433
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548697}
wpt-commits: 487c4a84856364cac109848f8dc3fd31117d6d69
wpt-pr: 10299
wpt-commits: 487c4a84856364cac109848f8dc3fd31117d6d69
wpt-pr: 10299
Automatic update from web-platform-tests[css-typed-om] Add support for background properties.
We cannot support background-repeat and background-position yet because
they are both implemented as shorthands in Blink, but are not shorthands
in the spec.
We'd need to refactor the existing code to allow shorthands to reify
as proper Typed OM objects. There are also some tricky bits to support
styleMap.set with shorthands given a proper Typed OM object.
Bug: 820299
Change-Id: I064ce37a48bee3d73965b66b323e20abf5a9099f
Reviewed-on: https://chromium-review.googlesource.com/994593
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548705}
wpt-commits: ca70fddcd052c04b962cc86d1438e68fb2457594
wpt-pr: 10300
wpt-commits: ca70fddcd052c04b962cc86d1438e68fb2457594
wpt-pr: 10300
Andreea Pavel
Masayuki Nakano
Sebastian Hengst
Narcis Beleuzu
Csoregi Natalia
James Graham
moz-wptsync-bot
Anne van Kesteren
Dominic Farolino
Mike Taylor
Anthony Ramine
Matt Falkenhagen
Chris Nardi
L. David Baron
Darren Shen
Simon Sapin
kaixinjxq
Luke Bjerring
Joshua Bell
Raymond Toy
pyup.io bot
Adam Rice
Nicolas Pena
Mustaq Ahmed
Jinho Bang
Philip Jägenstedt
Henrik Boström