Automatic update from web-platform-testsMerge pull request #10286 from bzbarsky/stable-error-messages-for-link-load
Use stable error messages in the link onload event tests by default.
wpt-commits: f527ada08cea94e63a40712062073d6ed37c8526
wpt-pr: 10286
wpt-commits: f527ada08cea94e63a40712062073d6ed37c8526
wpt-pr: 10286
Automatic update from web-platform-testsReadableStream: getReader() should call ToString() on mode
When the "mode" option is not undefined, getReader({mode}) algorithm
calls ToString() on it before checking whether or not it is "blob". Add
a test to ensure this conversion is done.
wpt-commits: ea469b6059e82729ef04cd90758fc9b52b733c7f
wpt-pr: 10267
wpt-commits: ea469b6059e82729ef04cd90758fc9b52b733c7f
wpt-pr: 10267
Automatic update from web-platform-testsbluetooth: web: test: Update blocklist UUID tests
This change updates the blocklisted UUID tests to use the Web
Bluetooth Test API. This will allow the test to be migrated into wpt/.
BUG=509038
Change-Id: I72acd10e5aabc4c03f955dc4c7b2a8620930cc2d
Reviewed-on: https://chromium-review.googlesource.com/894738
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547588}
wpt-commits: 02bf90086b80366a87edee52090a62896dd2391d
wpt-pr: 9322
wpt-commits: 02bf90086b80366a87edee52090a62896dd2391d
wpt-pr: 9322
Automatic update from web-platform-testsSerialize font shorthand like any other shorthand
The font shorthand had a short-circuit in StylePropertySerializer, which
meant that it was never serialized as a shorthand for style.cssText,
citing reasons of web incompatibility. However, it appears that all
other major browsers serialize font as a shorthand instead of having
style.cssText expand to all properties. Remove this short-circuit to
match other browsers.
Bug: 827921
Change-Id: I4d522b41a6153808b6b8dab17831afdd8315fdc3
Reviewed-on: https://chromium-review.googlesource.com/989834
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547607}
wpt-commits: 939b30a8b26ee46598d531034b40baf87d33f08a
wpt-pr: 10270
wpt-commits: 939b30a8b26ee46598d531034b40baf87d33f08a
wpt-pr: 10270
Automatic update from web-platform-testsCookie Store API: Split out and enable test cases
Split out cases from a master "cookie-store-tests.js" suite,
allowing them to be enabled/debugged separately.
Also updates observation tests to use the new "change" event,
and deletes "static" since we can assume a dependency on a test
server here.
Bug: 783229
Change-Id: I9e29ea74a2f0513a033a8f9c71da2836c000ee27
Reviewed-on: https://chromium-review.googlesource.com/986649
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547543}
wpt-commits: 94b7255991af7f0ddf582ff316b069c54e0e87b8
wpt-pr: 10244
wpt-commits: 94b7255991af7f0ddf582ff316b069c54e0e87b8
wpt-pr: 10244
Automatic update from web-platform-testsTests and docs for the current CORB vs <link rel="preload"> behavior.
Bug: 809261
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Idafb2b4cc5da3d6c7a054e479745288cc3b86513
Reviewed-on: https://chromium-review.googlesource.com/984338
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547494}
wpt-commits: 4bb4e6ec3e5abe394a69e79c0d6df160b606e6f4
wpt-pr: 10213
wpt-commits: 4bb4e6ec3e5abe394a69e79c0d6df160b606e6f4
wpt-pr: 10213
Automatic update from web-platform-testsRemove test that CSSStyleSheet.media is read-only
style-sheet-interfaces-001.html tested that styleSheet.media was
read-only, but the spec changed to add a [PutForwards] attribute to
|media|, meanining that the attribute is no longer truly read-only.
assert_readonly can have side-effects if the property has a
[PutForwards] attribute, so remove this check, as it was causing the
next test to fail.
Bug: 821780
Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3
Reviewed-on: https://chromium-review.googlesource.com/989407
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547451}
wpt-commits: af485dcf5f9fb6c1892908ab850b2bf49bc765a2
wpt-pr: 10264
wpt-commits: af485dcf5f9fb6c1892908ab850b2bf49bc765a2
wpt-pr: 10264
Automatic update from web-platform-tests[css-grid] Fix resolution of percentage paddings and margins of grid items
We were not resolving properly percentage paddings and margins
for tracks that have something like minmax(auto, 100px).
The reason was that while computing the minimum size of a grid item,
the percentages were resolved against the inline size of the grid container.
But for grid items we shouldn't never use the grid container size,
but the grid area size, as that's their containing block.
The patch modifies ContainingBlockLogicalWidthForContent() and
ContainingBlockLogicalHeightForContent() in LayoutBox,
so for grid items we return 0 if the area size hasn't been set yet.
We never want to use the grid container's sizes in these cases.
BUG=808758
TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-margins-*
TEST=external/wpt/css/css-grid/grid-items/grid-items-percentage-paddings-*
Change-Id: Ib142e51aee1fe623d38688469b179f01f82eb07b
Reviewed-on: https://chromium-review.googlesource.com/980756
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#547417}
wpt-commits: e4efc10a82630de47f920a737aa8ea94845191af
wpt-pr: 10194
wpt-commits: e4efc10a82630de47f920a737aa8ea94845191af
wpt-pr: 10194
Automatic update from web-platform-testsUpdate IRC archive link (#10266)
The link was dead; update to the new link.
wpt-commits: 94b33b573a069ae5170104ca581a354a35762536
wpt-pr: 10266
wpt-commits: 94b33b573a069ae5170104ca581a354a35762536
wpt-pr: 10266
Automatic update from web-platform-testsSet SkipServiceWorker flag for synchronous loads from the main thread.
Before 5e1b52dd7e828fb2e4bd69f599c0c30eec3e873c, synchronous XHR on worker
was handled by service workers. It is because the |is_sync_load| was false
when the sync request is from worker thread. But after the CL, the
|is_sync_load| flag for the sync request from worker became true, so the request
will not go to the service worker.
This CL will fix this by
- Set the SkipServiceWorker flag for synchronous loads from the main thread
in the renderer process. (FetchParameters.cpp)
- Don't set skip_service_worker even if is_sync_load is true in the browser
process. (resource_dispatcher_host_impl.cc)
Bug: 706331,827473
Change-Id: I186bc97f3f8d298e0a04942d0ec4b708b3022cc1
Reviewed-on: https://chromium-review.googlesource.com/989376
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547407}
wpt-commits: d68f044162867a8283c6d4adbf19e9587b6ea2fa
wpt-pr: 10265
wpt-commits: d68f044162867a8283c6d4adbf19e9587b6ea2fa
wpt-pr: 10265
Automatic update from web-platform-testsAdd a DataTransfer test
The types attribute must return this DataTransfer object's types array
wpt-commits: 1331d68a18a959d74c73142ed984c65f455ce1fe
wpt-pr: 8605
wpt-commits: 1331d68a18a959d74c73142ed984c65f455ce1fe
wpt-pr: 8605
Automatic update from web-platform-testsDelete wasm/many-memories.window.js WPT test
Testing for a specific number is causing problems and determining the right
number is problematic in general, as running out of memory is always a
legitimate possiblity. See https://github.com/WebAssembly/design/issues/1167 for
more discussion. In light of this, it's best to just remove the test.
Bug:
Change-Id: I66e248c8ab851bca0c54fa6fe13b6e93e55f1264
Reviewed-on: https://chromium-review.googlesource.com/851081
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547333}
wpt-commits: fc33be9acfbf8e883fd9683c527aab22d842542b
wpt-pr: 8927
wpt-commits: fc33be9acfbf8e883fd9683c527aab22d842542b
wpt-pr: 8927
Automatic update from web-platform-testsReplace Arial with Arimo GCS font
BUG=787020
TBR=dpranke,asvitkine
Change-Id: I38740d1ee9fe621eabd5416f1a87b23a71fbb7e7
Reviewed-on: https://chromium-review.googlesource.com/986812
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547246}
wpt-commits: 771a209d64f3c07430b5b0090bc61fc31485f0b9
wpt-pr: 10256
wpt-commits: 771a209d64f3c07430b5b0090bc61fc31485f0b9
wpt-pr: 10256
Automatic update from web-platform-testsUpdate the name of webaudio to web-audio-api
wpt-commits: 067f918f9a723736dcf9bf29b64184d2bdb70861
wpt-pr: 9839
wpt-commits: 067f918f9a723736dcf9bf29b64184d2bdb70861
wpt-pr: 9839
Automatic update from web-platform-testsRevert "bluetooth: FakeBluetoothChooser impl."
This reverts commit 6a337f19713e049cd42969b0c909c59aff4146cd.
Reason for revert: https://crbug.com/824704
These tests are failing:
external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services-with-uuid.https.html
external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html
external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html
external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html
external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html
Original change's description:
> bluetooth: FakeBluetoothChooser impl.
>
> Implements the interfaces that FakeBluetoothChooser overrides. The
> mojom::FakeBluetoothChooser overrides are implemented by running
> |event_handler_| with the appropriate arguments. The BluetoothChooser
> overrides do nothing at the moment, since the base class is only meant
> to update the chooser user interface.
>
> This change also begins to partially convert a Bluetooth chooser test to test
> the interface and deletes the temporary tests that were created to test this
> API.
>
> This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
> reverted the original change. The original change caused the
> new-scan-device-added.html test to fail because of a Mojo validation error
> resulting from not updating the
> third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
> file needed by the test.
>
> Bug: 719827, 719826, 824704, 826787
> Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
> Reviewed-on: https://chromium-review.googlesource.com/985195
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546729}
TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org
Change-Id: Ie2ef2af1ae74e8dd5ca01441027adaa59e6e0c0f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719827, 719826, 824704, 826787
Reviewed-on: https://chromium-review.googlesource.com/986592
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546851}
wpt-commits: 709111adbc503d82692ae71f2397eda8bef635f2
wpt-pr: 10242
wpt-commits: 709111adbc503d82692ae71f2397eda8bef635f2
wpt-pr: 10242
Automatic update from web-platform-testsAdd wpt test for back/forward mouse buttons.
Test that back and forward mouseup events are received and can be
preventDefaulted.
BUG=680741
Change-Id: I381a3c3dacc344ae4f49c8a35cdcc0ef83907917
Reviewed-on: https://chromium-review.googlesource.com/986508
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546857}
wpt-commits: 68f87b7492febebdc9911028e562b8bc4ea0c35f
wpt-pr: 10243
wpt-commits: 68f87b7492febebdc9911028e562b8bc4ea0c35f
wpt-pr: 10243
Automatic update from web-platform-tests[css-overflow-3] test the flow-relative overflow properties (#10233)
Corresponding to the spec changes decided in https://github.com/w3c/csswg-drafts/issues/2000
wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
wpt-commits: 4091ab0f7cbcb304cdd5b1d1c30264b052359b38
wpt-pr: 10233
Automatic update from web-platform-testsRTCRtpReceiver.getStats() in blink added behind flag.
This exposes RTCRtpReceiver.getStats() in JavaScript (behind flag) which
implements the stats selection algorithm[1] for receivers.
(This is similar to RTCRtpSender.getStats():
https://chromium-review.googlesource.com/c/chromium/src/+/975306)
[1] https://w3c.github.io/webrtc-pc/#dfn-stats-selection-algorithm
Bug: 680172
Change-Id: I8049a52fcaa3c2bd51e5541c7149d9b3aee57e3d
Reviewed-on: https://chromium-review.googlesource.com/976121
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Taylor Brandstetter <deadbeef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546801}
wpt-commits: f30b60b6c146a653f31ae5c92297a9639d16d450
wpt-pr: 10219
wpt-commits: f30b60b6c146a653f31ae5c92297a9639d16d450
wpt-pr: 10219
Automatic update from web-platform-testsInvert (fix) the order of `wpt make-hosts-file` instructions (#10237)
This was inverted so that the Windows instructions were printed on
Linux. Rather than just changing the condition, switch the messages,
to match the order of some preceding code.
wpt-commits: 8efcf2b57818807058a785bc55ebe13cb0139123
wpt-pr: 10237
wpt-commits: 8efcf2b57818807058a785bc55ebe13cb0139123
wpt-pr: 10237
Automatic update from web-platform-tests[css-typed-om] Add support for marker properties.
This patch adds support for marker, marker-start, marker-end, marker-mid
We also had to add a new CSS data type <url>, but because it's not
spec'd yet, we can't really test it.
Bug: 820299
Change-Id: Ie3f851be3d65396705594d99582ac3e87e3fc57d
Reviewed-on: https://chromium-review.googlesource.com/983192
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546645}
wpt-commits: 604d17e907e6ef5bed218cfa36653f37c941ee59
wpt-pr: 10205
wpt-commits: 604d17e907e6ef5bed218cfa36653f37c941ee59
wpt-pr: 10205
Automatic update from web-platform-testsbluetooth: FakeBluetoothChooser impl.
Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.
This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.
This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
reverted the original change. The original change caused the
new-scan-device-added.html test to fail because of a Mojo validation error
resulting from not updating the
third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
file needed by the test.
Bug: 719827, 719826, 824704, 826787
Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
Reviewed-on: https://chromium-review.googlesource.com/985195
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546729}
wpt-commits: 9c86b931f4ebe4db86d2ed931ca2d588be3c4a38
wpt-pr: 10224
wpt-commits: 9c86b931f4ebe4db86d2ed931ca2d588be3c4a38
wpt-pr: 10224
Automatic update from web-platform-testsCheck BackgroundEdgeOrigin when check BackgroundPosition.
We should check Background{X/Y}Origin when check
BackgroundPosition{X/Y}. BackgroundPosition same but
BackgroundEdgeOrigin different is not the same position, we should
return false when FillLayersEqual().
Bug: 823046
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: Ia7d0c5af33e1ee5986420dc054c2ce1b1f65e9b0
Reviewed-on: https://chromium-review.googlesource.com/967912
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546679}
wpt-commits: 55846d56d8eed33606cdc1beaa7add98e694c824
wpt-pr: 10138
wpt-commits: 55846d56d8eed33606cdc1beaa7add98e694c824
wpt-pr: 10138
Automatic update from web-platform-testswebdriver: add more WebKit workarounds to detect whether a window is fullscreen (#10226)
WebKit doesn't implement the Fullscreen API yet, so we need to use
the vendor prefixed property to check whether the window is fullscreen.
This workaround was previously applied to fullscreen_window.py, but it
needs to happen in other places as wel.
wpt-commits: 592e2ed83ecd717392d37047536250ba74f1bafa
wpt-pr: 10226
wpt-commits: 592e2ed83ecd717392d37047536250ba74f1bafa
wpt-pr: 10226
Automatic update from web-platform-testsRevert "bluetooth: FakeBluetoothChooser impl."
This reverts commit 188adfb51a7c4ca1ab0cbeaffdec4f7cd76857f7.
Reason for revert: https://crbug.com/826787
Original change's description:
> bluetooth: FakeBluetoothChooser impl.
>
> Implements the interfaces that FakeBluetoothChooser overrides. The
> mojom::FakeBluetoothChooser overrides are implemented by running
> |event_handler_| with the appropriate arguments. The BluetoothChooser
> overrides do nothing at the moment, since the base class is only meant
> to update the chooser user interface.
>
> This change also begins to partially convert a Bluetooth chooser test to test
> the interface and deletes the temporary tests that were created to test this
> API.
>
> BUG=719827,719826,824704
>
> Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3
> Reviewed-on: https://chromium-review.googlesource.com/962983
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Conley Owens <cco3@chromium.org>
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546509}
TBR=dcheng@chromium.org,cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org
Change-Id: I0597151ec5878d41ac631b72296203bc99b1f2c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 719827, 719826, 824704, 826787
Reviewed-on: https://chromium-review.googlesource.com/984299
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546572}
wpt-commits: d5fea759ccb42cb19ed8553b99e74165fbfa79bb
wpt-pr: 10223
wpt-commits: d5fea759ccb42cb19ed8553b99e74165fbfa79bb
wpt-pr: 10223
Automatic update from web-platform-tests[css-layout-api] Implementation of LayoutConstraints#fixedInlineSize.
This adds the bare bones for the LayoutConstraints object. It just
handles the fixedInlineSize parameter. I expect the information in
this object after the next F2F.
The layout for the test will simply output an autoBlockSize of 100, if
the fixedInlineSize is 100. The tests impose various conditions in
how this can occur, but is certainly not exhaustive.
Change-Id: I6be4a7b77d7b737c778dc2de8b235035b8d3fa22
Bug: 726125
Reviewed-on: https://chromium-review.googlesource.com/981517
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546393}
wpt-commits: c2cd7575a454498f5758b8179506b3b49ad9f074
wpt-pr: 10199
wpt-commits: c2cd7575a454498f5758b8179506b3b49ad9f074
wpt-pr: 10199
Automatic update from web-platform-testsbluetooth: FakeBluetoothChooser impl.
Implements the interfaces that FakeBluetoothChooser overrides. The
mojom::FakeBluetoothChooser overrides are implemented by running
|event_handler_| with the appropriate arguments. The BluetoothChooser
overrides do nothing at the moment, since the base class is only meant
to update the chooser user interface.
This change also begins to partially convert a Bluetooth chooser test to test
the interface and deletes the temporary tests that were created to test this
API.
BUG=719827,719826,824704
Change-Id: I56a04e6bdb2de38d9163d7bc350db578deeb9ba3
Reviewed-on: https://chromium-review.googlesource.com/962983
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546509}
wpt-commits: 107dd46e1211df0e9a2aa229418ef30291573a0b
wpt-pr: 10083
wpt-commits: 107dd46e1211df0e9a2aa229418ef30291573a0b
wpt-pr: 10083
Automatic update from web-platform-tests[css-typed-om] Stub list-valued tests.
Currently we're just adding a TODO when we want to test a list-valued
property. It's probably easier if we stub that test function and then
implement it later.
Bug: 774887
Change-Id: Iab3cea915afbcc8490cacbd45e5632a18e7dece1
Reviewed-on: https://chromium-review.googlesource.com/981956
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546067}
wpt-commits: 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb
wpt-pr: 10191
wpt-commits: 97d4646fd82ae91238bf0c8bb8f941a0db10ecfb
wpt-pr: 10191
Automatic update from web-platform-testsKeep track of all pending slot assignments, and recalc all before UpdateStyle phase
For the purpose of rendering, Blink must calculate all pending slot assignments
before UpdateStyle phase. Unless that, a recursive RecalcStyle() may not
traverse a node which should be re-attached.
e.g. Suppose the following tree, where #d1 is assigned to a slot.
host
├──/shadow-root
│ └── slot name=s1
└── div id=d1 slot=s1
Then, we change #d1's slot attribute to s2, like:
> document.querySelector('#d1').setAttribute('slot', 's2');
host
├──/shadow-root
│ └── slot name=s1
└── div id=d1 slot=s2
In this case, #d1 should be removed from a LayoutTree. In other words, Blink
has to reattach #d1 somehow. However, if we don't recalc a slot assignment for
the shadow tree before UpdateStyle, a recursive RecalcStyle never traverses the
sub-tree because child-needs-style-recalc flag is not set for the node (and its
ancestor nodes). A flag should be set as a result of slot assignment recalc.
Thanks to the Incremental Shadow DOM, a slot assignemt recalc now becomes a
local operatoin on each shadow tree, rather than one global operation for every
shadow trees. We don't need to traverse a composed tree to recalc all. We can
recalc a slot assignment for each shadow tree directly, without traversing a
composed tree.
For a shadow tree which is not connected, we don't need to recalc its slot
assignment before UpdateStyle because such a shadow tree shouldn't have any
effect on rendering. Lazy slot assignment recalc is enough for such a shadow
tree.
This CL doesn't introduce any optimization to minimize the number of
to-be-reattached nodes. I'll optimize that as a next task. I'll use a sort of
dynamic programming there, as I did at
https://chromium-review.googlesource.com/c/chromium/src/+/535493 for
non-Incremental Shadow DOM.
Except for the performance, this CL should be the last part of Incremental
Shadow DOM from the external behavior's perspective. Style and Layout should
work correctly after this CL, even with Incremental Shadow DOM.
BUG=776656
Change-Id: Id18e87ff59d92863c68c571e7db09253c08aa91f
Reviewed-on: https://chromium-review.googlesource.com/964062
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546458}
wpt-commits: 1d25beb750906894ae1306c69ba2290e527b7048
wpt-pr: 10174
wpt-commits: 1d25beb750906894ae1306c69ba2290e527b7048
wpt-pr: 10174
Automatic update from web-platform-testsTest that event handlers set on the window object are found on the body element (#10169)
Based on event-handler-attributes-body-window.html.
wpt-commits: 6fca0b2cd6f7f8d915e78b1e3aa00a3ac6893019
wpt-pr: 10169
wpt-commits: 6fca0b2cd6f7f8d915e78b1e3aa00a3ac6893019
wpt-pr: 10169
Automatic update from web-platform-testsRe-land: "Don't adjust the NavigationTimings on redirects"
The reason for revert was the new navigation timing test expectations
(that got commited right before the original change) had a FAIL
expectation for the particular event order that this change was fixing.
Original change's description:
> Don't adjust the NavigationTimings on redirects
>
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
>
> R=ksakamoto,arthursonzogni
>
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}
Bug: 813889
Change-Id: I6f5c0ba1196fa1dd52225036820b29a95569ac21
Reviewed-on: https://chromium-review.googlesource.com/981913
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546365}
wpt-commits: 383fd735a55bd21daef6a07430d8f6ce3852f30b
wpt-pr: 10193
wpt-commits: 383fd735a55bd21daef6a07430d8f6ce3852f30b
wpt-pr: 10193
Automatic update from web-platform-tests[css-typed-om] Support some text-decoration properties.
Adds tests for:
- text-decoration
- text-decoration-line
- text-decoration-skip (not implemented in Blink)
- text-decoration-skip-ink
- text-decoration-width (not implemented in Blink)
text-decoration-line uses a weird internal structure for CSSValues,
so we have to encode/decode to that structure when getting/setting.
Failing tests because for some reason we ignore 'blink' for the
computed value. Blink also doesn't support 'spelling-error' and
'grammar-error' yet.
Bug: 820299
Change-Id: I60e8c3958c9b3a784177c9813a7325aa26e39581
Reviewed-on: https://chromium-review.googlesource.com/981717
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546364}
wpt-commits: 62d701058e3ddedb88df00fadb4e05802b7e8cbc
wpt-pr: 10189
wpt-commits: 62d701058e3ddedb88df00fadb4e05802b7e8cbc
wpt-pr: 10189
Automatic update from web-platform-tests[css-typed-om] support r and rx and ry properties
r[1], rx[2], ry[3]
are added to support in whitelist.
and test file are also added.
[1]https://svgwg.org/svg2-draft/geometry.html#R
[2]https://svgwg.org/svg2-draft/geometry.html#RX
[3]https://svgwg.org/svg2-draft/geometry.html#RY
Bug: 820299
Change-Id: I51457648ca07aaf06cf15bd28452d5ad8099d2e3
Reviewed-on: https://chromium-review.googlesource.com/981918
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546302}
wpt-commits: 45d92ebc552d67936169a17e86980636b112bf18
wpt-pr: 10196
wpt-commits: 45d92ebc552d67936169a17e86980636b112bf18
wpt-pr: 10196
Automatic update from web-platform-testsRevert "Don't adjust the NavigationTimings on redirects"
This reverts commit aeecb4f32ece14a8a294e4f9b80a5bb2278091c9.
Reason for revert: Causing lots of failures on webkit bots, e.g.:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/42143
Original change's description:
> Don't adjust the NavigationTimings on redirects
>
> We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
> shouldn't update in each AddRedirect() (which is called in a batch
> way after all the redirects are handled in the browser process with PlzNavigate,
> adjusting timings there with current timestamp is totally wrong)
>
> R=ksakamoto,arthursonzogni
>
> Bug: 813889
> Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
> Reviewed-on: https://chromium-review.googlesource.com/974673
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#546001}
TBR=kinuko@chromium.org,ksakamoto@chromium.org,arthursonzogni@chromium.org
Change-Id: I467ed888084ea0eda06faa903d1797fabffc47da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813889
Reviewed-on: https://chromium-review.googlesource.com/981912
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546025}
wpt-commits: 2e480369d06977c6afeda0d45bd67f0644b787b4
wpt-pr: 10190
wpt-commits: 2e480369d06977c6afeda0d45bd67f0644b787b4
wpt-pr: 10190
Automatic update from web-platform-tests[css-layout-api] Allow developers to position fragments.
This implements the LayoutFragment.inlineOffset and
LayoutFragment.blockOffset attributes.
The tests added simply re-create the reference by setting these two
attributes in different text directions and writing modes.
Change-Id: I1865403ca12e3b174738ee93320eae5ba16ac292
Bug: 726125
Reviewed-on: https://chromium-review.googlesource.com/971832
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546018}
wpt-commits: 8ec345bcd24282ce94960fc0b11ca057bec393be
wpt-pr: 10161
wpt-commits: 8ec345bcd24282ce94960fc0b11ca057bec393be
wpt-pr: 10161
Automatic update from web-platform-testsDon't adjust the NavigationTimings on redirects
We adjust the timings in WebDocumentLoaderImpl::UpdateNavigation(),
shouldn't update in each AddRedirect() (which is called in a batch
way after all the redirects are handled in the browser process with PlzNavigate,
adjusting timings there with current timestamp is totally wrong)
R=ksakamoto,arthursonzogni
Bug: 813889
Change-Id: I3a57d3fdf1833c300feb5ee61737b64cece0946b
Reviewed-on: https://chromium-review.googlesource.com/974673
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546001}
wpt-commits: c32afde8ec7f0e10b5b5f27c4907095c37303e71
wpt-pr: 10150
wpt-commits: c32afde8ec7f0e10b5b5f27c4907095c37303e71
wpt-pr: 10150
Automatic update from web-platform-testsservice_worker: Add tests for navigation timing
This CL adds some tests for PerformanceNavigationTiming
which are involved with service worker.
- SW intercepts a navigation
- SW falls back to network
- Redirect and SW intercepts a navigation
These tests check `workerStart <= fetchStart` because starting
a worker should happen before fetching a resource when service
worker is involved.
Bug: 782958
Change-Id: Idd3fa8f76a328e77ee531b81bd91ee3db223f12c
Reviewed-on: https://chromium-review.googlesource.com/979873
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545935}
wpt-commits: 92461700073cb989bf1df2deada5413b06647b80
wpt-pr: 10173
wpt-commits: 92461700073cb989bf1df2deada5413b06647b80
wpt-pr: 10173
Automatic update from web-platform-tests[css-layout-api] Allow LayoutChild(ren) to be laid out.
This allows a LayoutChild to have layout performed on it, which will
return a Fragment - with the correct inline and block sizes.
These Fragments cannot be positioned yet, (next patch).
The LayoutChild will be laid out with an available inline/block size of
zero by default, and optionally can accept a fixed-inline/block size,
which it must respect.
Bug: 726125
Change-Id: Ie4386b8f6cd6ccec3f9e52ff332322101058836d
Reviewed-on: https://chromium-review.googlesource.com/962870
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545845}
wpt-commits: 7988e1756539bcdf39ec2102b99e0671c44d503c
wpt-pr: 10054
wpt-commits: 7988e1756539bcdf39ec2102b99e0671c44d503c
wpt-pr: 10054
Automatic update from web-platform-tests[css-flexbox] Resolve min-width:auto on table item to min preferred size.
Edge and Firefox seem to let table flex items use the sizing algorithm
of the table extensively, and are therefore generally broken when it
comes to flexing tables. We, on the other hand, let the flex sizing
algorithm be in charge of sizing tables, so that flexing actually works.
However, this causes tables with a specified main size of less than the
minimum intrinsic logical width of the table to shrink below their
minimum intrinsic logical width, a situation that's generally unwanted
for tables.
Amend by ignoring the specified main size when resolving min-width:auto
on table items. Also ignore max-width/max-height. Just use the
preferred minimum logical width.
Bug: 821832
Change-Id: I78ca0c8e0041ea69bb606ff72d340bb3f5f9bb96
Reviewed-on: https://chromium-review.googlesource.com/964203
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545777}
wpt-commits: f4388a3ab1931b8f270378e3b0598c5d8538f3cb
wpt-pr: 10050
wpt-commits: f4388a3ab1931b8f270378e3b0598c5d8538f3cb
wpt-pr: 10050
Automatic update from web-platform-testsAdd support for autoGainControl and noiseSuppression to getCapabilities()
This CL adds support for autoGainControl and noiseSuppression properties
to MediaStreamTrack.getCapabilities() and InputDeviceInfo.getCapabilities().
Bug: 823831, 817769
Change-Id: Ifdc0e560001e000b12c8d04634d3c52de0a34cc7
Reviewed-on: https://chromium-review.googlesource.com/977251
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#545750}
wpt-commits: ff4fae135b1c76c6784d2b0f2739fc69adadb3ba
wpt-pr: 10154
wpt-commits: ff4fae135b1c76c6784d2b0f2739fc69adadb3ba
wpt-pr: 10154
Automatic update from web-platform-tests[css-typed-om] Support font properties.
We try to support as many font properties as possible. However, several
font properties have not been implemented in Blink yet. Also, the
computed value for font-stretch is wrong (it should be as specified,
and no rounding should occur).
Spec: https://drafts.css-houdini.org/css-typed-om-1/#reify-stylevalue
Bug: 820299
Change-Id: I744d03a08856bd6d0df6bd07230ec80138e6e3b7
Reviewed-on: https://chromium-review.googlesource.com/977247
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545721}
wpt-commits: 4ff4c6645e47cf6e2585e3bd3f648f5c9491a859
wpt-pr: 10152
wpt-commits: 4ff4c6645e47cf6e2585e3bd3f648f5c9491a859
wpt-pr: 10152
Automatic update from web-platform-testsFix some IDL tests after html.idl includes SVGElement
html.idl changed in upstream
https://github.com/w3c/web-platform-tests/pull/10110
and imported in
https://crrev.com/c/978021
Bug: 825191
Change-Id: Ie1a04e730aabd50c615f1dab079f92eeaa22565a
Reviewed-on: https://chromium-review.googlesource.com/978508
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545588}
wpt-commits: d04a8fc02b85bd32799691759c8c05ead07cd939
wpt-pr: 10163
wpt-commits: d04a8fc02b85bd32799691759c8c05ead07cd939
wpt-pr: 10163
Automatic update from web-platform-testsbluetooth: Impl. setNextWriteResponse (descriptor)
Also implements getLastWrittenValue() and converts two tests to use
these.
FakeRemoteGattDescriptor::setNextWriteResponse allows tests to set the
next response for a write.
BUG=719825
Change-Id: I2807d23a55f79eeca35338e25916c6d5e0115e89
Reviewed-on: https://chromium-review.googlesource.com/964901
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545508}
wpt-commits: 7991f4bac7d03ac0251bc5eac60b725ad53ca81f
wpt-pr: 10117
wpt-commits: 7991f4bac7d03ac0251bc5eac60b725ad53ca81f
wpt-pr: 10117
Automatic update from web-platform-testsbluetooth: Add RemoveFakeDescriptor to BT test
This change allows the removal of a descriptor to be simulated by the
Bluetooth test interface. A generated test script was also converted to test the
new interface.
BUG=569709
Change-Id: Id4286a3e44cd04ee1b371938f1ef89f33458269c
Reviewed-on: https://chromium-review.googlesource.com/972334
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545448}
wpt-commits: 273bb41376c98c36e743186b63ec3cffa58a5339
wpt-pr: 10118
wpt-commits: 273bb41376c98c36e743186b63ec3cffa58a5339
wpt-pr: 10118
Automatic update from web-platform-testsDon't skip display:none options finding selectable options.
This means we can also assume a null ComputedStyle on options means they
are display:none. That is a pre-requisite for fixing issue 822581.
Bug: 824754
Change-Id: Ia8a400ec8eed9ecb9a85d2c93c354841ad721492
Reviewed-on: https://chromium-review.googlesource.com/975604
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545443}
wpt-commits: 2d1fd9e9f49a4bd8884535447282f8fd52d8fd48
wpt-pr: 10146
wpt-commits: 2d1fd9e9f49a4bd8884535447282f8fd52d8fd48
wpt-pr: 10146
Automatic update from web-platform-testsPaymentRequest: Use [SecureContext] instead of manual check (#8648)
Until now, we had to use IsSecureContext() to check whether an execution
context is a secure context manually. But we can use [SecureContext]
instead of the manual check now. After this change, all related APIs
including PaymentRequest will not be exposed in non-secure context.
Bug: none
Change-Id: Ie5b3fc6641e882cc2844595fea350b6adb3425db
wpt-commits: a1ec330b943e4164962bd1108798d60aa4a0e5e3
wpt-pr: 8648
wpt-commits: a1ec330b943e4164962bd1108798d60aa4a0e5e3
wpt-pr: 8648
Automatic update from web-platform-testsidlharness.js: Distinguish instance toJSON is being executed against when it's inherited (#10029)
* Distinguish which instance toJSON is being executed against when inherited
wpt-commits: 4578f69b2b605146490f8951cd37e87bdf521d03
wpt-pr: 10029
wpt-commits: 4578f69b2b605146490f8951cd37e87bdf521d03
wpt-pr: 10029
Automatic update from web-platform-testsFixed lint checking directories it shouldn't be (#10147)
Lint earlier checked _venv/ and .git/ which it shouldn't be checking.
wpt-commits: b705dc10c1b15a9cf3fa2b1648274f4d70ee1aa2
wpt-pr: 10147
wpt-commits: b705dc10c1b15a9cf3fa2b1648274f4d70ee1aa2
wpt-pr: 10147
Automatic update from web-platform-testsFix python gitignore for directories. (#10131)
For top level directories like _venv/ we were creating the regexp
^\_venv/$, which we were then feeding paths like _venv/bin/foo which
it fails to match. Since we are matching against full paths, we
certainly want to allow matching _venv/* and probably also bare _venv,
so add a special case for paths with a trailing slash to allow these
options.
wpt-commits: 174f76430b32801d32cb3974c46894e866bad7a3
wpt-pr: 10131
wpt-commits: 174f76430b32801d32cb3974c46894e866bad7a3
wpt-pr: 10131
Automatic update from web-platform-tests[css-grid] Fix auto repeat tracks computation with definite min sizes
Indefinitely sized containers use the specified definite min-size (if any) as
available space in order to compute the number of auto repeat tracks to
create. A bug in that code was causing the grid to be one track larger than
expected. That was only happening in the case of the free space being
a multiple of the total size of the autorepeat tracks.
Bug: 823140
Change-Id: I6cc13df478da4ba00585fa557012391291941d1a
Reviewed-on: https://chromium-review.googlesource.com/973522
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#545403}
wpt-commits: 9e2e5eb3fc0dbb25a8f643020577157c3e64d556
wpt-pr: 10141
wpt-commits: 9e2e5eb3fc0dbb25a8f643020577157c3e64d556
wpt-pr: 10141
Automatic update from web-platform-testsAdd HTMLOrSVGElement to HTML's IDL
And align a couple other things while there.
Helps with https://github.com/whatwg/html/pull/3543.
wpt-commits: 20d739eff6ebfe360c1aadfd3f3161c0fce847a2
wpt-pr: 10110
wpt-commits: 20d739eff6ebfe360c1aadfd3f3161c0fce847a2
wpt-pr: 10110
Automatic update from web-platform-tests[PE] Add ToInt() for logical padding top and bottom for LayoutTableCell
This reverts the logic for logical top/bottom paddings to be the same
as before https://chromium-review.googlesource.com/619603. The logical
top/bottom paddings are truncated like what we do for other table
layouts.
We still keep subpixels for logical left/right paddings to ensure
correct logical width calculation. This is still the same as before
https://chromium-review.googlesource.com/619603.
Bug: 823824
Change-Id: Icb617bf5771d1726f767207853f4adc8275731dc
Reviewed-on: https://chromium-review.googlesource.com/974315
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545225}
wpt-commits: 4e1bb5100b7de0d9373bccf5fd09e8476801d3cd
wpt-pr: 10132
wpt-commits: 4e1bb5100b7de0d9373bccf5fd09e8476801d3cd
wpt-pr: 10132
Automatic update from web-platform-testsFix resources/test (when running locally)
1. Check the HTTP port of wptserve instead of HTTPS to avoid the
unnecessary complexities of setting up SSL context (which may fail in
some environments).
2. Use exponential backoff when waiting for wptserve and specify a
maximum retry to avoid indefinite hang.
3. Use `terminate` instead of `kill` to give wptserve a chance to clean
up, which is especially useful when running locally.
WPTServe.url still returns a HTTPS URL to make sure tests that require
secure context (e.g. service workers) still work.
--
Add .tox to global .gitignore
wpt-commits: f94a28aef58d7e6fb83900aadf29d89a3c14fb73, 9dcebcba39eba001a6f4a525646712021b55a685
wpt-pr: 10127
wpt-commits: f94a28aef58d7e6fb83900aadf29d89a3c14fb73, 9dcebcba39eba001a6f4a525646712021b55a685
wpt-pr: 10127
Automatic update from web-platform-testsAdd memory of last SDP offer/answer created
This adds internal slots "LastOffer" and "LastAnswer", and uses
those to check that SetLocalDescription uses an unchanged SDP offer/answer.
Because modification of SDP is suspected to be used in a number of places,
this change only rejects SDP with modified fingerprints (which would fail
anyway), but merely counts the usage for other modifications.
Bug: chromium:823036
Change-Id: I0c978d5ff3e63b0afab3ec02334c57a5aaa94cdd
Reviewed-on: https://chromium-review.googlesource.com/966441
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545175}
wpt-commits: e48a42ff61e97e4b6fbae0f66be03d60e20b9400
wpt-pr: 10075
wpt-commits: e48a42ff61e97e4b6fbae0f66be03d60e20b9400
wpt-pr: 10075
Automatic update from web-platform-testsReject customized built-in elements in attachShadow
Element::CanAttachShadowRoot() needs to be updated because it returns wrongly true for
customized built-in elements.
The spec: https://dom.spec.whatwg.org/#dom-element-attachshadow
Bug: 823033
Change-Id: Ia9aeb47569414830f5435f37f85d96101b9fe432
Reviewed-on: https://chromium-review.googlesource.com/970142
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545026}
wpt-commits: 99914e138abbd268494757edbdb800566727179b
wpt-pr: 10106
wpt-commits: 99914e138abbd268494757edbdb800566727179b
wpt-pr: 10106
Automatic update from web-platform-testsMathML: Test italic correction of sub and super scripts attached to a large operator (#9993)
wpt-commits: 74126cb3c187c5993d16d30d4f13368a3f7dc943
wpt-pr: 9993
wpt-commits: 74126cb3c187c5993d16d30d4f13368a3f7dc943
wpt-pr: 9993
Automatic update from web-platform-testsMove KeyboardLock API methods to a 'keyboard' object
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object. We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.
KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API
Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();
New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();
Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.
BUG=680809
Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544996}
wpt-commits: 5ffa5051c36c670be1a38000de442b002920ac12
wpt-pr: 10111
wpt-commits: 5ffa5051c36c670be1a38000de442b002920ac12
wpt-pr: 10111
Automatic update from web-platform-testsWorker: Support ES Modules on DedicatedWorker behind the runtime flag
This CL supports ES Modules on DedicatedWorker behind the ModuleDedicatedWorker
flag and adds WPT tests.
With the flag, you can specify 'type' option on the constructor of
DedicatedWorker (i.e., new Worker) to start a dedicated worker as a module
script. On DedicatedWorkerGlobalScope, static import is available, but dynamic
import() hasn't been implemented yet.
Bug: 680046
Change-Id: I3aca350228ec07be7884c7a2eb8cd351e7fd6b6e
Reviewed-on: https://chromium-review.googlesource.com/967908
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544983}
wpt-commits: 1a8c195a98225c947458a5fd45606d181eaf273b
wpt-pr: 10104
wpt-commits: 1a8c195a98225c947458a5fd45606d181eaf273b
wpt-pr: 10104
Automatic update from web-platform-tests[Blobs] Correctly set mimetype of blob in FetchDataLoader.
Just creating a new BlobDataHandle doesn't actually update the mimetype
of the blob (if later the blob is requested through a blob: URL for
example), so instead actually create a new blob wrapping the existing
blob to properly change the mimetype.
Bug: none
Change-Id: I93b6d584178a02a74d68bdd6fcace1514ca90ec0
Reviewed-on: https://chromium-review.googlesource.com/967271
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544864}
wpt-commits: 3c0e03dcd57325686f7ce4b660ba0e2cdc3dd35f
wpt-pr: 10101
wpt-commits: 3c0e03dcd57325686f7ce4b660ba0e2cdc3dd35f
wpt-pr: 10101
Automatic update from web-platform-testsTest that DTMFSender rejects properly after close
This verifies that the sender throws the right error
when called after the connection closing.
Bug: chromium:822799
Change-Id: Id3ab4ddc65b1510526fa49b7bfe3f9f95a7f2d65
Reviewed-on: https://chromium-review.googlesource.com/968927
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544804}
wpt-commits: b1ef882561da6110852ba6f96f2043a24d00dcb7
wpt-pr: 10109
wpt-commits: b1ef882561da6110852ba6f96f2043a24d00dcb7
wpt-pr: 10109
Automatic update from web-platform-testsImplement scroll-snap-type: proximity
As specified in the spec, when the snap-container has scroll-snap-type:
proximity, we should only consider snap positions that are close to the
current scroll offset.
https://drafts.csswg.org/css-scroll-snap-1/#snap-strictness
Bug: 823820
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I6312f98df421e303eb538f422ede39cea8dd5d38
Reviewed-on: https://chromium-review.googlesource.com/971466
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544783}
wpt-commits: c6ed7397bed7c2df7b6033bc6c6f6dc24bb0a32e
wpt-pr: 10115
wpt-commits: c6ed7397bed7c2df7b6033bc6c6f6dc24bb0a32e
wpt-pr: 10115
Automatic update from web-platform-tests[css-grid] Fix testing-utils.js
We have been calling testGridTemplateColumnsRows() with
and without arrays.
Arrays are needed because the serialization of 2 tracks of the same size
can be "100px 100px" or "repeat(2, 100px)".
But in the rest of the cases we don't need an array,
so we call the method with a single value.
testGridTemplateColumnsRows() was not ready to support that,
and it wasn't actually checking anything in that case.
The patch modifies testing-utils.js, so it wraps values in an array
when required.
Now testGridTemplateColumnsRows() will be actually checking things.
Change-Id: I7e360677c391df74dedb474922bf5c04247141c5
Reviewed-on: https://chromium-review.googlesource.com/973063
Reviewed-by: Sergio Villar <svillar@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#544681}
wpt-commits: 535e9629904e3f24ac891763d5d24b8475df5926
wpt-pr: 10122
wpt-commits: 535e9629904e3f24ac891763d5d24b8475df5926
wpt-pr: 10122
Automatic update from web-platform-testsAttempt to fix ci_resources_unittest (#10116)
The test wasn't running against the downloaded Firefox Nightly but
system Firefox instead, which is fixed by passing the binary path to
tox (which then passes it to pytest conftest.py).
The pip requirements should be managed by tox.
wpt-commits: 47c9322f474fe123c6df2223bd93b8fd0056c6f9
wpt-pr: 10116
wpt-commits: 47c9322f474fe123c6df2223bd93b8fd0056c6f9
wpt-pr: 10116
Automatic update from web-platform-testsuser activation must survive postMessage() to call show() (#10090)
Check that we can call pr.show() in an iframe via postMessage(), which is triggered by user activation.
wpt-commits: 92885acfbbfa2ad0fe08310857379cb4c84797c0
wpt-pr: 10090
wpt-commits: 92885acfbbfa2ad0fe08310857379cb4c84797c0
wpt-pr: 10090
Automatic update from web-platform-testsExit check_stability with an error when no tests run
Similar to #10030 (which was for `wpt run`), this commit makes `wpt
check-stability` return a non-zero exit code when no tests run.
Also fix some code smells:
* `run` was redefined by `do_delayed_imports` to a different function.
Rename the other `run` method in this module to `setup_and_run`.
* `retcode` was unnecessarily defined in the top scope. Remove it to
avoid redefinition.
* `global logger` and the call to `get_parser` were extraneous in `run`
(now `setup_and_run`) and hence are removed.
--
Address comments
* Renaming `check_stability.run` breaks commands.json and naming
conventions, so rename the other `run` in that module instead.
* Only return errors for empty results when we know for sure tests are
affected.
wpt-commits: 7e214e852492e619254c14c351a85ac97661d847, 3a8328470d53c4501e31cec2775c4d33821c2275
wpt-pr: 10098
wpt-commits: 7e214e852492e619254c14c351a85ac97661d847, 3a8328470d53c4501e31cec2775c4d33821c2275
wpt-pr: 10098
Automatic update from web-platform-testsNo longer allow Chrome stability check to fail
After #10064, Chrome jobs run successfully on Travis, so we can turn the
stability check back on.
Fixes#9932.
wpt-commits: 4d10320c4970e1d8f3f64aac9fecde03ee0ae87e
wpt-pr: 10082
wpt-commits: 4d10320c4970e1d8f3f64aac9fecde03ee0ae87e
wpt-pr: 10082
Automatic update from web-platform-testsIndexed DB: Consolidate window/worker IDL tests into any.js
Also, rely on HTML and DOM interfaces for dependencies rather
than inline definitions for Event, EventTarget, etc.
Change-Id: I58ac6515f8d2769aec6bbf1b90d9a4105639ad24
Reviewed-on: https://chromium-review.googlesource.com/965452
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544429}
wpt-commits: dacfb4465c26ab8ee6e1e618671b38905b50c02e
wpt-pr: 10063
wpt-commits: dacfb4465c26ab8ee6e1e618671b38905b50c02e
wpt-pr: 10063
Automatic update from web-platform-testsReadableStream: Readable byte stream must call pull if needed after receiving new chunk (#10018)
* Fix test that allows too much pulling
* Test that byte stream pulls after enqueue
wpt-commits: 6e1b5f44943705380487dc73b96b4c959487ee4d
wpt-pr: 10018
wpt-commits: 6e1b5f44943705380487dc73b96b4c959487ee4d
wpt-pr: 10018
Automatic update from web-platform-testsCorrectly reject in-progress body methods with AbortError
Prior to this change, response body methods such as
response.body.arrayBuffer() would reject with a TypeError if the fetch
was aborted. This change makes them correctly reject with an AbortError
instead.
This implements stage #3 of the "Body Cancellation" section of the
design doc:
https://docs.google.com/document/d/1OuoCG2uiijbAwbCw9jaS7tHEO0LBO_4gMNio1ox0qlY/edit#heading=h.fvc7d7q07oio
Bug: 817687
Change-Id: Ifde322d9c22485a8ba9d14fd4ffca65c4fb4745a
Reviewed-on: https://chromium-review.googlesource.com/954765
Commit-Queue: Adam Rice <ricea@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544335}
wpt-commits: f2ae7641fad03150b4238a8b34dc9bdfdf58c0dd
wpt-pr: 10096
wpt-commits: f2ae7641fad03150b4238a8b34dc9bdfdf58c0dd
wpt-pr: 10096
Automatic update from web-platform-tests[css-typed-om] support pointer-events property
pointer-events[1] are added to support in whitelist.
there are some camelcase keywords in pointer-events.
actually pre-defined keywords are interpreted
ASCII case-insensitively[2].
so it was changed to accept camelcase keyword in tests.
and test file are also added.
[1]https://svgwg.org/svg2-draft/interact.html#PointerEventsProperty
[2]https://drafts.csswg.org/css-values-4/#keywords
Bug: 820299
Change-Id: Iccc0f88a69bbec68964ef55bcc5c471fea765ccf
Reviewed-on: https://chromium-review.googlesource.com/968581
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hwanseung@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544232}
wpt-commits: 234faac690ec3bc8bebd39ae9b2e2b3a3b05ef82
wpt-pr: 10102
wpt-commits: 234faac690ec3bc8bebd39ae9b2e2b3a3b05ef82
wpt-pr: 10102
Automatic update from web-platform-testsWeb Platform Tests: add /interfaces/webaudio.idl and corresponding test
The Web Audio tests (in /webaudio) have idlharness test on an
interface-by-interface basis, but the new hotness is to have the
IDL fragments consolidated. This also allows dependent specs to
include the master interface definitions.
Bug: 679813,697123,785409,823431
Change-Id: I60bc8415627b8b3f43c13060e4bf65f47bc17c2b
Reviewed-on: https://chromium-review.googlesource.com/965401
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544173}
wpt-commits: 3ec34e5a2c8cbeeb7fad521cce0daf923b272a92
wpt-pr: 10062
wpt-commits: 3ec34e5a2c8cbeeb7fad521cce0daf923b272a92
wpt-pr: 10062
Automatic update from web-platform-testsscroll-snap-align should specify inline and block.
Currently, we parse the two values in scroll-snap-align for x and y.
However, according to the spec,
https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-align, the two
values specify the alignment in the inline axis and block axis. This
patch renames the two values and handles the vertical writing mode for
inline and block alignments.
Bug: 821645
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I78acff0df4698b3f9c0f7443e61e3bad75379b14
Reviewed-on: https://chromium-review.googlesource.com/967890
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544055}
wpt-commits: 26677578ecdfe1c498824f2711f2211d75a0fa71
wpt-pr: 10093
wpt-commits: 26677578ecdfe1c498824f2711f2211d75a0fa71
wpt-pr: 10093
Automatic update from web-platform-testsRemove dependency on external server for background-attachment-004 (#10092)
wpt-commits: 5bb0c8321fd284fa76d8e3e00e6c97de453ee1b5
wpt-pr: 10092
wpt-commits: 5bb0c8321fd284fa76d8e3e00e6c97de453ee1b5
wpt-pr: 10092
Automatic update from web-platform-testsFix sizing of orthogonal elements with percentage margins
LayoutBox::FillAvailableMeasure() was not considering the case of
orthogonal elements when computing the margins.
The margins ended up being properly calculated but the size of
the orthogonal elements was wrong, as they considered
to have more or less space than the available one.
The method is modified in order to use
the containing block inline size in order to resolve the percentages:
https://www.w3.org/TR/css-writing-modes-3/#dimension-mapping
BUG=808758
TEST=external/wpt/css/css-writing-modes/sizing-orthogonal-percentage-margin-00*.html
Change-Id: Ib8c81dcd14589b3fefe806de3f8f75c000b1cac9
Reviewed-on: https://chromium-review.googlesource.com/968522
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544047}
wpt-commits: 69cee83aeab7142e282fc2350846e677b5aebe08
wpt-pr: 10091
wpt-commits: 69cee83aeab7142e282fc2350846e677b5aebe08
wpt-pr: 10091
Automatic update from web-platform-testsFix a typo in a resource file name (#9986) (#10077)
wpt-commits: 5dee619315f5803008443f9bc51536e6be890e5c
wpt-pr: 10077
wpt-commits: 5dee619315f5803008443f9bc51536e6be890e5c
wpt-pr: 10077
Automatic update from web-platform-testsImprove wpt testing on OffscreenCanvas convertToBlob
Same as canvas.toBlob(), the OffscreenCanvas.convertToBlob() are running on
idle tasks by default. When idle tasks do not begin for a long time, they force
encoding on the current thread. As idle tasks are not enabled on layout tests
unless "--enable-threaded-compositing" flag is turned on, we therefore do both
virtual and non-virtual tests to ensure complete test coverage of both
execution paths--idle-task mode and force-encoding mode. The non-virtual tests
need to be marked as [Slow] as the CanvasAsyncBlobCreator is waiting for the
idle tasks for a threshold time before switching to force-encoding mode.
Bug: 817091
Change-Id: I2c7da9e27ee2d24e1a5e6ee1c36597b46f052aca
Reviewed-on: https://chromium-review.googlesource.com/964395
Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544036}
wpt-commits: 919015df88121d50623584f5dd02986721dbc3ab
wpt-pr: 10051
wpt-commits: 919015df88121d50623584f5dd02986721dbc3ab
wpt-pr: 10051
--HG--
rename : testing/web-platform/tests/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.html => testing/web-platform/tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.html
rename : testing/web-platform/tests/offscreen-canvas/the-offscreen-canvas/offscreencanvas.convert.to.blob.w.html => testing/web-platform/tests/offscreen-canvas/convert-to-blob/offscreencanvas.convert.to.blob.w.html
Automatic update from web-platform-tests[css-typed-om] Add support for min/max-width/height.
Add support & tests for (min/max)-(width/height).
Note that the typed om spec specifies the old specs for these properties:
https://drafts.csswg.org/css21/visudet.html
Bug: 820299
Change-Id: I9c65f7f24d84b83ea2e2f167f8fb86be967eff06
Reviewed-on: https://chromium-review.googlesource.com/968003
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543980}
wpt-commits: 918f9684ec3846ac5bf588678dbdde6d58e22fc8
wpt-pr: 10087
wpt-commits: 918f9684ec3846ac5bf588678dbdde6d58e22fc8
wpt-pr: 10087
Automatic update from web-platform-tests[css-typed-om] Add support for motion path properties.
This patch adds support for motion path properties. We had to modify
the computed style computation for <position> values. Previously, we
parse a <position> value as a CSSValuePair, but compute them to a
CSSValueList containing two items. This is very strange, so we just
compute to a CSSValuePair. Since both serialize to the same string,
this has no behavioural changes on CSSOM.
Bug: 820299
Change-Id: I2131055dad0785eb47ea2d2d89f00229f4376bae
Reviewed-on: https://chromium-review.googlesource.com/967915
Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543975}
wpt-commits: 1f80be4604d9c5d3f68caa6221080027435f4002
wpt-pr: 10086
wpt-commits: 1f80be4604d9c5d3f68caa6221080027435f4002
wpt-pr: 10086
Boris Zbarsky
Cameron McCormack
Adam Rice
Darren Shen
Ovidio Henriquez
Chris Nardi
Domenic Denicola
Lukasz Anforowicz
Joshua Bell
Manuel Rego Casasnovas
Kent Tamura
Chris Nardi
Tsuyoshi Horo
Chris Lilley
kaixinjxq
Eric Holk
Luke Bjerring
Tom Anderson
moz-wptsync-bot
Luke Bjerring
Florian Rivoal
François Doray
Dave Tapuska
Henrik Boström
Philip Jägenstedt
Kenichi Ishibashi
Zhuoyu Qian
Brian Burg
Ian Kilpatrick
jgraham
Rouslan Solomakhin
Anne van Kesteren
Hayato Ito
Kriti Singh
Hwanseung Lee
Kinuko Yasuda
Hiroki Nakagawa
Stephen McGruer
Rune Lillesveen
Ben Wells
Robert Ma
fantasai
Josh Matthews
Morten Stenshorne
Chandan Padhi
Robert Ma
youennf
Blink WPT Bot
Ahilya Sinha
Sergio Villar Senin
Michael[tm] Smith
Marcos Cáceres
Xianzhu Wang
Harald Alvestrand
Frédéric Wang
Joe Downing
Yoshifumi Inoue
Nicolás Peña
Marijn Kruisselbrink
Sandra Sun
Chris Harrelson
Wanming Lin
Mattias Buelens
Eric Willigers
Geoffrey Sneddon
xlai
Mariana Meireles