This patch creates a copy of the GeckoAppBase style in v21/themes.xml and removes
the custom icons for copy, cut and paste we use on v11+. Instead the system icons,
that match the look&feel of the ActionBar, will be used.
--HG--
extra : commitid : bb07iANzjF
extra : rebase_source : 3b057830c78f5cac1361474d3c60eeaf86eda1d6
extra : amend_source : 86e0168b47967e3e66cd36b151b33ccefd2e2af7
To do this, I ran:
convert <image> -alpha extract -alpha on <image>
The resultant images were slightly larger than their previous
counterparts so I then compressed them with ImageOptim.
--HG--
extra : commitid : KJ2wVCoGpWp
extra : rebase_source : c53cf14e32c8904e2ed2403f32bc8cb87245c465
DONTBUILD NPOTB
This adds a pass-thru |mach android| command. It's just here to make
it easier to add and remove Android SDK packages: since most folks
don't have the Android tools on their PATH, this saves them having to
root through the object directory to find the path to the tool.
--HG--
extra : commitid : HgCtltLK3V4
extra : rebase_source : 6c7db25c10b643c8fe655976e613c29db7cd0bc4
extra : histedit_source : fd95eb809a901fd3873968117c60966f3f82790c
DONTBUILD NPOTB
Straight from http://stackoverflow.com/a/24751182 and the linked
IntelliJ tickets.
--HG--
extra : commitid : AcbSF0042KW
extra : rebase_source : f67e9eecfdf3f452e4fd55901f8eb42b0f3ed22c
Other 3-dot menu button locations to follow.
I tested that the colors are correct in the various states (e.g. private
browsing).
This patch additionally:
* Restructured the menu button (which allowed the removal of a setVisibility
call
* Removed the now unused tablet assets.
--HG--
extra : commitid : 5AzCA3B3KHo
extra : rebase_source : b2ba9b4052cf94f8af4c4cb39b3f5f1f250d3b17
And replace the older assets.
These are the 36dp icons from Google's material design page:
https://www.google.com/design/icons/#ic_more_vert
Then we trim off the whitespace with image magick:
convert icon.png -trim out.png
And compress with ImageOptim.
--HG--
extra : commitid : 2KxoyvO50be
extra : rebase_source : 23535bb72fa7cc99f9e6a9b1efbf9e4c3f3a84f0
This also involved moving a redundant background declaration to only the
containing style.
--HG--
rename : mobile/android/base/resources/drawable/action_bar_button.xml => mobile/android/base/resources/drawable/menu_item_action_bar_bg.xml
extra : commitid : GFUgNsiZgGb
extra : rebase_source : 4a3c03b50f923e50bf99effea9b9d34813adb40b
These appear to have been added in the initial implementation of this feature.
--HG--
extra : commitid : KIlolzsFEyi
extra : rebase_source : 0351ba974ed6624c6f767146a39443f5704a57ab
On Gingerbread devices (Android API 9 or 10) the ViewHelper.setTranslationY code
doesn't work to move the SurfaceView. In order to acheive that effect I turned
LayerView into a ScrollView with a dummy element at the top, and allow it to
scroll. This allows the SurfaceView to move as desired. A few places in the code
were assuming that the LayerView and SurfaceView were always at the same screen
location (which was true before but not any more) and so those sites needed
some updating as well.
--HG--
extra : commitid : Jpr1k74MOAD
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
The annotated methods were using @JNITarget, which would do the same thing.
However, @ReflectionTarget is clearer (like a good variable name).
proguard.cfg states a class with an annotated member will be kept so we
shouldn't need to worry about not being able to retrieve the class via
reflection.
--HG--
extra : commitid : 9ji4YNIP4GE
extra : rebase_source : 780f1d1dd4fcc95545152d19896db0a376f38d48
This is a clone of @JNITarget and @RobocopTarget.
--HG--
extra : commitid : AhiQ1OmtCY0
extra : rebase_source : 6fb3880e2368a163292b968084991ca965a12211
extra : source : 62dbceeb9f18238ed2725564db03a2a2c6491f94
I previously set this for tablet but didn't (for an unknown reason) set this
for phones as well.
--HG--
rename : mobile/android/base/resources/color-large-v11/action_bar_secondary_menu_item_colors.xml => mobile/android/base/resources/color/action_bar_secondary_menu_item_colors.xml
extra : commitid : 9xV13qVkTCr
extra : rebase_source : f5c310d1ac68096be557a8992ba366bb0c99df0a
This doesn't appear in Fennec builds and I don't know which web apps "quit"
could appear in so I didn't test this in a web app. I can confirm no issues
with a typical Fennec build, however.
--HG--
extra : commitid : LbNepxFEs3P
extra : rebase_source : 687af1c7750c4fb0f3c866dfcaae8291494e146c
This also removes code to set an icon from an addon, which is unused because,
afaik, addons' icons are also hidden. iirc, there was a bug open on whether we
want addons to be able to show icons (e.g. could be used to show status), but
we can reimplement this if that bug is ever decided.
I was not able to test this with an addon that sets an icon but I did test that
the application did not crash with no addons installed.
--HG--
extra : commitid : BI54BWOip3Y
extra : rebase_source : d170349006588ebcecab4817bb5d3388467106e7
On GB devices, ic_menu_new_*tab is in the base menu, unlike the other
configurations, so it stayed on GB.
More complex removals to follow.
I tested this by clicking on all of the base menu items on a Lollipop phone,
KitKat large tablet, and a GB phone.
--HG--
extra : commitid : EBgTEO7y9qt
extra : rebase_source : 30c880c2d36c5f5336af50a5460f3bb1d6578117
Moving speculative connection from CLH to GeckoApp allows us to start
the speculative connection very early in the startup process rather
than later in startup.
One thing we do in the Fennec CLH is to make a speculative connection
based on the URI that's passed in. However, by the time the CLH runs,
we're far along into startup, and the advantage of a speculative
connection is reduced. This patch implements making speculative
connection as a method in GeckoThread, so that Fennec can make a
speculative connection without relying on the Fennec CLH.
Many Gecko operations depend on the profile being available. This
patch adds a PROFILE_READY Gecko state so that we can queue calls
until profile is loaded.
Many calls are associated with a Gecko state when they become available.
For example, calls that only depend on XPCOM become available very early
in startup, at the JNI_READY state. However, calls that depend on JS
components may only be available at the end of startup, at the RUNNING
state.
This patch adds an available state to every queued call, so that calls
can be made as soon as they become available, which is important for
calls like making speculative connections.
The enabled/disabled colors are set via ColorStateLists so the alpha
is unnecessary.
--HG--
extra : commitid : 3u4xoGQlD3E
extra : rebase_source : 0b9868ed14ad54d8de17f2b4cd12185b78e1c22a
This patch has a side effect of changing the color of the forward
button as it animates forward and back, but it's minimal enough
that I'm okay with it, and it cleans up disabled/private state color
management (particularly after the following patch).
--HG--
extra : commitid : B1r30FDcCZv
extra : rebase_source : 1107016d428ac01c6331048b415736b79c634529
Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Additionally, fix a bug about using android:tint when drawableTintList was not
used.
--HG--
extra : commitid : AZiAsNQkD4c
extra : rebase_source : c54b361b27aa6b7d14c030409ad86531a9516549
Sebastian Kaspari
Margaret Leibovic
Michael Comella
Nick Alexander
Ryan VanderMeulen
Allison Naaktgeboren
Fabrice Desré
Mark Finkle
Martyn Haigh
Kartikaya Gupta
Garvan Keeley
vivek
Carsten "Tomcat" Book
dominique vincent
Mantaroh Yoshinaga
Myk Melez
Gian-Carlo Pascutto
Nicholas Nethercote
Geoff Brown
Ahmed Khalil
Chenxia Liu
Justin Inouye
Yury Delendik
James Willcox
Jim Chen