Remove the intern_types module in favor of the associated Internable types that we already have.
The only bit of magic I had to do is around serialization bounds, and it's nicely isolated.
Differential Revision: https://phabricator.services.mozilla.com/D21797
--HG--
extra : moz-landing-system : lando
File logging can be turned on by setting `app.update.log.file=true`. It will log update messages that would normally go to the browser console (assuming `app.update.log==true`) to a file in the user profile directory called "update_messages.log". File logging will last for a single Firefox session only before it automatically disables itself.
The goal of this is to make it easier to get troubleshooting/debugging information from users that might complain of update problems. This will be especially important when upcoming changes are made to the update mechanism.
Differential Revision: https://phabricator.services.mozilla.com/D19422
--HG--
extra : moz-landing-system : lando
nsIconChannel (for moz-icon:// images) is unsound, see bug 1438939.
nsMenuPopupFrame::Init is also unsound on mac, looks like...
I'll try to get them fixed on trunk, but it's not worth crashing release for
this IMO, given it's pre-existing. The assert in PresShell::~PresShell hopefully
avoids exploitable issues.
Differential Revision: https://phabricator.services.mozilla.com/D20945
--HG--
extra : moz-landing-system : lando
urlExtraReferrer could be null, we should check before dereference. Otherwise
it will cause crash when webrender is enabled by gfx.webrender.enabled=true
and gfx.webrender.all=true,
Differential Revision: https://phabricator.services.mozilla.com/D20805
--HG--
extra : moz-landing-system : lando
When the event is not handled with coordinates and there is no frame for
`mPresShell`, `PresShell::EventHandler::HandleEvent()` handles the events
simpler than the case there is a frame. Therefore, this patch moves the
`else` block of `if (aFrame)` and reduce the indent of `if (aFrame)` case.
Differential Revision: https://phabricator.services.mozilla.com/D21194
--HG--
extra : moz-landing-system : lando
This was specialised so that it wouldn't crash on mobile wouldn't crash
when: SubChunkLimit + SubChunkStepstep > NurseryChunkUsableSize becase
NurseryChunkUsableSize is smaller on mobile.
However Bug 1530575 reduced the value of SubChunkStep so now we no-longer
need to specialise SubChunkLimit. We never tested the impact of
SubChunkLimit on mobile so it's just simpler to have one value.
Differential Revision: https://phabricator.services.mozilla.com/D21645
--HG--
extra : moz-landing-system : lando
If no extension controls the settings, ExtensionSettings may not be initialized on startup. Fall back to the defaults in that case.
Differential Revision: https://phabricator.services.mozilla.com/D21866
--HG--
extra : moz-landing-system : lando
mDomain in MatchPattern is inconsistent with nsIURI for IPv6 URL, which causes
failure of IPv6 matching. We normalize mDomain by droping the brackets so that
it's consistent with nsIURI.
Differential Revision: https://phabricator.services.mozilla.com/D20603
--HG--
extra : moz-landing-system : lando
This may or may not be part of the plan to get rid of nsCSSValue ;)
Option is not usable via FFI, and they should not be needed (we should be
following the shortest serialization principle instead). These patches also do
that, which matches the other transform properties. I think that slight change
is fine, if we can make it work, and consistent with other properties.
Alternative is adding more TransformOperation variants or such, which I rather
not do.
Differential Revision: https://phabricator.services.mozilla.com/D21862
--HG--
extra : moz-landing-system : lando
Otherwise, deriving ToComputedValue and ToAnimatedValue in structs or enums with
other where clauses just doesn't work.
Differential Revision: https://phabricator.services.mozilla.com/D21859
--HG--
extra : moz-landing-system : lando
word-spacing is still using the old Gecko computed style storage, which means
that it has a little bit of precision loss that I just fixed for stroke-width.
As it turns out we need this to avoid losing precision both during painting and
during serialization.
This patch also changes to serialize `context-value` if it's the computed value.
I could keep the previous behavior, but it makes no sense to serialize the
initial value. We're the only ones to support this value anyway, and I couldn't
find a definition or spec for this.
Also update tests and expectations for:
* New unexpected passes.
* Always serializing the unit in getComputedStyle.
* Calc and interpolation support.
Chrome also always serializes the unit in getComputedStyle, so I'm pretty sure
this is compatible with them. Chrome is inconsistent and keeps numbers in
specified style, but that's inconsistent with itself and with other quirky
lengths, so I updated the tests instead.
Differential Revision: https://phabricator.services.mozilla.com/D21819
Instead of storing them as LengthPercentage | Number, always store as
LengthPercentage, and use the unitless length quirk to parse numbers instead.
Further cleanups to use the rust representation can happen as a followup, which
will also get rid of the boolean argument (since we can poke at the rust length
itself). That's why I didn't bother to convert it to an enum class yet.
Differential Revision: https://phabricator.services.mozilla.com/D21804
Mark the about:compat process script as intermittently loaded in browser/base/content/test/performance/browser_startup_content.js
Differential Revision: https://phabricator.services.mozilla.com/D21316
--HG--
extra : moz-landing-system : lando
Coroiu Cristina
phoenixabhishek
ffxbld
Daniel Varga
bomisore
Jan de Mooij
James Teh
Bogdan Tara
Dzmitry Malyshau
Kirk Steuber
Emilio Cobos Álvarez
violet
Masayuki Nakano
Paul Bone
Gurzau Raul
Shane Caraveo
Brian Hackett
rdalal
Hiroyuki Ikezoe
Ryan VanderMeulen
Mark Banner
Jeff Muizelaar
Cosmin Sabou
Thomas Wisniewski
Olli Pettay
Kai Engert
championshuttler
Razvan Maries
Jon Coppeard
Manish Goregaokar