MozTrees persist column ordering using the XUL persist="ordinal" attribute. This patch synchronizes MozTree with that old mechanism to restore the ability to save and restore column ordering. Because the persist data will be stored in the same place as before, this should prevent people from losing their column ordering data without requiring data migration.
Differential Revision: https://phabricator.services.mozilla.com/D59763
--HG--
extra : rebase_source : 0474619cb817263d7a56b970c44cf8987d719355
extra : histedit_source : d8ed787170f5dd3ac6e19bf318e1a69c9ad0eac5
This removes nsTreeColumns::RestoreNaturalOrder, which requires the ordinal attribute to function. It only has one consumer: toolkit/content/widgets/tree.js. The call is removed from that consumer in this patch. This will break column ordering in MozTree's, which is fixed by a later changeset in this stack.
Differential Revision: https://phabricator.services.mozilla.com/D59761
--HG--
extra : rebase_source : 88c0b1dda44dc64eedbb73f7902e6cc61faeee1b
Automatic update from web-platform-tests
Make it clear that event handler callbacks require wrapping in promise_test
--
wpt-commits: e78c95ebf1cce550e9b7e55b281d4c10e9b99d48
wpt-pr: 21269
Automatic update from web-platform-tests
COOP: remove popup-meta-http-equiv.https.html.headers
This file was accidentally added in #20874.
The test was added in #20875 but it should not have a .headers file
since it's testing that `<meta>` has no effect.
--
wpt-commits: 7b1a0f47811c8e4899072296b8c88af5c1986c6b
wpt-pr: 21268
Automatic update from web-platform-tests
[LayoutNG] Remove IsIntermediateLayout flag.
Previously if we synthesized the min/max sizes by performing a layout
on the orthogonal subtree - we could end up in a situation where the
"DCHECK(!constraint_space.IsIntermediateLayout() || box_->NeedsLayout())"
was hit.
This was caused by a legacy layout fieldset needing a preferred widths
recalc.
This is an indirect fix for the below DCHECK bug. Removing the
IsIntermediateLayout flags means that we now perform a copy back when
we are in this (relatively rare) phase.
The IsIntermediateLayout was initially introduced as a performance
optimization - however it could also hurt performance if we perform
a correct layout of a subtree with a fixed size.
(we'd need to layout that sub-tree twice, getting exactly the same
layout result).
Bug: 1039241
Change-Id: I468a9c8e26b5e7855a72ddb2b1f2614538cedd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007422
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733344}
--
wpt-commits: 676c9d957b75188553d3dfd75b7c19856561e773
wpt-pr: 21259
Automatic update from web-platform-tests
[Trusted Types] Implement require-trusted-types-for
This CL separates 'require-trusted-types-for' from 'trusted-typs'
Content Security Policy directive, which currently has only one injection
sink 'script'.
https://w3c.github.io/webappsec-trusted-types/dist/spec/#require-trusted-types-for-csp-directive
Bug: 1030257
Change-Id: I1c241c5b6be318aa195323178cf974df138d5788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993351
Commit-Queue: Yifan Luo <lyf@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732848}
--
wpt-commits: b302c6dcdad515be7a446ee05cfda1027805226b
wpt-pr: 21133
--HG--
rename : testing/web-platform/tests/trusted-types/default-policy-report-only.tentative.html.headers => testing/web-platform/tests/trusted-types/no-require-trusted-types-for-report-only.tentative.html.headers
Automatic update from web-platform-tests
Sort the registrations returned by getRegistrations() by registration ID. (#21046)
This patch makes the order of the registrations returned by
getRegistrations() be sorted by registration ID, which fixes the flaky
test of getregistrations.https.html. Related Github issue is in
https://github.com/w3c/ServiceWorker/issues/1465
Bug: 925740
Change-Id: Iaa5716eec886232df61bd23487fbae5c63413e9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984900
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Wei4 Wang <wei4.wang@intel.com>
Cr-Commit-Position: refs/heads/master@{#732749}
Co-authored-by: WangW_intel <54053982+wangw-1991@users.noreply.github.com>
--
wpt-commits: 3b8990ef1b99135ad02f13b3389049921054c88f
wpt-pr: 21046
Automatic update from web-platform-tests
Relax expectations for fuzzy matches on Chrome on MacOS
We've been unable to reproduce, but on the bots these tests are
reporting a 254 channel difference rather than 255. It has been holding
up infrastructure changes and is a minor enough difference that we're
just going to accept the delta.
--
wpt-commits: 2f4e0f978f626ac74bb8b75574c240f023f0ab25
wpt-pr: 21221
Automatic update from web-platform-tests
Enable Scroll To Text by default (#19634)
Enables scroll to text by default for M81. Note we plan to launch via
Finch for M80.
Intent to ship with LGTMs:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ
This patch also updates web platform test expectations:
- scroll-to-text-fragment.html now passes; it just needed an extra rAF
for the fallback to element anchor behavior.
- scroll-to-text-fragment-security.html has two expected failures, as
they need to be updated to test cross-origin navigations. I'll make
this change in a follow-up patch to close bug 1042311.
Bug: 919204
Change-Id: Ic2d563934cd9406fb335904a94c390bba789e0b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838701
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732592}
Co-authored-by: Nick Burris <nburris@chromium.org>
--
wpt-commits: 91ae81eb86ffffeed3abee0f45ccfcd3f82750ef
wpt-pr: 19634
Automatic update from web-platform-tests
SharedWorker: Add static import with 'module' type for SharedWorker (#21229)
This CL implements static import for module script.
The feature is still behind the flag.
This CL also adds SharedWorker with type 'module' Web Platform Tests.
Dynamic import is not yet supported, so WPTs which include dyamic import
is expected to fail.
Bug: 824646
Change-Id: I3b4a239f392736d226a736c011e3f5eb0a3e0d78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006995
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733304}
--
wpt-commits: d516f2d97890cb217d2436f0b45cd00c837e1260
wpt-pr: 21229
Automatic update from web-platform-tests
Implement performance.measureMemory with per-frame sizes
This uses a new v8::Isolate::MeasureMemory API to compute the JS memory
footprint of each v8::Context that has the same security origin and
the same JS agent as the calling context does.
The V8 API takes a delegate with two methods that are implemented here:
1) ShouldMeasure(context) for selecting the contexts to measure.
It fetches the security origin and the JS agent of a context by
going through Context => ExecutionContext.
2) MeasurementComplete(context_sizes, unattributed_size) is called by
V8 when the measurement is done. The function constructs an object
representing the result and resolves the promise with it.
# Disable audit_non_blink_usage std::vector check per reviewer's comment
NOPRESUBMIT=True
Bug: 973627
Change-Id: Ibd0fb3463978184f1d467be306063d1f40105fda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986795
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733300}
--
wpt-commits: 8ce3c82fb7f762b60e37918d56c7c99bfe4dde76
wpt-pr: 21196
Automatic update from web-platform-tests
Don't stop text-decoration-propagation in general for UA shadows.
We used to stop propagation of text-decoration into elements rendered
with UA shadow trees in general. Instead we should list the specific
cases where we need to do this. This is currently for media elements
which has a special rendering where the media controls do not use a
proper containing block model.
This fixes text-decoration propagation for elements like, summary,
details, object, and marquee.
TEST=fast/table/backgr_layers-opacity.html
TEST=fast/table/backgr_layers-opacity-collapsed-border.html
TEST=media/controls-styling.html
Bug: 1042760
Change-Id: Ice2681e4ac93b1a96ec598bcb614b6a8f57e0b21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007629
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733271}
--
wpt-commits: e04da38398be2b6655d044fd3ba3e4bd25a0ba42
wpt-pr: 21231
Automatic update from web-platform-tests
Add tests for baseline, stretchiness and spacing in unknown elements. (#21257)
See https://github.com/mathml-refresh/mathml/issues/139
This also fixes wrong mpadded@notation attribute and repeats spacing tests
for other mrow-like elements.
--
wpt-commits: 87646d626a9a84941e790da383f140df6b37279d
wpt-pr: 21257
Automatic update from web-platform-tests
Relax feature-detection for <menclose> (#21256)
Discussion is still open: https://github.com/mathml-refresh/mathml/issues/105
so let's only check some minimal <mrow> support.
Igalia does not plan to implement this element in Chromium for now so
making detection too strict is causing test failures.
--
wpt-commits: ee2b3c3d8740dcfccf6d6a0c5a371335dd198654
wpt-pr: 21256
Automatic update from web-platform-tests
Enforce character restrictions for registerProtocolHandler scheme
Schemes that begin with the prefix "web+" must contain one or more ASCII
lower alphas, forbidding other characters. Chrome previously allowed any
character otherwise valid in URI schemes. Now, it matches the HTML5 spec
(https://html.spec.whatwg.org/#custom-handlers) and Firefox.
Bug: 1019995
Change-Id: Id1b86eb75ca2159fc6b2c2bd1b96adac6ba494c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009825
Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com>
Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733234}
--
wpt-commits: d7faaa65a15ef351c882e1b457ecee7070ea24c6
wpt-pr: 21252
Automatic update from web-platform-tests
Limit inline negative margin quirks only when line overflows
crbug.com/979894 and crbug.com/1011816 revealed that, boxes
with inline negative margins can be put back to the line even
if they appear beyond the end margin. The behavior is not
defined in the spec, but supported because all browsers do it
and there are good amount of sites relying on the behavior.
The special behavior, however, turned out that it should
apply only when the line overflows.
As described in fixes for the above issues, this behavior is
not well-defined, not really interoperable, and sometimes
the result of combinations of bugs. This patch takes the parts
of observable behaviors that are interoperable and reasonable,
while fixes the reported page.
Bug: 1040461
Change-Id: I3e4883220645a59dd3c33bdad4116f200fc4208d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000412
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733154}
--
wpt-commits: 2f346208c2a115a601b580e7869fe112b97c4246
wpt-pr: 21239
Automatic update from web-platform-tests
[TableNG] Fix table's box sizing in UA stylesheet
Table width is treated as border-box width, but UA does not specify box-sizing,
so it defaults to content-box. This fixes it.
The fix required rebaseline of several tests.
The only "not clearly better" difference is %ge resolution block
size for captions. Old code resolved against table's border-box size,
new code resolves against content-box size.
FF/Edge/Legacy all disagree on what is the correct answer.
Filed a spec issue, hope to match FF.
https://github.com/w3c/csswg-drafts/issues/4676
Rebaseline details:
Better, passing more tests.
.../tables/table-ua-stylesheet-expected.txt | 2 +-
Test depended on table's default box-sizing being content-box. Made
table's box sizing explicit for the test.
.../web_tests/fast/borders/border-image-fill-no-border.html | 3 +
Better. Was testing old bad behavior. Fixed up test also passes in FF.
.../fast/table/min-width-html-block-table-expected.txt | 120 ++++++++++++++--------------
.../fast/table/min-width-html-inline-table-expected.txt | 120 ++++++++++++++--------------
.../web_tests/fast/table/script-tests/min-width-helpers.js | 30 +++----
Better. Table's absolute position was incorrect. Correct now.
.../platform/linux/tables/mozilla/bugs/bug145572-expected.png | Bin 4239 -> 4238 bytes
Not better, just different. Different sizes are used to resolve caption
percentage heights.
.../mozilla_expected_failures/bugs/bug3166-14-expected.png | Bin 4477 -> 4477 bytes
.../mozilla_expected_failures/bugs/bug3166-17-expected.png | Bin 4446 -> 4444 bytes
Bug: 423997
Change-Id: I8e090390970a637713a9e1d4b62dc55114fd944b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003810
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733115}
--
wpt-commits: e671d58951e69df89c05fb3eb2a361be3303aa38
wpt-pr: 21225
Automatic update from web-platform-tests
Add test case to WebXR WPTs - XRFrame.getPose & getViewerPose are equal
This adds a new test case that should ensure that
`frame.getViewerPose(refSpace)` matches the pose returned by
`frame.getPose(viewerSpace, refSpace)`.
Change-Id: I0836649ed4911d714a6319bddc83f01ca3d8dd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008133
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733050}
--
wpt-commits: 248560faff74c9e8b4cc811b126e0833783d09d9
wpt-pr: 21244
Automatic update from web-platform-tests
Don't override background-images for atomic inlines in forced colors
In a previous change, we had ignored background images for all inlines
to prevent background images from being painted on top of the
readability backplate in forced colors mode.
https://chromium-review.googlesource.com/c/chromium/src/+/1757685
However, it turns out that atomic inlines paint their backgrounds
before the backplate is painted. As such, we do not want to ignore
background images for these inlines in forced colors mode.
Bug: 970285
Change-Id: Iee2463775e67a1661cbb85f0a51b5bb8f01566cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998976
Commit-Queue: Alison Maher <almaher@microsoft.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733014}
--
wpt-commits: 4e55a63338592a8fa6a505aa7feb5967874e64e6
wpt-pr: 21198
Automatic update from web-platform-tests
Add WebGPU CTS to DEPS, and roll it using the new tools
This brings WebGPU CTS into DEPS, and rolls the WPT copy to the same
version.
The new tools are NOT in this patch, and will land after this, in:
https://chromium-review.googlesource.com/c/chromium/src/+/1919211
Bug: dawn:323 # for added expectations
Change-Id: I334c51cc3b0a8473c77c486ea6293ba0500d4ba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996140
Auto-Submit: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#733000}
--
wpt-commits: 2032e1c975f70239680936ba812f7d40db45061a
wpt-pr: 21138
Automatic update from web-platform-tests
Portals: Make HTMLPortalElement keyboard focusable
Also simulates a click when clicking enter/space when a portal is
focused (similar to buttons).
Bug: 1043127
Change-Id: I0b1a35cd978c191a958dea0ed47bf737cac7292f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995940
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732989}
--
wpt-commits: cef0f785d29fdc0df093f4551c4759ab00d1b0bf
wpt-pr: 21233
Automatic update from web-platform-tests
Schedule frame for scroll linked animations only when scrolling changes
Scheduling frame for scroll linked animations regardless of the scroller
updates makes scroll animations inefficient. This change schedules next
frame only when scroll timeline current time changes. The change
assumes that animation timeline scheduling runs (via
DocumentAnimations::UpdateAnimations) at the end of any frame in which
scroll timeline (i.e. its offset, range, overflow) is invalidated.
Bug: 1039750
Change-Id: Ib87a298e6d09cbeb85276cea4c165022b76f3732
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990003
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732987}
--
wpt-commits: faf0b980eab5b7b9277937e8fdd79e282215faea
wpt-pr: 21092
Automatic update from web-platform-tests
CL followup - run ESLint, throw from math helper
- ran ESLint on webxr-test.js and xr-internal-device-mocking.js
- xr-internal-device-mocking.js now stores the
`MockRuntime._injectAdditionalFrameData()` before overwriting it with
its own implementation, and calls the original implementation as the
first step
- throw instead of console.warn when math helper encounters unexpected
combinations of .w component
Changes:
Change-Id: I94c015b5c89cfbc0e1a4b90db6ec44a198f4ce05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008073
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732977}
--
wpt-commits: b9607ef83f80ba7898def5f60c76c3e47ec9576f
wpt-pr: 21243
Automatic update from web-platform-tests
[ScrollSnap] Invalidate SnapContainer when applying transform to target
This is a follow-up patch of crrev.com/c/1962567 to support transform
inducing resnapping.
Bug: 1028316
Change-Id: Ie1ae2f088919665c6ddfbf3d8a9dce119d066f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008061
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732965}
--
wpt-commits: e2643469fd5a9c370f6d5df73f601a14b0abab1b
wpt-pr: 21241
Automatic update from web-platform-tests
Deflake WPT test: required_csp-header.html
This test is navigating 14*7 = 70 iframes in parallel. This is a lot! We
need to increase the WPT test timeout to make it work without exceeding
it.
Bug: 818324
Change-Id: I80aa2f74e41957e35b5490a9d57dcfccd2ac011f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007416
Commit-Queue: Camille Lamy <clamy@chromium.org>
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732895}
--
wpt-commits: 53e8914b40d9a9e41c12e07fbb34304f128833ca
wpt-pr: 21238
Automatic update from web-platform-tests
Deflake CSP object-src-url*-allowed.html
Reenable the tests. They have probably been fixed by:
https://chromium-review.googlesource.com/c/chromium/src/+/1995261
Remove attribute "async defer" to the <script>. It delays the script execution
for no reasons and might also cause it to fail.
Improve coding style along the way.
Bug: 1039643, 1039642
Change-Id: I8e4667a455d96f03f3f2d99e229f529ec5d70153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007732
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732890}
--
wpt-commits: d61f8dfcd7a6e768fa9874b261ead4c02b338da2
wpt-pr: 21234
Automatic update from web-platform-tests
Fix valueMissing() for immutable text-mode inputs
Prior to this commit, valueMissing() incorrectly returned true for
text-mode inputs that were readonly or disabled. With this CL, this
situation is fixed.
Fixed: 1039149
Change-Id: I0f3d9b5c00e7c4e9e8fa0a9767119a2ab5d6b01f
Bug: 1039149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003637
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732686}
--
wpt-commits: a2dbc7c6cef42d2a272ebfb07bfb6f42da387cc1
wpt-pr: 21211
Simon Giesecke
Emilio Cobos Álvarez
Kirk Steuber
moz-wptsync-bot
Anne van Kesteren
James Graham
Simon Pieters
Ian Kilpatrick
Pâris MEULEMAN
Yifan Luo
Blink WPT Bot
Stephen McGruer
Ulan Degenbaev
Mustapha Jaber
Rune Lillesveen
Frédéric Wang
Eric Lawrence
Koji Ishii
Ayu Ishii
Aleks Totic
Piotr Bialecki
Alison Maher
Kai Ninomiya
Adithya Srinivasan
Olga Gerchikov
Yi Gu
arthursonzogni
Eldar Rello
_Ros_
Mason Freed