-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.
There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.
Differential Revision: https://phabricator.services.mozilla.com/D132289
Keeping the pref as signed, since the existing code explicitly handles that case, so someone may have -1 as the pref value.
Differential Revision: https://phabricator.services.mozilla.com/D132020
1. When we see a failed TRR lookup in nsHostResolver::CompleteLookup, we trigger
a Confirmation and retry the lookup.
2. When triggering Confirmation, we set LOAD_FRESH_CONNECTION on the TRR channel,
which will then tell the connection manager to clear out the current TRR conneection.
This will cause us to use a new connection for the Confirmation and subsequent
lookups.
Differential Revision: https://phabricator.services.mozilla.com/D129227
Keeping the pref as signed, since the existing code explicitly handles that case, so someone may have -1 as the pref value.
Differential Revision: https://phabricator.services.mozilla.com/D132020
It's only meaningfully read in two places:
* WebRender fallback code.
* Some widget DEBUG-only code, which on Linux is ifdef'd and on Windows does
some rather sketchy things like sleeping for 30ms
So I think it should be ok to remove, since WR fallback has its own flashing
pref as well, IIUC.
Differential Revision: https://phabricator.services.mozilla.com/D132313
`CreateElementTransaction` is too similar to `InsertNodeTransaction`. Only the
difference is, CreateElementTransaction::DoTransaction() creates an element via
editor instance and marks it dirty before inserting the new element. E.g.,
selection management and whether inserting new node or not at "redo" are same.
So, for the maintenance cost reason, we should get rid of
`CreateElementTransaction`, but for now, we should just make `HTMLEditor` use
`InsertNodeTransaction` instead, with a new pref to make it possible to back it
out the new behavior even after shipping.
Differential Revision: https://phabricator.services.mozilla.com/D132119
It is helpful if window visibility state could be checked by debug overlay.
For now, it works only on Windows with compositor.
Differential Revision: https://phabricator.services.mozilla.com/D131807
There's two kinds of test failures remaining:
* Failures related to how system colors inherit, which is something
that no engine is shipping and I'm not convince it's a good thing:
https://github.com/w3c/csswg-drafts/issues/6773
* Failures related to <iframes> observing color-scheme of ancestors
(which Chrome does implement but Safari doesn't):
https://github.com/w3c/csswg-drafts/issues/4772https://bugzilla.mozilla.org/show_bug.cgi?id=1738380
I'm unconvinced that should work across cross-origin iframes though
(see the question at the end of that issue), and it seems delaying
shipping it blocked on figuring that out while other engines ship
diverging behaviors is probably not worth it.
Given privileged code is already using this and we know of no other
blockers, I think it's fine to let it ride the trains.
Differential Revision: https://phabricator.services.mozilla.com/D131635
This causes (among other things) pages to be dark when using regular
windows system colors and forcing colors to "always", which is nice.
Differential Revision: https://phabricator.services.mozilla.com/D131165
CLOSED TREE
Backed out changeset 511af4b42efc (bug 1734132)
Backed out changeset 9516eb1214d8 (bug 1734132)
Backed out changeset 513d740d6477 (bug 1734132)
As per spec. This could cause wrong styles to be returned because we
fill the bloom filter based on flat tree ancestors, which was ultimately
the root cause of bug 1737131.
Differential Revision: https://phabricator.services.mozilla.com/D131074
This means that more precise values can be stored, so that they match what we
actually retrieve from the printer and use in layout.
Depends on D99806
Differential Revision: https://phabricator.services.mozilla.com/D99807
Chris Peterson
Narcis Beleuzu
Olli Pettay
Marian-Vasile Laza
sotaro
Nihanth Subramanya
Anny Gakhokidze
Butkovits Atila
Tim Huang
Emilio Cobos Álvarez
Valentin Gosu
jake champion
Kershaw Chang
Sylvestre Ledru
Deian Stefan
Cristian Tuns
Masayuki Nakano
Jesse Schwartzentruber
Kagami Sascha Rosylight
Iulian Moraru
ssummar
Niklas Goegge
Manuel Bucher
Lars T Hansen
Sean Feng
Ting-Yu Lin
Paul Adenot
Bryce Seager van Dyk
Alexandru Michis
Bob Owen