This patch removes the interface/header/implementation.
This adds a Map to PlacesTreeView to maintain the relation between node
details and the nodes, based on changes in `this._rows` or on
node details changed events. The Map exists from node details
to nodes (not rows).
MozReview-Commit-ID: EUNiXNIB5rN
--HG--
extra : rebase_source : 5391d9240e1f871c53d8aa26ae951b440b7280ad
Also moving RID (StreamID) storage to the stack to clear up the TODO item
and simplify the code.
When unset the StreamID is stored as an empty string.
Added missing GUARDED_BY on rid_
Added a check to shortcut checking strlen on the StreamId when it is an empty string (which is most of the time).
MozReview-Commit-ID: EPUlPNBXYsQ
--HG--
extra : rebase_source : 08e1b9ea796c991d141164424014d2311ff9341c
<!-- Please describe your changes on the following line: -->
handles the case where `GlobalScope::current` calls `CurrentGlobalOrNull` and the result is null
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix#17238
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because: no functionality change & ./mach build -d has no errors
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: dd7540a5d4b81c1b7b72a2120b2ada948da7108e
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4221c73e82a0735531209e9b87d1a3db6b15e85f
Bug 1374173 seems to be the cause of all MediaCache intermittent assertion
failures. It's not an important bug, so let's back-out and verify that
intermittents disappear.
MozReview-Commit-ID: 2X8iW1hWu99
--HG--
extra : rebase_source : e22443a5b9d5ba9a6ce4b126953a880e8e469cd2
<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1371199
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
<!-- Either: -->
There are tests for these changes, a test case will be landed in reftests in https://bugzilla.mozilla.org/show_bug.cgi?id=1371199
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
Source-Repo: https://github.com/servo/servo
Source-Revision: d2bc0ff6314f75a7742567b1f7133a8c76120538
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : c23ae4807b7480952dc83847f9a0cefec795cb22
On Linux some implementations of time(0) appear to be suffering from integer
overflow and giving us the wrong dates. This causes the time we expose to the
CDM to be wrong, and so licenses passed to the CDM are failing to authenticate,
and Netflix is thus broken on some Linux systems.
This is only happening in Firefox 54 and earlier, as in those versions we use
the WidevineDecryptor to talk to the CDM. In 55 (in beta) and later we use the
PChromiumCDM protocol to talk to the CDM. This doesn't use time(0) to get a
time for the CDM, so it's immune to the problem here.
So this patch makes the GetCurrentWallTime() implementation in
WidevineDecryptor match the code currently being used on Nightly and Beta in
the ChromiumCDMChild::GetCurrentWallTime() function.
Since we use the PChromiumCDM protocol to talk to the CDM on Nightly and Beta
by default, the WidevineDecryptor isn't actually being used on Nightly and
Beta. So this patch will only cause a behaviour change in Release, which still
uses the old backend. However it will make Release run the same code that we're
running in Nightly and Beta, so it should be safe to uplift to Release.
MozReview-Commit-ID: J58iDyinyQG
--HG--
extra : rebase_source : dcdf4a846f7b007526aa626db24598942f13f01d
stylo: Fix pseudo element matching for rules in XBL stylesheets
This change was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1372876
Source-Repo: https://github.com/servo/servo
Source-Revision: 6342a4b455e7714d42b9f8379eec7eec6262abb6
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 4de3e9b28adcb16412f6804bdc02a9a632d93132
This change is intended to be used to test the backout scripts from the Firefox side. See the following mail thread for more details:
https://groups.google.com/forum/#!topic/mozilla.dev.servo/j4C7U_H_T2A
Source-Repo: https://github.com/servo/servo
Source-Revision: 50bef977d04598d5c8c29d5786312c7a47e0bdf4
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 01b3b7d520a6b670c38cf2386a72ca697f65bfa4
|const char*| is good enough for a field that can only take on the values
"smartcard-insert" or "smartcard-remove". And it avoids an
NS_ConvertUTF16toUTF8 conversion.
We deployed the Servo VCS backout service recently and want to test it. The goal is to land this PR so it is replicated to the Firefox repo. Then we'll back out this PR from the Firefox repo, which should trigger a new PR against Servo to do the backout.
The changed code is not wrong. So if things don't go as planned, it shouldn't harm anyone.
Source-Repo: https://github.com/servo/servo
Source-Revision: e364f849b009d664012475396b927d354a5b7463
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : f30d4b6a89cffd6018d7ea899b2f153e22025878
MilindL
Gijs Kruitbosch
Luke Chang
Tomer Cohen
Nico Grunbaum
Carsten "Tomcat" Book
Rex Lee
Jyotsna Prakash
Munro Mengjue Chiang
Phil Ringnalda
Gerald Squelart
Mike Hommey
Mantaroh Yoshinaga
Chris Pearce
bechen
Ting-Yu Lin
Wes Kocher
Fernando Jimenez Moreno
Sebastian Hengst
Lars Bergstrom
Florian Quèze
Nicholas Nethercote
Gregory Szorc