We acutally have an old Telemetry ping `autoplay_default_blocked`, which, however, has been removed incorrectly in bug1356046.
As we have extended the setting options of blocking autoplay in bug1543812, it's also no longer proper to use scalar to store it.
Therefore, create an new histogram Telemetry ping to store the number of times a user changed the default autoplay behavior to each setting during a subsession.
Differential Revision: https://phabricator.services.mozilla.com/D40890
--HG--
extra : moz-landing-system : lando
Functions available only in Nightlies should not be exported outside of Nightly
builds. This change splits the exports into 2 def files (since the preprocessor
is not available for def file).
Differential Revision: https://phabricator.services.mozilla.com/D40653
--HG--
extra : moz-landing-system : lando
Because DebugTrapEntries are only present if the script has debugger instrumentation
it should be fine to store this as a simple list of entries.
Differential Revision: https://phabricator.services.mozilla.com/D40948
--HG--
extra : moz-landing-system : lando
These tests both load a page, create some chrome reference to it, then
navigate to another page to cause a window close on the original page,
then check to make sure the references to the original page have gone
away.
With Fission, if the navigation is cross-process, then the message
manager gets torn down in the original process where the browser test
is running, and the sendAsyncMessage call in content-task.js fails
with the cryptic error NS_ERROR_ILLEGAL_VALUE.
This can be fixed by making the navigation not be cross-origin. The
test only wants the original pages to be torn down. The origin of the
new page doesn't matter.
Differential Revision: https://phabricator.services.mozilla.com/D41408
--HG--
extra : moz-landing-system : lando
Because glLineWidth is deprecated in newer versions of core opengl,
we currently ignore lineWidth when using core profile. We should
probably also make ALIASED_LINE_WIDTH_RANGE match this behavior to
lessen confusion.
Differential Revision: https://phabricator.services.mozilla.com/D41117
--HG--
extra : moz-landing-system : lando
This patch changes how a VarCache pref works when deleted (in some cases) --
the VarCache variable keeps its existing value instead of being reset to a
pre-specified default.
In bug 1570212 I have made sure that no VarCache prefs exhibit this behaviour
in practice any more, so this change should not affect functionality. There is
an assertion that checks this.
The next patch will take advantage of this change by removing the need to
store the pre-specified defaults, which will save memory.
Differential Revision: https://phabricator.services.mozilla.com/D39805
--HG--
extra : moz-landing-system : lando
If the login is older than 2 minutes, don't allow revealing the password in the doorhanger.
Differential Revision: https://phabricator.services.mozilla.com/D40434
--HG--
extra : moz-landing-system : lando
These changes were produced using the Include What You Use tool, which uses the
Clang front end to figure out which headers actually declare the identifiers
you're using.
These changes aren't exactly the ones IWYU suggests. The tool has some odd false
positives, even when you use its 'pragmas' to tell it about headers like
jsapi.h, which is supposed to gather up other headers for you. And there are
some cases where I could get away with a forward declaration (say, for Maybe),
but I really just want to #include the full header because it seems better. But
overall this patch has only minor deviations from IWYU's suggestions.
No intended change in execution or visible behavior.
Differential Revision: https://phabricator.services.mozilla.com/D39446
--HG--
extra : moz-landing-system : lando
Finally, once we know the type of the map we're consulting, that tells us all
the other types we need to know: certainly the referent and wrapper types, but
also the referent variant type, via the wrapper.
DebuggerWeakMap does need new member types to tell us what its Referent and
Wrapper types are. Rename the type parameters to avoid shadowing.
Since the map type can be inferred from the call, we no longer need to pass any
type parameters at all when we call the innermost wrapVariantReferent overload.
Differential Revision: https://phabricator.services.mozilla.com/D38544
--HG--
extra : moz-landing-system : lando
For generatorFrames, this doesn't matter, but for sources, subsequent patches
need a more precise Referent type than simply 'JSObject'.
Any type used as a weak map key needs a MovableCellHasher instantiation, so add
the necessary ones to Barrier.cpp. Since the list is getting long, sort it.
Differential Revision: https://phabricator.services.mozilla.com/D38543
--HG--
extra : moz-landing-system : lando
It's more convenient for a DebuggerWeakMap's Wrapper type parameter to be the
pointed-to type, not the pointer type, since we'll be consulting its member
types. Then, it's a bit more consistent to also use the pointed-to type for
Referent.
Differential Revision: https://phabricator.services.mozilla.com/D38542
--HG--
extra : moz-landing-system : lando
Give DebuggerScript and DebuggerSource a member type that spells out the variant
type appropriate for their referents. This allows wrapVariantReferent to simply
consult the wrapper for the referent variant type instead of demanding it as a
type parameter.
No intended change in visible behavior.
Differential Revision: https://phabricator.services.mozilla.com/D38541
--HG--
extra : moz-landing-system : lando
Technically, DebuggerWeakMap could be used for any sort of cross-compartment
mapping. But we actually only use it for looking up Debugger reflection objects,
so it is more informative to call the key and value types 'referent' and
'wrapper'.
No intended change in visible behavior.
Differential Revision: https://phabricator.services.mozilla.com/D38540
--HG--
extra : moz-landing-system : lando
Give DebuggerWeakMap a `Wrapper` type parameter to use as the WeakMap value type
instead of plain JSObject*. Then, supply a specific wrapper class type for each
DebuggerWeakMap instantiation.
No intended change in visible behavior.
Differential Revision: https://phabricator.services.mozilla.com/D38539
--HG--
extra : moz-landing-system : lando
This adds js/src/dbg/Source.{cpp,h}, and moves DebuggerSource's definition
there. No intended change in implementation or visible behavior.
Differential Revision: https://phabricator.services.mozilla.com/D38538
--HG--
extra : moz-landing-system : lando
Use the new 'scalar' and 'categorical' telemetry types to make it easier
to read the graphs.
Moves the majority of the data to expire in 75. The following are set to
never expire since they are good to monitor for regressions and general
usage.
- PDF_VIEWER_TIME_TO_VIEW_MS
- pdf.viewer.used
Differential Revision: https://phabricator.services.mozilla.com/D40660
--HG--
extra : moz-landing-system : lando
Showing the protection panel for pages where content blocking can't add exceptions and/or
the url classifier can't classify doesn't make sense and would just be confusing to the user
and our code.
Differential Revision: https://phabricator.services.mozilla.com/D41197
--HG--
extra : moz-landing-system : lando
All .xul files have been loading as HTMLDocuments for a few weeks now, so
it should be safe to remove the XULDocument implementation.
Differential Revision: https://phabricator.services.mozilla.com/D41238
--HG--
extra : moz-landing-system : lando
This updates various strings across the privacy panel.
- Update mulitple text strings in Enhanced Tracking Protection panel
- Add additional icons/revise order of strings in panel UI
- Hide "Change Block List" ui in Custom option of ETP behind pref: browser.contentblocking.customBlockList.preferences.ui.enabled;true
Differential Revision: https://phabricator.services.mozilla.com/D38345
--HG--
extra : moz-landing-system : lando
Alastor Wu
Eitan Isaacson
thomasmo
Jan de Mooij
Geoff Brown
Cosmin Sabou
Omkar Konaraddi
Steve Fink
Andrew McCreight
Greyson Gilbert
Emilio Cobos Álvarez
Charlie Marlow
Agi Sferro
Eugen Sawin
Nicholas Nethercote
Matthew Noorenberghe
Jim Blandy
Tim Nguyen
Brendan Dahl
Johann Hofmann
Chris H-C
Botond Ballo
Erica Wright
Axel Hecht
Tom Schuster
mcrawford@mozilla.com
Florin Strugariu