Nika Layzell
82ee49b019
Bug 1717778 - Upgrade some LinkedList asserts to RELEASE_ASSERT, r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D118719
2021-06-25 16:53:39 +00:00
Sean Feng
3ae0be12e8
Bug 1667836 - Add CC support to LinkedList r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D103798
2021-02-09 18:54:47 +00:00
Simon Giesecke
dd80614fa0
Bug 1678062 - Remove unnecessary includes. r=andi
...
Differential Revision: https://phabricator.services.mozilla.com/D97467
Depends on D96561
2020-11-23 16:12:02 +00:00
Kartikaya Gupta
49c359630a
Bug 1661798 - Have the LinkedList destructor emit the buggy template specialization. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D88663
2020-08-28 20:07:26 +00:00
Eugen Sawin
9caff81fa1
Bug 1623715 - [4.1] Fix LinkedList::length() for a const context. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84543
2020-08-18 17:29:07 +00:00
Razvan Maries
1cad430a1a
Backed out 7 changesets (bug 1623715) for build bustages on nsWindow.cpp. CLOSED TREE
...
Backed out changeset 9704afdeefb1 (bug 1623715)
Backed out changeset 2e7e298cfe27 (bug 1623715)
Backed out changeset 579df1a653ee (bug 1623715)
Backed out changeset 4361ef84e780 (bug 1623715)
Backed out changeset 898972ec680c (bug 1623715)
Backed out changeset a118a4d72bef (bug 1623715)
Backed out changeset 4ff55894774d (bug 1623715)
2020-08-18 18:38:43 +03:00
Eugen Sawin
9ee999f3c0
Bug 1623715 - [4.1] Fix LinkedList::length() for a const context. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84543
2020-08-18 14:37:27 +00:00
Dorel Luca
6e3ab7e5fa
Backed out 7 changesets (bug 1623715) for Linting failure and android build bustage. CLOSED TREE
...
Backed out changeset c8ca1d1866e7 (bug 1623715)
Backed out changeset 1b7c3fb0da3b (bug 1623715)
Backed out changeset 4887dea37231 (bug 1623715)
Backed out changeset 47f3eb481909 (bug 1623715)
Backed out changeset 6e7ce9e5f89b (bug 1623715)
Backed out changeset ddff358f800e (bug 1623715)
Backed out changeset cd585490e79b (bug 1623715)
2020-08-18 00:20:24 +03:00
Eugen Sawin
e7ef0233d7
Bug 1623715 - [4.1] Fix LinkedList::length() for a const context. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D84543
2020-08-17 20:37:37 +00:00
alwu
c90111145c
Bug 1620113 - part1 : support `contain` and `length` for LinkedList. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D66854
--HG--
extra : moz-landing-system : lando
2020-03-18 22:14:59 +00:00
Simon Giesecke
ad6c02c994
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in mfbt. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D62542
--HG--
extra : moz-landing-system : lando
2020-02-13 11:20:27 +00:00
Mihai Alexandru Michis
395eb2050d
Backed out changeset f3d9fbb2daf1 (bug 1613985) for causing hazard bustages on Linux.
...
CLOSED TREE
2020-02-12 16:43:30 +02:00
Simon Giesecke
066ea869b7
Bug 1613985 - Use default for equivalent-to-default constructors/destructors in mfbt. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D62542
--HG--
extra : moz-landing-system : lando
2020-02-12 11:13:24 +00:00
Emilio Cobos Álvarez
256c124f94
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
...
This was done by:
This was done by applying:
```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
from subprocess import Popen, PIPE, check_output, CalledProcessError
diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
- args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+ args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
if not output_file:
args.append("-i")
```
Then running `./mach clang-format -c <commit-hash>`
Then undoing that patch.
Then running check_spidermonkey_style.py --fixup
Then running `./mach clang-format`
I had to fix four things:
* I needed to move <utility> back down in GuardObjects.h because I was hitting
obscure problems with our system include wrappers like this:
0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94 ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)
Which I really didn't feel like digging into.
* I had to restore the order of TrustOverrideUtils.h and related files in nss
because the .inc files depend on TrustOverrideUtils.h being included earlier.
* I had to add a missing include to RollingNumber.h
* Also had to partially restore include order in JsepSessionImpl.cpp to avoid
some -WError issues due to some static inline functions being defined in a
header but not used in the rest of the compilation unit.
Differential Revision: https://phabricator.services.mozilla.com/D60327
--HG--
extra : moz-landing-system : lando
2020-01-20 16:19:48 +00:00
Emilio Cobos Álvarez
aa3a695712
Bug 1609996 - Remove mozilla/Move.h. r=froydnj
...
rg -l 'mozilla/Move.h' | xargs sed -i 's/#include "mozilla\/Move.h"/#include <utility>/g'
Further manual fixups and cleanups to the include order incoming.
Differential Revision: https://phabricator.services.mozilla.com/D60323
--HG--
extra : moz-landing-system : lando
2020-01-20 16:18:20 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Andreas Farre
b5730bd2b0
Bug 1445659 - Make it possible to store RefPtr<T> in AutoCleanLinkedList. r=froydnj
...
Add a trait method that AutoCleanLinkedList delegates to for calling
delete on non-refcounted list elements.
--HG--
extra : histedit_source : 5e8b05f348d734d9045621d858caed946853fc02
2018-06-13 06:25:00 +03:00
Cameron McCormack
8a2341f976
Bug 1473771 - Part 2: Make LinkedList::Iterator work when element type inherits from multiple LinkedListElement<T>s. r=Waldo
...
MozReview-Commit-ID: 9dNTsSNyIYK
--HG--
extra : rebase_source : 60de5392ebf857d71e09a1bc7a68cc19edd66263
2018-07-06 10:56:08 +10:00
Cameron McCormack
cf90987901
Bug 1473771 - Part 1: Make LinkedList<T>::sizeOfExcludingThis work when element type inherits from multiple LinkedListElement<T>s. r=Waldo
...
MozReview-Commit-ID: KtqGkRKs68f
--HG--
extra : rebase_source : a4946439813dab4867e80e370e884f851289b4b7
2018-07-06 10:10:09 +10:00
Emilio Cobos Álvarez
1e9c395548
Bug 1466168: Remove mozilla::Forward in favor of std::forward. r=froydnj
...
Same approach as the other bug, mostly replacing automatically by removing
'using mozilla::Forward;' and then:
s/mozilla::Forward/std::forward/
s/Forward</std::forward</
The only file that required manual fixup was TestTreeTraversal.cpp, which had
a class called TestNodeForward with template parameters :)
MozReview-Commit-ID: A88qFG5AccP
2018-06-02 09:33:26 +02:00
Emilio Cobos Álvarez
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Jon Coppeard
edcb15ad07
Bug 1456875 - Add const iterators for LinkedList r=Waldo
2018-04-30 10:21:31 +01:00
Valentin Gosu
679361e438
Bug 1424834 - LinkedList::sizeOfExcludingThis should use ConstRawType instead of T* r=njn
...
MozReview-Commit-ID: 2EM9cEOAkIl
--HG--
extra : rebase_source : 05ebe36ecdaacbaf26bd1b6e23715035996f88b4
2017-12-20 01:13:53 +01:00
Dorel Luca
d9227411a0
Backed out 2 changesets (bug 1424834) for AddressSanitizer failure r=backout a=backout
...
Backed out changeset 00e1d58aedfe (bug 1424834)
Backed out changeset 9b69f2b7d373 (bug 1424834)
2017-12-19 13:59:02 +02:00
Valentin Gosu
9d89df19e4
Bug 1424834 - LinkedList::sizeOfExcludingThis should use ConstRawType instead of T* r=njn
...
MozReview-Commit-ID: 2EM9cEOAkIl
--HG--
extra : rebase_source : b3950ed06e1bc014fff9aa1deb5c2387fb2eb5bb
2017-12-15 15:46:31 -06:00
Cosmin Sabou
f0ab0b072a
Backed out 2 changesets (bug 1424834) for leaks at netwerk/dns/nsHostResolver.cpp:352 r=backout a=backout
...
Backed out changeset 2503df83bbd9 (bug 1424834)
Backed out changeset 49cc08386f17 (bug 1424834)
2017-12-18 11:52:06 +02:00
Valentin Gosu
a659128162
Bug 1424834 - LinkedList::sizeOfExcludingThis should use ConstRawType instead of T* r=njn
...
MozReview-Commit-ID: 2EM9cEOAkIl
--HG--
extra : rebase_source : b3950ed06e1bc014fff9aa1deb5c2387fb2eb5bb
2017-12-15 15:46:31 -06:00
Sylvestre Ledru
7c0ae251cd
Bug 1381253 - Remove redundant control flow declarations rs=ehsan
...
MozReview-Commit-ID: FFxP4aMCbOL
--HG--
extra : amend_source : 3aec108430b11048f47ffe19d5da7ac5034770a9
2017-07-15 19:03:04 +02:00
Kris Maglione
7d8720d597
Bug 1359653: Part 3 - Add a clear() method and move asssignment operator to AutoCleanLinkedList. r=waldo
...
MozReview-Commit-ID: 2bUTMPviJzg
--HG--
extra : source : b49bd726c8a6e955c672df17b2b9134ab3ad34d5
2017-05-02 17:54:18 -07:00
Sebastian Hengst
d8a3163a9b
Backed out changeset b49bd726c8a6 (bug 1359653)
2017-05-06 11:02:32 +02:00
Kris Maglione
e514005e37
Bug 1359653: Part 3 - Add a clear() method and move asssignment operator to AutoCleanLinkedList. r=waldo
...
MozReview-Commit-ID: 2bUTMPviJzg
--HG--
extra : rebase_source : c02a5c07030a8c2d5ad47a586a5af8f02e5ec2f6
2017-05-02 17:54:18 -07:00
Bill McCloskey
fb57ac5b38
Bug 1355178 - Remove unnecessary refcounting from MessageChannel::mPending (r=froydnj)
...
MozReview-Commit-ID: DWEF1ObNmMa
2017-04-19 11:51:14 -07:00
Bill McCloskey
4c8471eb15
Bug 1310547 - Add removeAndGetNext/Previous methods to LinkedList (r=froydnj)
2016-10-30 22:04:01 -07:00
Bill McCloskey
c0d229e060
Bug 1310547 - Allow LinkedList to hold RefPtr elements (r=froydnj)
2016-10-30 22:04:00 -07:00
Ting-Yu Lin
89db11bf5e
Bug 1311277 Part 4 - Convert NodeKind to be an enum class. r=froydnj
...
MozReview-Commit-ID: 2APdWxa8rZ6
--HG--
extra : rebase_source : f4fa846c6bd063afd2d1868169b676ec12f1f19a
2016-10-20 17:01:11 +08:00
Ting-Yu Lin
96fcd3875f
Bug 1311277 Part 2 - Add move assignment for LinkedListElement and LinkedList. r=froydnj
...
MozReview-Commit-ID: 7NjbxamX87U
--HG--
extra : rebase_source : 578c72ee7eff740f7e7dcfd95f38f3ca8d1045a8
2016-10-19 13:30:51 +08:00
Ting-Yu Lin
dcc36e9067
Bug 1311277 Part 1 - Convert |other| argument to Mozilla coding style. r=froydnj
...
MozReview-Commit-ID: JcEloAe5dlA
--HG--
extra : rebase_source : 8bc712551d1a0b8f4c1aec1dafc9e4fb2c5861e0
2016-10-19 13:24:23 +08:00
Jeff Walden
d9ee752669
Add an assertion message to the assert-is-empty in LinkedList::~LinkedList, to indicate to users who hit it that it's the fault of the caller, not the fault of MFBT code. No bug, rs=froydnj
2016-02-16 13:06:20 -08:00
Steve Fink
2ac5b36223
Bug 1212624 - Implement range-based iteration for LinkedList, r=Waldo
...
--HG--
extra : rebase_source : 9d3d1b40cab8542f4e7aaf9ffe1496c646c8291e
2015-10-07 14:19:42 -07:00
Steve Fink
833a3ce77b
Backed out 5 changesets (bug 1212624) for breaking stuff.
...
Backed out changeset cf5ffa45a4a2
Backed out changeset 0d7a968d2d64 (bug 1212624)
Backed out changeset 379edefa8e47 (bug 1212624)
Backed out changeset f73fca35daad (bug 1212624)
Backed out changeset 4f499d30a0e0 (bug 1212624)
2015-10-14 16:49:12 -07:00
Steve Fink
0df76da429
Bug 1212624 - Implement range-based iteration for LinkedList, r=Waldo
...
--HG--
extra : rebase_source : fb99021b13d030e12257ed420887051c7c5f9b8c
2015-10-07 14:19:42 -07:00
Mike Hommey
c18398b98d
Bug 1121269 - Add an AutoCleanLinkedList template that removes and deletes elements upon destruction. r=Waldo
2015-02-11 10:21:02 +09:00
Masatoshi Kimura
bf312ad056
Bug 1120062 - Part 1: Remove most Nullptr.h includes. r=waldo
2015-01-11 11:34:52 +09:00
Chris Peterson
9e23388ca8
Bug 1118076 - Remove MOZ_THIS_IN_INITIALIZER_LIST. r=Waldo
2015-01-06 21:39:46 -08:00
Ehsan Akhgari
4354953b4f
Bug 1118486 - Part 1: Use `= delete` instead of MOZ_DELETE directly; r=Waldo
...
Most of this patch (with the exception of dom/bindings/Codegen.py) was
generated by the following bash script:
#!/bin/bash
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "*/.git*" \
! -wholename "obj-*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_DELETE '= delete'
2015-01-08 23:19:05 -05:00
Nicholas Nethercote
2a0942be41
Bug 1036789 - Convert the third quarter of MFBT to Gecko style. r=Ms2ger.
...
--HG--
extra : rebase_source : 668cd394806203ddfa34bd4f226335ff26c846b5
2014-07-10 19:10:17 -07:00
Nicholas Nethercote
9439ff268e
Bug 1026319 - Convert the second quarter of MFBT to Gecko style. r=froydnj.
...
--HG--
extra : rebase_source : 98d2557c7fe4648d79143c654e7e31767fca2e65
2014-06-12 23:34:08 -07:00
Ehsan Akhgari
8b30e40485
Bug 1013662 - Fix bad implicit conversion constructors in MFBT; r=froydnj,Waldo
2014-06-06 23:17:06 -04:00
Nicholas Nethercote
9666d27bb1
Bug 893857 (part 1) - Add LinkedList::SizeOf{In,Ex}cludingThis(). r=Waldo.
...
--HG--
extra : rebase_source : 1b170f930eb28127502b70c7b0b3d0181c11c2df
2013-11-24 15:20:12 -08:00