This drops `followLinks` as 1) it has been no-op on UNIX for a long time and 2) its Windows implementation never had a proper symlink support.
Differential Revision: https://phabricator.services.mozilla.com/D75569
Instead of doing this:
a) read existing file into memory
b) append new entries
c) sort all entries
d) write unique entries back to file
We now do this:
a) sort new entries
b) loop through existing file entries, one at a time, writing them to a tmp file
c) insert the new entries in between the existing file entries in lexicographic order,
and deduplicating the new entries
d) write any remaining new entries (that are lexicographically after the last
entry in the pre-existing file), again deduplicating the entries
e) move tmp file back to original file location
This avoids reading the entire file into memory which could be potentially
hundreds of MB large.
The changes in FileOperations.* are needed to support these changes, as we now
have two files that we're dealing with - reading from one and writing to the
other. We still use a Mutex (Windows) or exclusive-flock (POSIX) on the file
for the duration of the entire operation, so we should still be robust in the
face of multiple concurrently running clang processes.
Differential Revision: https://phabricator.services.mozilla.com/D76202
This updates the task definition for the win64 searchfox job to closely match
the win64/debug task definition in taskcluster/ci/build/windows.yml. So, instead
of running the build with the mozsearch-plugin on a windows worker, it runs
on a Linux worker and does a cross-compile of windows code. The end result in
terms of searchfox artifacts is equivalent, except for absolute filename paths.
I verified that with mozsearch/mozsearch#299 and mozsearch/mozsearch-mozilla#87
in place, searchfox correctly indexes windows-only C++ and Rust code.
Differential Revision: https://phabricator.services.mozilla.com/D76721
This patch removes TYPE_DOCUMENT test in test_shouldclassify because the
testcase creates a non-top level channel with TYPE_DOCUMENT flag (this is wong!),
which triggers the assertion in UpdateIsOnContentBlockingAllowList.
File a follow-up bug 1640715 to add TYPE_DOCUMENT test back.
Differential Revision: https://phabricator.services.mozilla.com/D76152
We don't need to call this API in DocumentLoadListener::AsyncOpen because we have
already called this in nsHttpChannel::AsyncOpen
Differential Revision: https://phabricator.services.mozilla.com/D76275
This assert is reached via MaybeSetImplicitlyUsed, so before bug 1640107 this problem might not have triggered the test suite at all.
Differential Revision: https://phabricator.services.mozilla.com/D76725
Although the data review request granted permission to keep the probes
for 6 months, I'm using a shorter expiration (81) so that all
blocklist-related telemetry can be coverd by one update request, in the
future.
"geckoview" is not listed yet, because blocklist v3 is not yet enabled
on mobile (bug 1639050). Once enabled, "geckoview" should be added to
every scalar from this commit.
Differential Revision: https://phabricator.services.mozilla.com/D76539
And introduce a helper to get the ExtensionBlocklistMBLF global without
using a deprecated API, and remove the exception from eslintrc
Differential Revision: https://phabricator.services.mozilla.com/D76712
Automatic update from web-platform-tests
sensors: Remove cross-origin iframe test from runGenericSensorTests().
This test is wrong, which causes it to be flaky: it just adds an iframe and
waits for it to load without properly taking care of window focus, so the
sensor in the main window continued running and we could end up receiving an
unexpected "reading" event if the iframe's "load" event took to long to be
delivered.
Remove the test altogether in favor of run_generic_sensor_iframe_tests(),
which checks for the same thing the right way (although it is also a bit
flaky...).
Bug: 731018
Change-Id: I568f032233be767a2d2a3d50bd3de8d8ce3db0ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204024
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769458}
--
wpt-commits: 257af6a7bd889bf588a438d70f6f01fed9fca66f
wpt-pr: 23640
Automatic update from web-platform-tests
Mark AmbientLightSensor.https.html as a slow test.
ALS and Magnetometer have a maximum frequency of 10Hz, which can cause the
Generic Sensors test suite to take longer than normal to run.
Add the <meta> tag with the annotation to AmbientLightSensor.https.html, as
Magnetometer.https.html already has it.
Bug: 731018
Change-Id: Ia437fb2907c0e52caa281c8e709c1d48ca59873f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203071
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769453}
--
wpt-commits: 4d6f847054dbe39fb986fbd43cca4a8bd646663c
wpt-pr: 23639
Automatic update from web-platform-tests
sensors: Call GenericSensorTest.reset() in a cleanup function.
This addresses some of the flakiness in the sensors tests, in addition to
helping make it easier to find other sources of flakiness.
Instead of calling GenericSensorTest.reset() in a `finally` clause, use
t.add_cleanup() instead. The latter's behavior is more deterministic (see
https://github.com/web-platform-tests/wpt/pull/17924), and fixes an issue
where an EventWatcher would fail an assertion when receiving an unexpected
event, and GenericSensorTest.reset() would either not be called or called
after other tests had already started running.
Bug: 731018
Change-Id: Ifbb95b8067b153b70ecb3e6509f476164afd022e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203378
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769442}
--
wpt-commits: e909362eb429426f97d3c8731855075de9def0b2
wpt-pr: 23629
Automatic update from web-platform-tests
De-flaky some pointerevents wpt tests - Part 2
Because of Linux memory leak, pointerevent wpt tests
pointerevent_pointerleave_does_not_bubble.html,
pointerevent_pointerout_received_once.html and
pointerevent_setpointercapture_disconnected.html are flaky, we
should finish the test in the actions promise's callback to guarantee
the actions are all executed before the test finishes to avoid memory
leak.
Bug: 998948
Change-Id: I8e94ef1f2aba426c7ce58deed096c9ec56b10f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198685
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#769431}
--
wpt-commits: 03e2258e2a76ff3f8269f83c601aec770c437853
wpt-pr: 23609
Noemi Erli
Sebastian Hengst
Kagami Sascha Rosylight
Kartikaya Gupta
Gian-Carlo Pascutto
Eugen Sawin
Honza Bambas
Nika Layzell
Dimi Lee
David Teller
wesj
Tom Schuster
Masatoshi Kimura
Mike Conley
Nihanth Subramanya
Rob Wu
Aaron Klotz
Myeongjun Go
sefeng
Gabriel D'Alimonte
Narcis Beleuzu
Andrew Halberstadt
Andreea Pavel
James Graham
Dão Gottwald
Erica Wright
moz-wptsync-bot
Raphael Kubo da Costa
Lan Wei
Liviu Tinta