Fix submitted upstream
Upstream version had a partial fix for overflow (though incomplete). I've included that fix here and completed it.
MozReview-Commit-ID: 5RyIMI5qrvC
--HG--
extra : rebase_source : 18a67d2ca8220a8129b69105413c33a81f7a6984
https://gcc.gnu.org/onlinedocs/gcc/Extended-Asm.html#Extended-Asm says
asm [volatile] ( AssemblerTemplate : [OutputOperands] [ : [InputOperands] [ : [Clobbers] ] ] )
which implies that Clobbers is optional even after the third colon, but
the gcc used for b2g_try_emulator_dep builds says
resample_neon.c: In function 'saturate_32bit_to_16bit':
resample_neon.c:50: error: expected string literal before ')' token
--HG--
extra : rebase_source : 6ca7768d5b30f67ff6827acc9a4fdc51a672bc1e
This ensures that code in resample.c will run on Intel x86 cpus even when SSE
support has been compiled, and will provide similarly for neon support when
enabled.
--HG--
rename : media/libspeex_resampler/sse-detect-runtime.patch => media/libspeex_resampler/simd-detect-runtime.patch
rename : media/libspeex_resampler/src/resample_neon.h => media/libspeex_resampler/src/resample_neon.c
rename : media/libspeex_resampler/src/resample_sse.h => media/libspeex_resampler/src/resample_sse.c
rename : media/libspeex_resampler/src/sse_detect.cpp => media/libspeex_resampler/src/simd_detect.cpp
rename : media/libspeex_resampler/src/sse_detect.h => media/libspeex_resampler/src/simd_detect.h
extra : rebase_source : bdf1ef791129dedeadce7369354a5992729a99b7
Upstream SATURATE32PSHR changes conflict with Gecko's SSE runtime
detection patch. That patch is updated to reduce deviation from
upstream.
--HG--
extra : rebase_source : fdaf355f802b944fcbe286e076ca19dc6bc33f80
This is the speexdsp revision most similar to what is currently in Gecko.
We'll want to keep the HUGEMEM variant that we currently have from
opus-tools, but that will be restored in a subsequent patch.
--HG--
extra : rebase_source : 0d0d881dc1c997a42c9386136f0b93fd15aa0331
Instead of defining OUTSIDE_SPEEX and RANDOM_PREFIX everywhere
speex_resampler.h is included, it is easier to patch the header.
Symbol names in gkmedias symbols.def are updated now that RANDOM_PREFIX is
taking effect, and unused symbols are no longer exported.
--HG--
extra : transplant_source : sx%C9%ED%EB%E7%D8P%09%18%87%D4Oj%85%D5%25%C8%A5%01
This allows a client to align output samples consistently for independent
resampling of contiguous input buffers.
--HG--
extra : rebase_source : 58caba11ac7f78418b173a98556276d3b4644603
sample_frac_num is the array most likely to be non-zero after resampling a
previous stream, but the other arrays can also be left at non-zero values
in other situations.
--HG--
extra : rebase_source : dfd3974f051ff0b1794a937d712dda185352f7d5
From 763e746e97f0c234cea9ad1b674d406f55a2fb51 Mon Sep 17 00:00:00 2001
This applies a patch from the opus-tools fork of the speex
resampler, fixing an issue where the resampler could return
less that the requested number of samples.
https://git.xiph.org/?p=opus-tools.git;a=commitdiff;h=5adadc5
---
media/libspeex_resampler/README_MOZILLA | 3 +-
media/libspeex_resampler/src/resample.c | 12 ++++---
media/libspeex_resampler/truncation.patch | 54 +++++++++++++++++++++++++++++++
media/libspeex_resampler/update.sh | 4 +++
4 files changed, 67 insertions(+), 6 deletions(-)
create mode 100644 media/libspeex_resampler/truncation.patch
--HG--
extra : rebase_source : db081699c3f914824abeb3bbf6563d459a690eff
Turns out that the compiler believes you when you say unsigned once.
No need to repeat yourself.
--HG--
extra : rebase_source : 979560fd47f7591d9cec0533a29462d3a25e3528
Paul Adenot
Jean-Yves Avenard
Carsten "Tomcat" Book
Wes Kocher
Karl Tomlinson
Ralph Giles
Ehsan Akhgari
Gervase Markham