5748c4da8c
Bug 1291019 - Take the value of |aDoomed| in NS_ReleaseOnMainThread() if we're going to leak anyway. r=froydnj
2016-08-01 17:51:01 -07:00
1a1438ccb5
Bug 1288578: Make public nsClassHashTable::IsEmpty. r=froydnj
...
MozReview-Commit-ID: JSjT17kWYcQ
2016-07-22 13:27:52 -07:00
5538d692d3
Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
...
This removes the unnecessary setting of c-basic-offset from all
python-mode files.
This was automatically generated using
perl -pi -e 's/; *c-basic-offset: *[0-9]+//'
... on the affected files.
The bulk of these files are moz.build files but there a few others as
well.
MozReview-Commit-ID: 2pPf3DEiZqx
--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
d634a99cad
Bug 1277106 - Part 4: Remove MOZ_UTF16() macro. r=Waldo
2016-07-19 21:07:53 -07:00
b175c9fdd5
Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo
2016-07-20 22:03:25 -07:00
16e1b1c5eb
Bug 1288077: Merge implementations of |nsTArrayFallibleAllocator|, r=froydnj
...
The two implemenations of |nsTArrayFallibleAllocator| in 'nsTArray' are
equivalent. This patch merges both.
MozReview-Commit-ID: 3G9pHSQRzKz
2016-07-20 17:29:36 +02:00
5528947546
Bug 1288077: Cleanup forward declarations of array types, r=froydnj
...
MozReview-Commit-ID: 59XzOnREb6I
2016-07-20 17:29:36 +02:00
c9844397ea
Bug 1288077: Whitespace fixes, r=froydnj
...
MozReview-Commit-ID: DpKAsid5O3k
2016-07-20 17:29:36 +02:00
4d3c9798eb
Bug 1285235 - Add bindings for growing nsTArrays; r=bholley
2016-07-14 14:29:37 +05:30
43c2748f66
Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj
2016-07-08 14:39:53 -07:00
5dba0130cc
Bug 1271751 - part 8 - fix bug in nsTArray_CopyWithConstructors; r=erahm
...
The backwards copying case in MoveOverlappingRegion had a bug: rather
than destroying each element from the source range as we moved it, we
would always destroy the element at the beginning of the source range.
Fortunately, none of the existing types that were copied via
constructors seem to trigger the problematic code.
2016-07-08 16:59:04 -04:00
229ede80e2
Bug 1271751 - part 7 - remove nsTArray_CopyWith*::Copy*; r=erahm
...
After all the previous patches, we never call these functions. Any
copying required by nsTArray is taken care of by other means.
2016-07-08 16:59:05 -04:00
3d1192cadc
Bug 1271751 - part 6 - make ShiftData actually move its elements rather than copying; r=erahm
...
This change eliminates the last use of the Copy* family of functions.
2016-07-08 16:59:05 -04:00
0dc761e84b
Bug 1271751 - part 5 - use MoveNonOverlappingRegion instead of CopyNonOverlappingRegion; r=erahm
...
In all of the calls to CopyNonOverlappingRegion from within nsTArray, we
don't care about the contents of the source afterwards. So we can use
moves instead of copies to potentially make things more efficient.
2016-07-08 16:59:05 -04:00
315612a443
Bug 1271751 - part 4 - rename CopyNonOverlappingRegionWithHeader to MoveNonOverlappingRegionWithHeader; r=erahm
...
Whenever we're copying the header, we can be guaranteed that we're never
going to use the elements from the old array afterward, so can move (in
the C++ sense) the elements rather than copying them.
2016-07-08 16:59:05 -04:00
5dd30fe964
Bug 1271751 - part 3 - add Move{Non,}OverlappingRegion; r=erahm
...
We'll need these for future patches as we transition nsTArray to use
moves for most of its operations rather than copies. The implementation
of these functions are essentially cut-and-paste versions of the Copy*
functions, but using moves.
2016-07-08 16:59:05 -04:00
6e9fa45637
Bug 1271751 - part 2 - rename {Copy,Move}Elements to something more accurate; r=erahm
...
The names {Copy,Move}Elements are based on the use of mem{cpy,move},
respectively. However, I submit that we really want the names to
reflect the C++ operations being done, rather than the underlying
implementation details. So let's rename these to reflect that we are
always copying the elements, and discriminate between the two cases
based on whether the regions being copied overlap or not.
Bring CopyHeaderAndElements along for the ride, as well.
2016-07-08 16:59:05 -04:00
e458be747b
Bug 1271751 - part 1 - provide out-of-class definitions for some nsTArray functions; r=erahm
...
This change enables some of the methods in nsTArray to be lazily
instantiated, particularly the ones that care about whether the element
type is copyable. Since we have a number of places where nsTArray is
used with move-only types, we need to ensure that unless methods
requiring copyability are actually called, those methods are not
instantiated.
2016-07-08 16:59:05 -04:00
09a852e8b4
Bug 1271751 - part 0 - remove heap functions from nsTArray; r=erahm
...
They are unused, except for tests.
2016-07-08 16:59:05 -04:00
2b3b60f7b1
Bug 1277155 - Part 1: Remove snprintf() polyfills for VS2013 in Sprintf.h and #defines. r=froydnj r=mhowell
2016-06-27 20:45:03 -07:00
96da4695c8
Bug 1283855 part 25 - Make JS_GC take JSContext instead of JSRuntime. r=terrence
2016-07-06 11:40:20 +02:00
d2ec8127e0
Bug 1279609 - nsRunnableMethodImpl should use a non-public destructor. r=froydnj
2016-07-05 12:03:18 -07:00
4ba1239131
Bug 1283855 part 11 - Make some GC callback APIs take JSContext instead of JSRuntime. r=terrence,mccr8
2016-07-05 14:35:19 +02:00
1363127e17
Bug 1283524 - remove unnecessary NS_ASSERT_OWNINGTHREAD checks in Release method macros; r=mccr8
...
The definitions of these Release methods already include
NS_ASSERT_OWNINGTHREAD checks earlier, so these second checks are
redundant.
2016-06-30 23:55:36 -04:00
523608513b
Bug 1247972 - specialize NS_ProxyRelease for nsISupports to be out-of-line; r=erahm
...
NS_ProxyRelease's current implementation requires a lot of code. We can
reduce the impact of this by providing an out-of-line implementation for
classes based on nsISupports. This change reduces codesize by ~60K on
a Linux x86-64 build.
2016-06-29 18:56:41 -04:00
f7ee3c3dbf
Bug 1281626 - part 5 - move nsRunnableFunction into mozilla::detail and rename it; r=khuey
...
We do this for similar reasons as nsRunnableMethod*: less prefixing and
a more obvious signal that this is a private implementation class.
2016-06-28 22:24:54 -04:00
65715152b1
Bug 1281626 - part 4 - change NS_NewRunnableFunction to return already_AddRefed; r=khuey
...
This change makes it more consistent with NS_NewRunnableMethod and also
opens up optimization opportunities for later.
2016-06-28 22:24:54 -04:00
f624e16333
Bug 1281626 - part 2 - make RunnableMethod* internals final classes; r=khuey
...
This step is mostly tidiness.
2016-06-28 22:24:54 -04:00
bcf3920031
Bug 1281626 - part 1 - move nsRunnableMethod* into mozilla::detail and rename them; r=khuey
...
Less ns-prefixing is more better. Also, this renaming makes clearer
that these classes are private implementation details, which is good,
because we're going to take advantage of that fact in a bit.
2016-06-28 22:24:54 -04:00
6baa905da7
Bug 1282527: Remove remaining PR_ASSERTs outside of NSPR/NSS. r=dbaron
...
--HG--
extra : rebase_source : a9dd69c772ef2641ee300d57d2a4d4c83003726c
2016-06-28 10:47:22 -07:00
fb0436ba41
Bug 1279295 - Create the runtime's JSContext when we create the runtime. r=luke
2016-06-22 09:47:52 +02:00
ddc458bf9e
Bug 1281227 - clarify comments in PLDHashTable.cpp; r=njn
...
Comments for SearchTable and FindFreeEntry refer to parameters that no
longer exist, now that we do things with template arguments. Let's fix
that.
2016-06-22 02:44:40 -04:00
150bcb573b
Bug 1278925 - micro-optimize nsCOMArray appending with already_AddRefed AppendElement; r=erahm
...
In all of the places touched by this patch, the smart pointer we're
appending is about to become unused, so simply .forget()'ing its
reference into the appropriate nsCOMArray works just fine.
2016-06-20 18:38:10 -04:00
083b9ba519
Bug 1279734 - "Fix two comment typos in nsTextFormatter.cpp". r=nfroyd
2016-06-11 10:41:45 +02:00
e8513ef5ee
Bug 1271593 - NS_NewRunnableFunction should forward its arg - r=froydnj
...
By perfect-forwarding its argument, we can automatically gain move semantics
optimization when storing the given function object into nsRunnableFunction.
Also it allows movable-only function objects.
Note that any reference is removed from the type to be stored, so that the
runnable always contain a concrete function object.
MozReview-Commit-ID: 9EZK84ZhMvR
--HG--
extra : rebase_source : e1f87c3284fda4df6d13839ea6a0b0c2ce196833
2016-06-02 01:21:36 +02:00
829225e78d
Bug 1278452 - Remove a redundant null check in xpcom/glue/. r=froydnj.
...
There's another null check just a little earlier.
--HG--
extra : rebase_source : 24968e6bc5f12c3aa5d53711ebbb7f849c4501c3
2016-06-07 16:13:17 +10:00
2be85aa542
Bug 1277890 - part 0 - add "append already_AddRefed element" API to nsCOMArray; r=erahm
2016-06-07 04:10:25 -04:00
b0f9749010
Bug 1278223 part 1 - Stop using multiple contexts per runtime in gtests. r=fitzgen
2016-06-06 19:45:06 +02:00
fc6592bdbc
Bug 1271182 - Add some deleted assignment operators and copy constructors. r=khuey
...
These are generally good practice for reference-counted objects; they
catch cases where these operations are used by accident, breaking
reference-counting.
This doesn't show any existing problems, though.
MozReview-Commit-ID: EvRkNCymOqT
2016-05-25 18:04:35 -07:00
35eaf64b42
Bug 1273190, part 3 - Fix some modelines in xpcom/. r=froydnj
...
Autogenerated by modeline.py.
2016-05-24 14:45:44 -07:00
21bb33df87
Bug 1273190, part 1 - Fix indentation and mode lines for various xpcom/ files. r=froydnj
2016-05-24 14:45:44 -07:00
3e3b6c7f4d
Bug 1270938 - Add stack traces for blocking resource base warnings. r=froydnj
2016-05-23 14:59:30 -07:00
2af45ab23d
Bug 1273838 - Part 2: Add stylo bindings glue for refcounting nsIPrincipals and nsIURIs. r=bholley
...
--HG--
extra : rebase_source : 3feef1315c4c8716952f630a38a4802e118b44ed
2016-05-21 10:02:54 +10:00
a5b7829d71
Bug 1273838 - Part 0.9: Add Ptr{Holder,Handle} typedefs for nsMainThreadPtr{Holder,Handle}. r=bholley
...
--HG--
extra : rebase_source : 12d60b4f31c3aa9183bcd8455357be4179f9a954
2016-05-21 10:02:54 +10:00
e0b47504da
Bug 1273838 - Part 0.8: Add nsMainThreadPtr{Handle,Holder} constructors that take already_AddRefed pointers. r=bholley
...
--HG--
extra : rebase_source : bbdd9945e4621a54510f0259fc01454cc8642b17
2016-05-21 10:02:54 +10:00
316b3d93b6
Bug 1272831 - Add AutoRestore::SavedValue() to retrieve the saved value. r=froydnj
...
MozReview-Commit-ID: eZCWmTpvXi
--HG--
extra : rebase_source : fc43e8b43edaad362971e7c7f91895759f47bf8f
2016-05-14 09:47:14 +08:00
e809e9f918
Bug 1035125 Part 9: Link Chromium sandbox into firefox.exe instead of having a separate DLL. r=aklotz,glandium
...
MozReview-Commit-ID: 1vgDPjpcwz3
--HG--
extra : rebase_source : 40966d98ca6c37f30884639d648907b4760ae240
2016-05-15 16:41:40 +01:00
8a9e2d2bd4
Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium
2016-05-14 00:54:55 -07:00
353ee65255
Bug 1272513 - Part 1: Suppress -Wshadow warnings-as-errors in some directories. r=glandium
2016-05-11 00:00:01 -07:00
1dc278fe13
Bug 1271848, part 1 - Add ClassName() method to the CC participant. r=smaug
...
This will let us report better information about participants at runtime.
2016-05-12 10:54:33 -07:00
941ab1f522
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-05-05 01:45:00 -07:00
7c2af31504
Bug 1268313: Part 5 - Make NS_NewRunnableMethod able to call const functions. r=froydnj
2016-05-05 01:44:59 -07:00
156b8c1933
Bug 1268313: Part 4 - Replace NewCancelableRunnableMethod with NS_NewCancelableRunnableMethod. r=froydnj
2016-05-05 01:44:59 -07:00
7f54121b91
Bug 1268313: Part 3 - Replace some NewCancelableRunnableMethod with NS_NewNonOwningCancelableRunnableMethod. r=froydnj
2016-05-05 01:44:59 -07:00
32bf86a025
Bug 1193762 part 9 - Delete nsCOMPtr<T>::operator T*()&&; r=froydnj
2016-05-01 21:29:23 +03:00
5d43a44ec6
Backed out changeset 3f2f3fcac66b (bug 1268313)
...
--HG--
extra : rebase_source : 438e7d7077b900ef252bd628f4559424eebd211f
2016-04-29 14:21:23 +02:00
4bb6f48de3
Backed out changeset 6a8d57e8fa8e (bug 1268313)
...
--HG--
extra : rebase_source : 8690897fd41073f22c8b25db5e8ce88df76a2bb7
2016-04-29 14:21:22 +02:00
894326b653
Backed out changeset 726f7361e0b8 (bug 1268313)
...
--HG--
extra : rebase_source : 3e04a6751a1cce2be7692763b4520dcca053f210
2016-04-29 14:21:20 +02:00
ba3fe0975c
Backed out changeset 85ce8cb0639a (bug 1268313)
...
--HG--
extra : rebase_source : 56d1cf41a2dc4959b67f834e07192a5c772176a8
2016-04-29 14:21:16 +02:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
48a594a09e
Bug 1268313: Part 7 - Move NS_NewRunnableMethod and friends to mozilla::NewRunnableMethod. r=froydnj
2016-04-28 14:08:25 -07:00
732a15e600
Bug 1268313: Part 5 - Make NS_NewRunnableMethod able to call const functions. r=froydnj
2016-04-28 14:08:24 -07:00
c724d0c867
Bug 1268313: Part 4 - Replace NewCancelableRunnableMethod with NS_NewCancelableRunnableMethod. r=froydnj
2016-04-28 14:08:24 -07:00
a13954d079
Bug 1268313: Part 3 - Replace some NewCancelableRunnableMethod with NS_NewNonOwningCancelableRunnableMethod. r=froydnj
2016-04-28 14:08:24 -07:00
b9ddae6e51
Bug 1264199: P0. Fix nsDequeue/MediaQueue methods constness. r=jwwang
...
MozReview-Commit-ID: BiOedq3IHt
--HG--
extra : rebase_source : 87175a92efdcfea864256482ced7eeee61301690
2016-04-25 12:13:55 +10:00
c73656947b
Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj
2016-04-25 17:23:21 -07:00
c2fe3cc9ea
Bug 1266295 - Remove unnecessary compiler version checks for gcc <= 4.8.0 in xpcom. r=froydnj
2016-04-17 17:10:00 -07:00
7386c22521
Bug 1262970 - Allow nsMainThreadPtrHandle to be constructed by and compared to nullptr. r=froydnj
...
MozReview-Commit-ID: HQgRhJc9AwG
--HG--
extra : rebase_source : e97c55229e0043d838d5dcb3e343bba2281c1e36
2016-04-14 11:38:04 +02:00
b0e24f4d55
Bug 1262400 - remove outer pointers from nsCreateInstance* classes; r=erahm
...
Outer pointers for object aggregation never get used. Having these
always-null pointers around means extra space to store them and extra
instructions to deal with them. Let's just remove them.
2016-04-14 11:30:59 -04:00
60dcde7875
Bug 1261723 (part 2) - Separate class ops from js::Class. code=njn,h4writer. r=efaust,bz.
...
js::Class op are often all null. And when they're not all null, they're often
duplicated among classes. By pulling them out into their own struct, and using a
(possibly null) pointer in js::Class, we can save 114 KiB per process on
64-bit, and half that on 32-bit.
* * *
imported patch separate-ClassOps-2
--HG--
extra : rebase_source : bd751bf247e9491c1966a123dbeffa573657dfb1
2016-04-01 11:00:01 +11:00
2709afd167
Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj
2016-04-11 11:40:06 -07:00
1cc02aa8c6
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
2dbf3449f8
Bug 1263764 - Make the external string API's Truncate compatible with the internal API's Truncate. r=froydnj
2016-04-01 16:17:35 +01:00
7d2cebe912
Backed out 3 changesets (bug 1263311) for Windows build failures in ServiceWorkerPrivate.cpp CLOSED TREE
...
Backed out changeset 0434a548e1fe (bug 1263311)
Backed out changeset 60b1be29446c (bug 1263311)
Backed out changeset 18132498bc40 (bug 1263311)
MozReview-Commit-ID: LPEa05QobdQ
2016-04-11 12:50:56 -07:00
d200ed89d0
Bug 1263311: Part 3 - s/nsCancelableRunnable/CancelableRunnable/g. r=froydnj
2016-04-11 11:40:06 -07:00
f13a6fc866
Bug 1263311: Part 1 - Change the nsICancelableRunnable interface. r=froydnj
2016-04-11 11:40:06 -07:00
5a57a5b196
Bug 1163320 - Variadic implementation of nsRunnableMethodArguments. r=froydnj
...
MozReview-Commit-ID: 13YyOyiionD
--HG--
extra : rebase_source : 89a0ad0877ed3290a41288523fe9b13d9c5bac7d
extra : source : ed761807105b30069d5a7412f8dacf75429eeeb6
2015-05-11 17:24:21 -04:00
dfc6d94fe7
Bug 1208371 - Implement operator!= for nsMainThreadPtrHandle. r=bholley
...
MozReview-Commit-ID: EjlvLi9VsFA
--HG--
extra : rebase_source : 0e58b99b3c03a4abc4dfbcd57662f761f701615e
2016-02-04 00:24:52 +08:00
da166b0f2c
Bug 1259706: Add NS_INLINE_DECL_THREADSAFE_VIRTUAL_REFCOUNTING macro. r=froydnj
...
Allow to generate virtual AddRef/Release methods.
MozReview-Commit-ID: I7xPupDEtr4
--HG--
extra : rebase_source : b4d0e2b2a254e0402bbe6543c5263da359efb640
2016-03-25 23:01:58 +11:00
6a82950698
Bug 1242963 - nsID stringification helper for logging; r=froydnj
...
From 6321c215bed173f89127558b2eec3cc1b475cf84 Mon Sep 17 00:00:00 2001
MozReview-Commit-ID: IPhQhW8v4iH
--HG--
extra : rebase_source : b78f75145aeff78901ffcea687c710d637f2c1e7
extra : source : defe17fe276a9a66f923f714d4f6c35e6373364e
2015-10-08 13:11:04 -04:00
640bfbec0b
Bug 1257331 - Use LPWSTR instead of LPVOID to prevent C4477 warning; r=froydnj
...
MozReview-Commit-ID: 2rJdKhlLtXr
--HG--
extra : rebase_source : e31284758a80054831fd6ecda0e7733ab4e9312a
2016-03-17 20:36:06 -07:00
a2f068b2ad
Bug 1253085 - Remove the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}. r=froydnj.
...
This is easy because it's never needed.
--HG--
extra : rebase_source : 78830dab41c40a1544fa55fc69ca9c1c6709d767
2016-03-16 15:33:44 +11:00
f584cb3bd0
Bug 1255655 - Const-ify named CIDs. r=froydnj.
...
There are about 600 of these, at 16 bytes each, and this change makes all of
them shareable between processes
--HG--
extra : rebase_source : b1824f0a022389aeb02d925c4d788e5a671bf782
2016-03-11 14:32:39 +11:00
4c23f5cd8d
Bug 1251482 - Remove remaining references to MOZILLA_XPCOMRT_API from xpcom. r=froydnj
2016-02-26 18:10:56 -08:00
72d9604d91
Backed out 8 changesets (bug 1251482, bug 1251494, bug 1251473, bug 1239870) for gtest failures
...
Backed out changeset f064a5efbb8c (bug 1251494)
Backed out changeset 9e33adec1aa6 (bug 1251482)
Backed out changeset ab0347657e25 (bug 1251473)
Backed out changeset 1d385d4f195d (bug 1239870)
Backed out changeset ceb3e1ee7dda (bug 1239870)
Backed out changeset 8574075bf42f (bug 1239870)
Backed out changeset ba077a3afbc7 (bug 1239870)
Backed out changeset eb99ab06414d (bug 1239870)
MozReview-Commit-ID: 7r9SEk4VGNU
2016-02-26 17:14:57 -08:00
ae72b68e62
Bug 1251482 - Remove remaining references to MOZILLA_XPCOMRT_API from xpcom. r=froydnj
2016-02-26 15:31:19 -08:00
b80e656e9e
Bug 1247679, part 3 - Replace NS_IMPL_CYCLE_COLLECTION_TRACE_JSVAL_MEMBER_CALLBACK with JS_MEMBER. r=smaug
2016-02-22 10:11:02 -08:00
c0010835a7
Bug 1247679, part 2 - Null check inside TraceCallbackFunc::Trace. r=smaug
2016-02-22 10:11:02 -08:00
2abcf180f1
Bug 1249171 - Simplify nsCOMArray::SizeOfExcludingThis(). r=erahm.
...
Using explicit iteration at measurement sites is much simpler and nicer than
using callbacks.
--HG--
extra : rebase_source : 8b3f7aa702743b665383766b66a866a2c3d17240
2016-02-19 14:54:45 +11:00
686438c658
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
2016-02-10 08:23:00 +01:00
5b358688b7
Backed out changeset c18e29c1b369 (bug 1164581) for cpp unit tests test failures
...
--HG--
extra : rebase_source : fb6fd434c8e3f4b5fa53ea645a54c07cab207894
2016-02-08 11:17:38 +01:00
69cf7e035f
Bug 1164581 - Adding an overload for NS_ProxyRelease that accepts already_AddRefed, and removing all the others. r=bobbyholley
...
--HG--
extra : rebase_source : 3c6bba6613a14e48239d302bdd0f7fe2e322265d
2016-02-07 10:56:00 +01:00
5315826043
Bug 1181444 (part 2) - Remove nsBaseHashtable::Enumerate(). r=froydnj.
...
\o/
--HG--
extra : rebase_source : 4f4831b1feb4ee25b6adc7aeeae548e5d0df5c8d
2015-11-24 19:42:28 -08:00
54720f2a75
Bug 1235261 - Part 7: Remove AutoInfallibleTArray. r=froydnj
2016-02-02 17:36:31 +02:00
62cff61cda
Bug 1235261 - Part 5: Merge nsAutoArrayBase into AutoTArray. r=froydnj
...
nsAutoArrayBase is no longer needed because AutoTArray is its only subclass.
2016-02-02 17:36:30 +02:00
7104c2aaa5
Bug 1235261 - Part 4: Remove AutoFallibleTArray. r=froydnj
2016-02-02 17:36:30 +02:00
d7371d07d0
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-02-02 17:36:30 +02:00
53001db0dd
Bug 1244606 - Remove PL_DHASH_FASTCALL. r=froydnj.
...
FindFreeEntry() has one caller, so using MOZ_ALWAYS_INLINE should be good
enough for it. As for SearchTable(), NS_FASTCALL is the same as
PL_DHASH_FASTCALL and so can be used instead.
--HG--
extra : rebase_source : 814f96d4751922785358e7a4f9d64fcf522364c1
2016-02-02 06:27:57 +11:00
d381b4bca6
Back out 7 changesets (bug 1235261) for cpptest failures in TestTArray
...
CLOSED TREE
Backed out changeset d66c3f19a210 (bug 1235261)
Backed out changeset 467d945426bb (bug 1235261)
Backed out changeset 32b61df13142 (bug 1235261)
Backed out changeset c50bb8ed4196 (bug 1235261)
Backed out changeset 0ff0fa6fe81f (bug 1235261)
Backed out changeset df70e89669da (bug 1235261)
Backed out changeset 064969357fc9 (bug 1235261)
2016-01-31 10:10:57 -08:00
d39376e4d0
Bug 1235261 - Part 7: Remove AutoInfallibleTArray. r=froydnj
2016-01-31 17:12:13 +02:00
fbff06ea09
Bug 1235261 - Part 5: Merge nsAutoArrayBase into AutoTArray. r=froydnj
...
nsAutoArrayBase is no longer needed because AutoTArray is its only subclass.
2016-01-31 17:12:12 +02:00
6ed751e586
Bug 1235261 - Part 4: Remove AutoFallibleTArray. r=froydnj
2016-01-31 17:12:12 +02:00
373593275e
Bug 1235261 - Part 1: Rename nsAutoTArray to AutoTArray. r=froydnj
2016-01-31 17:12:12 +02:00
ab4e3a0d42
Bug 1218816 - Remove useless semicolons. Found by coccinelle. r=Ehsan
...
--HG--
extra : rebase_source : 7d2cc56b6553cd7a8d848d3c660f30735bd82eec
2016-01-22 16:58:49 +01:00
add2713c12
Bug 1239888 - Inline PLDHashTable::{Done,Get}(). r=froydnj.
...
They're trivial and very hot. This reduces binary size in a 64-bit Linux opt build by 20 KiB and avoiding the calls can only help performance.
--HG--
extra : rebase_source : 774e6ffff9c787fa5444f939d1236d994ac8cf5b
2016-01-14 21:39:11 -08:00
bb453ca522
Bug 1228641. Add a initializer_list constructor to nsTArray. r=froydnj
...
This also adds a couple of users of the new pattern.
2016-01-17 22:11:25 -05:00
ec89bbf7f2
Bug 1237151 (part 3) - Remove ignored qualifiers in all remaining code. r=froydnj.
2016-01-05 17:08:45 -08:00
9b5c90690e
Merge inbound to m-c a=merge
...
--HG--
extra : commitid : I44HufYdnXT
2016-01-05 16:02:49 -08:00
c7edb0ffaf
Bug 1234176 - Introduce and use the WriteSysFile() helper function. r=dhylands
...
--HG--
extra : rebase_source : c976b7434f660bc7b5fdc19bce800990c96443cb
2015-12-29 11:49:50 +01:00
bb224242a8
Bug 1235598 - Part 2: Use TraceEdge exclusively in Gecko; r=smaug
...
--HG--
extra : rebase_source : 27afd7eecd5a13f8d28b888b64d5e44b3c4a74a5
2015-12-30 08:52:14 -08:00
a69ea37914
Backed out 2 changesets (bug 1235598) for linux reftest bustage
...
Backed out changeset 3bcd3c276785 (bug 1235598)
Backed out changeset 80cd10a8b3d7 (bug 1235598)
--HG--
extra : commitid : DZRlFy6bH2m
extra : rebase_source : 3479cd1146e58115883f2329861647a962d162cc
2015-12-31 15:51:13 -08:00
9d97726f6c
Bug 1235598 - Part 2: Use TraceEdge exclusively in Gecko; r=smaug
...
--HG--
extra : rebase_source : c18f7e97d09f0cd91d0d837d2cdc65926cd3de64
2015-12-30 08:52:14 -08:00
5ca565690e
Bug 1120016 - Allocate short lived JS wrappers in the Nursery, r=mccr8,terrence
2015-12-31 15:21:49 +02:00
792ca14825
Backed out changeset 0d55a6e4e98e (bug 1120016) for 980 b2g hazards
...
--HG--
extra : commitid : 27OIHVsa17S
2015-12-30 16:34:18 -08:00
2d98949f4f
Backout Bug 1235598 Part 2 because of merge bustage on a CLOSED TREE
2015-12-30 15:05:24 -08:00
4710ce6d97
Bug 1235598 - Part 2: Use TraceEdge exclusively in Gecko; r=smaug
...
--HG--
extra : rebase_source : fba9dbd3f6bc7b36074f58d11c411deb84c1ff1e
2015-12-30 08:52:14 -08:00
5be7be38a1
Bug 1235615 - Split JS::CompartmentOptions into JS::CompartmentCreationOptions that are immutable characteristics of a compartment, and JS::CompartmentBehaviors that may be changed after the compartment's been created. r=terrence
...
--HG--
extra : rebase_source : f08c380ae247d3308d4c36788ac765de1b75af50
2015-12-28 16:15:52 -06:00
2066f6d7b3
Bug 1120016 - Allocate short lived JS wrappers in the Nursery, r=mccr8,terrence
...
--HG--
extra : rebase_source : 3d51b7fc9962a93eb6071328db84b5b327225246
2015-12-30 19:16:13 +02:00
84e0c59589
Bug 1231964 - Move CC participant code that touches JS out of mozglue. r=smaug
...
The JS engine does not export symbols outside of XUL, so having these
defined inside mozglue apparently causes linking errors on some
platforms with the patches in bug 1120016.
This patch moves enough methods outside of mozglue that the patch in
that other bug will still link on all platforms, without moving so
much out that there are other linking errors.
--HG--
rename : xpcom/glue/nsCycleCollectionParticipant.cpp => xpcom/base/nsCycleCollectorTraceJSHelpers.cpp
2015-12-18 14:22:01 -08:00
ddc78c3b0c
Bug 1229458 - Remove SizeOfIncludingThisMustBeUnshared() from string classes. r=mccr8.
...
The patch changes all uses of SizeOfIncludingThisMustBeUnshared() to
SizeOfIncludingThisIfUnshared(). This incurs the (tiny) cost of an unnecessary
IsReadonly() check for guaranteed-unshared strings, but avoids the possible
assertion failures that would occur when MustBeUnshared() was used incorrectly
on shared strings, which is an easy mistake to make.
--HG--
extra : rebase_source : b1e91f1c19bcbe0521b0ce461d6c90512ca938ef
2015-12-01 15:36:26 -08:00
d180cd4a92
Bug 1181444 (part 1) - Remove nsBaseHashtable::EnumerateRead(). r=froydnj.
...
--HG--
extra : rebase_source : c07a83a2984ca4e67f3441d9e18b6bbac772495d
2015-11-22 14:39:01 -08:00
d63cd22524
Bug 1221376 - Remove PL_DHASH_STOP. r=froydnj.
...
All uses of it have been removed.
2015-11-03 17:22:15 -08:00
8eb3a68c9e
Bug 1201997 - Part 4 - Change size and offset variables to size_t.r=froydn
2015-11-15 14:48:08 +01:00
e97680a76a
Bug 1201997 - Part 3 - Make internally used methods private. r=froydn
2015-11-15 14:48:02 +01:00
fa8035029e
Bug 1201997 - Part 2 - Removing unused methods from the nsDeque class. r=froydn
2015-11-15 14:47:55 +01:00
6418c52357
Bug 1201997 - Part 1 - Converted compiled test to gtest for nsDeque class. Added tests to test untested methods. r=froydn
...
--HG--
rename : xpcom/tests/TestDeque.cpp => xpcom/glue/tests/gtest/TestNsDeque.cpp
2015-11-15 14:47:49 +01:00
5bf85e9f9d
Bug 1220923 - Make nsIntRegion a typedef for IntRegionTyped<UnknownUnits>. r=nical
...
--HG--
extra : source : 1f371f014048ed4c3c25095233fea927311a7e23
2015-11-04 11:49:49 -05:00
4a9be99fc7
Bug 1220544 - Fix -Wunreachable-code warnings in xpcom. r=mccr8
...
xpcom/glue/PLDHashTable.cpp:471:10 [-Wunreachable-code-return] 'return' will never be executed
xpcom/tests/TestAutoPtr.cpp:324:9 [-Wunreachable-code] code will never be executed
xpcom/tests/TestBlockingProcess.cpp:6:11 [-Wunreachable-code-return] 'return' will never be executed
2015-11-02 21:03:03 -08:00
a5557d1390
Bug 1219246 - use UniquePtr instead of nsAuto*Ptr in xpcom/; r=erahm
2015-10-31 13:47:14 -04:00
e968844794
Bug 968520 - Always use fallible allocator with nsTArray_base::ShrinkCapacity. r=froydnj
...
We don't need infallible allocation here because failure to shrink the
capacity will leave the array unchanged.
2015-11-02 07:53:27 +02:00
c6fdc8821b
Bug 968520 - Explicitly use infallible allocator for ShiftData call in nsTArray::RemoveElementsAt. r=froydnj
...
This call will never fail so this merely makes the intent clear.
2015-11-02 07:53:27 +02:00
ec6faa8712
Bug 1185763 - Part 6: Add fallible variant of r-value nsTArray::AppendElements. r=froydnj
2015-11-02 07:53:26 +02:00
78c64c0cde
Backout 5649b6b8cec3 (bug 1219246) for Linux xpcshell bustage
2015-10-31 13:34:06 -04:00
a5bf910f3f
Bug 1219246 - use UniquePtr instead of nsAutoArrayPtr in xpcom/; r=erahm
2015-10-28 09:50:29 -04:00
4cbe614b32
Bug 1220035 - Fix -Wimplicit-fallthrough warnings in xpcom. r=mccr8
...
xpcom/base/nsDebugImpl.cpp:458:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/ds/nsCheapSets.h:139:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/ds/nsPersistentProperties.cpp:232:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/ds/nsVariant.cpp:360:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/ds/nsVariant.cpp:766:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/ds/nsVariant.cpp:1658:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/ds/nsVariant.cpp:1661:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/glue/nsTextFormatter.cpp:355:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/glue/nsTextFormatter.cpp:362:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/io/nsWildCard.cpp:85:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
xpcom/io/nsWildCard.cpp:401:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-10-29 21:31:32 -07:00
6d8a42769f
Backed out changeset d84d5faa4852 (bug 1201997) for m2 perma failures
...
--HG--
rename : xpcom/glue/tests/gtest/TestNsDeque.cpp => xpcom/tests/TestDeque.cpp
extra : rebase_source : 689453beeca1b317d9b2f57889ba1b133b628821
2015-10-30 15:53:22 +01:00
c6da644f91
Backed out changeset 9390b1ece0ad (bug 1201997)
...
--HG--
extra : rebase_source : 68e7e60c942c44905f4c9bd5f36977a9e8a9c5b0
2015-10-30 15:52:23 +01:00
eb7db9ff93
Backed out changeset 91536bfeff0f (bug 1201997)
...
--HG--
extra : rebase_source : 6f11d67034e876738ecda6f1e32c8e655252660f
2015-10-30 15:52:21 +01:00
4c0ed54e29
Backed out changeset 9093e927a247 (bug 1201997)
...
--HG--
extra : rebase_source : c47b13e37a7756243a68cf15555bf176c0de8600
2015-10-30 15:52:18 +01:00
fe2a36f981
Bug 1201997 - Part 4 - Change size and offset variables to size_t.r=froydn
...
--HG--
extra : rebase_source : 0fd59eb6513e1af0162a9a02c6041182e556b9e7
2015-10-29 19:58:00 +01:00
346dbc9c43
Bug 1201997 - Part 3 - Make internally used methods private. r=froydn
...
--HG--
extra : rebase_source : 0cf8b2f60b98f6853d495b8caad87117b3e5b9cb
2015-10-29 19:57:00 +01:00
c6255f9679
Bug 1201997: Part 2 - Removing unused methods from the nsDeque class. r=froydn
...
--HG--
extra : rebase_source : 1e6115ce85d19a25f59310863365586e669affef
2015-10-29 19:56:00 +01:00
d4bc9904dc
Bug 1201997: Part 1 - Converted compiled test to gtest for nsDeque class. Added tests to test untested methods. r=froydn
...
--HG--
rename : xpcom/tests/TestDeque.cpp => xpcom/glue/tests/gtest/TestNsDeque.cpp
extra : rebase_source : 76fe6e0468ad1e0402a536bcb313bd4bb83f9c17
2015-10-29 19:55:00 +01:00
9a687fd23b
Bug 1217125 - remove pointless includes from nsTHashtable.h; r=mccr8
2015-10-03 00:47:14 -04:00
e6f7a67577
Bug 1174785 - Part 1: Add LogModule, LogModuleManager, and LazyLogModule. r=froydnj
...
The logging interface is moved to xpcom/base, a LogModule wrapper for PR_Log is
added, a thread-safe LogModuleManager is added, and a LazyLogModule class used
to lazily load log modules in a thread-safe manner is added.
--HG--
rename : xpcom/glue/Logging.h => xpcom/base/Logging.h
extra : rebase_source : 89b76664d9477e2c894448cdea4dae1c61f8ca24
2015-10-19 12:22:11 -07:00
ecda739d3e
Bug 1216177 - Remove the remaining nsRefPtr forward declarations; r=froydnj
2015-10-19 12:02:14 -04:00
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00
932187b05a
Bug 1212027 - part 6 - add an IsEmpty method to nsTHashtable; r=erahm
...
It's a little more convenient than checking Count(), and also gives
nsTHashtable the same interface as nsTArray (for this operation, at
least), which seems worthwhile.
2015-10-07 23:31:17 -04:00
0a799593e9
Bug 1207245 - part 5 - rename template parameters for nsRefPtrHashtable; r=ehsan
...
Having a template parameter conflict with a global name is terribly
inconvenient, so let's try to avoid that by renaming the 'RefPtr'
template parameter to something else.
2015-10-12 22:40:08 -04:00
6ab3d4ccd1
Bug 1213130 - Make several string function to accept char16ptr_t instead of char16_t*, and remove redundant overloads. rs=froydnj
...
--HG--
extra : source : d2dbd4e5316efb888335c92950d32ce77abc41e5
2015-10-10 12:19:23 +11:00
7ba467bc22
Bug 1186745 part 6 - Fix event leak when using NS_DispatchToCurrentThread. r=froydnj
...
--HG--
extra : source : c8159664670c96e6cfa4c856d6eb14bb9495cd6f
2015-10-06 13:00:59 +11:00
98d15627f8
Bug 1186745 part 1 - Add LeakRefPtr for pointer leaking by default. r=froydnj
...
This class can be used instead of raw pointer for a sound leaking-by-default
behavior. Also it could take advantage of move semantic check in the future.
--HG--
extra : source : 6bf72b4eaa92b13d42b547d8aeee677489a4d3e2
2015-10-06 13:00:59 +11:00
f72bee4d5f
Bug 1209351 (part 1) - Add an overloading of nsTHashTable::RemoveEntry() that takes an already-found entry. r=froydnj.
...
--HG--
extra : rebase_source : 9e48b42e9bd59732e2c2a6c436e9ee258d5c1cd9
2015-09-24 16:12:38 -07:00
b98e01e02a
Bug 1210871 - don't use reinterpret_cast in nsTHashtable.h; r=erahm
...
We don't need to reinterpret_cast when casting from void*, and we don't
need to reinterpret_cast when we're casting up and down a class
hierarchy. static_cast takes care of those cases just fine, and doesn't
scare the reader into thinking that nsTHashtable is doing something
unusual.
2015-10-02 20:32:15 -04:00
1d312920f4
Backed out 6 changesets (bug 1186745) for android Cpp failures
...
Backed out changeset 237a6acf0709 (bug 1186745)
Backed out changeset 7b530871783a (bug 1186745)
Backed out changeset 73f73b531fc8 (bug 1186745)
Backed out changeset e36909748ddf (bug 1186745)
Backed out changeset 3a31df8787f0 (bug 1186745)
Backed out changeset df9cb8f5f0a5 (bug 1186745)
2015-10-02 10:35:09 -07:00
863594b840
Bug 1186745 part 6 - Fix event leak when using NS_DispatchToCurrentThread. r=froydnj
...
--HG--
extra : source : a0baaf79582846e447014b2e933266c3150941aa
2015-10-03 00:18:24 +10:00
4dad63f727
Bug 1186745 part 1 - Add LeakRefPtr for pointer leaking by default. r=froydnj
...
This class can be used instead of raw pointer for a sound leaking-by-default
behavior. Also it could take advantage of move semantic check in the future.
--HG--
extra : source : 47cd2c22bafc8d4bb1c7e1dce3b45517aaec199f
2015-10-03 00:18:24 +10:00
30e17cfd82
Bug 1196461 - De-duplicate strings in heap snapshot core dumps; r=shu,jimb
...
This changeset replaces all of the
// char16_t[]
optional bytes someProperty = 1;
one- and two-byte string properties in the CoreDump.proto protobuf definition
file with:
oneof {
// char16_t[]
bytes someProperty = 1;
uint64 somePropertyRef = 2;
}
The first time the N^th unique string is serialized, then someProperty is used
and the full string is serialized in the protobuf message. All following times
that string is serialized, somePropertyRef is used and its value is N.
Among the other things, this also changes JS::ubi::Edge::name from a raw pointer
with commented rules about who does or doesn't own and should and shouldn't free
the raw pointer to a UniquePtr that enforces those rules rather than relying on
developers reading and obeying the rules in the comments.
2015-09-30 16:03:31 -07:00
b62a707f2b
Bug 1209969 - remove prlock.h include from nsBaseHashtable.h; r=erahm
...
nsBaseHashtable.h doesn't use PRLock.
2015-09-30 00:51:28 -04:00
deb2270515
Bug 1054756, part 5 - Remove Class::convert.
...
--HG--
extra : commitid : 6KCxWrCseSZ
extra : rebase_source : 63f3cd6ec1ade43c732ffd9b661fe6f2dca9eb4b
2015-03-20 16:28:59 -05:00
c096566a7e
Back out 6 changesets (bug 1186745) for cpptest failure in runnable_utils_unittest, nrappkit_unittest, test_nr_socket_unittest
...
Backed out changeset c6142b815de0 (bug 1186745)
Backed out changeset d8f740ef2430 (bug 1186745)
Backed out changeset edc0b56d81fa (bug 1186745)
Backed out changeset 383f8ac033ea (bug 1186745)
Backed out changeset ce960a661987 (bug 1186745)
Backed out changeset 3e9783023fb2 (bug 1186745)
--HG--
extra : rebase_source : 4681d6abaaa927ddb863f944efc87e6c6f6c2e26
2015-09-28 19:05:02 -07:00
e26e72c529
Bug 1186745 part 6 - Fix event leak when using NS_DispatchToCurrentThread. r=froydnj
...
--HG--
extra : source : 839c394ca2362db534c9a12b14be3a9f3f5d6ff5
2015-09-29 09:28:22 +10:00
661f0a0891
Bug 1186745 part 1 - Add LeakRefPtr for pointer leaking by default. r=froydnj
...
This class can be used instead of raw pointer for a sound leaking-by-default
behavior. Also it could take advantage of move semantic check in the future.
--HG--
extra : source : 3dbd000739dc0ea214a2292e3983469e41e99686
2015-09-29 09:28:22 +10:00
b19d88b060
Backed out 7 changesets (bug 1206168, bug 1177318, bug 1054756) for hazard build failures CLOSED TREE
...
Backed out changeset e892727a373a (bug 1206168)
Backed out changeset 6c93d1044b7e (bug 1054756)
Backed out changeset 105433ce195b (bug 1054756)
Backed out changeset 13128a88f2b9 (bug 1054756)
Backed out changeset c250abf4fd17 (bug 1054756)
Backed out changeset fc9fef646a97 (bug 1054756)
Backed out changeset c8897f109a08 (bug 1177318)
2015-09-23 12:31:19 -07:00
54e92d9beb
Bug 1054756, part 5 - Remove Class::convert.
...
--HG--
extra : commitid : KrjkP1flM3c
extra : rebase_source : 8c367e3158528e92ac8ebc51521d32472f1e5bb1
2015-03-20 16:28:59 -05:00
71920a9550
Bug 1207030 - Enable -Wshadow flag in more directories that have no -Wshadow warnings. r=glandium
2015-09-22 21:39:03 -07:00
647b520991
Bug 1201135 - Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}. r=mccr8.
...
--HG--
rename : xpcom/glue/pldhash.cpp => xpcom/glue/PLDHashTable.cpp
rename : xpcom/glue/pldhash.h => xpcom/glue/PLDHashTable.h
extra : rebase_source : 06b9d30db96ed78500fd44d9c0b51609103508a3
2015-09-15 20:49:53 -07:00
0dbaae1ce2
Bug 1204403 - Fix -Wshadow warnings in xpcom. r=mccr8
2015-09-07 23:56:16 -07:00
28c419dcc1
Bug 1123237 - Part 10. Expose SwapElements from nsBaseHashtable. r=nfroyd
2015-09-16 10:31:13 +08:00
2ee4fd783b
Bug 1121760 (part 6) - Move all remaining PL_DHash*() functions into PLDHashTable. r=poiru.
...
--HG--
extra : rebase_source : 3cdc975507170d783b02d70f7c7d95c6bf2e1bcd
2015-09-14 14:23:47 -07:00
63e79d16db
Bug 1121760 (part 5) - Remove PL_DHashMarkTableImmutable(). r=poiru.
...
--HG--
extra : rebase_source : 8617d7f3d8034832321145789cc0108f6a0878df
2015-09-14 14:23:27 -07:00
ecf0b741cd
Bug 1121760 (part 4) - Remove PL_DHashTableRawRemove(). r=poiru.
...
--HG--
extra : rebase_source : 9989b2171b8213512ce779415812fa04471fde22
2015-09-14 14:23:26 -07:00
59683492e5
Bug 1121760 (part 3) - Remove PL_DHashTableRemove(). r=poiru.
...
--HG--
extra : rebase_source : c34d693de4aca45f2ea05c2767c8b1007c89df29
2015-09-14 14:23:24 -07:00
479244f7c9
Bug 1121760 (part 2) - Remove PL_DHashTableAdd(). r=poiru.
...
--HG--
extra : rebase_source : 41eb939bfb5c925cba58b1af57abce9a4e5fdb30
2015-09-14 14:23:12 -07:00
fcfdd8f54b
Bug 1121760 (part 1) - Remove PL_DHashTableSearch(). r=poiru.
...
--HG--
extra : rebase_source : 770e1f49a451ecbadd778e071b204611e27cf701
2015-05-21 00:34:25 -07:00
5446225d17
Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
...
This leaves alone the AppendElement methods.
2015-09-15 15:30:44 -07:00
0097c41e01
Bug 1201190 - Part 3: Mark every consumer of GUARD_OBJECT as MOZ_RAII, r=ehsan
2015-09-12 16:53:33 -04:00
1eaae658aa
Bug 1156802 - Part 2: Remove all explicit move constructors, r=ehsan
2015-09-12 12:34:45 -04:00
de8fceb34d
Bug 1202526 (part 1) - Add PLDHashTable::RemoveEntry(). r=froydnj.
...
This patch also consolidates the shrink handling so it's now entirely within
ShrinkIfAppropriate().
2015-09-07 19:20:12 -07:00
ba9de6a2f7
Backed out changeset f5b2a11c64c9 (bug 1201271) for bustage
2015-09-09 15:56:21 -07:00
3e590f4e78
Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
...
This leaves alone the AppendElement methods.
2015-09-09 15:39:10 -07:00
90583f7067
Backed out 10 changesets (bug 1123237) for hazard build failures and Windows test failures
...
CLOSED TREE
Backed out changeset 9c26b3b787f8 (bug 1123237)
Backed out changeset 1fcec0dc93d5 (bug 1123237)
Backed out changeset 390033ceebb6 (bug 1123237)
Backed out changeset e8a1845876d6 (bug 1123237)
Backed out changeset 714ec40715fa (bug 1123237)
Backed out changeset 5ed952e011c3 (bug 1123237)
Backed out changeset c785df6c0cdf (bug 1123237)
Backed out changeset d69e2d195a24 (bug 1123237)
Backed out changeset 1f328807da1d (bug 1123237)
Backed out changeset a1546857dce9 (bug 1123237)
2015-09-05 13:49:39 -07:00
ab9d4cc8c0
Bug 1123237 - Part 10. Expose SwapElements from nsBaseHashtable. r=nfroyd
2015-09-06 00:13:26 +08:00
f8b8e77b55
Bug 1199400 - Part 1: Use CheckedInt when growing nsDeque capacity. r=froydnj
2015-09-03 13:33:46 -07:00
42bed38c5e
Bug 1199400 - Part 0: Remove unused nsDequeIterator. r=froydnj
2015-09-04 15:04:58 -07:00
13445609b8
Backed out changeset 351d5f864f9e for not compiling.
2015-09-04 09:52:24 -07:00
cc00f8d5c9
Bug 1201271 - Warn about unused results for more methods of nsTArray. r=froydnj
...
This leaves alone the AppendElement methods.
2015-09-04 09:45:44 -07:00
f44287005f
Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium.
...
The patch removes 455 occurrences of FAIL_ON_WARNINGS from moz.build files, and
adds 78 instances of ALLOW_COMPILER_WARNINGS. About half of those 78 are in
code we control and which should be removable with a little effort.
--HG--
extra : rebase_source : 82e3387abfbd5f1471e953961d301d3d97ed2973
2015-08-27 20:44:53 -07:00
523787b5ca
Bug 1181907 (Part 1) - Make it possible to use nsGenericHashKey with free functions. r=heycam
2015-08-26 18:19:31 -07:00
1416e566de
Bug 1198124 - Enable -Wshadow in directories that have no -Wshadow warnings. r=glandium
2015-08-25 09:14:38 -07:00
6b261a1c9e
Bug 1197563 - Polyfill __func__ for MSVC 2013 and earlier. r=froydnj
2015-08-20 23:39:18 -07:00
ba173ae5e4
Bug 1197316 - Remove PR_snprintf calls in xpcom/. r=froydnj
2015-08-22 17:57:52 -07:00
9960d37ffb
Bug 1196050 - Replace NSCAP_Zero usage with decltype(nullptr). r=froydnj
...
--HG--
extra : source : 9c567ed00fcf2433e484325bab9a18322718b0da
2015-08-20 10:30:10 +10:00
f29bc4307b
Bug 1010756 - Helpful errors for using nsCOMPtr on non-XPCOM types; r=froydnj
2015-08-12 18:43:10 +03:00
5b76d8f3b7
Bug 1181443 (part 3, attempt 2) - Remove nsTHashtable::EnumerateEntries(), which is no longer used. r=froydnj.
...
--HG--
extra : rebase_source : 232b65e93556a311efaf1f2e0b1aee0449b3838d
2015-07-23 02:37:26 -07:00
3b0a318c70
Bug 1192230 - clean up reference-counting in xpcom/; r=erahm
2015-07-01 12:27:43 -04:00
0527ccb54c
Bug 1185763 - Part 4: Swap elements if possible in r-value version of nsTArray::AppendElements. r=froydnj
2015-08-11 08:29:46 -07:00
2b4a52cf2e
Bug 1185763 - Part 3: Rename nsTArray::MoveElementsFrom to AppendElements. r=froydnj
2015-08-11 08:29:46 -07:00
5528f2d07d
Bug 1185763 - Part 2: Remove non-rvalue version of nsTArray::MoveElementsFrom. r=froydnj
2015-08-11 08:29:46 -07:00
deb1dc5d6b
Backout 04a196339ca4 (bug 1181443, part 3) so that bug 1182961's patches can be backed out.
...
--HG--
extra : rebase_source : c2f49d0bfd6a82b35eeed73c0a88f60661c1defd
2015-08-06 16:28:13 -07:00
2c850da1f5
Bug 1181443 (part 3) - Remove nsTHashtable::EnumerateEntries(), which is no longer used. r=froydnj.
...
--HG--
extra : rebase_source : f16a883725371524f0c63d72b09ae69df688673f
2015-07-23 02:37:26 -07:00
80ea0a3e53
Bug 1190823 - Move OwningNonNull.h to xpcom/base/; r=froydnj
...
--HG--
rename : dom/bindings/OwningNonNull.h => xpcom/base/OwningNonNull.h
2015-08-05 15:28:27 +03:00
d98d14fa1e
Bug 1189156 (part 4) - Don't use enumeration style for nsBaseHashtable::SizeOf{In,Ex}cludingThis(). r=erahm,jfkthame.
...
After this change, we have ShallowSizeOf{In,Ex}cludingThis(), which don't do
anything to measure children. (They can be combined with iteration to measure
children.)
--HG--
extra : rebase_source : f98420176f50990bbc5a25e35788328154cfeb00
2015-07-30 21:19:57 -07:00
1059c1de13
Bug 1189156 (part 2) - Don't use enumeration style for nsTHashtable::SizeOf{In,Ex}cludingThis(). r=erahm.
...
After this change, we have ShallowSizeOf{In,Ex}cludingThis(), which don't do
anything to measure children. (They can be combined with iteration to measure
children.)
And we still have the existing single-arg SizeOf{In,Ex}cluding() functions,
which work if the entry type itself defines SizeOfExcludingThis().
--HG--
extra : rebase_source : f93de9b789c21b1b148bed9de795f663f77c9dd9
2015-07-29 01:50:52 -07:00
16407ea724
Bug 1127618 - make push caches work in e10s. r=mcmanus r=froydnj IGNORE IDL
...
--HG--
extra : rebase_source : 24dd37c6eaec83a1776d77632b97106e8abb8015
2015-07-31 13:50:08 -07:00
2d56c1f52e
Bug 1189156 (part 1) - Don't use enumeration style for PLDHashTable::SizeOf{In,Ex}cludingThis(). r=froydnj.
...
After this change, we have PLDHashTable::ShallowSizeOf{In,Ex}cludingThis(),
which don't do anything to measure children. (They can be combined with
iteration to measure children.)
This patch also removes the PL_DHashTableSizeOf{In,Ex}cludingThis() functions.
They're not necessary because the methods can be used instead.
Finally, the patch deliberately converts some SizeOfExcludingThis() calls to
SizeOfIncludingThis(). These are all done on heap pointers so this change is
valid.
--HG--
extra : rebase_source : b1d51096a8e7dcac29d7efd92e28938836ff5481
2015-07-29 22:28:20 -07:00
87b80f8c66
Bug 1188745 - Rename nsTArray::SizeOfExcludingThis() as ShallowSizeOfExcludingThis(). r=froydnj.
...
This makes it clearer that, unlike how SizeOf*() functions usually work, this
doesn't measure any children hanging off the array.
And do likewise for nsTObserverArray.
--HG--
extra : rebase_source : 6a8c8d8ffb53ad51b5773afea77126cdd767f149
2015-07-28 23:24:24 -07:00
99b2a37529
Bug 108603 - Remove NS_IMPL_QUERY_INTERFACE_INHERITED0. r=mccr8, r=froydnj
...
--HG--
extra : rebase_source : 98a86a1ff5d023aa74800de8feb1cfe1846edf03
2015-07-24 12:13:00 -04:00
97b9240b34
Bug 1188696 - Hoist nsRefPtr.h into MFBT. r=froydnj
2015-07-29 10:44:59 -07:00
4762225b99
Bug 1188696 - Remove the XPCOM dependencies in nsRefPtr.h. r=froydnj
2015-07-29 10:44:58 -07:00
c6d5ee54fb
Bug 1179787 - part 2 - add template logic for smart pointer template arguments in NS_NewRunnableMethod*; r=botond
2015-07-02 11:17:49 -04:00
8ddd161b85
Bug 1179787 - part 1 - forward StorensRefPtrPassByPtr's constructor argument; r=botond
...
StorensRefPtrPassByPtr is currently used for storing reference-counted
types passed as T* template arguments to NS_NewRunnableMethodWith*.
We'd also like to use it to store nsRefPtr<T> template arguments. While
it could be used in its current form, it'd be better for its constructor
to support forwarding, so that something like:
NS_NewRunnableMethodWithArg<nsRefPtr<T>>(..., nsRefPtr<T>(local));
doesn't cause unnecessary reference counting.
2015-07-02 11:05:52 -04:00
fb6b2747d5
Bug 1180017 - Fix up the badly-horked backout and re-land.
...
CLOSED TREE
--HG--
extra : amend_source : 0b7ac18429b248cf05cfe33f6b2f6efdf1602c38
extra : histedit_source : bdb11dafa100809ec17491e5711fb0b507e023c6%2C5e4134650a804859dc8b3078688fa4655052263f
2015-07-29 12:31:47 -04:00
4e8fc0bdcb
Bug 1180017 - Give GCCellPtr is<T> and to<T> methods, replacing isFoo and toFoo methods. Fix callers. r=terrence
2015-07-03 15:06:23 -07:00
25a2a75a56
Backed out changeset 465793bc6fcf (bug 1180017) for suspicion of causing bug 1188799
2015-07-29 15:27:12 +02:00
1febc8154e
Bug 1188431 - Fixed length argument handling in char16ptr_t variant of NS_ConvertUTF16toUTF8 constructor. r=nfroyd
2015-07-29 12:26:40 +02:00
ff7cc06ef6
Bug 1180017: Give GCCellPtr is<T> and as<T> methods, replacing isFoo and toFoo methods. Fix callers. r=terrence
...
--HG--
extra : rebase_source : 4a381c5d8427ad2995426e65c69af1597b1557c2
2015-07-07 09:52:01 -07:00
7a81d59cb2
Bug 1188203 - Fix more constructors in XPCOM; r=froydnj
2015-07-28 12:24:37 -04:00
6dad638eb2
Bug 1186780: Replace EnumerateRead with new iterators in cycle collection code. r=mccr8
2015-07-26 19:29:52 -07:00
dbc67380bd
Bug 1187767 - Ensure PLDHashTable's generation is always updated when the entry store is modified. r=froydnj.
...
--HG--
extra : rebase_source : e70d253257eac422a454d20de0fb94d2ac736e84
2015-07-26 19:57:23 -07:00
c9839dd8f9
Backed out changeset 1ca5723f69d4 (bug 1186780) for dom crashes
2015-07-27 08:01:09 +02:00
6758447d5d
Bug 1186780: Replace EnumerateRead with new iterators in cycle collection code. r=mccr8
2015-07-26 19:29:52 -07:00
10da8efa1c
Bug 1187197 (part 3) - Convert pldhash.{cpp,h} to C++ style comments. r=froydnj.
...
--HG--
extra : rebase_source : 4615862ad586e24050a6f5571b8d21689ba3fdf3
2015-07-23 23:13:11 -07:00
42e338fc52
Bug 1187197 (part 2) - Put function return types on their own line. r=froydnj.
...
--HG--
extra : rebase_source : 58e81c134c321faa28e6ab46ed4c6c583a846ab5
2015-07-23 23:13:10 -07:00
49a82c55c8
Bug 1187197 (part 1) - Move comments from PL_DHashTable* functions to the equivalent methods. r=froydnj.
...
Because the PL_DHashTable* functions will go away eventually (bug 1121760).
--HG--
extra : rebase_source : 6bd5aedf71c162102f4a7e06347c868d5dd78dbd
2015-07-23 21:43:48 -07:00
660f381a2f
Bug 1159433 - Part 4: Mark nsTAutoString_CharT and nsAutoArrayBase as non-memmovable; r=froydnj
2015-07-24 19:15:40 -04:00
66a04cf80f
Bug 1159433 - Part 3: Make nsTArray_CopyChooser only accept memmovable argument types by default; r=froydnj
2015-07-24 19:15:23 -04:00
69cc6fcb31
Bug 1123907 - Part 2: Add MOZ_NEEDS_NO_VTABLE_TYPE to Attributes.h, and use it to verify the EntryType argument of nsTHashtable; r=ehsan
2015-07-24 19:14:09 -04:00
658cb19c1f
Bug 1187201 - Add char16 wrapper constructor for NS_ConvertUTF16toUTF8 in external string API. r=froydnj
...
--HG--
extra : source : 0facdb6085164a2f5a1674f795fc7a2df4332ca3
2015-07-24 23:06:50 +10:00
4db7ee5707
Bug 1185589 - Properly handle self-assignment in nsTArray::operator=. r=mccr8
2015-07-21 09:42:58 -07:00
4ade448a75
Bug 1185399 (part 2) - Remove macros from pldhash.cpp. r=froydnj.
2015-07-20 17:15:00 -07:00
954e563acc
Bug 1185399 (part 1) - Remove macros from pldhash.h. r=froydnj.
2015-07-20 17:06:38 -07:00
ee4f5ba9fb
Bug 1185470: Remove 'Get' prefixes from hashtable iterator methods. r=froydnj
2015-07-20 20:21:28 +08:00
819a9fd767
Bug 1182516 - Fix mid-air conflict with 3fd2ab6cb762 on a CLOSED TREE. r=bustage
...
--HG--
extra : commitid : Adcu7H4oTQG
2015-07-15 18:08:25 -04:00
bf12e17af3
Bug 1182277, don't leak when using nsAutoTArray inside nsTArray, r=nfroyd
...
--HG--
extra : rebase_source : f2ef5f9be86461490ad87e4862e1f77f88b33ade
2015-07-14 17:05:10 +03:00
4aa7305199
Bug 1180122 - Make Chaos Mode affect PLDHashTable's iterators. r=froydnj.
...
This makes the code less elegant, but that's unavoidable.
--HG--
extra : rebase_source : 585034bcd8383102669caf2378d705234410d8a9
2015-07-03 00:27:27 -07:00
a8939590de
Bug 1182996 - Fix and add missing namespace comments. rs=ehsan
...
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
2015-07-13 08:25:42 -07:00
fafaf07b01
Bug 1028132 - Remove mozilla::HasDangerousPublicDestructor<T>. r=mccr8
2015-07-07 18:45:00 -04:00
d367971294
Bug 1181445 (part 11) - Use nsBaseHashTable::Iterator in xpcom/glue/. r=froydnj.
...
--HG--
extra : rebase_source : 5b6fe9813c08627f626fa8da66a8e724baa274aa
2015-07-09 16:54:59 -07:00
240d180d7f
Bug 1181445 (part 5) - Use nsTHashTable::Iterator in nsTHashtable.h. r=mccr8.
...
This is a particularly nice example of how iterators can be so much nicer than
Enumerate()-style functions:
1 file changed, 4 insertions(+), 33 deletions(-)
--HG--
extra : rebase_source : 757f75b90cb4c624143c236f9743edf158f72d66
2015-07-09 16:54:59 -07:00
b37d03af49
Bug 1181445 (part 1) - Implement iterators for nsTHashtable and nsBaseHashtable. r=froydnj.
...
nsBaseHashtable has both EnumerateRead() and Enumerate(). A comment claims that
the latter locks the table, but this is false, so I removed the comment. Other
than that the only notable difference between them is that they have slightly
different types for dealing with values (|UserDataType| vs |DataType&|) so I've
implemented both GetUserData() and GetData(), allowing either type to be used.
--HG--
extra : rebase_source : 9d61cc8f4c14082c9f1939ff3ced2b697e043f42
2015-07-07 20:47:59 -07:00
f5e826fd1d
Bug 1155059: Patch 4 - invoke NS_ASSERTION if DispatchToMainThread fails to get MainThread ptr r=froydnj
2015-07-09 23:21:46 -04:00
c87c478f4f
Bug 1155059: Patch 1&2 - Convert Dispatch() and friends to already_AddRefed<> r=froydnj
...
Modify Dispatch IDL and code to deal with MSVC issues with overloaded templates r=froydnj
2015-07-09 23:21:46 -04:00
7fdec3adb1
Bug 833117 - Replace g_slice_set_config() with G_SLICE environment variable. r=nfroyd,r=karlt
...
Using g_slice_set_config() fails with newer glib because the slice allocator
now has a static constructor that runs when glib is loaded, consequently
emitting a noisy error message which confuses people into believing it's the
root of their problems.
The only way left to force the slice allocator to use "system" malloc (in
practice, jemalloc) is to set the G_SLICE environment variable to
always-malloc, and that needs to happen before glib is loaded.
Fortunately, the firefox and plugin-container executables don't depend on
glib. Unfortunately, webapprt does, so the problem remains for web apps
running through it. xpcshell and other executables that depend on libxul
directly (as opposed to loading it dynamically) are not covered either.
2015-07-10 09:56:05 +09:00
f976bf5495
Bug 1179071 - Merge RemovingIterator into Iterator. r=froydnj.
...
The original motivation for the Iterator/RemovingIterator split was that
PLDHashTable Checker class would treat them differently. But that didn't end up
happening (see bug 1131308). So this patch merges them. This is a small code
size win now but it will become bigger when I add iterators to nsTHashTable and
nsBaseHashtable.
The only complication is that PLDHashTable::Iter() is now non-const, which is
a problem if you use it in a const method. So I added PLDHashTable::ConstIter()
which is used in just two places. It's a bit of a hack -- effectively a
const_cast -- but I don't think it's too bad.
2015-07-06 22:02:26 -07:00
30fedff9e1
Bug 968520 - Add nsTArray::Assign. r=froydnj
2015-07-07 11:27:03 -07:00
b6a6d26147
Bug 1180072 - Remove PL_DHashTableEnumerate(). r=froydnj.
...
It's no longer used, and the Iterator classes are much nicer. Yay.
2015-06-18 22:19:10 -07:00
bdb164e9fd
Bug 1131308 (part 1) - Improve PLDHashTable's internal checking. r=froydnj.
...
--HG--
extra : rebase_source : 7801b437c2b9a82de90914a67e80acabba81570b
2015-05-20 23:11:35 -07:00
4a9000e192
Bug 1131308 (part 0) - Fix minor problems with RemovingIterator. r=froydnj.
...
- Its move constructor was moving |aOther.mTable| instead of |aOther|. This
meant that |aOther| wasn't being zeroed out appropriately.
- test_pldhash_RemovingIterator() was testing Iterator's move constructor
instead of RemovingIterator's move constructor, due to a copy/paste
mistake.
--HG--
extra : rebase_source : 1f4880893875218ddb155c76d329e84d884c0432
2015-07-05 17:49:44 -07:00
059c658d95
Bug 1179657 - Remove PL_DHASHMETER. r=froydnj.
...
Because it's totally busted and not a very good way of getting that kind of
statistics.
2015-07-01 22:59:53 -07:00
Seth Fowler
Emilio Cobos Álvarez
Tom Tromey
Chris Peterson
Thomas Zimmermann
Manish Goregaokar
Nathan Froyd
Jan de Mooij
Andrew McCreight
Aidin Gharibnavaz
Kyle Huey
Nomis101
Gerald Squelart
Nicholas Nethercote
L. David Baron
Eric Rahm
Cameron McCormack
Ting-Yu Lin
Bob Owen
Aryeh Gregor
Carsten "Tomcat" Book
Jean-Yves Avenard
Andreas Pehrson
Nathan Froyd
Jonathan Watt
Wes Kocher
Botond Ballo
Vladimir Vukicevic
Gregory Szorc
Birunthan Mohanathas
Phil Ringnalda
Sylvestre Ledru
Jeff Muizelaar
Gabriele Svelto
Terrence Cole
Olli Pettay
Jeff Walden
sajitk
Nathan Froyd
Ehsan Akhgari
Xidorn Quan
Nick Fitzgerald
Jason Orendorff
Kan-Ru Chen
Michael Layzell
Andrew McCreight
Miko Mynttinen
Nicholas Hurley
Bobby Holley
Ryan VanderMeulen
Jim Blandy
Jacek Caban
Benoit Girard
Randell Jesup
Mike Hommey