Desktop gtest creates minidumps in the current working directory. That is
problematic on Android, since the test app's cwd may not be writable, or
may not be readable by the test harness. This patch allows the test harness
to specify an alternate minidump path with environment variable
MOZ_GTEST_MINIDUMPS_PATH.
Differential Revision: https://phabricator.services.mozilla.com/D26833
--HG--
extra : moz-landing-system : lando
nsDisplayTableBackgroundColor inherits from nsDisplayBackgroundColor,
and both display item types are mapped to background_color property.
However, nsDisplayTableBackgroundColor is not animated on the
compositor, so we shouldn't add animations for TYPE_TABLE_BACKRGOUND_COLOR.
It seems the test case has a weird timeout in Android test-verify-opt. I
checked the live.log and the tests are passed, but got a final time-out.
It is not related to our change because this still happens if we skip
the test, and I saw that other intermittent bugs have the same issue.
Differential Revision: https://phabricator.services.mozilla.com/D24780
--HG--
extra : moz-landing-system : lando
If mozbuild parsing fails due to a missing file (eg: a file not existing
in UNIFIED_SOURCES), then no Makefiles are written out, but
config.status exists. This would cause mozbuild to think that configure
doesn't need to run, and rely on make to perform the backend-out-of-date
check in rebuild-backend.mk. Unfortunately since no Makefiles were
written, the make command fails immediately and no attempt is made to
re-create the backend. Note that this is only a problem if the first
mozbuild parsing from a clobber build fails, otherwise there is
typically a top-level Makefile from a previous build to call into (at
which point make can determine it is out-of-date, and re-invoke itself).
The fix is to have the RecursiveMake backend re-use the same logic that
was introduced into mozbuild for alternate backends, and remove
rebuild-backend.mk. This way, mozbuild can always determine if the
backend needs to be regenerated, even if the initial parsing failed.
Test code was also relying on rebuild-backend.mk to generate the
TestBackend, but moving backend_out_of_date() into MozbuildObject allows
this code to be shared.
Differential Revision: https://phabricator.services.mozilla.com/D26262
--HG--
rename : build/gen_test_backend.py => python/mozbuild/mozbuild/gen_test_backend.py
extra : moz-landing-system : lando
With this change, the use of SlashIsInvalid at the top of
GeneralParser<>::classMember obliges us to use the same modifier when getting
the same token later (in both classMember and propertyName).
Differential Revision: https://phabricator.services.mozilla.com/D26928
--HG--
extra : moz-landing-system : lando
On Android, update mozilla gtest logging so that logging appears in the Android logcat.
Also, when MOZ_GTEST_LOG_PATH is defined in the environment, create the named file
and direct logging to that file. Android gtest will use this to collect gtest logging from
the device and copy it to the test log.
Differential Revision: https://phabricator.services.mozilla.com/D26610
--HG--
extra : moz-landing-system : lando
Previously this functionality created a CryptoTask to do this work, but that
would cause a new thread to be created for each list of intermediates. This was
slow both because of all of the threads and because they could be scheduled
while other work was happening. Moving these tasks to the low-priority event
queue for threads in the certificate verification thread pool means no new
threads are created and the work only happens when these threads are idle
anyway.
Differential Revision: https://phabricator.services.mozilla.com/D26630
--HG--
extra : moz-landing-system : lando
We don't need an additional array just for byte reordering, replace
it with in-place processing.
Testcase are modified because the LookupCacheV4::Build API now clears the
input parameter.
Differential Revision: https://phabricator.services.mozilla.com/D26861
--HG--
extra : moz-landing-system : lando
Here is the flow how prefixes are handled during an V4 update:
1. Prefixes are received from Safe Browsing update, stored in ProtocolBuffer
2. Copy the prefixes from ProtocolBuffer to TableUpdate structure
3. Prefixes in TableUpdate are merged with local prefixes (stored in LookupCacheV4)
4. Merged prefixes are processes by PrefixSet to generate the in-memory prefix
set data structure (MakePrefixSet).
In this patch, we free the prefixes stored in TableUpdate right after step3.
This reduces the peak memory used during an update (peak happens in step 4).
Differential Revision: https://phabricator.services.mozilla.com/D26860
--HG--
extra : moz-landing-system : lando
This renames addModifierException -> allowGettingNextTokenWithAllowRegExp. The
new name is clunky, but the code is simpler.
Adding DoNotWant mode in condExpr() and classMember() is both what we actually
meant all along and necessary. It is necessary because the new assertion scheme
is actually pickier; calling matchToken with AllowDiv when we already called
allowGettingNextTokenWithAllowRegExp now flunks the assertion.
Differential Revision: https://phabricator.services.mozilla.com/D25311
--HG--
extra : moz-landing-system : lando
propertyName() has three callers, corresponding to ObjectLiteral,
ObjectBindingPattern, and ClassDeclaration. In each case the next token must be
neither Div nor RegExp.
Differential Revision: https://phabricator.services.mozilla.com/D25821
--HG--
extra : moz-landing-system : lando
This helps us get rid of several uses of addModifierException, as the next few
patches show. It will also be used to implement ASI for fields. (In most
contexts, the next token after a missing semicolon needs to be scanned in
SlashIsRegExp mode. In a ClassBody it's different; the next token must be
neither Div nor RegExp in a syntactically valid program.)
Differential Revision: https://phabricator.services.mozilla.com/D25819
--HG--
extra : moz-landing-system : lando
Also renames ModifierException::OperandIsNone -> SlashIsRegExpOK, although it
doesn't matter too much, as its days are numbered.
Differential Revision: https://phabricator.services.mozilla.com/D25818
--HG--
extra : moz-landing-system : lando
It turns out to be vestigial. The comment being deleted here says,
"Comma/semicolon cases are also gotten as operators (None)", but this is no
longer true. Both are scanned as Operand now; and so are RightCurly,
RightParen, and the various other tokens listed in yieldExpression(), for which
an exception was once necessary.
Differential Revision: https://phabricator.services.mozilla.com/D25310
--HG--
extra : moz-landing-system : lando
In particular, this enables Marionette in local Fennec builds, which
were the only place it wasn't enabled by default. (Automation builds
all enabled Marionette.) That default is getting in the way of the
Performance Team (and others!) testing GeckoView-based products
easily.
Differential Revision: https://phabricator.services.mozilla.com/D26815
--HG--
extra : moz-landing-system : lando
I don't think there's a point in making <link> elements match :visited, and it's
an issue for Chrome docs because some chrome code can run before we have a
profile.
Make the already-existent workaround for localization links work more generally.
There's no interop across browsers here anyhow:
https://github.com/w3c/csswg-drafts/issues/3817
tracks that.
Differential Revision: https://phabricator.services.mozilla.com/D26910
--HG--
extra : moz-landing-system : lando
Geoff Brown
Marcos Cáceres
Paul Bone
Daosheng Mu
rdalal
Dorel Luca
Coroiu Cristina
Emilio Cobos Álvarez
Mark Hammond
Boris Chiou
Andrea Marchesini
Boris Zbarsky
Mike Shal
Jason Orendorff
Christian Holler
Steve Fink
Dana Keeler
Ashley Hauck
Andrew Swan
dlee
Shane Caraveo
Edwin Gao
Kartikaya Gupta
Karl Tomlinson
Marian Raiciof
Olli Pettay
Tim Nguyen
Nick Alexander
Aki Sasaki
Chris Manchester
Marco Bonardo